[GitHub] sijie commented on a change in pull request #1209: Added MockBookKeeper for unit tests

sijie commented on a change in pull request #1209: Added MockBookKeeper for unit tests URL: https://github.com/apache/bookkeeper/pull/1209#discussion_r170844210 ## File path: bookkeeper-server/src/test/java/org/apache/bookkeeper/client/MockBookKeeper.java ## @@ -0,0

[GitHub] eolivelli opened a new pull request #1212: Add Jia Zhai and Enrico Olivelli to PMC list

eolivelli opened a new pull request #1212: Add Jia Zhai and Enrico Olivelli to PMC list URL: https://github.com/apache/bookkeeper/pull/1212 This is an automated message from the Apache Git Service. To respond to the

[GitHub] sijie commented on issue #1192: BP-29 (task 3): use metadata service uri for constructing registration client

sijie commented on issue #1192: BP-29 (task 3): use metadata service uri for constructing registration client URL: https://github.com/apache/bookkeeper/pull/1192#issuecomment-369027225 @ivankelly addressed your comments regarding `regClient` and `MetadataDrivers`

[GitHub] sijie commented on issue #1213: Please delete old releases from mirroring system

sijie commented on issue #1213: Please delete old releases from mirroring system URL: https://github.com/apache/bookkeeper/issues/1213#issuecomment-369030554 thanks @sebbASF looking into it. This is an automated message from

[GitHub] reddycharan commented on a change in pull request #1201: ISSUE #570: Entrylog per ledger

reddycharan commented on a change in pull request #1201: ISSUE #570: Entrylog per ledger URL: https://github.com/apache/bookkeeper/pull/1201#discussion_r171019871 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/BufferedChannel.java ## @@

[GitHub] sijie commented on a change in pull request #1201: ISSUE #570: Entrylog per ledger

sijie commented on a change in pull request #1201: ISSUE #570: Entrylog per ledger URL: https://github.com/apache/bookkeeper/pull/1201#discussion_r171039329 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/EntryMemTable.java ## @@ -263,6 +285,81

[GitHub] sebbASF opened a new issue #1213: Please delete old releases from mirroring system

sebbASF opened a new issue #1213: Please delete old releases from mirroring system URL: https://github.com/apache/bookkeeper/issues/1213 To reduce the load on the ASF mirrors, projects are required to delete old releases [1] Please can you remove all non-current releases? It's

[GitHub] sijie closed issue #1147: Move bookkeeper-server/{bin,conf} to root module

sijie closed issue #1147: Move bookkeeper-server/{bin,conf} to root module URL: https://github.com/apache/bookkeeper/issues/1147 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] reddycharan commented on a change in pull request #1201: ISSUE #570: Entrylog per ledger

reddycharan commented on a change in pull request #1201: ISSUE #570: Entrylog per ledger URL: https://github.com/apache/bookkeeper/pull/1201#discussion_r171030091 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/SyncThread.java ## @@ -119,6

[GitHub] sijie closed pull request #1212: Add Jia Zhai and Enrico Olivelli to PMC list

sijie closed pull request #1212: Add Jia Zhai and Enrico Olivelli to PMC list URL: https://github.com/apache/bookkeeper/pull/1212 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[GitHub] reddycharan commented on a change in pull request #1201: ISSUE #570: Entrylog per ledger

reddycharan commented on a change in pull request #1201: ISSUE #570: Entrylog per ledger URL: https://github.com/apache/bookkeeper/pull/1201#discussion_r171019871 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/BufferedChannel.java ## @@

[GitHub] reddycharan commented on a change in pull request #1201: ISSUE #570: Entrylog per ledger

reddycharan commented on a change in pull request #1201: ISSUE #570: Entrylog per ledger URL: https://github.com/apache/bookkeeper/pull/1201#discussion_r171023268 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/EntryLogger.java ## @@ -794,6

[GitHub] reddycharan commented on a change in pull request #1201: ISSUE #570: Entrylog per ledger

reddycharan commented on a change in pull request #1201: ISSUE #570: Entrylog per ledger URL: https://github.com/apache/bookkeeper/pull/1201#discussion_r171040651 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/EntryMemTable.java ## @@ -263,6

[GitHub] reddycharan commented on a change in pull request #1201: ISSUE #570: Entrylog per ledger

reddycharan commented on a change in pull request #1201: ISSUE #570: Entrylog per ledger URL: https://github.com/apache/bookkeeper/pull/1201#discussion_r171030825 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/conf/ServerConfiguration.java ## @@

[GitHub] sijie commented on issue #1192: BP-29 (task 3): use metadata service uri for constructing registration client

sijie commented on issue #1192: BP-29 (task 3): use metadata service uri for constructing registration client URL: https://github.com/apache/bookkeeper/pull/1192#issuecomment-369003391 > It's replacing it as far as BookKeeper is concerned. BookKeeper only has RegClient to manage the

[GitHub] reddycharan commented on a change in pull request #1201: ISSUE #570: Entrylog per ledger

reddycharan commented on a change in pull request #1201: ISSUE #570: Entrylog per ledger URL: https://github.com/apache/bookkeeper/pull/1201#discussion_r171048393 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/EntryMemTable.java ## @@ -263,6

[GitHub] sijie commented on a change in pull request #1201: ISSUE #570: Entrylog per ledger

sijie commented on a change in pull request #1201: ISSUE #570: Entrylog per ledger URL: https://github.com/apache/bookkeeper/pull/1201#discussion_r171020763 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/BufferedChannel.java ## @@ -110,11

[GitHub] reddycharan commented on a change in pull request #1201: ISSUE #570: Entrylog per ledger

reddycharan commented on a change in pull request #1201: ISSUE #570: Entrylog per ledger URL: https://github.com/apache/bookkeeper/pull/1201#discussion_r171031197 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/EntryMemTable.java ## @@ -263,6

[GitHub] sijie commented on issue #1090: Problems with the download page

sijie commented on issue #1090: Problems with the download page URL: https://github.com/apache/bookkeeper/issues/1090#issuecomment-369005694 @sebbASF we've addressed the concerns about the download page: http://bookkeeper.apache.org/releases/ do you mind taking a look to see if

[GitHub] reddycharan commented on a change in pull request #1201: ISSUE #570: Entrylog per ledger

reddycharan commented on a change in pull request #1201: ISSUE #570: Entrylog per ledger URL: https://github.com/apache/bookkeeper/pull/1201#discussion_r171038871 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/EntryMemTable.java ## @@ -263,6

[GitHub] reddycharan commented on a change in pull request #1201: ISSUE #570: Entrylog per ledger

reddycharan commented on a change in pull request #1201: ISSUE #570: Entrylog per ledger URL: https://github.com/apache/bookkeeper/pull/1201#discussion_r171050574 ## File path: bookkeeper-server/conf/bk_server.conf ## @@ -620,3 +620,15 @@ zkEnableSecurity=false #

[GitHub] sijie commented on issue #570: Multiple active entrylogs

sijie commented on issue #570: Multiple active entrylogs URL: https://github.com/apache/bookkeeper/issues/570#issuecomment-369018351 > Where has this been discussed? I can't find anything on the dev@ list. The discussion has been started since May 2017 and it has been

[GitHub] sijie closed pull request #1210: Issue 1147: Move bookkeeper-server/{bin,conf} to root module

sijie closed pull request #1210: Issue 1147: Move bookkeeper-server/{bin,conf} to root module URL: https://github.com/apache/bookkeeper/pull/1210 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance:

[GitHub] sijie commented on issue #1210: Issue 1147: Move bookkeeper-server/{bin,conf} to root module

sijie commented on issue #1210: Issue 1147: Move bookkeeper-server/{bin,conf} to root module URL: https://github.com/apache/bookkeeper/pull/1210#issuecomment-368981620 retest this please This is an automated message from the

[GitHub] reddycharan commented on a change in pull request #1201: ISSUE #570: Entrylog per ledger

reddycharan commented on a change in pull request #1201: ISSUE #570: Entrylog per ledger URL: https://github.com/apache/bookkeeper/pull/1201#discussion_r171027029 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/conf/ServerConfiguration.java ## @@

[GitHub] sijie commented on a change in pull request #1201: ISSUE #570: Entrylog per ledger

sijie commented on a change in pull request #1201: ISSUE #570: Entrylog per ledger URL: https://github.com/apache/bookkeeper/pull/1201#discussion_r171029439 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/conf/ServerConfiguration.java ## @@ -2586,4

[GitHub] reddycharan commented on a change in pull request #1201: ISSUE #570: Entrylog per ledger

reddycharan commented on a change in pull request #1201: ISSUE #570: Entrylog per ledger URL: https://github.com/apache/bookkeeper/pull/1201#discussion_r171048267 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/EntryMemTable.java ## @@ -263,6

[GitHub] reddycharan commented on a change in pull request #1201: ISSUE #570: Entrylog per ledger

reddycharan commented on a change in pull request #1201: ISSUE #570: Entrylog per ledger URL: https://github.com/apache/bookkeeper/pull/1201#discussion_r171048554 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/EntryMemTable.java ## @@ -263,6

[GitHub] reddycharan commented on a change in pull request #1201: ISSUE #570: Entrylog per ledger

reddycharan commented on a change in pull request #1201: ISSUE #570: Entrylog per ledger URL: https://github.com/apache/bookkeeper/pull/1201#discussion_r171048595 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/EntryMemTable.java ## @@ -263,6

[GitHub] sebbASF commented on issue #1090: Problems with the download page

sebbASF commented on issue #1090: Problems with the download page URL: https://github.com/apache/bookkeeper/issues/1090#issuecomment-369012278 I think the following sentence should be deleted: "Releases can be downloaded from BookKeeper?s Apache mirrors site or using the instructions

[GitHub] sijie commented on a change in pull request #1088: ISSUE #1086 (@bug W-4146427@) Client-side backpressure in netty (Fixes: io.netty.util.internal.OutOfDirectMemoryError under continuous heavy

sijie commented on a change in pull request #1088: ISSUE #1086 (@bug W-4146427@) Client-side backpressure in netty (Fixes: io.netty.util.internal.OutOfDirectMemoryError under continuous heavy load) URL: https://github.com/apache/bookkeeper/pull/1088#discussion_r170853461 ## File

[GitHub] ivankelly commented on issue #570: Multiple active entrylogs

ivankelly commented on issue #570: Multiple active entrylogs URL: https://github.com/apache/bookkeeper/issues/570#issuecomment-368816118 @reddycharan I'm not suggesting to have a ledgerstorage composed of multiple entrylogs. But the it makes no sense to make this modification on

[GitHub] sijie commented on issue #1208: use FutureUtils/FutureEventListener in bookkeeper-common for dlog

sijie commented on issue #1208: use FutureUtils/FutureEventListener in bookkeeper-common for dlog URL: https://github.com/apache/bookkeeper/pull/1208#issuecomment-368788859 @jiazhai the ci failure comes from findbugs error. fixed it, let's see ci results.

[GitHub] sijie commented on a change in pull request #1088: ISSUE #1086 (@bug W-4146427@) Client-side backpressure in netty (Fixes: io.netty.util.internal.OutOfDirectMemoryError under continuous heavy

sijie commented on a change in pull request #1088: ISSUE #1086 (@bug W-4146427@) Client-side backpressure in netty (Fixes: io.netty.util.internal.OutOfDirectMemoryError under continuous heavy load) URL: https://github.com/apache/bookkeeper/pull/1088#discussion_r170853592 ## File

[GitHub] sijie commented on a change in pull request #1088: ISSUE #1086 (@bug W-4146427@) Client-side backpressure in netty (Fixes: io.netty.util.internal.OutOfDirectMemoryError under continuous heavy

sijie commented on a change in pull request #1088: ISSUE #1086 (@bug W-4146427@) Client-side backpressure in netty (Fixes: io.netty.util.internal.OutOfDirectMemoryError under continuous heavy load) URL: https://github.com/apache/bookkeeper/pull/1088#discussion_r170855629 ## File

[GitHub] sijie commented on a change in pull request #1088: ISSUE #1086 (@bug W-4146427@) Client-side backpressure in netty (Fixes: io.netty.util.internal.OutOfDirectMemoryError under continuous heavy

sijie commented on a change in pull request #1088: ISSUE #1086 (@bug W-4146427@) Client-side backpressure in netty (Fixes: io.netty.util.internal.OutOfDirectMemoryError under continuous heavy load) URL: https://github.com/apache/bookkeeper/pull/1088#discussion_r170851649 ## File

[GitHub] sijie commented on a change in pull request #1088: ISSUE #1086 (@bug W-4146427@) Client-side backpressure in netty (Fixes: io.netty.util.internal.OutOfDirectMemoryError under continuous heavy

sijie commented on a change in pull request #1088: ISSUE #1086 (@bug W-4146427@) Client-side backpressure in netty (Fixes: io.netty.util.internal.OutOfDirectMemoryError under continuous heavy load) URL: https://github.com/apache/bookkeeper/pull/1088#discussion_r170852965 ## File

[GitHub] sijie commented on a change in pull request #1088: ISSUE #1086 (@bug W-4146427@) Client-side backpressure in netty (Fixes: io.netty.util.internal.OutOfDirectMemoryError under continuous heavy

sijie commented on a change in pull request #1088: ISSUE #1086 (@bug W-4146427@) Client-side backpressure in netty (Fixes: io.netty.util.internal.OutOfDirectMemoryError under continuous heavy load) URL: https://github.com/apache/bookkeeper/pull/1088#discussion_r170853137 ## File

[GitHub] sijie commented on a change in pull request #1088: ISSUE #1086 (@bug W-4146427@) Client-side backpressure in netty (Fixes: io.netty.util.internal.OutOfDirectMemoryError under continuous heavy

sijie commented on a change in pull request #1088: ISSUE #1086 (@bug W-4146427@) Client-side backpressure in netty (Fixes: io.netty.util.internal.OutOfDirectMemoryError under continuous heavy load) URL: https://github.com/apache/bookkeeper/pull/1088#discussion_r170857602 ## File

[GitHub] sijie commented on a change in pull request #1088: ISSUE #1086 (@bug W-4146427@) Client-side backpressure in netty (Fixes: io.netty.util.internal.OutOfDirectMemoryError under continuous heavy

sijie commented on a change in pull request #1088: ISSUE #1086 (@bug W-4146427@) Client-side backpressure in netty (Fixes: io.netty.util.internal.OutOfDirectMemoryError under continuous heavy load) URL: https://github.com/apache/bookkeeper/pull/1088#discussion_r170853204 ## File

[GitHub] sijie commented on a change in pull request #1088: ISSUE #1086 (@bug W-4146427@) Client-side backpressure in netty (Fixes: io.netty.util.internal.OutOfDirectMemoryError under continuous heavy

sijie commented on a change in pull request #1088: ISSUE #1086 (@bug W-4146427@) Client-side backpressure in netty (Fixes: io.netty.util.internal.OutOfDirectMemoryError under continuous heavy load) URL: https://github.com/apache/bookkeeper/pull/1088#discussion_r170850391 ## File

[GitHub] sijie commented on a change in pull request #1088: ISSUE #1086 (@bug W-4146427@) Client-side backpressure in netty (Fixes: io.netty.util.internal.OutOfDirectMemoryError under continuous heavy

sijie commented on a change in pull request #1088: ISSUE #1086 (@bug W-4146427@) Client-side backpressure in netty (Fixes: io.netty.util.internal.OutOfDirectMemoryError under continuous heavy load) URL: https://github.com/apache/bookkeeper/pull/1088#discussion_r170857470 ## File

[GitHub] sijie commented on a change in pull request #1088: ISSUE #1086 (@bug W-4146427@) Client-side backpressure in netty (Fixes: io.netty.util.internal.OutOfDirectMemoryError under continuous heavy

sijie commented on a change in pull request #1088: ISSUE #1086 (@bug W-4146427@) Client-side backpressure in netty (Fixes: io.netty.util.internal.OutOfDirectMemoryError under continuous heavy load) URL: https://github.com/apache/bookkeeper/pull/1088#discussion_r170854325 ## File

[GitHub] sijie commented on a change in pull request #1088: ISSUE #1086 (@bug W-4146427@) Client-side backpressure in netty (Fixes: io.netty.util.internal.OutOfDirectMemoryError under continuous heavy

sijie commented on a change in pull request #1088: ISSUE #1086 (@bug W-4146427@) Client-side backpressure in netty (Fixes: io.netty.util.internal.OutOfDirectMemoryError under continuous heavy load) URL: https://github.com/apache/bookkeeper/pull/1088#discussion_r170854197 ## File

[GitHub] sijie commented on a change in pull request #1088: ISSUE #1086 (@bug W-4146427@) Client-side backpressure in netty (Fixes: io.netty.util.internal.OutOfDirectMemoryError under continuous heavy

sijie commented on a change in pull request #1088: ISSUE #1086 (@bug W-4146427@) Client-side backpressure in netty (Fixes: io.netty.util.internal.OutOfDirectMemoryError under continuous heavy load) URL: https://github.com/apache/bookkeeper/pull/1088#discussion_r170853969 ## File

[GitHub] sijie commented on a change in pull request #1088: ISSUE #1086 (@bug W-4146427@) Client-side backpressure in netty (Fixes: io.netty.util.internal.OutOfDirectMemoryError under continuous heavy

sijie commented on a change in pull request #1088: ISSUE #1086 (@bug W-4146427@) Client-side backpressure in netty (Fixes: io.netty.util.internal.OutOfDirectMemoryError under continuous heavy load) URL: https://github.com/apache/bookkeeper/pull/1088#discussion_r170853461 ## File

[GitHub] sijie commented on a change in pull request #1088: ISSUE #1086 (@bug W-4146427@) Client-side backpressure in netty (Fixes: io.netty.util.internal.OutOfDirectMemoryError under continuous heavy

sijie commented on a change in pull request #1088: ISSUE #1086 (@bug W-4146427@) Client-side backpressure in netty (Fixes: io.netty.util.internal.OutOfDirectMemoryError under continuous heavy load) URL: https://github.com/apache/bookkeeper/pull/1088#discussion_r170854981 ## File

[GitHub] sijie commented on issue #1209: Added MockBookKeeper for unit tests

sijie commented on issue #1209: Added MockBookKeeper for unit tests URL: https://github.com/apache/bookkeeper/pull/1209#issuecomment-368806029 the failed "java 9" jenkins job is unrelated to this change. This is an automated

[GitHub] sijie commented on issue #1012: [Merge Yahoo repo] CMS-1437: use BookieSocketAddress in DNSToSwitchMapping

sijie commented on issue #1012: [Merge Yahoo repo] CMS-1437: use BookieSocketAddress in DNSToSwitchMapping URL: https://github.com/apache/bookkeeper/pull/1012#issuecomment-368789336 @merlimat it seems that we don't need this change any more, shall we close it or you want to wait until

[GitHub] sijie closed pull request #1209: Added MockBookKeeper for unit tests

sijie closed pull request #1209: Added MockBookKeeper for unit tests URL: https://github.com/apache/bookkeeper/pull/1209 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull

[GitHub] sijie commented on a change in pull request #1192: BP-29 (task 3): use metadata service uri for constructing registration client

sijie commented on a change in pull request #1192: BP-29 (task 3): use metadata service uri for constructing registration client URL: https://github.com/apache/bookkeeper/pull/1192#discussion_r170902665 ## File path:

[GitHub] sijie commented on a change in pull request #1192: BP-29 (task 3): use metadata service uri for constructing registration client

sijie commented on a change in pull request #1192: BP-29 (task 3): use metadata service uri for constructing registration client URL: https://github.com/apache/bookkeeper/pull/1192#discussion_r170902906 ## File path:

[GitHub] sijie commented on issue #1192: BP-29 (task 3): use metadata service uri for constructing registration client

sijie commented on issue #1192: BP-29 (task 3): use metadata service uri for constructing registration client URL: https://github.com/apache/bookkeeper/pull/1192#issuecomment-368855916 updated the comments. This is an

[GitHub] sijie opened a new pull request #1211: Use the bk OrderedScheduler in dlog

sijie opened a new pull request #1211: Use the bk OrderedScheduler in dlog URL: https://github.com/apache/bookkeeper/pull/1211 Descriptions of the changes in this PR: Dlog has an implementation of OrderedScheduler inspired of bk `OrderedScheduler`. It would be good to remove

[GitHub] ivankelly commented on a change in pull request #832: Issue 620: Close the fileChannels for read when they are idle

ivankelly commented on a change in pull request #832: Issue 620: Close the fileChannels for read when they are idle URL: https://github.com/apache/bookkeeper/pull/832#discussion_r170904586 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/EntryLogger.java

[GitHub] ivankelly commented on a change in pull request #832: Issue 620: Close the fileChannels for read when they are idle

ivankelly commented on a change in pull request #832: Issue 620: Close the fileChannels for read when they are idle URL: https://github.com/apache/bookkeeper/pull/832#discussion_r170899490 ## File path:

[GitHub] ivankelly commented on a change in pull request #832: Issue 620: Close the fileChannels for read when they are idle

ivankelly commented on a change in pull request #832: Issue 620: Close the fileChannels for read when they are idle URL: https://github.com/apache/bookkeeper/pull/832#discussion_r170912634 ## File path: bookkeeper-server/src/test/java/org/apache/bookkeeper/bookie/EntryLogTest.java

[GitHub] ivankelly commented on a change in pull request #832: Issue 620: Close the fileChannels for read when they are idle

ivankelly commented on a change in pull request #832: Issue 620: Close the fileChannels for read when they are idle URL: https://github.com/apache/bookkeeper/pull/832#discussion_r170900010 ## File path:

[GitHub] ivankelly commented on a change in pull request #832: Issue 620: Close the fileChannels for read when they are idle

ivankelly commented on a change in pull request #832: Issue 620: Close the fileChannels for read when they are idle URL: https://github.com/apache/bookkeeper/pull/832#discussion_r170904907 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/EntryLogger.java

[GitHub] ivankelly commented on a change in pull request #832: Issue 620: Close the fileChannels for read when they are idle

ivankelly commented on a change in pull request #832: Issue 620: Close the fileChannels for read when they are idle URL: https://github.com/apache/bookkeeper/pull/832#discussion_r170901464 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/EntryLogger.java

[GitHub] ivankelly commented on a change in pull request #832: Issue 620: Close the fileChannels for read when they are idle

ivankelly commented on a change in pull request #832: Issue 620: Close the fileChannels for read when they are idle URL: https://github.com/apache/bookkeeper/pull/832#discussion_r170900967 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/EntryLogger.java

[GitHub] ivankelly commented on a change in pull request #832: Issue 620: Close the fileChannels for read when they are idle

ivankelly commented on a change in pull request #832: Issue 620: Close the fileChannels for read when they are idle URL: https://github.com/apache/bookkeeper/pull/832#discussion_r170903266 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/EntryLogger.java

[GitHub] ivankelly commented on a change in pull request #832: Issue 620: Close the fileChannels for read when they are idle

ivankelly commented on a change in pull request #832: Issue 620: Close the fileChannels for read when they are idle URL: https://github.com/apache/bookkeeper/pull/832#discussion_r170898510 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/EntryLogger.java

[GitHub] ivankelly commented on a change in pull request #832: Issue 620: Close the fileChannels for read when they are idle

ivankelly commented on a change in pull request #832: Issue 620: Close the fileChannels for read when they are idle URL: https://github.com/apache/bookkeeper/pull/832#discussion_r170912739 ## File path: bookkeeper-server/src/test/java/org/apache/bookkeeper/bookie/EntryLogTest.java

[GitHub] ivankelly commented on a change in pull request #832: Issue 620: Close the fileChannels for read when they are idle

ivankelly commented on a change in pull request #832: Issue 620: Close the fileChannels for read when they are idle URL: https://github.com/apache/bookkeeper/pull/832#discussion_r170898661 ## File path: bookkeeper-server/conf/bk_server.conf ## @@ -433,6 +433,9 @@

[GitHub] ivankelly commented on a change in pull request #832: Issue 620: Close the fileChannels for read when they are idle

ivankelly commented on a change in pull request #832: Issue 620: Close the fileChannels for read when they are idle URL: https://github.com/apache/bookkeeper/pull/832#discussion_r170911124 ## File path: bookkeeper-server/src/test/java/org/apache/bookkeeper/bookie/EntryLogTest.java

[GitHub] ivankelly commented on a change in pull request #832: Issue 620: Close the fileChannels for read when they are idle

ivankelly commented on a change in pull request #832: Issue 620: Close the fileChannels for read when they are idle URL: https://github.com/apache/bookkeeper/pull/832#discussion_r170913134 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/EntryLogger.java

[GitHub] ivankelly commented on a change in pull request #1192: BP-29 (task 3): use metadata service uri for constructing registration client

ivankelly commented on a change in pull request #1192: BP-29 (task 3): use metadata service uri for constructing registration client URL: https://github.com/apache/bookkeeper/pull/1192#discussion_r170913941 ## File path:

[GitHub] ivankelly commented on a change in pull request #1192: BP-29 (task 3): use metadata service uri for constructing registration client

ivankelly commented on a change in pull request #1192: BP-29 (task 3): use metadata service uri for constructing registration client URL: https://github.com/apache/bookkeeper/pull/1192#discussion_r170919448 ## File path:

[GitHub] ivankelly commented on a change in pull request #1192: BP-29 (task 3): use metadata service uri for constructing registration client

ivankelly commented on a change in pull request #1192: BP-29 (task 3): use metadata service uri for constructing registration client URL: https://github.com/apache/bookkeeper/pull/1192#discussion_r170914734 ## File path:

[GitHub] ivankelly commented on a change in pull request #1192: BP-29 (task 3): use metadata service uri for constructing registration client

ivankelly commented on a change in pull request #1192: BP-29 (task 3): use metadata service uri for constructing registration client URL: https://github.com/apache/bookkeeper/pull/1192#discussion_r170914059 ## File path:

[GitHub] sijie commented on a change in pull request #1192: BP-29 (task 3): use metadata service uri for constructing registration client

sijie commented on a change in pull request #1192: BP-29 (task 3): use metadata service uri for constructing registration client URL: https://github.com/apache/bookkeeper/pull/1192#discussion_r170903797 ## File path:

[GitHub] sijie commented on a change in pull request #1192: BP-29 (task 3): use metadata service uri for constructing registration client

sijie commented on a change in pull request #1192: BP-29 (task 3): use metadata service uri for constructing registration client URL: https://github.com/apache/bookkeeper/pull/1192#discussion_r170903291 ## File path:

[GitHub] ivankelly commented on a change in pull request #832: Issue 620: Close the fileChannels for read when they are idle

ivankelly commented on a change in pull request #832: Issue 620: Close the fileChannels for read when they are idle URL: https://github.com/apache/bookkeeper/pull/832#discussion_r170911624 ## File path: bookkeeper-server/src/test/java/org/apache/bookkeeper/bookie/EntryLogTest.java

[GitHub] ivankelly commented on a change in pull request #832: Issue 620: Close the fileChannels for read when they are idle

ivankelly commented on a change in pull request #832: Issue 620: Close the fileChannels for read when they are idle URL: https://github.com/apache/bookkeeper/pull/832#discussion_r170900661 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/EntryLogger.java

[GitHub] jiazhai commented on issue #1208: use FutureUtils/FutureEventListener in bookkeeper-common for dlog

jiazhai commented on issue #1208: use FutureUtils/FutureEventListener in bookkeeper-common for dlog URL: https://github.com/apache/bookkeeper/pull/1208#issuecomment-368866550 ? This is an automated message from the Apache

Jenkins build is still unstable: bookkeeper_release_branch #72

See

[GitHub] ivankelly commented on a change in pull request #832: Issue 620: Close the fileChannels for read when they are idle

ivankelly commented on a change in pull request #832: Issue 620: Close the fileChannels for read when they are idle URL: https://github.com/apache/bookkeeper/pull/832#discussion_r170912467 ## File path: bookkeeper-server/src/test/java/org/apache/bookkeeper/bookie/EntryLogTest.java

[GitHub] ivankelly commented on a change in pull request #832: Issue 620: Close the fileChannels for read when they are idle

ivankelly commented on a change in pull request #832: Issue 620: Close the fileChannels for read when they are idle URL: https://github.com/apache/bookkeeper/pull/832#discussion_r170913185 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/EntryLogger.java

[GitHub] ivankelly commented on a change in pull request #1192: BP-29 (task 3): use metadata service uri for constructing registration client

ivankelly commented on a change in pull request #1192: BP-29 (task 3): use metadata service uri for constructing registration client URL: https://github.com/apache/bookkeeper/pull/1192#discussion_r170880851 ## File path:

[GitHub] ivankelly commented on a change in pull request #1192: BP-29 (task 3): use metadata service uri for constructing registration client

ivankelly commented on a change in pull request #1192: BP-29 (task 3): use metadata service uri for constructing registration client URL: https://github.com/apache/bookkeeper/pull/1192#discussion_r170878297 ## File path:

[GitHub] ivankelly commented on a change in pull request #1192: BP-29 (task 3): use metadata service uri for constructing registration client

ivankelly commented on a change in pull request #1192: BP-29 (task 3): use metadata service uri for constructing registration client URL: https://github.com/apache/bookkeeper/pull/1192#discussion_r170876639 ## File path:

[GitHub] ivankelly commented on a change in pull request #1192: BP-29 (task 3): use metadata service uri for constructing registration client

ivankelly commented on a change in pull request #1192: BP-29 (task 3): use metadata service uri for constructing registration client URL: https://github.com/apache/bookkeeper/pull/1192#discussion_r170876143 ## File path:

[GitHub] ivankelly commented on a change in pull request #1192: BP-29 (task 3): use metadata service uri for constructing registration client

ivankelly commented on a change in pull request #1192: BP-29 (task 3): use metadata service uri for constructing registration client URL: https://github.com/apache/bookkeeper/pull/1192#discussion_r170879150 ## File path:

[GitHub] sijie opened a new pull request #1210: Issue 1147: Move bookkeeper-server/{bin,conf} to root module

sijie opened a new pull request #1210: Issue 1147: Move bookkeeper-server/{bin,conf} to root module URL: https://github.com/apache/bookkeeper/pull/1210 Descriptions of the changes in this PR: *Motivation* since 4.7, we are shipping the binary distribution using

[GitHub] ivankelly commented on issue #570: Multiple active entrylogs

ivankelly commented on issue #570: Multiple active entrylogs URL: https://github.com/apache/bookkeeper/issues/570#issuecomment-368837292 > What I am suggesting here is to respect to what have been discussed and agreed on. Where has this been discussed? I can't find anything on the

[GitHub] ivankelly commented on issue #898: Bookies should prioritize recovery reads/writes

ivankelly commented on issue #898: Bookies should prioritize recovery reads/writes URL: https://github.com/apache/bookkeeper/pull/898#issuecomment-368839103 Will merge this tomorrow if there are no more comment (cc: @jvrao)

[GitHub] sijie commented on issue #570: Multiple active entrylogs

sijie commented on issue #570: Multiple active entrylogs URL: https://github.com/apache/bookkeeper/issues/570#issuecomment-368826780 > What is the rush? I am not suggesting a rush. What I am suggesting here is to respect to what have been discussed and agreed on. What I am saying

[GitHub] ivankelly commented on a change in pull request #1192: BP-29 (task 3): use metadata service uri for constructing registration client

ivankelly commented on a change in pull request #1192: BP-29 (task 3): use metadata service uri for constructing registration client URL: https://github.com/apache/bookkeeper/pull/1192#discussion_r170874199 ## File path:

[GitHub] ivankelly commented on a change in pull request #1192: BP-29 (task 3): use metadata service uri for constructing registration client

ivankelly commented on a change in pull request #1192: BP-29 (task 3): use metadata service uri for constructing registration client URL: https://github.com/apache/bookkeeper/pull/1192#discussion_r170877418 ## File path:

[GitHub] ivankelly commented on a change in pull request #1192: BP-29 (task 3): use metadata service uri for constructing registration client

ivankelly commented on a change in pull request #1192: BP-29 (task 3): use metadata service uri for constructing registration client URL: https://github.com/apache/bookkeeper/pull/1192#discussion_r170880742 ## File path:

[GitHub] sijie commented on issue #1210: Issue 1147: Move bookkeeper-server/{bin,conf} to root module

sijie commented on issue #1210: Issue 1147: Move bookkeeper-server/{bin,conf} to root module URL: https://github.com/apache/bookkeeper/pull/1210#issuecomment-368839735 A few other notes: - this existing IT tests covers testing the bookkeeper-server package, which would cover

[GitHub] ivankelly commented on issue #1210: Issue 1147: Move bookkeeper-server/{bin,conf} to root module

ivankelly commented on issue #1210: Issue 1147: Move bookkeeper-server/{bin,conf} to root module URL: https://github.com/apache/bookkeeper/pull/1210#issuecomment-368848381 retest this please This is an automated message from

[GitHub] ivankelly commented on issue #1210: Issue 1147: Move bookkeeper-server/{bin,conf} to root module

ivankelly commented on issue #1210: Issue 1147: Move bookkeeper-server/{bin,conf} to root module URL: https://github.com/apache/bookkeeper/pull/1210#issuecomment-368849793 rekicked the test because the IT had failed for some weird reason (couldn't connect to zk container, no reason

[GitHub] sijie commented on issue #1210: Issue 1147: Move bookkeeper-server/{bin,conf} to root module

sijie commented on issue #1210: Issue 1147: Move bookkeeper-server/{bin,conf} to root module URL: https://github.com/apache/bookkeeper/pull/1210#issuecomment-368853571 yes I tested from source and the compiled packages `bookkeeper-server` and `bookkeeper-all`.

[GitHub] sijie commented on a change in pull request #1192: BP-29 (task 3): use metadata service uri for constructing registration client

sijie commented on a change in pull request #1192: BP-29 (task 3): use metadata service uri for constructing registration client URL: https://github.com/apache/bookkeeper/pull/1192#discussion_r170902428 ## File path:

Jenkins build is back to stable : bookkeeper_release_nightly_snapshot #73

See

[GitHub] sijie opened a new pull request #1215: Update release guide to remove old releases after a new release is completed

sijie opened a new pull request #1215: Update release guide to remove old releases after a new release is completed URL: https://github.com/apache/bookkeeper/pull/1215 Descriptions of the changes in this PR: Address comments at #1213

[GitHub] sijie commented on issue #1214: Update download pages

sijie commented on issue #1214: Update download pages URL: https://github.com/apache/bookkeeper/pull/1214#issuecomment-369043640 /cc @lucperkins This is an automated message from the Apache Git Service. To respond to the

[GitHub] sijie closed issue #1207: copy the table service code as the contrib module

sijie closed issue #1207: copy the table service code as the contrib module URL: https://github.com/apache/bookkeeper/issues/1207 This is an automated message from the Apache Git Service. To respond to the message, please

  1   2   >