Github user KanakaKumar commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3059#discussion_r246826911
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/util/CarbonLoaderUtil.java
---
@@ -609,6 +609,14 @@ public static Dictionary
Github user KanakaKumar commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3059#discussion_r246317841
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/util/CarbonLoaderUtil.java
---
@@ -609,6 +613,9 @@ public static Dictionary
Github user KanakaKumar commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3059#discussion_r246311819
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/util/CarbonLoaderUtil.java
---
@@ -575,19 +575,23 @@ public static Dictionary
Github user KanakaKumar commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3059#discussion_r246311168
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/util/CarbonLoaderUtil.java
---
@@ -609,6 +613,9 @@ public static Dictionary
Github user KanakaKumar commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3059#discussion_r246309331
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/util/CarbonLoaderUtil.java
---
@@ -575,19 +575,23 @@ public static Dictionary
Github user KanakaKumar commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3059#discussion_r246286723
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/util/CarbonLoaderUtil.java
---
@@ -609,6 +597,10 @@ public static Dictionary
Github user KanakaKumar commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3059#discussion_r246286475
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/util/CarbonLoaderUtil.java
---
@@ -1164,4 +1156,35 @@ private static void
Github user KanakaKumar commented on the issue:
https://github.com/apache/carbondata/pull/3048
LGTM
---
Github user KanakaKumar commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3048#discussion_r245532720
--- Diff:
store/sdk/src/main/java/org/apache/carbondata/sdk/file/CarbonWriterBuilder.java
---
@@ -179,7 +181,8 @@ public CarbonWriterBuilder
Github user KanakaKumar commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3048#discussion_r245328731
--- Diff:
store/sdk/src/main/java/org/apache/carbondata/sdk/file/CarbonWriterBuilder.java
---
@@ -179,7 +182,8 @@ public CarbonWriterBuilder
Github user KanakaKumar commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3047#discussion_r244980360
--- Diff:
integration/spark-common/src/main/scala/org/apache/carbondata/api/CarbonStore.scala
---
@@ -101,14 +102,23 @@ object CarbonStore
Github user KanakaKumar commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3035#discussion_r244908015
--- Diff: store/CSDK/test/main.cpp ---
@@ -709,6 +709,7 @@ bool testWithTableProperty(JNIEnv *env, char *path, int
argc, char **argv
Github user KanakaKumar commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3035#discussion_r244907927
--- Diff: store/CSDK/test/main.cpp ---
@@ -546,7 +546,7 @@ bool testWriteData(JNIEnv *env, char *path, int argc,
char *argv
Github user KanakaKumar commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3035#discussion_r244907282
--- Diff: store/CSDK/src/CarbonWriter.cpp ---
@@ -291,9 +291,6 @@ void CarbonWriter::localDictionaryThreshold(int
localDictionaryThreshold
Github user KanakaKumar commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3035#discussion_r244907183
--- Diff: store/CSDK/test/main.cpp ---
@@ -853,7 +854,7 @@ int main(int argc, char *argv[]) {
} else {
int batch = 32000
Github user KanakaKumar commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2991#discussion_r243361889
--- Diff: store/CSDK/test/main.cpp ---
@@ -665,6 +699,208 @@ bool readFromS3(JNIEnv *env, char *path, char
*argv[]) {
printResult(env
Github user KanakaKumar commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2991#discussion_r243360358
--- Diff: store/CSDK/test/main.cpp ---
@@ -665,6 +699,208 @@ bool readFromS3(JNIEnv *env, char *path, char
*argv[]) {
printResult(env
Github user KanakaKumar commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2992#discussion_r243168227
--- Diff: docs/quick-start-guide.md ---
@@ -80,43 +80,49 @@ import org.apache.spark.sql.CarbonSession._
* Create a CarbonSession
Github user KanakaKumar commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2919#discussion_r242588569
--- Diff:
store/sdk/src/main/java/org/apache/carbondata/sdk/file/CarbonSchemaReader.java
---
@@ -241,12 +241,25 @@ private static Schema
Github user KanakaKumar commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2919#discussion_r242578856
--- Diff: docs/sdk-guide.md ---
@@ -816,13 +816,15 @@ Find example code at
[CarbonReaderExample](https://github.com/apache/carbondata
Github user KanakaKumar commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2919#discussion_r242577513
--- Diff:
store/sdk/src/test/java/org/apache/carbondata/sdk/file/CarbonSchemaReaderTest.java
---
@@ -236,6 +243,113 @@ public void
Github user KanakaKumar commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2919#discussion_r242577599
--- Diff:
store/sdk/src/main/java/org/apache/carbondata/sdk/file/CarbonSchemaReader.java
---
@@ -241,12 +241,25 @@ private static Schema
Github user KanakaKumar commented on the issue:
https://github.com/apache/carbondata/pull/2931
LGTM
---
Github user KanakaKumar commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2919#discussion_r242035462
--- Diff:
store/sdk/src/main/java/org/apache/carbondata/sdk/file/CarbonSchemaReader.java
---
@@ -241,12 +241,52 @@ private static Schema
Github user KanakaKumar commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2931#discussion_r242034641
--- Diff:
store/sdk/src/main/java/org/apache/carbondata/sdk/file/CarbonSchemaReader.java
---
@@ -147,34 +170,55 @@ public static Schema readSchema
Github user KanakaKumar commented on the issue:
https://github.com/apache/carbondata/pull/2899
LGTM
---
Github user KanakaKumar commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2899#discussion_r241731133
--- Diff:
store/sdk/src/main/java/org/apache/carbondata/sdk/file/CarbonWriterBuilder.java
---
@@ -77,8 +77,9 @@
/**
* Sets
Github user KanakaKumar commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2899#discussion_r241730265
--- Diff: store/CSDK/src/CarbonWriter.cpp ---
@@ -98,6 +127,158 @@ void CarbonWriter::withHadoopConf(char *key, char
*value
Github user KanakaKumar commented on the issue:
https://github.com/apache/carbondata/pull/2986
LGTM
---
Github user KanakaKumar commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2986#discussion_r241477189
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/table/CarbonDescribeFormattedCommand.scala
---
@@ -92,7 +92,9
Github user KanakaKumar commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2986#discussion_r241363901
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/table/CarbonDescribeFormattedCommand.scala
---
@@ -92,7 +92,9
Github user KanakaKumar commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2986#discussion_r241338497
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/table/CarbonDescribeFormattedCommand.scala
---
@@ -92,7 +92,9
Github user KanakaKumar commented on the issue:
https://github.com/apache/carbondata/pull/2847
LGTM
---
Github user KanakaKumar commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2847#discussion_r240208519
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/compression/GzipCompressor.java
---
@@ -0,0 +1,132 @@
+/*
+ * Licensed
Github user KanakaKumar commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2847#discussion_r240206699
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/compression/GzipCompressor.java
---
@@ -0,0 +1,132 @@
+/*
+ * Licensed
Github user KanakaKumar commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2847#discussion_r240211334
--- Diff:
integration/spark-common-test/src/test/scala/org/apache/carbondata/integration/spark/testsuite/dataload/TestLoadDataWithCompression.scala
Github user KanakaKumar commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2847#discussion_r240147384
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/compression/GzipCompressor.java
---
@@ -0,0 +1,132 @@
+/*
+ * Licensed
Github user KanakaKumar commented on the issue:
https://github.com/apache/carbondata/pull/2915
LGTM
---
Github user KanakaKumar commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2915#discussion_r235648435
--- Diff: docs/sdk-guide.md ---
@@ -674,6 +693,16 @@ Find example code at
[CarbonReaderExample](https://github.com/apache/carbondata/
public
Github user KanakaKumar commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2915#discussion_r235645252
--- Diff: docs/sdk-guide.md ---
@@ -684,6 +713,17 @@ Find example code at
[CarbonReaderExample](https://github.com/apache/carbondata/
public
Github user KanakaKumar commented on the issue:
https://github.com/apache/carbondata/pull/2929
LGTM
---
Github user KanakaKumar commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2929#discussion_r235266810
--- Diff: store/CSDK/src/CarbonRow.cpp ---
@@ -170,6 +170,9 @@ char *CarbonRow::getString(int ordinal) {
args[0].l = carbonRow
Github user KanakaKumar commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2929#discussion_r235261186
--- Diff: store/CSDK/src/CarbonRow.cpp ---
@@ -170,6 +170,9 @@ char *CarbonRow::getString(int ordinal) {
args[0].l = carbonRow
Github user KanakaKumar commented on the issue:
https://github.com/apache/carbondata/pull/2804
LGTM
---
Github user KanakaKumar commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2804#discussion_r231061128
--- Diff:
store/sdk/src/main/java/org/apache/carbondata/sdk/file/CarbonSchemaReader.java
---
@@ -61,14 +65,122 @@ public static Schema
Github user KanakaKumar commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2804#discussion_r231060332
--- Diff:
store/sdk/src/main/java/org/apache/carbondata/sdk/file/CarbonSchemaReader.java
---
@@ -144,4 +246,28 @@ public static Schema
Github user KanakaKumar commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2804#discussion_r231059908
--- Diff:
store/sdk/src/main/java/org/apache/carbondata/sdk/file/CarbonSchemaReader.java
---
@@ -61,14 +65,122 @@ public static Schema
Github user KanakaKumar commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2804#discussion_r231058670
--- Diff:
store/sdk/src/main/java/org/apache/carbondata/sdk/file/CarbonSchemaReader.java
---
@@ -61,14 +65,122 @@ public static Schema
Github user KanakaKumar commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2804#discussion_r231057030
--- Diff:
store/sdk/src/main/java/org/apache/carbondata/sdk/file/CarbonSchemaReader.java
---
@@ -61,14 +65,122 @@ public static Schema
Github user KanakaKumar commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2804#discussion_r230802487
--- Diff:
store/sdk/src/main/java/org/apache/carbondata/sdk/file/CarbonSchemaReader.java
---
@@ -61,14 +65,121 @@ public static Schema
Github user KanakaKumar commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2804#discussion_r230801853
--- Diff:
store/sdk/src/main/java/org/apache/carbondata/sdk/file/CarbonSchemaReader.java
---
@@ -61,14 +65,121 @@ public static Schema
Github user KanakaKumar commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2804#discussion_r230799912
--- Diff:
store/sdk/src/test/java/org/apache/carbondata/sdk/file/CarbonSchemaReaderTest.java
---
@@ -101,18 +104,30 @@ public boolean accept
Github user KanakaKumar commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2804#discussion_r230788337
--- Diff: docs/sdk-guide.md ---
@@ -685,6 +685,31 @@ Find example code at
[CarbonReaderExample](https://github.com/apache/carbondata
Github user KanakaKumar commented on the issue:
https://github.com/apache/carbondata/pull/2816
LGTM
---
Github user KanakaKumar commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2869#discussion_r230274806
--- Diff:
store/sdk/src/main/java/org/apache/carbondata/sdk/file/CarbonReaderBuilder.java
---
@@ -51,6 +54,7 @@
private Expression
Github user KanakaKumar commented on the issue:
https://github.com/apache/carbondata/pull/2884
LGTM
---
Github user KanakaKumar commented on the issue:
https://github.com/apache/carbondata/pull/2807
LGTM
---
Github user KanakaKumar commented on the issue:
https://github.com/apache/carbondata/pull/2807
Ok Xubo, fine.
---
Github user KanakaKumar commented on the issue:
https://github.com/apache/carbondata/pull/2807
I suggest let's hold this PR till 2804 is concluded & merged to avoid
duplicate work.
---
Github user KanakaKumar commented on the issue:
https://github.com/apache/carbondata/pull/2804
I think we can enhance the existing APIs itself to take folder path and
then list from the first available data file or index file.. Adding many APIs
in SDK will cause confusion for same
Github user KanakaKumar commented on the issue:
https://github.com/apache/carbondata/pull/2836
I think this PR may not be require any more after #2841. @xubo245 , our
intention is to make unsafe configuration flexible and even with default values
we should be able to continue with
Github user KanakaKumar commented on the issue:
https://github.com/apache/carbondata/pull/2877
LGTM
---
Github user KanakaKumar commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2877#discussion_r229579618
--- Diff:
core/src/main/java/org/apache/carbondata/core/metadata/encoder/Encoding.java ---
@@ -57,10 +62,55 @@ public static Encoding valueOf(int
Github user KanakaKumar commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2877#discussion_r229578569
--- Diff:
core/src/main/java/org/apache/carbondata/core/util/CarbonProperties.java ---
@@ -696,9 +697,6 @@ private void
Github user KanakaKumar commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2877#discussion_r229578345
--- Diff:
core/src/main/java/org/apache/carbondata/core/metadata/encoder/Encoding.java ---
@@ -57,10 +62,55 @@ public static Encoding valueOf(int
Github user KanakaKumar commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2877#discussion_r229578078
--- Diff:
core/src/main/java/org/apache/carbondata/core/metadata/encoder/Encoding.java ---
@@ -57,10 +62,55 @@ public static Encoding valueOf(int
Github user KanakaKumar commented on the issue:
https://github.com/apache/carbondata/pull/2837
LGTM
---
Github user KanakaKumar commented on the issue:
https://github.com/apache/carbondata/pull/2792
LGTM apart from those nits in guide & ut.
---
Github user KanakaKumar commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2792#discussion_r227839509
--- Diff:
store/sdk/src/test/java/org/apache/carbondata/sdk/file/CarbonReaderTest.java ---
@@ -1522,4 +1522,204 @@ public boolean accept(File dir
Github user KanakaKumar commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2792#discussion_r227839131
--- Diff:
store/sdk/src/test/java/org/apache/carbondata/sdk/file/CarbonReaderTest.java ---
@@ -1522,4 +1522,204 @@ public boolean accept(File dir
Github user KanakaKumar commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2792#discussion_r227836644
--- Diff: docs/csdk-guide.md ---
@@ -106,20 +128,41 @@ bool readFromS3(JNIEnv *env, char *argv[]) {
// "your endPoint"
Github user KanakaKumar commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2792#discussion_r227836440
--- Diff: docs/csdk-guide.md ---
@@ -68,20 +68,42 @@ JNIEnv *initJVM() {
bool readFromLocalWithoutProjection(JNIEnv *env
Github user KanakaKumar commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2792#discussion_r227741794
--- Diff: store/CSDK/CarbonRow.cpp ---
@@ -0,0 +1,128 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
Github user KanakaKumar commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2792#discussion_r222691292
--- Diff: store/CSDK/CarbonReader.cpp ---
@@ -89,10 +89,18 @@ jboolean CarbonReader::hasNext() {
return hasNext;
}
+jobject
Github user KanakaKumar commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2792#discussion_r222691023
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/row/CarbonRow.java ---
@@ -18,8 +18,11 @@
package
Github user KanakaKumar commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2792#discussion_r222690123
--- Diff:
hadoop/src/main/java/org/apache/carbondata/hadoop/readsupport/impl/DictionaryDecodeReadSupport.java
---
@@ -81,7 +82,24
Github user KanakaKumar commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2792#discussion_r222689040
--- Diff:
hadoop/src/main/java/org/apache/carbondata/hadoop/CarbonRecordReader.java ---
@@ -116,6 +117,25 @@ public void initialize(InputSplit
Github user KanakaKumar commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2792#discussion_r222686566
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/row/CarbonRow.java ---
@@ -57,6 +74,154 @@ public String getString(int ordinal
Github user KanakaKumar commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2791#discussion_r222594726
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/hive/CarbonFileMetastore.scala
---
@@ -208,7 +209,10 @@ class CarbonFileMetastore
Github user KanakaKumar commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2794#discussion_r222330949
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/merger/CarbonDataMergerUtil.java
---
@@ -744,6 +744,7 @@ private static long
Github user KanakaKumar commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2791#discussion_r52487
--- Diff:
integration/spark2/src/main/spark2.1/org/apache/spark/sql/hive/CarbonSessionState.scala
---
@@ -141,7 +141,13 @@ class
Github user KanakaKumar commented on the issue:
https://github.com/apache/carbondata/pull/2780
LGTM
---
Github user KanakaKumar commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2780#discussion_r221246385
--- Diff:
store/sdk/src/test/java/org/apache/carbondata/sdk/file/CarbonReaderTest.java ---
@@ -1435,5 +1435,99 @@ public void
Github user KanakaKumar commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2738#discussion_r221218207
--- Diff:
store/sdk/src/main/java/org/apache/carbondata/sdk/file/CarbonReader.java ---
@@ -90,6 +91,33 @@ public T readNextRow() throws IOException
Github user KanakaKumar commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2738#discussion_r221149564
--- Diff:
store/sdk/src/main/java/org/apache/carbondata/sdk/file/CarbonReader.java ---
@@ -90,6 +91,33 @@ public T readNextRow() throws IOException
Github user KanakaKumar commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2738#discussion_r220802829
--- Diff:
store/sdk/src/main/java/org/apache/carbondata/sdk/file/CarbonReaderBuilder.java
---
@@ -101,6 +101,20 @@ public CarbonReaderBuilder
Github user KanakaKumar commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2738#discussion_r220802212
--- Diff:
store/sdk/src/main/java/org/apache/carbondata/sdk/file/CarbonReaderBuilder.java
---
@@ -101,6 +101,20 @@ public CarbonReaderBuilder
Github user KanakaKumar commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2738#discussion_r220566235
--- Diff: store/CSDK/CarbonReader.cpp ---
@@ -0,0 +1,97 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
Github user KanakaKumar commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2738#discussion_r220565596
--- Diff: store/sdk/pom.xml ---
@@ -39,6 +39,16 @@
hadoop-aws
${hadoop.version
Github user KanakaKumar commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2738#discussion_r220562265
--- Diff: store/sdk/pom.xml ---
@@ -39,6 +39,16 @@
hadoop-aws
${hadoop.version
Github user KanakaKumar commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2738#discussion_r220560348
--- Diff:
store/sdk/src/main/java/org/apache/carbondata/sdk/file/CarbonReader.java ---
@@ -90,6 +91,33 @@ public T readNextRow() throws IOException
Github user KanakaKumar commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2738#discussion_r220559298
--- Diff:
store/sdk/src/main/java/org/apache/carbondata/sdk/file/CarbonReaderBuilder.java
---
@@ -101,6 +101,20 @@ public CarbonReaderBuilder
Github user KanakaKumar commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2738#discussion_r220558655
--- Diff:
store/sdk/src/main/java/org/apache/carbondata/sdk/file/CarbonReaderBuilder.java
---
@@ -101,6 +101,20 @@ public CarbonReaderBuilder
Github user KanakaKumar commented on the issue:
https://github.com/apache/carbondata/pull/2697
retest this please
---
Github user KanakaKumar commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2715#discussion_r217682375
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/compression/CompressorFactory.java
---
@@ -62,15 +67,54 @@ public Compressor
Github user KanakaKumar commented on the issue:
https://github.com/apache/carbondata/pull/2719
LGTM
---
Github user KanakaKumar commented on the issue:
https://github.com/apache/carbondata/pull/2704
LGTM
---
Github user KanakaKumar commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2704#discussion_r217021955
--- Diff:
core/src/main/java/org/apache/carbondata/core/scan/executor/util/RestructureUtil.java
---
@@ -165,14 +165,15 @@ private static boolean
Github user KanakaKumar commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2704#discussion_r216917965
--- Diff:
core/src/main/java/org/apache/carbondata/core/scan/executor/util/RestructureUtil.java
---
@@ -165,14 +165,15 @@ private static boolean
Github user KanakaKumar commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2704#discussion_r216918150
--- Diff:
core/src/main/java/org/apache/carbondata/core/scan/executor/util/RestructureUtil.java
---
@@ -165,14 +165,15 @@ private static boolean
1 - 100 of 206 matches
Mail list logo
