Re: [Libguestfs] libguestfs failure "mkdir: command not found ..."

2023-10-23 Thread Richard W.M. Jones
On Mon, Oct 23, 2023 at 03:53:37PM +, Maximilian Kirschner wrote: > Is it possible that this error occcurs because my root partition is encryped > with LUKS. If the virtual file system tries to mount the /root of my host > system, this will not work. > Is this the case? Does libguestfs mount

Re: [Libguestfs] libguestfs failure "mkdir: command not found ..."

2023-10-23 Thread Richard W.M. Jones
On Mon, Oct 23, 2023 at 07:38:28AM +, Maximilian Kirschner wrote: > Hello, > > > I'm trying to run virt-make-fs, which fails. > > I have installed libguestfs-tools via apt on a Ubuntu 22.04 system. I'm afraid looks like however libguestfs was built, it is severly broken. You might want

Re: [Libguestfs] [PATCH libnbd 0/4] Miscellaneous Rust cleanups

2023-10-18 Thread Richard W.M. Jones
On Wed, Oct 18, 2023 at 09:22:55AM -0500, Eric Blake wrote: > On Tue, Oct 10, 2023 at 03:06:06PM +0100, Richard W.M. Jones wrote: > > Add an overview libnbd-rust(3) man page pointing to the real > > documentation. This is like OCaml & Golang. > > > > When review

Re: [Libguestfs] [PATCH libnbd 0/4] Miscellaneous Rust cleanups

2023-10-18 Thread Richard W.M. Jones
On Wed, Oct 18, 2023 at 09:22:55AM -0500, Eric Blake wrote: > On Tue, Oct 10, 2023 at 03:06:06PM +0100, Richard W.M. Jones wrote: > > Add an overview libnbd-rust(3) man page pointing to the real > > documentation. This is like OCaml & Golang. > > > > When review

[Libguestfs] A note on migration of this list to lists.libguestfs.org

2023-10-18 Thread Richard W.M. Jones
We will soon be migrating this list over to a new hosting service at lists.libguestfs.org. All subscriptions will be moved automatically. The main visible change will be that the email address of the list will be different (since we will not longer be allowed to use the @redhat.com address).

Re: [Libguestfs] Reported issues in nbdkit_parse_probability (was: Fwd: AUR Comment for nbdkit)

2023-10-14 Thread Richard W.M. Jones
On Sat, Oct 14, 2023 at 01:49:34PM +0100, Richard W.M. Jones wrote: > https://aur.archlinux.org/packages/nbdkit#comment-938282 > FAIL: test-public > = > > Wrong return value for inf, got 0, expected -1 > Wrong result for inf, got inf, expected 0 > Wrong retu

[Libguestfs] Reported issues in nbdkit_parse_probability (was: Fwd: AUR Comment for nbdkit)

2023-10-14 Thread Richard W.M. Jones
https://aur.archlinux.org/packages/nbdkit#comment-938282 - Forwarded message from not...@aur.archlinux.org - Date: Sat, 14 Oct 2023 12:40:02 + Subject: AUR Comment for nbdkit dreieck [1] added the following comment to nbdkit [2]: `check()` fails for me, too: ``` [...] make

[Libguestfs] [PATCH libnbd 4/4] rust: Build the examples

2023-10-10 Thread Richard W.M. Jones
It's worth checking that the examples actually build, so we don't get any regressions. --- rust/Makefile.am | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/rust/Makefile.am b/rust/Makefile.am index 5c73512c87..a7700d69bd 100644 --- a/rust/Makefile.am +++

[Libguestfs] [PATCH libnbd 3/4] rust: Write a custom translator from POD to rustdoc

2023-10-10 Thread Richard W.M. Jones
For more faithful translation of API documentation, write a custom translator from POD to rustdoc. --- generator/Rust.ml | 99 ++- 1 file changed, 80 insertions(+), 19 deletions(-) diff --git a/generator/Rust.ml b/generator/Rust.ml index

[Libguestfs] [PATCH libnbd 2/4] rust: Add overview documentation

2023-10-10 Thread Richard W.M. Jones
--- .gitignore | 1 + docs/libnbd.pod | 4 rust/Makefile.am | 13 +++ rust/libnbd-rust.pod | 53 4 files changed, 71 insertions(+) diff --git a/.gitignore b/.gitignore index 36bf8b60f8..0b1cf7646a 100644 ---

[Libguestfs] [PATCH libnbd 1/4] rust: Annotate 'endif' with corresponding label

2023-10-10 Thread Richard W.M. Jones
Although not required, it makes automake 'Makefile.am's easier to read. --- rust/Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/rust/Makefile.am b/rust/Makefile.am index 027097af9b..75738a0c30 100644 --- a/rust/Makefile.am +++ b/rust/Makefile.am @@ -117,6 +117,6

[Libguestfs] [PATCH libnbd 0/4] Miscellaneous Rust cleanups

2023-10-10 Thread Richard W.M. Jones
Add an overview libnbd-rust(3) man page pointing to the real documentation. This is like OCaml & Golang. When reviewing the real rustdocs I noticed they basically converted the man pages into plain text, resulting in lots of problems such as internal links not working, no `code` annotations,

Re: [Libguestfs] [nbdkit] Two POSIX questions for you ...

2023-10-10 Thread Richard W.M. Jones
On Tue, Oct 10, 2023 at 09:05:43AM +0200, Laszlo Ersek wrote: > On 10/9/23 16:51, Richard W.M. Jones wrote: > > > > So one thing we could do for this test is to require (for the test) > > that /bin/sh is bash, something like the patch below. I was only able > > to tes

Re: [Libguestfs] [nbdkit] Two POSIX questions for you ...

2023-10-09 Thread Richard W.M. Jones
So one thing we could do for this test is to require (for the test) that /bin/sh is bash, something like the patch below. I was only able to test this in the positive case. diff --git a/tests/test-log-script-info.sh b/tests/test-log-script-info.sh index fa9b2ed32..d65f6415d 100755 ---

Re: [Libguestfs] [nbdkit] Two POSIX questions for you ...

2023-10-09 Thread Richard W.M. Jones
On Mon, Oct 09, 2023 at 01:32:07PM +0200, Laszlo Ersek wrote: > On 10/9/23 13:12, Richard W.M. Jones wrote: > > On Mon, Oct 09, 2023 at 12:57:14PM +0200, Laszlo Ersek wrote: > >> On 10/9/23 09:46, Richard W.M. Jones wrote: > >>> Hi Eric, a couple of POSIX

Re: [Libguestfs] [nbdkit] Two POSIX questions for you ...

2023-10-09 Thread Richard W.M. Jones
On Mon, Oct 09, 2023 at 12:57:14PM +0200, Laszlo Ersek wrote: > On 10/9/23 09:46, Richard W.M. Jones wrote: > > Hi Eric, a couple of POSIX questions for you from nbdkit. > > > > The first question is from an AUR comment on nbdkit: > > > > https://aur.arch

[Libguestfs] [nbdkit] Two POSIX questions for you ...

2023-10-09 Thread Richard W.M. Jones
Hi Eric, a couple of POSIX questions for you from nbdkit. The first question is from an AUR comment on nbdkit: https://aur.archlinux.org/packages/nbdkit#comment-937381 I think there's a bash-ism in the logscript parameter in this test:

Re: [Libguestfs] [libnbd PATCH 1/2] utils: Slightly simplify human_size()

2023-10-07 Thread Richard W.M. Jones
][0] != '\0'; > + *human = ext[i] != '\0'; > > - snprintf (buf, HUMAN_SIZE_LONGEST, "%" PRIu64 "%s", bytes, ext[i]); > + snprintf (buf, HUMAN_SIZE_LONGEST, "%" PRIu64 "%.1s", bytes, [i]); >return buf; > } Reviewed-by: Richard W.M. Jones

Re: [Libguestfs] [libnbd PATCH 2/2] info: Show human sizes for block_size values

2023-10-07 Thread Richard W.M. Jones
On Fri, Oct 06, 2023 at 10:18:09AM -0500, Eric Blake wrote: > Adding a human-readable size for block constraints is useful. For: > > $ ./run nbdinfo -- [ nbdkit memory \ >--filter=blocksize-policy blocksize-preferred=32k 1M ] | grep pref > > this changes pre-patch: >

Re: [Libguestfs] Some comments on the libnbd apk in Alpine

2023-10-06 Thread Richard W.M. Jones
On Fri, Oct 06, 2023 at 03:54:46PM -0400, Sean McAvoy wrote: > Hi Richard, > the package in Alpine (edge) has recently been updated to 1.18.0. The > mirrors should reflect that soon Thank you Rich. > > Thanks, > > Sean > > On Sat, Sep 23, 2023 at 6:11 A

Re: [Libguestfs] [PATCH libnbd 3/5] common: Combine human-size.h headers into one

2023-10-06 Thread Richard W.M. Jones
On Fri, Oct 06, 2023 at 09:18:31AM -0500, Eric Blake wrote: > On Sun, Sep 03, 2023 at 04:23:23PM +0100, Richard W.M. Jones wrote: > > Copy the human_size() function from common/utils/ into the new > > human-size.h header in common/include/. Remove human-size.c and > > combi

Re: [Libguestfs] [PATCH virt-v2v] -it ssh: Double quote ssh command which tests remote file exists

2023-10-02 Thread Richard W.M. Jones
On Mon, Oct 02, 2023 at 04:09:50PM +0200, Laszlo Ersek wrote: > On 10/2/23 11:03, Richard W.M. Jones wrote: > > Double quoting was removed in > > commit e2af12ba69c4463bb73d30db63290a887cdd41eb ("input: -i vmx: > > Remove support for openssh scp < 8.8", Nov 2021)

[Libguestfs] [PATCH virt-v2v] -it ssh: Double quote ssh command which tests remote file exists

2023-10-02 Thread Richard W.M. Jones
Double quoting was removed in commit e2af12ba69c4463bb73d30db63290a887cdd41eb ("input: -i vmx: Remove support for openssh scp < 8.8", Nov 2021). However it should only have been removed from scp commands, not for this ssh command where it is still required. See:

Re: [Libguestfs] Fwd: virt-v2v creating image that does not install guest agent on first boot

2023-10-02 Thread Richard W.M. Jones
On Mon, Oct 02, 2023 at 01:00:00PM +0800, Ming Xie wrote: > Hi Richard, > > On Fri, Sep 29, 2023 at 5:45 AM Richard W.M. Jones wrote: > > On Thu, Sep 28, 2023 at 07:41:55PM +0800, Ming Xie wrote: > > Hi Richard, > > > > On Thu, Sep 28, 2

Re: [Libguestfs] libguestfs kernel panic

2023-09-30 Thread Richard W.M. Jones
On Sat, Sep 30, 2023 at 10:42:55AM +, Clark, Dennis wrote: > Ok, Looking at my original installation procedure, including the slight tweaks > to get libvirt-7 loaded, and checking the current server … it appears the > libvirt-7 packages mention the O/S version (eg el8.7), and there are

Re: [Libguestfs] libguestfs kernel panic

2023-09-30 Thread Richard W.M. Jones
On Thu, Sep 28, 2023 at 12:30:28PM +, Clark, Dennis wrote: > [root@ol-kvm-h01 work]# LIBGUESTFS_BACKEND=direct libguestfs-test-tool ... > libguestfs: launch: version=1.44.0rhel=8,release= > 5.0.1.module+el8.7.0+21035+a8208c98,libvirt > > \x1b[2J[0.00] Linux version

Re: [Libguestfs] Fwd: virt-v2v creating image that does not install guest agent on first boot

2023-09-28 Thread Richard W.M. Jones
On Thu, Sep 28, 2023 at 07:41:55PM +0800, Ming Xie wrote: > Hi Richard, > > On Thu, Sep 28, 2023 at 6:14 PM Richard W.M. Jones wrote: > > Ming, > > For some reason the build seems "stuck" at the moment, but > if it finishes could you

Re: [Libguestfs] Fwd: virt-v2v creating image that does not install guest agent on first boot

2023-09-28 Thread Richard W.M. Jones
On Thu, Sep 28, 2023 at 07:41:55PM +0800, Ming Xie wrote: > Hi Richard, > > On Thu, Sep 28, 2023 at 6:14 PM Richard W.M. Jones wrote: > > Ming, > > For some reason the build seems "stuck" at the moment, but > if it finishes could you

Re: [Libguestfs] Fwd: virt-v2v creating image that does not install guest agent on first boot

2023-09-28 Thread Richard W.M. Jones
On Thu, Sep 28, 2023 at 04:03:33PM +0800, Ming Xie wrote: >    Yes, I reproduced the problem using rhel9 virt-v2v, because I saw that the > customer was also using rhel9 virt-v2v (version: 2.2), I saw that you wanted > to > solve the problem by fixing the  date of the schtask command, but I see

Re: [Libguestfs] Fwd: virt-v2v creating image that does not install guest agent on first boot

2023-09-28 Thread Richard W.M. Jones
Ming, For some reason the build seems "stuck" at the moment, but if it finishes could you see if this fixes the RHEL 9 case? https://kojihub.stream.centos.org/koji/taskinfo?taskID=2879547 Thanks, Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my

Re: [Libguestfs] [libnbd PATCH] info: Try harder for graceful disconnect from server

2023-09-28 Thread Richard W.M. Jones
On Wed, Sep 27, 2023 at 04:22:48PM -0500, Eric Blake wrote: > On Fri, Sep 22, 2023 at 04:03:19PM -0500, Eric Blake wrote: > > On Fri, Sep 22, 2023 at 09:47:55PM +0100, Richard W.M. Jones wrote: > > > On Fri, Sep 22, 2023 at 12:33:36PM -0500, Eric Blake wrote: > > > &

Re: [Libguestfs] Fwd: virt-v2v creating image that does not install guest agent on first boot

2023-09-27 Thread Richard W.M. Jones
install qemu-ga because of network address error after > converting MD-RAID1 win11 host by virt-p2v > Bug 1820152 - Fail to execute installation-qemu-ga.msi for win2012r2 and > win8.1-i386 guests > > > Thanks & Regards > Ming Xie > > On Fri, Sep 22, 2023 at 6:40 PM

[Libguestfs] ANNOUNCE: nbdkit 1.36 and libnbd 1.18 released

2023-09-27 Thread Richard W.M. Jones
ure" script generated by autoconf), but now the dependency is explicit (Eric Blake). Internals "podwrapper" has a new --replace parameter which makes it easier to use "AC_SUBST"-substitutions in documentation. SEE ALSO nbdkit(1). AUTHORS

[Libguestfs] [PATCH v2v v2 6/6] convert: Find out if Windows guest is expecting RTC set to UTC

2023-09-25 Thread Richard W.M. Jones
Read HKLM\SYSTEM\CurrentControlSet\Control\TimeZoneInformation key "RealTimeIsUniversal" to see if the Windows guest is expecting RTC set to localtime (not present) or UTC (present and set to 1). See: https://wiki.archlinux.org/title/System_time#UTC_in_Microsoft_Windows See:

[Libguestfs] [PATCH v2v v2 3/6] output/create_libvirt_xml.ml: Refactor os_section

2023-09-25 Thread Richard W.M. Jones
Minor refactoring of how section is generated in XML output. There is no change in the output. Reviewed-by: Laszlo Ersek --- output/create_libvirt_xml.ml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/output/create_libvirt_xml.ml b/output/create_libvirt_xml.ml index

[Libguestfs] [PATCH v2v v2 4/6] -o libvirt: Add to libvirt XML

2023-09-25 Thread Richard W.M. Jones
Reviewed-by: Laszlo Ersek --- output/create_libvirt_xml.ml | 6 ++ tests/test-v2v-i-ova.xml | 1 + 2 files changed, 7 insertions(+) diff --git a/output/create_libvirt_xml.ml b/output/create_libvirt_xml.ml index 12586fde17..30119d1357 100644 --- a/output/create_libvirt_xml.ml +++

[Libguestfs] [PATCH v2v v2 5/6] -o qemu: Set -rtc base=localtime when guest expects RTC set to localtime

2023-09-25 Thread Richard W.M. Jones
I didn't set the -rtc flag in the normal (UTC) case as that is the default. Reviewed-by: Laszlo Ersek --- output/output_qemu.ml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/output/output_qemu.ml b/output/output_qemu.ml index 57b1e58da2..1a5f7f7147 100644 --- a/output/output_qemu.ml +++

[Libguestfs] [[PATCH v2v v2 0/6] convert: Find out if Windows guest is expecting RTC set to UTC

2023-09-25 Thread Richard W.M. Jones
The main changes are: - BIOS -> RTC passim - Split out the minor refactoring patch - Enhanced commit messages - Add Laszlo's R-b tag Rich. ___ Libguestfs mailing list Libguestfs@redhat.com https://listman.redhat.com/mailman/listinfo/libguestfs

[Libguestfs] [PATCH v2v v2 1/6] types: Add gcaps_rtc_utc to record if the RTC is set to UTC or localtime

2023-09-25 Thread Richard W.M. Jones
Almost every Linux guest expects the motherboard Real Time Clock (RTC) to be set to UTC and they adjust the time displayed based on their timezone (which may be different for each user). Most Windows guests expect the RTC to be set to the local time. Windows can be configured to use a UTC clock.

[Libguestfs] [PATCH v2v v2 2/6] -o kubevirt: Add comment about future support for clock = localtime

2023-09-25 Thread Richard W.M. Jones
Reviewed-by: Laszlo Ersek --- output/create_kubevirt_yaml.ml | 5 + 1 file changed, 5 insertions(+) diff --git a/output/create_kubevirt_yaml.ml b/output/create_kubevirt_yaml.ml index 689555e4dc..e3a3f422df 100644 --- a/output/create_kubevirt_yaml.ml +++ b/output/create_kubevirt_yaml.ml @@

Re: [Libguestfs] [PATCH v2v 5/5] convert: Find out if Windows guest is expected BIOS set to localtime

2023-09-25 Thread Richard W.M. Jones
On Mon, Sep 25, 2023 at 05:58:00PM +0200, Laszlo Ersek wrote: > On 9/25/23 16:04, Richard W.M. Jones wrote: > > Read HKLM\SYSTEM\CurrentControlSet\Control\TimeZoneInformation key > > "RealTimeIsUniversal" to see if the Windows guest is expecting BIOS > > set to

Re: [Libguestfs] [PATCH v2v 0/5] convert: Find out if Windows guest is expecting BIOS localtime or UTC

2023-09-25 Thread Richard W.M. Jones
On Mon, Sep 25, 2023 at 05:49:18PM +0200, Laszlo Ersek wrote: > On 9/25/23 17:48, Laszlo Ersek wrote: > > On 9/25/23 16:04, Richard W.M. Jones wrote: > >> [Alice: See patch 2] > >> > >> [This patch is a bit rough, it could do with better commit messages > &g

Re: [Libguestfs] [PATCH v2v 3/5] -o libvirt: Add to libvirt XML

2023-09-25 Thread Richard W.M. Jones
On Mon, Sep 25, 2023 at 05:47:26PM +0200, Laszlo Ersek wrote: > On 9/25/23 16:04, Richard W.M. Jones wrote: > > --- > > output/create_libvirt_xml.ml | 10 -- > > tests/test-v2v-i-ova.xml | 1 + > > 2 files changed, 9 insertions(+), 2 deletions(-) &

Re: [Libguestfs] [PATCH v2v 0/5] convert: Find out if Windows guest is expecting BIOS localtime or UTC

2023-09-25 Thread Richard W.M. Jones
On Mon, Sep 25, 2023 at 04:26:59PM +0200, Alice Frosi wrote: > Hi Rich, > > On Mon, Sep 25, 2023 at 4:10 PM Richard W.M. Jones wrote: > > [Alice: See patch 2] > > > I'm not 100% sure about the source of this work. However, we had in > KubeVirt people in

[Libguestfs] [PATCH v2v 0/5] convert: Find out if Windows guest is expecting BIOS localtime or UTC

2023-09-25 Thread Richard W.M. Jones
[Alice: See patch 2] [This patch is a bit rough, it could do with better commit messages and some tests. Please test it to see if it solves the Windows conversion issue described in the thread below.] We currently do not set any field in guest output. Most Windows guests expect the BIOS to be

[Libguestfs] [PATCH v2v 5/5] convert: Find out if Windows guest is expected BIOS set to localtime

2023-09-25 Thread Richard W.M. Jones
Read HKLM\SYSTEM\CurrentControlSet\Control\TimeZoneInformation key "RealTimeIsUniversal" to see if the Windows guest is expecting BIOS set to localtime (not present) or UTC (present and set to 1). See: https://wiki.archlinux.org/title/System_time#UTC_in_Microsoft_Windows See:

[Libguestfs] [PATCH v2v 2/5] -o kubevirt: Add comment about future support for clock = localtime

2023-09-25 Thread Richard W.M. Jones
--- output/create_kubevirt_yaml.ml | 5 + 1 file changed, 5 insertions(+) diff --git a/output/create_kubevirt_yaml.ml b/output/create_kubevirt_yaml.ml index 689555e4dc..b96c742832 100644 --- a/output/create_kubevirt_yaml.ml +++ b/output/create_kubevirt_yaml.ml @@ -54,6 +54,11 @@ let

[Libguestfs] [PATCH v2v 4/5] -o qemu: Set -rtc base=localtime when guest expects BIOS set to localtime

2023-09-25 Thread Richard W.M. Jones
I didn't set the -rtc flag in the normal (UTC) case as that is the default. --- output/output_qemu.ml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/output/output_qemu.ml b/output/output_qemu.ml index 57b1e58da2..a9d7b37071 100644 --- a/output/output_qemu.ml +++ b/output/output_qemu.ml @@

[Libguestfs] [PATCH v2v 3/5] -o libvirt: Add to libvirt XML

2023-09-25 Thread Richard W.M. Jones
--- output/create_libvirt_xml.ml | 10 -- tests/test-v2v-i-ova.xml | 1 + 2 files changed, 9 insertions(+), 2 deletions(-) diff --git a/output/create_libvirt_xml.ml b/output/create_libvirt_xml.ml index 964acd25fd..f97272ca31 100644 --- a/output/create_libvirt_xml.ml +++

[Libguestfs] [PATCH v2v 1/5] types: Add gcaps_bios_utc to record if the BIOS is set to UTC or localtime

2023-09-25 Thread Richard W.M. Jones
This change simply adds the flag to guestcaps, and sets it to always true, so there is no change to the output. --- lib/types.mli | 5 + convert/convert_linux.ml | 1 + convert/convert_windows.ml | 1 + lib/types.ml | 3 +++ 4 files changed, 10 insertions(+) diff

Re: [Libguestfs] Fwd: virt-v2v creating image that does not install guest agent on first boot

2023-09-25 Thread Richard W.M. Jones
On Mon, Sep 25, 2023 at 01:25:06PM +0100, Daniel P. Berrangé wrote: > On Mon, Sep 25, 2023 at 01:14:40PM +0100, Richard W.M. Jones wrote: > > On Mon, Sep 25, 2023 at 01:09:15PM +0200, Lee Garrett wrote: > > > On 23.09.23 19:37, Laszlo Ersek wrote: > > > >On 9/

Re: [Libguestfs] Fwd: virt-v2v creating image that does not install guest agent on first boot

2023-09-25 Thread Richard W.M. Jones
On Mon, Sep 25, 2023 at 01:09:15PM +0200, Lee Garrett wrote: > On 23.09.23 19:37, Laszlo Ersek wrote: > >On 9/22/23 16:47, Lee Garrett wrote: > >>On 22.09.23 14:54, Richard W.M. Jones wrote: > >>>On Fri, Sep 22, 2023 at 11:40:03AM +0100, Richard W.M. Jones wrote: &g

Re: [Libguestfs] [EXTERNAL] - Re: Libguestfs desired version installation

2023-09-25 Thread Richard W.M. Jones
t; -Original Message----- > From: Richard W.M. Jones > Sent: Monday, September 25, 2023 2:36 PM > To: Teja Konapalli > Cc: libguestfs@redhat.com; Raja Ram Sharma ; Divyanshu > Kumar > Subject: [EXTERNAL] - Re: Libguestfs desired version installation >

Re: [Libguestfs] Libguestfs desired version installation

2023-09-25 Thread Richard W.M. Jones
I read the first email, you don't need to keep sending it. If you upgrade RHEL from 8.2 to the latest (8.8 or 8.9) you will get libguestfs 1.44.0. If you upgrade to RHEL 9 you will get libguestfs 1.50.1. Since you have (still) not described the exact environment you're using, or even

Re: [Libguestfs] Some comments on the libnbd apk in Alpine

2023-09-23 Thread Richard W.M. Jones
; > On Thu, Sep 21, 2023 at 6:02 PM Richard W.M. Jones wrote: > > Hi Sean, the maintainers of libnbd here.  Thanks for packaging libnbd > in Alpine: > > https://git.alpinelinux.org/aports/tree/testing/libnbd/APKBUILD > > I have a few comments: > >

Re: [Libguestfs] [libnbd PATCH] info: Try harder for graceful disconnect from server

2023-09-22 Thread Richard W.M. Jones
On Fri, Sep 22, 2023 at 12:33:36PM -0500, Eric Blake wrote: > There are a number of ways in which gathering information can fail. > But when possible, it makes sense to let the server know that we are > done talking, as it minimizes the likelihood that nbdinfo's error > message will be obscured by

Re: [Libguestfs] Fwd: virt-v2v creating image that does not install guest agent on first boot

2023-09-22 Thread Richard W.M. Jones
On Fri, Sep 22, 2023 at 05:27:25PM +0200, Lee Garrett wrote: > On 22.09.23 16:47, Lee Garrett wrote: > >On 22.09.23 14:54, Richard W.M. Jones wrote: > >>On Fri, Sep 22, 2023 at 11:40:03AM +0100, Richard W.M. Jones wrote: > >>>On Thu, Sep 21, 2023 at 07:47

Re: [Libguestfs] Fwd: virt-v2v creating image that does not install guest agent on first boot

2023-09-22 Thread Richard W.M. Jones
On Fri, Sep 22, 2023 at 11:40:03AM +0100, Richard W.M. Jones wrote: > On Thu, Sep 21, 2023 at 07:47:52PM +0200, Lee Garrett wrote: > > On 21.09.23 19:43, Richard W.M. Jones wrote: > > >So this is probably another instance or variation of the timezone > > >formatting pr

Re: [Libguestfs] Fwd: virt-v2v creating image that does not install guest agent on first boot

2023-09-22 Thread Richard W.M. Jones
On Thu, Sep 21, 2023 at 07:47:52PM +0200, Lee Garrett wrote: > On 21.09.23 19:43, Richard W.M. Jones wrote: > >So this is probably another instance or variation of the timezone > >formatting problem (of schtasks). Which version of virt-v2v is this? > >I want to check th

Re: [Libguestfs] [libnbd PATCH v2 2/6] fuzzing: Disable client-side strictness checks

2023-09-22 Thread Richard W.M. Jones
On Thu, Sep 21, 2023 at 10:22:08PM +0100, Richard W.M. Jones wrote: > On Thu, Sep 21, 2023 at 03:58:01PM -0500, Eric Blake wrote: > > When fuzzing, it is more desirable to always provoke the server into > > sending a response, rather than sometimes accidentally skipping a wire &

Re: [Libguestfs] [libnbd PATCH v2 6/6] info: Tolerate missing size

2023-09-21 Thread Richard W.M. Jones
, "\texport-size: %" PRIi64 "\n", size); > +} > if (content) >fprintf (fp, "\tcontent: %s\n", content); > if (uri) > @@ -273,7 +273,8 @@ show_one_export (struct nbd_handle *nbd, const char *desc, > block_maxi

Re: [Libguestfs] [libnbd PATCH v2 4/6] block_status: Fix assertion with large server size

2023-09-21 Thread Richard W.M. Jones
report a zero-length extent to the callback. Whether or not secalert > advises us to create a CVE for the previous patch, this bug does not > deserve its own CVE as it was only introduced in recent unstable > releases. > > Fixes: e8d837d306 ("block_status: Add

Re: [Libguestfs] [libnbd PATCH v2 5/6] block_status: Fix assertion on bad 64-bit block status reply

2023-09-21 Thread Richard W.M. Jones
able released > libnbd. Thus, there is no reason to create a CVE, although since I > will already be doing a security info email about previous patches > also addressing fuzzer findings, I can mention this at the same time. > > Fixes: ab992766cd ("block_status: Accept 64-bit exten

Re: [Libguestfs] [libnbd PATCH v2 2/6] fuzzing: Disable client-side strictness checks

2023-09-21 Thread Richard W.M. Jones
ver ] )* where [ request + args ] would be a simple serialized representation of a synchronous nbd_* API call? I think that would work ... Rich. > Signed-off-by: Eric Blake > Reviewed-by: Richard W.M. Jones > Reviewed-by: Laszlo Ersek > --- > fuzzing/libnbd-fuzz-wrapper.c |

Re: [Libguestfs] [libnbd PATCH v2 3/6] api: Sanitize sizes larger than INT64_MAX

2023-09-21 Thread Richard W.M. Jones
ngdesc = "\ > -Returns the size in bytes of the NBD export." > +Returns the size in bytes of the NBD export. > + > +Note that this call fails with C for an unlikely > +server that advertises a size which cannot fit in a 64-bit > +signed integer." > ^ non_blocking_te

Re: [Libguestfs] Fwd: virt-v2v creating image that does not install guest agent on first boot

2023-09-21 Thread Richard W.M. Jones
On Thu, Sep 21, 2023 at 06:24:40PM +0200, Lee Garrett wrote: > On 21.09.23 18:08, Richard W.M. Jones wrote: > >On Thu, Sep 21, 2023 at 04:50:26PM +0200, Lee Garrett wrote: > >>After testing it again today, the guest agent is still not > >>installed, however this ti

Re: [Libguestfs] Fwd: virt-v2v creating image that does not install guest agent on first boot

2023-09-21 Thread Richard W.M. Jones
mmon/blob/e70d89a58dae068be2e19c7c21558707261af96a/mlcustomize/inject_virtio_win.ml#L580 However there have been timezone bugs with this in the past (and maybe there still are), see the sordid history in these two links: https://github.com/libguestfs/libguestfs-common/blob/e70d89a58dae068b

[Libguestfs] Some comments on the libnbd apk in Alpine

2023-09-21 Thread Richard W.M. Jones
Hi Sean, the maintainers of libnbd here. Thanks for packaging libnbd in Alpine: https://git.alpinelinux.org/aports/tree/testing/libnbd/APKBUILD I have a few comments: (1) The url field should be "https://gitlab.com/nbdkit/libnbd; (The one you are using is an old, stale mirror) (2) libxml2-dev

Re: [Libguestfs] [PATCH libguestfs] daemon: Omit 'file -S' option on older distros that lack support

2023-09-21 Thread Richard W.M. Jones
This is upstream in c95d8c4cf64142. Also added a few commits to fix the Ruby tests which had broken because of a recent change to Ruby. I'll cut a development release soon. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and

Re: [Libguestfs] [PATCH libguestfs] daemon: Omit 'file -S' option on older distros that lack support

2023-09-21 Thread Richard W.M. Jones
On Thu, Sep 21, 2023 at 03:56:05PM +0200, Laszlo Ersek wrote: ... > > +open Std_utils > > + > > +(* Does [file] support the [-S] / [--no-sandbox] option > > + * (not on OpenSUSE LEAP 15). > > + *) > > +let file_has_S_option = lazy ( > > + let out = Utils.command "file" ["file"; "--help"] in > >

[Libguestfs] [PATCH libguestfs] daemon: Omit 'file -S' option on older distros that lack support

2023-09-21 Thread Richard W.M. Jones
OpenSUSE LEAP 15 lacks support for this option, so test for it before using it. See-also: https://listman.redhat.com/archives/libguestfs/2023-September/032613.html Report-by: Olaf Hering Fixes: commit 23986d3c4f4d1f9cbac44cc743d3e6af721e4237 --- daemon/Makefile.am | 2 ++ daemon/file.ml

Re: [Libguestfs] regression: file does not understand the -S option

2023-09-21 Thread Richard W.M. Jones
On Wed, Sep 20, 2023 at 11:42:55PM +0200, Olaf Hering wrote: > Recently a commit was added to call 'file -zSb' instead of 'file -zb'. > > This causes a regression on Leap 15 (but not on Tumbleweed), because > file 5.32 does not understand the -S option. > > How can this be fixed properly, to

Re: [Libguestfs] [EXTERNAL] - Re: LIBGUESTFS mount disk failure

2023-09-20 Thread Richard W.M. Jones
On Wed, Sep 20, 2023 at 09:53:19AM +, Divyanshu Kumar wrote: > Hi @Richard W.M. Jones, > > I am attaching a sample program of how we are using guestfs apis > where we are getting this error guestfs_mount_local fail. It works fine, I see no errors when I run it. This is the th

Re: [Libguestfs] [EXTERNAL] - Re: LIBGUESTFS mount disk failure

2023-09-19 Thread Richard W.M. Jones
> Thanks > RR > > > > > > -Original Message- > From: Richard W.M. Jones > Sent: Tuesday, September 19, 2023 1:15 PM > To: Raja Ram Sharma > Cc: Teja Konapalli ; libguestfs@redhat.com; > Divyanshu Kumar > Subject: Re: [EXTERNAL] - Re: LIB

Re: [Libguestfs] [External] Re: [PATCH] VxFS Filesystem support to libguestfs

2023-09-19 Thread Richard W.M. Jones
A new patch is attached. This is only build tested so far. To build with this patch I had to do: ./configure --enable-werror \ --with-supermin-packager-config=$PWD/localyum.conf where localyum.conf contains:

Re: [Libguestfs] [External] Re: [PATCH] VxFS Filesystem support to libguestfs

2023-09-19 Thread Richard W.M. Jones
On Fri, Sep 15, 2023 at 11:37:32AM +, Ravi Singh wrote: > >>> Fixed. Added VRTS* packages to packagelist.in and removed the > above scripts from hostfiles. OK, that should work. I will test it out later. One issue we'll probably have is how to package this up for Fedora or RHEL as those

Re: [Libguestfs] [EXTERNAL] - Re: LIBGUESTFS mount disk failure

2023-09-19 Thread Richard W.M. Jones
On Sun, Sep 17, 2023 at 04:11:25PM +, Raja Ram Sharma wrote: > One more help is needed : https://github.com/libguestfs/libguestfs/issues/124 > /***/ > I can get guestfs_last_error using function_callback and write to log file. > But "event Handling" is not

Re: [Libguestfs] [libnbd PATCH] generator: Fix assertion with ill-formed 64-bit block status reply

2023-09-19 Thread Richard W.M. Jones
metimes split across states based on what made the next state easier > to code). > > Requires a non-compliant server, but I was able to come up with a > one-line tweak to pending qemu patches that could trigger it. Not > creating a CVE as it only appears in unstable releases. > >

Re: [Libguestfs] [EXTERNAL] - Re: LIBGUESTFS mount disk failure

2023-09-17 Thread Richard W.M. Jones
On Sun, Sep 17, 2023 at 03:55:24AM +, Raja Ram Sharma wrote: > Hi Richard, > > Wish you a happy weekend! > > Guestfs_launch fails after below error : > > libguestfs: is_openable: /dev/kvm: No such file or directory > libguestfs: trace: get_backend_setting "force_tcg"

Re: [Libguestfs] [EXTERNAL] - Re: LIBGUESTFS mount disk failure

2023-09-16 Thread Richard W.M. Jones
Thanks for providing the libguestfs-test-tool output in a previous message. > While: guestfs_lanch error: > libguestfs: trace: set_verbose true > libguestfs: trace: set_verbose = 0 > libguestfs: trace: set_backend "direct" > libguestfs: trace: set_backend = 0 Here you're

Re: [Libguestfs] [EXTERNAL] - Re: LIBGUESTFS mount disk failure

2023-09-16 Thread Richard W.M. Jones
Hi, can you run: libguestfs-test-tool and send us the complete output. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com Fedora Windows cross-compiler. Compile Windows programs, test,

Re: [Libguestfs] LIBGUESTFS mount disk failure

2023-09-16 Thread Richard W.M. Jones
On Sat, Sep 16, 2023 at 03:56:07PM +, Teja Konapalli wrote: > Hi Richard & Team, > > > > Could you please help here on the below failure of mounting disk using > libguestfs. > > > > OS version: RHEL 8.2 > > Libguestfs version: 1.38.0 stable > > > > > > Error logs: > > > >

Re: [Libguestfs] [PATCH] VxFS Filesystem support to libguestfs

2023-09-14 Thread Richard W.M. Jones
On Thu, Jun 08, 2023 at 11:38:53AM +0100, Richard W.M. Jones wrote: > From: Ravi Singh First, thanks to various people who helped me to get Infoscale Storage installed. I have questions ... > appliance/hostfiles.in| 4 ++ > appliance/init| 2 + > daemon

[Libguestfs] Plans for nbdkit 1.36 & libnbd 1.18

2023-09-12 Thread Richard W.M. Jones
The current stable versions of nbdkit & libnbd were first released on: nbdkit 1.34.0 => 14 April 2023 libnbd 1.16.0 => 18 April 2023 which is about 5 months ago. Since we tend to release these projects approximately every 6 months, I'd like to aim for a release at the end of September or

Re: [Libguestfs] [EXTERNAL] - Re: LIBGUESTFS supported version

2023-09-12 Thread Richard W.M. Jones
ds, > Teja K > > -Original Message- > From: Richard W.M. Jones > Sent: Tuesday, September 12, 2023 1:14 PM > To: Teja Konapalli > Cc: libguestfs@redhat.com > Subject: Re: [EXTERNAL] - Re: [Libguestfs] LIBGUESTFS supported version > > CAUTION: This email origi

Re: [Libguestfs] [EXTERNAL] - Re: LIBGUESTFS supported version

2023-09-12 Thread Richard W.M. Jones
On Tue, Sep 12, 2023 at 06:44:54AM +, Teja Konapalli wrote: > Hi Richard & Team, > > Am getting below issue frequently when I try to mount using libguestfs. > > [ 2023-09-12 08:17:43 ] errno: ( 0 ) : mount_local: unknown option > 1804310928 (this can happen if a program is compiled against

Re: [Libguestfs] Fwd: virt-v2v creating image that does not install guest agent on first boot

2023-09-11 Thread Richard W.M. Jones
If we suspect that the whole firstboot mechanism might not be working with the new version of Windows, one way to test it (on this one, or a freshly installed Windows VM) would be: $ virt-customize -a windows.img --firstboot-command 'echo hello' and see if "hello" is written in some form to

Re: [Libguestfs] [PATCH nbdkit 10/10] XXX docs: Remove references to -U - when it is implicit

2023-09-11 Thread Richard W.M. Jones
This series, minus the delayed documentation patch, plus the --dump-config patch, was pushed as: ff3c9eb0e..868954b23 Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com libguestfs lets

Re: [Libguestfs] [PATCH nbdkit 10/10] XXX docs: Remove references to -U - when it is implicit

2023-09-11 Thread Richard W.M. Jones
On Mon, Sep 11, 2023 at 09:34:50AM -0500, Eric Blake wrote: > On Sat, Sep 09, 2023 at 02:57:58PM +0100, Richard W.M. Jones wrote: > > XXX NOTE XXX > > > > I would not apply this patch immediately, since online documentation > > will get updated as soon as I do that. Be

Re: [Libguestfs] [PATCH nbdkit 04/10] server: Calculate $uri in one place

2023-09-11 Thread Richard W.M. Jones
On Mon, Sep 11, 2023 at 09:19:12AM -0500, Eric Blake wrote: > On Mon, Sep 11, 2023 at 03:09:21PM +0100, Richard W.M. Jones wrote: > > > > - case SERVICE_MODE_UNIXSOCKET: > > > > -fprintf (fp, "nbd%s+unix://", tls == 2 ? "s" : ""); >

Re: [Libguestfs] [PATCH nbdkit 05/10] server: Add the NBD URI to debug output

2023-09-11 Thread Richard W.M. Jones
On Mon, Sep 11, 2023 at 09:04:13AM -0500, Eric Blake wrote: > Do we also want to output a debug statement when a URI is not > possible, such as under -s? Yes, I'll add something for those two cases. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my

Re: [Libguestfs] [PATCH nbdkit 04/10] server: Calculate $uri in one place

2023-09-11 Thread Richard W.M. Jones
On Mon, Sep 11, 2023 at 09:01:47AM -0500, Eric Blake wrote: > On Sat, Sep 09, 2023 at 02:57:52PM +0100, Richard W.M. Jones wrote: > > Move the calculation of $uri to the main function (well, inlined > > there), and out of --run code. > > > > This is largely code mo

Re: [Libguestfs] [PATCH nbdkit 00/10] Make --run imply -U -

2023-09-11 Thread Richard W.M. Jones
On Mon, Sep 11, 2023 at 08:18:04AM -0500, Eric Blake wrote: > On Mon, Sep 11, 2023 at 01:11:46PM +0100, Richard W.M. Jones wrote: > > On Mon, Sep 11, 2023 at 07:08:48AM -0500, Eric Blake wrote: > > > On Sat, Sep 09, 2023 at 02:57:48PM +0100, Richard W.M. Jones wrote: > &

Re: [Libguestfs] Fwd: virt-v2v creating image that does not install guest agent on first boot

2023-09-11 Thread Richard W.M. Jones
On Sun, Sep 10, 2023 at 11:34:22AM +0100, Richard W.M. Jones wrote: > This message got caught in moderation because the attachment > was large. I put the attachment here: > > http://oirase.annexia.org/tmp/2023-lgarrett-virt-v2v-debug-output.txt > > - Forwarded messag

Re: [Libguestfs] [EXTERNAL] - Re: LIBGUESTFS supported version

2023-09-11 Thread Richard W.M. Jones
n of libguestfs, since libguestfs uses your host kernel and host utilities to access the disk (running them in a VM). What exact "unknown filesystem" type was it? Rich. > Thanks > Teja K > > -Original Message- > From: Richard W.M. Jones > Sent: Wednesday, Sep

Re: [Libguestfs] [PATCH nbdkit 00/10] Make --run imply -U -

2023-09-11 Thread Richard W.M. Jones
On Mon, Sep 11, 2023 at 07:08:48AM -0500, Eric Blake wrote: > On Sat, Sep 09, 2023 at 02:57:48PM +0100, Richard W.M. Jones wrote: > > Should have done this a long time ago. I feel it is about time we > > change the default of nbdkit --run to imply -U -, rather than opening &g

[Libguestfs] Fwd: virt-v2v creating image that does not install guest agent on first boot

2023-09-10 Thread Richard W.M. Jones
This message got caught in moderation because the attachment was large. I put the attachment here: http://oirase.annexia.org/tmp/2023-lgarrett-virt-v2v-debug-output.txt - Forwarded message from Lee Garrett - Date: Sun, 10 Sep 2023 00:09:17 +0200 From: Lee Garrett To:

[Libguestfs] [PATCH nbdkit 04/10] server: Calculate $uri in one place

2023-09-09 Thread Richard W.M. Jones
Move the calculation of $uri to the main function (well, inlined there), and out of --run code. This is largely code motion. In theory it changes the content of $uri since we now shell quote it after generating it, but this ought not to have any practical effect. --- server/internal.h | 1 +

[Libguestfs] [PATCH nbdkit 01/10] server: Introduce service_mode concept

2023-09-09 Thread Richard W.M. Jones
Previously there were two places where similiar-ish logic was used to decide if we are going to serve over a socket activation, -s, Unix socket, AF_VSOCK or TCP/IP. Let's abstract that into a service_mode. One place where we did this was when calculating the $uri variable for --run. This change

[Libguestfs] [PATCH nbdkit 09/10] tests: Remove references to -U - when it is implicit

2023-09-09 Thread Richard W.M. Jones
In tests where we used 'nbdkit -U - ... --run', remove -U - as that is now implicit. --- tests/Makefile.am| 2 +- plugins/rust/test-ramdisk.sh | 4 +-- tests/test-S3.sh | 2 +- tests/test-blkio.sh | 2 +-

  1   2   3   4   5   6   7   8   9   10   >