Re: Improvements on usability

2011-09-12 Thread Julia S. Simon
Hi, I got the OK to be listed in Happy Users list. Company name is Tuenti, url: http://tuenti.com Regards, Julia -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/

Re: Improvements on usability

2011-09-12 Thread Christian Hammond
Thanks Julia! I've added it to our list, using the description on the front page. Let me know if you'd like me to change anything. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Mon, Sep 12, 2011 at 12:31

problem upgrading 1.5.6 to 1.6(.1)

2011-09-12 Thread M. Exner
We've been using reviewboard for a while now and had no problems with upgrading several times. We're running it on a windows server using apache 2.2 and mysql 5.5. But now I try to upgrade our 1.5.6 installation to 1.6 I get several database issues. 'rb-site upgrade reviewboard' gives the

Re: problem upgrading 1.5.6 to 1.6(.1)

2011-09-12 Thread Christian Hammond
Hi Martin, The #sql- tables are generated internally by MySQL. Do you know if you're using InnoDB or MyISAM on the database? From a Google search, it seems that there may be several causes for this. It's basically a very misleading error message, and seems to vary on configuration. What version

Re: problem upgrading 1.5.6 to 1.6(.1)

2011-09-12 Thread M. Exner
The windows server runs MySQL v5.5.10 using InnoDB storage engine. But now that I looked at the tables in the windows server's reviewboard db I see they're using MyISAM storage engine. The test server runs MySQL 5.1.54-1ubuntu4 with storage engine unset, so defaulting to MyISAM. Here the tables

Re: problem upgrading 1.5.6 to 1.6(.1)

2011-09-12 Thread M. Exner
Problem solved! I switched all existing reviewboard tables to storage engine InnoDB and the upgrade went fine. Can only imagine the problem was the engine mix of old tables (MyISAM) and newly created tables (InnoDB). Thanks for your help and keep up the great work! Regards, Martin -- Want to

Re: Preserving diff file sort order

2011-09-12 Thread SCFrench
I'm pretty sure I tried that (restarting memcached), but I can try again. Do you know if the sorting occurs when posting the review to the database, or only when viewing the diff? That is, once I've commented out sort calls and restarted memcached, would I need to re-post the diff file or would

Re: Permissions issue

2011-09-12 Thread hs_etd
I did the following in /etc/selinux/config SELINUX=disabled and restarted the system. It still didn't help. I did get a different, yet similar error. This time it wasn't complaining that etdlab (my login) didn't have permission. It was complaining that apache did not have permission to

Re: Problem with WSGI on fresh install

2011-09-12 Thread Nicolas VINOT
Hi, I investigate more on this problem, and it sounds RB is totally unusable on subdirectory installation (« http://forge/reviews/ » in my case). « WSGIScriptAlias » parameter must not finish with a « / », otherwise WSGI concatenate URL-path part to the WSGI script path (leading to « Target

Upgrading from 1.0 to… well… anything

2011-09-12 Thread insysion
I'm in a bit of a bind. Administration for Reviewboard at work has fallen to me after the previous administrator (and installer) left with well intentioned but insufficient documentation. My first problem, I'm looking to upgrade from 1.0 to 1.5 / 1.6 in order to get email notifications, however I

Re: Mod_python error with brand new RB 1.6 installation

2011-09-12 Thread Steve
On Sep 9, 3:35 pm, Christian Hammond chip...@chipx86.com wrote: Can you attach that backends.py file? Something seems very fishy. I'm using a customized backends.py file. Maybe it's incompatible with 1.6? I successfully set up a 1.5 installation several months ago using the same configuration.

Re: Mod_python error with brand new RB 1.6 installation

2011-09-12 Thread Steve
Hi Christian, snip my backends.py file After sending you my backends file, I decided to start with the default backends.py file and then added the additional classes that I needed for theActiveDirectoryGroupMembershipSSLBackend authentication. Then I ran rb-site upgrade and I get a login

Re: Mod_python error with brand new RB 1.6 installation

2011-09-12 Thread Steve
On Sep 12, 11:09 am, Steve seide.al...@gmail.com wrote: Hi Christian, snip my backends.py file After sending you my backends file,  I decided to start with the default backends.py file and then added the additional classes that I needed for theActiveDirectoryGroupMembershipSSLBackend

Re: Upgrading from 1.0 to… well… anything

2011-09-12 Thread Christian Hammond
Hi, What version exactly is this? Almost sounds like a pre-1.0. Before you do anything, back up the site directory and database. Things could get hairy. Can you describe to me the steps you're doing to upgrade? setup.cfg shouldn't come into play unless you're dealing with a source tree. I'm

Re: Mod_python error with brand new RB 1.6 installation

2011-09-12 Thread Christian Hammond
Great :) Best thing to do if you need customizations is to create a brand new Python package for your backend and subclass one of ours, modifying functions as needed. The whole way backends work changed in 1.6. See our Code Base Docs for a link to a guide on custom auth backends. Christian On

Re: problem upgrading 1.5.6 to 1.6(.1)

2011-09-12 Thread Christian Hammond
Excellent! Glad it's working :) Christian On Monday, September 12, 2011, M. Exner ex...@dps-online.de wrote: Problem solved! I switched all existing reviewboard tables to storage engine InnoDB and the upgrade went fine. Can only imagine the problem was the engine mix of old tables (MyISAM)

API issues after 1.6(.1) upgrade

2011-09-12 Thread Matt Whiteley
We were running 1.5.6 and since the upgrade to 1.6 (and now 1.6.1) we are having issues with the API causing the post-review script to fail. I searched for anyone having the same issue but didn't find anything. HTTP GETting api/ HTTP GETting https://reviews.example.com/api/info/ Got API Error

Preventing commits from going through if status is still in review stage

2011-09-12 Thread james
Is there documentation on how to set this up with post-commit or pre- commit hooks where a user can't push changes into the repository unless the changeset has been reviewed and approved? I'm using git as our repo and so far I've gotten as far as being able to use post-review to submit a review

Re: API issues after 1.6(.1) upgrade

2011-09-12 Thread Christian Hammond
I noticed this on a new install and am working on a fix. For now, specify --username= and --password= on the command line for the first post, and it should at least generate the cookie file so you won't hit this again. Can you file a bug? Christian -- Christian Hammond - chip...@chipx86.com

Re: Preventing commits from going through if status is still in review stage

2011-09-12 Thread Christian Hammond
There's nothing we provide, as it varies quite a bit between installs, repository types, etc. Right now anything you do requires a fair bit of custom code. We're working on a formal Python API for Review Board, which will make this easier from a development standpoint. From a workflow

Re: Upgrading from 1.0 to… well… anything

2011-09-12 Thread Christian Hammond
Okay, to make yourself a superuser, do: $ rb-site manage /path/to/site shell from django.contrib.auth.models import User user = User.objects.get(username=your username) user.is_superuser = True user.save() Christian -- Christian Hammond - chip...@chipx86.com Review

Re: Preserving diff file sort order

2011-09-12 Thread Christian Hammond
Actually, I believe it is at upload time. So new diffs should be fine. diffviewer/forms.py would be the place to look. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Mon, Sep 12, 2011 at 6:50 AM, SCFrench

Re: Preventing commits from going through if status is still in review stage

2011-09-12 Thread james
The Python API or even a Restful call to the reviewboard would be nice. Then I could probably call reviewboard from a curl and check on the changeset status. For instance this is my git log: --- SNIPPET --- commit 08c36a414d56a7e1db26bfd7f5fabe2cb9d0aff7 Author: james

LDAP problems

2011-09-12 Thread Jeff Ward
I'm having significant problems getting LDAP authentication to work. First, my problem, then a few suggestions to make this all go a bit easier. My set up is the following: Review board 1.6.1 LDAP server: ldap://loaclhost:389 LDAP Base DN: ou=People,dc=domain,dc=com Given Name Attribute:

Re: Upgrading from 1.0 to… well… anything

2011-09-12 Thread insysion
Sounds great, unfortunately first I need to get me an rb-site tool :) I've scoured the machine where RB is installed and the closest I have is an rb-site.txt describing it's use. But the tool is nowhere to be found. On Sep 12, 8:03 pm, Christian Hammond chip...@chipx86.com wrote: Okay, to make

Re: Upgrading from 1.0 to… well… anything

2011-09-12 Thread Christian Hammond
Hi, rb-site is provided by the ReviewBoard package, which you should install by doing easy_install -U ReviewBoard. You shouldn't need to touch the tatballs. I don't know why it was angry about setup.py, but perhaps it's just too old. Best way to back up the database is by doing an SQL dump.

Re: Preventing commits from going through if status is still in review stage

2011-09-12 Thread Christian Hammond
No, not necessarily. When you post a diff, it generates a squashed diff, whichay mean the SHA1 will differ. We also just have no mechanism today to look up a review request by this sort of info. Christian On Monday, September 12, 2011, james james.ngu...@gmail.com wrote: The Python API or even

Re: Preventing commits from going through if status is still in review stage

2011-09-12 Thread james
On Sep 12, 12:35 pm, Christian Hammond chip...@chipx86.com wrote: No, not necessarily. When you post a diff, it generates a squashed diff, whichay mean the SHA1 will differ. Ah. Got it. We also just have no mechanism today to look up a review request by this sort of info. Yeah. This was

Re: LDAP problems

2011-09-12 Thread Jeff Ward
Some more information, I removed cn as the Full Name Attribute and mail as the Email LDAP Attribute and auth now works (mostly) correctly. Which means that the givenName / sn fields were retrieved correctly, but the cn / mail attributes were not. I would like these attributes to be read,

ReviewBoard on OpenShift Express

2011-09-12 Thread Stephen Gallagher
I don't know how many users on this list are familiar with OpenShift. This is a Red Hat-sponsored cloud service providing virtual applications. One of the popular applications selected for use as a demonstration of the power of OpenShift was ReviewBoard. I'd like to describe for you what I now

Re: ReviewBoard on OpenShift Express

2011-09-12 Thread Christian Hammond
Hey Stephen, Looks like an interesting project. I'll have to look into it more. However, I wouldn't be doing my job if I didn't say that the absolute easiest way to get Review Board, with full support from us, is to use our new hosting service, RBCommons (http://www.rbcommons.com) ;) Christian

Re: API issues after 1.6(.1) upgrade

2011-09-12 Thread Matt Whiteley
I'm including --username and --password when this error occurs. The cookie file is created but only with the comments and no cookie information. Yes, I will create a bug report. On Sep 12, 11:57 am, Christian Hammond chip...@chipx86.com wrote: I noticed this on a new install and am working on a

Re: ReviewBoard on OpenShift Express

2011-09-12 Thread Stephen Gallagher
Oh, absolutely! OpenShift Express doesn't come with application support (and very limited platform support in the free version). I'm not trying to compete with rbcommons! Mostly I thought it might prove interesting to those admins having setup troubles (especially on Windows) On Sep 12, 2011

Re: Upgrading from 1.0 to… well… anything

2011-09-12 Thread Anton Cohen
I did an upgrade from pre-1.0 SVN to 1.5.5. The instructions are in a previous post: http://goo.gl/KFIiT Your steps will be a little different because you are using easy_install. And you might not have the missing table issue I had. easy_install is generally easy to get: Red Hat-based: yum

Re: ReviewBoard on OpenShift Express

2011-09-12 Thread Christian Hammond
No that's great that you linked to it :) I just felt like taking the opportunity to mention RBCommons ;) Anything to help get people set up is helpful. On machines that RB supports well, it's easy, but yeah, Windows and other Linux distros can be a real pain. Christian -- Christian Hammond -

Re: ReviewBoard on OpenShift Express

2011-09-12 Thread Anton Cohen
On Mon, Sep 12, 2011 at 2:51 PM, Stephen Gallagher step...@gallagherhome.com wrote: Mostly I thought it might prove interesting to those admins having setup troubles (especially on Windows) Yeah, this should be a big help to people trying to run Django apps without Linux experiences. I'm pretty

After installation, I see The page you were looking for does not exist.

2011-09-12 Thread Den Mark
For the first time, I installed RB. I installed RB 1.6 on Linux and got The page you were looking for does not exist. when I hit the home page. I can see the Review Board 1.6 header and some links. Something like this.

Issue 2279 in reviewboard: 1.6.1 started to return redirected url instead of configured server name

2011-09-12 Thread reviewboard
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 2279 by kofem...@googlemail.com: 1.6.1 started to return redirected url instead of configured server name http://code.google.com/p/reviewboard/issues/detail?id=2279 * NOTE: Do not post confidential information in this bug

Issue 2280 in reviewboard: API: failure to update review request: AttributeError: 'NoneType' object has no attribute 'startswith'

2011-09-12 Thread reviewboard
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 2280 by robert.munteanu: API: failure to update review request: AttributeError: 'NoneType' object has no attribute 'startswith' http://code.google.com/p/reviewboard/issues/detail?id=2280 What version are you running?

Re: Issue 2280 in reviewboard: API: failure to update review request: AttributeError: 'NoneType' object has no attribute 'startswith'

2011-09-12 Thread reviewboard
Updates: Status: NeedInfo Labels: -Type-Defect Type-Support Comment #1 on issue 2280 by chip...@gmail.com: API: failure to update review request: AttributeError: 'NoneType' object has no attribute 'startswith' http://code.google.com/p/reviewboard/issues/detail?id=2280 Are

Re: Issue 2279 in reviewboard: 1.6.1 started to return redirected url instead of configured server name

2011-09-12 Thread reviewboard
Comment #3 on issue 2279 by chip...@gmail.com: 1.6.1 started to return redirected url instead of configured server name http://code.google.com/p/reviewboard/issues/detail?id=2279 Looks like this was part of the set of fixes in Django 1.3.1 for the security vulnerabilities. See the info at:

Re: Issue 2279 in reviewboard: 1.6.1 started to return redirected url instead of configured server name

2011-09-12 Thread reviewboard
Comment #4 on issue 2279 by kofem...@googlemail.com: 1.6.1 started to return redirected url instead of configured server name http://code.google.com/p/reviewboard/issues/detail?id=2279 Thanks. As we reverted back to 1.6 I will do a second attempt to upgrade tomorrow. -- You received this

Re: Comment on IdeasFor2_0 in reviewboard

2011-09-12 Thread reviewboard
Comment by jonathan...@gmail.com: In the pre-commit use case, I'd like to be able to use ReviewBoard to commit the change to SVN for me. That closes the loop of: Whoops, the developer accidentally committed something that they shouldn't have i.e. what was reviewed is actually what is

Re: Issue 2280 in reviewboard: API: failure to update review request: AttributeError: 'NoneType' object has no attribute 'startswith'

2011-09-12 Thread reviewboard
Comment #2 on issue 2280 by robert.munteanu: API: failure to update review request: AttributeError: 'NoneType' object has no attribute 'startswith' http://code.google.com/p/reviewboard/issues/detail?id=2280 I am posting using the ereviewboard plugin for Eclipse. After setting the

Re: Issue 2280 in reviewboard: API: failure to update review request: AttributeError: 'NoneType' object has no attribute 'startswith'

2011-09-12 Thread reviewboard
Updates: Status: NotABug Comment #3 on issue 2280 by chip...@gmail.com: API: failure to update review request: AttributeError: 'NoneType' object has no attribute 'startswith' http://code.google.com/p/reviewboard/issues/detail?id=2280 (No comment was entered for this change.) --

Issue 2281 in reviewboard: /api/info requested before login

2011-09-12 Thread reviewboard
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 2281 by mwhite...@wordstream.com: /api/info requested before login http://code.google.com/p/reviewboard/issues/detail?id=2281 * NOTE: Do not post confidential information in this bug report. * * If you need immediate

Issue 2282 in reviewboard: Open an issue checkboxes missing on Review Dialog page

2011-09-12 Thread reviewboard
Status: New Owner: Labels: Type-Enhancement Priority-Medium New issue 2282 by pankrato...@gmail.com: Open an issue checkboxes missing on Review Dialog page http://code.google.com/p/reviewboard/issues/detail?id=2282 *NOTE: If you have a patch, please submit it to