Re: Reviewboard Git binary support

[André Klitzing]

Hi there,

looks like the corrupted binary fix.

https://reviews.reviewboard.org/r/10854/

Best regards
  André

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"Review Board Community" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/reviewboard/debcf852-2038-468a-b661-b6bed723a9f0%40googlegroups.com.

Re: Reviewboard Git binary support

[Christian Hammond]

Hi Kevin,

Sorry for the very late reply. We've been pretty busy over the past couple
of months and haven't been able to give community support the attention
we'd like.

I'm a bit surprised to see that this is broken. I'd be curious to know what
that part of the uploaded diff looks like. It's clearly seeing that it's
there and is trying to apply it, but it sounds more like the binary that
the diff was uploaded from and the binary it's trying to apply to are
different. We're just calling out to git to apply the diff that it
generated, so you should see the same results if you were to try to
hand-apply. It could be that the uploaded diff is being mangled, but I
can't say without seeing it.

Christian


On Mon, Apr 20, 2020 at 3:14 PM kevin fortinet 
wrote:

> Hi,
>
> I'm using Reviewboard 2.5.18 and rbtools 1.0.3. I've noticed rbt
> patch/land would always fail if there's a binary in the diff.
>
> Steps:
>
>1. Create a commit with binary and text change. then post it to
>reviewboard
>2. On a clean clone, rbt patch .
>
> I am wondering whether reviewboard supports git binary, and if it doesn't,
> is there a way to avoid skip patching the binaries but to finish with the
> text changes?
>
> kevin@kevin-OptiPlex-7020:~/repo/fac$ rbt patch --debug 60122
> >>> RBTools 1.0.3
> >>> Python 2.7.12 (default, Oct  8 2019, 14:14:10)
> [GCC 5.4.0 20160609]
> >>> Running on Linux-4.15.0-91-generic-x86_64-with-Ubuntu-16.04-xenial
> >>> Home = /home/kevin
> >>> Current directory = /home/kevin/repo/fac
> >>> Command line: rbt patch --debug 60122
> >>> Running: tf vc help
> >>> Checking for a Subversion repository...
> >>> Running: svn --non-interactive info
> >>> Command exited with rc 1: [u'svn', u'--non-interactive', u'info']
> >>> Checking for a Git repository...
> >>> Running: git rev-parse --git-dir
> >>> Running: git config core.bare
> >>> Running: git rev-parse --show-toplevel
> >>> Running: git symbolic-ref -q HEAD
> >>> Running: git config --get branch.master.merge
> >>> Running: git config --get branch.master.remote
> >>> Running: git config --get remote.origin.url
> >>> Repository info: Path: g...@git.corp.abc.com:fac/fortiauthenticator.git,
> Base path: , Supports changesets: False
> >>> Checking for a Mercurial repository...
> >>> Unable to execute "hg --help": skipping Mercurial
> >>> Checking for a CVS repository...
> >>> Unable to execute "cvs": skipping CVS
> >>> Checking for a Perforce repository...
> >>> Unable to execute "p4 help": skipping Perforce
> >>> Checking for a Plastic repository...
> >>> Unable to execute "cm version": skipping Plastic
> >>> Checking for a ClearCase repository...
> >>> Unable to execute "cleartool help": skipping ClearCase
> >>> Checking for a Bazaar repository...
> >>> Unable to execute "bzr help": skipping Bazaar
> >>> Checking for a Team Foundation Server repository...
> >>> Unable to execute "tf help": skipping TFS
> >>> Making HTTP GET request to http://reviewboard-test.corp.abc.com/api/
> >>> Making HTTP GET request to https://reviewboard-test.corp.abc
> .com/api/review-requests/60122/diffs/
> >>> Cached response for HTTP GET 
> >>> https://reviewboard-test.corp.abc.com/api/review-requests/60122/diffs/
> expired and was modified
> >>> Making HTTP GET request to https://reviewboard-test.corp.abc
> .com/api/review-requests/60122/diffs/2/
> >>> Cached response for HTTP GET 
> >>> https://reviewboard-test.corp.abc.com/api/review-requests/60122/diffs/2/
> expired and was not modified
> >>> Making HTTP GET request to https://reviewboard-test.corp.abc
> .com/api/review-requests/60122/diffs/2/
> >>> Cached response for HTTP GET 
> >>> https://reviewboard-test.corp.abc.com/api/review-requests/60122/diffs/2/
> expired and was not modified
> >>> Running: git status --porcelain --untracked-files=no
> --ignore-submodules=dirty
> Patch is being applied from request 60122 with diff revision 2.
> >>> Running: git apply -3 /tmp/rbtools.qYiOC7
> >>> Command exited with rc 1: [u'git', u'apply', u'-3',
> u'/tmp/rbtools.qYiOC7']
> error: missing binary patch data for 'cp'
> error: binary patch does not apply to 'cp'
> Falling back to three-way merge...
> error: missing binary patch data for 'cp'
> error: binary patch does not apply to 'cp'
> error: cp: patch does not apply
> ---
>
> error: missing binary patch data for 'cp'
> error: binary patch does not apply to 'cp'
> Falling back to three-way merge...
> error: missing binary patch data for 'cp'
> error: binary patch does not apply to 'cp'
> error: cp: patch does not apply
>
> Traceback (most recent call last):
>   File "/usr/local/bin/rbt", line 10, in 
> sys.exit(main())
>   File "/usr/local/lib/python2.7/dist-packages/rbtools/commands/main.py",
> line 120, in main
> command.run_from_argv([RB_MAIN, command_name] + args)
>   File
> "/usr/local/lib/python2.7/dist-packages/rbtools/commands/__init__.py", line
> 725, in run_from_argv
> exit_code = self.main(*args) or 0
>   File "/usr/local/lib/python2.7/dist-packages/rbto

Reviewboard Git binary support

[kevin fortinet]

Hi,

I'm using Reviewboard 2.5.18 and rbtools 1.0.3. I've noticed rbt patch/land 
would always fail if there's a binary in the diff.

Steps:

   1. Create a commit with binary and text change. then post it to 
   reviewboard
   2. On a clean clone, rbt patch .

I am wondering whether reviewboard supports git binary, and if it doesn't, 
is there a way to avoid skip patching the binaries but to finish with the 
text changes?

kevin@kevin-OptiPlex-7020:~/repo/fac$ rbt patch --debug 60122 
>>> RBTools 1.0.3
>>> Python 2.7.12 (default, Oct  8 2019, 14:14:10) 
[GCC 5.4.0 20160609]
>>> Running on Linux-4.15.0-91-generic-x86_64-with-Ubuntu-16.04-xenial
>>> Home = /home/kevin
>>> Current directory = /home/kevin/repo/fac
>>> Command line: rbt patch --debug 60122
>>> Running: tf vc help
>>> Checking for a Subversion repository...
>>> Running: svn --non-interactive info
>>> Command exited with rc 1: [u'svn', u'--non-interactive', u'info']
>>> Checking for a Git repository...
>>> Running: git rev-parse --git-dir
>>> Running: git config core.bare
>>> Running: git rev-parse --show-toplevel
>>> Running: git symbolic-ref -q HEAD
>>> Running: git config --get branch.master.merge
>>> Running: git config --get branch.master.remote
>>> Running: git config --get remote.origin.url
>>> Repository info: Path: g...@git.corp.abc.com:fac/fortiauthenticator.git, 
Base path: , Supports changesets: False
>>> Checking for a Mercurial repository...
>>> Unable to execute "hg --help": skipping Mercurial
>>> Checking for a CVS repository...
>>> Unable to execute "cvs": skipping CVS
>>> Checking for a Perforce repository...
>>> Unable to execute "p4 help": skipping Perforce
>>> Checking for a Plastic repository...
>>> Unable to execute "cm version": skipping Plastic
>>> Checking for a ClearCase repository...
>>> Unable to execute "cleartool help": skipping ClearCase
>>> Checking for a Bazaar repository...
>>> Unable to execute "bzr help": skipping Bazaar
>>> Checking for a Team Foundation Server repository...
>>> Unable to execute "tf help": skipping TFS
>>> Making HTTP GET request to http://reviewboard-test.corp.abc.com/api/
>>> Making HTTP GET request to https://reviewboard-test.corp.abc
.com/api/review-requests/60122/diffs/
>>> Cached response for HTTP GET 
>>> https://reviewboard-test.corp.abc.com/api/review-requests/60122/diffs/ 
expired and was modified
>>> Making HTTP GET request to https://reviewboard-test.corp.abc
.com/api/review-requests/60122/diffs/2/
>>> Cached response for HTTP GET 
>>> https://reviewboard-test.corp.abc.com/api/review-requests/60122/diffs/2/ 
expired and was not modified
>>> Making HTTP GET request to https://reviewboard-test.corp.abc
.com/api/review-requests/60122/diffs/2/
>>> Cached response for HTTP GET 
>>> https://reviewboard-test.corp.abc.com/api/review-requests/60122/diffs/2/ 
expired and was not modified
>>> Running: git status --porcelain --untracked-files=no 
--ignore-submodules=dirty
Patch is being applied from request 60122 with diff revision 2.
>>> Running: git apply -3 /tmp/rbtools.qYiOC7
>>> Command exited with rc 1: [u'git', u'apply', u'-3', 
u'/tmp/rbtools.qYiOC7']
error: missing binary patch data for 'cp'
error: binary patch does not apply to 'cp'
Falling back to three-way merge...
error: missing binary patch data for 'cp'
error: binary patch does not apply to 'cp'
error: cp: patch does not apply
---

error: missing binary patch data for 'cp'
error: binary patch does not apply to 'cp'
Falling back to three-way merge...
error: missing binary patch data for 'cp'
error: binary patch does not apply to 'cp'
error: cp: patch does not apply

Traceback (most recent call last):
  File "/usr/local/bin/rbt", line 10, in 
sys.exit(main())
  File "/usr/local/lib/python2.7/dist-packages/rbtools/commands/main.py", 
line 120, in main
command.run_from_argv([RB_MAIN, command_name] + args)
  File 
"/usr/local/lib/python2.7/dist-packages/rbtools/commands/__init__.py", line 
725, in run_from_argv
exit_code = self.main(*args) or 0
  File "/usr/local/lib/python2.7/dist-packages/rbtools/commands/patch.py", 
line 203, in main
revert=self.options.revert_patch)
  File "/usr/local/lib/python2.7/dist-packages/rbtools/commands/patch.py", 
line 119, in apply_patch
'Unable to apply the patch. The patch may be invalid, or '
rbtools.commands.CommandError: Unable to apply the patch. The patch may be 
invalid, or there may be conflicts that could not be resolved.



-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"Review Board Community" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/reviewb

reviewboard + git

[spronyuk]

Hi guys!

Now I implementing a reviewboard and git in our company (now we used svn).

I have one question about creating a new review requests in reviewboard.
When I choose repository (type: svn), I see some "form" below, like this:





There (in this form) I can choose folder with all commits and then I can 
create a new review request from selected commit. It is very easy for users.

But! When I choose repository (type: git), I don`t see this form below.
Does reviewboard have this feature (form) for git types or no?
If no, how should I create a new review request in reviewboard for my 
necessary commit? I want to create it via reviewboard web. It would be also 
easy for users.

Thanks.

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: Reviewboard Git Configuration

[David Trowbridge]

Mohamed,

See
https://www.reviewboard.org/docs/manual/2.0/admin/configuration/repositories/#raw-file-urls

-David

On Wed, Jun 24, 2015 at 9:26 PM,  wrote:

> Hi,
>
> I have to configure Git (gitweb) with Reviewboard. And we have decided not
> to go with local clone option.
> Going forward, 'Raw File URLs' configuration; pls provide the steps.
>
> Thanks,
> Mohamed Kamal
>
>  --
> Supercharge your Review Board with Power Pack:
> https://www.reviewboard.org/powerpack/
> Want us to host Review Board for you? Check out RBCommons:
> https://rbcommons.com/
> Happy user? Let us know! https://www.reviewboard.org/users/
> ---
> You received this message because you are subscribed to the Google Groups
> "reviewboard" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to reviewboard+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Reviewboard Git Configuration

[mohamed . kamal]

Hi,

I have to configure Git (gitweb) with Reviewboard. And we have decided not 
to go with local clone option. 
Going forward, 'Raw File URLs' configuration; pls provide the steps.

Thanks,
Mohamed Kamal

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: Reviewboard GIT configuration

[Jan Koprowski]

Also using Gitolite as repository-hosting solution solve Your problem
because You can dedicate one, the same user for access control to Git
repositories.

On Wed, May 4, 2011 at 9:31 AM, Christian Hammond  wrote:
> Hi,
>
> If you're using a recent Review Board 1.5 release, and a recent RBTools, you
> can use named repositories instead. See
>
> http://www.reviewboard.org/docs/manual/dev/users/tools/post-review/#repository
>
> Christian
>
> --
> Christian Hammond - chip...@chipx86.com
> Review Board - http://www.reviewboard.org
> VMware, Inc. - http://www.vmware.com
>
>
> On Wed, May 4, 2011 at 12:21 AM, Fv  wrote:
>>
>> Hi there,
>>
>> We are using reviewboard with GIT.
>> Until now, we access git repository through SSH and a single user
>> account for all git pusher.
>>
>> For a more fine grained administration, we would like to use one user
>> account per git pusher.
>>
>> The problem we have is that for post-review tool to work we needs to
>> have all the same " git remote show origin" value (which is compared
>> with "Mirror Path" configuration variable).
>>
>> That is not the case if each user use a different ssh user account
>> (ssh://user1@server/repo and ssh://user2@server/repo) and can't be the
>> same as "Mirror path" repository configuration variable.
>>
>> Is anyone using a similar configuration and/or have the same problem ?
>>
>> Cheers,
>> F.
>>
>> --
>> Want to help the Review Board project? Donate today at
>> http://www.reviewboard.org/donate/
>> Happy user? Let us know at http://www.reviewboard.org/users/
>> -~--~~~~--~~--~--~---
>> To unsubscribe from this group, send email to
>> reviewboard+unsubscr...@googlegroups.com
>> For more options, visit this group at
>> http://groups.google.com/group/reviewboard?hl=en
>
> --
> Want to help the Review Board project? Donate today at
> http://www.reviewboard.org/donate/
> Happy user? Let us know at http://www.reviewboard.org/users/
> -~--~~~~--~~--~--~---
> To unsubscribe from this group, send email to
> reviewboard+unsubscr...@googlegroups.com
> For more options, visit this group at
> http://groups.google.com/group/reviewboard?hl=en



-- 
><> Jan Koprowski

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en

Re: Reviewboard GIT configuration

[Christian Hammond]

Hi,

If you're using a recent Review Board 1.5 release, and a recent RBTools, you
can use named repositories instead. See

http://www.reviewboard.org/docs/manual/dev/users/tools/post-review/#repository

Christian

-- 
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.com


On Wed, May 4, 2011 at 12:21 AM, Fv  wrote:

> Hi there,
>
> We are using reviewboard with GIT.
> Until now, we access git repository through SSH and a single user
> account for all git pusher.
>
> For a more fine grained administration, we would like to use one user
> account per git pusher.
>
> The problem we have is that for post-review tool to work we needs to
> have all the same " git remote show origin" value (which is compared
> with "Mirror Path" configuration variable).
>
> That is not the case if each user use a different ssh user account
> (ssh://user1@server/repo and ssh://user2@server/repo) and can't be the
> same as "Mirror path" repository configuration variable.
>
> Is anyone using a similar configuration and/or have the same problem ?
>
> Cheers,
> F.
>
> --
> Want to help the Review Board project? Donate today at
> http://www.reviewboard.org/donate/
> Happy user? Let us know at http://www.reviewboard.org/users/
> -~--~~~~--~~--~--~---
> To unsubscribe from this group, send email to
> reviewboard+unsubscr...@googlegroups.com
> For more options, visit this group at
> http://groups.google.com/group/reviewboard?hl=en

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en

Reviewboard GIT configuration

[Fv]

Hi there,

We are using reviewboard with GIT.
Until now, we access git repository through SSH and a single user
account for all git pusher.

For a more fine grained administration, we would like to use one user
account per git pusher.

The problem we have is that for post-review tool to work we needs to
have all the same " git remote show origin" value (which is compared
with "Mirror Path" configuration variable).

That is not the case if each user use a different ssh user account
(ssh://user1@server/repo and ssh://user2@server/repo) and can't be the
same as "Mirror path" repository configuration variable.

Is anyone using a similar configuration and/or have the same problem ?

Cheers,
F.

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en

Re: ReviewBoard git support

[Aleix Pol]

On Fri, Oct 29, 2010 at 1:27 AM, Stephen Gallagher wrote:

>
>
> On Oct 28, 5:59 pm, Aleix Pol  wrote:
> > Hi ReviewBoardians!
> > I'm a KDE developer and we're being moved from svn to git. In KDevelop we
> > where using gitorious, there's a feature called merge request where a
> branch
> > is given and it is compared to its parent which is pretty cool because
> > you're not forced to create a plain patch (without all the history).
> >
> > I guess it should be quite easy to add that into ReviewBoard by
> processing
> > the output of a git call instead of a patch file, do you think it would
> be
> > feasable?
> >
>
> Check out RBtools' post-review.
>
> http://www.reviewboard.org/docs/releasenotes/dev/rbtools/0.2/
>
> --
> Want to help the Review Board project? Donate today at
> http://www.reviewboard.org/donate/
> Happy user? Let us know at http://www.reviewboard.org/users/
> -~--~~~~--~~--~--~---
> To unsubscribe from this group, send email to
> reviewboard+unsubscr...@googlegroups.com
> For more options, visit this group at
> http://groups.google.com/group/reviewboard?hl=en


I was thinking more like RB could understand DVCS contribution paradigm. I
don't really like to tell newcomers (the ones who use RB) to install a new
application, also this would make it a little hard to tell what has to be
merged.

Aleix

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en

Re: ReviewBoard git support

[Stephen Gallagher]

On Oct 28, 5:59 pm, Aleix Pol  wrote:
> Hi ReviewBoardians!
> I'm a KDE developer and we're being moved from svn to git. In KDevelop we
> where using gitorious, there's a feature called merge request where a branch
> is given and it is compared to its parent which is pretty cool because
> you're not forced to create a plain patch (without all the history).
>
> I guess it should be quite easy to add that into ReviewBoard by processing
> the output of a git call instead of a patch file, do you think it would be
> feasable?
>

Check out RBtools' post-review.

http://www.reviewboard.org/docs/releasenotes/dev/rbtools/0.2/

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en

ReviewBoard git support

[Aleix Pol]

Hi ReviewBoardians!
I'm a KDE developer and we're being moved from svn to git. In KDevelop we
where using gitorious, there's a feature called merge request where a branch
is given and it is compared to its parent which is pretty cool because
you're not forced to create a plain patch (without all the history).

I guess it should be quite easy to add that into ReviewBoard by processing
the output of a git call instead of a patch file, do you think it would be
feasable?

Thanks!
Aleix

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en

Re: ReviewBoard-GIT: Local Clone

[Christian Hammond]

Hi Robert,

And just to be sure, that path exists on the server running Review Board?

If you have logging turned on, there should be *something* in the log files
on this.

You can try doing this:

git --git-dir=/home/rpachos/git/testrepo/.git config
core.repositoryformatversion

That's what Review Board is doing to test that repository. If it fails, then
hopefully you'll have a better idea of why.

You may want to upgrade to 1.5 RC 1, which works far better with Git and
lets you use cgit/gitweb/etc. instead of a local git clone for accessing
files. It's easier to maintain.


Christian

-- 
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.com


On Mon, Jun 28, 2010 at 7:57 AM, Robert Pachos  wrote:

>
> On Jun 25, 7:01 am, Christian Hammond  wrote:
>
> Thanks for the response Christian.
>
> > Make sure that git is installed and in the path on the server running
> Review
> > Board. What's happening is that we're trying to use git to check on the
> > repository, and failing.
> >
> > If git is indeed installed, try removing the "/.git" part from the path.
>
> I confirmed both that git is in the apache user's path, as well as
> tried to remove the git subdirectory from the repo path.
>
> rpac...@huxley:~$ ps -ef | grep apache
> root  1142 1  0 10:16 ?00:00:00 /usr/sbin/apache2 -k
> start
> www-data  1144  1142  0 10:16 ?00:00:00 /usr/sbin/apache2 -k
> start
> www-data  1212  1142  0 10:16 ?00:00:00 /usr/sbin/apache2 -k
> start
> www-data  1213  1142  0 10:16 ?00:00:00 /usr/sbin/apache2 -k
> start
> rpachos   2495  2376  0 10:30 pts/000:00:00 grep apache
> rpac...@huxley:~$ sudo su - www-data
> [sudo] password for rpachos:
> $ which git
> /usr/bin/git
> $
>
> I also checked the webserver logs to see if perhaps there might be an
> error message present that might help, no luck there.  Any additional
> suggestions as to things that I can check/try?
>
> Thanks again,
>
> Rob
>
> > --
> > Christian Hammond - chip...@chipx86.com
> > Review Board -http://www.reviewboard.org
> > VMware, Inc. -http://www.vmware.com
> >
> > On Thu, Jun 24, 2010 at 3:00 PM, Robert Pachos 
> wrote:
> > > Hi there,
> >
> > > I'm trying out RB 1.0.8 on linux with Git and I'm having trouble
> > > configuring a local repository.  When I go to "New Review Request" I
> > > don't get any valid repositories in the list.  I have configured the
> > > git repository as follows in RB:
> >
> > > Name: Test Repo
> > > Path: /home/rpachos/git/testrepo/.git
> > > Repository Type: Git
> >
> > > Everything else is blank.
> >
> > > The test repository is local to the machine running RB and is a non-
> > > bare clone that is readable and executable by the apache user.  I've
> > > reviewed the following doc and don't see anything else that's required/
> > > wrong.
> >
> > >http://www.reviewboard.org/docs/manual/dev/admin/management/repositor.
> ..
> >
> > > Any help would be much appreciated!
> >
> > > Rob
> >
> > > --
> > > Want to help the Review Board project? Donate today at
> > >http://www.reviewboard.org/donate/
> > > Happy user? Let us know athttp://www.reviewboard.org/users/
> > > -~--~~~~--~~--~--~---
> > > To unsubscribe from this group, send email to
> > > reviewboard+unsubscr...@googlegroups.com
> 
> >
> > > For more options, visit this group at
> > >http://groups.google.com/group/reviewboard?hl=en
>
> --
> Want to help the Review Board project? Donate today at
> http://www.reviewboard.org/donate/
> Happy user? Let us know at http://www.reviewboard.org/users/
> -~--~~~~--~~--~--~---
> To unsubscribe from this group, send email to
> reviewboard+unsubscr...@googlegroups.com
> For more options, visit this group at
> http://groups.google.com/group/reviewboard?hl=en
>

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en

Re: ReviewBoard-GIT: Local Clone

[Robert Pachos]

On Jun 25, 7:01 am, Christian Hammond  wrote:

Thanks for the response Christian.

> Make sure that git is installed and in the path on the server running Review
> Board. What's happening is that we're trying to use git to check on the
> repository, and failing.
>
> If git is indeed installed, try removing the "/.git" part from the path.

I confirmed both that git is in the apache user's path, as well as
tried to remove the git subdirectory from the repo path.

rpac...@huxley:~$ ps -ef | grep apache
root  1142 1  0 10:16 ?00:00:00 /usr/sbin/apache2 -k
start
www-data  1144  1142  0 10:16 ?00:00:00 /usr/sbin/apache2 -k
start
www-data  1212  1142  0 10:16 ?00:00:00 /usr/sbin/apache2 -k
start
www-data  1213  1142  0 10:16 ?00:00:00 /usr/sbin/apache2 -k
start
rpachos   2495  2376  0 10:30 pts/000:00:00 grep apache
rpac...@huxley:~$ sudo su - www-data
[sudo] password for rpachos:
$ which git
/usr/bin/git
$

I also checked the webserver logs to see if perhaps there might be an
error message present that might help, no luck there.  Any additional
suggestions as to things that I can check/try?

Thanks again,

Rob

> --
> Christian Hammond - chip...@chipx86.com
> Review Board -http://www.reviewboard.org
> VMware, Inc. -http://www.vmware.com
>
> On Thu, Jun 24, 2010 at 3:00 PM, Robert Pachos  wrote:
> > Hi there,
>
> > I'm trying out RB 1.0.8 on linux with Git and I'm having trouble
> > configuring a local repository.  When I go to "New Review Request" I
> > don't get any valid repositories in the list.  I have configured the
> > git repository as follows in RB:
>
> > Name: Test Repo
> > Path: /home/rpachos/git/testrepo/.git
> > Repository Type: Git
>
> > Everything else is blank.
>
> > The test repository is local to the machine running RB and is a non-
> > bare clone that is readable and executable by the apache user.  I've
> > reviewed the following doc and don't see anything else that's required/
> > wrong.
>
> >http://www.reviewboard.org/docs/manual/dev/admin/management/repositor...
>
> > Any help would be much appreciated!
>
> > Rob
>
> > --
> > Want to help the Review Board project? Donate today at
> >http://www.reviewboard.org/donate/
> > Happy user? Let us know athttp://www.reviewboard.org/users/
> > -~--~~~~--~~--~--~---
> > To unsubscribe from this group, send email to
> > reviewboard+unsubscr...@googlegroups.com
> > For more options, visit this group at
> >http://groups.google.com/group/reviewboard?hl=en

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en

Re: ReviewBoard-GIT: Local Clone

[Christian Hammond]

Hi Rob,

Make sure that git is installed and in the path on the server running Review
Board. What's happening is that we're trying to use git to check on the
repository, and failing.

If git is indeed installed, try removing the "/.git" part from the path.

Christian

-- 
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.com


On Thu, Jun 24, 2010 at 3:00 PM, Robert Pachos  wrote:

> Hi there,
>
> I'm trying out RB 1.0.8 on linux with Git and I'm having trouble
> configuring a local repository.  When I go to "New Review Request" I
> don't get any valid repositories in the list.  I have configured the
> git repository as follows in RB:
>
> Name: Test Repo
> Path: /home/rpachos/git/testrepo/.git
> Repository Type: Git
>
> Everything else is blank.
>
> The test repository is local to the machine running RB and is a non-
> bare clone that is readable and executable by the apache user.  I've
> reviewed the following doc and don't see anything else that's required/
> wrong.
>
> http://www.reviewboard.org/docs/manual/dev/admin/management/repositories/
>
> Any help would be much appreciated!
>
> Rob
>
> --
> Want to help the Review Board project? Donate today at
> http://www.reviewboard.org/donate/
> Happy user? Let us know at http://www.reviewboard.org/users/
> -~--~~~~--~~--~--~---
> To unsubscribe from this group, send email to
> reviewboard+unsubscr...@googlegroups.com
> For more options, visit this group at
> http://groups.google.com/group/reviewboard?hl=en

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en

ReviewBoard-GIT: Local Clone

[Robert Pachos]

Hi there,

I'm trying out RB 1.0.8 on linux with Git and I'm having trouble
configuring a local repository.  When I go to "New Review Request" I
don't get any valid repositories in the list.  I have configured the
git repository as follows in RB:

Name: Test Repo
Path: /home/rpachos/git/testrepo/.git
Repository Type: Git

Everything else is blank.

The test repository is local to the machine running RB and is a non-
bare clone that is readable and executable by the apache user.  I've
reviewed the following doc and don't see anything else that's required/
wrong.

http://www.reviewboard.org/docs/manual/dev/admin/management/repositories/

Any help would be much appreciated!

Rob

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en

Re: ReviewBoard-GIT setup

[Christian Hammond]

Hi,

The Mirror Path is basically an alias for the repository path. If you have
two URLs for the repository (a read-only and a read-write) then you
generally would want to use the read-only URL for Path and the read-write
for Mirror Path.

Raw file URL mask is a URL (with some fields that will be replaced within
that URL) to a path on a Git web viewer (such as cgit or gitweb) for getting
the raw contents of a file.

The raw file URL mask is the only way to do remote Git support. Otherwise,
you need an always up-to-date Git clone on the Review Board server. I'm
planning to make it easier to configure a repository with various Git web
viewers in beta 3, instead of having to enter the mask by hand.

There's information about these fields at:
http://www.reviewboard.org/docs/manual/dev/admin/management/repositories/

Christian

-- 
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.com


On Mon, May 24, 2010 at 12:22 PM, Sapna Vempati wrote:

> Hi,
>
> I am trying to set new git repositories to my test server (with has RB
> 1.0.5 Beta2), through web. I will have about 28 new respositores that would
> have to be set.
>
> Can someone please help on what these 2 fields should contain under ?
>
> Dashboard  > Repositories >
> Add Repository +
>
> Mirror path:
>
> Raw file URL mask:
>
> Thanks a lot for your help in advance ?
>
> Sapna.
>
> --
> Want to help the Review Board project? Donate today at
> http://www.reviewboard.org/donate/
> Happy user? Let us know at http://www.reviewboard.org/users/
> -~--~~~~--~~--~--~---
> To unsubscribe from this group, send email to
> reviewboard+unsubscr...@googlegroups.com
> For more options, visit this group at
> http://groups.google.com/group/reviewboard?hl=en

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en

ReviewBoard-GIT setup

[Sapna Vempati]

Hi,

I am trying to set new git repositories to my test server (with has RB 1.0.5
Beta2), through web. I will have about 28 new respositores that would have
to be set.

Can someone please help on what these 2 fields should contain under ?

Dashboard  > Repositories >
Add Repository +

Mirror path:

Raw file URL mask:

Thanks a lot for your help in advance ?

Sapna.

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en

Re: ReviewBoard + GIT Integration

[Christian Hammond]

Hi Kunjal,

On Wed, Nov 11, 2009 at 5:33 PM, Kunjal  wrote:

>
> Chris,
>
> We have RB 1.0.5.1 working with Perforce.
> We also use GIT as version control system for some of our projects and
> we want to integrate RB with GIT.
> Few questions:
>
> 1. Can we use the same reviewboard database with GIT which we are
> using for Perforce?
>

Yes. Review Board is designed to work with as many repositories as you can
throw at it, of any types we support.


>
> 2. How to post review from GIT? Do I need to install RB_Tools etc? Any
> steps?
>

You can either use post-review (always recommended) or generate a diff using
git diff (you may need to pass --full-index to it, which post-review will do
for you).

In 1.0.x, you will need a local checkout of the git repository on the server
hosting Review Board, and this will need to stay constantly in sync. In
1.1.x, you'll be able to point to a remote gitweb/github/cgit/etc URL
instead.

Christian

-- 
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.com

--~--~-~--~~~---~--~~
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
-~--~~~~--~~--~--~---

ReviewBoard + GIT Integration

[Kunjal]

Chris,

We have RB 1.0.5.1 working with Perforce.
We also use GIT as version control system for some of our projects and
we want to integrate RB with GIT.
Few questions:

1. Can we use the same reviewboard database with GIT which we are
using for Perforce?

2. How to post review from GIT? Do I need to install RB_Tools etc? Any
steps?

Thanks
Kunjal

--~--~-~--~~~---~--~~
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
-~--~~~~--~~--~--~---

Re: ReviewBoard + GIT Integration

[Kunjal]

Thanks a lot Matthew for your time.

Kunjal


On Sep 16, 9:13 am, Matthew Woehlke 
wrote:
> (Inline quoting is preferred, thanks!)
>
> On 2009-09-16 10:57, Kunjal wrote:
>
> > so, the post-review script will work as is in Red-Hat linux
> > environment?
>
> If the Python deps are met, it should. In my environment I have a
> local-built copy of Python (with the needed modules, though I think it
> is just simplejson, so not actually "modules" plural), ensuring that I
> don't have problems with too-old Python or the like. It's built on RH3
> and as far as I know runs fine on RH3+ (though not sure if it would run
> on non-RH/Fedora systems).
>
> If you are running RH5, you are probably fine. (Actually... if you are
> running RH3/RH4, I am pretty sure that didn't have git and so you must
> have built git locally anyway, so...)
>
> > Can some one post review from windows machine to GIT which is hosted
> > on linux machine?
>
> Assuming you have git functional on the Windows machine, I think it
> should work. Obviously, you'll also need Python :-).
>
> --
> Matthew
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To post to this group, send email to reviewboard@googlegroups.com
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
-~--~~~~--~~--~--~---

Re: ReviewBoard + GIT Integration

[Matthew Woehlke]

(Inline quoting is preferred, thanks!)

On 2009-09-16 10:57, Kunjal wrote:
> so, the post-review script will work as is in Red-Hat linux
> environment?

If the Python deps are met, it should. In my environment I have a 
local-built copy of Python (with the needed modules, though I think it 
is just simplejson, so not actually "modules" plural), ensuring that I 
don't have problems with too-old Python or the like. It's built on RH3 
and as far as I know runs fine on RH3+ (though not sure if it would run 
on non-RH/Fedora systems).

If you are running RH5, you are probably fine. (Actually... if you are 
running RH3/RH4, I am pretty sure that didn't have git and so you must 
have built git locally anyway, so...)

> Can some one post review from windows machine to GIT which is hosted
> on linux machine?

Assuming you have git functional on the Windows machine, I think it 
should work. Obviously, you'll also need Python :-).

-- 
Matthew

--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To post to this group, send email to reviewboard@googlegroups.com
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
-~--~~~~--~~--~--~---

Re: ReviewBoard + GIT Integration

[Dan Savilonis]

Philipp,

Your base revision must be available in the git repository that the
reviewboard server is using. Otherwise, you'll need to submit a parent
diff as well, which is based off a revision in that repo. If it's not,
the blob ids in the diff will not exist and you'll get the error you
encountered.

Dan

On Sep 16, 12:14 pm, Philipp Henkel  wrote:
> I'm wondering if the web interface could also be used for git. Today I
> tried to create a "New Review Request" using the web interface 
> onhttp://reviews.review-board.organd failed miserably. I'm new to git
> and as I have never used git with RB I'm wondering if git diffs are
> fully supported through the web interface.
>
> My diff was always rejected with the following error message:
> The file 'reviewboard/diffviewer/forms.py' (r36800c1) could not be
> found in the repository
>
> The diff was produced with "$ git diff"
>
> diff --git a/reviewboard/diffviewer/forms.py b/reviewboard/diffviewer/
> forms.py
> index 36800c1..9d9a1c1 100644
> --- a/reviewboard/diffviewer/forms.py
> +++ b/reviewboard/diffviewer/forms.py
> @@ -127,6 +127,8 @@ class UploadDiffForm(forms.Form):
>          tool = self.repository.get_scmtool()
>
>          for f in tool.get_parser(file.read()).parse():
> +            if f.binary:
> +                continue
>              f2, revision = tool.parse_diff_revision(f.origFile,
> f.origInfo)
>              if f2.startswith("/"):
>                  filename = f2
>
> Thanks in advance,
> Philipp
>
> On Sep 16, 1:25 am, Matthew Woehlke 
> wrote:
>
> > On 2009-09-15 18:07, Kunjal wrote:
>
> > > We already have RB integrated with Perforce and it is working cool.
> > > Now, we have some developers working in GIT and we want to review that
> > > code as well.
> > > What are the steps developer should perform to get the diff and post
> > > the review?
>
> > Save yourself a whole lot of trouble and use post-review :-).
>
> > Or to answer your question more literally, here are the steps:
> > $ post-review -d # 
>
> > ...and you can omit -d if you don't want the noise of seeing what it is
> > doing. (You'll also need to install RBTools once per machine, or else
> > just snag postreview.py and make sure everyone has a copy.)
>
> > --
> > Matthew
>
>
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To post to this group, send email to reviewboard@googlegroups.com
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
-~--~~~~--~~--~--~---

Re: ReviewBoard + GIT Integration

[Philipp Henkel]

I'm wondering if the web interface could also be used for git. Today I
tried to create a "New Review Request" using the web interface on
http://reviews.review-board.org and failed miserably. I'm new to git
and as I have never used git with RB I'm wondering if git diffs are
fully supported through the web interface.

My diff was always rejected with the following error message:
The file 'reviewboard/diffviewer/forms.py' (r36800c1) could not be
found in the repository

The diff was produced with "$ git diff"

diff --git a/reviewboard/diffviewer/forms.py b/reviewboard/diffviewer/
forms.py
index 36800c1..9d9a1c1 100644
--- a/reviewboard/diffviewer/forms.py
+++ b/reviewboard/diffviewer/forms.py
@@ -127,6 +127,8 @@ class UploadDiffForm(forms.Form):
 tool = self.repository.get_scmtool()

 for f in tool.get_parser(file.read()).parse():
+if f.binary:
+continue
 f2, revision = tool.parse_diff_revision(f.origFile,
f.origInfo)
 if f2.startswith("/"):
 filename = f2

Thanks in advance,
Philipp



On Sep 16, 1:25 am, Matthew Woehlke 
wrote:
> On 2009-09-15 18:07, Kunjal wrote:
>
> > We already have RB integrated with Perforce and it is working cool.
> > Now, we have some developers working in GIT and we want to review that
> > code as well.
> > What are the steps developer should perform to get the diff and post
> > the review?
>
> Save yourself a whole lot of trouble and use post-review :-).
>
> Or to answer your question more literally, here are the steps:
> $ post-review -d # 
>
> ...and you can omit -d if you don't want the noise of seeing what it is
> doing. (You'll also need to install RBTools once per machine, or else
> just snag postreview.py and make sure everyone has a copy.)
>
> --
> Matthew
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To post to this group, send email to reviewboard@googlegroups.com
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
-~--~~~~--~~--~--~---

Re: ReviewBoard + GIT Integration

[Kunjal]

Thanks Matthew,

so, the post-review script will work as is in Red-Hat linux
environment?
Can some one post review from windows machine to GIT which is hosted
on linux machine?

Thanks
Kunjal

On Sep 15, 4:25 pm, Matthew Woehlke 
wrote:
> On 2009-09-15 18:07, Kunjal wrote:
>
> > We already have RB integrated with Perforce and it is working cool.
> > Now, we have some developers working in GIT and we want to review that
> > code as well.
> > What are the steps developer should perform to get the diff and post
> > the review?
>
> Save yourself a whole lot of trouble and use post-review :-).
>
> Or to answer your question more literally, here are the steps:
> $ post-review -d # 
>
> ...and you can omit -d if you don't want the noise of seeing what it is
> doing. (You'll also need to install RBTools once per machine, or else
> just snag postreview.py and make sure everyone has a copy.)
>
> --
> Matthew
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To post to this group, send email to reviewboard@googlegroups.com
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
-~--~~~~--~~--~--~---

Re: ReviewBoard + GIT Integration

[Matthew Woehlke]

On 2009-09-15 18:07, Kunjal wrote:
> We already have RB integrated with Perforce and it is working cool.
> Now, we have some developers working in GIT and we want to review that
> code as well.
> What are the steps developer should perform to get the diff and post
> the review?

Save yourself a whole lot of trouble and use post-review :-).

Or to answer your question more literally, here are the steps:
$ post-review -d # 

...and you can omit -d if you don't want the noise of seeing what it is 
doing. (You'll also need to install RBTools once per machine, or else 
just snag postreview.py and make sure everyone has a copy.)

-- 
Matthew

--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To post to this group, send email to reviewboard@googlegroups.com
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
-~--~~~~--~~--~--~---

ReviewBoard + GIT Integration

[Kunjal]

Hello,

We already have RB integrated with Perforce and it is working cool.
Now, we have some developers working in GIT and we want to review that
code as well.
Where should I start?
What are the steps developer should perform to get the diff and post
the review?
Any info. in this regard will be helpful.

Thanks

--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To post to this group, send email to reviewboard@googlegroups.com
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
-~--~~~~--~~--~--~---

Re: ReviewBoard / git problem

[Alexey Morozov]

On Wednesday 06 May 2009 03:12:58 Christian Hammond wrote:
> We probably want to use os.path.pathsep instead of os.environ.get('IFS')
> anyway.

Christian, the problem is not with IFS, the problem with PATH and other common 
environment variables. Actually os.environ doesn't contain anything useful at 
all, so os.environ['PATH'] raises a KeyError. However I do see all relevant 
information, including system PATH, in Request META, and git binary is 
executed just fine. That's why I said it looks more like "security 
precautions" in [my] Apache, FastCGI or Django setup.


> Btw, I get a bounceback every time I e-mail you. Not sure if you're seeing
> any of my responses.
Yes, I read your messages without any problems. This is a public mail hub, and 
perhaps they have some sort of greylisting or whatever, but I'm not aware of 
any lost mail here, so please ignore these bounces.

Yours respectfully,
Alexey

--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To post to this group, send email to reviewboard@googlegroups.com
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
-~--~~~~--~~--~--~---

Re: ReviewBoard / git problem

[Christian Hammond]

We probably want to use os.path.pathsep instead of os.environ.get('IFS')
anyway.

Btw, I get a bounceback every time I e-mail you. Not sure if you're seeing
any of my responses.

Christian

-- 
Christian Hammond - chip...@chipx86.com
Review Board - http://www.review-board.org
VMware, Inc. - http://www.vmware.com


On Tue, May 5, 2009 at 5:04 AM, Alexey Morozov  wrote:

>
> Hi!
>
> I just discovered that git client in ReviewBoard isn't usable in my
> installation (an usual Apache/FastCGI/Django-1.0.2/RB-1.0postRC1). The
> problem is in this code fragment in reviewboard/scmtools/git.py:
>
>for dir in os.environ['PATH'].split(os.environ.get('IFS', ':')):
>if os.path.exists(os.path.join(dir, 'git')):
>found = True
>break
>if not found:
># This is technically not the right kind of error, but it's the
># pattern we use with all the other tools.
>raise ImportError
>
> In my setup (I didn't do anything special, I swear! :) ) os.environ
> contains
> only these values (dumped from the point immediately preceding the check):
>
> environ={'TZ': 'Asia/Dhaka', 'PYTHON_EGG_CACHE':
> '/var/www/webapps/reviewboard/tmp/egg_cache', 'DJANGO_SETTINGS_MODULE':
> 'reviewboard.settings'}
>
> Despite such a crippled environment settings git runs just fine
> (from /usr/bin/), so I guess it's some Django/FastCGI "security measures".
>
> I'm going to remove the check above or at least make it actually check git
> existance.
>
> Alexey Morozov
>
> >
>

--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To post to this group, send email to reviewboard@googlegroups.com
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
-~--~~~~--~~--~--~---

ReviewBoard / git problem

[Alexey Morozov]

Hi!

I just discovered that git client in ReviewBoard isn't usable in my 
installation (an usual Apache/FastCGI/Django-1.0.2/RB-1.0postRC1). The 
problem is in this code fragment in reviewboard/scmtools/git.py:

for dir in os.environ['PATH'].split(os.environ.get('IFS', ':')):
if os.path.exists(os.path.join(dir, 'git')):
found = True
break
if not found:
# This is technically not the right kind of error, but it's the
# pattern we use with all the other tools.
raise ImportError

In my setup (I didn't do anything special, I swear! :) ) os.environ contains 
only these values (dumped from the point immediately preceding the check):

environ={'TZ': 'Asia/Dhaka', 'PYTHON_EGG_CACHE': 
'/var/www/webapps/reviewboard/tmp/egg_cache', 'DJANGO_SETTINGS_MODULE': 
'reviewboard.settings'}

Despite such a crippled environment settings git runs just fine 
(from /usr/bin/), so I guess it's some Django/FastCGI "security measures". 

I'm going to remove the check above or at least make it actually check git 
existance.

Alexey Morozov

--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To post to this group, send email to reviewboard@googlegroups.com
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
-~--~~~~--~~--~--~---