[Impala-ASF-CR] IMPALA-11897: Fix default LDAP group search filter

2023-02-07 Thread Tamas Mate (Code Review)
Tamas Mate has posted comments on this change. ( http://gerrit.cloudera.org:8080/19442 ) Change subject: IMPALA-11897: Fix default LDAP group search filter .. Patch Set 2: (2 comments) Thanks for the update Gergely, some nits

[Impala-ASF-CR] IMPALA-11798: Property 'external.table.purge' should not be ignored when CREATE Iceberg tables

2023-02-03 Thread Tamas Mate (Code Review)
Tamas Mate has posted comments on this change. ( http://gerrit.cloudera.org:8080/19416 ) Change subject: IMPALA-11798: Property 'external.table.purge' should not be ignored when CREATE Iceberg tables .. Patch Set 2: Code-Revie

[Impala-ASF-CR] IMPALA-11798: Property 'external.table.purge' should not be ignored when CREATE Iceberg tables

2023-02-01 Thread Tamas Mate (Code Review)
Tamas Mate has posted comments on this change. ( http://gerrit.cloudera.org:8080/19416 ) Change subject: IMPALA-11798: Property 'external.table.purge' should not be ignored when CREATE Iceberg tables .. Patch Set 1: (1 commen

[Impala-ASF-CR] Fix default LDAP group search filter

2023-01-26 Thread Tamas Mate (Code Review)
Tamas Mate has posted comments on this change. ( http://gerrit.cloudera.org:8080/19442 ) Change subject: Fix default LDAP group search filter .. Patch Set 1: (2 comments) Hi Gergely, nice catch and thank you for submitting a

[Impala-ASF-CR] IMPALA-11864: Iceberg LOAD DATA should not load S3 hidden files

2023-01-26 Thread Tamas Mate (Code Review)
Hello Daniel Becker, Zoltan Borok-Nagy, Gergely Fürnstáhl, Noemi Pap-Takacs, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19441 to look at the new patch set (#3). Change subject: IMPALA-11864: Iceberg LOAD DATA should not load S3 h

[Impala-ASF-CR] IMPALA-11864: Iceberg LOAD DATA should not load S3 hidden files

2023-01-26 Thread Tamas Mate (Code Review)
Tamas Mate has posted comments on this change. ( http://gerrit.cloudera.org:8080/19441 ) Change subject: IMPALA-11864: Iceberg LOAD DATA should not load S3 hidden files .. Patch Set 2: (1 comment) Thank you for the review Dan

[Impala-ASF-CR] IMPALA-11864: Iceberg LOAD DATA should not load S3 hidden files

2023-01-26 Thread Tamas Mate (Code Review)
Tamas Mate has posted comments on this change. ( http://gerrit.cloudera.org:8080/19441 ) Change subject: IMPALA-11864: Iceberg LOAD DATA should not load S3 hidden files .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:

[Impala-ASF-CR] IMPALA-11864: Iceberg LOAD DATA should not load S3 hidden files

2023-01-26 Thread Tamas Mate (Code Review)
Tamas Mate has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/19441 ) Change subject: IMPALA-11864: Iceberg LOAD DATA should not load S3 hidden files .. IMPALA-11864: Iceberg LOAD DATA should not load S3 hidden

[Impala-ASF-CR] IMPALA-11864: Iceberg LOAD DATA should not load S3 hidden files

2023-01-26 Thread Tamas Mate (Code Review)
Tamas Mate has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19441 Change subject: IMPALA-11864: Iceberg LOAD DATA should not load S3 hidden files .. IMPALA-11864: Iceberg LOAD DATA should not load S3 hidde

[Impala-ASF-CR] IMPALA-11798: Property 'external.table.purge' should not be ignored when CREATE Iceberg tables

2023-01-18 Thread Tamas Mate (Code Review)
Tamas Mate has posted comments on this change. ( http://gerrit.cloudera.org:8080/19416 ) Change subject: IMPALA-11798: Property 'external.table.purge' should not be ignored when CREATE Iceberg tables .. Patch Set 1: (1 commen

[Impala-ASF-CR] IMPALA-11826: Avoid calling planFiles() on Iceberg V2 tables when there are no predicates

2023-01-18 Thread Tamas Mate (Code Review)
Tamas Mate has posted comments on this change. ( http://gerrit.cloudera.org:8080/19419 ) Change subject: IMPALA-11826: Avoid calling planFiles() on Iceberg V2 tables when there are no predicates .. Patch Set 3: Code-Review+2

[Impala-ASF-CR] IMPALA-11834: Fix Iceberg LOAD DATA hdfsDelete JVM crash

2023-01-11 Thread Tamas Mate (Code Review)
Tamas Mate has posted comments on this change. ( http://gerrit.cloudera.org:8080/19410 ) Change subject: IMPALA-11834: Fix Iceberg LOAD DATA hdfsDelete JVM crash .. Patch Set 3: Thank you for the review Daniel and Zoltan. I wi

[Impala-ASF-CR] IMPALA-11834: Fix Iceberg LOAD DATA hdfsDelete JVM crash

2023-01-10 Thread Tamas Mate (Code Review)
Tamas Mate has posted comments on this change. ( http://gerrit.cloudera.org:8080/19410 ) Change subject: IMPALA-11834: Fix Iceberg LOAD DATA hdfsDelete JVM crash .. Patch Set 1: I don't think a test would work with HDFS and fo

[Impala-ASF-CR] IMPALA-11834: Fix Iceberg LOAD DATA hdfsDelete JVM crash

2023-01-10 Thread Tamas Mate (Code Review)
Tamas Mate has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19410 Change subject: IMPALA-11834: Fix Iceberg LOAD DATA hdfsDelete JVM crash .. IMPALA-11834: Fix Iceberg LOAD DATA hdfsDelete JVM crash The L

[Impala-ASF-CR] IMPALA-11620: Enable setting 'write.format.default'

2023-01-09 Thread Tamas Mate (Code Review)
Tamas Mate has posted comments on this change. ( http://gerrit.cloudera.org:8080/19221 ) Change subject: IMPALA-11620: Enable setting 'write.format.default' .. Patch Set 4: Code-Review+2 Thank you for the update Noemi! -- To

[Impala-ASF-CR] IMPALA-11819: [DOCS] Add Iceberg LOAD DATA information

2023-01-09 Thread Tamas Mate (Code Review)
Tamas Mate has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19396 ) Change subject: IMPALA-11819: [DOCS] Add Iceberg LOAD DATA information .. IMPALA-11819: [DOCS] Add Iceberg LOAD DATA information

[Impala-ASF-CR] IMPALA-11819: [DOCS] Add Iceberg LOAD DATA information

2023-01-09 Thread Tamas Mate (Code Review)
Tamas Mate has posted comments on this change. ( http://gerrit.cloudera.org:8080/19396 ) Change subject: IMPALA-11819: [DOCS] Add Iceberg LOAD DATA information .. Patch Set 2: Code-Review+2 Thank you for the reviews! -- To v

[Impala-ASF-CR] IMPALA-11819: [DOCS] Add Iceberg LOAD DATA information

2023-01-08 Thread Tamas Mate (Code Review)
Tamas Mate has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/19396 ) Change subject: IMPALA-11819: [DOCS] Add Iceberg LOAD DATA information .. IMPALA-11819: [DOCS] Add Iceberg LOAD DATA information This commi

[Impala-ASF-CR] IMPALA-11620: Enable setting 'write.format.default'

2023-01-05 Thread Tamas Mate (Code Review)
Tamas Mate has posted comments on this change. ( http://gerrit.cloudera.org:8080/19221 ) Change subject: IMPALA-11620: Enable setting 'write.format.default' .. Patch Set 3: Code-Review+1 Thank you for this fix Noemi, LGTM! -

[Impala-ASF-CR] IMPALA-11818: Fix flaky TestDdlStatements.test describe materialized view

2023-01-04 Thread Tamas Mate (Code Review)
Tamas Mate has posted comments on this change. ( http://gerrit.cloudera.org:8080/19395 ) Change subject: IMPALA-11818: Fix flaky TestDdlStatements.test_describe_materialized_view .. Patch Set 2: Failed because flaky IMPALA-11

[Impala-ASF-CR] IMPALA-11819: [DOCS] Add Iceberg LOAD DATA information

2023-01-03 Thread Tamas Mate (Code Review)
Tamas Mate has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19396 Change subject: IMPALA-11819: [DOCS] Add Iceberg LOAD DATA information .. IMPALA-11819: [DOCS] Add Iceberg LOAD DATA information This comm

[Impala-ASF-CR] IMPALA-11818: Fix flaky TestDdlStatements.test describe materialized view

2023-01-03 Thread Tamas Mate (Code Review)
Tamas Mate has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19395 Change subject: IMPALA-11818: Fix flaky TestDdlStatements.test_describe_materialized_view .. IMPALA-11818: Fix flaky TestDdlStatements.tes

[Impala-ASF-CR](asf-site) Add documentation for 4.2.0

2023-01-02 Thread Tamas Mate (Code Review)
Tamas Mate has posted comments on this change. ( http://gerrit.cloudera.org:8080/19367 ) Change subject: Add documentation for 4.2.0 .. Patch Set 4: Code-Review+1 Thanks for this change! LGTM! -- To view, visit http://gerrit

[Impala-ASF-CR] IMPALA-11807: Fix TestIcebergTable.test avro file format and test mixed file format

2022-12-22 Thread Tamas Mate (Code Review)
Tamas Mate has posted comments on this change. ( http://gerrit.cloudera.org:8080/19387 ) Change subject: IMPALA-11807: Fix TestIcebergTable.test_avro_file_format and test_mixed_file_format .. Patch Set 4: Code-Review+2 Thank

[Impala-ASF-CR] IMPALA-11807: Fix TestIcebergTable.test avro file format and test mixed file format

2022-12-22 Thread Tamas Mate (Code Review)
Tamas Mate has posted comments on this change. ( http://gerrit.cloudera.org:8080/19387 ) Change subject: IMPALA-11807: Fix TestIcebergTable.test_avro_file_format and test_mixed_file_format .. Patch Set 2: (1 comment) http://

[Impala-ASF-CR] IMPALA-11807: Fix TestIcebergTable.test avro file format and test mixed file format

2022-12-21 Thread Tamas Mate (Code Review)
Tamas Mate has posted comments on this change. ( http://gerrit.cloudera.org:8080/19387 ) Change subject: IMPALA-11807: Fix TestIcebergTable.test_avro_file_format and test_mixed_file_format .. Patch Set 2: (1 comment) http://

[Impala-ASF-CR] IMPALA-11806: Fix TestIcebergTable.test load E2E test

2022-12-21 Thread Tamas Mate (Code Review)
Tamas Mate has posted comments on this change. ( http://gerrit.cloudera.org:8080/19385 ) Change subject: IMPALA-11806: Fix TestIcebergTable.test_load E2E test .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.clou

[Impala-ASF-CR] IMPALA-11806: Fix TestIcebergTable.test load E2E test

2022-12-21 Thread Tamas Mate (Code Review)
Tamas Mate has posted comments on this change. ( http://gerrit.cloudera.org:8080/19385 ) Change subject: IMPALA-11806: Fix TestIcebergTable.test_load E2E test .. Patch Set 1: (2 comments) Thank you for the review Gergo and No

[Impala-ASF-CR] IMPALA-11806: Fix TestIcebergTable.test load E2E test

2022-12-21 Thread Tamas Mate (Code Review)
Tamas Mate has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/19385 ) Change subject: IMPALA-11806: Fix TestIcebergTable.test_load E2E test .. IMPALA-11806: Fix TestIcebergTable.test_load E2E test The test had

[Impala-ASF-CR] IMPALA-11806: Fix TestIcebergTable.test load E2E test

2022-12-21 Thread Tamas Mate (Code Review)
Tamas Mate has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19385 Change subject: IMPALA-11806: Fix TestIcebergTable.test_load E2E test .. IMPALA-11806: Fix TestIcebergTable.test_load E2E test The test ha

[Impala-ASF-CR] IMPALA-11708: Add support for mixed Iceberg tables with AVRO file format

2022-12-16 Thread Tamas Mate (Code Review)
Tamas Mate has posted comments on this change. ( http://gerrit.cloudera.org:8080/19353 ) Change subject: IMPALA-11708: Add support for mixed Iceberg tables with AVRO file format .. Patch Set 3: Code-Review+2 -- To view, visi

[Impala-ASF-CR] IMPALA-11708: Add support for mixed Iceberg tables with AVRO file format

2022-12-14 Thread Tamas Mate (Code Review)
Tamas Mate has posted comments on this change. ( http://gerrit.cloudera.org:8080/19353 ) Change subject: IMPALA-11708: Add support for mixed Iceberg tables with AVRO file format .. Patch Set 1: (1 comment) Nice improvement!

[Impala-ASF-CR] IMPALA-11339: Add Iceberg LOAD DATA INPATH statement

2022-12-14 Thread Tamas Mate (Code Review)
Tamas Mate has uploaded a new patch set (#9). ( http://gerrit.cloudera.org:8080/19145 ) Change subject: IMPALA-11339: Add Iceberg LOAD DATA INPATH statement .. IMPALA-11339: Add Iceberg LOAD DATA INPATH statement Extend LOAD DA

[Impala-ASF-CR] IMPALA-11339: Add Iceberg LOAD DATA INPATH statement

2022-12-14 Thread Tamas Mate (Code Review)
Tamas Mate has posted comments on this change. ( http://gerrit.cloudera.org:8080/19145 ) Change subject: IMPALA-11339: Add Iceberg LOAD DATA INPATH statement .. Patch Set 8: (1 comment) http://gerrit.cloudera.org:8080/#/c/191

[Impala-ASF-CR] IMPALA-11787: Cardinality estimate for UNION in Iceberg position-delete plans can double the actual table cardinality

2022-12-14 Thread Tamas Mate (Code Review)
Tamas Mate has posted comments on this change. ( http://gerrit.cloudera.org:8080/19354 ) Change subject: IMPALA-11787: Cardinality estimate for UNION in Iceberg position-delete plans can double the actual table cardinality ..

[Impala-ASF-CR] IMPALA-11777: Bump CDP BUILD NUMBER to get HIVE-24498

2022-12-13 Thread Tamas Mate (Code Review)
Tamas Mate has posted comments on this change. ( http://gerrit.cloudera.org:8080/19331 ) Change subject: IMPALA-11777: Bump CDP_BUILD_NUMBER to get HIVE-24498 .. Patch Set 1: LGTM, thanks for this bump! -- To view, visit htt

[Impala-ASF-CR] IMPALA-11777: Bump CDP BUILD NUMBER to get HIVE-24498

2022-12-13 Thread Tamas Mate (Code Review)
Tamas Mate has posted comments on this change. ( http://gerrit.cloudera.org:8080/19331 ) Change subject: IMPALA-11777: Bump CDP_BUILD_NUMBER to get HIVE-24498 .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.clou

[Impala-ASF-CR] IMPALA-11784: Don't call Iceberg's planFiles redundantly during table load

2022-12-13 Thread Tamas Mate (Code Review)
Tamas Mate has posted comments on this change. ( http://gerrit.cloudera.org:8080/19334 ) Change subject: IMPALA-11784: Don't call Iceberg's planFiles redundantly during table load .. Patch Set 1: Code-Review+2 Nice catch, LGT

[Impala-ASF-CR] IMPALA-11339: Add Iceberg LOAD DATA INPATH statement

2022-12-12 Thread Tamas Mate (Code Review)
Tamas Mate has uploaded a new patch set (#8). ( http://gerrit.cloudera.org:8080/19145 ) Change subject: IMPALA-11339: Add Iceberg LOAD DATA INPATH statement .. IMPALA-11339: Add Iceberg LOAD DATA INPATH statement Extend LOAD DA

[Impala-ASF-CR] IMPALA-11780: Wrong FILE POSITION values for multi row group Parquet files when page filtering is used

2022-12-07 Thread Tamas Mate (Code Review)
Tamas Mate has posted comments on this change. ( http://gerrit.cloudera.org:8080/19328 ) Change subject: IMPALA-11780: Wrong FILE__POSITION values for multi row group Parquet files when page filtering is used .. Patch Set 1: C

[Impala-ASF-CR] IMPALA-11158: Add support for Iceberg tables with AVRO data files

2022-12-07 Thread Tamas Mate (Code Review)
Tamas Mate has posted comments on this change. ( http://gerrit.cloudera.org:8080/19084 ) Change subject: IMPALA-11158: Add support for Iceberg tables with AVRO data files .. Patch Set 8: Code-Review+2 Carrying over the +1.

[Impala-ASF-CR] IMPALA-11339: Add Iceberg LOAD DATA INPATH statement

2022-12-07 Thread Tamas Mate (Code Review)
Tamas Mate has posted comments on this change. ( http://gerrit.cloudera.org:8080/19145 ) Change subject: IMPALA-11339: Add Iceberg LOAD DATA INPATH statement .. Patch Set 6: The build fail is not related: 14:01:06 [ERROR] Fail

[Impala-ASF-CR] IMPALA-11339: Add Iceberg LOAD DATA INPATH statement

2022-12-07 Thread Tamas Mate (Code Review)
Tamas Mate has posted comments on this change. ( http://gerrit.cloudera.org:8080/19145 ) Change subject: IMPALA-11339: Add Iceberg LOAD DATA INPATH statement .. Patch Set 6: (3 comments) http://gerrit.cloudera.org:8080/#/c/19

[Impala-ASF-CR] IMPALA-11339: Add Iceberg LOAD DATA INPATH statement

2022-12-07 Thread Tamas Mate (Code Review)
Tamas Mate has uploaded a new patch set (#6). ( http://gerrit.cloudera.org:8080/19145 ) Change subject: IMPALA-11339: Add Iceberg LOAD DATA INPATH statement .. IMPALA-11339: Add Iceberg LOAD DATA INPATH statement Extend LOAD DA

[Impala-ASF-CR] IMPALA-11339: Add Iceberg LOAD DATA INPATH statement

2022-12-07 Thread Tamas Mate (Code Review)
Tamas Mate has uploaded a new patch set (#5). ( http://gerrit.cloudera.org:8080/19145 ) Change subject: IMPALA-11339: Add Iceberg LOAD DATA INPATH statement .. IMPALA-11339: Add Iceberg LOAD DATA INPATH statement Extend LOAD DA

[Impala-ASF-CR] IMPALA-11339: Add Iceberg LOAD DATA INPATH statement

2022-12-07 Thread Tamas Mate (Code Review)
Tamas Mate has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/19145 ) Change subject: IMPALA-11339: Add Iceberg LOAD DATA INPATH statement .. IMPALA-11339: Add Iceberg LOAD DATA INPATH statement Extend LOAD DA

[Impala-ASF-CR] IMPALA-11740: Incorrect results for partitioned Iceberg V2 tables when runtime filters are applied

2022-11-28 Thread Tamas Mate (Code Review)
Tamas Mate has posted comments on this change. ( http://gerrit.cloudera.org:8080/19274 ) Change subject: IMPALA-11740: Incorrect results for partitioned Iceberg V2 tables when runtime filters are applied .. Patch Set 2: Thank

[Impala-ASF-CR] IMPALA-11740: Incorrect results for partitioned Iceberg V2 tables when runtime filters are applied

2022-11-28 Thread Tamas Mate (Code Review)
Tamas Mate has posted comments on this change. ( http://gerrit.cloudera.org:8080/19274 ) Change subject: IMPALA-11740: Incorrect results for partitioned Iceberg V2 tables when runtime filters are applied .. Patch Set 2: Code-R

[Impala-ASF-CR] IMPALA-11158: Add support for Iceberg tables with AVRO data files

2022-11-28 Thread Tamas Mate (Code Review)
Tamas Mate has posted comments on this change. ( http://gerrit.cloudera.org:8080/19084 ) Change subject: IMPALA-11158: Add support for Iceberg tables with AVRO data files .. Patch Set 5: Code-Review+1 (6 comments) LGTM, mark

[Impala-ASF-CR] IMPALA-11676: Prettify asf-site docs

2022-11-16 Thread Tamas Mate (Code Review)
Tamas Mate has posted comments on this change. ( http://gerrit.cloudera.org:8080/19242 ) Change subject: IMPALA-11676: Prettify asf-site docs .. Patch Set 2: (1 comment) Thank you for the reviews Zoltan and Xiang Yang! Yes,

[Impala-ASF-CR] IMPALA-11676: Prettify asf-site docs

2022-11-16 Thread Tamas Mate (Code Review)
Tamas Mate has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/19242 ) Change subject: IMPALA-11676: Prettify asf-site docs .. IMPALA-11676: Prettify asf-site docs This commit refactors and adds a new build opt

[Impala-ASF-CR] IMPALA-11721: Impala query keep being retried over frequently updated iceberg table

2022-11-14 Thread Tamas Mate (Code Review)
Tamas Mate has posted comments on this change. ( http://gerrit.cloudera.org:8080/19234 ) Change subject: IMPALA-11721: Impala query keep being retried over frequently updated iceberg table .. Patch Set 2: Code-Review+2 (3 com

[Impala-ASF-CR] IMPALA-11676: Prettify asf-site docs

2022-11-14 Thread Tamas Mate (Code Review)
Tamas Mate has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19242 Change subject: IMPALA-11676: Prettify asf-site docs .. IMPALA-11676: Prettify asf-site docs This commit refactors and adds a new build op

[Impala-ASF-CR] IMPALA-11158: Add support for Iceberg tables with AVRO data files

2022-11-07 Thread Tamas Mate (Code Review)
Tamas Mate has posted comments on this change. ( http://gerrit.cloudera.org:8080/19084 ) Change subject: IMPALA-11158: Add support for Iceberg tables with AVRO data files .. Patch Set 4: (10 comments) The change looks great,

[Impala-ASF-CR] IMPALA-11339: Add Iceberg LOAD DATA INPATH statement

2022-11-01 Thread Tamas Mate (Code Review)
Tamas Mate has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/19145 ) Change subject: IMPALA-11339: Add Iceberg LOAD DATA INPATH statement .. IMPALA-11339: Add Iceberg LOAD DATA INPATH statement Extend LOAD DA

[Impala-ASF-CR](asf-site) Add 4.1.1 change log

2022-10-19 Thread Tamas Mate (Code Review)
Tamas Mate has posted comments on this change. ( http://gerrit.cloudera.org:8080/19142 ) Change subject: Add 4.1.1 change log .. Patch Set 1: Code-Review+2 Thanks Quanlong, LGTM! -- To view, visit http://gerrit.cloudera.org:

[Impala-ASF-CR](asf-site) Update download links for release 4.1.1

2022-10-19 Thread Tamas Mate (Code Review)
Tamas Mate has posted comments on this change. ( http://gerrit.cloudera.org:8080/19141 ) Change subject: Update download links for release 4.1.1 .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/

[Impala-ASF-CR](asf-site) Update download links for release 4.1.1

2022-10-19 Thread Tamas Mate (Code Review)
Tamas Mate has posted comments on this change. ( http://gerrit.cloudera.org:8080/19141 ) Change subject: Update download links for release 4.1.1 .. Patch Set 1: -Code-Review LGTM, thanks Quanlong! -- To view, visit http://ge

[Impala-ASF-CR](asf-site) Update download links for release 4.1.1

2022-10-19 Thread Tamas Mate (Code Review)
Tamas Mate has posted comments on this change. ( http://gerrit.cloudera.org:8080/19141 ) Change subject: Update download links for release 4.1.1 .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/

[Impala-ASF-CR] IMPALA-11655: Impala should set write mode "merge-on-read" by default

2022-10-17 Thread Tamas Mate (Code Review)
Tamas Mate has posted comments on this change. ( http://gerrit.cloudera.org:8080/19138 ) Change subject: IMPALA-11655: Impala should set write mode "merge-on-read" by default .. Patch Set 2: Code-Review+1 Thanks for the fix Z

[Impala-ASF-CR] [WIP] IMPALA-11339: Add Iceberg LOAD DATA INPATH statement

2022-10-17 Thread Tamas Mate (Code Review)
Tamas Mate has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/19145 ) Change subject: [WIP] IMPALA-11339: Add Iceberg LOAD DATA INPATH statement .. [WIP] IMPALA-11339: Add Iceberg LOAD DATA INPATH statement Ex

[Impala-ASF-CR] [WIP] IMPALA-11339: Add Iceberg LOAD DATA INPATH statement

2022-10-17 Thread Tamas Mate (Code Review)
Tamas Mate has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19145 Change subject: [WIP] IMPALA-11339: Add Iceberg LOAD DATA INPATH statement .. [WIP] IMPALA-11339: Add Iceberg LOAD DATA INPATH statement E

[Impala-ASF-CR](branch-4.1.1) IMPALA-11528: Catalogd should start up with a corrupt Hive function.

2022-09-26 Thread Tamas Mate (Code Review)
Tamas Mate has posted comments on this change. ( http://gerrit.cloudera.org:8080/19019 ) Change subject: IMPALA-11528: Catalogd should start up with a corrupt Hive function. .. Patch Set 4: Code-Review+2 -- To view, visit ht

[Impala-ASF-CR] IMPALA-11508: Deflake test expire snapshots

2022-09-26 Thread Tamas Mate (Code Review)
Tamas Mate has posted comments on this change. ( http://gerrit.cloudera.org:8080/19036 ) Change subject: IMPALA-11508: Deflake test_expire_snapshots .. Patch Set 1: Code-Review+2 Nice fix, LGTM! -- To view, visit http://gerr

[Impala-ASF-CR] IMPALA-11582: Implement table sampling for Iceberg tables

2022-09-26 Thread Tamas Mate (Code Review)
Tamas Mate has posted comments on this change. ( http://gerrit.cloudera.org:8080/18989 ) Change subject: IMPALA-11582: Implement table sampling for Iceberg tables .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/

[Impala-ASF-CR] IMPALA-11528: Catalogd should start up with a corrupt Hive function.

2022-09-08 Thread Tamas Mate (Code Review)
Tamas Mate has posted comments on this change. ( http://gerrit.cloudera.org:8080/18927 ) Change subject: IMPALA-11528: Catalogd should start up with a corrupt Hive function. .. Patch Set 10: Code-Review+2 (1 comment) Thanks

[Impala-ASF-CR] IMPALA-11528: Catalogd should start up with a corrupt Hive function.

2022-09-07 Thread Tamas Mate (Code Review)
Tamas Mate has posted comments on this change. ( http://gerrit.cloudera.org:8080/18927 ) Change subject: IMPALA-11528: Catalogd should start up with a corrupt Hive function. .. Patch Set 9: (3 comments) http://gerrit.clouder

[Impala-ASF-CR] IMPALA-11159: Fix AttributeError in TestAsyncDDLTiming.test ctas

2022-09-06 Thread Tamas Mate (Code Review)
Tamas Mate has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/18933 ) Change subject: IMPALA-11159: Fix AttributeError in TestAsyncDDLTiming.test_ctas .. IMPALA-11159: Fix AttributeError in TestAsyncDDLTiming.t

[Impala-ASF-CR] IMPALA-11159: Fix AttributeError in TestAsyncDDLTiming.test ctas

2022-09-06 Thread Tamas Mate (Code Review)
Tamas Mate has posted comments on this change. ( http://gerrit.cloudera.org:8080/18933 ) Change subject: IMPALA-11159: Fix AttributeError in TestAsyncDDLTiming.test_ctas .. Patch Set 2: (2 comments) Thank you for the review Q

[Impala-ASF-CR] IMPALA-11159: Fix AttributeError in TestAsyncDDLTiming.test ctas

2022-09-06 Thread Tamas Mate (Code Review)
Tamas Mate has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/18933 ) Change subject: IMPALA-11159: Fix AttributeError in TestAsyncDDLTiming.test_ctas .. IMPALA-11159: Fix AttributeError in TestAsyncDDLTiming.t

[Impala-ASF-CR] IMPALA-11159: Fix AttributeError in TestAsyncDDLTiming.test ctas

2022-09-06 Thread Tamas Mate (Code Review)
Tamas Mate has posted comments on this change. ( http://gerrit.cloudera.org:8080/18933 ) Change subject: IMPALA-11159: Fix AttributeError in TestAsyncDDLTiming.test_ctas .. Patch Set 1: (2 comments) Thank you for the review C

[Impala-ASF-CR] IMPALA-11159: Fix AttributeError in TestAsyncDDLTiming.test ctas

2022-08-31 Thread Tamas Mate (Code Review)
Tamas Mate has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18933 Change subject: IMPALA-11159: Fix AttributeError in TestAsyncDDLTiming.test_ctas .. IMPALA-11159: Fix AttributeError in TestAsyncDDLTiming.

[Impala-ASF-CR] IMPALA-11483: [DOCS] Document EXPIRE SNAPSHOTS functionality

2022-08-30 Thread Tamas Mate (Code Review)
Tamas Mate has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18838 ) Change subject: IMPALA-11483: [DOCS] Document EXPIRE SNAPSHOTS functionality .. IMPALA-11483: [DOCS] Document EXPIRE SNAPSHOTS fun

[Impala-ASF-CR] IMPALA-11483: [DOCS] Document EXPIRE SNAPSHOTS functionality

2022-08-30 Thread Tamas Mate (Code Review)
Tamas Mate has posted comments on this change. ( http://gerrit.cloudera.org:8080/18838 ) Change subject: IMPALA-11483: [DOCS] Document EXPIRE SNAPSHOTS functionality .. Patch Set 4: Verified+1 Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-11483: [DOCS] Document EXPIRE SNAPSHOTS functionality

2022-08-30 Thread Tamas Mate (Code Review)
Tamas Mate has posted comments on this change. ( http://gerrit.cloudera.org:8080/18838 ) Change subject: IMPALA-11483: [DOCS] Document EXPIRE SNAPSHOTS functionality .. Patch Set 3: Code-Review+2 Thank you for the review Andre

[Impala-ASF-CR] IMPALA-11483: [DOCS] Document EXPIRE SNAPSHOTS functionality

2022-08-30 Thread Tamas Mate (Code Review)
Hello Andrew Sherman, Gabor Kaszab, Zoltan Borok-Nagy, Gergely Fürnstáhl, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/18838 to look at the new patch set (#3). Change subject: IMPALA-11483: [DOCS] Document EXPIRE SNAPSHOTS function

[Impala-ASF-CR] IMPALA-11484: Create SCAN plan for Iceberg V2 position delete tables

2022-08-30 Thread Tamas Mate (Code Review)
Tamas Mate has posted comments on this change. ( http://gerrit.cloudera.org:8080/18847 ) Change subject: IMPALA-11484: Create SCAN plan for Iceberg V2 position delete tables .. Patch Set 7: Code-Review+2 (1 comment) Thanks f

[Impala-ASF-CR](branch-4.1.1) IMPALA-10865: Fix initialize SelectStmt's groupingExprs in analyzeGroupingExprs

2022-08-30 Thread Tamas Mate (Code Review)
Tamas Mate has posted comments on this change. ( http://gerrit.cloudera.org:8080/18913 ) Change subject: IMPALA-10865: Fix initialize SelectStmt's groupingExprs_ in analyzeGroupingExprs .. Patch Set 1: Code-Review+2 -- To vi

[Impala-ASF-CR](branch-4.1.1) IMPALA-11034: Resolve schema of old data files in migrated Iceberg tables

2022-08-30 Thread Tamas Mate (Code Review)
Tamas Mate has posted comments on this change. ( http://gerrit.cloudera.org:8080/18912 ) Change subject: IMPALA-11034: Resolve schema of old data files in migrated Iceberg tables .. Patch Set 1: Code-Review+2 -- To view, vis

[Impala-ASF-CR] IMPALA-11528: Catalogd should start up even with a corrupt Hive function.

2022-08-30 Thread Tamas Mate (Code Review)
Tamas Mate has posted comments on this change. ( http://gerrit.cloudera.org:8080/18927 ) Change subject: IMPALA-11528: Catalogd should start up even with a corrupt Hive function. .. Patch Set 2: (1 comment) Thanks for pickin

[Impala-ASF-CR] IMPALA-11484: Create SCAN plan for Iceberg V2 position delete tables

2022-08-26 Thread Tamas Mate (Code Review)
Tamas Mate has posted comments on this change. ( http://gerrit.cloudera.org:8080/18847 ) Change subject: IMPALA-11484: Create SCAN plan for Iceberg V2 position delete tables .. Patch Set 5: (3 comments) http://gerrit.clouder

[Impala-ASF-CR] IMPALA-11484: Create SCAN plan for Iceberg V2 position delete tables

2022-08-26 Thread Tamas Mate (Code Review)
Tamas Mate has posted comments on this change. ( http://gerrit.cloudera.org:8080/18847 ) Change subject: IMPALA-11484: Create SCAN plan for Iceberg V2 position delete tables .. Patch Set 5: (17 comments) Great change! Added

[Impala-ASF-CR] IMPALA-11521: Fix test binary type

2022-08-25 Thread Tamas Mate (Code Review)
Tamas Mate has posted comments on this change. ( http://gerrit.cloudera.org:8080/18895 ) Change subject: IMPALA-11521: Fix test_binary_type .. Patch Set 4: Thank you for the review Csaba. -- To view, visit http://gerrit.clou

[Impala-ASF-CR] IMPALA-11429: Set table owner after creating an Iceberg table

2022-08-25 Thread Tamas Mate (Code Review)
Tamas Mate has posted comments on this change. ( http://gerrit.cloudera.org:8080/18837 ) Change subject: IMPALA-11429: Set table owner after creating an Iceberg table .. Patch Set 8: Code-Review+2 Thanks for adding these chang

[Impala-ASF-CR] IMPALA-11520: Remove functional.unsupported types misc test

2022-08-25 Thread Tamas Mate (Code Review)
Tamas Mate has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/18896 ) Change subject: IMPALA-11520: Remove functional.unsupported_types misc test .. IMPALA-11520: Remove functional.unsupported_types misc test

[Impala-ASF-CR] IMPALA-11429: Set table owner after creating an Iceberg table

2022-08-24 Thread Tamas Mate (Code Review)
Tamas Mate has posted comments on this change. ( http://gerrit.cloudera.org:8080/18837 ) Change subject: IMPALA-11429: Set table owner after creating an Iceberg table .. Patch Set 5: (1 comment) http://gerrit.cloudera.org:808

[Impala-ASF-CR] IMPALA-11520: Remove functional.unsupported types misc test

2022-08-24 Thread Tamas Mate (Code Review)
Tamas Mate has posted comments on this change. ( http://gerrit.cloudera.org:8080/18896 ) Change subject: IMPALA-11520: Remove functional.unsupported_types misc test .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/

[Impala-ASF-CR] IMPALA-11521: Fix test binary type

2022-08-23 Thread Tamas Mate (Code Review)
Tamas Mate has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/18895 ) Change subject: IMPALA-11521: Fix test_binary_type .. IMPALA-11521: Fix test_binary_type Fix test_binary_type typo, it should not reference

[Impala-ASF-CR] IMPALA-11521: Fix test binary type

2022-08-23 Thread Tamas Mate (Code Review)
Tamas Mate has posted comments on this change. ( http://gerrit.cloudera.org:8080/18895 ) Change subject: IMPALA-11521: Fix test_binary_type .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/18895/1/tests/query_t

[Impala-ASF-CR] IMPALA-11520: Remove functional.unsupported types misc test

2022-08-23 Thread Tamas Mate (Code Review)
Tamas Mate has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18896 Change subject: IMPALA-11520: Remove functional.unsupported_types misc test .. IMPALA-11520: Remove functional.unsupported_types misc test

[Impala-ASF-CR] IMPALA-11521: Skip test binary type for HBase

2022-08-23 Thread Tamas Mate (Code Review)
Tamas Mate has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18895 Change subject: IMPALA-11521: Skip test_binary_type for HBase .. IMPALA-11521: Skip test_binary_type for HBase Skip this test for builds t

[Impala-ASF-CR] IMPALA-11429: Set table owner after creating an Iceberg table

2022-08-22 Thread Tamas Mate (Code Review)
Tamas Mate has posted comments on this change. ( http://gerrit.cloudera.org:8080/18837 ) Change subject: IMPALA-11429: Set table owner after creating an Iceberg table .. Patch Set 5: (2 comments) http://gerrit.cloudera.org:80

[Impala-ASF-CR] IMPALA-11429: Set table owner after creating an Iceberg table

2022-08-20 Thread Tamas Mate (Code Review)
Tamas Mate has posted comments on this change. ( http://gerrit.cloudera.org:8080/18837 ) Change subject: IMPALA-11429: Set table owner after creating an Iceberg table .. Patch Set 5: (3 comments) http://gerrit.cloudera.org:80

[Impala-ASF-CR] IMPALA-11294: Remove dictionary runtime filter test workarounds

2022-08-20 Thread Tamas Mate (Code Review)
Tamas Mate has posted comments on this change. ( http://gerrit.cloudera.org:8080/18839 ) Change subject: IMPALA-11294: Remove dictionary runtime filter test workarounds .. Patch Set 3: Failure caused by some infra issues: Cre

[Impala-ASF-CR] IMPALA-11436: Change search bind authentication parameters

2022-08-20 Thread Tamas Mate (Code Review)
Tamas Mate has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18819 ) Change subject: IMPALA-11436: Change search bind authentication parameters .. IMPALA-11436: Change search bind authentication para

[Impala-ASF-CR] IMPALA-11436: Change search bind authentication parameters

2022-08-20 Thread Tamas Mate (Code Review)
Tamas Mate has uploaded a new patch set (#5). ( http://gerrit.cloudera.org:8080/18819 ) Change subject: IMPALA-11436: Change search bind authentication parameters .. IMPALA-11436: Change search bind authentication parameters Im

[Impala-ASF-CR] IMPALA-11436: Change search bind authentication parameters

2022-08-20 Thread Tamas Mate (Code Review)
Tamas Mate has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/18819 ) Change subject: IMPALA-11436: Change search bind authentication parameters .. IMPALA-11436: Change search bind authentication parameters Im

[Impala-ASF-CR] IMPALA-11436: Change search bind authentication parameters

2022-08-20 Thread Tamas Mate (Code Review)
Tamas Mate has posted comments on this change. ( http://gerrit.cloudera.org:8080/18819 ) Change subject: IMPALA-11436: Change search bind authentication parameters .. Patch Set 1: (1 comment) Thank you for the review Csaba, u

[Impala-ASF-CR] IMPALA-11483: [DOCS] Document EXPIRE SNAPSHOTS functionality

2022-08-20 Thread Tamas Mate (Code Review)
Tamas Mate has posted comments on this change. ( http://gerrit.cloudera.org:8080/18838 ) Change subject: IMPALA-11483: [DOCS] Document EXPIRE SNAPSHOTS functionality .. Patch Set 1: (4 comments) Thank you for the review Andre

[Impala-ASF-CR] IMPALA-11483: [DOCS] Document EXPIRE SNAPSHOTS functionality

2022-08-20 Thread Tamas Mate (Code Review)
Tamas Mate has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/18838 ) Change subject: IMPALA-11483: [DOCS] Document EXPIRE SNAPSHOTS functionality .. IMPALA-11483: [DOCS] Document EXPIRE SNAPSHOTS functionality

<    1   2   3   4   5   6   7   >