[Impala-ASF-CR] IMPALA-6128: Spill-to-disk Encryption(AES-CFB + SHA256) is slow

2017-11-15 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/8510 ) Change subject: IMPALA-6128: Spill-to-disk Encryption(AES-CFB + SHA256) is slow .. Patch Set 2: Thanks for doing this. It seems

[Impala-ASF-CR] IMPALA-5053: [SECURITY] Make KRPC work with Kerberos

2017-11-09 Thread Sailesh Mukil (Code Review)
Hello Michael Ho, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8270 to look at the new patch set (#3). Change subject: IMPALA-5053: [SECURITY] Make KRPC work with Kerberos ..

[Impala-ASF-CR] IMPALA-5053: [SECURITY] Make KRPC work with Kerberos

2017-11-09 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/8270 ) Change subject: IMPALA-5053: [SECURITY] Make KRPC work with Kerberos .. Patch Set 3: (11 comments)

[Impala-ASF-CR] IMPALA-6164: Fix stale query profile in TestAlwaysFalseFilter

2017-11-08 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/8498 ) Change subject: IMPALA-6164: Fix stale query profile in TestAlwaysFalseFilter .. Patch Set 1: Code-Review+1 (2 comments)

[Impala-ASF-CR] IMPALA-5473: [DOCS] Document TLS min version & cipher options

2017-11-07 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/8401 ) Change subject: IMPALA-5473: [DOCS] Document TLS min version & cipher options .. Patch Set 3: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-3613: Avoid topic updates to unregistered subscriber instances

2017-11-06 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/8449 ) Change subject: IMPALA-3613: Avoid topic updates to unregistered subscriber instances .. Patch Set 5: Code-Review+1 -- To view,

[Impala-ASF-CR] IMPALA-4671: (part-1) Copy kudu::ServicePool into Impala namespace

2017-11-04 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/8471 ) Change subject: IMPALA-4671: (part-1) Copy kudu::ServicePool into Impala namespace .. IMPALA-4671: (part-1) Copy kudu::ServicePool into

[Impala-ASF-CR] IMPALA-4671: (part-2) Replace kudu::ServicePool with one that uses Impala threads

2017-11-04 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/8472 ) Change subject: IMPALA-4671: (part-2) Replace kudu::ServicePool with one that uses Impala threads .. IMPALA-4671: (part-2) Replace

[Impala-ASF-CR] IMPALA-3613: Avoid topic updates to unregistered subscriber instances

2017-11-03 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/8449 ) Change subject: IMPALA-3613: Avoid topic updates to unregistered subscriber instances .. Patch Set 3: (4 comments)

[Impala-ASF-CR] IMPALA-6144: PublishFilter() continues to run after query failure/cancellation

2017-11-03 Thread Sailesh Mukil (Code Review)
Hello Bharath Vissapragada, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8455 to look at the new patch set (#2). Change subject: IMPALA-6144: PublishFilter() continues to run after query failure/cancellation

[Impala-ASF-CR] IMPALA-6144: PublishFilter() continues to run after query failure/cancellation

2017-11-03 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/8455 ) Change subject: IMPALA-6144: PublishFilter() continues to run after query failure/cancellation .. Patch Set 2: (5 comments)

[Impala-ASF-CR] IMPALA-6144: UpdateFilter()/PublishFilter() continue to run after query failure/cancellation

2017-11-02 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8455 Change subject: IMPALA-6144: UpdateFilter()/PublishFilter() continue to run after query failure/cancellation .. IMPALA-6144:

[Impala-ASF-CR] IMPALA-3613: Avoid topic updates to unregistered subscriber instances

2017-11-01 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/8449 ) Change subject: IMPALA-3613: Avoid topic updates to unregistered subscriber instances .. Patch Set 2: (7 comments) Thanks for doing

[Impala-ASF-CR] IMPALA-5054: [SECURITY] Enable KRPC w/ TLS in Impala

2017-11-01 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8439 Change subject: IMPALA-5054: [SECURITY] Enable KRPC w/ TLS in Impala .. IMPALA-5054: [SECURITY] Enable KRPC w/ TLS in Impala KRPC has

[Impala-ASF-CR] IMPALA-5053: [SECURITY] Make KRPC work with Kerberos

2017-11-01 Thread Sailesh Mukil (Code Review)
Hello Michael Ho, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8270 to look at the new patch set (#2). Change subject: IMPALA-5053: [SECURITY] Make KRPC work with Kerberos ..

[Impala-ASF-CR] IMPALA-4978 / IMPALA-5631: [DOCS] Add FQDN known issue

2017-10-31 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/7388 ) Change subject: IMPALA-4978 / IMPALA-5631: [DOCS] Add FQDN known issue .. Patch Set 3: (1 comment) Sorry, just saw this today.

[Impala-ASF-CR] IMPALA-6126: ASAN detects heap-use-after-free in thrift-server-test

2017-10-31 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/8412 ) Change subject: IMPALA-6126: ASAN detects heap-use-after-free in thrift-server-test .. Patch Set 5: Code-Review+2 Thanks for the

[Impala-ASF-CR] IMPALA-6126: ASAN detects heap-use-after-free in thrift-server-test

2017-10-31 Thread Sailesh Mukil (Code Review)
Hello Lars Volker, Tim Armstrong, Alex Behm, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8412 to look at the new patch set (#4). Change subject: IMPALA-6126: ASAN detects heap-use-after-free in thrift-server-test

[Impala-ASF-CR] IMPALA-6126: ASAN detects heap-use-after-free in thrift-server-test

2017-10-31 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/8412 ) Change subject: IMPALA-6126: ASAN detects heap-use-after-free in thrift-server-test .. Patch Set 3: Looks like I found the real bug.

[Impala-ASF-CR] IMPALA-6126: ASAN detects heap-use-after-free in thrift-server-test

2017-10-31 Thread Sailesh Mukil (Code Review)
Hello Lars Volker, Tim Armstrong, Alex Behm, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8412 to look at the new patch set (#3). Change subject: IMPALA-6126: ASAN detects heap-use-after-free in thrift-server-test

[Impala-ASF-CR] IMPALA-6126: ASAN detects heap-use-after-free in thrift-server-test

2017-10-30 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/8412 ) Change subject: IMPALA-6126: ASAN detects heap-use-after-free in thrift-server-test .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-6126: ASAN detects heap-use-after-free in thrift-server-test

2017-10-30 Thread Sailesh Mukil (Code Review)
Hello Lars Volker, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8412 to look at the new patch set (#2). Change subject: IMPALA-6126: ASAN detects heap-use-after-free in thrift-server-test

[Impala-ASF-CR] IMPALA-6126: ASAN detects heap-use-after-free in thrift-server-test

2017-10-30 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/8412 ) Change subject: IMPALA-6126: ASAN detects heap-use-after-free in thrift-server-test .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-6126: ASAN detects heap-use-after-free in thrift-server-test

2017-10-30 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8412 Change subject: IMPALA-6126: ASAN detects heap-use-after-free in thrift-server-test .. IMPALA-6126: ASAN detects heap-use-after-free in

[Impala-ASF-CR] IMPALA-5473: [DOCS] Document TLS min version & cipher options

2017-10-27 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/8401 ) Change subject: IMPALA-5473: [DOCS] Document TLS min version & cipher options .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-1575: Part 1: eagerly release query exec resources

2017-10-26 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/8303 ) Change subject: IMPALA-1575: Part 1: eagerly release query exec resources .. Patch Set 11: Code-Review+1 (1 comment) Thanks for the

[Impala-ASF-CR] IMPALA-5129: Use Kudu's Kinit code to avoid expensive fork

2017-10-26 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/7938 ) Change subject: IMPALA-5129: Use Kudu's Kinit code to avoid expensive fork .. Patch Set 14: Code-Review+2 Fix minor clang-tidy issues.

[Impala-ASF-CR] IMPALA-5129: Use Kudu's Kinit code to avoid expensive fork

2017-10-26 Thread Sailesh Mukil (Code Review)
Hello Michael Ho, Michael Brown, Jim Apple, Bikramjeet Vig, Dan Hecht, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7938 to look at the new patch set (#14). Change subject: IMPALA-5129: Use Kudu's Kinit code to avoid expensive

[Impala-ASF-CR] IMPALA-1575: Part 1: eagerly release query exec resources

2017-10-26 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/8303 ) Change subject: IMPALA-1575: Part 1: eagerly release query exec resources .. Patch Set 10: (4 comments) Just have a few minor

[Impala-ASF-CR] IMPALA-5129: Use Kudu's Kinit code to avoid expensive fork

2017-10-26 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/7938 ) Change subject: IMPALA-5129: Use Kudu's Kinit code to avoid expensive fork .. Patch Set 13: (1 comment)

[Impala-ASF-CR] IMPALA-5129: Use Kudu's Kinit code to avoid expensive fork

2017-10-26 Thread Sailesh Mukil (Code Review)
Hello Michael Ho, Michael Brown, Jim Apple, Bikramjeet Vig, Dan Hecht, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7938 to look at the new patch set (#13). Change subject: IMPALA-5129: Use Kudu's Kinit code to avoid expensive

[Impala-ASF-CR] IMPALA-5129: Use Kudu's Kinit code to avoid expensive fork

2017-10-25 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/7938 ) Change subject: IMPALA-5129: Use Kudu's Kinit code to avoid expensive fork .. Patch Set 12: The GVO was hanging since the kerberos

[Impala-ASF-CR] IMPALA-5129: Use Kudu's Kinit code to avoid expensive fork

2017-10-25 Thread Sailesh Mukil (Code Review)
Hello Michael Ho, Bikramjeet Vig, Dan Hecht, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7938 to look at the new patch set (#12). Change subject: IMPALA-5129: Use Kudu's Kinit code to avoid expensive fork

[Impala-ASF-CR] IMPALA-4456: Address scalability issues of qs map lock and client request state map lock

2017-10-25 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/8363 ) Change subject: IMPALA-4456: Address scalability issues of qs_map_lock_ and client_request_state_map_lock_ .. Patch Set 4: (4

[Impala-ASF-CR] IMPALA-4456: Address scalability issues of qs map lock and client request state map lock

2017-10-25 Thread Sailesh Mukil (Code Review)
Hello Philip Zeyliger, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8363 to look at the new patch set (#4). Change subject: IMPALA-4456: Address scalability issues of qs_map_lock_ and client_request_state_map_lock_

[Impala-ASF-CR] IMPALA-4456: Address scalability issues of qs map lock and client request state map lock

2017-10-23 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/8363 ) Change subject: IMPALA-4456: Address scalability issues of qs_map_lock_ and client_request_state_map_lock_ .. IMPALA-4456: Address

[Impala-ASF-CR] IMPALA-4456: Address scalability issues of qs map lock and client request state map lock

2017-10-23 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/8363 ) Change subject: IMPALA-4456: Address scalability issues of qs_map_lock_ and client_request_state_map_lock_ .. Patch Set 3: (1

[Impala-ASF-CR] IMPALA-5129: Use Kudu's Kinit code to avoid expensive fork

2017-10-23 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/7938 ) Change subject: IMPALA-5129: Use Kudu's Kinit code to avoid expensive fork .. Patch Set 11: Code-Review+2 After a rebase, the binaries

[Impala-ASF-CR] IMPALA-5129: Use Kudu's Kinit code to avoid expensive fork

2017-10-23 Thread Sailesh Mukil (Code Review)
Hello Michael Ho, Bikramjeet Vig, Dan Hecht, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7938 to look at the new patch set (#11). Change subject: IMPALA-5129: Use Kudu's Kinit code to avoid expensive fork

[Impala-ASF-CR] IMPALA-5129: Use Kudu's Kinit code to avoid expensive fork

2017-10-20 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/7938 ) Change subject: IMPALA-5129: Use Kudu's Kinit code to avoid expensive fork .. Patch Set 10: Code-Review+2 Carrying +2. -- To view,

[Impala-ASF-CR] IMPALA-5129: Use Kudu's Kinit code to avoid expensive fork

2017-10-19 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/7938 ) Change subject: IMPALA-5129: Use Kudu's Kinit code to avoid expensive fork .. Patch Set 9: (2 comments) > > (1 comment) > >

[Impala-ASF-CR] IMPALA-5129: Use Kudu's Kinit code to avoid expensive fork

2017-10-19 Thread Sailesh Mukil (Code Review)
Hello Michael Ho, Bikramjeet Vig, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7938 to look at the new patch set (#9). Change subject: IMPALA-5129: Use Kudu's Kinit code to avoid expensive fork

[Impala-ASF-CR] IMPALA-5129: Use KRPC's Kinit code to avoid expensive fork

2017-10-19 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/7938 ) Change subject: IMPALA-5129: Use KRPC's Kinit code to avoid expensive fork .. Patch Set 8: Verified-1 Code-Review+2 > (1 comment)

[Impala-ASF-CR] Allow the SASL protocol service name to be configurable

2017-10-18 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/8230 ) Change subject: Allow the SASL protocol service name to be configurable .. Patch Set 3: Code-Review+2 Rebase, carry +2. -- To view,

[Impala-ASF-CR] Allow the SASL protocol service name to be configurable

2017-10-17 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/8230 ) Change subject: Allow the SASL protocol service name to be configurable .. Patch Set 2: > (1 comment) I tried cherry-picking:

[Impala-ASF-CR] Allow configuration of values passed into kerberos env vars

2017-10-17 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/8308 ) Change subject: Allow configuration of values passed into kerberos env vars .. Patch Set 1: > Uploaded patch set 1. This cherry-pick

[Impala-ASF-CR] Allow configuration of values passed into kerberos env vars

2017-10-17 Thread Sailesh Mukil (Code Review)
Hello Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/8308 to review the following change. Change subject: Allow configuration of values passed into kerberos env vars .. Allow

[Impala-ASF-CR] Reduce log spew from rpcz store.cc

2017-10-16 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/8285 ) Change subject: Reduce log spew from rpcz_store.cc .. Patch Set 1: > Uploaded patch set 1. This cherry-pick was clean and is intended

[Impala-ASF-CR] Reduce log spew from rpcz store.cc

2017-10-16 Thread Sailesh Mukil (Code Review)
Hello Kudu Jenkins, Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/8285 to review the following change. Change subject: Reduce log spew from rpcz_store.cc .. Reduce log spew

[Impala-ASF-CR] IMPALA-6049: breakpad tests: skip all tests with local filesystem

2017-10-13 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/8272 ) Change subject: IMPALA-6049: breakpad tests: skip all tests with local filesystem .. Patch Set 1: Code-Review+1 -- To view, visit

[Impala-ASF-CR] IMPALA-5053: [SECURITY] Make KRPC work with Kerberos

2017-10-12 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/8270 ) Change subject: IMPALA-5053: [SECURITY] Make KRPC work with Kerberos .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-5129: Use KRPC's Kinit code to avoid expensive fork

2017-10-12 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/7938 ) Change subject: IMPALA-5129: Use KRPC's Kinit code to avoid expensive fork .. Patch Set 8: (2 comments)

[Impala-ASF-CR] IMPALA-5053: [SECURITY] Make KRPC work with Kerberos

2017-10-12 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8270 Change subject: IMPALA-5053: [SECURITY] Make KRPC work with Kerberos .. IMPALA-5053: [SECURITY] Make KRPC work with Kerberos KuduRPC

[Impala-ASF-CR] IMPALA-5129: Use KRPC's Kinit code to avoid expensive fork

2017-10-12 Thread Sailesh Mukil (Code Review)
Hello Michael Ho, Bikramjeet Vig, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7938 to look at the new patch set (#8). Change subject: IMPALA-5129: Use KRPC's Kinit code to avoid expensive fork

[Impala-ASF-CR] IMPALA-4856: Port data stream service to KRPC

2017-10-11 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/8023 ) Change subject: IMPALA-4856: Port data stream service to KRPC .. Patch Set 3: (23 comments)

[Impala-ASF-CR] IMPALA-6030: Don't start coordinator specific thread pools if a node isn't a coordinator node

2017-10-11 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/8242 ) Change subject: IMPALA-6030: Don't start coordinator specific thread pools if a node isn't a coordinator node .. Patch Set 3: (1

[Impala-ASF-CR] IMPALA-6030: Don't start coordinator specific thread pools if a node isn't a coordinator node

2017-10-11 Thread Sailesh Mukil (Code Review)
Hello Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8242 to look at the new patch set (#3). Change subject: IMPALA-6030: Don't start coordinator specific thread pools if a node isn't a coordinator node

[Impala-ASF-CR] Allow the SASL protocol service name to be configurable

2017-10-11 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/8230 ) Change subject: Allow the SASL protocol service name to be configurable .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-6030: Don't start coordinator specific thread pools if a node isn't a coordinator node

2017-10-11 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/8242 ) Change subject: IMPALA-6030: Don't start coordinator specific thread pools if a node isn't a coordinator node .. Patch Set 2: > It'd

[Impala-ASF-CR] IMPALA-6030: Don't start coordinator specific thread pools if a node isn't a coordinator node

2017-10-11 Thread Sailesh Mukil (Code Review)
Hello Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8242 to look at the new patch set (#2). Change subject: IMPALA-6030: Don't start coordinator specific thread pools if a node isn't a coordinator node

[Impala-ASF-CR] Allow the SASL protocol service name to be configurable

2017-10-11 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/8230 ) Change subject: Allow the SASL protocol service name to be configurable .. Patch Set 1: (1 comment)

[Impala-ASF-CR] Allow the SASL protocol service name to be configurable

2017-10-11 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/8230 ) Change subject: Allow the SASL protocol service name to be configurable .. Patch Set 1: (2 comments) > Is this a conflict free

[Impala-ASF-CR] IMPALA-5940: Avoid log spew by using Status::Expected()

2017-10-11 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/8255 ) Change subject: IMPALA-5940: Avoid log spew by using Status::Expected() .. Patch Set 1: Code-Review+1 (1 comment)

[Impala-ASF-CR] IMPALA-5129: Use KRPC's Kinit code to avoid expensive fork

2017-10-10 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/7938 ) Change subject: IMPALA-5129: Use KRPC's Kinit code to avoid expensive fork .. Patch Set 6: (4 comments)

[Impala-ASF-CR] IMPALA-5129: Use KRPC's Kinit code to avoid expensive fork

2017-10-10 Thread Sailesh Mukil (Code Review)
Hello Michael Ho, Bikramjeet Vig, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7938 to look at the new patch set (#7). Change subject: IMPALA-5129: Use KRPC's Kinit code to avoid expensive fork

[Impala-ASF-CR] IMPALA-5940: Avoid log spew by using Status::Expected()

2017-10-10 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/8255 ) Change subject: IMPALA-5940: Avoid log spew by using Status::Expected() .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-5129: Use KRPC's Kinit code to avoid expensive fork

2017-10-10 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/7938 ) Change subject: IMPALA-5129: Use KRPC's Kinit code to avoid expensive fork .. Patch Set 6: (1 comment)

[Impala-ASF-CR] IMPALA-5129: Use KRPC's Kinit code to avoid expensive fork

2017-10-10 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/7938 ) Change subject: IMPALA-5129: Use KRPC's Kinit code to avoid expensive fork .. Patch Set 6: (1 comment)

[Impala-ASF-CR] IMPALA-5129: Use KRPC's Kinit code to avoid expensive fork

2017-10-10 Thread Sailesh Mukil (Code Review)
Hello Michael Ho, Bikramjeet Vig, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7938 to look at the new patch set (#6). Change subject: IMPALA-5129: Use KRPC's Kinit code to avoid expensive fork

[Impala-ASF-CR] IMPALA-5129: Use KRPC's Kinit code to avoid expensive fork

2017-10-09 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/7938 ) Change subject: IMPALA-5129: Use KRPC's Kinit code to avoid expensive fork .. Patch Set 5: (2 comments)

[Impala-ASF-CR] IMPALA-5789: Add always false flag in bloom filter

2017-10-09 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/8170 ) Change subject: IMPALA-5789: Add always_false flag in bloom filter .. Patch Set 2: (3 comments)

[Impala-ASF-CR] Allow the SASL protocol service name to be configurable

2017-10-06 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/8230 ) Change subject: Allow the SASL protocol service name to be configurable .. Patch Set 1: This patch allows Impala to pass in the SASL

[Impala-ASF-CR] Allow the SASL protocol service name to be configurable

2017-10-06 Thread Sailesh Mukil (Code Review)
Hello Dan Burkert, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/8230 to review the following change. Change subject: Allow the SASL protocol service name to be configurable .. Allow the

[Impala-ASF-CR] IMPALA-4671: Replace kudu::ServicePool with one that uses Impala threads

2017-10-05 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has abandoned this change. ( http://gerrit.cloudera.org:8080/8094 ) Change subject: IMPALA-4671: Replace kudu::ServicePool with one that uses Impala threads .. Abandoned Will update with a patch that uses an

[Impala-ASF-CR] IMPALA-5129: Use KRPC's Kinit code to avoid expensive fork

2017-10-05 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/7938 ) Change subject: IMPALA-5129: Use KRPC's Kinit code to avoid expensive fork .. Patch Set 5: (2 comments)

[Impala-ASF-CR] IMPALA-5129: Use KRPC's Kinit code to avoid expensive fork

2017-10-05 Thread Sailesh Mukil (Code Review)
Hello Michael Ho, Bikramjeet Vig, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7938 to look at the new patch set (#5). Change subject: IMPALA-5129: Use KRPC's Kinit code to avoid expensive fork

[Impala-ASF-CR] IMPALA-5394: Change ThriftServer() to always use TAcceptQueueServer

2017-10-04 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/7061 ) Change subject: IMPALA-5394: Change ThriftServer() to always use TAcceptQueueServer .. Patch Set 14: Verified+1 > Thanks! Also thanks

[Impala-ASF-CR] Remove dead code parallel-executor*

2017-10-04 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/8206 ) Change subject: Remove dead code parallel-executor* .. Patch Set 1: Code-Review+1 (1 comment)

[Impala-ASF-CR] IMPALA-5394: Change ThriftServer() to always use TAcceptQueueServer

2017-10-04 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/7061 ) Change subject: IMPALA-5394: Change ThriftServer() to always use TAcceptQueueServer .. Patch Set 12: Code-Review+2 > It looks like it

[Impala-ASF-CR] IMPALA-5394: Change ThriftServer() to always use TAcceptQueueServer

2017-10-04 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/7061 ) Change subject: IMPALA-5394: Change ThriftServer() to always use TAcceptQueueServer .. Patch Set 13: Code-Review+2 Rebase, Carry +2.

[Impala-ASF-CR] IMPALA-5174: Suppress kudu flags that aren't relevant to Impala

2017-10-03 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/8074 ) Change subject: IMPALA-5174: Suppress kudu flags that aren't relevant to Impala .. Patch Set 2: Code-Review+2 (1 comment) Rebase,

[Impala-ASF-CR] IMPALA-5174: Suppress kudu flags that aren't relevant to Impala

2017-10-03 Thread Sailesh Mukil (Code Review)
Hello Michael Ho, Joe McDonnell, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8074 to look at the new patch set (#2). Change subject: IMPALA-5174: Suppress kudu flags that aren't relevant to Impala

[Impala-ASF-CR] IMPALA-5940: Avoid log spew by using Status::Expected.

2017-10-03 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/8100 ) Change subject: IMPALA-5940: Avoid log spew by using Status::Expected. .. Patch Set 5: (1 comment)

[Impala-ASF-CR] IMPALA-5940: Avoid log spew by using Status::Expected.

2017-10-03 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/8100 ) Change subject: IMPALA-5940: Avoid log spew by using Status::Expected. .. Patch Set 5: (1 comment)

[Impala-ASF-CR] IMPALA-5394: Change ThriftServer() to always use TAcceptQueueServer

2017-10-03 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/7061 ) Change subject: IMPALA-5394: Change ThriftServer() to always use TAcceptQueueServer .. Patch Set 10: (1 comment) Thanks Mike. @John:

[Impala-ASF-CR] IMPALA-5394: Change ThriftServer() to always use TAcceptQueueServer

2017-10-02 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/7061 ) Change subject: IMPALA-5394: Change ThriftServer() to always use TAcceptQueueServer .. Patch Set 9: (1 comment) Yes, a run of the

[Impala-ASF-CR] IMPALA-4786: Clean up how ImpalaServers are created

2017-10-02 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/8076 ) Change subject: IMPALA-4786: Clean up how ImpalaServers are created .. Patch Set 6: Code-Review+2 Hit IMPALA-5999 twice in a row.

[Impala-ASF-CR] IMPALA-5394: Change ThriftServer() to always use TAcceptQueueServer

2017-09-29 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/7061 ) Change subject: IMPALA-5394: Change ThriftServer() to always use TAcceptQueueServer .. Patch Set 8: > No problem, I just got back

[Impala-ASF-CR] IMPALA-5394: Change ThriftServer() to always use TAcceptQueueServer

2017-09-29 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/7061 ) Change subject: IMPALA-5394: Change ThriftServer() to always use TAcceptQueueServer .. Patch Set 8: (3 comments) Sorry for the slow

[Impala-ASF-CR] IMPALA-4786: Clean up how ImpalaServers are created

2017-09-29 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/8076 ) Change subject: IMPALA-4786: Clean up how ImpalaServers are created .. Patch Set 5: Code-Review+2 Hit a flaky test. Will investigate

[Impala-ASF-CR] IMPALA-4786: Clean up how ImpalaServers are created

2017-09-28 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/8076 ) Change subject: IMPALA-4786: Clean up how ImpalaServers are created .. Patch Set 4: Code-Review+2 Rebase, carry +2. -- To view,

[Impala-ASF-CR] IMPALA-4856: Port data stream service to KRPC

2017-09-26 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/8023 ) Change subject: IMPALA-4856: Port data stream service to KRPC .. Patch Set 1: (5 comments)

[Impala-ASF-CR] IMPALA-4786: Clean up how ImpalaServers are created

2017-09-26 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/8076 ) Change subject: IMPALA-4786: Clean up how ImpalaServers are created .. Patch Set 3: (2 comments)

[Impala-ASF-CR] IMPALA-4786: Clean up how ImpalaServers are created

2017-09-26 Thread Sailesh Mukil (Code Review)
Hello Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8076 to look at the new patch set (#3). Change subject: IMPALA-4786: Clean up how ImpalaServers are created .. IMPALA-4786:

[Impala-ASF-CR] IMPALA-4856: Port data stream service to KRPC

2017-09-25 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/8023 ) Change subject: IMPALA-4856: Port data stream service to KRPC .. Patch Set 1: (14 comments)

[Impala-ASF-CR] IMPALA-5895: clean up runtime profile lifecycle

2017-09-19 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: IMPALA-5895: clean up runtime profile lifecycle .. Patch Set 10: Code-Review+1 I went over the fix to AddTimeSeriesCounter, and it looks correct. This patch

[Impala-ASF-CR] IMPALA-5895: clean up runtime profile lifecycle

2017-09-19 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: IMPALA-5895: clean up runtime profile lifecycle .. Patch Set 9: Code-Review+1 (2 comments) LGTM, except these 2 comments.

[Impala-ASF-CR] IMPALA-5895: clean up runtime profile lifecycle

2017-09-19 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: IMPALA-5895: clean up runtime profile lifecycle .. Patch Set 8: (3 comments) http://gerrit.cloudera.org:8080/#/c/8069/8//COMMIT_MSG Commit Message: Line 19:

[Impala-ASF-CR] IMPALA-5895: clean up runtime profile lifecycle

2017-09-19 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: IMPALA-5895: clean up runtime profile lifecycle .. Patch Set 7: (4 comments) http://gerrit.cloudera.org:8080/#/c/8069/7/be/src/util/runtime-profile.cc File

[Impala-ASF-CR] IMPALA-4786: Clean up how ImpalaServers are created

2017-09-18 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: IMPALA-4786: Clean up how ImpalaServers are created .. Patch Set 2: (5 comments) http://gerrit.cloudera.org:8080/#/c/8076/1/be/src/service/impala-server.cc

  1   2   3   4   5   6   >