[kudu-CR] [tools] rebalancer in the kudu CLI tool

2018-05-30 Thread Alexey Serbin (Code Review)
Hello Will Berkeley, Mike Percy, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10399 to look at the new patch set (#13). Change subject: [tools] rebalancer in the kudu CLI tool

[kudu-CR] [tools] rebalancer in the kudu CLI tool

2018-05-30 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/10399 ) Change subject: [tools] rebalancer in the kudu CLI tool .. Patch Set 13: (68 comments)

[kudu-CR] WIP [kudu CLI] more integration tests for rebalancer

2018-05-30 Thread Alexey Serbin (Code Review)
Hello Tidy Bot, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10540 to look at the new patch set (#2). Change subject: WIP [kudu CLI] more integration tests for rebalancer

[kudu-CR] KUDU-2191: Leave table type as it is when populate a table

2018-05-30 Thread Hao Hao (Code Review)
Hao Hao has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10477 ) Change subject: KUDU-2191: Leave table type as it is when populate a table .. KUDU-2191: Leave table type as it is when populate a

[kudu-CR] KUDU-2438 Class relocation in the maven build should be

2018-05-30 Thread Ferenc Szabo (Code Review)
Ferenc Szabo has posted comments on this change. ( http://gerrit.cloudera.org:8080/10524 ) Change subject: KUDU-2438 Class relocation in the maven build should be .. Patch Set 2: Dan, you have moved the relocation from the

[kudu-CR] build: improve parse test failure script

2018-05-30 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/10224 ) Change subject: build: improve parse_test_failure script .. Patch Set 2: (5 comments)

[kudu-CR] build: improve parse test failure script

2018-05-30 Thread Todd Lipcon (Code Review)
Todd Lipcon has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10224 Change subject: build: improve parse_test_failure script .. build: improve parse_test_failure script This updates the script to properly

[kudu-CR] [tools] KUDU-2413 Configurable # of reactors in loadgen

2018-05-30 Thread Attila Bukor (Code Review)
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/10542 ) Change subject: [tools] KUDU-2413 Configurable # of reactors in loadgen .. Patch Set 2: (1 comment)

[kudu-CR] thirdparty: clean up unused argument warnings

2018-05-30 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10469 ) Change subject: thirdparty: clean up unused argument warnings .. thirdparty: clean up unused argument warnings Commit ba3cdea53

[kudu-CR] KUDU-2191: Leave table type as it is when populate a table

2018-05-30 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/10477 ) Change subject: KUDU-2191: Leave table type as it is when populate a table .. Patch Set 2: Code-Review+2 -- To view, visit

[kudu-CR] thirdparty: clean up unused argument warnings

2018-05-30 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/10469 ) Change subject: thirdparty: clean up unused argument warnings .. Patch Set 1: Code-Review+2 LGTM. Tested on macos. -- To view, visit

[kudu-CR] [docs] KUDU-2107 Document how to add reviewers

2018-05-30 Thread Dan Burkert (Code Review)
Dan Burkert has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10501 ) Change subject: [docs] KUDU-2107 Document how to add reviewers .. [docs] KUDU-2107 Document how to add reviewers The

[kudu-CR] [docs] KUDU-2107 Document how to add reviewers

2018-05-30 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/10501 ) Change subject: [docs] KUDU-2107 Document how to add reviewers .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] KUDU-2438 Class relocation in the maven build should be

2018-05-30 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/10524 ) Change subject: KUDU-2438 Class relocation in the maven build should be .. Patch Set 2: Related commit:

[kudu-CR] [java] Add Timestamp APIs to kudu-client

2018-05-30 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/10502 ) Change subject: [java] Add Timestamp APIs to kudu-client .. Patch Set 1: (10 comments)

[kudu-CR](branch-1.7.x) make shared: fix build for newer libc++

2018-05-30 Thread Attila Bukor (Code Review)
Attila Bukor has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10549 Change subject: make_shared: fix build for newer libc++ .. make_shared: fix build for newer libc++ Previously, we used friendship with

[kudu-CR] [Java] Add Schema.getColumnById

2018-05-30 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/10546 ) Change subject: [Java] Add Schema.getColumnById .. Patch Set 1: (1 comment)

[kudu-CR] [Java] Add private API to get a table range partitions

2018-05-30 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/10547 ) Change subject: [Java] Add private API to get a table range partitions .. Patch Set 1: (3 comments)

[kudu-CR] [WIP] KUDU-2242 Wait for NTP synchronization on startup

2018-05-30 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/10548 ) Change subject: [WIP] KUDU-2242 Wait for NTP synchronization on startup .. Patch Set 1: (3 comments)

[kudu-CR] [WIP] KUDU-2242 Wait for NTP synchronization on startup

2018-05-30 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/10548 ) Change subject: [WIP] KUDU-2242 Wait for NTP synchronization on startup .. Patch Set 1: > I wonder if we should condition this on

[kudu-CR] [WIP] KUDU-2242 Wait for NTP synchronization on startup

2018-05-30 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/10548 ) Change subject: [WIP] KUDU-2242 Wait for NTP synchronization on startup .. Patch Set 1: I wonder if we should condition this on either

[kudu-CR] [WIP] KUDU-2242 Wait for NTP synchronization on startup

2018-05-30 Thread Will Berkeley (Code Review)
Will Berkeley has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10548 Change subject: [WIP] KUDU-2242 Wait for NTP synchronization on startup .. [WIP] KUDU-2242 Wait for NTP synchronization on startup

[kudu-CR] [Java] Add private API to get a table range partitions

2018-05-30 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/10547 ) Change subject: [Java] Add private API to get a table range partitions .. Patch Set 1: (2 comments)

[kudu-CR] [Java] Add Schema.getColumnById

2018-05-30 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/10546 ) Change subject: [Java] Add Schema.getColumnById .. Patch Set 1: (1 comment) > Patch Set 1: > > (1 comment)

[kudu-CR] [Java] Add private API to get a table range partitions

2018-05-30 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/10547 ) Change subject: [Java] Add private API to get a table range partitions .. Patch Set 1: (1 comment) As a side note, Impala has a todo

[kudu-CR] Adding a subsection to NTP troubleshooting section to cover frequent cases of NTP crashes when the Kudu cluster is deployed on Microsoft Azure

2018-05-30 Thread Alex Rodoni (Code Review)
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/8960 ) Change subject: Adding a subsection to NTP troubleshooting section to cover frequent cases of NTP crashes when the Kudu cluster is deployed on Microsoft Azure

[kudu-CR] [Java] Add Schema.getColumnById

2018-05-30 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/10546 ) Change subject: [Java] Add Schema.getColumnById .. Patch Set 1: (1 comment)

[kudu-CR] WIP: support for running Java tests in dist-test

2018-05-30 Thread Hao Hao (Code Review)
Hao Hao has abandoned this change. ( http://gerrit.cloudera.org:8080/9932 ) Change subject: WIP: support for running Java tests in dist-test .. Abandoned -- To view, visit http://gerrit.cloudera.org:8080/9932 To unsubscribe,

[kudu-CR] [Java] Add private API to get a table range partitions

2018-05-30 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/10547 ) Change subject: [Java] Add private API to get a table range partitions .. Patch Set 1: (2 comments)

[kudu-CR] [Java] Add Schema.getColumnById

2018-05-30 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/10546 ) Change subject: [Java] Add Schema.getColumnById .. Patch Set 1: (1 comment)

[kudu-CR] WIP: Kudu Backup/Restore Spark Jobs

2018-05-30 Thread Grant Henke (Code Review)
Hello Mike Percy, Kudu Jenkins, Adar Dembo, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10375 to look at the new patch set (#10). Change subject: WIP: Kudu Backup/Restore Spark Jobs

[kudu-CR] [Java] Add Schema.getColumnById

2018-05-30 Thread Grant Henke (Code Review)
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10546 Change subject: [Java] Add Schema.getColumnById .. [Java] Add Schema.getColumnById Change-Id: Iee5c1abbe864b3e9f6905e0f70e9b708175071b0

[kudu-CR] [Java] Add private API to get a table range partitions

2018-05-30 Thread Grant Henke (Code Review)
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10547 Change subject: [Java] Add private API to get a table range partitions .. [Java] Add private API to get a table range partitions Adds a

[kudu-CR] Fix ksck checksum scan printing

2018-05-30 Thread Fengling Wang (Code Review)
Fengling Wang has posted comments on this change. ( http://gerrit.cloudera.org:8080/10535 ) Change subject: Fix ksck checksum_scan printing .. Patch Set 4: (2 comments)

[kudu-CR] Fix ksck checksum scan printing

2018-05-30 Thread Fengling Wang (Code Review)
Hello Will Berkeley, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10535 to look at the new patch set (#5). Change subject: Fix ksck checksum_scan printing .. Fix ksck

[kudu-CR] KUDU-2353 (part 1): add a tool to parse stacks from diagnostics log

2018-05-30 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/9773 ) Change subject: KUDU-2353 (part 1): add a tool to parse stacks from diagnostics log .. Patch Set 4: Ah, I forgot about that. Thanks

[kudu-CR] KUDU-2353 (part 1): add a tool to parse stacks from diagnostics log

2018-05-30 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/9773 ) Change subject: KUDU-2353 (part 1): add a tool to parse stacks from diagnostics log .. Patch Set 4: Looks good though I'd still like to

[kudu-CR] KUDU-2447 Fix TS crashed with "NONE predicate can not be pushed into key"

2018-05-30 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/10514 ) Change subject: KUDU-2447 Fix TS crashed with "NONE predicate can not be pushed into key" .. Patch Set 3: (1 comment) Great find,

[kudu-CR] KUDU-2287 Expose election failures as metrics

2018-05-30 Thread Attila Bukor (Code Review)
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/10076 ) Change subject: KUDU-2287 Expose election failures as metrics .. Patch Set 22: (7 comments)

[kudu-CR] KUDU-2287 Expose election failures as metrics

2018-05-30 Thread Attila Bukor (Code Review)
Hello Will Berkeley, Tidy Bot, Mike Percy, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10076 to look at the new patch set (#22). Change subject: KUDU-2287 Expose election failures as metrics

[kudu-CR] [tools] KUDU-2413 Configurable # of reactors in loadgen

2018-05-30 Thread Attila Bukor (Code Review)
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/10542 ) Change subject: [tools] KUDU-2413 Configurable # of reactors in loadgen .. Patch Set 2: (3 comments)

[kudu-CR] [tools] KUDU-2413 Configurable # of reactors in loadgen

2018-05-30 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/10542 ) Change subject: [tools] KUDU-2413 Configurable # of reactors in loadgen .. Patch Set 2: (2 comments)

[kudu-CR] KUDU-2287 Expose election failures as metrics

2018-05-30 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/10076 ) Change subject: KUDU-2287 Expose election failures as metrics .. Patch Set 21: (7 comments)

[kudu-CR] [tools] KUDU-2413 Configurable # of reactors in loadgen

2018-05-30 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/10542 ) Change subject: [tools] KUDU-2413 Configurable # of reactors in loadgen .. Patch Set 1: (3 comments)

[kudu-CR] [tools] KUDU-2413 Configurable # of reactors in loadgen

2018-05-30 Thread Attila Bukor (Code Review)
Hello Will Berkeley, Alexey Serbin, Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/10542 to review the following change. Change subject: [tools] KUDU-2413 Configurable # of reactors in loadgen

[kudu-CR] KUDU-2287 Expose election failures as metrics

2018-05-30 Thread Attila Bukor (Code Review)
Hello Will Berkeley, Tidy Bot, Mike Percy, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10076 to look at the new patch set (#21). Change subject: KUDU-2287 Expose election failures as metrics

[kudu-CR] KUDU-2287 Expose election failures as metrics

2018-05-30 Thread Attila Bukor (Code Review)
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/10076 ) Change subject: KUDU-2287 Expose election failures as metrics .. Patch Set 20: > Patch Set 15: > > (1 comment) > > Also needs some

[kudu-CR] KUDU-2287 Expose election failures as metrics

2018-05-30 Thread Attila Bukor (Code Review)
Hello Will Berkeley, Tidy Bot, Mike Percy, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10076 to look at the new patch set (#20). Change subject: KUDU-2287 Expose election failures as metrics

[kudu-CR] KUDU-2287 Expose election failures as metrics

2018-05-30 Thread Attila Bukor (Code Review)
Hello Will Berkeley, Tidy Bot, Mike Percy, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10076 to look at the new patch set (#19). Change subject: KUDU-2287 Expose election failures as metrics

[kudu-CR] KUDU-2353 (part 1): add a tool to parse stacks from diagnostics log

2018-05-30 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/9773 ) Change subject: KUDU-2353 (part 1): add a tool to parse stacks from diagnostics log .. Patch Set 3: (2 comments)

[kudu-CR] KUDU-2353 (part 1): add a tool to parse stacks from diagnostics log

2018-05-30 Thread Will Berkeley (Code Review)
Will Berkeley has uploaded a new patch set (#4) to the change originally created by Todd Lipcon. ( http://gerrit.cloudera.org:8080/9773 ) Change subject: KUDU-2353 (part 1): add a tool to parse stacks from diagnostics log ..

[kudu-CR] WIP [kudu CLI] more integration tests for rebalancer

2018-05-30 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10540 Change subject: WIP [kudu CLI] more integration tests for rebalancer .. WIP [kudu CLI] more integration tests for rebalancer Added one

[kudu-CR] [tools] rebalancer in the kudu CLI tool

2018-05-30 Thread Alexey Serbin (Code Review)
Hello Will Berkeley, Mike Percy, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10399 to look at the new patch set (#12). Change subject: [tools] rebalancer in the kudu CLI tool ..

[kudu-CR] [rebalancing] Add a rebalancing algorithm

2018-05-30 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/10336 ) Change subject: [rebalancing] Add a rebalancing algorithm .. Patch Set 14: (11 comments) Just some nits on comments and formatting.