[kudu-CR] [txns][tools] add a state filter to `txns list` tool

2021-05-03 Thread Andrew Wong (Code Review)
Hello Tidy Bot, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17371 to look at the new patch set (#3). Change subject: [txns][tools] add a state filter to `txns list` tool

[kudu-CR] [backup] KUDU-3183 Add tablePrefix option to the Kudu restore job

2021-05-03 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17388 ) Change subject: [backup] KUDU-3183 Add tablePrefix option to the Kudu restore job .. Patch Set 1: (1 comment)

[kudu-CR] KUDU-3223: Management of per-table level limit

2021-05-03 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17273 ) Change subject: KUDU-3223: Management of per-table level limit .. Patch Set 35: (2 comments)

[kudu-CR] [backup] KUDU-3183 Add tablePrefix option to the Kudu restore job

2021-05-03 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17388 ) Change subject: [backup] KUDU-3183 Add tablePrefix option to the Kudu restore job .. Patch Set 1: (3 comments)

[kudu-CR] [test] fix flakiness in RegistrationTest.TestTSRegisters

2021-05-02 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17377 ) Change subject: [test] fix flakiness in RegistrationTest.TestTSRegisters .. Patch Set 1: Code-Review+2 (1 comment)

[kudu-CR] [subprocess] fix flakiness in TestEchoSubprocess

2021-05-02 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17381 ) Change subject: [subprocess] fix flakiness in TestEchoSubprocess .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] [test] fix flakiness in RegistrationTest.TestTSRegisters

2021-05-02 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17377 ) Change subject: [test] fix flakiness in RegistrationTest.TestTSRegisters .. Patch Set 1: Code-Review+1 (1 comment)

[kudu-CR] [rpc] add transport-specific info for RPC connections

2021-04-30 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17369 ) Change subject: [rpc] add transport-specific info for RPC connections .. Patch Set 2: Code-Review+2 -- To view, visit

[kudu-CR] [rpc] add transport-specific info for RPC connections

2021-04-30 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17369 ) Change subject: [rpc] add transport-specific info for RPC connections .. Patch Set 1: Code-Review+2 (1 comment)

[kudu-CR] [rpc] add transport-specific info for RPC connections

2021-04-30 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17369 ) Change subject: [rpc] add transport-specific info for RPC connections .. Patch Set 1: (1 comment)

[kudu-CR] [rpc] add transport-specific info for RPC connections

2021-04-30 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17369 ) Change subject: [rpc] add transport-specific info for RPC connections .. Patch Set 1: Code-Review+1 (1 comment)

[kudu-CR] KUDU-2754: Mark max log files as stable

2021-04-30 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17362 ) Change subject: KUDU-2754: Mark max_log_files as stable .. Patch Set 3: Code-Review+2 -- To view, visit

[kudu-CR] [tests] enable using txns in TestWorkload

2021-04-30 Thread Andrew Wong (Code Review)
Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17326 ) Change subject: [tests] enable using txns in TestWorkload .. [tests] enable using txns in TestWorkload I have an upcoming test

[kudu-CR] [client] return TimedOut if the deadline has passed in master RPCs

2021-04-30 Thread Andrew Wong (Code Review)
Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17367 ) Change subject: [client] return TimedOut if the deadline has passed in master RPCs .. [client] return TimedOut if the deadline

[kudu-CR] [client] return TimedOut if the deadline has passed in master RPCs

2021-04-30 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17367 ) Change subject: [client] return TimedOut if the deadline has passed in master RPCs .. Patch Set 2: Verified+1 Test failures were

[kudu-CR] [client] return TimedOut if the deadline has passed in master RPCs

2021-04-30 Thread Andrew Wong (Code Review)
Andrew Wong has removed a vote on this change. Change subject: [client] return TimedOut if the deadline has passed in master RPCs .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit

[kudu-CR] [tests] enable using txns in TestWorkload

2021-04-30 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17326 ) Change subject: [tests] enable using txns in TestWorkload .. Patch Set 5: (1 comment)

[kudu-CR] [tests] enable using txns in TestWorkload

2021-04-30 Thread Andrew Wong (Code Review)
Hello Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17326 to look at the new patch set (#5). Change subject: [tests] enable using txns in TestWorkload ..

[kudu-CR] [txns][tools] add a state filter to `txns list` tool

2021-04-30 Thread Andrew Wong (Code Review)
Andrew Wong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17371 Change subject: [txns][tools] add a state filter to `txns list` tool .. [txns][tools] add a state filter to `txns list` tool This patch

[kudu-CR] [txns][tools] tool to list transactions

2021-04-30 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17370 to look at the new patch set (#2). Change subject: [txns][tools] tool to list transactions .. [txns][tools] tool

[kudu-CR] KUDU-3223: Quota management for table write

2021-04-29 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17273 ) Change subject: KUDU-3223: Quota management for table write .. Patch Set 32: Verified+1 The test failures were unrelated, and it seems

[kudu-CR] KUDU-3223: Quota management for table write

2021-04-29 Thread Andrew Wong (Code Review)
Andrew Wong has removed a vote on this change. Change subject: KUDU-3223: Quota management for table write .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/17273 To unsubscribe,

[kudu-CR] [txns][tools] tool to list transactions

2021-04-29 Thread Andrew Wong (Code Review)
Andrew Wong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17370 Change subject: [txns][tools] tool to list transactions .. [txns][tools] tool to list transactions This patch adds a tool to iterate

[kudu-CR] [tests] enable using txns in TestWorkload

2021-04-29 Thread Andrew Wong (Code Review)
Hello Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17326 to look at the new patch set (#4). Change subject: [tests] enable using txns in TestWorkload ..

[kudu-CR] [doc] KUDU-2181 Remove master doc changes

2021-04-29 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17359 ) Change subject: [doc] KUDU-2181 Remove master doc changes .. Patch Set 2: (3 comments)

[kudu-CR] [client] return TimedOut if the deadline has passed in master RPCs

2021-04-29 Thread Andrew Wong (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Bankim Bhavsar, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17367 to look at the new patch set (#2). Change subject: [client] return TimedOut if the deadline has passed in master RPCs

[kudu-CR] [doc] KUDU-2181 Update Migrating to Multiple Masters documentation

2021-04-29 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17352 ) Change subject: [doc] KUDU-2181 Update Migrating to Multiple Masters documentation .. Patch Set 4: Code-Review+1 (3 comments)

[kudu-CR] [client] return TimedOut if the deadline has passed in master RPCs

2021-04-29 Thread Andrew Wong (Code Review)
Hello Alexey Serbin, Bankim Bhavsar, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/17367 to review the following change. Change subject: [client] return TimedOut if the deadline has passed in master RPCs

[kudu-CR] [doc] KUDU-2181 Recover dead master doc updates

2021-04-29 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17360 ) Change subject: [doc] KUDU-2181 Recover dead master doc updates .. Patch Set 2: (4 comments) Looking through the staged version, while

[kudu-CR] KUDU-2612: re-open TxnSystemTable if transaction is in new range

2021-04-29 Thread Andrew Wong (Code Review)
Andrew Wong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17368 Change subject: KUDU-2612: re-open TxnSystemTable if transaction is in new range .. KUDU-2612: re-open TxnSystemTable if transaction is

[kudu-CR] [tests] enable using txns in TestWorkload

2021-04-29 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17326 ) Change subject: [tests] enable using txns in TestWorkload .. Patch Set 3: Verified+1 Test failure is not due to this patch: -

[kudu-CR] [tests] enable using txns in TestWorkload

2021-04-29 Thread Andrew Wong (Code Review)
Andrew Wong has removed a vote on this change. Change subject: [tests] enable using txns in TestWorkload .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/17326 To unsubscribe, visit

[kudu-CR] KUDU-2612: fix race when adopting partition lock

2021-04-29 Thread Andrew Wong (Code Review)
Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17361 ) Change subject: KUDU-2612: fix race when adopting partition lock .. KUDU-2612: fix race when adopting partition lock The way we

[kudu-CR] KUDU-2612: fix race when adopting partition lock

2021-04-29 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17361 ) Change subject: KUDU-2612: fix race when adopting partition lock .. Patch Set 2: Verified+1 The test failures, while related to

[kudu-CR] KUDU-2612: fix race when adopting partition lock

2021-04-29 Thread Andrew Wong (Code Review)
Andrew Wong has removed a vote on this change. Change subject: KUDU-2612: fix race when adopting partition lock .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/17361 To unsubscribe,

[kudu-CR] KUDU-3223: Quota management for table write

2021-04-29 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17273 ) Change subject: KUDU-3223: Quota management for table write .. Patch Set 28: (2 comments)

[kudu-CR] [tests] enable using txns in TestWorkload

2021-04-28 Thread Andrew Wong (Code Review)
Hello Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17326 to look at the new patch set (#3). Change subject: [tests] enable using txns in TestWorkload ..

[kudu-CR] KUDU-2612: fix race when adopting partition lock

2021-04-28 Thread Andrew Wong (Code Review)
Hello Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17361 to look at the new patch set (#2). Change subject: KUDU-2612: fix race when adopting partition lock

[kudu-CR] [tests] enable using txns in TestWorkload

2021-04-28 Thread Andrew Wong (Code Review)
Hello Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17326 to look at the new patch set (#2). Change subject: [tests] enable using txns in TestWorkload ..

[kudu-CR] [tests] enable using txns in TestWorkload

2021-04-28 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17326 ) Change subject: [tests] enable using txns in TestWorkload .. Patch Set 1: (5 comments)

[kudu-CR] KUDU-2612: fix race when adopting partition lock

2021-04-28 Thread Andrew Wong (Code Review)
Andrew Wong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17361 Change subject: KUDU-2612: fix race when adopting partition lock .. KUDU-2612: fix race when adopting partition lock The way we were

[kudu-CR] KUDU-3223: Quota management for table write

2021-04-28 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17273 ) Change subject: KUDU-3223: Quota management for table write .. Patch Set 26: (10 comments) Sorry for the delay on review! Looking

[kudu-CR] KUDU-2612: propagate commit timestamp (Java client)

2021-04-28 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17356 ) Change subject: KUDU-2612: propagate commit timestamp (Java client) .. Patch Set 2: Code-Review+2 (1 comment)

[kudu-CR] KUDU-2612: retry abort task on timeout

2021-04-28 Thread Andrew Wong (Code Review)
Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17357 ) Change subject: KUDU-2612: retry abort task on timeout .. KUDU-2612: retry abort task on timeout It's possible that in the

[kudu-CR] KUDU-2612: retry abort task on timeout

2021-04-28 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17357 ) Change subject: KUDU-2612: retry abort task on timeout .. Patch Set 2: (1 comment)

[kudu-CR] KUDU-2612: retry abort task on timeout

2021-04-28 Thread Andrew Wong (Code Review)
Hello Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17357 to look at the new patch set (#2). Change subject: KUDU-2612: retry abort task on timeout ..

[kudu-CR] KUDU-2612: propagate commit timestamp (Java client)

2021-04-28 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17356 ) Change subject: KUDU-2612: propagate commit timestamp (Java client) .. Patch Set 1: Code-Review+1 (1 comment)

[kudu-CR] KUDU-2612: retry abort task on timeout

2021-04-28 Thread Andrew Wong (Code Review)
Hello Alexey Serbin, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/17357 to review the following change. Change subject: KUDU-2612: retry abort task on timeout .. KUDU-2612: retry abort

[kudu-CR] KUDU-2612: address TODOs in TestKuduTransaction

2021-04-28 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17355 ) Change subject: KUDU-2612: address TODOs in TestKuduTransaction .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] [client] retry master RPCs on network errors

2021-04-27 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17343 ) Change subject: [client] retry master RPCs on network errors .. Patch Set 6: (1 comment) Oops clicked submit instead of send.

[kudu-CR] [client] retry master RPCs on network errors

2021-04-27 Thread Andrew Wong (Code Review)
Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17343 ) Change subject: [client] retry master RPCs on network errors .. [client] retry master RPCs on network errors

[kudu-CR] [client] retry master RPCs on network errors

2021-04-27 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17343 ) Change subject: [client] retry master RPCs on network errors .. Patch Set 5: Verified+1 Test failures were the known flake of

[kudu-CR] [client] retry master RPCs on network errors

2021-04-27 Thread Andrew Wong (Code Review)
Andrew Wong has removed a vote on this change. Change subject: [client] retry master RPCs on network errors .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/17343 To unsubscribe,

[kudu-CR] [client] retry master RPCs on network errors

2021-04-27 Thread Andrew Wong (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Bankim Bhavsar, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17343 to look at the new patch set (#4). Change subject: [client] retry master RPCs on network errors

[kudu-CR] [client] retry master RPCs on network errors

2021-04-27 Thread Andrew Wong (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Bankim Bhavsar, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17343 to look at the new patch set (#5). Change subject: [client] retry master RPCs on network errors

[kudu-CR] [client] retry master RPCs on network errors

2021-04-27 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17343 ) Change subject: [client] retry master RPCs on network errors .. Patch Set 5: > Patch Set 3: Verified+1 > > (3 comments) > > Overall

[kudu-CR] [client] retry master RPCs on network errors

2021-04-27 Thread Andrew Wong (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Bankim Bhavsar, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17343 to look at the new patch set (#3). Change subject: [client] retry master RPCs on network errors

[kudu-CR] [client] retry master RPCs on network errors

2021-04-27 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17343 ) Change subject: [client] retry master RPCs on network errors .. Patch Set 2: (6 comments)

[kudu-CR] [client] retry master RPCs on network errors

2021-04-27 Thread Andrew Wong (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Bankim Bhavsar, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17343 to look at the new patch set (#2). Change subject: [client] retry master RPCs on network errors

[kudu-CR] KUDU-2612: propagate commit timestamp (C++ client)

2021-04-27 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17345 ) Change subject: KUDU-2612: propagate commit timestamp (C++ client) .. Patch Set 2: Code-Review+2 -- To view, visit

[kudu-CR] KUDU-2612: propagate commit timestamp (C++ client)

2021-04-27 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17345 ) Change subject: KUDU-2612: propagate commit timestamp (C++ client) .. Patch Set 1: Code-Review+2 (2 comments) Thanks for making this

[kudu-CR] [client] retry master RPCs on network errors

2021-04-26 Thread Andrew Wong (Code Review)
Andrew Wong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17343 Change subject: [client] retry master RPCs on network errors .. [client] retry master RPCs on network errors AsyncLeaderMasterRpc and

[kudu-CR] KUDU-2612: more info on abandoned transaction tracking

2021-04-26 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17341 ) Change subject: KUDU-2612: more info on abandoned transaction tracking .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] KUDU-2612: rollback txn on TXN LOCKED ABORT

2021-04-23 Thread Andrew Wong (Code Review)
Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17263 ) Change subject: KUDU-2612: rollback txn on TXN_LOCKED_ABORT .. KUDU-2612: rollback txn on TXN_LOCKED_ABORT Previously it was

[kudu-CR] [master] Clarify comment in SysCatalogTable::WaitUntilRunning().

2021-04-23 Thread Andrew Wong (Code Review)
Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17337 ) Change subject: [master] Clarify comment in SysCatalogTable::WaitUntilRunning(). .. [master] Clarify comment in

[kudu-CR] [master] Clarify comment in SysCatalogTable::WaitUntilRunning().

2021-04-23 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17337 ) Change subject: [master] Clarify comment in SysCatalogTable::WaitUntilRunning(). .. Patch Set 1: Verified+1 -- To view, visit

[kudu-CR] [master] Clarify comment in SysCatalogTable::WaitUntilRunning().

2021-04-23 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17337 ) Change subject: [master] Clarify comment in SysCatalogTable::WaitUntilRunning(). .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] [master] Clarify comment in SysCatalogTable::WaitUntilRunning().

2021-04-23 Thread Andrew Wong (Code Review)
Andrew Wong has removed a vote on this change. Change subject: [master] Clarify comment in SysCatalogTable::WaitUntilRunning(). .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/17337

[kudu-CR] [client] fix typos on metacache lookup timing

2021-04-23 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17336 ) Change subject: [client] fix typos on metacache lookup timing .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] [script][test] Supply --master addresses for single master config

2021-04-23 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17335 ) Change subject: [script][test] Supply --master_addresses for single master config .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] KUDU-2612: rollback txn on TXN LOCKED ABORT

2021-04-23 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17263 ) Change subject: KUDU-2612: rollback txn on TXN_LOCKED_ABORT .. Patch Set 7: Verified+1 Unrelated flake of

[kudu-CR] KUDU-2612: rollback txn on TXN LOCKED ABORT

2021-04-23 Thread Andrew Wong (Code Review)
Andrew Wong has removed a vote on this change. Change subject: KUDU-2612: rollback txn on TXN_LOCKED_ABORT .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/17263 To unsubscribe,

[kudu-CR] KUDU-2612: rollback txn on TXN LOCKED ABORT

2021-04-23 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17263 ) Change subject: KUDU-2612: rollback txn on TXN_LOCKED_ABORT .. Patch Set 7: (4 comments)

[kudu-CR] KUDU-2612: rollback txn on TXN LOCKED ABORT

2021-04-23 Thread Andrew Wong (Code Review)
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17263 to look at the new patch set (#7). Change subject: KUDU-2612: rollback txn on TXN_LOCKED_ABORT

[kudu-CR] [tools] fix build on macOS

2021-04-23 Thread Andrew Wong (Code Review)
Andrew Wong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17334 Change subject: [tools] fix build on macOS .. [tools] fix build on macOS This patch fixes a build error seen on macOS: FAILED:

[kudu-CR] [security] set minimum TLS protocol version to TSLv1.2

2021-04-23 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17268 ) Change subject: [security] set minimum TLS protocol version to TSLv1.2 .. Patch Set 3: (1 comment)

[kudu-CR] [security] set minimum TLS protocol version to TSLv1.2

2021-04-23 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17268 ) Change subject: [security] set minimum TLS protocol version to TSLv1.2 .. Patch Set 3: (1 comment)

[kudu-CR] [security] set minimum TLS protocol version to TSLv1.2

2021-04-22 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17268 ) Change subject: [security] set minimum TLS protocol version to TSLv1.2 .. Patch Set 3: Code-Review+1 -- To view, visit

[kudu-CR] [security] set minimum TLS protocol version to TSLv1.2

2021-04-22 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17268 ) Change subject: [security] set minimum TLS protocol version to TSLv1.2 .. Patch Set 3: (2 comments)

[kudu-CR] [master][tool] KUDU-2181 Tool to orchestrate adding a master

2021-04-20 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17267 ) Change subject: [master][tool] KUDU-2181 Tool to orchestrate adding a master .. Patch Set 5: Code-Review+2 -- To view, visit

[kudu-CR] [master][tool] KUDU-2181 Tool to orchestrate adding a master

2021-04-19 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17267 ) Change subject: [master][tool] KUDU-2181 Tool to orchestrate adding a master .. Patch Set 4: Code-Review+2 (3 comments)

[kudu-CR] KUDU-3223: Quota management for table write

2021-04-19 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17273 ) Change subject: KUDU-3223: Quota management for table write .. Patch Set 21: (18 comments)

[kudu-CR] [tests] enable using txns in TestWorkload

2021-04-19 Thread Andrew Wong (Code Review)
Andrew Wong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17326 Change subject: [tests] enable using txns in TestWorkload .. [tests] enable using txns in TestWorkload I have an upcoming test in which

[kudu-CR] KUDU-2612: rollback txn on TXN LOCKED ABORT

2021-04-19 Thread Andrew Wong (Code Review)
Andrew Wong has removed a vote on this change. Change subject: KUDU-2612: rollback txn on TXN_LOCKED_ABORT .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/17263 To unsubscribe,

[kudu-CR] KUDU-2612: rollback txn on TXN LOCKED ABORT

2021-04-19 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17263 ) Change subject: KUDU-2612: rollback txn on TXN_LOCKED_ABORT .. Patch Set 6: Verified+1 Test failures are unrelated:

[kudu-CR] KUDU-2612: rollback txn on TXN LOCKED ABORT

2021-04-19 Thread Andrew Wong (Code Review)
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17263 to look at the new patch set (#6). Change subject: KUDU-2612: rollback txn on TXN_LOCKED_ABORT

[kudu-CR] [ksck] KUDU-3258: allow ksck and rebalancer to work on txn status table

2021-04-19 Thread Andrew Wong (Code Review)
Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17315 ) Change subject: [ksck] KUDU-3258: allow ksck and rebalancer to work on txn status table .. [ksck] KUDU-3258: allow ksck and

[kudu-CR] KUDU-2612: rollback txn on TXN LOCKED ABORT

2021-04-19 Thread Andrew Wong (Code Review)
Hello Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17263 to look at the new patch set (#4). Change subject: KUDU-2612: rollback txn on TXN_LOCKED_ABORT ..

[kudu-CR] KUDU-2612: rollback txn on TXN LOCKED ABORT

2021-04-19 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17263 to look at the new patch set (#3). Change subject: KUDU-2612: rollback txn on TXN_LOCKED_ABORT .. KUDU-2612:

[kudu-CR] [ksck] KUDU-3258: allow ksck and rebalancer to work on txn status table

2021-04-19 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17315 ) Change subject: [ksck] KUDU-3258: allow ksck and rebalancer to work on txn status table .. Patch Set 4: Verified+1 Test failure is

[kudu-CR] [ksck] KUDU-3258: allow ksck and rebalancer to work on txn status table

2021-04-19 Thread Andrew Wong (Code Review)
Andrew Wong has removed a vote on this change. Change subject: [ksck] KUDU-3258: allow ksck and rebalancer to work on txn status table .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit

[kudu-CR] [ksck] KUDU-3258: allow ksck and rebalancer to work on txn status table

2021-04-18 Thread Andrew Wong (Code Review)
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17315 to look at the new patch set (#4). Change subject: [ksck] KUDU-3258: allow ksck and rebalancer to work on txn status table

[kudu-CR] [ksck] KUDU-3258: allow ksck and rebalancer to work on txn status table

2021-04-18 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17315 ) Change subject: [ksck] KUDU-3258: allow ksck and rebalancer to work on txn status table .. Patch Set 3: (3 comments)

[kudu-CR] [ksck] KUDU-3258: allow ksck and rebalancer to work on txn status table

2021-04-18 Thread Andrew Wong (Code Review)
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17315 to look at the new patch set (#3). Change subject: [ksck] KUDU-3258: allow ksck and rebalancer to work on txn status table

[kudu-CR] KUDU-2612: an extra test for txn keepalive failover in Java client

2021-04-14 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17321 ) Change subject: KUDU-2612: an extra test for txn keepalive failover in Java client .. Patch Set 3: Code-Review+2 -- To view, visit

[kudu-CR] KUDU-2612: an extra test for txn keepalive failover in Java client

2021-04-14 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17321 ) Change subject: KUDU-2612: an extra test for txn keepalive failover in Java client .. Patch Set 2: Code-Review+2 (1 comment) Thanks

[kudu-CR] [ksck] KUDU-3258: allow ksck and rebalancer to work on txn status table

2021-04-14 Thread Andrew Wong (Code Review)
Hello Tidy Bot, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17315 to look at the new patch set (#2). Change subject: [ksck] KUDU-3258: allow ksck and rebalancer to work on txn status table

[kudu-CR] [kudu-test-utils] enhance signature of KuduTestHarness methods

2021-04-14 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17320 ) Change subject: [kudu-test-utils] enhance signature of KuduTestHarness methods .. Patch Set 1: Code-Review+2 Nice addition! -- To

[kudu-CR] [mini-cluster] Refactor to expose flags of ExternalMaster

2021-04-14 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17266 ) Change subject: [mini-cluster] Refactor to expose flags of ExternalMaster .. Patch Set 4: Code-Review+2 -- To view, visit

[kudu-CR] [thirdparty] enable building curl with alternative OpenSSL

2021-04-14 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17318 ) Change subject: [thirdparty] enable building curl with alternative OpenSSL .. Patch Set 1: Code-Review+2 (1 comment)

<    4   5   6   7   8   9   10   11   12   13   >