[kudu-CR] Create ConsensusMetadataService

2017-06-22 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Create ConsensusMetadataService .. Patch Set 2: (17 comments)

[kudu-CR] ConsensusMetadata::Create() should not overwrite an existing file

2017-06-22 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: ConsensusMetadata::Create() should not overwrite an existing file .. Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/7190/1//COMMIT_MSG

[kudu-CR] TabletReplica: Move Init() logic to Start()

2017-06-22 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: TabletReplica: Move Init() logic to Start() .. Patch Set 2: (5 comments) http://gerrit.cloudera.org:8080/#/c/7194/2/src/kudu/tablet/tablet.h File

[kudu-CR] WIP: Ensure ConsensusMetadata exists, even for tombstoned tablets

2017-06-22 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: WIP: Ensure ConsensusMetadata exists, even for tombstoned tablets .. Patch Set 1: (5 comments) just browsed this one since it seems like it needs

[kudu-CR] consensus: Don't mark dirty when clearing the leader UUID

2017-06-22 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: consensus: Don't mark dirty when clearing the leader UUID .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7193 To

[kudu-CR] threadpool: new test for pools with no max threads

2017-06-22 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: threadpool: new test for pools with no max_threads .. Patch Set 12: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6945 To unsubscribe,

[kudu-CR] Make ConsensusMetadata thread-safe

2017-06-22 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Make ConsensusMetadata thread-safe .. Patch Set 3: Code-Review+2 (1 comment) feel free to address the nit or not and re+2

[kudu-CR] consensus: Get rid of RaftConsensus::Create()

2017-06-22 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: consensus: Get rid of RaftConsensus::Create() .. Patch Set 2: (5 comments) http://gerrit.cloudera.org:8080/#/c/7192/2//COMMIT_MSG Commit Message: PS2,

[kudu-CR] threadpool: token-based task sequencing

2017-06-22 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: threadpool: token-based task sequencing .. Patch Set 12: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6874 To unsubscribe, visit

[kudu-CR] threadpool: token-based task sequencing

2017-06-22 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: threadpool: token-based task sequencing .. Patch Set 12: leaving it open in case todd wants to take another look -- To view, visit

[kudu-CR] server: consolidate tablet prepare pools

2017-06-22 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: server: consolidate tablet prepare pools .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/7150/4/src/kudu/kserver/kserver.cc File

[kudu-CR] consensus: consolidate Raft thread pools

2017-06-22 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: consensus: consolidate Raft thread pools .. Patch Set 13: (3 comments) http://gerrit.cloudera.org:8080/#/c/6946/13/src/kudu/consensus/raft_consensus.cc

[kudu-CR] Simplify OpId/Timestamp assignment

2017-06-22 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7221 to look at the new patch set (#3). Change subject: Simplify OpId/Timestamp assignment .. Simplify OpId/Timestamp

[kudu-CR] [java] Replace interface-annotations with Apache Yetus annotations

2017-06-22 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: [java] Replace interface-annotations with Apache Yetus annotations .. Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/7235/7//COMMIT_MSG Commit

Re: [kudu-CR] Fix too-strict CHECK in RleIntBlockDecoder::SeekToPositionInBlock

2017-06-22 Thread William Berkeley
Sure. Please see KUDU-2049 . -Will On Thu, Jun 22, 2017 at 10:23 AM, Todd Lipcon wrote: > Mind filling a Jira for this since it seems like the kind of bug we will > want to backport? > > On Jun 22, 2017 9:45 AM, "Will

[kudu-CR] WIP: Fix SIGSEGV in ksck

2017-06-22 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has uploaded a new change for review. http://gerrit.cloudera.org:8080/7261 Change subject: WIP: Fix SIGSEGV in ksck .. WIP: Fix SIGSEGV in ksck We were hitting the a segfault when trying to run ksck on a

[kudu-CR] tools: refactor table-printing code a bit

2017-06-22 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: tools: refactor table-printing code a bit .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/7259/1/src/kudu/tools/ksck.cc File

[kudu-CR] Simplify OpId/Timestamp assignment

2017-06-22 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7221 to look at the new patch set (#4). Change subject: Simplify OpId/Timestamp assignment .. Simplify OpId/Timestamp

[kudu-CR] [java] Replace interface-annotations with Apache Yetus annotations

2017-06-22 Thread Will Berkeley (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7235 to look at the new patch set (#7). Change subject: [java] Replace interface-annotations with Apache Yetus annotations

[kudu-CR] tools: refactor table-printing code a bit

2017-06-22 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: tools: refactor table-printing code a bit .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7259 To unsubscribe, visit

[kudu-CR] [java] Replace interface-annotations with Apache Yetus annotations

2017-06-22 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: [java] Replace interface-annotations with Apache Yetus annotations .. Patch Set 6: (4 comments) http://gerrit.cloudera.org:8080/#/c/7235/6//COMMIT_MSG Commit

[kudu-CR] [java] Replace interface-annotations with Apache Yetus annotations

2017-06-22 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: [java] Replace interface-annotations with Apache Yetus annotations .. Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/7235/7//COMMIT_MSG Commit

[kudu-CR] ConsensusMetadata::Create() should not overwrite an existing file

2017-06-22 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: ConsensusMetadata::Create() should not overwrite an existing file .. Patch Set 1: (1 comment)

[kudu-CR] KUDU-2049 Fix too-strict CHECK in RleIntBlockDecoder::SeekToPositionInBlock

2017-06-22 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. Change subject: KUDU-2049 Fix too-strict CHECK in RleIntBlockDecoder::SeekToPositionInBlock .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/7262

[kudu-CR] [java] Replace interface-annotations with Apache Yetus annotations

2017-06-22 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: [java] Replace interface-annotations with Apache Yetus annotations .. Patch Set 8: (1 comment) > I don't see Impala depending on interface-annotations, but I

[kudu-CR] tools: add a tool to extract an arbitrary block to stdout

2017-06-22 Thread Todd Lipcon (Code Review)
Hello Adar Dembo, Will Berkeley, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/7260 to review the following change. Change subject: tools: add a tool to extract an arbitrary block to stdout

[kudu-CR] tools: refactor table-printing code a bit

2017-06-22 Thread Todd Lipcon (Code Review)
Hello Adar Dembo, Will Berkeley, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/7259 to review the following change. Change subject: tools: refactor table-printing code a bit .. tools:

[kudu-CR] tools: add a tool to extract an arbitrary block to stdout

2017-06-22 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: tools: add a tool to extract an arbitrary block to stdout .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7260 To unsubscribe,

[kudu-CR] tools: add a tool to extract an arbitrary block to stdout

2017-06-22 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: tools: add a tool to extract an arbitrary block to stdout .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/7260/1/src/kudu/tools/tool_action_fs.cc

[kudu-CR] [java] Replace interface-annotations with Apache Yetus annotations

2017-06-22 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: [java] Replace interface-annotations with Apache Yetus annotations .. Patch Set 9: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7235 To

[kudu-CR] ConsensusMetadata::Create() should not overwrite an existing file

2017-06-22 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: ConsensusMetadata::Create() should not overwrite an existing file .. Patch Set 1: (1 comment)

[kudu-CR] WIP: Add gradle build

2017-06-22 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: WIP: Add gradle build .. Patch Set 1: (10 comments) http://gerrit.cloudera.org:8080/#/c/7258/1//COMMIT_MSG Commit Message: Line 22: - Reporting available

[kudu-CR] WIP: Fix SIGSEGV in ksck

2017-06-22 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7261 to look at the new patch set (#3). Change subject: WIP: Fix SIGSEGV in ksck .. WIP: Fix SIGSEGV in ksck We were

[kudu-CR] [java] Replace interface-annotations with Apache Yetus annotations

2017-06-22 Thread Will Berkeley (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7235 to look at the new patch set (#8). Change subject: [java] Replace interface-annotations with Apache Yetus annotations

[kudu-CR] KUDU-2049 Fix too-strict CHECK in RleIntBlockDecoder::SeekToPositionInBlock

2017-06-22 Thread Will Berkeley (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7262 to look at the new patch set (#2). Change subject: KUDU-2049 Fix too-strict CHECK in RleIntBlockDecoder::SeekToPositionInBlock

[kudu-CR] [java] Replace interface-annotations with Apache Yetus annotations

2017-06-22 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: [java] Replace interface-annotations with Apache Yetus annotations .. Patch Set 7: > No worries. Speaking of people with interface annotations in their poms, we

[kudu-CR] [java] Replace interface-annotations with Apache Yetus annotations

2017-06-22 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: [java] Replace interface-annotations with Apache Yetus annotations .. Patch Set 9: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/7235 To

[kudu-CR] tools: add a tool to extract an arbitrary block to stdout

2017-06-22 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: tools: add a tool to extract an arbitrary block to stdout .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/7260/1/src/kudu/tools/kudu-tool-test.cc

[kudu-CR] [client-test] fixing flakes in the test

2017-06-22 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded a new change for review. http://gerrit.cloudera.org:8080/7263 Change subject: [client-test] fixing flakes in the test .. [client-test] fixing flakes in the test Extended timeout for table creation

[kudu-CR] KUDU-2049 Fix too-strict CHECK in RleIntBlockDecoder::SeekToPositionInBlock

2017-06-22 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. Change subject: KUDU-2049 Fix too-strict CHECK in RleIntBlockDecoder::SeekToPositionInBlock .. Patch Set 2: Code-Review+1 (1 comment)

[kudu-CR] [java] Replace interface-annotations with Apache Yetus annotations

2017-06-22 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: [java] Replace interface-annotations with Apache Yetus annotations .. Patch Set 8: the should have been 'point it to the new version of kudu-client' -- To

[kudu-CR] [java] Replace interface-annotations with Apache Yetus annotations

2017-06-22 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: [java] Replace interface-annotations with Apache Yetus annotations .. Patch Set 8: > The reason I said that is that the interface-annotations jar ends up

[kudu-CR] [java] Replace interface-annotations with Apache Yetus annotations

2017-06-22 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: [java] Replace interface-annotations with Apache Yetus annotations .. Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/7235/7//COMMIT_MSG Commit

[kudu-CR] [mini {master,tablet server}] micro clean-up

2017-06-22 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded a new change for review. http://gerrit.cloudera.org:8080/7265 Change subject: [mini_{master,tablet_server}] micro clean-up .. [mini_{master,tablet_server}] micro clean-up A micro clean-up on

[kudu-CR] disk failure: test coverage for disk failure recovery

2017-06-22 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7031 to look at the new patch set (#6). Change subject: disk failure: test coverage for disk failure recovery .. disk

[kudu-CR] [mini {master,tablet server}] micro clean-up

2017-06-22 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [mini_{master,tablet_server}] micro clean-up .. Patch Set 1: (5 comments) http://gerrit.cloudera.org:8080/#/c/7265/1/src/kudu/master/mini_master.cc File

[kudu-CR] [mini {master,tablet server}] micro clean-up

2017-06-22 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded a new patch set (#2). Change subject: [mini_{master,tablet_server}] micro clean-up .. [mini_{master,tablet_server}] micro clean-up A micro clean-up on mini_master and mini_tablet_server: * remove

[kudu-CR] Fix SIGSEGV in ksck

2017-06-22 Thread Will Berkeley (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7261 to look at the new patch set (#4). Change subject: Fix SIGSEGV in ksck .. Fix SIGSEGV in ksck ksck will segfault

[kudu-CR] [mini {master,tablet server}] micro clean-up

2017-06-22 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. Change subject: [mini_{master,tablet_server}] micro clean-up .. [mini_{master,tablet_server}] micro clean-up A micro clean-up on mini_master and mini_tablet_server:

[kudu-CR] tools: add a tool to summarize data size on a tablet or tablets

2017-06-22 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: tools: add a tool to summarize data size on a tablet or tablets .. Patch Set 2: (11 comments)

[kudu-CR] [java] Replace interface-annotations with Apache Yetus annotations

2017-06-22 Thread Will Berkeley (Code Review)
Will Berkeley has submitted this change and it was merged. Change subject: [java] Replace interface-annotations with Apache Yetus annotations .. [java] Replace interface-annotations with Apache Yetus annotations Apache Yetus,

[kudu-CR] tools: add a tool to summarize data size on a tablet or tablets

2017-06-22 Thread Todd Lipcon (Code Review)
Hello Adar Dembo, Will Berkeley, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5727 to look at the new patch set (#2). Change subject: tools: add a tool to summarize data size on a tablet or tablets

[kudu-CR] Fix too-strict CHECK in RleIntBlockDecoder::SeekToPositionInBlock

2017-06-22 Thread Will Berkeley (Code Review)
Will Berkeley has uploaded a new change for review. http://gerrit.cloudera.org:8080/7262 Change subject: Fix too-strict CHECK in RleIntBlockDecoder::SeekToPositionInBlock .. Fix too-strict CHECK in

[kudu-CR] WIP: Fix SIGSEGV in ksck

2017-06-22 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has uploaded a new patch set (#2). Change subject: WIP: Fix SIGSEGV in ksck .. WIP: Fix SIGSEGV in ksck We were hitting the a segfault when trying to run ksck on a cluster where some tablet servers are

[kudu-CR] [java] Replace interface-annotations with Apache Yetus annotations

2017-06-22 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: [java] Replace interface-annotations with Apache Yetus annotations .. Patch Set 7: (1 comment) It looks like most of the imports have been resorted, except in

[kudu-CR] [java] Replace interface-annotations with Apache Yetus annotations

2017-06-22 Thread Will Berkeley (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7235 to look at the new patch set (#9). Change subject: [java] Replace interface-annotations with Apache Yetus annotations

[kudu-CR] Simplify OpId/Timestamp assignment

2017-06-22 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7221 to look at the new patch set (#5). Change subject: Simplify OpId/Timestamp assignment .. Simplify OpId/Timestamp

[kudu-CR] disk failure: coordinate error handling

2017-06-22 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7029 to look at the new patch set (#14). Change subject: disk failure: coordinate error handling .. disk failure:

[kudu-CR] WIP disk failure: coordinate disk failure handling

2017-06-22 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7030 to look at the new patch set (#8). Change subject: WIP disk failure: coordinate disk failure handling .. WIP disk

[kudu-CR] Simplify OpId/Timestamp assignment and make it atomic

2017-06-22 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7221 to look at the new patch set (#6). Change subject: Simplify OpId/Timestamp assignment and make it atomic ..

[kudu-CR] [mini {master,tablet server}] webserver binding change

2017-06-22 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded a new patch set (#2). Change subject: [mini_{master,tablet_server}] webserver binding change .. [mini_{master,tablet_server}] webserver binding change This small patch introduces the following changes

[kudu-CR] [mini {master,tablet server}] webserver binding change

2017-06-22 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: [mini_{master,tablet_server}] webserver binding change .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/7266/2//COMMIT_MSG Commit Message: PS2,

[kudu-CR] [mini {master,tablet server}] webserver binding change

2017-06-22 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [mini_{master,tablet_server}] webserver binding change .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/7266/2//COMMIT_MSG Commit Message: PS2,

[kudu-CR] [client-test] fixing flakes in the test

2017-06-22 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: [client-test] fixing flakes in the test .. Patch Set 1: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/7263/1/src/kudu/client/client-test.cc File

[kudu-CR] [mini {master,tablet server}] micro clean-up

2017-06-22 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [mini_{master,tablet_server}] micro clean-up .. Patch Set 1: Verified+1 Unrelated flake in MultiThreadedHybridClockTabletTest/5.UpdateNoMergeCompaction -- To

[kudu-CR] [client-test] fixing flakes in the test

2017-06-22 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [client-test] fixing flakes in the test .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/7263/1/src/kudu/client/client-test.cc File

[kudu-CR] [client-test] fixing flakes in the test

2017-06-22 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. Change subject: [client-test] fixing flakes in the test .. [client-test] fixing flakes in the test Extended timeout for table creation up to 60 seconds in couple of

[kudu-CR] [mini {master,tablet server}] webserver binding change

2017-06-22 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded a new change for review. http://gerrit.cloudera.org:8080/7266 Change subject: [mini_{master,tablet_server}] webserver binding change .. [mini_{master,tablet_server}] webserver binding change This

[kudu-CR] WIP: Fix SIGSEGV in ksck

2017-06-22 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: WIP: Fix SIGSEGV in ksck .. Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/7261/3//COMMIT_MSG Commit Message: PS3, Line 9: the nit: drop

[kudu-CR] Fix SIGSEGV in ksck

2017-06-22 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: Fix SIGSEGV in ksck .. Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/7261/3//COMMIT_MSG Commit Message: PS3, Line 9: the > nit: drop Done.

[kudu-CR] [mini {master,tablet server}] micro clean-up

2017-06-22 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: [mini_{master,tablet_server}] micro clean-up .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7265 To unsubscribe, visit

[kudu-CR] KUDU-2052: use XFS IOC UNRESVSP64 ioctl to punch holes on xfs

2017-06-22 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-2052: use XFS_IOC_UNRESVSP64 ioctl to punch holes on xfs .. Patch Set 2: (2 comments) Patch seems fine but I have a licensing worry that may be a blocker

[kudu-CR] Use dynamic bind address for internal + external mini clusters

2017-06-22 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: Use dynamic bind address for internal + external mini clusters .. Patch Set 1: (10 comments)

[kudu-CR] WIP: Add gradle build

2017-06-22 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. Change subject: WIP: Add gradle build .. Patch Set 2: (9 comments) http://gerrit.cloudera.org:8080/#/c/7258/1//COMMIT_MSG Commit Message: Line 23: - Protobuf and Avro code

[kudu-CR] KUDU-2052: use XFS IOC UNRESVSP64 ioctl to punch holes on xfs

2017-06-22 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: KUDU-2052: use XFS_IOC_UNRESVSP64 ioctl to punch holes on xfs .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/7269/2/src/kudu/util/env_posix.cc

[kudu-CR] Rename MiniCluster to InternalMiniCluster

2017-06-22 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: Rename MiniCluster to InternalMiniCluster .. Patch Set 1: (3 comments) just some nits, overall looks good

[kudu-CR] Rename MiniClusterBase to MiniCluster

2017-06-22 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: Rename MiniClusterBase to MiniCluster .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7273 To unsubscribe, visit

[kudu-CR] [consensus] 'runtime' tag for consensus log FI flags

2017-06-22 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [consensus] 'runtime' tag for consensus log FI flags .. Patch Set 1: Unrelated flake in RaftConsensusITest.TestHammerOneRow -- To view, visit

[kudu-CR] WIP: Add gradle build

2017-06-22 Thread Grant Henke (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7258 to look at the new patch set (#2). Change subject: WIP: Add gradle build .. WIP: Add gradle build Adds an

[kudu-CR] block manager-test: don't inject EIO in destructor

2017-06-22 Thread Andrew Wong (Code Review)
Andrew Wong has uploaded a new patch set (#2). Change subject: block_manager-test: don't inject EIO in destructor .. block_manager-test: don't inject EIO in destructor BlockManagerTest uses FLAGS_env_inject_eio to inject errors

[kudu-CR] KUDU-2052: use XFS IOC UNRESVSP64 ioctl to punch holes on xfs

2017-06-22 Thread Adar Dembo (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7269 to look at the new patch set (#2). Change subject: KUDU-2052: use XFS_IOC_UNRESVSP64 ioctl to punch holes on xfs ..

[kudu-CR] KUDU-1955 refuse to use world-readable keytabs

2017-06-22 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-1955 refuse to use world-readable keytabs .. Patch Set 5: (5 comments)

[kudu-CR] KUDU-1955 refuse to use world-readable keytabs

2017-06-22 Thread Sam Okrent (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7249 to look at the new patch set (#3). Change subject: KUDU-1955 refuse to use world-readable keytabs .. KUDU-1955

[kudu-CR] WIP KUDU-1943: Add BlockTransaction to Block Manager

2017-06-22 Thread Hao Hao (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7207 to look at the new patch set (#5). Change subject: WIP KUDU-1943: Add BlockTransaction to Block Manager .. WIP

[kudu-CR] KUDU-1955 refuse to use world-readable keytabs

2017-06-22 Thread Sam Okrent (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7249 to look at the new patch set (#4). Change subject: KUDU-1955 refuse to use world-readable keytabs .. KUDU-1955

[kudu-CR] block manager-test: don't inject EIO in destructor

2017-06-22 Thread Andrew Wong (Code Review)
Andrew Wong has uploaded a new change for review. http://gerrit.cloudera.org:8080/7271 Change subject: block_manager-test: don't inject EIO in destructor .. block_manager-test: don't inject EIO in destructor BlockManagerTest

[kudu-CR] KUDU-1955 refuse to use world-readable keytabs

2017-06-22 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: KUDU-1955 refuse to use world-readable keytabs .. Patch Set 4: Code looks good. The .test_macros.h.swo needs to be removed. -- To view, visit

[kudu-CR] KUDU-1955 refuse to use world-readable keytabs

2017-06-22 Thread Sam Okrent (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7249 to look at the new patch set (#5). Change subject: KUDU-1955 refuse to use world-readable keytabs .. KUDU-1955

[kudu-CR] block manager-test: don't inject EIO in destructor

2017-06-22 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: block_manager-test: don't inject EIO in destructor .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7271 To unsubscribe, visit

[kudu-CR] KUDU-1955 refuse to use world-readable keytabs

2017-06-22 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: KUDU-1955 refuse to use world-readable keytabs .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7249 To unsubscribe, visit

[kudu-CR] KUDU-1955 refuse to use world-readable keytabs

2017-06-22 Thread Sam Okrent (Code Review)
Sam Okrent has posted comments on this change. Change subject: KUDU-1955 refuse to use world-readable keytabs .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/7249/2/src/kudu/util/env.h File

[kudu-CR] KUDU-1955 refuse to use world-readable keytabs

2017-06-22 Thread Sam Okrent (Code Review)
Sam Okrent has posted comments on this change. Change subject: KUDU-1955 refuse to use world-readable keytabs .. Patch Set 2: (2 comments)

[kudu-CR] Add basic Hive MetaStore client

2017-06-22 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: Add basic Hive MetaStore client .. Patch Set 8: (1 comment) http://gerrit.cloudera.org:8080/#/c/7053/8/thirdparty/build-definitions.sh File

[kudu-CR] KUDU-2052: use XFS IOC UNRESVSP64 ioctl to punch holes on xfs

2017-06-22 Thread Adar Dembo (Code Review)
Hello Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/7269 to review the following change. Change subject: KUDU-2052: use XFS_IOC_UNRESVSP64 ioctl to punch holes on xfs ..

[kudu-CR] WIP persistent disk state

2017-06-22 Thread Andrew Wong (Code Review)
Andrew Wong has uploaded a new change for review. http://gerrit.cloudera.org:8080/7270 Change subject: WIP persistent disk state .. WIP persistent disk state Change-Id: Ifddf0817fe1a82044077f5544c400c88de20769f --- M

[kudu-CR] block manager-test: don't inject EIO in destructor

2017-06-22 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. Change subject: block_manager-test: don't inject EIO in destructor .. Patch Set 3: FLAGS_env_inject_eio is also used in env-test, but shouldn't cause this sort of failure given

[kudu-CR] Rename MiniClusterBase to MiniCluster

2017-06-22 Thread Mike Percy (Code Review)
Hello Todd Lipcon, Alexey Serbin, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/7273 to review the following change. Change subject: Rename MiniClusterBase to MiniCluster .. Rename

[kudu-CR] Use dynamic bind address for internal + external mini clusters

2017-06-22 Thread Mike Percy (Code Review)
Hello Todd Lipcon, Alexey Serbin, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/7274 to review the following change. Change subject: Use dynamic bind address for internal + external mini clusters