[kudu-CR] KUDU-1643 Prune hash partitions based on IN-list predicates

2016-12-01 Thread Haijie Hong (Code Review)
Haijie Hong has posted comments on this change. Change subject: KUDU-1643 Prune hash partitions based on IN-list predicates .. Patch Set 8: (7 comments) > (7 comments)

[kudu-CR] KUDU-798 (part 3) Make replica transactions start/abort on the consensus thread

2016-12-01 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5294 to look at the new patch set (#8). Change subject: KUDU-798 (part 3) Make replica transactions start/abort on the consensus thread

[kudu-CR] KUDU-798 (part 3) Make replica transactions start/abort on the consensus thread

2016-12-01 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5294 to look at the new patch set (#7). Change subject: KUDU-798 (part 3) Make replica transactions start/abort on the consensus thread

[kudu-CR] WIP: KUDU-695. Avoid glog contention by deferring logs to other threads

2016-12-01 Thread Todd Lipcon (Code Review)
Hello David Ribeiro Alves, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5321 to look at the new patch set (#2). Change subject: WIP: KUDU-695. Avoid glog contention by deferring logs to other threads

[kudu-CR] WIP: KUDU-695. Avoid glog contention by deferring logs to other threads

2016-12-01 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: WIP: KUDU-695. Avoid glog contention by deferring logs to other threads .. Patch Set 1: (1 comment)

[kudu-CR] WIP: KUDU-1622. Try to move heavy work out of ResultTracker lock

2016-12-01 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: WIP: KUDU-1622. Try to move heavy work out of ResultTracker lock .. Patch Set 1: I looped the exactly_once_rpc-test and the GC stress test occasionally failed

[kudu-CR] WIP: KUDU-1622. Try to move heavy work out of ResultTracker lock

2016-12-01 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: WIP: KUDU-1622. Try to move heavy work out of ResultTracker lock .. Patch Set 1: which tests does it fail? -- To view, visit

[kudu-CR] WIP: KUDU-1622. Stripe the ResultTracker to lessen contention

2016-12-01 Thread Todd Lipcon (Code Review)
Hello David Ribeiro Alves, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/5322 to review the following change. Change subject: WIP: KUDU-1622. Stripe the ResultTracker to lessen contention

[kudu-CR] WIP: KUDU-1622. Try to move heavy work out of ResultTracker lock

2016-12-01 Thread Todd Lipcon (Code Review)
Hello David Ribeiro Alves, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/5323 to review the following change. Change subject: WIP: KUDU-1622. Try to move heavy work out of ResultTracker lock

[kudu-CR] KUDU-625 - Make write transctions abort in mvcc, by default

2016-12-01 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has uploaded a new patch set (#2). Change subject: KUDU-625 - Make write transctions abort in mvcc, by default .. KUDU-625 - Make write transctions abort in mvcc, by default This patch addresses a long

[kudu-CR] KUDU-625 - Make write transctions abort in mvcc, by default

2016-12-01 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has uploaded a new change for review. http://gerrit.cloudera.org:8080/5320 Change subject: KUDU-625 - Make write transctions abort in mvcc, by default .. KUDU-625 - Make write transctions abort in mvcc, by

[kudu-CR] [flaky tests] Fix "Already present" failures on raft consensus-itest

2016-12-01 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has uploaded a new change for review. http://gerrit.cloudera.org:8080/5319 Change subject: [flaky tests] Fix "Already present" failures on raft_consensus-itest .. [flaky tests] Fix "Already present"

[kudu-CR] block manager: start using the file cache

2016-12-01 Thread Adar Dembo (Code Review)
Hello Dan Burkert, Todd Lipcon, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5147 to look at the new patch set (#5). Change subject: block manager: start using the file cache

[kudu-CR] Revert "env: change various file filename() functions to return copies"

2016-12-01 Thread Adar Dembo (Code Review)
Hello Dan Burkert, Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/5318 to review the following change. Change subject: Revert "env: change various file filename() functions to return copies"

[kudu-CR] util: add file cache

2016-12-01 Thread Adar Dembo (Code Review)
Hello Dan Burkert, Todd Lipcon, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5146 to look at the new patch set (#6). Change subject: util: add file cache .. util: add

[kudu-CR] util: add file cache

2016-12-01 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: util: add file cache .. Patch Set 5: (12 comments) http://gerrit.cloudera.org:8080/#/c/5146/5/src/kudu/util/cache.cc File src/kudu/util/cache.cc: PS5, Line 34:

[kudu-CR] block manager: start using the file cache

2016-12-01 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: block manager: start using the file cache .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/5147/4/src/kudu/fs/log_block_manager.cc File

[kudu-CR] [tools] Tombstone the tablet with "local replica delete"

2016-12-01 Thread Dinesh Bhat (Code Review)
Hello Mike Percy, Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5191 to look at the new patch set (#5). Change subject: [tools] Tombstone the tablet with "local_replica delete"

[kudu-CR] [tools] Tombstone the tablet with "local replica delete"

2016-12-01 Thread Dinesh Bhat (Code Review)
Dinesh Bhat has posted comments on this change. Change subject: [tools] Tombstone the tablet with "local_replica delete" .. Patch Set 4: (2 comments)

[kudu-CR] KUDU-1422 [java client] modifiable error collector capacity

2016-12-01 Thread eric-maynard (Code Review)
eric-maynard has posted comments on this change. Change subject: KUDU-1422 [java client] modifiable error collector capacity .. Patch Set 2: (1 comment)

[kudu-CR] KUDU-1422 [java client] modifiable error collector capacity

2016-12-01 Thread eric-maynard (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5291 to look at the new patch set (#3). Change subject: KUDU-1422 [java client] modifiable error collector capacity ..

[kudu-CR] KUDU-1422 [java client] modifiable error collector capacity

2016-12-01 Thread eric-maynard (Code Review)
eric-maynard has posted comments on this change. Change subject: KUDU-1422 [java client] modifiable error collector capacity .. Patch Set 3: (3 comments)

[kudu-CR] [ts tablet manager] simplified WaitForAllBootstrapsToFinish

2016-12-01 Thread Dinesh Bhat (Code Review)
Dinesh Bhat has posted comments on this change. Change subject: [ts_tablet_manager] simplified WaitForAllBootstrapsToFinish .. Patch Set 1: Code-Review+1 (1 comment)

[kudu-CR] WIP: scanner should not retry a SCANNER EXPIRED error without reopening

2016-12-01 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: WIP: scanner should not retry a SCANNER_EXPIRED error without reopening .. Patch Set 1: Alexey -- this one is also relevant to some stuff you've been looking at

[kudu-CR] WIP: KUDU-1369. client: fail over scans to a new replica if current replica is out-of-date

2016-12-01 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: WIP: KUDU-1369. client: fail over scans to a new replica if current replica is out-of-date .. Patch Set 1: David/Alexey -- just found this old WIP patch of mine

[kudu-CR] KUDU-1752 C++ client error memory should be bounded

2016-12-01 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-1752 C++ client error memory should be bounded .. Patch Set 2: (16 comments) http://gerrit.cloudera.org:8080/#/c/5308/2/src/kudu/client/client-test.cc File

[kudu-CR] KUDU-1752 C++ client error memory should be bounded

2016-12-01 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5308 to look at the new patch set (#2). Change subject: KUDU-1752 C++ client error memory should be bounded ..

[kudu-CR] KUDU-1752 C++ client error memory should be bounded

2016-12-01 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: KUDU-1752 C++ client error memory should be bounded .. Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/5308/1/src/kudu/client/client.h File

[kudu-CR] KUDU-1778. Fix LMP mismatch behavior after a replica restarts

2016-12-01 Thread Todd Lipcon (Code Review)
Hello David Ribeiro Alves, Mike Percy, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5309 to look at the new patch set (#3). Change subject: KUDU-1778. Fix LMP mismatch behavior after a replica restarts

[kudu-CR] KUDU-1422 [java client] modifiable error collector capacity

2016-12-01 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-1422 [java client] modifiable error collector capacity .. Patch Set 2: (3 comments)

[kudu-CR] KUDU-1773: remove overly strict DCHECKs

2016-12-01 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-1773: remove overly strict DCHECKs .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5292 To unsubscribe, visit

[kudu-CR] KUDU-1773: remove overly strict DCHECKs

2016-12-01 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: KUDU-1773: remove overly strict DCHECKs .. KUDU-1773: remove overly strict DCHECKs A tablet's replicas may change over the course of a write. For

[kudu-CR] tool: Allow hyphens to be used instead of underscores

2016-12-01 Thread Mike Percy (Code Review)
Mike Percy has submitted this change and it was merged. Change subject: tool: Allow hyphens to be used instead of underscores .. tool: Allow hyphens to be used instead of underscores This works for both modes and actions.

[kudu-CR] tool: Replace Kudu replica with tablet replica in help text

2016-12-01 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: tool: Replace Kudu replica with tablet replica in help text .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5310 To unsubscribe,

[kudu-CR] tool: Replace Kudu replica with tablet replica in help text

2016-12-01 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. Change subject: tool: Replace Kudu replica with tablet replica in help text .. tool: Replace Kudu replica with tablet replica in help text The help text is clearer when

[kudu-CR] tool: Replace Kudu replica with tablet replica in help text

2016-12-01 Thread Mike Percy (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5310 to look at the new patch set (#2). Change subject: tool: Replace Kudu replica with tablet replica in help text ..

[kudu-CR] tool: Allow hyphens to be used instead of underscores

2016-12-01 Thread Mike Percy (Code Review)
Hello Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5311 to look at the new patch set (#4). Change subject: tool: Allow hyphens to be used instead of underscores

[kudu-CR] tool: Replace Kudu replica with tablet replica in help text

2016-12-01 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: tool: Replace Kudu replica with tablet replica in help text .. Patch Set 1: (2 comments)

[kudu-CR] tool: Allow hyphens to be used instead of underscores

2016-12-01 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: tool: Allow hyphens to be used instead of underscores .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/5311/2/src/kudu/tools/tool_main.cc File

[kudu-CR] tool: Allow hyphens to be used instead of underscores

2016-12-01 Thread Mike Percy (Code Review)
Hello Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5311 to look at the new patch set (#3). Change subject: tool: Allow hyphens to be used instead of underscores

[kudu-CR] KUDU-981 (part 1): validate identifiers as UTF8 with no null bytes

2016-12-01 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-981 (part 1): validate identifiers as UTF8 with no null bytes .. Patch Set 2: Code-Review+2 Carrying +2s -- To view, visit

[kudu-CR] KUDU-981 (part 1): validate identifiers as UTF8 with no null bytes

2016-12-01 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: KUDU-981 (part 1): validate identifiers as UTF8 with no null bytes .. KUDU-981 (part 1): validate identifiers as UTF8 with no null bytes Ensures that

[kudu-CR] Update debug partition and row printing

2016-12-01 Thread Dan Burkert (Code Review)
Dan Burkert has submitted this change and it was merged. Change subject: Update debug partition and row printing .. Update debug partition and row printing This commit updates the debug printing of rows and partitions in

[kudu-CR] Update debug partition and row printing

2016-12-01 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Update debug partition and row printing .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5262 To unsubscribe, visit

[kudu-CR] tool: Replace Kudu replica with tablet replica in help text

2016-12-01 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: tool: Replace Kudu replica with tablet replica in help text .. Patch Set 1: (2 comments)

[kudu-CR] tool: Allow hyphens to be used instead of underscores

2016-12-01 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: tool: Allow hyphens to be used instead of underscores .. Patch Set 2: Code-Review+2 (1 comment)

[kudu-CR] KUDU-1752 C++ client error memory should be bounded

2016-12-01 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: KUDU-1752 C++ client error memory should be bounded .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5308/1/src/kudu/client/client.h File

[kudu-CR] KUDU-921. tablet copy: Make the StartTabletCopy() RPC async

2016-12-01 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: KUDU-921. tablet copy: Make the StartTabletCopy() RPC async .. Patch Set 7: > 1) There's some way to wait for the tablet copy to finish, at least > for tests, even

[kudu-CR] KUDU-921. tablet copy: Make the StartTabletCopy() RPC async

2016-12-01 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-921. tablet copy: Make the StartTabletCopy() RPC async .. Patch Set 7: > > I'm going to take your advice and do this. I think it will also > > solve the test

[kudu-CR] KUDU-921. tablet copy: Make the StartTabletCopy() RPC async

2016-12-01 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: KUDU-921. tablet copy: Make the StartTabletCopy() RPC async .. Patch Set 7: Code-Review-1 I posted this for a test run / sanity check but I need to work on better

[kudu-CR] KUDU-1752 C++ client error memory should be bounded

2016-12-01 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-1752 C++ client error memory should be bounded .. Patch Set 1: (1 comment) > > Separately, it may be interesting to use util/mem_tracker for > > client-side

[kudu-CR] KUDU-921. tablet copy: Make the StartTabletCopy() RPC async

2016-12-01 Thread Mike Percy (Code Review)
Hello Dinesh Bhat, Todd Lipcon, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5045 to look at the new patch set (#7). Change subject: KUDU-921. tablet copy: Make the StartTabletCopy() RPC async

[kudu-CR] KUDU-921. tablet copy: Make the StartTabletCopy() RPC async

2016-12-01 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: KUDU-921. tablet copy: Make the StartTabletCopy() RPC async .. Patch Set 6: (3 comments)

[kudu-CR] KUDU-1752 C++ client error memory should be bounded

2016-12-01 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: KUDU-1752 C++ client error memory should be bounded .. Patch Set 1: (3 comments) Thanks! Unit tests?

[kudu-CR] KUDU-921. tablet copy: Make the StartTabletCopy() RPC async

2016-12-01 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: KUDU-921. tablet copy: Make the StartTabletCopy() RPC async .. Patch Set 6: > > On second look I see what you mean; the moment we invoke the > > callback, we

[kudu-CR] KUDU-798 (part 3) Make replica transactions start/abort on the consensus thread

2016-12-01 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-798 (part 3) Make replica transactions start/abort on the consensus thread .. Patch Set 6: (3 comments)

[kudu-CR] KUDU-798 (part 3) Make replica transactions start/abort on the consensus thread

2016-12-01 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-798 (part 3) Make replica transactions start/abort on the consensus thread .. Patch Set 6: (3 comments)

[kudu-CR] WIP KUDU-1127 Don't hang scanner threads waiting for safe time

2016-12-01 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: WIP KUDU-1127 Don't hang scanner threads waiting for safe time .. Patch Set 1: btw I think the solution for that would actually more in the line of making

[kudu-CR] WIP KUDU-1127 Don't hang scanner threads waiting for safe time

2016-12-01 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: WIP KUDU-1127 Don't hang scanner threads waiting for safe time .. Patch Set 1: (1 comment) Yeah this doesn't try to make it not wait at all, just tries

[kudu-CR] KUDU-798 (part 3) Make replica transactions start/abort on the consensus thread

2016-12-01 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-798 (part 3) Make replica transactions start/abort on the consensus thread .. Patch Set 4: (1 comment)

[kudu-CR] KUDU-1752 C++ client error memory should be bounded

2016-12-01 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: KUDU-1752 C++ client error memory should be bounded .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5308/1/src/kudu/client/error_collector.cc

[kudu-CR] tool: Replace Kudu replica with tablet replica in help text

2016-12-01 Thread Mike Percy (Code Review)
Hello Dinesh Bhat, Adar Dembo, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/5310 to review the following change. Change subject: tool: Replace Kudu replica with tablet replica in help text

[kudu-CR] KUDU-798 (part 3) Make replica transactions start/abort on the consensus thread

2016-12-01 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5294 to look at the new patch set (#5). Change subject: KUDU-798 (part 3) Make replica transactions start/abort on the consensus thread

[kudu-CR] KUDU-798 (part 3) Make replica transactions start/abort on the consensus thread

2016-12-01 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-798 (part 3) Make replica transactions start/abort on the consensus thread .. Patch Set 3: (8 comments)

[kudu-CR] KUDU-921. tablet copy: Make the StartTabletCopy() RPC async

2016-12-01 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: KUDU-921. tablet copy: Make the StartTabletCopy() RPC async .. Patch Set 6: > On second look I see what you mean; the moment we invoke the > callback, we respond

[kudu-CR] WIP KUDU-1127 Don't hang scanner threads waiting for safe time

2016-12-01 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: WIP KUDU-1127 Don't hang scanner threads waiting for safe time .. Patch Set 1: (3 comments) seems like a reasonable heuristic. The only kinda funny thing is

[kudu-CR] KUDU-1752 C++ client error memory should be bounded

2016-12-01 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: KUDU-1752 C++ client error memory should be bounded .. Patch Set 1: (5 comments) Thank you for the review. > (4 comments) > > Could you exercise the new

[kudu-CR] KUDU-798 (part 3) Make replica transactions start/abort on the consensus thread

2016-12-01 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-798 (part 3) Make replica transactions start/abort on the consensus thread .. Patch Set 4: (1 comment)

[kudu-CR] WIP: KUDU-1778. Fix LMP mismatch behavior after a replica restarts

2016-12-01 Thread Todd Lipcon (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5309 to look at the new patch set (#2). Change subject: WIP: KUDU-1778. Fix LMP mismatch behavior after a replica restarts

[kudu-CR] WIP: KUDU-1778. Fix LMP mismatch behavior after a replica restarts

2016-12-01 Thread Todd Lipcon (Code Review)
Hello David Ribeiro Alves, Mike Percy, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/5309 to review the following change. Change subject: WIP: KUDU-1778. Fix LMP mismatch behavior after a replica restarts

[kudu-CR] KUDU-921. tablet copy: Make the StartTabletCopy() RPC async

2016-12-01 Thread Dinesh Bhat (Code Review)
Dinesh Bhat has posted comments on this change. Change subject: KUDU-921. tablet copy: Make the StartTabletCopy() RPC async .. Patch Set 6: Code-Review+1 (3 comments)

[kudu-CR] KUDU-1752 C++ client error memory should be bounded

2016-12-01 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-1752 C++ client error memory should be bounded .. Patch Set 1: (4 comments) Could you exercise the new code in some tests? Separately, it may be interesting

[kudu-CR] KUDU-1752 C++ client error memory should be bounded

2016-12-01 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded a new change for review. http://gerrit.cloudera.org:8080/5308 Change subject: KUDU-1752 C++ client error memory should be bounded .. KUDU-1752 C++ client error memory should be bounded Added

[kudu-CR] KUDU-1773: remove overly strict DCHECKs

2016-12-01 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-1773: remove overly strict DCHECKs .. Patch Set 1: > Can you think of a new stress test we could add that would trigger > this? It's a shame that we found

[kudu-CR] KUDU-1775 (part 2). Enforce a max number of columns and reasonable identifier lengths

2016-12-01 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: KUDU-1775 (part 2). Enforce a max number of columns and reasonable identifier lengths .. Patch Set 5: Code-Review+2 -- To view, visit

[kudu-CR] KUDU-1775 (part 2). Enforce a max number of columns and reasonable identifier lengths

2016-12-01 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-1775 (part 2). Enforce a max number of columns and reasonable identifier lengths .. Patch Set 5: Code-Review+2 carrying +2 from adar/will/dan (just added a

[kudu-CR] KUDU-1775 (part 2). Enforce a max number of columns and reasonable identifier lengths

2016-12-01 Thread Todd Lipcon (Code Review)
Hello Adar Dembo, Will Berkeley, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5290 to look at the new patch set (#5). Change subject: KUDU-1775 (part 2). Enforce a max number of columns and reasonable identifier lengths

[kudu-CR] KUDU-1775 (part 2). Enforce a max number of columns and reasonable identifier lengths

2016-12-01 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: KUDU-1775 (part 2). Enforce a max number of columns and reasonable identifier lengths .. Patch Set 4: (1 comment)

[kudu-CR] KUDU-981 (part 1): validate identifiers as UTF8 with no null bytes

2016-12-01 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-981 (part 1): validate identifiers as UTF8 with no null bytes .. Patch Set 1: > Forcing everyone to use UTF-8 is pragmatic, but it's also restrictive for >

[kudu-CR] KUDU-921. tablet copy: Make the StartTabletCopy() RPC async

2016-12-01 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-921. tablet copy: Make the StartTabletCopy() RPC async .. Patch Set 6: > > If I'm understanding this correctly, the semantics of the > > StartTabletCopy RPC

[kudu-CR] [tools] Tombstone the tablet with "local replica delete"

2016-12-01 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: [tools] Tombstone the tablet with "local_replica delete" .. Patch Set 4: (1 comment)

[kudu-CR] [tools] Tombstone the tablet with "local replica delete"

2016-12-01 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: [tools] Tombstone the tablet with "local_replica delete" .. Patch Set 3: (1 comment)

[kudu-CR] [tools] Tombstone the tablet with "local replica delete"

2016-12-01 Thread Dinesh Bhat (Code Review)
Hello Mike Percy, Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5191 to look at the new patch set (#4). Change subject: [tools] Tombstone the tablet with "local_replica delete"

[kudu-CR] KUDU-798 (part 3) Make replica transactions start/abort on the consensus thread

2016-12-01 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: KUDU-798 (part 3) Make replica transactions start/abort on the consensus thread .. Patch Set 4: (7 comments)

[kudu-CR] KUDU-1422 [java client] modifiable error collector capacity

2016-12-01 Thread eric-maynard (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5291 to look at the new patch set (#2). Change subject: KUDU-1422 [java client] modifiable error collector capacity ..

[kudu-CR] [java client] Allow to pass extra flags to tservers/masters

2016-12-01 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: [java client] Allow to pass extra flags to tservers/masters .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5299 To unsubscribe,

[kudu-CR] [java client] Allow to pass extra flags to tservers/masters

2016-12-01 Thread Mike Percy (Code Review)
Mike Percy has submitted this change and it was merged. Change subject: [java client] Allow to pass extra flags to tservers/masters .. [java client] Allow to pass extra flags to tservers/masters This path adds a couple of

[kudu-CR] KUDU-981 (part 1): validate identifiers as UTF8 with no null bytes

2016-12-01 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: KUDU-981 (part 1): validate identifiers as UTF8 with no null bytes .. Patch Set 1: Code-Review+2 (1 comment)

[kudu-CR] KUDU-1775 (part 2). Enforce a max number of columns and reasonable identifier lengths

2016-12-01 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: KUDU-1775 (part 2). Enforce a max number of columns and reasonable identifier lengths .. Patch Set 4: Code-Review+2 -- To view, visit

[kudu-CR] KUDU-1643 Prune hash partitions based on IN-list predicates

2016-12-01 Thread Haijie Hong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5176 to look at the new patch set (#8). Change subject: KUDU-1643 Prune hash partitions based on IN-list predicates ..

[kudu-CR] [tools] Tombstone the tablet with "local replica delete"

2016-12-01 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: [tools] Tombstone the tablet with "local_replica delete" .. Patch Set 3: (6 comments)

[kudu-CR] KUDU-1773: remove overly strict DCHECKs

2016-12-01 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: KUDU-1773: remove overly strict DCHECKs .. Patch Set 1: Code-Review+1 Looks safe to me. I'll leave it to Todd for final review. -- To view, visit

[kudu-CR] [flume] Add interface annotations to KuduOperationsProducers

2016-12-01 Thread Mike Percy (Code Review)
Mike Percy has submitted this change and it was merged. Change subject: [flume] Add interface annotations to KuduOperationsProducers .. [flume] Add interface annotations to KuduOperationsProducers This ensures their javadocs

[kudu-CR] WIP: Add a way to get the physical time component of a hybrid timestamp

2016-12-01 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has uploaded a new change for review. http://gerrit.cloudera.org:8080/5304 Change subject: WIP: Add a way to get the physical time component of a hybrid timestamp .. WIP: Add a way to get the physical

[kudu-CR] WIP: KUDU-798 (part 4) Add a TimeManager to manage safe time advancement

2016-12-01 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5300 to look at the new patch set (#4). Change subject: WIP: KUDU-798 (part 4) Add a TimeManager to manage safe time advancement

[kudu-CR] WIP KUDU-1127 Don't hang scanner threads waiting for safe time

2016-12-01 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has uploaded a new change for review. http://gerrit.cloudera.org:8080/5305 Change subject: WIP KUDU-1127 Don't hang scanner threads waiting for safe time .. WIP KUDU-1127 Don't hang scanner threads waiting

[kudu-CR] KUDU-921. tablet copy: Make the StartTabletCopy() RPC async

2016-12-01 Thread Mike Percy (Code Review)
Hello Todd Lipcon, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5045 to look at the new patch set (#6). Change subject: KUDU-921. tablet copy: Make the StartTabletCopy() RPC async

[kudu-CR] KUDU-921. tablet copy: Make the StartTabletCopy() RPC async

2016-12-01 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: KUDU-921. tablet copy: Make the StartTabletCopy() RPC async .. Patch Set 2: (6 comments)

[kudu-CR] KUDU-921. tablet copy: Make the StartTabletCopy() RPC async

2016-12-01 Thread Mike Percy (Code Review)
Hello Todd Lipcon, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5045 to look at the new patch set (#5). Change subject: KUDU-921. tablet copy: Make the StartTabletCopy() RPC async

[kudu-CR] KUDU-921. tablet copy: Make the StartTabletCopy() RPC async

2016-12-01 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: KUDU-921. tablet copy: Make the StartTabletCopy() RPC async .. Patch Set 4: (4 comments) > If I'm understanding this correctly, the semantics of the >

  1   2   >