[kudu-CR] KUDU-1831. Java client does not check if the primary key columns are specified first

Hello Jean-Daniel Cryans, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5723 to look at the new patch set (#2). Change subject: KUDU-1831. Java client does not check if the primary key columns are specified first ...

[kudu-CR] Add Google Breakpad support to Kudu

Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5620 to look at the new patch set (#6). Change subject: Add Google Breakpad support to Kudu .. Add Google Breakpad suppo

[kudu-CR] Add Google Breakpad support to Kudu

Mike Percy has posted comments on this change. Change subject: Add Google Breakpad support to Kudu .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/5620/3/src/kudu/util/minidump.cc File src/kudu/util/minidump.cc

[kudu-CR] env util: Factor out helper DeleteExcessFilesByPattern()

Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5740 to look at the new patch set (#3). Change subject: env_util: Factor out helper DeleteExcessFilesByPattern() .. env_

[kudu-CR] env util: Factor out helper DeleteExcessFilesByPattern()

Mike Percy has posted comments on this change. Change subject: env_util: Factor out helper DeleteExcessFilesByPattern() .. Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/5740/2/src/kudu/util/env_util-test.cc Fil

[kudu-CR] thirdparty: patch glog for better breakpad support

Mike Percy has submitted this change and it was merged. Change subject: thirdparty: patch glog for better breakpad support .. thirdparty: patch glog for better breakpad support This patch is a backport of glog commit cda16b3443

[kudu-CR] thirdparty: patch glog for better breakpad support

Mike Percy has posted comments on this change. Change subject: thirdparty: patch glog for better breakpad support .. Patch Set 2: > Right, but for which signals? Just SIGABRT? AFAICT, glog handles > SIGSEGV, SIGILL, SIGFPE, SI

[kudu-CR] [kudu-jepsen] Kudu Jepsen tests

Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5492 to look at the new patch set (#20). Change subject: [kudu-jepsen] Kudu Jepsen tests .. [kudu-jepsen] Kudu Jepsen te

[kudu-CR] Add Google Breakpad support to Kudu

Adar Dembo has posted comments on this change. Change subject: Add Google Breakpad support to Kudu .. Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/5620/3/src/kudu/util/minidump.cc File src/kudu/util/minidump.cc

[kudu-CR] [util] fixed env-test on OS X

Adar Dembo has submitted this change and it was merged. Change subject: [util] fixed env-test on OS X .. [util] fixed env-test on OS X Prior to the fix, in some cases the uninitialized portion of 64-bit variable was non-zero an

[kudu-CR] [util] fixed env-test on OS X

Adar Dembo has posted comments on this change. Change subject: [util] fixed env-test on OS X .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5738 To unsubscribe, visit http://gerrit.cloudera.org

[kudu-CR] thirdparty: patch glog for better breakpad support

Adar Dembo has posted comments on this change. Change subject: thirdparty: patch glog for better breakpad support .. Patch Set 2: > > Still trying to wrap my head around who among breakpad and glog is > > responsible for which

[kudu-CR] [util] fixed env-test on OS X

Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5738 to look at the new patch set (#5). Change subject: [util] fixed env-test on OS X .. [util] fixed env-test on OS X

[kudu-CR] thirdparty: patch glog for better breakpad support

Mike Percy has posted comments on this change. Change subject: thirdparty: patch glog for better breakpad support .. Patch Set 2: > Still trying to wrap my head around who among breakpad and glog is > responsible for which sig

[kudu-CR] Control mutex stack walking in DEBUG mode with a gflag

Mike Percy has posted comments on this change. Change subject: Control mutex stack walking in DEBUG mode with a gflag .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/5741/2//COMMIT_MSG Commit Message: PS2, Lin

[kudu-CR] [util] fixed env-test on OS X

Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5738 to look at the new patch set (#4). Change subject: [util] fixed env-test on OS X .. [util] fixed env-test on OS X

[kudu-CR] [util] fixed env-test on OS X

Alexey Serbin has posted comments on this change. Change subject: [util] fixed env-test on OS X .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/5738/2/src/kudu/util/env_posix.cc File src/kudu/util/env_posix.cc:

[kudu-CR] [util] fixed env-test on OS X

Alexey Serbin has posted comments on this change. Change subject: [util] fixed env-test on OS X .. Patch Set 2: (2 comments) Thank you for the review. http://gerrit.cloudera.org:8080/#/c/5738/2//COMMIT_MSG Commit Message: Li

[kudu-CR] thirdparty: patch glog for better breakpad support

Adar Dembo has posted comments on this change. Change subject: thirdparty: patch glog for better breakpad support .. Patch Set 2: Code-Review+2 Still trying to wrap my head around who among breakpad and glog is responsible for

[kudu-CR] Control mutex stack walking in DEBUG mode with a gflag

Adar Dembo has posted comments on this change. Change subject: Control mutex stack walking in DEBUG mode with a gflag .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/5741/2//COMMIT_MSG Commit Message: PS2, Li

[kudu-CR] [util] fixed env-test on OS X

Dinesh Bhat has posted comments on this change. Change subject: [util] fixed env-test on OS X .. Patch Set 2: (2 comments) I am not seeing radio buttons on gerrit, perhaps some browser plugin issue I am facing at the moment,

[kudu-CR] env util: Factor out helper DeleteExcessFilesByPattern()

Adar Dembo has posted comments on this change. Change subject: env_util: Factor out helper DeleteExcessFilesByPattern() .. Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/5740/2/src/kudu/util/env_util-test.cc Fil

[kudu-CR] KUDU-1836. Enable compression of DeltaFiles

Alexey Serbin has posted comments on this change. Change subject: KUDU-1836. Enable compression of DeltaFiles .. Patch Set 1: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/5737/1/src/kudu/tablet/deltafile.cc Fi

[kudu-CR] EMC: Don't reuse data dir for log dir

Adar Dembo has submitted this change and it was merged. Change subject: EMC: Don't reuse data dir for log dir .. EMC: Don't reuse data dir for log dir Separate the data and log directories in ExternalMiniCluster. Prior to this

[kudu-CR] EMC: Don't reuse data dir for log dir

Adar Dembo has posted comments on this change. Change subject: EMC: Don't reuse data dir for log dir .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5619 To unsubscribe, visit http://gerrit.clou

[kudu-CR] [util] fixed env-test on OS X

Adar Dembo has posted comments on this change. Change subject: [util] fixed env-test on OS X .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/5738/2/src/kudu/util/env_posix.cc File src/kudu/util/env_posix.cc: L

[kudu-CR] [security] interface for certificate signing service

Alexey Serbin has posted comments on this change. Change subject: [security] interface for certificate signing service .. Patch Set 3: Verified+1 Unrelevant test breakage: RaftConsensusITest.TestConfigChangeUnderLoad -- To vi

[kudu-CR] [util] fixed env-test on OS X

Alexey Serbin has posted comments on this change. Change subject: [util] fixed env-test on OS X .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/5738/2/src/kudu/util/env_posix.cc File src/kudu/util/env_posix.cc

[kudu-CR] Control mutex stack walking in DEBUG mode with a gflag

Mike Percy has posted comments on this change. Change subject: Control mutex stack walking in DEBUG mode with a gflag .. Patch Set 2: Verified+1 Overriding flaky java test. -- To view, visit http://gerrit.cloudera.org:8080/57

[kudu-CR] KUDU-1836. Enable compression of DeltaFiles

Todd Lipcon has posted comments on this change. Change subject: KUDU-1836. Enable compression of DeltaFiles .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/5737/1//COMMIT_MSG Commit Message: PS1, Line 10: eem

[kudu-CR] [util] fixed env-test on OS X

Dinesh Bhat has posted comments on this change. Change subject: [util] fixed env-test on OS X .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/5738/2/src/kudu/util/env_posix.cc File src/kudu/util/env_posix.cc:

[kudu-CR] KUDU-1836. Enable compression of DeltaFiles

David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1836. Enable compression of DeltaFiles .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/5737/1//COMMIT_MSG Commit Message: PS1, Line

[kudu-CR] KUDU-1767. c++ client: Prevent concurrent flushes by default

Mike Percy has abandoned this change. Change subject: KUDU-1767. c++ client: Prevent concurrent flushes by default .. Abandoned Abandoning this workaround. For many ingest use cases, where people consider the primary data depe

[kudu-CR] Add Google Breakpad support to Kudu

Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5620 to look at the new patch set (#5). Change subject: Add Google Breakpad support to Kudu .. Add Google Breakpad suppo

[kudu-CR] env util: Factor out helper DeleteExcessFilesByPattern()

Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5740 to look at the new patch set (#2). Change subject: env_util: Factor out helper DeleteExcessFilesByPattern() .. env_

[kudu-CR] EMC: Don't reuse data dir for log dir

Hello Dinesh Bhat, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5619 to look at the new patch set (#5). Change subject: EMC: Don't reuse data dir for log dir .. EMC: Don't

[kudu-CR] EMC: Don't reuse data dir for log dir

Mike Percy has posted comments on this change. Change subject: EMC: Don't reuse data dir for log dir .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/5619/4//COMMIT_MSG Commit Message: PS4, Line 29: initialing

[kudu-CR] Add some path / env related helper functions

Mike Percy has submitted this change and it was merged. Change subject: Add some path / env related helper functions .. Add some path / env related helper functions * path_util: Add SplitPath() helper function This function

[kudu-CR] Add some path / env related helper functions

Mike Percy has posted comments on this change. Change subject: Add some path / env related helper functions .. Patch Set 4: Verified+1 Yeah, spurious failure. -- To view, visit http://gerrit.cloudera.org:8080/5618 To unsubscr

[kudu-CR] [util] fixed env-test on OS X

Alexey Serbin has posted comments on this change. Change subject: [util] fixed env-test on OS X .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/5738/2/src/kudu/util/env_posix.cc File src/kudu/util/env_posix.cc:

[kudu-CR] [util] fixed env-test on OS X

Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5738 to look at the new patch set (#3). Change subject: [util] fixed env-test on OS X .. [util] fixed env-test on OS X

[kudu-CR] [util] fixed env-test on OS X

Alexey Serbin has posted comments on this change. Change subject: [util] fixed env-test on OS X .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/5738/2/src/kudu/util/env_posix.cc File src/kudu/util/env_posix.cc:

[kudu-CR] [util] fixed env-test on OS X

Adar Dembo has posted comments on this change. Change subject: [util] fixed env-test on OS X .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/5738/2/src/kudu/util/env_posix.cc File src/kudu/util/env_posix.cc: L

[kudu-CR] Add some path / env related helper functions

Adar Dembo has posted comments on this change. Change subject: Add some path / env related helper functions .. Patch Set 4: Code-Review+2 Test failure looks spurious. -- To view, visit http://gerrit.cloudera.org:8080/5618 To

[kudu-CR] EMC: Don't reuse data dir for log dir

Adar Dembo has posted comments on this change. Change subject: EMC: Don't reuse data dir for log dir .. Patch Set 4: (1 comment) Looks good to me, just one nit in the commit message. http://gerrit.cloudera.org:8080/#/c/5619/4

[kudu-CR] docs: add notes for multi master migration

Adar Dembo has submitted this change and it was merged. Change subject: docs: add notes for multi master migration .. docs: add notes for multi master migration Change-Id: I7e469bc23b650f3b99c785311acc665ac20f33ea Reviewed-on:

[kudu-CR] docs: add notes for multi master migration

Adar Dembo has posted comments on this change. Change subject: docs: add notes for multi master migration .. Patch Set 4: Code-Review+2 Thanks for being patient. -- To view, visit http://gerrit.cloudera.org:8080/5728 To unsub

[kudu-CR] docs: add notes for multi master migration

Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5728 to look at the new patch set (#4). Change subject: docs: add notes for multi master migration .. docs: add notes fo

[kudu-CR] docs: add notes for multi master migration

zhen.zhang has posted comments on this change. Change subject: docs: add notes for multi master migration .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/5728/3/docs/administration.adoc File docs/administration

[kudu-CR] docs: add notes for multi master migration

zhen.zhang has posted comments on this change. Change subject: docs: add notes for multi master migration .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/5728/3/docs/administration.adoc File docs/administration

[kudu-CR] docs: add notes for multi master migration

Adar Dembo has posted comments on this change. Change subject: docs: add notes for multi master migration .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/5728/3/docs/administration.adoc File docs/administration

[kudu-CR] docs: add notes for multi master migration

Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5728 to look at the new patch set (#3). Change subject: docs: add notes for multi master migration .. docs: add notes fo

[kudu-CR] docs: add notes for multi master migration

zhen.zhang has posted comments on this change. Change subject: docs: add notes for multi master migration .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/5728/2/docs/administration.adoc File docs/administration

[kudu-CR] KUDU-1831. Java client does not check if the primary key columns are specified first

Jun He has posted comments on this change. Change subject: KUDU-1831. Java client does not check if the primary key columns are specified first .. Patch Set 1: Based on https://github.com/apache/kudu/blob/master/java/kudu-cli

[kudu-CR] EMC: Don't reuse data dir for log dir

Hello Dinesh Bhat, Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5619 to look at the new patch set (#4). Change subject: EMC: Don't reuse data dir for log dir ..

[kudu-CR] Add Google Breakpad support to Kudu

Hello Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5620 to look at the new patch set (#4). Change subject: Add Google Breakpad support to Kudu .. Add Google Br

[kudu-CR] Control mutex stack walking in DEBUG mode with a gflag

Hello Adar Dembo, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/5741 to review the following change. Change subject: Control mutex stack walking in DEBUG mode with a gflag .. Control mutex

[kudu-CR] thirdparty: patch glog for better breakpad support

Hello Adar Dembo, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/5742 to review the following change. Change subject: thirdparty: patch glog for better breakpad support .. thirdparty: patch

[kudu-CR] env util: Factor out helper DeleteExcessFilesByPattern()

Hello Adar Dembo, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/5740 to review the following change. Change subject: env_util: Factor out helper DeleteExcessFilesByPattern() .. env_util: F

[kudu-CR] Add some path / env related helper functions

Hello Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5618 to look at the new patch set (#4). Change subject: Add some path / env related helper functions .. Add

[kudu-CR] Add Google Breakpad support to Kudu

Mike Percy has posted comments on this change. Change subject: Add Google Breakpad support to Kudu .. Patch Set 3: (46 comments) http://gerrit.cloudera.org:8080/#/c/5620/3//COMMIT_MSG Commit Message: Line 7: Add Google Breakp

[kudu-CR] EMC: Don't reuse data dir for log dir

Mike Percy has posted comments on this change. Change subject: EMC: Don't reuse data dir for log dir .. Patch Set 3: (13 comments) http://gerrit.cloudera.org:8080/#/c/5619/3//COMMIT_MSG Commit Message: PS3, Line 11: . > It wo

[kudu-CR] Add some path / env related helper functions

Mike Percy has posted comments on this change. Change subject: Add some path / env related helper functions .. Patch Set 3: (7 comments) http://gerrit.cloudera.org:8080/#/c/5618/3/src/kudu/util/env_util-test.cc File src/kudu/u

[kudu-CR] docs: add notes for multi master migration

Adar Dembo has posted comments on this change. Change subject: docs: add notes for multi master migration .. Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/5728/1/docs/administration.adoc File docs/administratio

[kudu-CR] KUDU-1831. Java client does not check if the primary key columns are specified first

Jun He has posted comments on this change. Change subject: KUDU-1831. Java client does not check if the primary key columns are specified first .. Patch Set 1: > It seems like in the context of a projection, we don't want to