[kudu-CR] log block manager: switch from google::sparse hash map to sparsepp

2017-09-14 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: log_block_manager: switch from google::sparse_hash_map to sparsepp .. log_block_manager: switch from google::sparse_hash_map to sparsepp sparsepp is

[kudu-CR] Add a simple benchmark to create 1M blocks and reopen LBM

2017-09-14 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: Add a simple benchmark to create 1M blocks and reopen LBM .. Add a simple benchmark to create 1M blocks and reopen LBM Change-Id:

[kudu-CR] Add a simple benchmark to create 1M blocks and reopen LBM

2017-09-14 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Add a simple benchmark to create 1M blocks and reopen LBM .. Patch Set 2: (1 comment)

[kudu-CR] log block manager: use move semantics to fill in the block map

2017-09-14 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: log_block_manager: use move semantics to fill in the block map .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/8008 To

[kudu-CR] Add a simple benchmark to create 1M blocks and reopen LBM

2017-09-14 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Add a simple benchmark to create 1M blocks and reopen LBM .. Patch Set 2: Code-Review+2 (1 comment) Based on my understanding of mkfs block size choices, I think

[kudu-CR] Avoid unnecessary vector allocations for ReadV/WriteV-like APIs

2017-09-14 Thread Todd Lipcon (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8077 to look at the new patch set (#3). Change subject: Avoid unnecessary vector allocations for ReadV/WriteV-like APIs

[kudu-CR] log block manager: switch from google::sparse hash map to sparsepp

2017-09-14 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: log_block_manager: switch from google::sparse_hash_map to sparsepp .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/8007 To

[kudu-CR] KUDU-1788. Increase Raft RPC timeout to 30sec to avoid fruitless retries.

2017-09-14 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-1788. Increase Raft RPC timeout to 30sec to avoid fruitless retries. .. Patch Set 1: (2 comments) > does this have any nasty interaction with failure

[kudu-CR] [consensus] micro-cleanup on VerifyRaftConfig()

2017-09-14 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded a new change for review. http://gerrit.cloudera.org:8080/8078 Change subject: [consensus] micro-cleanup on VerifyRaftConfig() .. [consensus] micro-cleanup on VerifyRaftConfig() Removed unused

[kudu-CR] Avoid unnecessary vector allocations for ReadV/WriteV-like APIs

2017-09-14 Thread Todd Lipcon (Code Review)
Todd Lipcon has uploaded a new patch set (#2). Change subject: Avoid unnecessary vector allocations for ReadV/WriteV-like APIs .. Avoid unnecessary vector allocations for ReadV/WriteV-like APIs This reduces extra short-lived

[kudu-CR] KUDU-2144. Add metrics for Reactor load

2017-09-14 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: KUDU-2144. Add metrics for Reactor load .. KUDU-2144. Add metrics for Reactor load This adds two new metrics: 1) reactor_load_percent This measures the

[kudu-CR] Avoid a few allocations while reading PBC files

2017-09-14 Thread Todd Lipcon (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8009 to look at the new patch set (#2). Change subject: Avoid a few allocations while reading PBC files .. Avoid a few

[kudu-CR] Avoid unnecessary vector allocations for ReadV/WriteV-like APIs

2017-09-14 Thread Todd Lipcon (Code Review)
Todd Lipcon has uploaded a new change for review. http://gerrit.cloudera.org:8080/8077 Change subject: Avoid unnecessary vector allocations for ReadV/WriteV-like APIs .. Avoid unnecessary vector allocations for

[kudu-CR] WIP: pb util: avoid repeated stat() calls reading files

2017-09-14 Thread Todd Lipcon (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8010 to look at the new patch set (#2). Change subject: WIP: pb_util: avoid repeated stat() calls reading files .. WIP:

[kudu-CR] Avoid a few allocations while reading PBC files

2017-09-14 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Avoid a few allocations while reading PBC files .. Patch Set 1: yea, WebRTC (chromium ish) has ArrayView which is pretty nice for this kinda thing as well. Maybe

[kudu-CR] c++ client: try harder to pass table IDs into RPCs that can accept them

2017-09-14 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: c++ client: try harder to pass table IDs into RPCs that can accept them .. Patch Set 2: (1 comment)

[kudu-CR] KUDU-1807 (part 2): ban GetTableSchema for table createdness in clients

2017-09-14 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: KUDU-1807 (part 2): ban GetTableSchema for table createdness in clients .. Patch Set 3: (5 comments)

[kudu-CR] Add a simple benchmark to create 1M blocks and reopen LBM

2017-09-14 Thread Todd Lipcon (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8006 to look at the new patch set (#2). Change subject: Add a simple benchmark to create 1M blocks and reopen LBM ..

[kudu-CR] log block manager: switch from google::sparse hash map to sparsepp

2017-09-14 Thread Todd Lipcon (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8007 to look at the new patch set (#2). Change subject: log_block_manager: switch from google::sparse_hash_map to sparsepp

[kudu-CR] Add mustache template for /table

2017-09-14 Thread Will Berkeley (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8067 to look at the new patch set (#3). Change subject: Add mustache template for /table .. Add mustache template for

[kudu-CR] Add mustache template for /table

2017-09-14 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: Add mustache template for /table .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/8067/1/src/kudu/master/master-path-handlers.h File

[kudu-CR] KUDU-2135 (part 2): don't use previously failed disks

2017-09-14 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7270 to look at the new patch set (#30). Change subject: KUDU-2135 (part 2): don't use previously failed disks ..

[kudu-CR] KUDU-2135 (part 2): don't use previously failed disks

2017-09-14 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7270 to look at the new patch set (#29). Change subject: KUDU-2135 (part 2): don't use previously failed disks ..

[kudu-CR] Add a simple benchmark to create 1M blocks and reopen LBM

2017-09-14 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Add a simple benchmark to create 1M blocks and reopen LBM .. Patch Set 1: (1 comment)

[kudu-CR] log block manager: switch from google::sparse hash map to sparsepp

2017-09-14 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: log_block_manager: switch from google::sparse_hash_map to sparsepp .. Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/8007/1//COMMIT_MSG Commit

[kudu-CR] ref counted: fix move constructors to actually move

2017-09-14 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: ref_counted: fix move constructors to actually move .. ref_counted: fix move constructors to actually move Ever since the move constructors for

[kudu-CR] ref counted: fix move constructors to actually move

2017-09-14 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: ref_counted: fix move constructors to actually move .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/8002/2/src/kudu/gutil/ref_counted.h File

[kudu-CR] [tests] de-flaking catalog manager tsk-itest

2017-09-14 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [tests] de-flaking catalog_manager_tsk-itest .. Patch Set 1: > What's the verdict on this? It seems like the test is no longer as > flaky as it was last week.

[kudu-CR] [tests] de-flaking catalog manager tsk-itest

2017-09-14 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: [tests] de-flaking catalog_manager_tsk-itest .. Patch Set 1: What's the verdict on this? It seems like the test is no longer as flaky as it was last week. Did we

[kudu-CR] Update instructions for publishing changes to the live site

2017-09-14 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Update instructions for publishing changes to the live site .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/8059 To unsubscribe,

[kudu-CR] Add mustache template for /table

2017-09-14 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Add mustache template for /table .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/8067/1/src/kudu/master/master-path-handlers.h File

[kudu-CR] KUDU-501 Redirect to leader master web UI

2017-09-14 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-501 Redirect to leader master web UI .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/8068/2/src/kudu/master/master-path-handlers.cc File

[kudu-CR] c++ client: try harder to pass table IDs into RPCs that can accept them

2017-09-14 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: c++ client: try harder to pass table IDs into RPCs that can accept them .. Patch Set 2: (5 comments)

[kudu-CR] c++ client: try harder to pass table IDs into RPCs that can accept them

2017-09-14 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: c++ client: try harder to pass table IDs into RPCs that can accept them .. Patch Set 2: (1 comment)

[kudu-CR] KUDU-1807 (part 2): ban GetTableSchema for table createdness in clients

2017-09-14 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: KUDU-1807 (part 2): ban GetTableSchema for table createdness in clients .. Patch Set 3: (3 comments)

[kudu-CR] KUDU-1807 (part 1): deprecate GetTableSchema.create table done

2017-09-14 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-1807 (part 1): deprecate GetTableSchema.create_table_done .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/8027/1/src/kudu/master/master.proto

[kudu-CR] KUDU-1807 (part 3): remove GetTableSchema.create table done

2017-09-14 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-1807 (part 3): remove GetTableSchema.create_table_done .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/8045 To unsubscribe,

[kudu-CR] c++ client: try harder to pass table IDs into RPCs that can accept them

2017-09-14 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: c++ client: try harder to pass table IDs into RPCs that can accept them .. Patch Set 2: (2 comments)

[kudu-CR] KUDU-1807 (part 1): deprecate GetTableSchema.create table done

2017-09-14 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-1807 (part 1): deprecate GetTableSchema.create_table_done .. Patch Set 1: (1 comment)

[kudu-CR] KUDU-2055 [part 2]: Add util to construct sorted disjoint interval

2017-09-14 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-2055 [part 2]: Add util to construct sorted disjoint interval .. Patch Set 1: (1 comment)

[kudu-CR] KUDU-2055 [part 2]: Add util to construct sorted disjoint interval

2017-09-14 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-2055 [part 2]: Add util to construct sorted disjoint interval .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/8041/1//COMMIT_MSG

[kudu-CR] KUDU-1807 (part 2): ban GetTableSchema for table createdness in clients

2017-09-14 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-1807 (part 2): ban GetTableSchema for table createdness in clients .. Patch Set 3: (4 comments)

[kudu-CR] KUDU-1807 (part 3): remove GetTableSchema.create table done

2017-09-14 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1807 (part 3): remove GetTableSchema.create_table_done .. Patch Set 2: actually nm. my concern was that we might use done() (which is false by

[kudu-CR] KUDU-1807 (part 3): remove GetTableSchema.create table done

2017-09-14 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1807 (part 3): remove GetTableSchema.create_table_done .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/8045 To

[kudu-CR] KUDU-1807 (part 3): remove GetTableSchema.create table done

2017-09-14 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1807 (part 3): remove GetTableSchema.create_table_done .. Patch Set 2: lgtm, just want to make sure that previously the java client (and elsewhere)

[kudu-CR] KUDU-2144. Add metrics for Reactor load

2017-09-14 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-2144. Add metrics for Reactor load .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/8064 To unsubscribe, visit

[kudu-CR] KUDU-1755 Part 2: Improve tablet on-disk size metric

2017-09-14 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1755 Part 2: Improve tablet on-disk size metric .. Patch Set 19: (3 comments) http://gerrit.cloudera.org:8080/#/c/6968/19/src/kudu/consensus/log.h

[kudu-CR] kudu-spark: change default master address to local fqdn

2017-09-14 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: kudu-spark: change default master address to local fqdn .. Patch Set 2: (1 comment)

[kudu-CR] KUDU-1755 Part 2: Improve tablet on-disk size metric

2017-09-14 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: KUDU-1755 Part 2: Improve tablet on-disk size metric .. Patch Set 17: (1 comment) http://gerrit.cloudera.org:8080/#/c/6968/17/src/kudu/consensus/log.cc File

[kudu-CR] KUDU-1755 Part 2: Improve tablet on-disk size metric

2017-09-14 Thread Will Berkeley (Code Review)
Hello Adar Dembo, Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6968 to look at the new patch set (#19). Change subject: KUDU-1755 Part 2: Improve tablet on-disk size metric

[kudu-CR] c++ client: try harder to pass table IDs into RPCs that can accept them

2017-09-14 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: c++ client: try harder to pass table IDs into RPCs that can accept them .. Patch Set 2: (5 comments)

[kudu-CR] kudu-spark: change default master address to local fqdn

2017-09-14 Thread Attila Bukor (Code Review)
Attila Bukor has posted comments on this change. Change subject: kudu-spark: change default master address to local fqdn .. Patch Set 2: Code-Review+1 (1 comment)

[kudu-CR] KUDU-1755 Part 2: Improve tablet on-disk size metric

2017-09-14 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-1755 Part 2: Improve tablet on-disk size metric .. Patch Set 17: (1 comment) http://gerrit.cloudera.org:8080/#/c/6968/17/src/kudu/consensus/log.cc File

[kudu-CR] kudu-spark: change default master address to local fqdn

2017-09-14 Thread Attila Bukor (Code Review)
Attila Bukor has posted comments on this change. Change subject: kudu-spark: change default master address to local fqdn .. Patch Set 2: (1 comment)

[kudu-CR] KUDU-1755 Part 2: Improve tablet on-disk size metric

2017-09-14 Thread Will Berkeley (Code Review)
Hello Adar Dembo, Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6968 to look at the new patch set (#18). Change subject: KUDU-1755 Part 2: Improve tablet on-disk size metric

[kudu-CR] KUDU-1755 Part 2: Improve tablet on-disk size metric

2017-09-14 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: KUDU-1755 Part 2: Improve tablet on-disk size metric .. Patch Set 17: (4 comments) http://gerrit.cloudera.org:8080/#/c/6968/17/src/kudu/consensus/log.cc File

[kudu-CR] [iwyu] introduce Linux system mappings

2017-09-14 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. Change subject: [iwyu] introduce Linux system mappings .. [iwyu] introduce Linux system mappings For starters, added the following mappings to achieve better

[kudu-CR] KUDU-2125: Tablet copy client does not retry on failures

2017-09-14 Thread Dan Burkert (Code Review)
Dan Burkert has submitted this change and it was merged. Change subject: KUDU-2125: Tablet copy client does not retry on failures .. KUDU-2125: Tablet copy client does not retry on failures The tablet copy client would fail

[kudu-CR] KUDU-2124. Don't hold session lock while initializing a TabletCopySession

2017-09-14 Thread Dan Burkert (Code Review)
Dan Burkert has submitted this change and it was merged. Change subject: KUDU-2124. Don't hold session lock while initializing a TabletCopySession .. KUDU-2124. Don't hold session lock while initializing a TabletCopySession

[kudu-CR] kudu-spark: change default master address to local fqdn

2017-09-14 Thread Dan Burkert (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8072 to look at the new patch set (#2). Change subject: kudu-spark: change default master address to local fqdn ..

[kudu-CR] [iwyu] introduce Linux system mappings

2017-09-14 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. Change subject: [iwyu] introduce Linux system mappings .. Patch Set 3: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/8071 To unsubscribe, visit

[kudu-CR] KUDU-501 Redirect to leader master web UI

2017-09-14 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. Change subject: KUDU-501 Redirect to leader master web UI .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/8068/2/src/kudu/master/master-path-handlers.cc File

[kudu-CR] c++ client: try harder to pass table IDs into RPCs that can accept them

2017-09-14 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: c++ client: try harder to pass table IDs into RPCs that can accept them .. Patch Set 2: Code-Review+1 (1 comment) LGTM, but perhaps Todd or JD need to approve

[kudu-CR] KUDU-1807 (part 2): ban GetTableSchema for table createdness in clients

2017-09-14 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-1807 (part 2): ban GetTableSchema for table createdness in clients .. Patch Set 3: Verified+1 Overriding Jenkins, the sole failure was in setting up one of

[kudu-CR] c++ client: try harder to pass table IDs into RPCs that can accept them

2017-09-14 Thread Adar Dembo (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8066 to look at the new patch set (#2). Change subject: c++ client: try harder to pass table IDs into RPCs that can accept them

[kudu-CR] c++ client: try harder to pass table IDs into RPCs that can accept them

2017-09-14 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: c++ client: try harder to pass table IDs into RPCs that can accept them .. Patch Set 1: (2 comments)

[kudu-CR] [iwyu] introduce Linux system mappings

2017-09-14 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: [iwyu] introduce Linux system mappings .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/8071 To unsubscribe, visit

[kudu-CR] [iwyu] introduce Linux system mappings

2017-09-14 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [iwyu] introduce Linux system mappings .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/8071/2/src/kudu/util/env_posix.cc File

[kudu-CR] KUDU-501 Redirect to leader master web UI

2017-09-14 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-501 Redirect to leader master web UI .. Patch Set 2: (5 comments) http://gerrit.cloudera.org:8080/#/c/8068/2//COMMIT_MSG Commit Message: PS2, Line 12: a

[kudu-CR] [iwyu] introduce Linux system mappings

2017-09-14 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8071 to look at the new patch set (#3). Change subject: [iwyu] introduce Linux system mappings .. [iwyu] introduce

[kudu-CR] KUDU-1755 Part 2: Improve tablet on-disk size metric

2017-09-14 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. Change subject: KUDU-1755 Part 2: Improve tablet on-disk size metric .. Patch Set 17: (4 comments) http://gerrit.cloudera.org:8080/#/c/6968/17/src/kudu/consensus/log.cc File

[kudu-CR] c++ client: try harder to pass table IDs into RPCs that can accept them

2017-09-14 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: c++ client: try harder to pass table IDs into RPCs that can accept them .. Patch Set 1: (2 comments)

[kudu-CR] kudu-spark-tools: change default master address to local fqdn

2017-09-14 Thread Dan Burkert (Code Review)
Hello Attila Bukor, Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/8072 to review the following change. Change subject: kudu-spark-tools: change default master address to local fqdn

[kudu-CR] KUDU-1755 Part 2: Improve tablet on-disk size metric

2017-09-14 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: KUDU-1755 Part 2: Improve tablet on-disk size metric .. Patch Set 17: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/6968 To unsubscribe,

[kudu-CR] [iwyu] introduce Linux system mappings

2017-09-14 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [iwyu] introduce Linux system mappings .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/8071/1/src/kudu/util/env_posix.cc File

[kudu-CR] [iwyu] introduce Linux system mappings

2017-09-14 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded a new patch set (#2). Change subject: [iwyu] introduce Linux system mappings .. [iwyu] introduce Linux system mappings For starters, added the following mappings to achieve better compatibility across

[kudu-CR] [iwyu] introduce Linux system mappings

2017-09-14 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: [iwyu] introduce Linux system mappings .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/8071/1/src/kudu/util/env_posix.cc File

[kudu-CR] [iwyu] introduce Linux system mappings

2017-09-14 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded a new change for review. http://gerrit.cloudera.org:8080/8071 Change subject: [iwyu] introduce Linux system mappings .. [iwyu] introduce Linux system mappings For starters, added the following

[kudu-CR] KUDU-2125: Tablet copy client does not retry on failures

2017-09-14 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: KUDU-2125: Tablet copy client does not retry on failures .. Patch Set 15: Code-Review+2 Carrying over Mike's +2. Had to rebase due to test conflict. -- To

[kudu-CR] KUDU-2124. Don't hold session lock while initializing a TabletCopySession

2017-09-14 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: KUDU-2124. Don't hold session lock while initializing a TabletCopySession .. Patch Set 10: Code-Review+2 (1 comment) Carrying over Mike's +2. Had to rebase due

[kudu-CR] KUDU-2124. Don't hold session lock while initializing a TabletCopySession

2017-09-14 Thread Dan Burkert (Code Review)
Hello Mike Percy, Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7985 to look at the new patch set (#10). Change subject: KUDU-2124. Don't hold session lock while initializing a TabletCopySession

[kudu-CR] KUDU-2125: Tablet copy client does not retry on failures

2017-09-14 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: KUDU-2125: Tablet copy client does not retry on failures .. Patch Set 14: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/8016 To unsubscribe,

[kudu-CR] KUDU-1755 Part 2: Improve tablet on-disk size metric

2017-09-14 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: KUDU-1755 Part 2: Improve tablet on-disk size metric .. Patch Set 17: (3 comments) http://gerrit.cloudera.org:8080/#/c/6968/16/src/kudu/consensus/log-test.cc

[kudu-CR] KUDU-1755 Part 2: Improve tablet on-disk size metric

2017-09-14 Thread Will Berkeley (Code Review)
Hello Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6968 to look at the new patch set (#17). Change subject: KUDU-1755 Part 2: Improve tablet on-disk size metric

[kudu-CR] KUDU-501 Redirect to leader master web UI

2017-09-14 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: KUDU-501 Redirect to leader master web UI .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/8068/1/src/kudu/master/master-path-handlers.cc File

[kudu-CR] KUDU-501 Redirect to leader master web UI

2017-09-14 Thread Will Berkeley (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8068 to look at the new patch set (#2). Change subject: KUDU-501 Redirect to leader master web UI .. KUDU-501 Redirect

[kudu-CR] Add mustache template for /table

2017-09-14 Thread Will Berkeley (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8067 to look at the new patch set (#2). Change subject: Add mustache template for /table .. Add mustache template for

[kudu-CR] Add mustache template for /table

2017-09-14 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: Add mustache template for /table .. Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/8067/1/src/kudu/master/master-path-handlers.cc File

[kudu-CR] KUDU-2144. Add metrics for Reactor load

2017-09-14 Thread Todd Lipcon (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8064 to look at the new patch set (#2). Change subject: KUDU-2144. Add metrics for Reactor load .. KUDU-2144. Add

[kudu-CR] KUDU-1807 (part 2): ban GetTableSchema for table createdness in clients

2017-09-14 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: KUDU-1807 (part 2): ban GetTableSchema for table createdness in clients .. Patch Set 2: (1 comment)

[kudu-CR] KUDU-501 Redirect to leader master web UI

2017-09-14 Thread Will Berkeley (Code Review)
Will Berkeley has uploaded a new change for review. http://gerrit.cloudera.org:8080/8068 Change subject: KUDU-501 Redirect to leader master web UI .. KUDU-501 Redirect to leader master web UI The /table and /tables page of

[kudu-CR] Add mustache template for /table

2017-09-14 Thread Will Berkeley (Code Review)
Will Berkeley has uploaded a new change for review. http://gerrit.cloudera.org:8080/8067 Change subject: Add mustache template for /table .. Add mustache template for /table As a run-up to improving the web ui experience