Re: Review Request 37669: Ignore overflow components in version parsing.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37669/#review96980 --- Ship it! Ship It! - Timothy Chen On Aug. 22, 2015, 5:04 p.m., ha

Re: Review Request 37669: Ignore overflow components in version parsing.

> On Aug. 28, 2015, 7:32 p.m., Bernd Mathiske wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/version.hpp, line 59 > > > > > > "allowed" and "would" are not quite right. > > > > Suggested phrasing

Re: Review Request 37914: Updated the ReviewBot to flag reviews that do not contain reviewers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37914/#review96977 --- Patch looks great! Reviews applied: [37914] All tests passed. - M

Re: Review Request 37913: Improve allocator filtering by keeping per-slave filter sets.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37913/#review96976 --- Patch looks great! Reviews applied: [37913] All tests passed. - M

Re: Review Request 37908: Silence oversubscription logging

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37908/#review96974 --- Patch looks great! Reviews applied: [37908] All tests passed. - M

Re: Review Request 37531: MESOS-3070

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37531/ --- (Updated Aug. 29, 2015, 1:13 a.m.) Review request for mesos and Vinod Kone. C

Re: Review Request 37114: MESOS-3187, support docker host command line option

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37114/ --- (Updated Aug. 29, 2015, 1:11 a.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 37541: Add TraceEvent API

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37541/#review96969 --- Patch looks great! Reviews applied: [37540, 37541] All tests passe

Review Request 37914: Updated the ReviewBot to flag reviews that do not contain reviewers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37914/ --- Review request for mesos, Benjamin Hindman and Michael Park. Repository: mesos

Re: Review Request 37364: Maintenance Primitives: Adds an endpoint for retrieving the maintenance status for machines.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37364/ --- (Updated Aug. 28, 2015, 5:04 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 37773: Docker: Adding registry client.

> On Aug. 28, 2015, 11:03 p.m., Lily Chen wrote: > > src/slave/containerizer/provisioners/docker/registry_client.cpp, line 465 > > > > > > Same issue with path naming as with getManifest Please see https://docs.dock

Re: Review Request 37773: Docker: Adding registry client.

> On Aug. 28, 2015, 6:46 p.m., Timothy Chen wrote: > > src/slave/containerizer/provisioners/docker/registry_client.hpp, line 150 > > > > > > Do we need to define static here if it's not being used anywhere else > >

Re: Review Request 37773: Docker: Adding registry client.

> On Aug. 28, 2015, 11:03 p.m., Lily Chen wrote: > > src/slave/containerizer/provisioners/docker/registry_client.cpp, line 409 > > > > > > I think path may be misleading, can we name this repo? https://docs.docker.c

Re: Review Request 37773: Docker: Adding registry client.

> On Aug. 28, 2015, 11:03 p.m., Lily Chen wrote: > > src/slave/containerizer/provisioners/docker/registry_client.cpp, line 415 > > > > > > can we do a path::join here? It would be hard to get the "/"s correct > > ju

Re: Review Request 37814: Added documentation for libprocess environment variables

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37814/#review96958 --- Patch looks great! Reviews applied: [37814] All tests passed. - M

Re: Review Request 37773: Docker: Adding registry client.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37773/#review96957 --- src/slave/containerizer/provisioners/docker/registry_client.cpp (li

Re: Review Request 37907: Libevent: Used `evutil_gettimeofday` to implement `time()`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37907/#review96955 --- Ship it! Are there any libevent benchmark tests that we can validat

Re: Review Request 37913: Improve allocator filtering by keeping per-slave filter sets.

> On Aug. 28, 2015, 11:44 p.m., Neil Conway wrote: > > Diff seems weird -- maybe needs a rebase. Thanks ... rebased again and it looks better now :) - James --- This is an automatically generated e-mail. To reply, visit: https://reviews

Re: Review Request 37913: Improve allocator filtering by keeping per-slave filter sets.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37913/ --- (Updated Aug. 28, 2015, 11:46 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 37913: Improve allocator filtering by keeping per-slave filter sets.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37913/#review96952 --- Diff seems weird -- maybe needs a rebase. - Neil Conway On Aug. 2

Review Request 37913: Improve allocator filtering by keeping per-slave filter sets.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37913/ --- Review request for mesos and Ben Mahler. Bugs: MESOS-3052 https://issues.ap

Re: Review Request 37908: Silence oversubscription logging

> On Aug. 28, 2015, 3:42 p.m., Jie Yu wrote: > > src/slave/slave.cpp, lines 4240-4248 > > > > > > Hum, why zero is a special case here? What if the RE initially returns > > 10cpus, and due to some reaons, it return

Re: Review Request 37362: Maintenance Primitives: Adds an endpoint for transitioning agents back into UP mode.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37362/ --- (Updated Aug. 28, 2015, 4:20 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 37541: Add TraceEvent API

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37541/ --- (Updated Aug. 28, 2015, 11:07 p.m.) Review request for mesos, Chi Zhang, Ian Do

Re: Review Request 37881: Implemented AppcProvisioner.

> On Aug. 28, 2015, 12:59 p.m., Jie Yu wrote: > > src/slave/containerizer/provisioners/appc.cpp, lines 79-97 > > > > > > Some high level comments. > > > > I think it will be beneficial if we can move the fetc

Re: Review Request 37540: Add PerfEvent API

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37540/ --- (Updated Aug. 28, 2015, 11:06 p.m.) Review request for mesos, Chi Zhang, Ian Do

Re: Review Request 37114: MESOS-3187, support docker host command line option

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37114/#review96945 --- src/docker/docker.hpp (line 45)

Re: Review Request 37773: Docker: Adding registry client.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37773/#review96932 --- src/slave/containerizer/provisioners/docker/registry_client.cpp (li

Re: Review Request 37881: Implemented AppcProvisioner.

> On Aug. 28, 2015, 7:59 p.m., Jie Yu wrote: > > src/slave/flags.cpp, lines 72-76 > > > > > > Why do you still need this flag? > > Jiang Yan Xu wrote: > We instantiate all supported backends but this flag specifi

Re: Review Request 37358: Maintenance Primitives: Adds an endpoint for transitioning agents into the DOWN mode.

> On Aug. 27, 2015, 10:02 p.m., Benjamin Hindman wrote: > > src/master/maintenance.cpp, lines 237-239 > > > > > > It seems weird to make this an error ... why is it a prerequisite that > > validation of a MachineInf

Re: Review Request 37907: Libevent: Used `evutil_gettimeofday` to implement `time()`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37907/#review96943 --- Patch looks great! Reviews applied: [37907] All tests passed. - M

Re: Review Request 37908: Silence oversubscription logging

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37908/#review96940 --- src/slave/slave.cpp (line 4226)

Re: Review Request 37881: Implemented AppcProvisioner.

> On Aug. 28, 2015, 12:59 p.m., Jie Yu wrote: > > src/slave/flags.cpp, lines 72-76 > > > > > > Why do you still need this flag? > > Jiang Yan Xu wrote: > We instantiate all supported backends but this flag specif

Re: Review Request 37358: Maintenance Primitives: Adds an endpoint for transitioning agents into the DOWN mode.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37358/ --- (Updated Aug. 28, 2015, 3:32 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 37814: Added documentation for libprocess environment variables

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37814/ --- (Updated Aug. 28, 2015, 10:25 p.m.) Review request for mesos, Alexander Rojas a

Re: Review Request 37881: Implemented AppcProvisioner.

> On Aug. 28, 2015, 7:59 p.m., Jie Yu wrote: > > src/slave/flags.cpp, lines 72-76 > > > > > > Why do you still need this flag? > > Jiang Yan Xu wrote: > We instantiate all supported backends but this flag specifi

Review Request 37908: Silence oversubscription logging

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37908/ --- Review request for mesos and Jie Yu. Repository: mesos Description --- R

Re: Review Request 37881: Implemented AppcProvisioner.

> On Aug. 28, 2015, 7:59 p.m., Jie Yu wrote: > > src/slave/containerizer/provisioners/appc.cpp, lines 79-97 > > > > > > Some high level comments. > > > > I think it will be beneficial if we can move the fetch

Review Request 37907: Libevent: Used `evutil_gettimeofday` to implement `time()`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37907/ --- Review request for mesos, Benjamin Hindman and Vinod Kone. Bugs: MESOS-3189

Re: Review Request 37881: Implemented AppcProvisioner.

> On Aug. 28, 2015, 12:59 p.m., Jie Yu wrote: > > src/slave/containerizer/provisioner.cpp, lines 43-46 > > > > > > I would love to get this TODO solved in this patch. It should be pretty > > straightfoward, right? Ju

Re: Review Request 37325: Maintenance Primitives: Adds an endpoint for scheduling agents for maintenance.

> On Aug. 26, 2015, 11:05 p.m., Alexander Rukletsov wrote: > > Not a full review, mostly nit-picks. Will do a second pass. Awesome. Thanks! - Joseph --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache

Re: Review Request 37325: Maintenance Primitives: Adds an endpoint for scheduling agents for maintenance.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37325/ --- (Updated Aug. 28, 2015, 2:37 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 37903: stout: Fix bug in IPNetwork::create() with zero prefix.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37903/#review96934 --- Patch looks great! Reviews applied: [37903] All tests passed. - M

Re: Review Request 37900: Maintenance Primitives: Add helper functions for the maintenance protobufs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37900/ --- (Updated Aug. 28, 2015, 2:07 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 37621: Maintenance Primitives: Gracefully handle inverse offers in pre-V1 scheduler.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37621/#review96930 --- Ship it! src/sched/sched.cpp (line 525)

Re: Review Request 37284: Maintenance Primitives: Added support for Accept / Decline of InverseOffers in master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37284/#review96928 --- Ship it! Ship It! - Benjamin Hindman On Aug. 26, 2015, 2:13 a.m.

Re: Review Request 37283: Maintenance Primitives: Refactored Master maintenance test to use V1 API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37283/#review96925 --- Ship it! src/tests/master_maintenance_tests.cpp (line 82)

Re: Review Request 37234: Maintenance Primitives: Added URL field to InverseOffer proto.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37234/#review96924 --- Ship it! Ship It! - Benjamin Hindman On Aug. 26, 2015, 2:13 a.m.

Re: Review Request 37282: Maintenance Primitives: Added InverseOffer to V1 API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37282/#review96923 --- Ship it! Looks like this stuff is actually needed for https://revi

Re: Review Request 37180: Maintenance Primitives: Implemented Master::inverseOffer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37180/#review96921 --- Ship it! src/master/master.cpp (line 4144)

Re: Review Request 37280: Maintenance Primitives: Added updateInverseOffer to Allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37280/#review96917 --- Ship it! include/mesos/master/allocator.hpp (line 147)

Re: Review Request 37282: Maintenance Primitives: Added InverseOffer to V1 API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37282/#review96916 --- Maybe you can kill this entire review however given my comments belo

Re: Review Request 37178: Maintenance Primitives: Added InverseOffers to Scheduler Event Offers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37178/#review96915 --- Ship it! Ship It! - Benjamin Hindman On Aug. 26, 2015, 2:12 a.m.

Re: Review Request 37582: Maintenance Primitives: Add test for the hierarchical DRF allocator sending inverse offers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37582/#review96914 --- Ship it! src/tests/hierarchical_allocator_tests.cpp (line 474)

Re: Review Request 37900: Maintenance Primitives: Add helper functions for the maintenance protobufs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37900/#review96912 --- Ship it! src/master/maintenance.hpp (line 48)

Re: Review Request 37900: Maintenance Primitives: Add helper functions for the maintenance protobufs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37900/#review96913 --- Patch looks great! Reviews applied: [37655, 36321, 36571, 37314, 37

Review Request 37903: stout: Fix bug in IPNetwork::create() with zero prefix.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37903/ --- Review request for mesos. Bugs: MESOS-3328 https://issues.apache.org/jira/b

Re: Review Request 37881: Implemented AppcProvisioner.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37881/#review96903 --- src/slave/containerizer/provisioner.cpp (line 27)

Re: Review Request 37669: Ignore overflow components in version parsing.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37669/#review96878 --- 3rdparty/libprocess/3rdparty/stout/include/stout/version.hpp (line

Re: Review Request 37900: Maintenance Primitives: Add helper functions for the maintenance protobufs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37900/ --- (Updated Aug. 28, 2015, 12:15 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 37773: Docker: Adding registry client.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37773/#review96908 --- Patch looks great! Reviews applied: [37871, 37427, 37773] All test

Review Request 37900: Maintenance Primitives: Add helper functions for the maintenance protobufs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37900/ --- Review request for mesos, Benjamin Hindman, Ben Mahler, Artem Harutyunyan, Joris

Re: Review Request 37773: Docker: Adding registry client.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37773/#review96907 --- I have a feeling we can remove all the promises usage in this review

Re: Review Request 37773: Docker: Adding registry client.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37773/#review96905 --- src/slave/containerizer/provisioners/docker/registry_client.hpp (li

Re: Review Request 36908: Added QuotaInfo Protobuf.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36908/#review96906 --- include/mesos/master/quota.proto (line 38)

Re: Review Request 37773: Docker: Adding registry client.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37773/ --- (Updated Aug. 28, 2015, 6:38 p.m.) Review request for mesos, Lily Chen and Timo

Re: Review Request 37773: Docker: Adding registry client.

> On Aug. 28, 2015, 5:21 p.m., Lily Chen wrote: > > src/slave/containerizer/provisioners/docker/registry_client.hpp, line 34 > > > > > > No need for provisioners namespace, see appc example of > > mesos::internal::sl

Re: Review Request 37427: Docker registry: adding TokenManager.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37427/ --- (Updated Aug. 28, 2015, 6:36 p.m.) Review request for mesos, Lily Chen, Joris V

Re: Review Request 37871: SSL tests refactoring

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37871/ --- (Updated Aug. 28, 2015, 6:35 p.m.) Review request for mesos, Joris Van Remoorte

Re: Review Request 37894: Renamed cgroups::kill to cgroups::signal.

> On Aug. 28, 2015, 4:45 p.m., Cong Wang wrote: > > Why? Everyone knows kill(2) sends a signal while signal(2) installs a > > signal handler... > > Jie Yu wrote: > IMO, that naming is confusing, and should be 'signal' and 'install'. > > Joerg Schad wrote: > This is actually answering a

Re: Review Request 36620: Added Non-Freezeer Task Killer.

> On Aug. 27, 2015, 7:02 p.m., Jie Yu wrote: > > src/linux/cgroups.cpp, lines 1776-1791 > > > > > > Could you please introduce a new function under cgroups namespace and > > put this logic there: > > > >

Re: Review Request 37827: Added a test for converting JSON arrays to repeated protobufs.

> On Aug. 27, 2015, 5:51 p.m., Joseph Wu wrote: > > 3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.cpp, lines 179-181 > > > > > > From the method name, I think it's not completely obvious what the type > >

Re: Review Request 37314: Maintenance Primitives: Populate master's maintenance-related local state upon recovery from registry.

> On Aug. 28, 2015, 8:19 a.m., Joris Van Remoortere wrote: > > include/mesos/type_utils.hpp, line 158 > > > > > > You have this on a new line to call it out for readability right? It > > would fit above otherwise.

Re: Review Request 37314: Maintenance Primitives: Populate master's maintenance-related local state upon recovery from registry.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37314/ --- (Updated Aug. 28, 2015, 10:38 a.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 36571: Maintenance Primitives: Add maintenance-related, registry protobufs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36571/ --- (Updated Aug. 28, 2015, 10:25 a.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 37773: Docker: Adding registry client.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37773/#review96896 --- src/slave/containerizer/provisioners/docker/registry_client.hpp (li

Re: Review Request 37894: Renamed cgroups::kill to cgroups::signal.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37894/#review96897 --- Patch looks great! Reviews applied: [37894] All tests passed. - M

Re: Review Request 36571: Maintenance Primitives: Add maintenance-related, registry protobufs.

> On Aug. 28, 2015, 8:12 a.m., Joris Van Remoortere wrote: > > include/mesos/mesos.proto, line 160 > > > > > > `a slave` or `an agent` ? Since I added Machine* to the v1 API, I just used "slave" in one, and "agent"

Re: Review Request 36571: Maintenance Primitives: Add maintenance-related, registry protobufs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36571/ --- (Updated Aug. 28, 2015, 10:20 a.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 36321: Maintenance primitives: Add Unavailability and InverseOffer protobufs.

> On Aug. 28, 2015, 7:49 a.m., Joris Van Remoortere wrote: > > include/mesos/mesos.proto, line 877 > > > > > > In your last diff, you changed a bunch of `window` to `interval`. Do > > you want to change this one

Re: Review Request 36321: Maintenance primitives: Add Unavailability and InverseOffer protobufs.

> On Aug. 27, 2015, 1:06 p.m., Benjamin Hindman wrote: > > include/mesos/mesos.proto, lines 926-927 > > > > > > Why do we need the URL? Can we comment for folks so they know what they > > might need/use this for?

Re: Review Request 36321: Maintenance primitives: Add Unavailability and InverseOffer protobufs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36321/ --- (Updated Aug. 28, 2015, 10:11 a.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 37427: Docker registry: adding TokenManager.

> On Aug. 28, 2015, 12:18 a.m., Timothy Chen wrote: > > src/slave/containerizer/provisioners/docker/token_manager.hpp, line 223 > > > > > > Is there a reason you need to include this in the header? Can we just > >

Re: Review Request 36620: Added Non-Freezeer Task Killer.

> On Aug. 27, 2015, 7:02 p.m., Jie Yu wrote: > > src/linux/cgroups.cpp, lines 1776-1791 > > > > > > Could you please introduce a new function under cgroups namespace and > > put this logic there: > > > >

Re: Review Request 37894: Renamed cgroups::kill to cgroups::signal.

> On Aug. 28, 2015, 4:45 p.m., Cong Wang wrote: > > Why? Everyone knows kill(2) sends a signal while signal(2) installs a > > signal handler... > > Jie Yu wrote: > IMO, that naming is confusing, and should be 'signal' and 'install'. > > Joerg Schad wrote: > This is actually answering a

Re: Review Request 37894: Renamed cgroups::kill to cgroups::signal.

> On Aug. 28, 2015, 4:45 p.m., Cong Wang wrote: > > Why? Everyone knows kill(2) sends a signal while signal(2) installs a > > signal handler... > > Jie Yu wrote: > IMO, that naming is confusing, and should be 'signal' and 'install'. This is actually answering a discussion here https://rev

Re: Review Request 37894: Renamed cgroups::kill to cgroups::signal.

> On Aug. 28, 2015, 4:45 p.m., Cong Wang wrote: > > Why? Everyone knows kill(2) sends a signal while signal(2) installs a > > signal handler... IMO, that naming is confusing, and should be 'signal' and 'install'. - Jie --- This is an a

Re: Review Request 37894: Renamed cgroups::kill to cgroups::signal.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37894/#review96883 --- Why? Everyone knows kill(2) sends a signal while signal(2) installs

Review Request 37894: Renamed cgroups::kill to cgroups::signal.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37894/ --- Review request for mesos, Jie Yu, Till Toenshoff, and Timothy Chen. Bugs: MESOS

Re: Review Request 37892: Renamed cgroups::kill to cgroups::signal

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37892/ --- (Updated Aug. 28, 2015, 4:29 p.m.) Review request for mesos. Bugs: MESOS-3086

Re: Review Request 37892: Renamed cgroups::kill to cgroups::signal

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37892/ --- (Updated Aug. 28, 2015, 4:12 p.m.) Review request for mesos. Bugs: MESOS-3086

Re: Review Request 37427: Docker registry: adding TokenManager.

> On Aug. 28, 2015, 7:56 a.m., Timothy Chen wrote: > > src/slave/containerizer/provisioners/docker/token_manager.cpp, line 223 > > > > > > If you put the cache here in TokenManager instead of > > TokenManagerProces

Review Request 37892: Renamed cgroups::kill to cgroups::signal

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37892/ --- Review request for mesos. Bugs: MESOS-3086 https://issues.apache.org/jira/b

Re: Review Request 36620: Added Non-Freezeer Task Killer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36620/#review96872 --- src/linux/cgroups.cpp (line 1676)

Re: Review Request 37891: Fetcher now does not erroneously report a non-archive when extracting from one.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37891/ --- (Updated Aug. 28, 2015, 8:51 a.m.) Review request for mesos, Adam B, Benjamin H

Re: Review Request 36620: Added Non-Freezeer Task Killer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36620/ --- (Updated Aug. 28, 2015, 3:48 p.m.) Review request for mesos, Benjamin Hindman,

Review Request 37891: Fetcher now does not erroneously report a non-archive when extracting from one.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37891/ --- Review request for mesos, Adam B, Benjamin Hindman, Till Toenshoff, and Timothy

Re: Review Request 37314: Maintenance Primitives: Populate master's maintenance-related local state upon recovery from registry.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37314/#review96870 --- Ship it! include/mesos/type_utils.hpp (line 153)

Re: Review Request 36571: Maintenance Primitives: Add maintenance-related, registry protobufs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36571/#review96868 --- Ship it! include/mesos/maintenance/maintenance.proto (line 56)

Re: Review Request 36620: Added Non-Freezeer Task Killer.

> On Aug. 27, 2015, 7:02 p.m., Jie Yu wrote: > > src/linux/cgroups.cpp, lines 1776-1791 > > > > > > Could you please introduce a new function under cgroups namespace and > > put this logic there: > > > >

  1   2   >