Re: Review Request 50841: Added GPU scheduling logic to docker containerizer process.

> On 十月 9, 2016, 5:16 a.m., Guangya Liu wrote: > > src/slave/containerizer/docker.cpp, lines 2105-2109 > > > > > > Not yours, but I think that the comments can be removed as we have the > > logic of killing those

Review Request 52732: Made mesos-containerizer launch helper inherit agent env variables.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52732/ --- Review request for mesos, Gilbert Song and Kevin Klues. Bugs: MESOS-6323

Review Request 52731: Added 'environment' flag to mesos-containerizer launch helper.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52731/ --- Review request for mesos, Gilbert Song and Kevin Klues. Bugs: MESOS-6323

Review Request 52729: Made execvp explicit in posix/shell.hpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52729/ --- Review request for mesos, Gilbert Song and Kevin Klues. Bugs: MESOS-6323

Review Request 52730: Added an abstraction for Envp pointer expected by exec routines.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52730/ --- Review request for mesos, Gilbert Song and Kevin Klues. Bugs: MESOS-6323

Re: Review Request 52092: Avoided to concat cgroup internally in subsystems.

> On Oct. 10, 2016, 4:57 p.m., Jie Yu wrote: > > Is it up-to-date? Can you do a base and I'll get this committed. Rebase. - haosdent --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 52092: Avoided to concat cgroup internally in subsystems.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52092/ --- (Updated Oct. 11, 2016, 3:53 a.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 52667: Added mesos test helper 'createCommandInfo()'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52667/#review152089 --- src/tests/mesos.hpp (lines 449 - 461)

Re: Review Request 52716: Added mesos test helper 'createV1Task()'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52716/#review152091 --- src/tests/mesos.hpp (lines 559 - 564)

Re: Review Request 52715: Added a test helper 'createV1ExecutorInfo()'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52715/#review152090 --- src/tests/mesos.hpp (line 446)

Re: Review Request 52718: Added v1 api helpers to create calls in 'tests/mesos.hpp'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52718/#review152093 --- Thanks for introducing these test helpers Gilbert. These would be

Re: Review Request 52612: Added nested container tests for docker runtime isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52612/ --- (Updated Oct. 10, 2016, 6:15 p.m.) Review request for mesos, Anand Mazumdar,

Review Request 52717: Added mesos test helper 'createV1ContainerInfo()'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52717/ --- Review request for mesos, Anand Mazumdar, Jie Yu, and Vinod Kone. Repository:

Review Request 52715: Added a test helper 'createV1ExecutorInfo()'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52715/ --- Review request for mesos, Anand Mazumdar, Jie Yu, and Vinod Kone. Repository:

Review Request 52718: Added v1 api helpers to create calls in 'tests/mesos.hpp'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52718/ --- Review request for mesos, Anand Mazumdar, Jie Yu, and Vinod Kone. Repository:

Review Request 52714: Added optional 'Type' to createExecutorInfo().

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52714/ --- Review request for mesos, Anand Mazumdar, Jie Yu, and Vinod Kone. Repository:

Review Request 52716: Added mesos test helper 'createV1Task()'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52716/ --- Review request for mesos, Anand Mazumdar, Jie Yu, and Vinod Kone. Repository:

Re: Review Request 52668: Refactored nested container tests launcher orphans.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52668/ --- (Updated Oct. 10, 2016, 6:14 p.m.) Review request for mesos, Benjamin Hindman

Review Request 52713: Added evolve helper for ContainerInfo.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52713/ --- Review request for mesos, Anand Mazumdar, Jie Yu, and Vinod Kone. Repository:

Re: Review Request 52667: Added mesos test helper 'createCommandInfo()'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52667/ --- (Updated Oct. 10, 2016, 6:14 p.m.) Review request for mesos, Benjamin Hindman

Review Request 52723: Changed agent to report TASK_DROPPED during reconciliation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52723/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-6332

Review Request 52721: Fixed typo in log message.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52721/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-6332

Review Request 52720: Clarified a comment.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52720/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-6332

Review Request 52719: Renamed a function for clarity.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52719/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-6332

Re: Review Request 52311: Pass the user value from executor of switch_user flag is set.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52311/#review152088 --- src/slave/slave.cpp (line 4197)

Re: Review Request 52309: Pass the user variable from library to binary.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52309/#review152087 --- Fix it, then Ship it! Once these last few things are tweaked,

Re: Review Request 52310: Switch the uid of the binary if a user is passed from the lib_logrotate.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52310/#review152086 --- Fix it, then Ship it! Once this last comment is tweaked, this

Re: Review Request 52680: Used full docker image name to force pull a iamge.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52680/#review152074 --- Ship it! This looks right to me, I'll Jie comment and merge

Review Request 52680: Used full docker image name to force pull a iamge.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52680/ --- Review request for mesos, Jie Yu and Timothy Chen. Repository: mesos

Review Request 52707: Updated CLI bootstrap to search for local virtualenv installations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52707/ --- Review request for mesos, Artem Harutyunyan, Kevin Klues, and Vinod Kone.

Re: Review Request 50674: Stout: Enabled tests that pass on Windows.

> On Aug. 2, 2016, 11:15 p.m., Joseph Wu wrote: > > 3rdparty/stout/tests/flags_tests.cpp, lines 231-235 > > > > > > This test will build on Windows, right? > > > > If so, you should prepend `DISABLED_`

Re: Review Request 50674: Stout: Enabled tests that pass on Windows.

> On Aug. 2, 2016, 11:15 p.m., Joseph Wu wrote: > > 3rdparty/stout/tests/flags_tests.cpp, lines 231-235 > > > > > > This test will build on Windows, right? > > > > If so, you should prepend `DISABLED_`

Review Request 52706: Updated mesos containerizer to use new 'stout/wait.hpp' header.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52706/ --- Review request for mesos and Jie Yu. Bugs: MESOS-6310

Review Request 52705: Added 'stout/wait.hpp' header.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52705/ --- Review request for mesos and Jie Yu. Bugs: MESOS-6310

Re: Review Request 50674: Stout: Enabled tests that pass on Windows.

> On Aug. 2, 2016, 11:15 p.m., Joseph Wu wrote: > > 3rdparty/stout/tests/flags_tests.cpp, lines 231-235 > > > > > > This test will build on Windows, right? > > > > If so, you should prepend `DISABLED_`

Re: Review Request 52596: Added special case when sorting hierarchically in MountInfoTable::read.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52596/ --- (Updated Oct. 10, 2016, 8:50 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 50737: Parametrized libprocess HTTPTests by SSL configuration.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50737/ --- (Updated Oct. 10, 2016, 8:50 p.m.) Review request for mesos, Anand Mazumdar,

Review Request 52703: Added test to test corner case with sorted 'MountInfoTable::read()'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52703/ --- Review request for mesos and Jie Yu. Bugs: MESOS-6118

Review Request 52704: Refactored 'MountInfoTable::read()' into two separate functions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52704/ --- Review request for mesos and Jie Yu. Bugs: MESOS-6118

Re: Review Request 52597: Added more detailed error message when failing in MountInfoTable::read.

> On Oct. 7, 2016, 5:03 p.m., Jie Yu wrote: > > src/linux/fs.cpp, lines 141-143 > > > > > > Does this compile? > > Kevin Klues wrote: > Interestingly yes... > > Though I see why you think it shouldn't

Re: Review Request 52696: Harden stout

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52696/ --- (Updated Oct. 10, 2016, 7:53 p.m.) Review request for mesos and Michael Park.

Re: Review Request 52695: Harden libprocess

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52695/ --- (Updated Oct. 10, 2016, 7:52 p.m.) Review request for mesos and Michael Park.

Re: Review Request 52645: Harden Mesos

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52645/ --- (Updated Oct. 10, 2016, 7:50 p.m.) Review request for mesos and Michael Park.

Re: Review Request 40512: Libprocess Reinit: Add a test-only method to reinitialize libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40512/#review152055 --- Fix it, then Ship it! 3rdparty/libprocess/src/process.cpp

Re: Review Request 52620: Updated InverseOffers* maintenance tests to use the new scheduler mock.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52620/#review152054 --- Ship it! LGTM - Anand Mazumdar On Oct. 10, 2016, 7:18 p.m.,

Re: Review Request 40268: Libprocess Reinit: Change Socket::DEFAULT_KIND to a non-static value.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40268/#review152053 --- Ship it! Ship It! - Vinod Kone On July 29, 2016, 11:59

Re: Review Request 40413: Libprocess Reinit: Move ReaperProcess instantiation into process.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40413/#review152048 --- Fix it, then Ship it!

Re: Review Request 40410: Libprocess Reinit: Move MetricsProcess instantiation into process.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40410/#review152051 --- 3rdparty/libprocess/include/process/metrics/metrics.hpp (lines

Re: Review Request 40410: Libprocess Reinit: Move MetricsProcess instantiation into process.cpp.

> On Oct. 10, 2016, 12:22 p.m., Vinod Kone wrote: > > 3rdparty/libprocess/src/metrics/metrics.cpp, line 106 > > > > > > so MetricsProcess was not managed by gc before? was that a bug? It was never cleaned up and

Re: Review Request 40410: Libprocess Reinit: Move MetricsProcess instantiation into process.cpp.

> On Oct. 10, 2016, 7:22 p.m., Vinod Kone wrote: > > 3rdparty/libprocess/include/process/metrics/metrics.hpp, line 95 > > > > > > we don't name other global processes singletons, so i would just call > > this

Re: Review Request 40411: Libprocess Reinit: Modify test to use PID.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40411/#review152047 --- Ship it! LGTM modulo naming of "metrics_singleton" - Vinod

Re: Review Request 40410: Libprocess Reinit: Move MetricsProcess instantiation into process.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40410/#review152045 --- Fix it, then Ship it!

Re: Review Request 52620: Updated InverseOffers* maintenance tests to use the new scheduler mock.

> On Oct. 7, 2016, 11:51 p.m., Anand Mazumdar wrote: > > src/tests/master_maintenance_tests.cpp, lines 1169-1171 > > > > > > We prefer to keep expectations close to the actual business logic for > > readability.

Re: Review Request 52620: Updated InverseOffers* maintenance tests to use the new scheduler mock.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52620/ --- (Updated Oct. 10, 2016, 8:18 p.m.) Review request for mesos and Anand

Re: Review Request 52695: Harden libprocess

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52695/#review152028 --- 3rdparty/libprocess/Makefile.am (line 16)

Re: Review Request 50737: Parametrized libprocess HTTPTests by SSL configuration.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50737/#review151905 --- 3rdparty/libprocess/src/tests/http_tests.cpp (line 257)

Re: Review Request 52064: Support for multiple versions of docs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52064/#review152043 --- what's the status of this? - Vinod Kone On Sept. 28, 2016,

Re: Review Request 52645: Harden Mesos

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52645/#review152042 --- I will leave comments about requiring GCC 4.9 to people who are

Review Request 52701: WIP: Enhanced error messages for HTTP parsing errors.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52701/ --- Review request for mesos, Benjamin Mahler, Greg Mann, and Artem Harutyunyan.

Re: Review Request 52664: Moved the `decimalFloat` filter to app.js for consistency.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52664/#review152041 --- Ship it! Ship It! - Vinod Kone On Oct. 8, 2016, 6:10 p.m.,

Re: Review Request 52470: Set executor id in `protobuf::createTask`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52470/#review152034 --- I think it's probably worth to just mutate TaskInfo like you did

Re: Review Request 52638: Populated `recovered` field in `GetAgents` response.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52638/#review152036 --- Would you be following up with the change to `/state` in a

Re: Review Request 52637: Added recovered `AgentID`s in `GetAgents` response.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52637/#review152019 --- Can you also update the review description to be more informative

Re: Review Request 50912: Added the infrastructure for a new python-based CLI.

> On Oct. 5, 2016, 5:36 p.m., Vinod Kone wrote: > > src/cli_new/bin/main.py, line 22 > > > > > > why the space? > > > > also alphabetical ordering. This separates standard python libraries from local

Re: Review Request 52645: Harden Mesos

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52645/ --- (Updated Oct. 10, 2016, 6:16 p.m.) Review request for mesos and Michael Park.

Re: Review Request 52645: Harden Mesos

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52645/ --- (Updated Oct. 10, 2016, 6:13 p.m.) Review request for mesos and Michael Park.

Re: Review Request 52645: Harden Mesos

> On Oct. 10, 2016, 5:32 p.m., James Peach wrote: > > configure.ac, line 460 > > > > > > GCC 4.9 is in devtoolset-3 for RHEL 6, so I think this is fine. IMHO it > > is still worth giving the mailing list a heads-up

Re: Review Request 50910: Added a python linter to mesos-style.cpp.

> On Oct. 4, 2016, 5:18 p.m., Joseph Wu wrote: > > support/mesos-style.py, lines 270-272 > > > > > > It may help to change the order of reviews (no rebase necessary, just > > the "depends on" field). > > > >

Re: Review Request 45963: Allow tasks to set persistent volume as readonly or readwrite resource.

> On Oct. 7, 2016, 5:49 p.m., Greg Mann wrote: > > src/examples/persistent_shared_volume_framework.cpp, line 191 > > > > > > s/used/uses/ It looks like this typo is still present? Or perhaps you meant to drop the

Re: Review Request 52689: Fixed a typo in CMakeLists.txt.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52689/#review152018 --- Ship it! Ship It! - Joseph Wu On Oct. 10, 2016, 5:59 a.m.,

Re: Review Request 52617: Improved symmetry of code in related utility functions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52617/#review152016 --- Ship it! Ship It! - Joseph Wu On Oct. 6, 2016, 2:37 p.m.,

Re: Review Request 52618: Added comment describing a common gotcha.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52618/#review152017 --- Ship it! Ship It! - Joseph Wu On Oct. 6, 2016, 2:37 p.m.,

Re: Review Request 52616: Fixed whitespace infelicities.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52616/#review152015 --- Ship it! Ship It! - Joseph Wu On Oct. 6, 2016, 2:37 p.m.,

Re: Review Request 52645: Harden Mesos

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52645/#review152008 --- configure.ac (line 460)

Re: Review Request 52208: Fixed warnings in health_checker.cpp.

> On Oct. 10, 2016, 8:25 a.m., Alexander Rukletsov wrote: > > src/health-check/health_checker.cpp, line 179 > > > > > > Why haven't you used `Duration::create()`? Didn't realize that existed :) That does look

Re: Review Request 51999: Refactor parsing of resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51999/#review152010 --- Fix it, then Ship it! Committing with the following

Re: Review Request 52690: Added 3rdparty build byproducts to cmake setup.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52690/#review152009 --- Patch looks great! Reviews applied: [52690] Passed command:

Re: Review Request 52556: Added the MESOS_RUNTIME_DIRECTORY executor env variable.

> On Oct. 10, 2016, 8:32 a.m., Jiang Yan Xu wrote: > > src/launcher/executor.cpp, lines 903-910 > > > > > > You didn't start this but I wonder why we can't consistently use the > > flags, which can be provided

Re: Review Request 52092: Avoided to concat cgroup internally in subsystems.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52092/#review152004 --- Is it up-to-date? Can you do a base and I'll get this committed.

Re: Review Request 52556: Added the MESOS_RUNTIME_DIRECTORY executor env variable.

> On Oct. 10, 2016, 3:32 p.m., Jiang Yan Xu wrote: > > src/launcher/executor.cpp, lines 903-910 > > > > > > You didn't start this but I wonder why we can't consistently use the > > flags, which can be provided

Re: Review Request 52647: Fix new errors/warnings produced by hardened flags

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52647/ --- (Updated Oct. 10, 2016, 3:51 p.m.) Review request for mesos and Michael Park.

Re: Review Request 51719: Permitted specifying custom test driver in stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51719/#review151994 --- Fix it, then Ship it! Ship It! 3rdparty/stout/configure.ac

Re: Review Request 51718: Permitted specifying custom test driver in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51718/#review151992 --- Fix it, then Ship it! Ship It!

Review Request 52696: Harden stout

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52696/ --- Review request for mesos and Michael Park. Bugs: MESOS-6229

Review Request 52695: Harden libprocess

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52695/ --- Review request for mesos and Michael Park. Bugs: MESOS-6229

Re: Review Request 52645: Harden Mesos

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52645/ --- (Updated Oct. 10, 2016, 3:42 p.m.) Review request for mesos and Michael Park.

Re: Review Request 52645: Harden Mesos

On Oct. 7, 2016, 10:15 p.m., Aaron Wood wrote: > > (1) Do we need to make the `CXXFLAGS` conditional on being supported by the > > current compiler? Seems like these flags are quite specific to (certain > > versions of?) gcc/clang. > > > > (2) You should split this review into three separate

Re: Review Request 52626: Ensured allocations are processed before querying metrics in a test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52626/#review151991 --- Ship it! Ship It! - Michael Park On Oct. 7, 2016, 9:43

Re: Review Request 52556: Added the MESOS_RUNTIME_DIRECTORY executor env variable.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52556/#review151918 --- src/launcher/executor.cpp (lines 903 - 910)

Re: Review Request 51717: Enable Mesos test runner.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51717/#review151989 --- Fix it, then Ship it! Ship It! src/Makefile.am (line 2343)

Re: Review Request 51716: Added configure option for Mesos test runner.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51716/#review151988 --- Fix it, then Ship it! Ship It! configure.ac (lines 616 -

Re: Review Request 52208: Fixed warnings in health_checker.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52208/#review151986 --- src/health-check/health_checker.cpp (line 179)

Re: Review Request 51715: Added a parallel gtest runner.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51715/#review151984 --- Fix it, then Ship it! Looks very good guys - thanks Kevin for

Review Request 52693: Changed master to send TASK_UNKNOWN during reconciliation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52693/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-6330

Re: Review Request 52676: Made stout's tests a phony target.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52676/#review151982 --- Patch looks great! Reviews applied: [52676] Passed command:

Re: Review Request 52563: Minor clean ups in `health_check_tests.cpp` for consistency.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52563/#review151981 --- src/tests/health_check_tests.cpp (line 231)

Re: Review Request 52561: Renamed `flags` to `agentFlags` in health check test cases.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52561/#review151980 --- src/tests/health_check_tests.cpp (line 376)

Re: Review Request 52556: Added the MESOS_RUNTIME_DIRECTORY executor env variable.

> On Oct. 6, 2016, 3:40 p.m., Alexander Rukletsov wrote: > > Please add support for > > * docker executor > > * pod (default) executor > > Gastón Kleiman wrote: > The default executor has no use for this env variable yet. Should I add > it as an unused attribute in the `DefaultExecutor`

Review Request 52689: Fixed a typo in CMakeLists.txt.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52689/ --- Review request for mesos and Joseph Wu. Repository: mesos Description

Review Request 52690: Added 3rdparty build byproducts to cmake setup.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52690/ --- Review request for mesos and Joseph Wu. Bugs: MESOS-5656

  1   2   >