Re: Review Request 19143: Catch errors thrown by authentication modules.

2014-03-13 Thread Joshua Cohen
) be responsible for catching the appropriate exception types and re-raising as auth errors if necessary, or is there really no way of narrowing this down to only auth errors? - Joshua Cohen On March 12, 2014, 10:59 p.m., Mark Chu-Carroll wrote

Review Request 25108: Fix default logger in command runner.

2014-08-27 Thread Joshua Cohen
, Joshua Cohen

Re: Review Request 25108: Fix default logger in command runner.

2014-08-27 Thread Joshua Cohen
-mail. To reply, visit: https://reviews.apache.org/r/25108/#review51709 --- On Aug. 27, 2014, 6:40 p.m., Joshua Cohen wrote: --- This is an automatically generated e-mail. To reply

Re: Review Request 25158: Aurora Update UI

2014-08-28 Thread Joshua Cohen
bound for size (and an upper bound for overall vertical hiehgt) and simply let each box represent multiple instances? - Joshua Cohen On Aug. 28, 2014, 6:13 p.m., David McLaughlin wrote: --- This is an automatically generated e-mail

Review Request 25206: Fix aurora run in end to end tests.

2014-08-29 Thread Joshua Cohen
/test/sh/org/apache/aurora/e2e/test_end_to_end.sh Unfortunately the v2 client end to end tests are currently broken (filed https://issues.apache.org/jira/browse/AURORA-677), but I verified that the test for aurora task run works in that script as well. Thanks, Joshua Cohen

Re: Review Request 25255: Implement server-driven update commands.

2014-09-02 Thread Joshua Cohen
boilerplate. - Joshua Cohen On Sept. 2, 2014, 4:36 p.m., Mark Chu-Carroll wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25255

Re: Review Request 25257: Add a separate main class that runs the scheduler in local mode.

2014-09-02 Thread Joshua Cohen
On Sept. 2, 2014, 6:31 p.m., Joshua Cohen wrote: src/test/java/org/apache/aurora/scheduler/app/local/FakeMaster.java, lines 134-135 https://reviews.apache.org/r/25257/diff/1/?file=674033#file674033line134 Any way to avoid magic numbers here (and would it be worthwhile

Re: Review Request 25206: Fix aurora run in end to end tests.

2014-09-03 Thread Joshua Cohen
)? - Joshua --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25206/#review52121 --- On Aug. 29, 2014, 11:17 p.m., Joshua Cohen wrote

Re: Review Request 25297: Make config-file an optional parameter for job restart.

2014-09-03 Thread Joshua Cohen
out to a separate function that's reused by both and documenting the reasoning there? src/test/sh/org/apache/aurora/e2e/test_end_to_end_v2.sh https://reviews.apache.org/r/25297/#comment90940 Kill trailing whitespace? - Joshua Cohen On Sept. 3, 2014, 2:07 p.m., Mark Chu-Carroll wrote

Re: Review Request 25285: Upgrade to latest in jetty 7.x series.

2014-09-03 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25285/#review52186 --- Ship it! Ship It! - Joshua Cohen On Sept. 3, 2014, 5:23 a.m

Re: Review Request 25300: Add a state machine to react to job update status changes.

2014-09-03 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25300/#review52193 --- Ship it! Ship It! - Joshua Cohen On Sept. 3, 2014, 4:02 p.m

Re: Review Request 25206: Fix aurora run in end to end tests.

2014-09-03 Thread Joshua Cohen
verified that the test for aurora task run works in that script as well. Thanks, Joshua Cohen

Re: Review Request 25206: Fix aurora run in end to end tests.

2014-09-03 Thread Joshua Cohen
/browse/AURORA-677), but I verified that the test for aurora task run works in that script as well. Thanks, Joshua Cohen

Re: Review Request 25206: Fix aurora run in end to end tests.

2014-09-03 Thread Joshua Cohen
to have the e2e tests fixed before I ship https://reviews.apache.org/r/25208/ Joshua Cohen wrote: It defaults to 'aurora run', for the aurora1 client, but we pass in 'aurora2 job run' from the test_end_to_end_v2.sh script. Are you saying to switch the default (or maybe I should just remove

Re: Review Request 25206: Fix aurora run in end to end tests.

2014-09-03 Thread Joshua Cohen
--- On Sept. 3, 2014, 6:33 p.m., Joshua Cohen wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25206

Re: Review Request 25206: Fix aurora run in end to end tests.

2014-09-03 Thread Joshua Cohen
for aurora task run works in that script as well. Thanks, Joshua Cohen

Re: Review Request 25206: Fix aurora run in end to end tests.

2014-09-03 Thread Joshua Cohen
broken (filed https://issues.apache.org/jira/browse/AURORA-677), but I verified that the test for aurora task run works in that script as well. Thanks, Joshua Cohen

Review Request 25319: Tweak contributors doc to add details on finding newbie issues.

2014-09-03 Thread Joshua Cohen
: https://reviews.apache.org/r/25319/diff/ Testing --- Thanks, Joshua Cohen

Re: Review Request 25357: Adding support for per-job task status metrics.

2014-09-04 Thread Joshua Cohen
/apache/aurora/scheduler/TaskVars.java https://reviews.apache.org/r/25357/#comment91130 use host (declared above) here in place of task.getAssignedTask().getSlaveHost()? - Joshua Cohen On Sept. 4, 2014, 9:42 p.m., Maxim Khutornenko wrote

Review Request 25361: Update vagrant provisioning and aurorabuild scripts to remove the need to sudo to run build commands in the vagrant image.

2014-09-04 Thread Joshua Cohen
Thanks, Joshua Cohen

Review Request 25365: Update slave url to use the thermos port.

2014-09-04 Thread Joshua Cohen
/aurora/scheduler/http/slaves.st defe1c5ececc8d742c78e52b9c43bebebba401ea Diff: https://reviews.apache.org/r/25365/diff/ Testing --- Ran scheduler, verified updated url. Thanks, Joshua Cohen

Re: Review Request 25366: Set principal field in FrameworkInfo struct.

2014-09-04 Thread Joshua Cohen
a get call, not sure if there's any downside there to the implicit string conversion done by getProperty). - Joshua Cohen On Sept. 4, 2014, 11:16 p.m., Zameer Manji wrote: --- This is an automatically generated e-mail. To reply, visit

Re: Review Request 25366: Set principal field in FrameworkInfo struct.

2014-09-04 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25366/#review52377 --- Ship it! Ship It! - Joshua Cohen On Sept. 4, 2014, 11:36 p.m

Review Request 25398: Make the offer hold jitter window configurable.

2014-09-05 Thread Joshua Cohen
/ Testing --- gradle -Pq build Thanks, Joshua Cohen

Re: Review Request 25319: Tweak contributors doc to add details on finding newbie issues.

2014-09-05 Thread Joshua Cohen
(updated) - docs/contributing.md 44512c273e5f24c2b9352b3a817c2a1bb5996ce4 Diff: https://reviews.apache.org/r/25319/diff/ Testing --- Thanks, Joshua Cohen

Re: Review Request 25398: Make the offer hold jitter window configurable.

2014-09-05 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25398/#review52514 --- On Sept. 5, 2014, 9:30 p.m., Joshua Cohen wrote

Re: Review Request 25398: Make the offer hold jitter window configurable.

2014-09-08 Thread Joshua Cohen
https://reviews.apache.org/r/25398/#comment91463 Should these be @Positive instead (i.e. do we want to allow for a zero hold time/jitter window)? - Joshua Cohen On Sept. 8, 2014, 5:54 p.m., Joshua Cohen wrote

Re: Review Request 25398: Make the offer hold jitter window configurable.

2014-09-08 Thread Joshua Cohen
--- gradle -Pq build Thanks, Joshua Cohen

Re: Review Request 25398: Make the offer hold jitter window configurable.

2014-09-08 Thread Joshua Cohen
--- gradle -Pq build Thanks, Joshua Cohen

Re: Review Request 25398: Make the offer hold jitter window configurable.

2014-09-08 Thread Joshua Cohen
. - Joshua --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25398/#review52630 --- On Sept. 8, 2014, 9:09 p.m., Joshua Cohen wrote

Re: Review Request 25398: Make the offer hold jitter window configurable.

2014-09-08 Thread Joshua Cohen
/ Testing --- gradle -Pq build Thanks, Joshua Cohen

Re: Review Request 25398: Make the offer hold jitter window configurable.

2014-09-09 Thread Joshua Cohen
/25398/diff/ Testing --- gradle -Pq build Thanks, Joshua Cohen

Re: Review Request 25398: Make the offer hold jitter window configurable.

2014-09-09 Thread Joshua Cohen
, 2014, 4:54 p.m., Joshua Cohen wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25398/ --- (Updated Sept. 9, 2014, 4:54 p.m

Review Request 25548: Apply GzipFilter to POSTs as well as GETs

2014-09-11 Thread Joshua Cohen
: gzip -X POST -d @- \ http://192.168.33.7:8081/api EOF |tr '\r' '\n' |grep Content-Encoding |awk '{print $2}' \ |tr '[:upper:]' '[:lower]' [1,getJobSummary,1,0,{1:{str:vagrant}}] EOF gzip Thanks, Joshua Cohen

Re: Review Request 25552: Show reason for PENDING state in Scheduler UI

2014-09-11 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25552/#review53123 --- Ship it! Ship It! - Joshua Cohen On Sept. 11, 2014, 9:55 p.m

Re: Review Request 25529: Add a controller for job updates.

2014-09-11 Thread Joshua Cohen
, is there danger in the addition of additional statuses in the future rendering that assumption invalid?) - Joshua Cohen On Sept. 11, 2014, 4:53 a.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request 25582: Fix error in client task ssh command when the job isn't found.

2014-09-12 Thread Joshua Cohen
On Sept. 12, 2014, 5:09 p.m., Joe Smith wrote: src/test/python/apache/aurora/client/cli/test_task_run.py, line 228 https://reviews.apache.org/r/25582/diff/1/?file=687672#file687672line228 Test the ssh command for proper behavior when no tasks are found within a job or something,

Re: Review Request 25259: Add update information to the scheduler UI

2014-09-12 Thread Joshua Cohen
about passing subset in as a param to isSubset instead of picking it up via a closure? - Joshua Cohen On Sept. 9, 2014, 11:50 p.m., David McLaughlin wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request 25593: Use a ServletContextListener to configure servlets

2014-09-12 Thread Joshua Cohen
/JettyServerModule.java https://reviews.apache.org/r/25593/#comment92730 Obviously not related, but should these all use Objects.requireNonNull instead of Preconditions.checkNotNull? - Joshua Cohen On Sept. 12, 2014, 9:28 p.m., Kevin Sweeney wrote

Re: Review Request 25593: Use a ServletContextListener to configure servlets

2014-09-12 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25593/#review53226 --- Ship it! Ship It! - Joshua Cohen On Sept. 12, 2014, 9:43 p.m

Re: Review Request 25259: Add update information to the scheduler UI

2014-09-15 Thread Joshua Cohen
now! src/main/resources/org/apache/aurora/scheduler/http/ui/js/services.js https://reviews.apache.org/r/25259/#comment93077 Nitpick: I'd name this subset param so it doesn't collide w/ the subset var above, just for extra future-safety. - Joshua Cohen On Sept. 15, 2014, 6:53 p.m., David

Re: Review Request 25529: Add a controller for job updates.

2014-09-15 Thread Joshua Cohen
the config validation logic from the UpdateFactory creation? - Joshua Cohen On Sept. 15, 2014, 7:40 p.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25529

Re: Review Request 25721: Asynchronous JS for Scheduler UI

2014-09-17 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25721/#review53733 --- Ship it! Ship It! - Joshua Cohen On Sept. 17, 2014, 5:49 p.m

Re: Review Request 25791: Save instance update events when updating a job.

2014-09-18 Thread Joshua Cohen
/JobUpdateControllerImpl.java https://reviews.apache.org/r/25791/#comment93729 Do we have any sort of guidelines on using Preconditions.checkNotNull vs Objects.requireNonNull, or should it always be the latter? - Joshua Cohen On Sept. 18, 2014, 8:14 p.m., Bill Farner wrote

Re: Review Request 25794: Add a mock scheduler client to the AuroraClient service

2014-09-18 Thread Joshua Cohen
to swap out responses by replacing the mock data on disk...). - Joshua Cohen On Sept. 18, 2014, 9:38 p.m., David McLaughlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25794

Review Request 25835: Serve HTTP assets out of a standard classpath root.

2014-09-19 Thread Joshua Cohen
the image to see if that cleans things up. Thanks, Joshua Cohen

Re: Review Request 25835: Serve HTTP assets out of a standard classpath root.

2014-09-19 Thread Joshua Cohen
., Joshua Cohen wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25835/ --- (Updated Sept. 19, 2014, 6:41 p.m.) Review request

Re: Review Request 25835: Serve HTTP assets out of a standard classpath root.

2014-09-19 Thread Joshua Cohen
On Sept. 19, 2014, 6:58 p.m., Bill Farner wrote: Ran locally, looks like assets are no longer gzip-encoded. Does that repro for you? Joshua Cohen wrote: Hmm, I didn't verify that explicitly, but the gzip encoding tests passed, so I assumed we were ok on that front. I'll take

Re: Review Request 25835: Serve HTTP assets out of a standard classpath root.

2014-09-19 Thread Joshua Cohen
UI in vagrant image. One thing I've seen locally is lost tasks in vagrant, but I *think* that's just due to my image being somehow misconfigured, and not these changes. I'm going to destroy and rebuild the image to see if that cleans things up. Thanks, Joshua Cohen

Re: Review Request 25835: Serve HTTP assets out of a standard classpath root.

2014-09-19 Thread Joshua Cohen
line (request for /js/angular.js returns a 404) even though it's passing in IntelliJ. So that's neat. - Joshua Cohen On Sept. 19, 2014, 8:45 p.m., Joshua Cohen wrote: --- This is an automatically generated e-mail. To reply, visit

Re: Review Request 25835: Serve HTTP assets out of a standard classpath root.

2014-09-19 Thread Joshua Cohen
works in scheduler UI in vagrant image. One thing I've seen locally is lost tasks in vagrant, but I *think* that's just due to my image being somehow misconfigured, and not these changes. I'm going to destroy and rebuild the image to see if that cleans things up. Thanks, Joshua Cohen

Re: Review Request 25835: Serve HTTP assets out of a standard classpath root.

2014-09-19 Thread Joshua Cohen
files to the same directory. You need to do a git clean and try again. On Fri, Sep 19, 2014 at 2:24 PM, Joshua Cohen jco...@twopensource.com wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org

Re: Review Request 25913: HTML Grid Fixes in Scheduler UI

2014-09-22 Thread Joshua Cohen
to include screenshots comparable to those in the ticket showing the proper alignment? - Joshua Cohen On Sept. 22, 2014, 11:23 p.m., David McLaughlin wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request 25963: Expose in progress and recently completed updates in UI

2014-09-24 Thread Joshua Cohen
the data source). Does angular have partials or something similar so we can avoid replicating this? - Joshua Cohen On Sept. 23, 2014, 11:46 p.m., David McLaughlin wrote: --- This is an automatically generated e-mail. To reply, visit

Re: Review Request 25963: Expose in progress and recently completed updates in UI

2014-09-24 Thread Joshua Cohen
/org/apache/aurora/scheduler/http/ui/latestUpdates.html https://reviews.apache.org/r/25963/#comment94608 Nit: should we parameterize this to maintain the previous distinction between in progress vs completed? - Joshua Cohen On Sept. 24, 2014, 9:46 p.m., David McLaughlin wrote

Re: Review Request 25963: Expose in progress and recently completed updates in UI

2014-09-24 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25963/#review54474 --- Ship it! Ship It! - Joshua Cohen On Sept. 24, 2014, 10:52 p.m

Re: Review Request 26095: Fix instance summary visualisation.

2014-09-26 Thread Joshua Cohen
://reviews.apache.org/r/26095/#comment95006 As far as I can see, allInstances is only used here to get the length, can we just make this: var totalInstancesToBeUpdated = Object.keys(updateUtil.getAllInstanceIds(details.update).allIds).length - Joshua Cohen On Sept. 26, 2014, 7:55 p.m., David

Re: Review Request 26123: Fail the build on lack of test coverage.

2014-09-27 Thread Joshua Cohen
of the desired behavior for someone adding new code to a legacy class but not adding code coverage because it means writing tests for the entire class as part of their change. - Joshua Cohen On Sept. 27, 2014, 11:25 p.m., Bill Farner wrote

Re: Review Request 25835: Serve HTTP assets out of a standard classpath root.

2014-09-29 Thread Joshua Cohen
for assets that were added mid-development). The third commit is us forking the graphview resources from twitter commons The fourth/final commit is the bulk of the actual code changes to get everything working. - Joshua Cohen On Sept. 19, 2014, 9:39 p.m., Joshua Cohen wrote

Re: Review Request 26095: Fix instance summary visualisation.

2014-09-29 Thread Joshua Cohen
On Sept. 26, 2014, 8:19 p.m., Joshua Cohen wrote: src/main/resources/org/apache/aurora/scheduler/http/ui/js/services.js, line 440 https://reviews.apache.org/r/26095/diff/1/?file=706256#file706256line440 As far as I can see, allInstances is only used here to get the length, can

Re: Review Request 26095: Fix instance summary visualisation.

2014-09-29 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26095/#review54833 --- Ship it! Looks good to me. - Joshua Cohen On Sept. 29, 2014, 4

Re: Review Request 26123: Fail the build on lack of test coverage.

2014-09-29 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26123/#review54908 --- Ship it! Thanks for clarifying the assert message. - Joshua Cohen

Re: Review Request 25835: Serve HTTP assets out of a standard classpath root.

2014-09-30 Thread Joshua Cohen
-aurora/commit/e5d9194992b2789b0ebfc7ac0495b575604ccc6b - Joshua Cohen On Sept. 19, 2014, 9:39 p.m., Joshua Cohen wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25835

Re: Review Request 26269: Remove UI from page titles.

2014-10-02 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26269/#review55212 --- Ship it! Ship It! - Joshua Cohen On Oct. 2, 2014, 3:48 p.m

Review Request 26320: Skip checkstyle on python file in 3rdparty.

2014-10-03 Thread Joshua Cohen
://reviews.apache.org/r/26320/diff/ Testing --- Committed file w/ precommit hook in place. Thanks, Joshua Cohen

Re: Review Request 25835: Serve HTTP assets out of a standard classpath root.

2014-10-03 Thread Joshua Cohen
, 9:39 p.m., Joshua Cohen wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25835/ --- (Updated Sept. 19, 2014, 9:39 p.m

Re: Review Request 26320: Skip checkstyle on python file in 3rdparty.

2014-10-06 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26320/#review55511 --- *ping* Kevin. - Joshua Cohen On Oct. 3, 2014, 4:51 p.m., Joshua

Re: Review Request 26363: Make the large-update check in the client update command consider instance parameters.

2014-10-06 Thread Joshua Cohen
in... many (all?) of these tests. Can you refactor to remove the repetition? - Joshua Cohen On Oct. 6, 2014, 2:57 p.m., Mark Chu-Carroll wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26363

Re: Review Request 26378: Upgrade to pants 0.0.24

2014-10-06 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26378/#review55595 --- Ship it! Ship It! - Joshua Cohen On Oct. 6, 2014, 7:53 p.m

Review Request 26424: Disable requests http connection logging.

2014-10-07 Thread Joshua Cohen
c722eae2d04dec90e9c772f49c578184a2bdf76c Diff: https://reviews.apache.org/r/26424/diff/ Testing --- Added hokey test, ran hokey test. Also verified the lack of http connection logs when running client commands directly. Thanks, Joshua Cohen

Re: Review Request 26424: Disable requests http connection logging.

2014-10-07 Thread Joshua Cohen
commands directly. Thanks, Joshua Cohen

Re: Review Request 26424: Disable requests http connection logging.

2014-10-08 Thread Joshua Cohen
/python/apache/aurora/common/test_transport.py c722eae2d04dec90e9c772f49c578184a2bdf76c Diff: https://reviews.apache.org/r/26424/diff/ Testing --- Added hokey test, ran hokey test. Also verified the lack of http connection logs when running client commands directly. Thanks, Joshua Cohen

Re: Review Request 26383: Health Check Disabler

2014-10-08 Thread Joshua Cohen
I'm +1 on removing the time control as well. If you need to extend the snooze you could always touch -m the snooze file? On Wed, Oct 8, 2014 at 9:51 AM, Bill Farner wfar...@apache.org wrote: On Oct. 6, 2014, 10:40 p.m., Brian Wickman wrote: docs/configuration-reference.md, lines 359-360

Re: Review Request 26320: Skip checkstyle on python file in 3rdparty.

2014-10-08 Thread Joshua Cohen
On Oct. 6, 2014, 4:33 p.m., Joshua Cohen wrote: *ping* Kevin. *ping* again. Once this ships the static assets changes from https://github.com/jcohen/incubator-aurora/commits/jcohen/static-assets (reviewed at https://reviews.apache.org/r/25835/) should be mergeable. - Joshua

Re: Review Request 26320: Skip checkstyle on python file in 3rdparty.

2014-10-08 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26320/#review55847 --- On Oct. 3, 2014, 4:51 p.m., Joshua Cohen wrote

Re: Review Request 26363: Make the large-update check in the client update command consider instance parameters.

2014-10-08 Thread Joshua Cohen
On Oct. 6, 2014, 4:44 p.m., Joshua Cohen wrote: src/test/python/apache/aurora/client/cli/test_update.py, lines 342-353 https://reviews.apache.org/r/26363/diff/1/?file=714123#file714123line342 This sequence of mocks and writing config to a file is repeated in... many (all

Re: Review Request 26464: Blacklist org/apache/aurora/scheduler/http/api/ApiBeta$2 which has no coverage.

2014-10-08 Thread Joshua Cohen
that we're just fixing a symptom of the problem, and not the problem itself (i.e. we're going to be adding random classes to the legacy list despite their actually having coverage). - Joshua Cohen On Oct. 8, 2014, 11:09 p.m., Zameer Manji wrote

Re: Review Request 26464: Blacklist org/apache/aurora/scheduler/http/api/ApiBeta$2 which has no coverage.

2014-10-08 Thread Joshua Cohen
On Oct. 8, 2014, 11:50 p.m., Joshua Cohen wrote: This doesn't actually fail when I run it locally. I'm worried that we're just fixing a symptom of the problem, and not the problem itself (i.e. we're going to be adding random classes to the legacy list despite their actually having

Review Request 26469: Kill code to serve ApiBeta help pages that's no longer used now that the content is served directly.

2014-10-08 Thread Joshua Cohen
-Type: text/html Vary: Accept-Encoding Content-Length: 0 Server: Jetty(7.6.15.v20140411) Thanks, Joshua Cohen

Re: Review Request 26464: Blacklist org/apache/aurora/scheduler/http/api/ApiBeta$2 which has no coverage.

2014-10-08 Thread Joshua Cohen
On Oct. 8, 2014, 11:50 p.m., Joshua Cohen wrote: This doesn't actually fail when I run it locally. I'm worried that we're just fixing a symptom of the problem, and not the problem itself (i.e. we're going to be adding random classes to the legacy list despite their actually having

Re: Review Request 26469: Kill code to serve ApiBeta help pages that's no longer used now that the content is served directly.

2014-10-09 Thread Joshua Cohen
you see that one as well? - Bill On October 9th, 2014, 12:15 a.m. UTC, Joshua Cohen wrote: Review request for Aurora, Bill Farner and Zameer Manji. By Joshua Cohen. *Updated Oct. 9, 2014, 12:15 a.m.* *Repository: * aurora Description Kill code to serve ApiBeta help pages that's

Re: Review Request 26469: Kill code to serve ApiBeta help pages that's no longer used now that the content is served directly.

2014-10-09 Thread Joshua Cohen
I can also verify that running the entire test suite in a debugger, a breakpoint set in OfferQueue$OfferQueueImpl$2 is not hit. On Thu, Oct 9, 2014 at 10:05 AM, Joshua Cohen jco...@twopensource.com wrote: Nope, it's passing for me, but it's similar to the behavior I was seeing with ApiBeta$2

Re: Review Request 26504: Restore JDK8 compatibility

2014-10-09 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26504/#review56011 --- Ship it! Ship It! - Joshua Cohen On Oct. 9, 2014, 4:50 p.m

Re: Review Request 26469: Kill code to serve ApiBeta help pages that's no longer used now that the content is served directly.

2014-10-09 Thread Joshua Cohen
report if needed. On Thu, Oct 9, 2014 at 10:42 AM, Bill Farner wfar...@apache.org wrote: Can you post your xml report to a ticket? It might help get to the bottom of this flakiness. On Thursday, October 9, 2014, Joshua Cohen jco...@twopensource.com wrote: I can also verify that running

Re: Review Request 26383: Health Check Disabler

2014-10-09 Thread Joshua Cohen
I feel like we should err on the side of correctness here, rather than simplicity? The dangers of someone accidentally leaving health checks disabled indefinitely (on a service that has opted in to health checks) are not insignificant. On Thu, Oct 9, 2014 at 1:34 PM, Kevin Sweeney

Re: Review Request 26383: Health Check Disabler

2014-10-09 Thread Joshua Cohen
On Oct. 9, 2014, 2:53 p.m., Bill Farner wrote: src/main/python/apache/aurora/executor/common/health_checker.py, line 66 https://reviews.apache.org/r/26383/diff/3/?file=716355#file716355line66 FWIW i actually meant to suggest that the snooze has no concept of time at all. If the

Re: Review Request 26531: Defining schema for the heartbeat RPC.

2014-10-10 Thread Joshua Cohen
://reviews.apache.org/r/26531/#comment96529 This doesn't match the doc you sent out? Shouldn't this just be one of [OK, STOP, ERRROR]? (JobUpdateStatus has a much wider set of values of which only ERROR is included) - Joshua Cohen On Oct. 9, 2014, 11:23 p.m., Maxim Khutornenko wrote

Re: Review Request 26574: Handle anonymous inner classes better in per-class coverage check.

2014-10-10 Thread Joshua Cohen
to externalize it[1], rather than having build.gradle take on more and more logic? [1] http://www.gradle.org/docs/current/userguide/custom_tasks.html - Joshua Cohen On Oct. 10, 2014, 9:41 p.m., Bill Farner wrote

Re: Review Request 26574: Handle anonymous inner classes better in per-class coverage check.

2014-10-10 Thread Joshua Cohen
about organizing build.gradle. - Joshua Cohen On Oct. 10, 2014, 9:41 p.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26574

Re: Review Request 26688: Fix errors in help rendering:

2014-10-14 Thread Joshua Cohen
that just says int rather than str? - Joshua Cohen On Oct. 14, 2014, 3:07 p.m., Mark Chu-Carroll wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26688

Re: Review Request 26711: Fix bad function call in thermos_task_runner.

2014-10-14 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26711/#review56594 --- Ship it! Ship It! - Joshua Cohen On Oct. 14, 2014, 10:53 p.m

Re: Review Request 26424: Disable requests http connection logging.

2014-10-14 Thread Joshua Cohen
On Oct. 15, 2014, 12:02 a.m., Bill Farner wrote: Sorry for the delay on this, i didn't realize i was on the hook to commit. Now on master: $ git log -1 commit 72fed752fcdbacf0f29e7eaef56c177f5ec9fcf0 Author: Joshua Cohen jco...@twopensource.com Date: Tue Oct 14

Re: Review Request 26714: Remove use of the getVersion RPC from the client.

2014-10-15 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26714/#review56809 --- Ship it! Ship It! - Joshua Cohen On Oct. 15, 2014, 6:48 p.m

Re: Review Request 26688: Fix errors in help rendering:

2014-10-15 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26688/#review56811 --- Ship it! Ship It! - Joshua Cohen On Oct. 15, 2014, 5:57 p.m

Re: Review Request 26664: Deprecating SANDBOX_DELETED task state.

2014-10-15 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26664/#review56813 --- Ship it! Ship It! - Joshua Cohen On Oct. 13, 2014, 11:22 p.m

Re: Review Request 26790: Fix redirect loop when accessing rewritten paths.

2014-10-16 Thread Joshua Cohen
Diff: https://reviews.apache.org/r/26790/diff/ Testing --- ./gradlew build -Pq Also started up multiple schedulers in vagrant image and confirmed that I'm properly redirected when accessing the non-leading scheduler. Thanks, Joshua Cohen

Re: Review Request 26821: Handle resourceOffers callback asynchronsly.

2014-10-16 Thread Joshua Cohen
https://reviews.apache.org/r/26821/#comment97432 nit, move to previous line. src/main/java/org/apache/aurora/scheduler/MesosSchedulerImpl.java https://reviews.apache.org/r/26821/#comment97433 s/Augment/augment - Joshua Cohen On Oct. 16, 2014, 8:26 p.m., Zameer Manji wrote

Review Request 26834: Add client cluster configuration docs.

2014-10-16 Thread Joshua Cohen
://reviews.apache.org/r/26834/diff/ Testing --- Rendered here: https://github.com/jcohen/incubator-aurora/blob/jcohen/docs/clusters.json/docs/client-cluster-configuration.md Thanks, Joshua Cohen

Re: Review Request 26834: Add client cluster configuration docs.

2014-10-16 Thread Joshua Cohen
On Oct. 16, 2014, 11:03 p.m., Joshua Cohen wrote: docs/client-cluster-configuration.md, line 34 https://reviews.apache.org/r/26834/diff/1/?file=723472#file723472line34 I think an argument could be made for removing this configuration entirely and just hardcoding

Review Request 26841: Describe how to clone the git repo to contributing docs.

2014-10-16 Thread Joshua Cohen
/incubator-aurora/blob/jcohen/docs/howtocontribute-git/docs/contributing.md Thanks, Joshua Cohen

  1   2   3   4   >