[Impala-ASF-CR] IMPALA-6314: Add run time scalar subquery check for uncorrelated subqueries

2018-02-22 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/9005 ) Change subject: IMPALA-6314: Add run time scalar subquery check for uncorrelated subqueries .. Patch Set 9: (1 comment)

[Impala-ASF-CR] IMPALA-6553: [DOCS] load catalog in background default change

2018-02-22 Thread Balazs Jeszenszky (Code Review)
Balazs Jeszenszky has posted comments on this change. ( http://gerrit.cloudera.org:8080/9389 ) Change subject: IMPALA-6553: [DOCS] load_catalog_in_background default change .. Patch Set 3: (3 comments) Add commit comment?

[Impala-ASF-CR] IMPALA-6542: Fix inconsistent write path of Parquet min/max statistics

2018-02-22 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/9381 ) Change subject: IMPALA-6542: Fix inconsistent write path of Parquet min/max statistics .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-6542: Fix inconsistent write path of Parquet min/max statistics

2018-02-22 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/9381 ) Change subject: IMPALA-6542: Fix inconsistent write path of Parquet min/max statistics .. Patch Set 3: (1 comment) Thanks for the

[Impala-ASF-CR] IMPALA-6341, IMPALA-5917: Reduce mem-limit for start-impala-cluster.

2018-02-22 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/9395 ) Change subject: IMPALA-6341, IMPALA-5917: Reduce mem-limit for start-impala-cluster. .. Patch Set 1: Code-Review+1 Would still be good to

[Impala-ASF-CR] IMPALA-6347: Monitor queue depth size for outgoing RPCs for Reactor threads

2018-02-22 Thread Sailesh Mukil (Code Review)
Hello Michael Ho, Lars Volker, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9384 to look at the new patch set (#2). Change subject: IMPALA-6347: Monitor queue depth size for outgoing RPCs for Reactor threads

[Impala-ASF-CR] IMPALA-6347: Monitor queue depth size for outgoing RPCs for Reactor threads

2018-02-22 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/9384 ) Change subject: IMPALA-6347: Monitor queue depth size for outgoing RPCs for Reactor threads .. Patch Set 2: (3 comments)

[Impala-ASF-CR] IMPALA-6553: [DOCS] load catalog in background default change

2018-02-22 Thread Alex Rodoni (Code Review)
Hello John Russell, Balazs Jeszenszky, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9389 to look at the new patch set (#4). Change subject: IMPALA-6553: [DOCS] load_catalog_in_background default change

[Impala-ASF-CR] IMPALA-6553: [DOCS] load catalog in background default change

2018-02-22 Thread Alex Rodoni (Code Review)
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/9389 ) Change subject: IMPALA-6553: [DOCS] load_catalog_in_background default change .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-6553: [DOCS] load catalog in background default change

2018-02-22 Thread Alex Rodoni (Code Review)
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/9389 ) Change subject: IMPALA-6553: [DOCS] load_catalog_in_background default change .. Patch Set 3: (2 comments)

[Impala-ASF-CR] IMPALA-4835: Part 3: switch I/O buffers to buffer pool

2018-02-22 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/8966 ) Change subject: IMPALA-4835: Part 3: switch I/O buffers to buffer pool .. Patch Set 22: Code-Review+2 (2 comments)

[Impala-ASF-CR] IMPALA-6347: Monitor queue depth size for outgoing RPCs for Reactor threads

2018-02-22 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9384 ) Change subject: IMPALA-6347: Monitor queue depth size for outgoing RPCs for Reactor threads .. Patch Set 2: (4 comments)

[Impala-ASF-CR] IMPALA-5752: Add support for DECIMAL on Kudu tables

2018-02-22 Thread Grant Henke (Code Review)
Hello Thomas Tauber-Marshall, Taras Bobrovytsky, Dimitris Tsirogiannis, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9368 to look at the new patch set (#8). Change subject: IMPALA-5752: Add support for DECIMAL on Kudu tables

[Impala-ASF-CR] KUDU-2301: (Part-1) Add instrumentation on a per connection level

2018-02-22 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/9383 ) Change subject: KUDU-2301: (Part-1) Add instrumentation on a per connection level .. Patch Set 1: > This patch isn't merged on the

[Impala-ASF-CR] IMPALA-5752: Add support for DECIMAL on Kudu tables

2018-02-22 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/9368 ) Change subject: IMPALA-5752: Add support for DECIMAL on Kudu tables .. Patch Set 8: Code-Review+1 I think you just need Dimitris' +2 and

[Impala-ASF-CR] IMPALA-6549: Enable file handle cache by default

2018-02-22 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/9371 ) Change subject: IMPALA-6549: Enable file handle cache by default .. Patch Set 2: Code-Review+2 Thanks. I'm fine with merging it as long as

[Impala-ASF-CR] IMPALA-6341, IMPALA-5917: Reduce mem-limit for start-impala-cluster.

2018-02-22 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/9395 ) Change subject: IMPALA-6341, IMPALA-5917: Reduce mem-limit for start-impala-cluster. .. Patch Set 1: I see this happening in

[Impala-ASF-CR] IMPALA-6542: Fix inconsistent write path of Parquet min/max statistics

2018-02-22 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/9381 ) Change subject: IMPALA-6542: Fix inconsistent write path of Parquet min/max statistics .. Patch Set 2: (3 comments)

[Impala-ASF-CR] IMPALA-6542: Fix inconsistent write path of Parquet min/max statistics

2018-02-22 Thread Zoltan Borok-Nagy (Code Review)
Hello Lars Volker, Gabor Kaszab, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9381 to look at the new patch set (#3). Change subject: IMPALA-6542: Fix inconsistent write path of Parquet min/max statistics

[Impala-ASF-CR] IMPALA-6341, IMPALA-5917: Reduce mem-limit for start-impala-cluster.

2018-02-22 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9395 ) Change subject: IMPALA-6341, IMPALA-5917: Reduce mem-limit for start-impala-cluster. .. Patch Set 1: (1 comment) I'm ok with this so

[Impala-ASF-CR] IMPALA-6537: Add missing ODBC scalar functions

2018-02-22 Thread Greg Rahn (Code Review)
Greg Rahn has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/9376 ) Change subject: IMPALA-6537: Add missing ODBC scalar functions .. IMPALA-6537: Add missing ODBC scalar functions This patch contains the

[Impala-ASF-CR] IMPALA-6341, IMPALA-5917: Reduce mem-limit for start-impala-cluster.

2018-02-22 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9395 Change subject: IMPALA-6341, IMPALA-5917: Reduce mem-limit for start-impala-cluster. .. IMPALA-6341, IMPALA-5917: Reduce mem-limit

[Impala-ASF-CR] IMPALA-5752: Add support for DECIMAL on Kudu tables

2018-02-22 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/9368 ) Change subject: IMPALA-5752: Add support for DECIMAL on Kudu tables .. Patch Set 8: Note: This patch passes all tests and is ready for

[Impala-ASF-CR] IMPALA-4167: Support insert plan hints for CREATE TABLE AS SELECT

2018-02-22 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8400 ) Change subject: IMPALA-4167: Support insert plan hints for CREATE TABLE AS SELECT .. Patch Set 17: Build started:

[Impala-ASF-CR] IMPALA-4167: Support insert plan hints for CREATE TABLE AS SELECT

2018-02-22 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/8400 ) Change subject: IMPALA-4167: Support insert plan hints for CREATE TABLE AS SELECT .. Patch Set 17: Code-Review+2 Thanks for pointing out

[Impala-ASF-CR] IMPALA-6549: Enable file handle cache by default

2018-02-22 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/9371 ) Change subject: IMPALA-6549: Enable file handle cache by default .. Patch Set 3: Code-Review+2 Rebased. Carry +2 -- To view, visit

[Impala-ASF-CR] IMPALA-4167: Support insert plan hints for CREATE TABLE AS SELECT

2018-02-22 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8400 ) Change subject: IMPALA-4167: Support insert plan hints for CREATE TABLE AS SELECT .. Patch Set 17: Verified+1 -- To view,

[Impala-ASF-CR] IMPALA-4167: Support insert plan hints for CREATE TABLE AS SELECT

2018-02-22 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8400 ) Change subject: IMPALA-4167: Support insert plan hints for CREATE TABLE AS SELECT .. IMPALA-4167: Support insert plan

[Impala-ASF-CR] IMPAL-4430: Update build scripts to die hard when IMPALA HOME has spaces

2018-02-22 Thread Nithya Janarthanan (Code Review)
Nithya Janarthanan has posted comments on this change. ( http://gerrit.cloudera.org:8080/9385 ) Change subject: IMPAL-4430: Update build scripts to die hard when IMPALA_HOME has spaces .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPAL-4430: Update build scripts to die hard when IMPALA HOME has spaces

2018-02-22 Thread Nithya Janarthanan (Code Review)
Nithya Janarthanan has posted comments on this change. ( http://gerrit.cloudera.org:8080/9385 ) Change subject: IMPAL-4430: Update build scripts to die hard when IMPALA_HOME has spaces .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-6482: add EXEC TIME LIMIT S option

2018-02-22 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9227 ) Change subject: IMPALA-6482: add EXEC_TIME_LIMIT_S option .. Patch Set 7: (6 comments)

[Impala-ASF-CR] IMPALA-6482: add EXEC TIME LIMIT S option

2018-02-22 Thread Tim Armstrong (Code Review)
Hello Philip Zeyliger, Bikramjeet Vig, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9227 to look at the new patch set (#8). Change subject: IMPALA-6482: add EXEC_TIME_LIMIT_S option

[Impala-ASF-CR] IMPALA-6275: Fix warn stacktrace in successful CTAS

2018-02-22 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9364 ) Change subject: IMPALA-6275: Fix warn stacktrace in successful CTAS .. Patch Set 5: Build started:

[Impala-ASF-CR] IMPALA-5752: Add support for DECIMAL on Kudu tables

2018-02-22 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. ( http://gerrit.cloudera.org:8080/9368 ) Change subject: IMPALA-5752: Add support for DECIMAL on Kudu tables .. Patch Set 9: Code-Review+2 Rebased -- To view, visit

[Impala-ASF-CR] IMPALA-6530: Track time spent opening HDFS file handles

2018-02-22 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/9370 ) Change subject: IMPALA-6530: Track time spent opening HDFS file handles .. Patch Set 3: Code-Review+2 (1 comment)

[Impala-ASF-CR] IMPALA-5752: Add support for DECIMAL on Kudu tables

2018-02-22 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. ( http://gerrit.cloudera.org:8080/9368 ) Change subject: IMPALA-5752: Add support for DECIMAL on Kudu tables .. Patch Set 8: Code-Review+2 -- To view, visit

[Impala-ASF-CR] Fix review comments

2018-02-22 Thread Nithya Janarthanan (Code Review)
Nithya Janarthanan has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9399 Change subject: Fix review comments .. Fix review comments Change-Id: I31f5f36bafa9ca29e05729af9904c8d9838c1d93 --- M

[Impala-ASF-CR] IMPALA-6347: Monitor queue depth size for outgoing RPCs for Reactor threads

2018-02-22 Thread Sailesh Mukil (Code Review)
Hello Michael Ho, Lars Volker, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9384 to look at the new patch set (#3). Change subject: IMPALA-6347: Monitor queue depth size for outgoing RPCs for Reactor threads

[Impala-ASF-CR] IMPALA-6347: Monitor queue depth size for outgoing RPCs for Reactor threads

2018-02-22 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/9384 ) Change subject: IMPALA-6347: Monitor queue depth size for outgoing RPCs for Reactor threads .. Patch Set 3: (4 comments)

[Impala-ASF-CR] IMPALA-6347: Monitor queue depth size for outgoing RPCs for Reactor threads

2018-02-22 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9384 ) Change subject: IMPALA-6347: Monitor queue depth size for outgoing RPCs for Reactor threads .. Patch Set 2: (2 comments)

[Impala-ASF-CR] IMPALA-4835: Part 2: Allocate scan range buffers upfront

2018-02-22 Thread Tim Armstrong (Code Review)
Hello Michael Ho, Tianyi Wang, Bikramjeet Vig, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8707 to look at the new patch set (#33). Change subject: IMPALA-4835: Part 2: Allocate scan range buffers upfront

[Impala-ASF-CR] IMPALA-4835: Part 3: switch I/O buffers to buffer pool

2018-02-22 Thread Tim Armstrong (Code Review)
Hello Bikramjeet Vig, Alex Behm, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8966 to look at the new patch set (#24). Change subject: IMPALA-4835: Part 3: switch I/O buffers to buffer pool

[Impala-ASF-CR] IMPALA-6553: [DOCS] load catalog in background default change

2018-02-22 Thread Balazs Jeszenszky (Code Review)
Balazs Jeszenszky has posted comments on this change. ( http://gerrit.cloudera.org:8080/9389 ) Change subject: IMPALA-6553: [DOCS] load_catalog_in_background default change .. Patch Set 4: Code-Review+1 LGTM, after looking

[Impala-ASF-CR] IMPALA-4835: Part 2: Allocate scan range buffers upfront

2018-02-22 Thread Tim Armstrong (Code Review)
Tim Armstrong has abandoned this change. ( http://gerrit.cloudera.org:8080/9405 ) Change subject: IMPALA-4835: Part 2: Allocate scan range buffers upfront .. Abandoned -- To view, visit http://gerrit.cloudera.org:8080/9405 To

[Impala-ASF-CR] IMPALA-4835: Part 2+3: switch I/O buffers to buffer pool

2018-02-22 Thread Tim Armstrong (Code Review)
Tim Armstrong has abandoned this change. ( http://gerrit.cloudera.org:8080/9302 ) Change subject: IMPALA-4835: Part 2+3: switch I/O buffers to buffer pool .. Abandoned -- To view, visit http://gerrit.cloudera.org:8080/9302 To

[Impala-ASF-CR] IMPALA-4835: Part 2: Allocate scan range buffers upfront

2018-02-22 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8707 ) Change subject: IMPALA-4835: Part 2: Allocate scan range buffers upfront .. Patch Set 33: Added a fix for IMPALA-6564 -- To view,

[Impala-ASF-CR] IMPALA-5752: Add support for DECIMAL on Kudu tables

2018-02-22 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9368 ) Change subject: IMPALA-5752: Add support for DECIMAL on Kudu tables .. Patch Set 9: Build started:

[Impala-ASF-CR] IMPAL-4430: Update build scripts to die hard when IMPALA HOME has spaces

2018-02-22 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/9385 ) Change subject: IMPAL-4430: Update build scripts to die hard when IMPALA_HOME has spaces .. Patch Set 2: (2 comments)

[Impala-ASF-CR] IMPALA-6547: [DOCS] Correct default encoding for INT

2018-02-22 Thread Alex Rodoni (Code Review)
Alex Rodoni has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9402 Change subject: IMPALA-6547: [DOCS] Correct default encoding for INT .. IMPALA-6547: [DOCS] Correct default encoding for INT Updated that

[Impala-ASF-CR] IMPALA-6275: Fix warn stacktrace in successful CTAS

2018-02-22 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/9364 ) Change subject: IMPALA-6275: Fix warn stacktrace in successful CTAS .. IMPALA-6275: Fix warn stacktrace in successful CTAS For CTAS in

[Impala-ASF-CR] IMPALA-6564: avoid scanner thread race leading to query failure

2018-02-22 Thread Tim Armstrong (Code Review)
Tim Armstrong has abandoned this change. ( http://gerrit.cloudera.org:8080/9401 ) Change subject: IMPALA-6564: avoid scanner thread race leading to query failure .. Abandoned The bug was actually a subtle issue in my other

[Impala-ASF-CR] IMPALA-4835: Part 3: switch I/O buffers to buffer pool

2018-02-22 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8966 ) Change subject: IMPALA-4835: Part 3: switch I/O buffers to buffer pool .. Patch Set 24: Code-Review+2 (2 comments)

[Impala-ASF-CR] IMPALA-4835: Part 3: switch I/O buffers to buffer pool

2018-02-22 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8966 ) Change subject: IMPALA-4835: Part 3: switch I/O buffers to buffer pool .. Patch Set 22: I've been seeing some flaky tests with this

[Impala-ASF-CR] IMPALA-6542: Fix inconsistent write path of Parquet min/max statistics

2018-02-22 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9381 ) Change subject: IMPALA-6542: Fix inconsistent write path of Parquet min/max statistics .. Patch Set 1: (2 comments)

[Impala-ASF-CR] IMPALA-6537: Add missing ODBC scalar functions

2018-02-22 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9376 ) Change subject: IMPALA-6537: Add missing ODBC scalar functions .. Patch Set 4: Build started:

[Impala-ASF-CR] IMPAL-4430: Update build scripts to die hard when IMPALA HOME has spaces

2018-02-22 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/9385 ) Change subject: IMPAL-4430: Update build scripts to die hard when IMPALA_HOME has spaces .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-6564: avoid scanner thread race leading to query failure

2018-02-22 Thread Tim Armstrong (Code Review)
Hello Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9401 to look at the new patch set (#2). Change subject: IMPALA-6564: avoid scanner thread race leading to query failure ..

[Impala-ASF-CR] IMPALA-6324: Support reading RLE-encoded boolean values in Parquet scanner

2018-02-22 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9403 Change subject: IMPALA-6324: Support reading RLE-encoded boolean values in Parquet scanner .. IMPALA-6324: Support reading

[Impala-ASF-CR] IMPAL-4430: Update build scripts to die hard when IMPALA HOME has spaces

2018-02-22 Thread Nithya Janarthanan (Code Review)
Nithya Janarthanan has posted comments on this change. ( http://gerrit.cloudera.org:8080/9385 ) Change subject: IMPAL-4430: Update build scripts to die hard when IMPALA_HOME has spaces .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-6275: Fix warn stacktrace in successful CTAS

2018-02-22 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/9364 ) Change subject: IMPALA-6275: Fix warn stacktrace in successful CTAS .. Patch Set 4: (3 comments)

[Impala-ASF-CR] IMPALA-4835: Part 1: simplify I/O mgr mem mgmt and cancellation

2018-02-22 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8414 ) Change subject: IMPALA-4835: Part 1: simplify I/O mgr mem mgmt and cancellation .. Patch Set 24: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-4835: Part 2: Allocate scan range buffers upfront

2018-02-22 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8707 ) Change subject: IMPALA-4835: Part 2: Allocate scan range buffers upfront .. Patch Set 32: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-4835: Part 2: Allocate scan range buffers upfront

2018-02-22 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9405 Change subject: IMPALA-4835: Part 2: Allocate scan range buffers upfront .. IMPALA-4835: Part 2: Allocate scan range buffers upfront

[Impala-ASF-CR] IMPALA-4835: Part 3: switch I/O buffers to buffer pool

2018-02-22 Thread Tim Armstrong (Code Review)
Hello Bikramjeet Vig, Alex Behm, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8966 to look at the new patch set (#23). Change subject: IMPALA-4835: Part 3: switch I/O buffers to buffer pool

[Impala-ASF-CR] IMPALA-3193: Show table's comment on show tables

2018-02-22 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. ( http://gerrit.cloudera.org:8080/8851 ) Change subject: IMPALA-3193: Show table's comment on show tables .. Patch Set 18: There is one patch that just got merged and

[Impala-ASF-CR] IMPAL-4430: Update build scripts to die hard when IMPALA HOME has spaces

2018-02-22 Thread Nithya Janarthanan (Code Review)
Nithya Janarthanan has posted comments on this change. ( http://gerrit.cloudera.org:8080/9385 ) Change subject: IMPAL-4430: Update build scripts to die hard when IMPALA_HOME has spaces .. Patch Set 1: (1 comment)

[Impala-ASF-CR] Fix review comments

2018-02-22 Thread Nithya Janarthanan (Code Review)
Nithya Janarthanan has abandoned this change. ( http://gerrit.cloudera.org:8080/9399 ) Change subject: Fix review comments .. Abandoned -- To view, visit http://gerrit.cloudera.org:8080/9399 To unsubscribe, visit

[Impala-ASF-CR] IMPAL-4430: Update build scripts to die hard when IMPALA HOME has spaces

2018-02-22 Thread Nithya Janarthanan (Code Review)
Nithya Janarthanan has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/9385 ) Change subject: IMPAL-4430: Update build scripts to die hard when IMPALA_HOME has spaces .. IMPAL-4430: Update build scripts to die

[Impala-ASF-CR] IMPALA-6564: avoid scanner thread race leading to query failure

2018-02-22 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9401 Change subject: IMPALA-6564: avoid scanner thread race leading to query failure .. IMPALA-6564: avoid scanner thread race leading to

[Impala-ASF-CR] IMPALA-6324: Support reading RLE-encoded boolean values in Parquet scanner

2018-02-22 Thread Csaba Ringhofer (Code Review)
Hello Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9403 to look at the new patch set (#2). Change subject: IMPALA-6324: Support reading RLE-encoded boolean values in Parquet scanner

[Impala-ASF-CR] IMPALA-6564: avoid scanner thread race leading to query failure

2018-02-22 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/9401 ) Change subject: IMPALA-6564: avoid scanner thread race leading to query failure .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPAL-4430: Update build scripts to die hard when IMPALA HOME has spaces

2018-02-22 Thread Nithya Janarthanan (Code Review)
Nithya Janarthanan has posted comments on this change. ( http://gerrit.cloudera.org:8080/9385 ) Change subject: IMPAL-4430: Update build scripts to die hard when IMPALA_HOME has spaces .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPAL-4430: Update build scripts to die hard when IMPALA HOME has spaces

2018-02-22 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/9385 ) Change subject: IMPAL-4430: Update build scripts to die hard when IMPALA_HOME has spaces .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-6564: avoid scanner thread race leading to query failure

2018-02-22 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9401 ) Change subject: IMPALA-6564: avoid scanner thread race leading to query failure .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-6275: Fix warn stacktrace in successful CTAS

2018-02-22 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/9364 ) Change subject: IMPALA-6275: Fix warn stacktrace in successful CTAS .. Patch Set 5: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-6543: Limit RowBatch serialization size to INT MAX

2018-02-22 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/9367 ) Change subject: IMPALA-6543: Limit RowBatch serialization size to INT_MAX .. Patch Set 1: (1 comment) Updated

[Impala-ASF-CR] IMPALA-6543: Limit RowBatch serialization size to INT MAX

2018-02-22 Thread Joe McDonnell (Code Review)
Hello Michael Ho, Lars Volker, Sailesh Mukil, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9367 to look at the new patch set (#2). Change subject: IMPALA-6543: Limit RowBatch serialization size to INT_MAX

[Impala-ASF-CR] IMPALA-6549: Enable file handle cache by default

2018-02-22 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9371 ) Change subject: IMPALA-6549: Enable file handle cache by default .. Patch Set 3: Build started:

[Impala-ASF-CR] IMPAL-4430: Update build scripts to die hard when IMPALA HOME has spaces

2018-02-22 Thread Nithya Janarthanan (Code Review)
Nithya Janarthanan has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9385 Change subject: IMPAL-4430: Update build scripts to die hard when IMPALA_HOME has spaces .. IMPAL-4430: Update build scripts to

[Impala-ASF-CR] IMPALA-6275: Fix warn stacktrace in successful CTAS

2018-02-22 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#5). ( http://gerrit.cloudera.org:8080/9364 ) Change subject: IMPALA-6275: Fix warn stacktrace in successful CTAS .. IMPALA-6275: Fix warn stacktrace in successful CTAS For CTAS in

[Impala-ASF-CR] IMPALA-6347: Monitor queue depth size for outgoing RPCs for Reactor threads

2018-02-22 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/9384 ) Change subject: IMPALA-6347: Monitor queue depth size for outgoing RPCs for Reactor threads .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-6347: Monitor queue depth size for outgoing RPCs for Reactor threads

2018-02-22 Thread Sailesh Mukil (Code Review)
Hello Michael Ho, Lars Volker, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9384 to look at the new patch set (#4). Change subject: IMPALA-6347: Monitor queue depth size for outgoing RPCs for Reactor threads

[Impala-ASF-CR] IMPALA-6482: add EXEC TIME LIMIT S option

2018-02-22 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/9227 ) Change subject: IMPALA-6482: add EXEC_TIME_LIMIT_S option .. Patch Set 8: Code-Review+1 (3 comments)

[Impala-ASF-CR] IMPALA-6530: Track time spent opening HDFS file handles

2018-02-22 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/9370 ) Change subject: IMPALA-6530: Track time spent opening HDFS file handles .. Patch Set 4: Code-Review+2 Carrying +2 -- To view, visit

[Impala-ASF-CR] IMPALA-4835: Part 2: Allocate scan range buffers upfront

2018-02-22 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8707 ) Change subject: IMPALA-4835: Part 2: Allocate scan range buffers upfront .. Patch Set 33: (1 comment)

[Impala-ASF-CR] IMPALA-5752: Add support for DECIMAL on Kudu tables

2018-02-22 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9368 ) Change subject: IMPALA-5752: Add support for DECIMAL on Kudu tables .. Patch Set 9: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-5752: Add support for DECIMAL on Kudu tables

2018-02-22 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9368 ) Change subject: IMPALA-5752: Add support for DECIMAL on Kudu tables .. IMPALA-5752: Add support for DECIMAL on Kudu

[Impala-ASF-CR] IMPALA-6482: add EXEC TIME LIMIT S option

2018-02-22 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9227 ) Change subject: IMPALA-6482: add EXEC_TIME_LIMIT_S option .. Patch Set 10: Build started:

[Impala-ASF-CR] IMPALA-6482: add EXEC TIME LIMIT S option

2018-02-22 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9227 ) Change subject: IMPALA-6482: add EXEC_TIME_LIMIT_S option .. Patch Set 10: Code-Review+2 Carry +2 -- To view, visit

[Impala-ASF-CR] IMPALA-4835: Part 2: Allocate scan range buffers upfront

2018-02-22 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/8707 ) Change subject: IMPALA-4835: Part 2: Allocate scan range buffers upfront .. Patch Set 33: Code-Review+2 (1 comment)

[Impala-ASF-CR] KUDU-2301: (Part-1) Add instrumentation on a per connection level

2018-02-22 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9383 ) Change subject: KUDU-2301: (Part-1) Add instrumentation on a per connection level .. Patch Set 1: Code-Review+1 Looks good to me,

[Impala-ASF-CR] IMPALA-6530: Track time spent opening HDFS file handles

2018-02-22 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/9370 ) Change subject: IMPALA-6530: Track time spent opening HDFS file handles .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-6530: Track time spent opening HDFS file handles

2018-02-22 Thread Joe McDonnell (Code Review)
Hello Tim Armstrong, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9370 to look at the new patch set (#4). Change subject: IMPALA-6530: Track time spent opening HDFS file handles

[Impala-ASF-CR] IMPALA-6543: Limit RowBatch serialization size to INT MAX

2018-02-22 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9367 ) Change subject: IMPALA-6543: Limit RowBatch serialization size to INT_MAX .. Patch Set 2: Code-Review+1 Did anyone else want to take a

[Impala-ASF-CR] IMPALA-6347: Monitor queue depth size for outgoing RPCs for Reactor threads

2018-02-22 Thread Sailesh Mukil (Code Review)
Hello Michael Ho, Lars Volker, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9384 to look at the new patch set (#6). Change subject: IMPALA-6347: Monitor queue depth size for outgoing RPCs for Reactor threads

[Impala-ASF-CR] IMPALA-6549: Enable file handle cache by default

2018-02-22 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/9371 ) Change subject: IMPALA-6549: Enable file handle cache by default .. Patch Set 3: GVO hit IMPALA-6532 -- To view, visit

[Impala-ASF-CR] KUDU-2301: (Part-1) Add instrumentation on a per connection level

2018-02-22 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/9383 ) Change subject: KUDU-2301: (Part-1) Add instrumentation on a per connection level .. Patch Set 2: Code-Review+1 > Looks good to me,

[Impala-ASF-CR] KUDU-2301: (Part-1) Add instrumentation on a per connection level

2018-02-22 Thread Sailesh Mukil (Code Review)
Hello Michael Ho, Lars Volker, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9383 to look at the new patch set (#2). Change subject: KUDU-2301: (Part-1) Add instrumentation on a per connection level

[Impala-ASF-CR] IMPALA-6549: Enable file handle cache by default

2018-02-22 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9371 ) Change subject: IMPALA-6549: Enable file handle cache by default .. Patch Set 3: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-6482: add EXEC TIME LIMIT S option

2018-02-22 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/9227 ) Change subject: IMPALA-6482: add EXEC_TIME_LIMIT_S option .. Patch Set 9: Code-Review+2 (9 comments)

  1   2   >