[Freeciv-Dev] [bug #22276] city_build_free_buildings() doesn't send great wonder info as intended
Follow-up Comment #1, bug #22276 (project freeciv): I confirm this wasn't my intent for bug #15548, this was a typo. ___ Reply to this item at: http://gna.org/bugs/?22276 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #20618] Goto shouldn't attack in fogged tiles
Update of bug #20618 (project freeciv): Assigned to:None = pepeto ___ Reply to this item at: http://gna.org/bugs/?20618 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #22279] Unit cannnot perform diplomat action from Ocean
Follow-up Comment #1, bug #22279 (project freeciv): The unit flag Marines is currently reserved for attacks. This is a lack of control for diplomat action currently. But Sveinung is working on it. See patch #4671. ___ Reply to this item at: http://gna.org/bugs/?22279 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #4671] Move limits on what terrain a spy action can be done from to action enablers
Follow-up Comment #8, patch #4671 (project freeciv): See also bug #22279. ___ Reply to this item at: http://gna.org/patch/?4671 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #22258] Map topology and tileset incompatible is not an error
Update of bug #22258 (project freeciv): Status: Ready For Test = Fixed Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/bugs/?22258 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #4888] Move research advance name accessors
Update of patch #4888 (project freeciv): Status: Ready For Test = Done Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/patch/?4888 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #22252] Giving techonologies in editor does not work
Update of bug #22252 (project freeciv): Status: Ready For Test = Fixed Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/bugs/?22252 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #4890] Utility for iterating all requirements of an advance
Update of patch #4890 (project freeciv): Status: Ready For Test = Done Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/patch/?4890 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #4891] techs_precalc_data() cleanup
Update of patch #4891 (project freeciv): Status: Ready For Test = Done Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/patch/?4891 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #22280] Obsoleting tech of not-yet-loaded buildings checked
URL: http://gna.org/bugs/?22280 Summary: Obsoleting tech of not-yet-loaded buildings checked Project: Freeciv Submitted by: cazfi Submitted on: Sun 06 Jul 2014 12:04:12 PM EEST Category: general Severity: 3 - Normal Priority: 5 - Normal Status: Ready For Test Assigned to: None Originator Email: Open/Closed: Open Release: Discussion Lock: Any Operating System: None Planned Release: 2.5.0 ___ Details: Reported by GriffonSpade at forums: http://forum.freeciv.org/f/viewtopic.php?f=8t=319 When buildings are being loaded from ruleset, check for obsoleting tech of all buildings is being made *after each building has been loaded*, not when they are all loaded. This can lead to bogus error messages when later building is already checked when only first ones have been loaded. Fix attached. ___ File Attachments: --- Date: Sun 06 Jul 2014 12:04:12 PM EEST Name: ObsolescenceOfUninitialized-S2_5.patch Size: 406B By: cazfi http://gna.org/bugs/download.php?file_id=21296 ___ Reply to this item at: http://gna.org/bugs/?22280 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #4892] Move last harmless functions from tech.[ch] to research.[ch]
Update of patch #4892 (project freeciv): Status: Ready For Test = Done Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/patch/?4892 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #21350] Supplied scenario start positions vs core nations
Follow-up Comment #3, bug #21350 (project freeciv): When the core nation set is rigidly enforced [...] our supplied scenarios which specify nation-specific start positions will cause trouble Oh, past-me, why so vague? I'm guessing that by trouble I meant looks a bit ugly, in that the game may have to choose nations which aren't in the scenario, and then match them to start positions that were designed for someone else; and that there's no user indication of this until the game starts. A mitigating factor is the default aifill in the scenario. If that's set so that there are sufficient 'core' nations to cover, you'll only see the ugliness if you change it or have very many human players. Otherwise those start positions which are for non-core nations will never be used with nationset=core, I think. Anyway, I came back here to note that bardo tweaked one of the Earth scenarios under patch #4842 in a way which should improve this. Survey of the scenarios previously marked as troublesome: * british-isles-85x80-v2.80.sav: 1/5 in core; aifill not set, default 5 *ugly* * earth-160x90-v2.sav: *new* 30/38 in core; aifill 30 * earth-80x50-v3.sav: 16/18 core; aifill 10 * europe-200x100-v2.sav: 16/37 core; aifill 14 * france-140x90-v2.sav: 15/27 core; aifill 18 *ugly* * north_america_116x100-v1.2.sav: 10/12 core; aifill 12 *ugly* ___ Reply to this item at: http://gna.org/bugs/?21350 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #4889] Pathfinding refactoring
Update of patch #4889 (project freeciv): Status: Ready For Test = In Progress ___ Reply to this item at: http://gna.org/patch/?4889 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #21380] Property editor does not honour nation set restrictions
Follow-up Comment #3, bug #21380 (project freeciv): ...now if you edit a scenario which has start positions for nations not in your current set (which you can't change while editing), it says 1 Nation, but you can't see who it is or change it. Enh. Maybe a show all button? ___ Reply to this item at: http://gna.org/bugs/?21380 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #4864] Distance-based calculation for meeting charges
Follow-up Comment #3, patch #4864 (project freeciv): Would the simple S2_5 fix be beneficial for S2_4 too? It looks like it could be quite important -- without it, are sea bodyguards going to meet their charge and then immediately wander off? ___ Reply to this item at: http://gna.org/patch/?4864 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #22281] Help should show Courthouse has no effect in presence of Palace
URL: http://gna.org/bugs/?22281 Summary: Help should show Courthouse has no effect in presence of Palace Project: Freeciv Submitted by: None Submitted on: Sun 06 Jul 2014 11:15:30 AM UTC Category: docs Severity: 2 - Minor Priority: 5 - Normal Status: None Assigned to: None Originator Email: kaza...@gmail.com Open/Closed: Open Release: 2.4.2 Discussion Lock: Any Operating System: Any Planned Release: ___ Details: Regarding the default/classic ruleset (and other relevant rulesets), I think it's best that the Help docs for the Courthouse state that it has no effect in the presence of the Palace, and that the Help docs for the Palace state that it has the corruption-busting effects of the Courthouse. This saves someone from building a Courthouse in the capital and then wondering why nothing has changed. For a while I thought the game was broken (unlikely I know), but the effects.ruleset file eventually cleared away the confusion. Still, one shouldn't have to go through the ruleset files to find out about gameplay rules. ___ Reply to this item at: http://gna.org/bugs/?22281 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #22274] Database backend 'random characters' not supported by database.lua
Follow-up Comment #5, bug #22274 (project freeciv): Using an SQLite database is still working for me, so I'll probably need to know more about your environment: * Are there any non-ASCII characters anywhere in sight (in the configuration file, in its filename, in the database)? * What does your --Database file look like, and what's it called? * What OS is the server running on? * When my --enable-debug server starts, it says: _Encodings: Data=UTF-8, Local=UTF-8, Internal=UTF-8_. What does yours say (or if you don't have --enable-debug, do you know what it would say)? * If you enable LOG_DEBUG level logging, what does it say about database stuff? (E.g., search for Database option to see stuff logged by database.lua.) The only obvious character set conversion in this area I've found so far is Windows-specific: filenames are converted with internal_to_local_string_malloc(), and that can go wrong. That should lead to simple failure to open a file, though, I think. (But I haven't investigated if the Lua machinery does some character set conversion on the Lua interface.) ___ Reply to this item at: http://gna.org/bugs/?22274 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #4889] Pathfinding refactoring
Update of patch #4889 (project freeciv): Status: In Progress = Ready For Test ___ Follow-up Comment #2: New version: * clarify the usage of paranthesizes in pf_get_action() ; * split 'enum pf_action' and 'enum pf_action_account' ; * fixed node behavior overwrite ; * added some comments. (file #21297) ___ Additional Item Attachment: File name: pf_refactoring2.patch.gz Size:11 KB ___ Reply to this item at: http://gna.org/patch/?4889 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #22282] convert_string() / iconv() error reporting could be more specific
URL: http://gna.org/bugs/?22282 Summary: convert_string() / iconv() error reporting could be more specific Project: Freeciv Submitted by: jtn Submitted on: Sun 06 Jul 2014 12:39:24 BST Category: None Severity: 3 - Normal Priority: 5 - Normal Status: None Assigned to: None Originator Email: Open/Closed: Open Release: Discussion Lock: Any Operating System: Any Planned Release: ___ Details: Currently convert_string() just says Invalid string conversion from %s to %s. if it encounters an error related to the body of the string. There are some defined errno meanings for iconv(), so the message could sometimes be more specific. EILSEQ An invalid multibyte sequence has been encountered in the input. EINVAL An incomplete multibyte sequence has been encountered in the input. ___ Reply to this item at: http://gna.org/bugs/?22282 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #22283] Poor error reporting on failure to open file
URL: http://gna.org/bugs/?22283 Summary: Poor error reporting on failure to open file Project: Freeciv Submitted by: jtn Submitted on: Sun 06 Jul 2014 12:47:19 BST Category: None Severity: 3 - Normal Priority: 5 - Normal Status: None Assigned to: None Originator Email: Open/Closed: Open Release: Discussion Lock: Any Operating System: None Planned Release: ___ Details: If a data file isn't present, has no permissions, etc, secfile_error() doesn't return anything useful (a blank string when I tried). Fixing this will be quite tedious: secfile_load()/secfile_load_section() call inf_from_file() in inputfile, which doesn't have a defined ferror/errno/strerror-type interface. inf_from_file() calls fz_from_file(), which kind of has such an interface (fz_strerror()), although it relies on the regular errno which won't be set for compression-related errors. Also, it's not set for all OS errors. For instance, support.c:is_reg_file_for_access() can return FALSE for a non-errno condition, so fz_from_file() can't simply call strerror(), hence we don't trivially get file not found vs permission denied in fz_strerror(). Fixing this will require a usable error reporting interface at every layer in this stack, so that we can get file not found from the OS all the way to secfile_error(). ___ Reply to this item at: http://gna.org/bugs/?22283 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #22281] Help should show Courthouse has no effect in presence of Palace
Follow-up Comment #1, bug #22281 (project freeciv): Hm, yes, that could be clearer. Also the Palace help could state explicitly that Palace means your capital can't be incited to revolt, to contrast with the Courthouse's increase in incite cost. (This is also a useful example of the notion of redundant buildings being discussed in patch #4885, bug #21992 etc. You might kind of want Courthouse to be marked as redundant in the UI in non-Democracy governments, but: * Redundancy logic does not know that No_Incite trumps Incite_Cost_Pct, and probably shouldn't. * In a Democracy, the Courthouse would do something useful (Make_Content) even in your capital. Should that count as redundant? One day it could be useful without the set of buildings in the city changing. ** You could probably trick the current logic into displaying it as redundant by expressing the Democracy requirement as negated reqs for all the other governments. (Gross.) I suspect that it won't be possible for the engine to always infer redundancy in the way we'd want from the building effects. But making ruleset authors write their own consider this building redundant / not redundant if these requirements are met, which the engine can't check, is also ugly and error-prone. Hm.) ___ Reply to this item at: http://gna.org/bugs/?22281 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] styles.ruleset missing
Hi Everyone, I'm trying to get a freeciv server up and running and I'm faced with an issue when running freeciv-web: ubuntu@ip-10-236-131-195:~/freeciv$ freeciv-web This is the server for Freeciv version 2.5.99-dev You can learn a lot about Freeciv at http://www.freeciv.org/ This freeciv-server program has player authentication support, but it's currently not in use. 2: Loading rulesets. 1: Could not find a readable styles.ruleset ruleset file.I'm actually interested in contributing to the project long I did some searching and found this has come up before but was unable to find the resolution. Can anyone point me in the right direction on how to move forward? I really love this project and would really like to get more involved once I can free up some time. Keep up the amazing work. Andrew McGrath Founder, Checkout 51 ph. 647 225 4909 www.checkout51.com ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #4908] Document global and national starting buildings/techs/units in their help
URL: http://gna.org/patch/?4908 Summary: Document global and national starting buildings/techs/units in their help Project: Freeciv Submitted by: jtn Submitted on: Sun 06 Jul 2014 14:05:07 BST Category: docs Priority: 5 - Normal Status: In Progress Privacy: Public Assigned to: jtn Originator Email: Open/Closed: Open Discussion Lock: Any Planned Release: 2.4.3, 2.5.0, 2.6.0 ___ Details: We already document nation-specific starting goodies in nation help visible in pregame (patch #3066), but I think it would also be useful to document both nation and global starting items in the help for those items (e.g. Palace help). For one thing, this makes the global starting items visible in the help, which currently they aren't. ___ Reply to this item at: http://gna.org/patch/?4908 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #22281] Help should show Courthouse has no effect in presence of Palace
Follow-up Comment #2, bug #22281 (project freeciv): Yep, unless the Palace incorporates all the abilities of a Courthouse (including its ability to be built in multiple cities), the Courthouse shouldn't be marked as redundant in the UI even if the Palace is around. The Palace can move after all, and what is currently a capital city may no longer be so. Adam Smith helps in keeping a capital Courthouse standing. It's just that there could be a note regarding the interactions between Palace and Courthouse in the Help docs. Autogenerating the docs from effects.ruleset is probably better (but more work). ___ Reply to this item at: http://gna.org/bugs/?22281 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #20618] Goto shouldn't attack in fogged tiles
Follow-up Comment #1, bug #20618 (project freeciv): I see two ways to implements this: * add a client goto option to have 'vigilant' orders ; * stop the unit if a unit or a city is found on the way, in the middle of the patch. Then, it will requires another order type (so it is not possible to implement in stable branch) like 'ORDER_ACTION' for the last order to determine if attack was scheduled or not. ___ Reply to this item at: http://gna.org/bugs/?20618 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #22281] Help should show Courthouse has no effect in presence of Palace
Update of bug #22281 (project freeciv): Status:None = In Progress Assigned to:None = jtn ___ Follow-up Comment #3: It's just that there could be a note regarding the interactions between Palace and Courthouse in the Help docs. Agreed; working on it. (Aside: in the civ1 ruleset, Courthouse only affects corruption, and *is* marked as redundant in the capital. Also, the help is full of lies; fixing that too.) ___ Reply to this item at: http://gna.org/bugs/?22281 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #4908] Document global and national starting buildings/techs/units in their help
Update of patch #4908 (project freeciv): Status: In Progress = Ready For Test ___ Follow-up Comment #1: Currently any barbarian/pirate initial goodies are not acknowledged on S2_5 and later, due to the fix for bug #21901. (file #21298, file #21299) ___ Additional Item Attachment: File name: trunk-S2_5-help-free-stuff.patch Size:4 KB File name: S2_4-help-free-stuff.patch Size:3 KB ___ Reply to this item at: http://gna.org/patch/?4908 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #22281] Help should show Courthouse has no effect in presence of Palace
Update of bug #22281 (project freeciv): Status: In Progress = Ready For Test Planned Release: = 2.4.3, 2.5.0, 2.6.0 ___ Follow-up Comment #4: * Explicitly noted that capital can't be incited in Palace help. * Also noted other diplomat bonuses that weren't mentioned. * civ1 claimed all sorts of effects for its Courthouses which weren't in the rules, which have only a corruption effect. This civ1 manual http://www.civfanatics.com/civ1/manual/civ1_man.htm supports that, so I've fixed the docs. * civ2 and multiplayer help didn't mention the effects on waste; fixed. ** (civ1 also has a waste benefit to Palace, but the ruleset has no waste, so I didn't mention it.) * civ2civ3 Courthouse description didn't mention its effects on food waste. Palace neither. Also, remove claims that some governments don't suffer distance-based waste, as it's a bit more complicated than that. (file #21300, file #21301) ___ Additional Item Attachment: File name: trunk-S2_5-help-courthouse-vs-palace.patch Size:12 KB File name: S2_4-help-courthouse-vs-palace.patch Size:10 KB ___ Reply to this item at: http://gna.org/bugs/?22281 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #4650] Split single input xx.po file into translations/*/xx.po
Follow-up Comment #3, patch #4650 (project freeciv): I believe this ends up with every source translation in exactly one place, But is that what we want? It's possible that a few strings (governor titles) are needed for both core nations and extended nations. You're right, what I described is not what we want. Fortunately, I was lying :) If a msgid appears in both core and extended nations, this procedure puts the translation in both resulting po-files. ___ Reply to this item at: http://gna.org/patch/?4650 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
Re: [Freeciv-Dev] styles.ruleset missing
On 1 July 2014 18:15, Andrew McGrath and...@checkout51.com wrote: Hi Everyone, I'm trying to get a freeciv server up and running and I'm faced with an issue when running freeciv-web: ubuntu@ip-10-236-131-195:~/freeciv$ freeciv-web The interface between freeciv and freeciv-web is not very clean at the moment (going to right direction, though). Anyway, there's only some pieces for the freeciv-web functionality in freeciv sources, you cannot build fully freeciv-web capable server from plain freeciv sources. If you want to work specifically on freeciv-web, and not upstream freeciv, you should get sources from https://github.com/freeciv/freeciv-web and follow build instructions there. This is the server for Freeciv version 2.5.99-dev You can learn a lot about Freeciv at http://www.freeciv.org/ This freeciv-server program has player authentication support, but it's currently not in use. 2: Loading rulesets. 1: Could not find a readable styles.ruleset ruleset file.I'm actually interested in contributing to the project long This particular problem is because freeciv does not contain freeciv-web compatible ruleset at all - something I'm currently evaluating. It would make sense to move its maintenance to freeciv so it would remain compatible with freeciv server, but then getting any rule changes freeciv-web needs when updating to newer freeciv revision would require extra patching in freeciv-web side and submitting those changes back to upstream freeciv. - ML ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #22187] Client allows attempted violation of embarks/disembarks restrictions
Update of bug #22187 (project freeciv): Status:None = In Progress ___ Follow-up Comment #5: Worse than pathfinding violation, the server allows Riflemen to load to Helicopter into Ocean. But as it cannot be loaded, the Riflemen stands alone in Ocean. ___ Reply to this item at: http://gna.org/bugs/?22187 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #4909] Remove advance_by_flag()
URL: http://gna.org/patch/?4909 Summary: Remove advance_by_flag() Project: Freeciv Submitted by: pepeto Submitted on: dim. 06 juil. 2014 20:25:42 CEST Category: general Priority: 5 - Normal Status: Ready For Test Privacy: Public Assigned to: pepeto Originator Email: Open/Closed: Open Discussion Lock: Any Planned Release: 2.6.0 ___ Details: Not used anymore. ___ File Attachments: --- Date: dim. 06 juil. 2014 20:25:42 CEST Name: remove_advance_by_flag.patch Size: 2 ko By: pepeto http://gna.org/patch/download.php?file_id=21302 ___ Reply to this item at: http://gna.org/patch/?4909 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #22062] Cannot see the real cost of the technologies with some values of tech_leakage
Update of bug #22062 (project freeciv): Status:None = Ready For Test Assigned to:None = pepeto Planned Release: = 2.6.0 ___ Follow-up Comment #1: Fix attached. It needs network capability string change. (file #21303) ___ Additional Item Attachment: File name: researching_cost_info.patchSize:16 KB ___ Reply to this item at: http://gna.org/bugs/?22062 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #4910] pf_parameter with unit_type pointer
URL: http://gna.org/patch/?4910 Summary: pf_parameter with unit_type pointer Project: Freeciv Submitted by: pepeto Submitted on: dim. 06 juil. 2014 20:32:33 CEST Category: ai Priority: 5 - Normal Status: Ready For Test Privacy: Public Assigned to: pepeto Originator Email: Open/Closed: Open Discussion Lock: Any Planned Release: 2.6.0 ___ Details: _pf_parameter::utype_ replaces _unit_flags_, _uclass_, and _unknown_MC_. ___ File Attachments: --- Date: dim. 06 juil. 2014 20:32:33 CEST Name: pf_parameter_utype_based.patch Size: 26 ko By: pepeto http://gna.org/patch/download.php?file_id=21304 ___ Reply to this item at: http://gna.org/patch/?4910 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #4910] pf_parameter with unit_type pointer
Update of patch #4910 (project freeciv): Depends on: = patch #4889 ___ Reply to this item at: http://gna.org/patch/?4910 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #22187] Client allows attempted violation of embarks/disembarks restrictions
Update of bug #22187 (project freeciv): Category:None = general Status: In Progress = Ready For Test ___ Follow-up Comment #6: Fix attached for the pathfinding part. Applies over patch #4889 and patch #4910. (file #21305) ___ Additional Item Attachment: File name: pf_embarking_disembarking.patch Size:13 KB ___ Reply to this item at: http://gna.org/bugs/?22187 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #22187] Client allows attempted violation of embarks/disembarks restrictions
Update of bug #22187 (project freeciv): Depends on: = patch #4910 ___ Reply to this item at: http://gna.org/bugs/?22187 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #22286] Ruledit won't compile because of renamed field
URL: http://gna.org/bugs/?22286 Summary: Ruledit won't compile because of renamed field Project: Freeciv Submitted by: sveinung Submitted on: Sun 06 Jul 2014 06:59:08 PM UTC Category: freeciv-ruledit Severity: 3 - Normal Priority: 9 - Immediate Status: Ready For Test Assigned to: sveinung Originator Email: Open/Closed: Open Release: TRUNK Discussion Lock: Any Operating System: None Planned Release: 2.6.0 ___ Details: SVN commit 25397 renamed the advance field preset_cost to cost without updating ruledit's rulesave.c ___ File Attachments: --- Date: Sun 06 Jul 2014 06:59:08 PM UTC Name: 0001-Make-ruledit-compile-again.patch Size: 960B By: sveinung http://gna.org/bugs/download.php?file_id=21306 ___ Reply to this item at: http://gna.org/bugs/?22286 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #22286] Ruledit won't compile because of renamed field
Update of bug #22286 (project freeciv): Status: Ready For Test = Fixed Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/bugs/?22286 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #22275] Warning about 0-size calloc at luascript_signal.c:223
Follow-up Comment #1, bug #22275 (project freeciv): Original submission used line from version where bug #19909 was reverted (see bug #22274). Without the revert I get same warning from luascript_func.c:133. ___ Reply to this item at: http://gna.org/bugs/?22275 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #22274] Database backend 'random characters' not supported by database.lua
Follow-up Comment #6, bug #22274 (project freeciv): bug #22275 seems to be related (or more like the cause). I have two entries in my database config file (attached) and with -d 3 I get the bug #22275 warning twice between the message that server starts to read the config file and the invalid conversion error. I'm not aware of any non-ascii characters anywhere in this setup, and every part should be set to use UTF-8. It turns out this build is not --enable-debug one (comes from my public server scripts, now named as pubcaz system). I'll make --enable-debug build next. (file #21307) ___ Additional Item Attachment: File name: fc_auth.conf Size:0 KB ___ Reply to this item at: http://gna.org/bugs/?22274 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #22286] Ruledit won't compile because of renamed field
Follow-up Comment #2, bug #22286 (project freeciv): Note that all done here was to make it compile again. Calculated values are now written. Since they are stored as an int the calculated values are now rounded. Should I have commented out the support for writing tech cost in stead of doing what I did? ___ Reply to this item at: http://gna.org/bugs/?22286 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #22286] Ruledit won't compile because of renamed field
Follow-up Comment #3, bug #22286 (project freeciv): Since they are stored as an int the calculated values are now rounded. Calculated values? Has the ruleset format changed in a way that saving them should reflect? Simple rule: If you do not make any changes to the loaded ruleset in freeciv-ruledit and save it, saved ruleset should have identical rules to the original (i.e, identical short of formatting changes, comments missing, and unfortunately currently also gettext marking _() missing from strings that previously had them) ___ Reply to this item at: http://gna.org/bugs/?22286 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #4911] Rename and move player_research_step()
URL: http://gna.org/patch/?4911 Summary: Rename and move player_research_step() Project: Freeciv Submitted by: pepeto Submitted on: dim. 06 juil. 2014 23:01:54 CEST Category: general Priority: 5 - Normal Status: Ready For Test Privacy: Public Assigned to: pepeto Originator Email: Open/Closed: Open Discussion Lock: Any Planned Release: 2.6.0 ___ Details: Move from common/tech.[ch] to common/research.[ch], rename to research_goal_step(), take _research_ pointer as first argument, and use iteration instead of recursion. ___ File Attachments: --- Date: dim. 06 juil. 2014 23:01:54 CEST Name: research_goal_step.patch Size: 6 ko By: pepeto http://gna.org/patch/download.php?file_id=21308 ___ Reply to this item at: http://gna.org/patch/?4911 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #22059] tech_leakage doesn't handle team pooled research
Update of bug #22059 (project freeciv): Status:None = Ready For Test Assigned to:None = pepeto Planned Release: = 2.6.0 ___ Follow-up Comment #1: Attached fix (also fixes bug #22060 and bug #22061): * renamed base_total_bulbs_required() to research_total_bulbs_required() ; * moved from common/tech.[ch] to common/research.[ch] ; * take _research_ pointer as first argument ; * fix tech_leakage: ** for 1), counts the players anyone sharing the research has an embassy with ; ** for 2) and 3), counts players (not researches). * fix EFT_TECH_COST_FACTOR: multiply with the bonus for every player sharing the research ; * fix AI science cost: reduce proportionally to the number of players sharing the research ; (file #21309) ___ Additional Item Attachment: File name: research_total_bulbs_required.patch Size:18 KB ___ Reply to this item at: http://gna.org/bugs/?22059 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #22060] EFT_TECH_COST_FACTOR isn't handle with team pooled research
Update of bug #22060 (project freeciv): Status:None = In Progress Assigned to:None = pepeto Depends on: = bugs #22059 ___ Follow-up Comment #1: See bug #22059. ___ Reply to this item at: http://gna.org/bugs/?22060 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #22061] Team pooled research and AI science cost
Update of bug #22061 (project freeciv): Status:None = In Progress Assigned to:None = pepeto Depends on: = bugs #22059 ___ Follow-up Comment #1: See bug #22059. ___ Reply to this item at: http://gna.org/bugs/?22061 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #22266] Crosser build of freeciv-mp-cli fails
Update of bug #22266 (project freeciv): Status: Ready For Test = Fixed Assigned to:None = cazfi Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/bugs/?22266 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #4879] Mark redundant buildings in sdl-client
Update of patch #4879 (project freeciv): Status: Ready For Test = Done Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/patch/?4879 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #22287] Calculated advance costs written into ruleset
URL: http://gna.org/bugs/?22287 Summary: Calculated advance costs written into ruleset Project: Freeciv Submitted by: pepeto Submitted on: dim. 06 juil. 2014 23:40:08 CEST Category: freeciv-ruledit Severity: 3 - Normal Priority: 5 - Normal Status: Ready For Test Assigned to: None Originator Email: Open/Closed: Open Release: Discussion Lock: Any Operating System: Any Planned Release: 2.6.0 ___ Details: Following bug #22286, comment 2: Calculated values are now written. Since they are stored as an int the calculated values are now rounded. Thank you Sveinung and Marko. Sorry, to have misunderstood the purpose of the 'preset_cost', which looked to me to duplicate the ugly techcoststyle1 array. The attached patch should fix it. ___ File Attachments: --- Date: dim. 06 juil. 2014 23:40:08 CEST Name: load_rulesetdir_act_techs_precalc_data.patch Size: 430 o By: pepeto http://gna.org/bugs/download.php?file_id=21311 ___ Reply to this item at: http://gna.org/bugs/?22287 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #22184] Windows installer has translations from freeciv domain only
Update of bug #22184 (project freeciv): Status: Ready For Test = Fixed Assigned to:None = cazfi Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/bugs/?22184 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #22288] Ruledit stores (rounded) calculated tech cost
URL: http://gna.org/bugs/?22288 Summary: Ruledit stores (rounded) calculated tech cost Project: Freeciv Submitted by: sveinung Submitted on: Sun 06 Jul 2014 09:46:41 PM UTC Category: freeciv-ruledit Severity: 3 - Normal Priority: 5 - Normal Status: None Assigned to: None Originator Email: Open/Closed: Open Release: TRUNK Discussion Lock: Any Operating System: None Planned Release: 2.6.0 ___ Details: Patch #4891 replaced the advance struct's preset_cost with cost. cost may be the tech cost defined in the ruleset like preset_cost or a calculated value. The ruleset cost is still an int. The calculated value may be a double. The cost field is written during ruleset load. Patch #4891 made ruledit stop compile. Bug #22286 was a compile fix for ruledit. It didn't try to fix anything but compilation. All it did was to change the name from preset_cost to cost. The advantage of this over commenting out tech cost storage is that tech cost values loaded from the ruleset aren't lost. The disadvantage is that tech cost values calculated by techs_precalc_data() during ruleset load are (converted to int and) stored in the ruleset. ___ Reply to this item at: http://gna.org/bugs/?22288 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #22288] Ruledit stores (rounded) calculated tech cost
Update of bug #22288 (project freeciv): Status:None = Duplicate Open/Closed:Open = Closed ___ Follow-up Comment #1: Dupe of bug #22287 ___ Reply to this item at: http://gna.org/bugs/?22288 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #22274] Database backend 'random characters' not supported by database.lua
Follow-up Comment #7, bug #22274 (project freeciv): I had to do more than --enable-debug - I had -DNDEBUG which didn't work well with --enable-debug (and I'm inclined to say we don't need/want to support such combination, so not opening bug about that). But, once I removed -DNDEBUG and added --enable-debug, the server starts fine. Bug #22275 warnings still appear. ___ Reply to this item at: http://gna.org/bugs/?22274 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #22274] Database backend 'random characters' not supported by database.lua
Follow-up Comment #8, bug #22274 (project freeciv): I had -DNDEBUG and searching patch of bug #19909 for assert brings up this suspect: + fc_assert(entry_str_get(pentry, value)); ___ Reply to this item at: http://gna.org/bugs/?22274 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #22287] Calculated advance costs written into ruleset
Follow-up Comment #1, bug #22287 (project freeciv): The attached patch fixes the issue for me. ___ Reply to this item at: http://gna.org/bugs/?22287 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #22274] Database backend 'random characters' not supported by database.lua
Update of bug #22274 (project freeciv): Status:None = Ready For Test ___ Follow-up Comment #9: Fix (file #21312) ___ Additional Item Attachment: File name: EntryStrGetSuccess.patch Size:0 KB ___ Reply to this item at: http://gna.org/bugs/?22274 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #4878] Cities cannot be built on Alien ruleset Boiling Oceans
Follow-up Comment #1, patch #4878 (project freeciv): - S2_5 version (file #21313) ___ Additional Item Attachment: File name: BoilingCities-S2_5.patch Size:1 KB ___ Reply to this item at: http://gna.org/patch/?4878 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #22274] Database backend 'random characters' not supported by database.lua
Follow-up Comment #10, bug #22274 (project freeciv): fc_assert(entry_str_get(pentry, value)); Good grief, what was I thinking? ___ Reply to this item at: http://gna.org/bugs/?22274 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
Re: [Freeciv-Dev] [bug #22274] Database backend 'random characters' not supported by database.lua
On 7 July 2014 02:48, Jacob Nevins no-reply.invalid-addr...@gna.org wrote: Follow-up Comment #10, bug #22274 (project freeciv): fc_assert(entry_str_get(pentry, value)); Good grief, what was I thinking? I think you were *not* thinking, for a decisecond or two. Coding is extreme sport - losing your alertness for a fraction of a second can cause you to burn. - ML ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #4877] Obsolete NoBonus road move mode
Update of patch #4877 (project freeciv): Status: Ready For Test = Done Assigned to:None = cazfi Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/patch/?4877 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #4903] Coding style: maxTileUnits = max_tile_units
Update of patch #4903 (project freeciv): Status: Ready For Test = Done Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/patch/?4903 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
