URL: https://github.com/freeipa/freeipa/pull/718
Title: #718: configure: fix AC_CHECK_LIB usage
lslebodn commented:
"""
A little bit offtopic. It is interesting that you look for the function `main`
in libkrad. Because it does not exist there. I've just noticed it.
```
sh# nm
URL: https://github.com/freeipa/freeipa/pull/718
Title: #718: configure: fix AC_CHECK_LIB usage
lslebodn commented:
"""
>It does not explicitly say what constitutes an unspecified value though.
```, , ``` or ``` , [] ,``` are considered as unspecified values and therefo
URL: https://github.com/freeipa/freeipa/pull/718
Title: #718: configure: fix AC_CHECK_LIB usage
lslebodn commented:
"""
>It does not explicitly say what constitutes an unspecified value though.
```[]``` means default action.
BTW it is not peculiar behaviour because most pro
URL: https://github.com/freeipa/bind-dyndb-ldap/pull/16
Title: #16: spec: remove unnecessary bind-pkcs11 dependency
lslebodn commented:
"""
I am not sure whether change to "requires" is ideal. Because after installation
of freeipa-dns with this spec file system wil
URL: https://github.com/freeipa/freeipa/pull/623
Title: #623: client install: do not assume /etc/krb5.conf.d exists
lslebodn commented:
"""
On (28/03/17 04:08), Christian Heimes wrote:
>The ipa-certauth plugin now starts to rely on the existence of
>```/etc/krb5.conf.
URL: https://github.com/freeipa/freeipa/pull/623
Title: #623: client install: do not assume /etc/krb5.conf.d exists
lslebodn commented:
"""
FYI: `/etc/krb5.conf.d` is not default include directory it is fedora/el7
specific.
debian testing has MIT kerberos 1.15 and `/etc/kr
URL: https://github.com/freeipa/freeipa/pull/623
Title: #623: client install: do not assume /etc/krb5.conf.d exists
lslebodn commented:
"""
FYI: `/etc/krb5.conf.d` is not default include directory it is fedora/el7
specific.
debian testing has MIT kerberos 1.15 and `/etc/kr
URL: https://github.com/freeipa/freeipa/pull/657
Title: #657: configure: fix --disable-server with certauth plugin
lslebodn commented:
"""
`AM_CONDITIONAL` need to be executed every time.
So just `AM_CONDITIONAL([BUILD_IPA_CERTAUTH_PLUGIN]` need to be moved from
sever.m4
URL: https://github.com/freeipa/freeipa/pull/657
Title: #657: configure: fix --disable-server with certauth plugin
lslebodn commented:
"""
`AM_CONDITIONAL` need to be executed every time.
So just `AM_CONDITIONAL([BUILD_IPA_CERTAUTH_PLUGIN]` need to be moved from
sever.m4
URL: https://github.com/freeipa/freeipa/pull/600
Title: #600: CONFIGURE: Improve detection of xmlrpc_c flags
lslebodn commented:
"""
On (15/03/17 08:14), MartinBasti wrote:
>Commit message amended before pushed
>
Thank you; I was busy with other tasks.
LS
""&q
URL: https://github.com/freeipa/freeipa/pull/599
Title: #599: CONFIGURE: Improve error messages for optional dependencies
lslebodn commented:
"""
@tiran one more time:
The approach in PR #502 was not accepted in upstream discussion
https://www.redhat.com/archives/freeipa-d
URL: https://github.com/freeipa/freeipa/pull/599
Title: #599: CONFIGURE: Improve error messages for optional dependencies
lslebodn commented:
"""
>NACK, you are changing the spirit of the accepted PR #502.
The approach PR #502 was not accepted in upstream discussion
http
URL: https://github.com/freeipa/freeipa/pull/600
Title: #600: CONFIGURE: Improve detection of xmlrpc_c flags
lslebodn commented:
"""
@tjaalton It should simplify you work on debian
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/600#issuecom
URL: https://github.com/freeipa/freeipa/pull/600
Author: lslebodn
Title: #600: CONFIGURE: Improve detection of xmlrpc_c flags
Action: opened
PR body:
"""
The pkg-config files for xmlrpc_c libraries are shipped just
in fedora/rhel due to downstream patch. Debian does not have
p
URL: https://github.com/freeipa/freeipa/pull/599
Author: lslebodn
Title: #599: CONFIGURE: Improve error messages for optional dependencies
Action: synchronized
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/599/head:pr599
git
URL: https://github.com/freeipa/freeipa/pull/599
Author: lslebodn
Title: #599: CONFIGURE: Improve error messages for optional dependencies
Action: opened
PR body:
"""
https://www.redhat.com/archives/freeipa-devel/2017-March/msg00307.html
"""
To pull the PR
URL: https://github.com/freeipa/freeipa/pull/502
Title: #502: Make pylint and jsl optional
lslebodn commented:
"""
On (15/03/17 05:32), Petr Vobornik wrote:
>In any case spending so much time discussing so minor change is a waste of
>time. I'd push it.
>
Will you acc
URL: https://github.com/freeipa/freeipa/pull/502
Title: #502: Make pylint and jsl optional
lslebodn commented:
"""
On (15/03/17 05:17), Jan Cholasta wrote:
>@lslebodn, nobody said that this has to be the last lint build related patch
>ever, we can change the behavi
URL: https://github.com/freeipa/freeipa/pull/502
Title: #502: Make pylint and jsl optional
lslebodn commented:
"""
On (14/03/17 16:05), Christian Heimes wrote:
>https://github.com/freeipa/freeipa/pull/502#issue-209980292
>
>two thumbs up, one heart, no thumbs dow
URL: https://github.com/freeipa/freeipa/pull/502
Title: #502: Make pylint and jsl optional
lslebodn commented:
"""
>PR #593 is not related to default yes; It is about something else.
Current version does not fix concerns; because default should be yes as it was
d
URL: https://github.com/freeipa/freeipa/pull/502
Title: #502: Make pylint and jsl optional
lslebodn commented:
"""
>PR #593 is not related to default yes; It is about something else.
Current version does not fix concerns; because default should be yes as it was
d
URL: https://github.com/freeipa/freeipa/pull/502
Title: #502: Make pylint and jsl optional
lslebodn commented:
"""
> This PR makes packaging IPA 4.5 on RHEL 7 easier for me, so thumbs up from me.
I understand it is more convenient to have less extra configu
URL: https://github.com/freeipa/freeipa/pull/502
Title: #502: Make pylint and jsl optional
lslebodn commented:
"""
> This PR makes packaging IPA 4.5 on RHEL 7 easier for me, so thumbs up from me.
I understand it is more convenient to have less extra configu
URL: https://github.com/freeipa/freeipa/pull/502
Title: #502: Make pylint and jsl optional
lslebodn commented:
"""
>PR #593 is not related to default yes; It is about something else.
Current version does not fix concerns; because default should be yes as it was
d
URL: https://github.com/freeipa/freeipa/pull/596
Title: #596: spec file: support client-only build
lslebodn commented:
"""
On (15/03/17 02:32), Jan Cholasta wrote:
>I can't, both are required to build client components (`ipa-getkeytab`
>specifically), moving them to the
URL: https://github.com/freeipa/freeipa/pull/591
Title: #591: spec file: add unconditional python-setuptools BuildRequires
lslebodn commented:
"""
Post push comment. This is a reason why there was configure time check in
**rejected** PR#494.
Spec file change is not very up
URL: https://github.com/freeipa/freeipa/pull/596
Title: #596: spec file: support client-only build
lslebodn commented:
"""
You can also move few dependencies to server only build
```
BuildRequires: libini_config-devel
BuildRequires: cyrus-sasl-devel
```
Check spec file change
URL: https://github.com/freeipa/freeipa/pull/502
Title: #502: Make pylint and jsl optional
lslebodn commented:
"""
On (14/03/17 09:56), Christian Heimes wrote:
>The PR got three +1 / heart and not -1. I propose to get it merged for 4.5
>today.
>
I cannot see 3-times
URL: https://github.com/freeipa/freeipa/pull/414
Title: #414: SPEC: Update SELinux file context of ipa-otpd
lslebodn commented:
"""
On (10/03/17 00:28), Martin Babinsky wrote:
>@lslebodn CI complains that your changes produce an invalid specfile. Can you
>please fix th
URL: https://github.com/freeipa/freeipa/pull/502
Title: #502: Make pylint and jsl optional
lslebodn commented:
"""
I am still expect some comment from @rcritten
LS
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/502#issuecomment-28393871
URL: https://github.com/freeipa/freeipa/pull/502
Title: #502: Make pylint and jsl optional
lslebodn commented:
"""
On (01/03/17 22:37), Jan Cholasta wrote:
>I tend to agree with @lslebodn, but I don't have a strong opinion on this. I
>noticed a couple of issues though:
&
URL: https://github.com/freeipa/freeipa/pull/502
Title: #502: Make pylint and jsl optional
lslebodn commented:
"""
On (01/03/17 09:39), Petr Vobornik wrote:
>+1 Reasoning for not skipping linters was that reviewer or patch author can
>forget to run those. This problem
URL: https://github.com/freeipa/freeipa/pull/502
Title: #502: Make pylint and jsl optional
lslebodn commented:
"""
> But you're right we should update the wiki pages to mention the new defaults.
Such change require broader discussion.
e.g. I know that @rcritten had strong op
URL: https://github.com/freeipa/freeipa/pull/502
Title: #502: Make pylint and jsl optional
lslebodn commented:
"""
It was explained on IRC
> < cheimes> lslebodn: Your proposal is missing the point of the ticket. It
> doesn't not simplify
> build
URL: https://github.com/freeipa/freeipa/pull/502
Title: #502: Make pylint and jsl optional
lslebodn commented:
"""
Please add explanation to the thumb down
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/502#issuecomment-28330932
URL: https://github.com/freeipa/freeipa/pull/501
Title: #501: C compilation fixes and hardening
lslebodn commented:
"""
I know it's closed.
It was just a kindly reminder to address obvious problems as part of review
process.
"""
See the full comment at
http
URL: https://github.com/freeipa/freeipa/pull/502
Title: #502: Make pylint and jsl optional
lslebodn commented:
"""
Writing hint together with error is the simplest solution. And still remind
developers to install pylint/jslint.
e.g.
```
diff --git a/configure.ac b/configure.ac
URL: https://github.com/freeipa/freeipa/pull/501
Title: #501: C compilation fixes and hardening
lslebodn commented:
"""
FYI; it is far far away from best practice to modify `CFLAGS` and configure
time; unless you test compiler options. Such change should be in makef
URL: https://github.com/freeipa/freeipa/pull/502
Title: #502: Make pylint and jsl optional
lslebodn commented:
"""
May I know why the default was changed without design discussion?
IIRC pscacek intentionally enabled it by default. Much better approach would be
to print hint at
URL: https://github.com/freeipa/freeipa/pull/472
Title: #472: Packaging: Add placeholder packages
lslebodn commented:
"""
NACK for downstream patch. The intentin of build system refactoring was make
packaging in downstream simpler.
"""
See the full comment
URL: https://github.com/freeipa/freeipa/pull/472
Title: #472: Packaging: Add placeholder packages
lslebodn commented:
"""
NACK for downstream patch. The intentin of build system refactoring was make
packaging in downstream simpler.
"""
See the full comment
URL: https://github.com/freeipa/freeipa/pull/472
Title: #472: Packaging: Add placeholder packages
lslebodn commented:
"""
FYI: At the moment, `make check` run just C-based unit test and all of them are
optional.
If required dependency is not found at configure time then tes
URL: https://github.com/freeipa/freeipa/pull/472
Title: #472: Packaging: Add placeholder packages
lslebodn commented:
"""
I agree with @MartinBasti it is not a unit test.
IMHO better approach is to test it in CI/travis/...
"""
See the full comment at
https://g
URL: https://github.com/freeipa/freeipa/pull/364
Title: #364: Client-only builds with --disable-server
lslebodn commented:
"""
>Thanks for your contribution. I added your patch to my PR. On my system I ran
>into a minor issue. >Some C99 types like uint8_t we
URL: https://github.com/freeipa/freeipa/pull/364
Title: #364: Client-only builds with --disable-server
lslebodn commented:
"""
On (22/02/17 06:16), Simo Sorce wrote:
>So this is the reasoning and why I am approving this PR and not #494.
>
>When you build all component
URL: https://github.com/freeipa/freeipa/pull/494
Title: #494: Support client-only build
lslebodn commented:
"""
On (22/02/17 01:52), Tomas Krizek wrote:
>@lslebodn My bad, there was some leftover stuff that `git clean -dfx` didn't
>clear for some reason.
>
>N
URL: https://github.com/freeipa/freeipa/pull/494
Title: #494: Support client-only build
lslebodn commented:
"""
On (22/02/17 03:24), Christian Heimes wrote:
>python-requests is a bad example because it suffers from the same issue as IPA.
>
>A better example is any oth
URL: https://github.com/freeipa/freeipa/pull/494
Title: #494: Support client-only build
lslebodn commented:
"""
On (22/02/17 03:24), Christian Heimes wrote:
>python-requests is a bad example because it suffers from the same issue as IPA.
>
>A better example is any oth
URL: https://github.com/freeipa/freeipa/pull/364
Title: #364: Client-only builds with --disable-server
lslebodn commented:
"""
>Thanks for your contribution. I added your patch to my PR. On my system I ran
>into a minor issue. >Some C99 types like uint8_t we
URL: https://github.com/freeipa/freeipa/pull/494
Title: #494: Support client-only build
lslebodn commented:
"""
On (22/02/17 03:04), Christian Heimes wrote:
>You are aware that your example code checks the wrong code? It is testing
>in-tree sources, not the actual sour
URL: https://github.com/freeipa/freeipa/pull/494
Title: #494: Support client-only build
lslebodn commented:
"""
On (22/02/17 02:51), Christian Heimes wrote:
>You assumption is incorrect. ```ipatests``` does not depend on
>```ipaserver```,
>https://github.com/fre
URL: https://github.com/freeipa/freeipa/pull/494
Title: #494: Support client-only build
lslebodn commented:
"""
On (22/02/17 02:09), Christian Heimes wrote:
>There are two reasons we decided on ```--without-ipatests```:
>
>* ```--with-tests``` / ```--without-tests``` is
URL: https://github.com/freeipa/freeipa/pull/494
Title: #494: Support client-only build
lslebodn commented:
"""
On (22/02/17 02:23), Christian Heimes wrote:
>tiran requested changes on this pull request.
>
>see comments
>
>> -CFLAGS="$bck_cflags"
>-
URL: https://github.com/freeipa/freeipa/pull/494
Title: #494: Support client-only build
lslebodn commented:
"""
On (22/02/17 02:16), Christian Heimes wrote:
>NACK on 42fb9b1c
>
>* Either use ```--with-ipaplatform=redhat``` on CentOS
>* Or implement a proper way to fi
URL: https://github.com/freeipa/freeipa/pull/494
Author: lslebodn
Title: #494: Support client-only build
Action: synchronized
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/494/head:pr494
git checkout pr494
From
URL: https://github.com/freeipa/freeipa/pull/494
Title: #494: Support client-only build
lslebodn commented:
"""
On (22/02/17 01:43), Christian Heimes wrote:
>NACK on aece4c3c
>
>We compromised on ```--without-ipatests``` with installation of ipatests
>default
URL: https://github.com/freeipa/freeipa/pull/494
Title: #494: Support client-only build
lslebodn commented:
"""
BTW I tested client-only build on fedora24, fedora25, fedora rawhide,
epel7, debian stable, debian testing, debian unstable
"""
See the full comment
URL: https://github.com/freeipa/freeipa/pull/494
Title: #494: Support client-only build
lslebodn commented:
"""
On (22/02/17 00:59), Tomas Krizek wrote:
>I'm not able to run autoreconf, it fails with the following error:
>
>```
>configure.ac:447: error: required file
URL: https://github.com/freeipa/freeipa/pull/494
Author: lslebodn
Title: #494: Support client-only build
Action: opened
PR body:
"""
How to test:
* autoreconf -if
* ./configure --disable-server
* make srpms
* mock --rebuild dist/rpms/freeipa-4.4.90.*.src.rpm --resultdir .
*
URL: https://github.com/freeipa/freeipa/pull/364
Title: #364: Client-only builds with --disable-server
lslebodn commented:
"""
It looks like @tiran does not want to move this PR forward.
So here is a link to patch which does not misuse client-only
build and add configure time op
URL: https://github.com/freeipa/freeipa/pull/364
Title: #364: Client-only builds with --disable-server
lslebodn commented:
"""
On (17/02/17 01:12), Petr Vobornik wrote:
>I still fail to see why we should care about `make dist` with `configure
>--disable-server` this
URL: https://github.com/freeipa/freeipa/pull/364
Title: #364: Client-only builds with --disable-server
lslebodn commented:
"""
On (16/02/17 02:30), Christian Heimes wrote:
>Lukas, you are wasting both my and your precious time with a needless
>bike-shedding discu
URL: https://github.com/freeipa/freeipa/pull/364
Title: #364: Client-only builds with --disable-server
lslebodn commented:
"""
On (16/02/17 00:57), Christian Heimes wrote:
>You are missing the point. Obviously tests are an important part of building.
>I can't test the clie
URL: https://github.com/freeipa/freeipa/pull/364
Title: #364: Client-only builds with --disable-server
lslebodn commented:
"""
On (14/02/17 02:29), Christian Heimes wrote:
>I'm following a different design and development philosophy. In my experience
>an iterativ
URL: https://github.com/freeipa/freeipa/pull/364
Title: #364: Client-only builds with --disable-server
lslebodn commented:
"""
On (13/02/17 05:05), Christian Heimes wrote:
>I'm following the development principals of **minimum viable product**. This
>PR solves a cri
URL: https://github.com/freeipa/freeipa/pull/364
Title: #364: Client-only builds with --disable-server
lslebodn commented:
"""
On (13/02/17 04:32), Christian Heimes wrote:
>No, the test runner should either detect missing packages and skip tests
>automatically, or should g
URL: https://github.com/freeipa/freeipa/pull/364
Title: #364: Client-only builds with --disable-server
lslebodn commented:
"""
On (13/02/17 03:56), Christian Heimes wrote:
>Two reasons
>
>1. ```make install```
>2. I need ipatests to be part of the build proce
URL: https://github.com/freeipa/freeipa/pull/364
Title: #364: Client-only builds with --disable-server
lslebodn commented:
"""
On (13/02/17 03:08), Christian Heimes wrote:
>Packaging is a different issue. The PR does not provide RPM packaging for
>client-only build.
URL: https://github.com/freeipa/freeipa/pull/364
Title: #364: Client-only builds with --disable-server
lslebodn commented:
"""
On (13/02/17 01:25), Christian Heimes wrote:
>@lslebodn it works even better without your proposed changes. Parts
>```ipatests``` work fine fo
URL: https://github.com/freeipa/freeipa/pull/364
Title: #364: Client-only builds with --disable-server
lslebodn commented:
"""
It works quite good with the following change
```
diff --git a/Makefile.am b/Makefile.am
index 311f6121f..13e5a87b0 100644
--- a/Makefile.am
+++ b/Makef
URL: https://github.com/freeipa/freeipa/pull/364
Title: #364: Client-only builds with --disable-server
lslebodn commented:
"""
On (10/02/17 06:11), Petr Vobornik wrote:
>I still think that this use case needs to be documented in
>http://www.freeipa.org/page/V4/Bui
URL: https://github.com/freeipa/freeipa/pull/364
Title: #364: Client-only builds with --disable-server
lslebodn commented:
"""
See inline comment and issue above; otherwise LGTM.
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/364#issuecom
URL: https://github.com/freeipa/freeipa/pull/364
Title: #364: Client-only builds with --disable-server
lslebodn commented:
"""
`make dist` failed if configure was executed with `--disable-server`
```
make[3]: Leaving directory '/workdir/freeipa/po'
make[2]: Leaving directory '/
URL: https://github.com/freeipa/freeipa/pull/414
Author: lslebodn
Title: #414: SPEC: Update SELinux file context of ipa-otpd
Action: opened
PR body:
"""
The ipa-otpd binary was moved but SELinux was not updated.
This is a workaround for developers who develop on platforms
wit
URL: https://github.com/freeipa/freeipa/pull/389
Title: #389: Fix build in mock
lslebodn commented:
"""
@tiran or @pvomacka, @tomaskrizek It would be good if you could test/ack the
latest version of the patch.
Because currently it is not possible to build freeIPA with ups
URL: https://github.com/freeipa/freeipa/pull/364
Title: #364: Client-only builds with --disable-server
lslebodn commented:
"""
I fine with ignoring python related parts; but it should be documented. But you
might ask other freeIPA developers. (maybe on freeipa-devel)
"&quo
URL: https://github.com/freeipa/freeipa/pull/364
Title: #364: Client-only builds with --disable-server
lslebodn commented:
"""
I think it would be simpler to read the code without to many `AM_COND_IF()`.
IMHO it would be simpler to move C-related part to separate file (e.g.
`se
URL: https://github.com/freeipa/freeipa/pull/389
Title: #389: Fix build in mock
lslebodn commented:
"""
I updated doc help do jslint in latest version
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/389#issuecomment-271931555
--
Manage you
URL: https://github.com/freeipa/freeipa/pull/389
Author: lslebodn
Title: #389: Fix build in mock
Action: synchronized
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/389/head:pr389
git checkout pr389
From
URL: https://github.com/freeipa/freeipa/pull/389
Author: lslebodn
Title: #389: Fix build in mock
Action: synchronized
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/389/head:pr389
git checkout pr389
From
URL: https://github.com/freeipa/freeipa/pull/389
Author: lslebodn
Title: #389: Fix build in mock
Action: synchronized
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/389/head:pr389
git checkout pr389
From
URL: https://github.com/freeipa/freeipa/pull/389
Author: lslebodn
Title: #389: Fix build in mock
Action: opened
PR body:
"""
"""
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/389/head
URL: https://github.com/freeipa/freeipa/pull/238
Title: #238: Build system refactoring phase 8: update translation system
lslebodn commented:
"""
>Your patch adds `config.rpath`. Is it necessary to include the file in source
>control? certmonger and sssd use the file but
URL: https://github.com/freeipa/freeipa/pull/236
Title: #236: Build phase 7: cleanup
lslebodn commented:
"""
Thank you very much for removing problematic patch. Do not forget to remove it
from "Build phase 8" :-) as well
A) there are few conflicts => patch
URL: https://github.com/freeipa/freeipa/pull/238
Title: #238: Build system refactoring phase 8: update translation system
lslebodn commented:
"""
and also
```
Making install in po
make[1]: Entering directory '/home/user/freeipa/po'
make[1]: *** No rule to make target 'install'
URL: https://github.com/freeipa/freeipa/pull/236
Title: #236: Build phase 7: cleanup
lslebodn commented:
"""
>Hi Lukas. Given there is no technical justification to have it I'm going to
>remove these. Simple is better than complex.
I am sorry I do not agree. The te
URL: https://github.com/freeipa/freeipa/pull/236
Title: #236: Build phase 7: cleanup
lslebodn commented:
"""
You should the opposite of the last patch "Build: clean-up spurious NULL
variables from Makefile.am files". The NULL should be added to each list.
NACK t
URL: https://github.com/freeipa/freeipa/pull/208
Title: #208: Tests: Fix integration sudo test
lslebodn commented:
"""
All versions of Fedora have sudo 1.8.18.
And thank you very much for nice/verbose explanation in commit message
ACK
"""
See the full comment
URL: https://github.com/freeipa/freeipa/pull/171
Title: #171: Build system cleanup phase 2
lslebodn commented:
"""
On (20/10/16 10:29), Petr Špaček wrote:
>@lslebodn I'm really trying to explain this but I'm still not able to get the
>point across.
>> My concerns a
URL: https://github.com/freeipa/freeipa/pull/171
Title: #171: Build system cleanup phase 2
lslebodn commented:
"""
We (lslebodn and pspacek) agree that we disagree about maintainability of
client_only in one monolithic configure.ac.
But we agreed that the refactoring of
URL: https://github.com/freeipa/freeipa/pull/171
Title: #171: Build system cleanup phase 2
lslebodn commented:
"""
On (21/10/16 00:41), Petr Špaček wrote:
>> Correct me If I am wrong. The configure script is and will be used
>just for detection of build dependencies
URL: https://github.com/freeipa/freeipa/pull/171
Title: #171: Build system cleanup phase 2
lslebodn commented:
"""
On (20/10/16 10:29), Petr Špaček wrote:
>@lslebodn I'm really trying to explain this but I'm still not able to get the
>point across.
>> My concerns a
URL: https://github.com/freeipa/freeipa/pull/171
Title: #171: Build system cleanup phase 2
lslebodn commented:
"""
On (20/10/16 10:29), Petr Špaček wrote:
>@lslebodn I'm really trying to explain this but I'm still not able to get the
>point across.
>> My concerns a
URL: https://github.com/freeipa/freeipa/pull/171
Title: #171: Build system cleanup phase 2
lslebodn commented:
"""
> 08:53 < pspacek> lslebodn: I would appreciate patch showing the nicer
> solution to me. I do not think it
> is that easy as you c
URL: https://github.com/freeipa/freeipa/pull/171
Title: #171: Build system cleanup phase 2
lslebodn commented:
"""
> 08:53 < pspacek> lslebodn: I would appreciate patch showing the nicer
> solution to me. I do not think it
> is that easy as you c
URL: https://github.com/freeipa/freeipa/pull/171
Title: #171: Build system cleanup phase 2
lslebodn commented:
"""
> 08:53 < pspacek> lslebodn: I would appreciate patch showing the nicer
> solution to me. I do not think it
> is that easy as you c
URL: https://github.com/freeipa/freeipa/pull/171
Title: #171: Build system cleanup phase 2
lslebodn commented:
"""
> Please note that current client-only build is quite broken and requires heavy
> machinery in downstream spec file so it is hard to speak about any reusag
URL: https://github.com/freeipa/freeipa/pull/171
Title: #171: Build system cleanup phase 2
lslebodn commented:
"""
My proposal would not require any reimplementation because it will reuse
current solution.
And I would like to know the reasons why upstream might consider to dr
URL: https://github.com/freeipa/freeipa/pull/171
Title: #171: Build system cleanup phase 2
lslebodn commented:
"""
BTW I am really interested in how do you plan to implement client only build.
IMHO it would be much simpler include reduced version of daemon/configure.ac
(+o
URL: https://github.com/freeipa/freeipa/pull/171
Title: #171: Build system cleanup phase 2
lslebodn commented:
"""
I see you need to increase patch_count and not to have proper review
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/171#iss
1 - 100 of 109 matches
Mail list logo
