Re: [Openocd-development] startup.tcl should be shipped as plaintext

2009-11-30 Thread Zach Welch
On Mon, 2009-11-30 at 10:21 +0100, Øyvind Harboe wrote: The error messages in embedded:startup.tcl refer to line numbers. It would be good to distribute startup.tcl for reference, even if it is not required. If the user can't look in the source code, then they need to report the bug to

Re: [Openocd-development] [PATCH] Revert improve alloc_vprintf

2009-11-30 Thread Zach Welch
The proper solution: tell the maintainers of your vsnprintf to improve their implementation! ;) --Z On Mon, 2009-11-30 at 02:20 -0800, Zach Welch wrote: Do not apply. The old implementation was total crap, and your vsnprintf implementation must be too. That's not our problem, and it can

Re: [Openocd-development] [PATCH 0/4] add stack backtracing

2009-11-30 Thread Zach Welch
On Mon, 2009-11-30 at 03:04 -0800, Zachary T Welch wrote: Hi all, This series creates two new helper APIs: 'module' and 'stack'. It applies on top of my outstanding patches; pull from repo.or.cz. FWIW, I have pushed a revised version of these to my mirror to include proper copyright blurbs

Re: [Openocd-development] [PATCH] arm: dcc_downloads and fast_memory_access are now enabled by default

2009-11-30 Thread Zach Welch
I think David has explained why this is not a good idea for a default. It is not always safe and presents an option that would need to be disabled when bringing up new boards. Bring-up is hard enough without having to fight the tools from trying to be smarter than they are. On Mon, 2009-11-30 at

Re: [Openocd-development] [PATCH 0/3] deferred 'init' and leaner 'help'

2009-11-30 Thread Zach Welch
On Sun, 2009-11-29 at 14:33 -0800, Zachary T Welch wrote: Hi all, These patches clean up the server and system startup. The first patch factors the GDB server setup to be more conducive to deferred initialization of targets (in a later series). The second provides the 'noinit' command

Re: [Openocd-development] [PUSHED 0/4] minor cleaning and audit

2009-11-30 Thread Zach Welch
On Sun, 2009-11-29 at 19:00 -0800, Zachary T Welch wrote: Hi all, This series includes only minor changes. Applies on top of the last series to allow deferred 'init'. Share and Enjoy, --Z ___ Openocd-development mailing list

Re: [Openocd-development] [PUSHED 0/5] remove interp global variable

2009-11-30 Thread Zach Welch
On Sun, 2009-11-29 at 19:03 -0800, Zachary T Welch wrote: Hi all, This series removes the 'interp' global variable from the system, bringing us a step closer to supporting several active command contexts. Share and Enjoy, --Z ___

Re: [Openocd-development] [PATCH 1/4] add 'module' helper module

2009-11-30 Thread Zach Welch
On Mon, 2009-11-30 at 14:38 -0800, David Brownell wrote: On Monday 30 November 2009, Zachary T Welch wrote: Adds a fully-documented API for dynamically loading libraries and looking up symbols or addresses in them. Seems to me I've seen one or two or three or four of these before ... must

Re: [Openocd-development] [PATCH 2/4] produce stack traces on segfaults

2009-11-30 Thread Zach Welch
On Mon, 2009-11-30 at 14:42 -0800, David Brownell wrote: On Monday 30 November 2009, Zachary T Welch wrote: Registers a signal handler to catch SIGSEGV in order to display the stack where the program crashed. Is this for inside OpenOCD? If so, I'd rather just expect folk to run inside

Re: [Openocd-development] [PATCH] arm: dcc_downloads and fast_memory_access are now enabled by default

2009-11-30 Thread Zach Welch
On Tue, 2009-12-01 at 08:08 +0100, Øyvind Harboe wrote: On Mon, Nov 30, 2009 at 10:19 PM, Zach Welch z...@superlucidity.net wrote: I think David has explained why this is not a good idea for a default. It is not always safe and presents an option that would need to be disabled when bringing

Re: [Openocd-development] [patch 3/5] ARM: implement mrc()/mcr() as DPM ops

2009-11-30 Thread Zach Welch
On Mon, 2009-11-30 at 23:42 -0800, David Brownell wrote: On Monday 30 November 2009, David Brownell wrote: (Patches to move the mrc and mcr code into struct arm are due too ... MIPS and other cores do not support those ARM-specific concepts.) Needed for testing, even ... here it is.

Re: [Openocd-development] everything must be used before init ??

2009-11-29 Thread Zach Welch
Excellent. I came up with nearly the same patch before running out for the evening. The difference being that I put _after_ the last possible failure path, so it's possible to recover and try again. On Sat, 2009-11-28 at 22:43 -0800, David Brownell wrote: On Saturday 28 November 2009, David

Re: [Openocd-development] everything must be used before init ??

2009-11-29 Thread Zach Welch
On Sat, 2009-11-28 at 18:16 -0800, David Brownell wrote: On Saturday 28 November 2009, Zach Welch wrote: Yeah, I figure there are some scripts (or users) that have not been sufficiently strict about CONFIG vs. EXEC modes, as that logic has been broken for ages Broken how? It's

Re: [Openocd-development] [RFC] massive command restructuring!!!

2009-11-29 Thread Zach Welch
On Sun, 2009-11-29 at 18:47 +0100, Øyvind Harboe wrote: Finally, would it be logical to create the dynamic flash banks commands as subcommands of their relevant target? foo.cpu flash bank bank0 . # but no target arg anymore foo.cpu bank0 info # presently, it's 'flash

Re: [Openocd-development] [RFC] massive command restructuring!!!

2009-11-29 Thread Zach Welch
On Sun, 2009-11-29 at 21:01 +0100, Øyvind Harboe wrote: I disagree. You can't use flash without a target. We should never offer that command without a target for it to be used with. The user should not need to pull the two together on their own. Sure you can! I even believe that there

Re: [Openocd-development] [RFC] proposal to fix another regression

2009-11-28 Thread Zach Welch
On Fri, 2009-11-27 at 19:31 -0800, Zach Welch wrote: On Fri, 2009-11-27 at 16:24 -0800, Zach Welch wrote: Well, drat. The patch that I pushed had some unintended consequences. Any Jim subcommand handlers' output now gets suppressed too, which negatively affected my recently posted series

Re: [Openocd-development] [PUSHED] command improvements

2009-11-28 Thread Zach Welch
On Sat, 2009-11-28 at 09:48 -0800, Zach Welch wrote: On Fri, 2009-11-27 at 19:31 -0800, Zach Welch wrote: On Fri, 2009-11-27 at 16:24 -0800, Zach Welch wrote: Well, drat. The patch that I pushed had some unintended consequences. Any Jim subcommand handlers' output now gets suppressed too

[Openocd-development] [rfc] improving 'help'... volunteers?

2009-11-28 Thread Zach Welch
Hi all, Some additional patches could improve the help system further. First, the command name matching logic can be improved to allow partial matching and better support invalid subcommand invocations (e.g. running 'dummy missing' should produce the help for 'dummy', but it shows the generic

Re: [Openocd-development] [rfc] improving 'help'... volunteers?

2009-11-28 Thread Zach Welch
On Sat, 2009-11-28 at 14:07 -0800, David Brownell wrote: On Saturday 28 November 2009, Zach Welch wrote: Next, we should consider updating all help messages to full sentences, so the new command mode information will follow the final period. And make sure the usage is all strict BNF. I

[Openocd-development] [RFC] massive command restructuring!!!

2009-11-28 Thread Zach Welch
Hi all, I used exclamation points in $SUBJECT, because these suggestions will have drastic user-visible impact -- though the effects can be mitigated. All of the work done that I have done recently on the command handling system has established a foundation for migrating the script language to

Re: [Openocd-development] everything must be used before init ??

2009-11-28 Thread Zach Welch
On Sat, 2009-11-28 at 15:10 -0800, David Brownell wrote: I just pulled everything into a workspace and built it ... now it's failing left and right. It complains about using poll off and jtag_reset 1 1 after reset, which is when they're supposed to be usable... I had tested that the patch

Re: [Openocd-development] everything must be used before init ??

2009-11-28 Thread Zach Welch
On Sat, 2009-11-28 at 15:21 -0800, David Brownell wrote: On Saturday 28 November 2009, David Brownell wrote: I just pulled everything into a workspace and built it ... now it's failing left and right. It complains about using poll off and jtag_reset 1 1 after reset, which is when

Re: [Openocd-development] [s3c24xx_nand fix ]

2009-11-28 Thread Zach Welch
Thanks! I'll push this shortly, as it seems like the sort of thing that would accidentally get dropped during my cleanup efforts. I'll take your word that it works. :) On Sat, 2009-11-28 at 23:41 +, lementec fabien wrote: Hi, there is a bug in s3c24xx_nand. Here the fix: diff --git

Re: [Openocd-development] everything must be used before init ??

2009-11-28 Thread Zach Welch
On Sat, 2009-11-28 at 16:36 -0800, David Brownell wrote: On Saturday 28 November 2009, Zach Welch wrote: I believe that the real problem is that the .mode initializer for those commands' registration records have been marked incorrectly. There may be others It's easy to discover

Re: [Openocd-development] [Patch 0/8] more command cleaning

2009-11-27 Thread Zach Welch
On Fri, 2009-11-27 at 07:55 +0100, Øyvind Harboe wrote: Does this change the syntax for scripts? No, but it does extend it. All relevant top-level commands have been made available underneath the jtag and target-instance commands. --Z ___

Re: [Openocd-development] [PATCH 5/8] add more stub handlers to testee target

2009-11-27 Thread Zach Welch
On Fri, 2009-11-27 at 07:56 +0100, Øyvind Harboe wrote: What's this??? A pure virtual test target? Does it work with the dummy interface and faux flash driver? Would be neat :-) That's the idea. It's a work in progress that went in during my initial command registration restructuring,

Re: [Openocd-development] [Patch 0/8] more command cleaning

2009-11-27 Thread Zach Welch
On Thu, 2009-11-26 at 23:37 -0800, David Brownell wrote: On Thursday 26 November 2009, Øyvind Harboe wrote: Does this change the syntax for scripts? And what might have caused nand list output to repeat? As if the command got called twice... nand list #0: NAND 1GiB 3,3V 8-bit (Micron)

Re: [Openocd-development] Fix interface regression

2009-11-27 Thread Zach Welch
On Fri, 2009-11-27 at 19:52 +0100, Øyvind Harboe wrote: Fixes regression in interface command registration. master branch currently fails to build with --enable-minidriver-dummy (and other interfaces). Do not apply. The register_commands callback was removed on purpose, as it does not

Re: [Openocd-development] Fix interface regression

2009-11-27 Thread Zach Welch
On Fri, 2009-11-27 at 11:00 -0800, Zach Welch wrote: On Fri, 2009-11-27 at 19:52 +0100, Øyvind Harboe wrote: Fixes regression in interface command registration. master branch currently fails to build with --enable-minidriver-dummy (and other interfaces). Do not apply

Re: [Openocd-development] Fix interface regression

2009-11-27 Thread Zach Welch
On Fri, 2009-11-27 at 20:48 +0100, Øyvind Harboe wrote: On Fri, Nov 27, 2009 at 8:00 PM, Zach Welch z...@superlucidity.net wrote: On Fri, 2009-11-27 at 19:52 +0100, Øyvind Harboe wrote: Fixes regression in interface command registration. master branch currently fails to build

Re: [Openocd-development] [Patch 0/8] more command cleaning

2009-11-27 Thread Zach Welch
On Fri, 2009-11-27 at 12:47 -0800, David Brownell wrote: On Friday 27 November 2009, Zach Welch wrote: And what might have caused nand list output to repeat? As if the command got called twice... Saw the same with arm reg. Do all commands repeat their output? All not-top-level

Re: [Openocd-development] [RFC] proposal to fix another regression

2009-11-27 Thread Zach Welch
On Fri, 2009-11-27 at 16:24 -0800, Zach Welch wrote: Well, drat. The patch that I pushed had some unintended consequences. Any Jim subcommand handlers' output now gets suppressed too, which negatively affected my recently posted series to split apart the top-level Jim handlers. The patches

Re: [Openocd-development] write_phys_memory and read_phys_memory

2009-11-26 Thread Zach Welch
On Thu, 2009-11-26 at 14:05 +0100, Øyvind Harboe wrote: Hi Andrey, Error: type 'xscale' is missing write_phys_memory Error: type 'xscale' is missing read_phys_memory Ignore these errors. They are only reminders to the developers to add this support to the xscale target. I saw these two

Re: [Openocd-development] 'erase_sector' and 'protect' flash commands

2009-11-26 Thread Zach Welch
Pushed, with another minor-but-related help text fix. Thanks! --Z On Wed, 2009-11-25 at 08:36 -0500, Eric Wetzel wrote: Hello, 'flash erase_sector' and 'flash protect' have not been working for me recently. Passing them the correct number of arguments (3 and 4, respectively) returns the

Re: [Openocd-development] [PATCH] pull request: Typos and documentation fixes

2009-11-26 Thread Zach Welch
On Thu, 2009-11-26 at 18:12 +0100, Uwe Hermann wrote: Hi, please pull from the doc-fixes branch from my OpenOCD repo: Clone URL: git clone git://gitorious.org/openocd/openocd.git The branch has a bunch of minor typos and documentation fixes. Pulled, rebased against the current

Re: [Openocd-development] [SERIES 0/6:0/84] command registration

2009-11-25 Thread Zach Welch
On Tue, 2009-11-24 at 14:02 -0800, Zach Welch wrote: Hi all, I have finished my series to convert the tree to use the improved command registration methodology. I apologize for the number of patches in these series; however, only a handful of patches are bigger than 10K, and most are just

Re: [Openocd-development] [PUSHED 6/6:88/84] command registration

2009-11-25 Thread Zach Welch
On Wed, 2009-11-25 at 10:45 -0800, Zach Welch wrote: On Tue, 2009-11-24 at 14:02 -0800, Zach Welch wrote: Hi all, I have finished my series to convert the tree to use the improved command registration methodology. I apologize for the number of patches in these series; however, only

Re: [Openocd-development] [PATCH 07/10] allow target_type.h to be included alone

2009-11-25 Thread Zach Welch
On Wed, 2009-11-25 at 13:08 -0800, David Brownell wrote: On Tuesday 24 November 2009, Zach Welch wrote: On Tue, 2009-11-24 at 16:54 -0800, David Brownell wrote: On Tuesday 24 November 2009, z...@superlucidity.net wrote: [snip] That said, it feels like very bad form to omit forward

Re: [Openocd-development] [PATCH 0/8] unify usb device opening

2009-11-24 Thread Zach Welch
On Thu, 2009-11-19 at 14:53 -0800, Zachary T Welch wrote: Hi all, Add jtag/usb_common.[ch] to hold routines shared between the USB JTAG interface drivers. This series adds the first helper, jtag_usb_open that unifies the steps required to probe the USB busses and devices, matching

Re: [Openocd-development] Document build broken when src != build

2009-11-24 Thread Zach Welch
On Sun, 2009-11-22 at 10:17 +0100, Øyvind Harboe wrote: I can no longer build docs when src != build. I believe this is trivially reproducible and that the breakage is relatively recent(a month or so). Or... perhaps I'm missing some tool on my laptop? make docs make doxygen = both

Re: [Openocd-development] [PUSHED 8/8] unify usb device opening

2009-11-24 Thread Zach Welch
On Tue, 2009-11-24 at 08:38 -0800, David Brownell wrote: On Tuesday 24 November 2009, Zach Welch wrote: Unless there are any objections, I am going to push this series today. Reads OK. Doesn't affect FT2232 support. I'd say go for it. And with this feedback, I've pushed them out. Share

Re: [Openocd-development] Styleguide additions for embedded hosts

2009-11-24 Thread Zach Welch
On Tue, 2009-11-24 at 20:52 +0100, Øyvind Harboe wrote: I'll push this if I don't hear anything. The code adheres to these rules at this point pretty much. There are a few sites that could be a bit better, but I don't fear that there are plentiful of bad examples that are copied and pasted.

Re: [Openocd-development] Styleguide additions for embedded hosts

2009-11-24 Thread Zach Welch
On Tue, 2009-11-24 at 13:21 -0800, David Brownell wrote: On Tuesday 24 November 2009, Zach Welch wrote: I think the subject of Embeddeding Open needs to be addressed more comprehensively in its own section. I'm not disagreeing ... but what would be in that section? Some of the folk

[Openocd-development] [SERIES 0/6:0/84] command registration

2009-11-24 Thread Zach Welch
Hi all, I have finished my series to convert the tree to use the improved command registration methodology. I apologize for the number of patches in these series; however, only a handful of patches are bigger than 10K, and most are just boring semi-mechanical transformations. The following

Re: [Openocd-development] [SERIES 0/6:0/84] command registration

2009-11-24 Thread Zach Welch
On Tue, 2009-11-24 at 16:33 -0600, Dean Glazeski wrote: First of all, screw you for all of these patches. Frekin' 80+ emails! Yeah, sorry. ;) I particularly apologize for 'git send-email' failing to properly thread the messages for each series under their summaries. Even so, only the first and

Re: [Openocd-development] [PATCH 07/10] allow target_type.h to be included alone

2009-11-24 Thread Zach Welch
On Tue, 2009-11-24 at 16:54 -0800, David Brownell wrote: On Tuesday 24 November 2009, z...@superlucidity.net wrote: It is an error to require other headers to be included first, so declare what we can (struct declarations) and include the rest (Jim types). This one seemed out of step with

Re: [Openocd-development] [SERIES 0/6:0/84] command registration

2009-11-24 Thread Zach Welch
On Tue, 2009-11-24 at 16:51 -0800, David Brownell wrote: On Tuesday 24 November 2009, Zach Welch wrote: The following benefits can be expected from this work: - Command registration is much simpler and easier to read and update. - All registrations now get proper error checking

Re: [Openocd-development] [SERIES 0/6:0/84] command registration

2009-11-24 Thread Zach Welch
On Tue, 2009-11-24 at 21:55 -0500, Nicolas Pitre wrote: On Tue, 24 Nov 2009, Zach Welch wrote: On Tue, 2009-11-24 at 16:33 -0600, Dean Glazeski wrote: First of all, screw you for all of these patches. Frekin' 80+ emails! Yeah, sorry. ;) I particularly apologize for 'git send-email

Re: [Openocd-development] [SERIES 0/6:0/84] command registration

2009-11-24 Thread Zach Welch
On Tue, 2009-11-24 at 22:08 -0500, Nicolas Pitre wrote: On Tue, 24 Nov 2009, Zach Welch wrote: On Tue, 2009-11-24 at 21:55 -0500, Nicolas Pitre wrote: On Tue, 24 Nov 2009, Zach Welch wrote: On Tue, 2009-11-24 at 16:33 -0600, Dean Glazeski wrote: First of all, screw you for all

Re: [Openocd-development] [SERIES 0/6:0/84] command registration

2009-11-24 Thread Zach Welch
On Tue, 2009-11-24 at 23:32 -0500, Nicolas Pitre wrote: On Tue, 24 Nov 2009, Zach Welch wrote: On Tue, 2009-11-24 at 22:08 -0500, Nicolas Pitre wrote: Your usage of --in-reply-to is wrong. That made all patch series to end up in the same thread. How could I have done it right

Re: [Openocd-development] Flash Code for ADI's ADUC706x

2009-11-24 Thread Zach Welch
On Wed, 2009-11-25 at 08:00 +0100, EG wrote: Hello, please find a tar attached containing additional files and a diff to add flash support for the ADUC706x controller to openocd 0.3.1 ... Best regards, Enrico Enrico, Some initial feedback: 1. Please send only plain text attachments or

Re: [Openocd-development] retire arm920t and arm720t cp15 commands

2009-11-23 Thread Zach Welch
On Mon, 2009-11-23 at 14:19 +0100, Øyvind Harboe wrote: Would anyone mind if the arm920t and arm720t cp15 commands were retired? The only user of arm920t in the tcl directory is csb337.cfg. If someone could offer a translation of the arm920t cp15 2 0xc0001078 command to mcr syntax + test

Re: [Openocd-development] AT91SAM9 NAND Driver

2009-11-23 Thread Zach Welch
On Mon, 2009-11-23 at 13:04 -0600, Dean Glazeski wrote: Hi all, I've finished up the implementation and documentation for an AT91SAM9 NAND driver for OpenOCD. In total there are about 34 patches that includes some refactor work for both the NAND controller layer and the ARM NAND I/O

Re: [Openocd-development] [PATCH 3/3] support for scripts in $HOME/.openocd

2009-11-23 Thread Zach Welch
On Mon, 2009-11-23 at 22:22 +0100, Andreas Fritiofson wrote: On Sun, Nov 22, 2009 at 12:42 PM, Øyvind Harboe oyvind.har...@zylin.com wrote: On Sun, Nov 22, 2009 at 11:04 AM, Andreas Fritiofson andreas.fritiof...@gmail.com wrote: On Sun, Nov 22, 2009 at 9:51 AM, Øyvind Harboe

Re: [Openocd-development] AT91SAM9 NAND Driver

2009-11-23 Thread Zach Welch
PM, Zach Welch z...@superlucidity.net wrote: On Mon, 2009-11-23 at 13:04 -0600, Dean Glazeski wrote: Hi all, I've finished up the implementation and documentation for an AT91SAM9 NAND driver for OpenOCD. In total there are about 34

Re: [Openocd-development] [PATCH] improve alloc_vprintf

2009-11-23 Thread Zach Welch
Looks great, but one minor comment below On Tue, 2009-11-24 at 00:37 +0100, Andreas Fritiofson wrote: The previous implementation was unnecessarily complex. Get rid of the loops, let vsnprintf() tell us directly how much storage we need and allocate that. A second pass writes the actual

Re: [Openocd-development] [PATCH 5/8] improve 'help' command

2009-11-21 Thread Zach Welch
On Sat, 2009-11-21 at 09:36 -0700, David Brownell wrote: On Friday 20 November 2009, Zach Welch wrote: Also, any reason to hold off on this present series or the USB series? These command patches, didn't see a reason. Okay, I've made a few trivial changes to them after working

Re: [Openocd-development] [PATCH 03/12] arm-jtag-ew: use register_commands()

2009-11-21 Thread Zach Welch
On Sat, 2009-11-21 at 21:31 +0100, Øyvind Harboe wrote: Why is a table better than a fn call for registering commands? It's harder to screw up with the new way of doing things, as the registration parameters are more explicit. It also eliminates a lot of redundant calls to register_command{,s}

Re: [Openocd-development] [PATCH 04/12] at91rm9200: use register_commands()

2009-11-21 Thread Zach Welch
On Sat, 2009-11-21 at 16:24 -0700, David Brownell wrote: On Saturday 21 November 2009, Zachary T Welch wrote: +static const struct command_registration at91rm9200_command_handlers[] = { + { + .name = at91rm9200_device, + .handler =

Re: [Openocd-development] [PATCH 3/3] support for scripts in $HOME/.openocd

2009-11-21 Thread Zach Welch
On Sun, 2009-11-22 at 00:52 +0100, Andreas Fritiofson wrote: On Sat, Nov 21, 2009 at 9:31 PM, Øyvind Harboe oyvind.har...@zylin.com wrote: On Sat, Nov 21, 2009 at 7:14 PM, Zach Welch z...@superlucidity.net wrote: PATH_MAX should be defined and available (in limits.h). Use it. Why

Re: [Openocd-development] [PATCH 3/3] support for scripts in $HOME/.openocd

2009-11-21 Thread Zach Welch
On Sun, 2009-11-22 at 01:56 +0100, Andreas Fritiofson wrote: On Sun, Nov 22, 2009 at 1:13 AM, Zach Welch z...@superlucidity.net wrote: Checkout your branch and run 'git rebase master'. That will update your branch against the current master. Then, do the same thing with '-i'. Select

Re: [Openocd-development] [PUSHED 9/8] add flash/nand name support

2009-11-20 Thread Zach Welch
Pushed. Thanks for helping track this down. --Z On Thu, 2009-11-19 at 23:23 -0600, Dean Glazeski wrote: I can verify that this patch makes the fake errors go away. // Dean Glazeski On Thu, Nov 19, 2009 at 8:16 PM, Zach Welch z...@superlucidity.net wrote: Another whoops

Re: [Openocd-development] [PATCH 8/8] maintain command lists in sorted order

2009-11-20 Thread Zach Welch
On Fri, 2009-11-20 at 13:08 -0700, David Brownell wrote: On Friday 20 November 2009, Zachary T Welch wrote: Use insertion sort to the command link lists. The only practical effect of this is to order the output of the new 'help' command. O(really)? O(n) != O(1). ;) Not that it can

Re: [Openocd-development] NAND File I/O parses wrong argument

2009-11-19 Thread Zach Welch
On Wed, 2009-11-18 at 23:25 -0600, Dean Glazeski wrote: Hi all, Recent NAND file I/O changes are parsing the wrong argument for the size. Should be third argument, not second. Pushed. Let me know if you find any other problems. Incidentally, does the 'new verify' command work for you

Re: [Openocd-development] [PUSHED 9/8] add flash/nand name support

2009-11-19 Thread Zach Welch
On Wed, 2009-11-18 at 02:56 -0800, Zachary T Welch wrote: Hi all, This series improves on the patch sent previously to add bank names. It adds a 'name' field to the flash and nand bank structures. This name must be passed as the first argument to the 'flash bank' and 'nand device'

Re: [Openocd-development] NAND File I/O parses wrong argument

2009-11-19 Thread Zach Welch
here. As another curveball, it reads 0x1B when not verifying oob and 0x05 when I tell it to at location 0. The correct value in the file is 0x1E for that location and the NAND device does return this value when read. // Dean Glazeski On Thu, Nov 19, 2009 at 9:15 AM, Zach Welch z

Re: [Openocd-development] NAND File I/O parses wrong argument

2009-11-19 Thread Zach Welch
On Thu, 2009-11-19 at 15:08 -0800, Zach Welch wrote: At the moment, I just want correctness. Thanks for doing the detective work, but you're also welcom. Whoops... that one slipped away from me you're also welcome to put together an initial patch for it. Similarly, you are welcome

Re: [Openocd-development] NAND File I/O parses wrong argument

2009-11-19 Thread Zach Welch
present proper fault output. It makes it hard to trace problems when regressions happen :) I'll spend some time with that once I have the AT91SAM9 NAND working and get a start with the dataflash. // Dean Glazeski On Thu, Nov 19, 2009 at 5:12 PM, Zach Welch z...@superlucidity.net wrote

Re: [Openocd-development] [PUSHED 9/8] add flash/nand name support

2009-11-19 Thread Zach Welch
after the '.'. I'm not really sure why this is there or how to fix it. // Dean Glazeski On Thu, Nov 19, 2009 at 5:00 PM, Zach Welch z...@superlucidity.net wrote: On Wed, 2009-11-18 at 02:56 -0800, Zachary T Welch wrote: Hi all, This series improves

Re: [Openocd-development] [PUSHED 9/8] add flash/nand name support

2009-11-19 Thread Zach Welch
On Thu, 2009-11-19 at 19:47 -0700, David Brownell wrote: Why is there even a number appended? Just let whoever defines the name define it however they want, and insist only that it be unique. That will get rid of lots of possible errors inthe code... Well, the code in question supports

Re: [Openocd-development] [PATCH 0/8] add flash/nand name support

2009-11-18 Thread Zach Welch
I have been considering another round of reorganization, which would include such restructuring. Such work is very invasive, though. Please tell me more about future type of flash. I am considering adding a base type to unify the flash/nand code, so let me know how it might impact those plans.

Re: [Openocd-development] [PUSHED 3/3] modularize startup.tcl

2009-11-18 Thread Zach Welch
On Tue, 2009-11-17 at 09:39 -0800, Zachary T Welch wrote: Hi all, This series modularizes the startup.tcl file, putting various pieces of the system where they belong. Instead of linking it into the library, provide it as a parameter to the command_init() routine from openocd.c. Fixes the

Re: [Openocd-development] [PATCH 1/6] add COMMAND_PARSE_BOOL macro and friends

2009-11-18 Thread Zach Welch
On Wed, 2009-11-18 at 11:07 -0700, David Brownell wrote: On Wednesday 18 November 2009, Zachary T Welch wrote: Adds several macros similar to COMMAND_PARSE_NUMBER, but for parsing boolean command arguments. Two flavors are provided to provide drop-in compatibility with existing code, allow

Re: [Openocd-development] [PUSHED 3/3] modularize startup.tcl

2009-11-18 Thread Zach Welch
On Wed, 2009-11-18 at 11:23 -0700, David Brownell wrote: On Wednesday 18 November 2009, Zach Welch wrote: On Tue, 2009-11-17 at 09:39 -0800, Zachary T Welch wrote: Hi all, This series modularizes the startup.tcl file, putting various pieces of the system where they belong. Instead

Re: [Openocd-development] [PUSHED 3/3] modularize startup.tcl

2009-11-18 Thread Zach Welch
On Wed, 2009-11-18 at 11:34 -0800, Zach Welch wrote: On Wed, 2009-11-18 at 11:23 -0700, David Brownell wrote: On Wednesday 18 November 2009, Zach Welch wrote: On Tue, 2009-11-17 at 09:39 -0800, Zachary T Welch wrote: Hi all, This series modularizes the startup.tcl file, putting

Re: [Openocd-development] [PUSHED 3/3] modularize startup.tcl

2009-11-18 Thread Zach Welch
, 2009 at 1:42 PM, Zach Welch z...@superlucidity.net wrote: On Wed, 2009-11-18 at 11:34 -0800, Zach Welch wrote: On Wed, 2009-11-18 at 11:23 -0700, David Brownell wrote: On Wednesday 18 November 2009, Zach Welch wrote: On Tue, 2009-11-17 at 09:39 -0800, Zachary

Re: [Openocd-development] [PUSHED 3/3] modularize startup.tcl

2009-11-18 Thread Zach Welch
// Dean Glazeski On Wed, Nov 18, 2009 at 2:05 PM, Zach Welch z...@superlucidity.net wrote: Okay I've pushed it. However, I have to wonder if I am the only one that is a little surprised that this was the source of the problem

Re: [Openocd-development] [PATCH 1/6] add COMMAND_PARSE_BOOL macro and friends

2009-11-18 Thread Zach Welch
On Wed, 2009-11-18 at 11:30 -0800, Zach Welch wrote: On Wed, 2009-11-18 at 11:07 -0700, David Brownell wrote: It gets annoying to need to recall which variant of true/false a given routine needs. :) It's part of a generally good rule too: be forgiving with what you accept for input

Re: [Openocd-development] [patch] ARM: rework arm reg output for new mode

2009-11-18 Thread Zach Welch
Very nice. Keep 'em comin'. --Z On Wed, 2009-11-18 at 16:41 -0700, David Brownell wrote: Change the layout to show the Secure Monitor registers too, when they're present. Instead of lining registers for each of six (or seven) modes up in adjacent vertical columns, display each mode's

Re: [Openocd-development] [PUSHED 6/6] improve on/off argument parsing

2009-11-18 Thread Zach Welch
On Wed, 2009-11-18 at 08:27 -0800, Zachary T Welch wrote: Hi all, This series attempts to improve the handling of command arguments that use on/off or enable/disable options. This is accomplished by macros that work similarly to the COMMAND_PARSE_NUMBER, causing the caller to return (and

Re: [Openocd-development] [PATCH 0/6] improve command handling, act 2

2009-11-17 Thread Zach Welch
On Mon, 2009-11-16 at 18:01 -0700, David Brownell wrote: On Monday 16 November 2009, Zachary T Welch wrote: As suggsted by the first commit message, the final act will involve the removeal of the migration macros; however, that should wait until we near 1.0, in the event that further

Re: [Openocd-development] [PATCH 0/6] improve command handling, act 2

2009-11-17 Thread Zach Welch
On Tue, 2009-11-17 at 09:42 +0100, Øyvind Harboe wrote: On Tue, Nov 17, 2009 at 9:35 AM, Zach Welch z...@superlucidity.net wrote: On Mon, 2009-11-16 at 18:01 -0700, David Brownell wrote: On Monday 16 November 2009, Zachary T Welch wrote: As suggsted by the first commit message, the final

[Openocd-development] container_of in flash module

2009-11-17 Thread Zach Welch
Hi all, After producing my last patch to the flash module, I have been thinking that it should be possible (and worthwhile) to use container_of() in order to unify the driver structures (and maybe the banks too). At the very least, the bank commands and block read/write can be unified in a new

Re: [Openocd-development] [PATCH] allow flash/nand banks commands to accept names

2009-11-17 Thread Zach Welch
On Tue, 2009-11-17 at 04:09 -0700, David Brownell wrote: On Tuesday 17 November 2009, Zachary T Welch wrote: Add get_flash_bank_by_name (and get_nand_device_by_name) helpers to retrieves struct flash_bank * (struct nand_device *) given a driver name and an (optional) driver-specific

Re: [Openocd-development] [PATCH 0/2] update doxygen build

2009-11-17 Thread Zach Welch
On Tue, 2009-11-17 at 07:02 -0800, Zachary T Welch wrote: Hi all, The first patch extends the Doxygen build process to produce a PDF version of the developer manual. Due to the time it takes to (re)build, the second patch adds configuration options for the user to explicitly enable this

Re: [Openocd-development] [PATCH 0/3] modularize startup.tcl

2009-11-17 Thread Zach Welch
On Tue, 2009-11-17 at 18:43 +0100, Øyvind Harboe wrote: On Tue, Nov 17, 2009 at 6:39 PM, Zachary T Welch z...@superlucidity.net wrote: Hi all, This series modularizes the startup.tcl file, putting various pieces of the system where they belong. Instead of linking it into the library,

Re: [Openocd-development] [PUSHED 0/6] improve command handling, act 2

2009-11-17 Thread Zach Welch
On Mon, 2009-11-16 at 15:34 -0800, Zachary T Welch wrote: Hi all, This series converts all COMMAND_HANDLER routines to use a new struct command_invocation to pass parameters by reference. This migration is managed by introducing macros for the remaining handler arguments, using them

Re: [Openocd-development] [PUSHED 2/2] update doxygen build

2009-11-17 Thread Zach Welch
On Tue, 2009-11-17 at 07:02 -0800, Zachary T Welch wrote: Hi all, The first patch extends the Doxygen build process to produce a PDF version of the developer manual. Due to the time it takes to (re)build, the second patch adds configuration options for the user to explicitly enable this

Re: [Openocd-development] [PUSHED 12/11] improve binarybuffers routines

2009-11-16 Thread Zach Welch
On Sat, 2009-11-14 at 11:14 -0800, Zachary T Welch wrote: Hi all, This series updates the binarybuffers helpers. While the changes have been split almost per-function, they could be split further if desired. Overall, I expect a modest improvements for operations that use these, because

Re: [Openocd-development] [PUSHED 4/4] Factor NAND write/dump to add verify

2009-11-16 Thread Zach Welch
On Fri, 2009-11-13 at 13:17 -0800, Zachary T Welch wrote: This series was started to eliminate some duplicated code, but I threw in the new 'nand verify' command to exploit the new helper functions. I have no clue as to whether it will be useful or not; if not, the last two patches could be

Re: [Openocd-development] [PATCH 08/11] improve buf_cpy helper

2009-11-16 Thread Zach Welch
On Sun, 2009-11-15 at 16:11 -0700, David Brownell wrote: On Sunday 15 November 2009, Zach Welch wrote: I'd be happier if it were called DIV_ROUND_UP() like a certain OS kernel I could mention ... not as cryptic. I agree that the current name stands to be improved. (Likewise

Re: [Openocd-development] configure Issue with current libftdi and openocd

2009-11-16 Thread Zach Welch
On Mon, 2009-11-16 at 13:57 +0100, Albert ARIBAUD wrote: Hi, I have compiled and installed libftdi from GIT, forcing the prefix to /usr. The lib header files are then installed into /usr/include/libftdi. However, the current configure.in for OpenOCD expects file ftdi.h to be in

Re: [Openocd-development] [PATCH 4/5] armv7m: make core reg read/write use unsigned

2009-11-16 Thread Zach Welch
On Mon, 2009-11-16 at 10:20 -0700, David Brownell wrote: On Monday 16 November 2009, Zachary T Welch wrote: Eliminate redundant check that gets covered by using unsigned type. Same can be done to the struct arm methods of the same name. Also, note that there are a number of Tcl commands

Re: [Openocd-development] [PATCH 11/11] improve inline binarybuffer helpers

2009-11-16 Thread Zach Welch
I am going to name Mr. Copy and Mr. Paste as the culprits, your honor. Since they were acting on my direct orders, I ask mercy from the court. I definitely know better and will try to do better in the future. :) --Z On Mon, 2009-11-16 at 15:54 -0700, David Brownell wrote: Newly introduced

Re: [Openocd-development] [PATCH 08/11] improve buf_cpy helper

2009-11-15 Thread Zach Welch
On Sat, 2009-11-14 at 19:59 -0700, David Brownell wrote: On Saturday 14 November 2009, Zach Welch wrote: On Sat, 2009-11-14 at 12:56 -0700, David Brownell wrote: On Saturday 14 November 2009, Zachary T Welch wrote: - for (unsigned i = 0, num_bytes = CEIL(size, 8); i num_bytes

Re: [Openocd-development] ARM NAND I/O: Read Function

2009-11-15 Thread Zach Welch
On Sun, 2009-11-15 at 02:19 -0700, David Brownell wrote: On Sunday 15 November 2009, Dean Glazeski wrote: I've done an implementation of reading using an on-chip algorithm for NAND devices attached to ARM chips. It seems to work on my AT91SAM9260 board increasing nand dump from 0.2 kb/s to

Re: [Openocd-development] Unable to build OpenOCD PDF documentation using Cygwin

2009-11-15 Thread Zach Welch
Did you use --enable-maintainer-mode when running configure? I believe that will fix this particular problem. --Z On Sun, 2009-11-15 at 13:16 +0100, Ferdinand Postema wrote: Hi Peter, I had the same problem. It seems that the new version of tetex (version 3.0.0-3) is causing the problem.

Re: [Openocd-development] [PATCH 08/11] improve buf_cpy helper

2009-11-15 Thread Zach Welch
On Sun, 2009-11-15 at 16:12 -0700, David Brownell wrote: On Sunday 15 November 2009, Zach Welch wrote: Or maybe I was. Given that it copies everything, why is there code *after* the copy mangling the last byte? Wouldn't that only be correct when the code copied all

Re: [Openocd-development] [patch 0/5] header cleanups

2009-11-15 Thread Zach Welch
On Sun, 2009-11-15 at 13:38 -0700, David Brownell wrote: The nest of header inclusions is something of a mess; touch one, and totally unrelated code will need to be recompiled. So here are a few patches making that a bit better for the headers in the target part of the tree. In order:

Re: [Openocd-development] SWD interface patches, constructive criticism needed.

2009-11-14 Thread Zach Welch
On Sat, 2009-11-14 at 08:22 +, Andrew Rogers wrote: SWD is not finished yet, a long way to go. Adding the actual hardware drivers is a almost the last thing on my list. I want to get the framework in place first. What I have done is to get a SWD interface listed when you use 'openocd -c

<    1   2   3   4   5   6   7   8   9   >