[Impala-ASF-CR] IMPALA-6053: Fix exception when storadeIds don't match hosts

2017-11-28 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/8668 ) Change subject: IMPALA-6053: Fix exception when storadeIds don't match hosts .. Patch Set 2: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-5310: Part 2: Add SAMPLED NDV() function.

2017-11-28 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/8569 ) Change subject: IMPALA-5310: Part 2: Add SAMPLED_NDV() function. .. Patch Set 3: Code-Review+1 (3 comments) LGTM.

[Impala-ASF-CR] IMPALA-4132: Use -fno-omit-frame-pointer

2017-11-22 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/8612 ) Change subject: IMPALA-4132: Use -fno-omit-frame-pointer .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-5940: Avoid stack tracing and log spew with Status::Expected()

2017-11-29 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/8689 ) Change subject: IMPALA-5940: Avoid stack tracing and log spew with Status::Expected() .. Patch Set 1: (3 comments)

[Impala-ASF-CR] IMPALA-5940: Avoid stack tracing and log spew with Status::Expected()

2017-11-29 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/8689 ) Change subject: IMPALA-5940: Avoid stack tracing and log spew with Status::Expected() .. Patch Set 1: Code-Review+1 -- To

[Impala-ASF-CR] IMPALA-5058: Improve the concurrency of DDL/DML operations

2017-12-16 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/8752 ) Change subject: IMPALA-5058: Improve the concurrency of DDL/DML operations .. Patch Set 2: Code-Review+1 (10 comments) I've

[Impala-ASF-CR] IMPALA-4886: Expose table metrics in the catalog web UI.

2017-12-15 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/8529 ) Change subject: IMPALA-4886: Expose table metrics in the catalog web UI. .. Patch Set 4: Code-Review+1 (5 comments) Please

[Impala-ASF-CR] [PREVIEW] IMPALA-4886: Expose table metrics in the catalog web UI.

2017-12-13 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/8529 ) Change subject: [PREVIEW] IMPALA-4886: Expose table metrics in the catalog web UI. .. Patch Set 3: (20 comments) The patch

[Impala-ASF-CR] IMPALA-6092: avoid drop/create function interactions in e2e tests

2017-11-20 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/8593 ) Change subject: IMPALA-6092: avoid drop/create function interactions in e2e tests .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-6092: avoid drop/create function interactions in e2e tests

2017-11-20 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/8593 ) Change subject: IMPALA-6092: avoid drop/create function interactions in e2e tests .. Patch Set 2: Code-Review+1 (1 comment)

[Impala-ASF-CR] IMPALA-6092: avoid drop/create function interactions in e2e tests

2017-11-20 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/8593 ) Change subject: IMPALA-6092: avoid drop/create function interactions in e2e tests .. Patch Set 1: (3 comments)

[Impala-ASF-CR] IMPALA-6092: avoid drop/create function interactions in e2e tests

2017-11-18 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/8593 ) Change subject: IMPALA-6092: avoid drop/create function interactions in e2e tests .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-4927: Impala should handle invalid input from Sentry

2017-11-21 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/8588 ) Change subject: IMPALA-4927: Impala should handle invalid input from Sentry .. Patch Set 5: (1 comment)

[Impala-ASF-CR] IMPALA-4927: Impala should handle invalid input from Sentry

2017-11-21 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/8588 ) Change subject: IMPALA-4927: Impala should handle invalid input from Sentry .. Patch Set 5: (1 comment)

[Impala-ASF-CR] IMPALA-5310: Part 2: Add SAMPLED NDV() function.

2017-11-16 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/8569 ) Change subject: IMPALA-5310: Part 2: Add SAMPLED_NDV() function. .. Patch Set 1: (7 comments) I have a bunch of nits. Although

[Impala-ASF-CR] [PREVIEW] IMPALA-5058: Improve concurrency of DDL/DML operations

2017-11-15 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/8545 ) Change subject: [PREVIEW] IMPALA-5058: Improve concurrency of DDL/DML operations .. Patch Set 1: (1 comment)

[Impala-ASF-CR] Fix diagnostics path to not include the parent dir structure

2018-05-08 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10347 Change subject: Fix diagnostics path to not include the parent dir structure .. Fix diagnostics path to not include the parent

[Impala-ASF-CR] Fix diagnostics path to not include the parent dir structure

2018-05-09 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/10347 ) Change subject: Fix diagnostics path to not include the parent dir structure .. Patch Set 1: (1 comment)

[Impala-ASF-CR] Fix diagnostics path to not include the parent dir structure

2018-05-09 Thread Bharath Vissapragada (Code Review)
Hello Philip Zeyliger, Kim Jin Chul, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10347 to look at the new patch set (#2). Change subject: Fix diagnostics path to not include the parent dir structure

[Impala-ASF-CR] Fix diagnostics path to not include the parent dir structure

2018-05-09 Thread Bharath Vissapragada (Code Review)
Hello Lars Volker, Philip Zeyliger, Kim Jin Chul, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10347 to look at the new patch set (#3). Change subject: Fix diagnostics path to not include the parent dir structure

[Impala-ASF-CR] Fix diagnostics path to not include the parent dir structure

2018-05-09 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/10347 ) Change subject: Fix diagnostics path to not include the parent dir structure .. Patch Set 3: (2 comments)

[Impala-ASF-CR] Fix diagnostics path to not include the parent dir structure

2018-05-09 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/10347 ) Change subject: Fix diagnostics path to not include the parent dir structure .. Patch Set 3: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-7158: Fix HdfsScanNodeBase::progress 's init

2018-06-12 Thread Bharath Vissapragada (Code Review)
Hello Sailesh Mukil, Tim Armstrong, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10672 to look at the new patch set (#2). Change subject: IMPALA-7158: Fix HdfsScanNodeBase::progress_'s init

[Impala-ASF-CR] IMPALA-7158: Fix HdfsScanNodeBase::progress 's init

2018-06-12 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/10672 ) Change subject: IMPALA-7158: Fix HdfsScanNodeBase::progress_'s init .. Patch Set 2: Updated the commit message. -- To view,

[Impala-ASF-CR] IMPALA-7158: Fix HdfsScanNodeBase::progress 's init

2018-06-08 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10672 Change subject: IMPALA-7158: Fix HdfsScanNodeBase::progress_'s init .. IMPALA-7158: Fix HdfsScanNodeBase::progress_'s init

[Impala-ASF-CR] IMPALA-6119: Fix issue with multiple partitions sharing same location

2018-06-18 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/10543 ) Change subject: IMPALA-6119: Fix issue with multiple partitions sharing same location .. Patch Set 12: (4 comments) Looks

[Impala-ASF-CR] Change variables to make the code easier to read

2018-06-12 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/10699 ) Change subject: Change variables to make the code easier to read .. Patch Set 1: Code-Review+2 -- To view, visit

[Impala-ASF-CR] Change variables to make the code easier to read

2018-06-12 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/10699 ) Change subject: Change variables to make the code easier to read .. Patch Set 1: I think we can run the script in a standalone

[Impala-ASF-CR] IMPALA-6119: Fix issue with multiple partitions sharing same location

2018-06-13 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/10543 ) Change subject: IMPALA-6119: Fix issue with multiple partitions sharing same location .. Patch Set 10: Sorry, was busy. Will

[Impala-ASF-CR] IMPALA-2195: Improper handling of comments in queries

2018-06-13 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9933 ) Change subject: IMPALA-2195: Improper handling of comments in queries .. IMPALA-2195: Improper handling of comments in

[Impala-ASF-CR] IMPALA-2195: Improper handling of comments in queries

2018-06-13 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/9933 ) Change subject: IMPALA-2195: Improper handling of comments in queries .. Patch Set 15: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-7106: Print rewritten SQL correctly when log trace is enabled

2018-06-13 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/10571 ) Change subject: IMPALA-7106: Print rewritten SQL correctly when log trace is enabled .. Patch Set 14: (1 comment) Just

[Impala-ASF-CR] IMPALA-6119: Fix issue with multiple partitions sharing same location

2018-06-14 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/10543 ) Change subject: IMPALA-6119: Fix issue with multiple partitions sharing same location .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-6119: Fix issue with multiple partitions sharing same location

2018-06-19 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/10543 ) Change subject: IMPALA-6119: Fix issue with multiple partitions sharing same location .. Patch Set 15: Code-Review+1 (6

[Impala-ASF-CR] IMPALA-6119: Fix issue with multiple partitions sharing same location

2018-06-19 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/10543 ) Change subject: IMPALA-6119: Fix issue with multiple partitions sharing same location .. Patch Set 15: (1 comment)

[Impala-ASF-CR] IMPALA-6119: Fix issue with multiple partitions sharing same location

2018-06-19 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/10543 ) Change subject: IMPALA-6119: Fix issue with multiple partitions sharing same location .. Patch Set 15: (1 comment)

[Impala-ASF-CR] IMPALA-6119: Fix issue with multiple partitions sharing same location

2018-06-13 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/10543 ) Change subject: IMPALA-6119: Fix issue with multiple partitions sharing same location .. Patch Set 10: (3 comments)

[Impala-ASF-CR] IMPALA-6119: Fix issue with multiple partitions sharing same location

2018-05-30 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/10543 ) Change subject: IMPALA-6119: Fix issue with multiple partitions sharing same location .. Patch Set 1: (13 comments)

[Impala-ASF-CR] IMPALA-7012: Fix NPE when parsing unexpected tokens

2018-05-29 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/10512 ) Change subject: IMPALA-7012: Fix NPE when parsing unexpected tokens .. Patch Set 1: (2 comments)

[Impala-ASF-CR] IMPALA-6119: Fix issue with multiple partitions sharing same location

2018-06-04 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/10543 ) Change subject: IMPALA-6119: Fix issue with multiple partitions sharing same location .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-7110. Fix some warnings from error-prone

2018-06-04 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/10583 ) Change subject: IMPALA-7110. Fix some warnings from error-prone .. Patch Set 1: Code-Review+2 (1 comment)

[Impala-ASF-CR] IMPALA-7077. Add a configuration for the max number of partitions to load

2018-06-04 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/10584 ) Change subject: IMPALA-7077. Add a configuration for the max number of partitions to load .. Patch Set 1: (7 comments)

[Impala-ASF-CR] IMPALA-6119: Fix issue with multiple partitions sharing same location

2018-05-31 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/10543 ) Change subject: IMPALA-6119: Fix issue with multiple partitions sharing same location .. Patch Set 2: (2 comments)

[Impala-ASF-CR] IMPALA-6020: [DOCS] REFRESH statement cannot detect HDFS block movement

2018-06-01 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/10470 ) Change subject: IMPALA-6020: [DOCS] REFRESH statement cannot detect HDFS block movement .. Patch Set 1: Code-Review+2 Yes,

[Impala-ASF-CR] [DOCS] SHOW TBLPROPERTIES not supported in impala

2018-06-01 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/10564 ) Change subject: [DOCS] SHOW TBLPROPERTIES not supported in impala .. Patch Set 1: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-2195: Improper handling of comments in queries

2018-06-01 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/9933 ) Change subject: IMPALA-2195: Improper handling of comments in queries .. Patch Set 12: No takers for +2? This has been

[Impala-ASF-CR] IMPALA-7110. Fix errors from error-prone

2018-06-05 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/10583 ) Change subject: IMPALA-7110. Fix errors from error-prone .. Patch Set 2: Code-Review+1 (1 comment) Phil, can you +2 this, I'm

[Impala-ASF-CR] IMPALA-7077. Add a configuration for the max number of partitions to load

2018-06-05 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/10584 ) Change subject: IMPALA-7077. Add a configuration for the max number of partitions to load .. Patch Set 1: (2 comments) Todd,

[Impala-ASF-CR] IMPALA-5552: Add support for authorized proxy groups

2018-06-05 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/10510 ) Change subject: IMPALA-5552: Add support for authorized proxy groups .. Patch Set 8: (13 comments) Just came across this CR.

[Impala-ASF-CR] IMPALA-5552: Add support for authorized proxy groups

2018-06-06 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/10510 ) Change subject: IMPALA-5552: Add support for authorized proxy groups .. Patch Set 14: Code-Review+1 Phil, do you want to +2?

[Impala-ASF-CR] IMPALA-5552: Add support for authorized proxy groups

2018-06-06 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/10510 ) Change subject: IMPALA-5552: Add support for authorized proxy groups .. Patch Set 8: (1 comment)

[Impala-ASF-CR] IMPALA-5552: Add support for authorized proxy groups

2018-06-06 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/10510 ) Change subject: IMPALA-5552: Add support for authorized proxy groups .. Patch Set 13: (3 comments) LGTM once my comments are

[Impala-ASF-CR] IMPALA-5642: [DOCS] An additional restriction for Hive/Java UDFs

2018-05-29 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/10520 ) Change subject: IMPALA-5642: [DOCS] An additional restriction for Hive/Java UDFs .. Patch Set 1: Code-Review+2 (1 comment)

[Impala-ASF-CR] IMPALA-3040: Remove cache directive before dropping a table

2018-06-27 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/10792 ) Change subject: IMPALA-3040: Remove cache directive before dropping a table .. Patch Set 2: Also, thinking a bit more about

[Impala-ASF-CR] [DRAFT] IMPALA-6189: Add thread watchdogs for HDFS IO calls

2018-06-22 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/10696 ) Change subject: [DRAFT] IMPALA-6189: Add thread watchdogs for HDFS IO calls .. Patch Set 4: Forgot to respond to the top-level

[Impala-ASF-CR] IMPALA-3040: Remove cache directive before dropping a table

2018-06-25 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/10792 ) Change subject: IMPALA-3040: Remove cache directive before dropping a table .. Patch Set 1: (2 comments)

[Impala-ASF-CR] [DRAFT] IMPALA-6189: Add thread watchdogs for HDFS IO calls

2018-06-22 Thread Bharath Vissapragada (Code Review)
Hello Michael Ho, Lars Volker, Philip Zeyliger, Balazs Jeszenszky, Zoram Thanga, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10696 to look at the new patch set (#4). Change subject: [DRAFT] IMPALA-6189: Add thread watchdogs for HDFS IO calls

[Impala-ASF-CR] [DRAFT] IMPALA-6189: Add thread watchdogs for HDFS IO calls

2018-06-22 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/10696 ) Change subject: [DRAFT] IMPALA-6189: Add thread watchdogs for HDFS IO calls .. Patch Set 3: (9 comments)

[Impala-ASF-CR] IMPALA-6119: Fix issue with multiple partitions sharing same location

2018-06-20 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/10543 ) Change subject: IMPALA-6119: Fix issue with multiple partitions sharing same location .. Patch Set 17: (2 comments)

[Impala-ASF-CR] IMPALA-3040: Remove cache directive before dropping a table

2018-06-27 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/10792 ) Change subject: IMPALA-3040: Remove cache directive before dropping a table .. Patch Set 2: Your theory seems plausible to me

[Impala-ASF-CR] IMPALA-3040: Remove cache directive before dropping a table

2018-07-03 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/10792 ) Change subject: IMPALA-3040: Remove cache directive before dropping a table .. Patch Set 2: Thanks for the explanation. I

[Impala-ASF-CR] IMPALA-3040: Remove cache directive before dropping a table

2018-07-03 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/10792 ) Change subject: IMPALA-3040: Remove cache directive before dropping a table .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-2195: Improper handling of comments in queries

2018-04-30 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/9933 ) Change subject: IMPALA-2195: Improper handling of comments in queries .. Patch Set 9: Code-Review+1 (3 comments) I'll let

[Impala-ASF-CR] IMPALA-2195: Improper handling of comments in queries

2018-04-30 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/9933 ) Change subject: IMPALA-2195: Improper handling of comments in queries .. Patch Set 7: (10 comments) After discussing with

[Impala-ASF-CR] IMPALA-3040: Remove cache directives during background partition dropping

2018-07-03 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/10792 ) Change subject: IMPALA-3040: Remove cache directives during background partition dropping .. Patch Set 3: (6 comments)

[Impala-ASF-CR] IMPALA-6348: Redact only sensitive fields in runtime profiles

2018-01-05 Thread Bharath Vissapragada (Code Review)
Hello Sailesh Mukil, anujphadke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8934 to look at the new patch set (#3). Change subject: IMPALA-6348: Redact only sensitive fields in runtime profiles

[Impala-ASF-CR] IMPALA-6384: RequestPoolService should honor custom group mapping config

2018-01-10 Thread Bharath Vissapragada (Code Review)
Hello Dimitris Tsirogiannis, Zoram Thanga, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9000 to look at the new patch set (#2). Change subject: IMPALA-6384: RequestPoolService should honor custom group mapping config

[Impala-ASF-CR] IMPALA-6384: RequestPoolService should honor custom group mapping config

2018-01-10 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/9000 ) Change subject: IMPALA-6384: RequestPoolService should honor custom group mapping config .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-6384: RequestPoolService should honor custom group mapping config

2018-01-10 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9000 Change subject: IMPALA-6384: RequestPoolService should honor custom group mapping config .. IMPALA-6384: RequestPoolService

[Impala-ASF-CR] IMPALA-5152: Introduce metadata loading phase

2018-01-08 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/8958 ) Change subject: IMPALA-5152: Introduce metadata loading phase .. Patch Set 1: (11 comments) Patch looks good to me overall,

[Impala-ASF-CR] IMPALA-2642: Fix a potential deadlock in statestore

2018-01-16 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/9038 ) Change subject: IMPALA-2642: Fix a potential deadlock in statestore .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-6384: RequestPoolService should honor custom group mapping config

2018-01-11 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/9000 ) Change subject: IMPALA-6384: RequestPoolService should honor custom group mapping config .. Patch Set 3: Code-Review+2 (1

[Impala-ASF-CR] IMPALA-6497: add "Last row fetched" and AC events

2018-02-21 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/9271 ) Change subject: IMPALA-6497: add "Last row fetched" and AC events .. Patch Set 9: (1 comment)

[Impala-ASF-CR] IMPALA-6497: add "Last row fetched" and AC events

2018-02-21 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/9271 ) Change subject: IMPALA-6497: add "Last row fetched" and AC events .. Patch Set 9: (1 comment)

[Impala-ASF-CR] IMPALA-6567: ResetMetadataStmt analysis should not load tables.

2018-02-23 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/9418 ) Change subject: IMPALA-6567: ResetMetadataStmt analysis should not load tables. .. Patch Set 2: Code-Review+1 (1 comment)

[Impala-ASF-CR] IMPALA-6348: Redact only sensitive fields in runtime profiles

2018-01-03 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8934 Change subject: IMPALA-6348: Redact only sensitive fields in runtime profiles .. IMPALA-6348: Redact only sensitive fields in

[Impala-ASF-CR] [DRAFT] IMPALA-6189: Add thread watchdogs for HDFS IO calls

2018-06-21 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/10696 ) Change subject: [DRAFT] IMPALA-6189: Add thread watchdogs for HDFS IO calls .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-6857: Add Jvm pause/GC Monitor utility and expose JMX metrics

2018-07-27 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/10998 ) Change subject: IMPALA-6857: Add Jvm pause/GC Monitor utility and expose JMX metrics .. Patch Set 5: (9 comments)

[Impala-ASF-CR] IMPALA-6857: Add Jvm pause/GC Monitor utility and expose JMX metrics

2018-07-27 Thread Bharath Vissapragada (Code Review)
Hello Tianyi Wang, Todd Lipcon, Impala Public Jenkins, Vuk Ercegovac, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10998 to look at the new patch set (#5). Change subject: IMPALA-6857: Add Jvm pause/GC Monitor utility and expose JMX metrics

[Impala-ASF-CR] IMPALA-7209: Disallow self referencing in ALTER VIEW statements

2018-07-27 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/10908 ) Change subject: IMPALA-7209: Disallow self referencing in ALTER VIEW statements .. Patch Set 10: (3 comments) Sorry for the

[Impala-ASF-CR] IMPALA-7387: Set correct MIME type for JSON webpages

2018-08-02 Thread Bharath Vissapragada (Code Review)
Hello Philip Zeyliger, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/0 to look at the new patch set (#5). Change subject: IMPALA-7387: Set correct MIME type for JSON webpages

[Impala-ASF-CR] IMPALA-7386. Replace CatalogObjectVersionQueue with a multiset

2018-08-02 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/11109 ) Change subject: IMPALA-7386. Replace CatalogObjectVersionQueue with a multiset .. Patch Set 1: (3 comments)

[Impala-ASF-CR] IMPALA-7387: Set correct MIME type for JSON webpages

2018-08-02 Thread Bharath Vissapragada (Code Review)
Hello Philip Zeyliger, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/0 to look at the new patch set (#6). Change subject: IMPALA-7387: Set correct MIME type for JSON webpages

[Impala-ASF-CR] IMPALA-7387: Set correct MIME type for JSON webpages

2018-08-02 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/0 ) Change subject: IMPALA-7387: Set correct MIME type for JSON webpages .. Patch Set 7: Code-Review+2 (2 comments) Carrying +2

[Impala-ASF-CR] IMPALA-7387: Set correct MIME type for JSON webpages

2018-08-02 Thread Bharath Vissapragada (Code Review)
Hello Philip Zeyliger, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/0 to look at the new patch set (#7). Change subject: IMPALA-7387: Set correct MIME type for JSON webpages

[Impala-ASF-CR] IMPALA-7387: Set correct MIME type for JSON webpages

2018-08-02 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/0 ) Change subject: IMPALA-7387: Set correct MIME type for JSON webpages .. Patch Set 8: Looks like IMPALA-7328, triggering

[Impala-ASF-CR] IMPALA-7386. Replace CatalogObjectVersionQueue with a multiset

2018-08-02 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/11109 ) Change subject: IMPALA-7386. Replace CatalogObjectVersionQueue with a multiset .. Patch Set 1: (2 comments)

[Impala-ASF-CR] IMPALA-7209: Disallow self referencing in ALTER VIEW statements

2018-07-30 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/10908 ) Change subject: IMPALA-7209: Disallow self referencing in ALTER VIEW statements .. Patch Set 12: Code-Review+2 (1 comment)

[Impala-ASF-CR] IMPALA-6857: Add Jvm pause/GC Monitor utility and expose JMX metrics

2018-07-30 Thread Bharath Vissapragada (Code Review)
Hello Tianyi Wang, Philip Zeyliger, Todd Lipcon, Impala Public Jenkins, Vuk Ercegovac, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10998 to look at the new patch set (#6). Change subject: IMPALA-6857: Add Jvm pause/GC Monitor utility and expose JMX

[Impala-ASF-CR] IMPALA-6857: Add Jvm pause/GC Monitor utility and expose JMX metrics

2018-07-30 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/10998 ) Change subject: IMPALA-6857: Add Jvm pause/GC Monitor utility and expose JMX metrics .. Patch Set 5: (2 comments)

[Impala-ASF-CR] IMPALA-6857: Add Jvm pause/GC Monitor utility and expose JMX metrics

2018-07-30 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/10998 ) Change subject: IMPALA-6857: Add Jvm pause/GC Monitor utility and expose JMX metrics .. Patch Set 6: (13 comments)

[Impala-ASF-CR] IMPALA-7209: Disallow self referencing in ALTER VIEW statements

2018-07-29 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/10908 ) Change subject: IMPALA-7209: Disallow self referencing in ALTER VIEW statements .. Patch Set 11: (1 comment) Can +2 once you

[Impala-ASF-CR] IMPALA-7225: REFRESH..PARTITION shoud not reset partition's num rows

2018-07-26 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/11056 ) Change subject: IMPALA-7225: REFRESH..PARTITION shoud not reset partition's num rows .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-7225: REFRESH..PARTITION shoud not reset partition's num rows

2018-07-26 Thread Bharath Vissapragada (Code Review)
Hello Tianyi Wang, Todd Lipcon, Impala Public Jenkins, Vuk Ercegovac, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11056 to look at the new patch set (#2). Change subject: IMPALA-7225: REFRESH..PARTITION shoud not reset partition's num rows

[Impala-ASF-CR] IMPALA-6857: Add Jvm pause/GC Monitor utility

2018-07-26 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/10998 ) Change subject: IMPALA-6857: Add Jvm pause/GC Monitor utility .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-7320. Avoid calling getFileStatus() for each partition when table is loaded

2018-07-27 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/11027 ) Change subject: IMPALA-7320. Avoid calling getFileStatus() for each partition when table is loaded .. Patch Set 3:

[Impala-ASF-CR] IMPALA-6857: Add Jvm pause/GC Monitor utility

2018-07-25 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/10998 ) Change subject: IMPALA-6857: Add Jvm pause/GC Monitor utility .. IMPALA-6857: Add Jvm pause/GC Monitor utility This commit adds

[Impala-ASF-CR] IMPALA-6857: Add Jvm pause/GC Monitor utility

2018-07-26 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/10998 ) Change subject: IMPALA-6857: Add Jvm pause/GC Monitor utility .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-7225: REFRESH..PARTITION shoud not reset partition's num rows

2018-07-26 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11056 Change subject: IMPALA-7225: REFRESH..PARTITION shoud not reset partition's num rows .. IMPALA-7225: REFRESH..PARTITION shoud

[Impala-ASF-CR] IMPALA-6857: Add Jvm pause/GC Monitor utility and expose JMX metrics

2018-07-31 Thread Bharath Vissapragada (Code Review)
Hello Tianyi Wang, Philip Zeyliger, Todd Lipcon, Impala Public Jenkins, Vuk Ercegovac, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10998 to look at the new patch set (#7). Change subject: IMPALA-6857: Add Jvm pause/GC Monitor utility and expose JMX

  1   2   3   4   5   6   7   8   9   10   >