[Impala-ASF-CR] IMPALA-12366: Use 2GB as the default for thrift rpc max message size

2023-08-24 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/20394 ) Change subject: IMPALA-12366: Use 2GB as the default for thrift_rpc_max_message_size .. Patch Set 2: Code-Review+2 Looks good to me.

[Impala-ASF-CR] IMPALA-12357: Skip scheduling bloom filter from full-build scan

2023-08-31 Thread Riza Suminto (Code Review)
Hello Aman Sinha, David Rorke, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20366 to look at the new patch set (#9). Change subject: IMPALA-12357: Skip scheduling bloom filter from full-build scan

[Impala-ASF-CR] IMPALA-12357: Skip scheduling bloom filter from full-build scan

2023-08-31 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/20366 ) Change subject: IMPALA-12357: Skip scheduling bloom filter from full-build scan .. Patch Set 10: (1 comment)

[Impala-ASF-CR] IMPALA-12357: Skip scheduling bloom filter from full-build scan

2023-08-31 Thread Riza Suminto (Code Review)
Hello Aman Sinha, David Rorke, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20366 to look at the new patch set (#10). Change subject: IMPALA-12357: Skip scheduling bloom filter from full-build scan

[Impala-ASF-CR] IMPALA-12357: Skip scheduling bloom filter from full-build scan

2023-08-31 Thread Riza Suminto (Code Review)
Hello Aman Sinha, David Rorke, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20366 to look at the new patch set (#8). Change subject: IMPALA-12357: Skip scheduling bloom filter from full-build scan

[Impala-ASF-CR] IMPALA-12357: Skip scheduling bloom filter from full-build scan

2023-08-31 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/20366 ) Change subject: IMPALA-12357: Skip scheduling bloom filter from full-build scan .. Patch Set 9: (3 comments)

[Impala-ASF-CR] IMPALA-12385: Enable Periodic metrics by default

2023-08-31 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/20377 ) Change subject: IMPALA-12385: Enable Periodic metrics by default .. Patch Set 6: Code-Review+1 Putting +1 since I don't mind it merge

[Impala-ASF-CR] IMPALA-12385: Enable Periodic metrics by default

2023-08-31 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/20377 ) Change subject: IMPALA-12385: Enable Periodic metrics by default .. Patch Set 6: (2 comments)

[Impala-ASF-CR] IMPALA-12408: Optimize HdfsScanNode.computeScanRangeLocations()

2023-08-30 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/20434 ) Change subject: IMPALA-12408: Optimize HdfsScanNode.computeScanRangeLocations() .. Patch Set 5: (1 comment)

[Impala-ASF-CR] IMPALA-12385: Enable Periodic metrics by default

2023-08-30 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/20377 ) Change subject: IMPALA-12385: Enable Periodic metrics by default .. Patch Set 5: (5 comments)

[Impala-ASF-CR] IMPALA-12408: Optimize HdfsScanNode.computeScanRangeLocations()

2023-08-30 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/20434 ) Change subject: IMPALA-12408: Optimize HdfsScanNode.computeScanRangeLocations() .. Patch Set 5: (4 comments)

[Impala-ASF-CR] IMPALA-11068: Add query option to reduce scanner thread launch.

2023-09-12 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/18126 ) Change subject: IMPALA-11068: Add query option to reduce scanner thread launch. .. Patch Set 3: (7 comments)

[Impala-ASF-CR] IMPALA-11284: Do non-optional rewrites for || and Between predicate

2023-09-12 Thread Riza Suminto (Code Review)
Riza Suminto has uploaded a new patch set (#11) to the change originally created by Abhishek Rawat. ( http://gerrit.cloudera.org:8080/18581 ) Change subject: IMPALA-11284: Do non-optional rewrites for || and Between predicate

[Impala-ASF-CR] IMPALA-11284: Do non-optional rewrites for || and Between predicate

2023-09-12 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/18581 ) Change subject: IMPALA-11284: Do non-optional rewrites for || and Between predicate .. Patch Set 9: (1 comment)

[Impala-ASF-CR] IMPALA-11284: Do non-optional rewrites for || and Between predicate

2023-09-12 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/18581 ) Change subject: IMPALA-11284: Do non-optional rewrites for || and Between predicate .. Patch Set 10: (1 comment)

[Impala-ASF-CR] IMPALA-11068: Add query option to reduce scanner thread launch.

2023-09-12 Thread Riza Suminto (Code Review)
Hello Kurt Deschler, Daniel Becker, Joe McDonnell, Csaba Ringhofer, Bikramjeet Vig, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/18126 to look at the new patch set (#3). Change subject: IMPALA-11068: Add query option to reduce

[Impala-ASF-CR] IMPALA-11284: Do non-optional rewrites for || and Between predicate

2023-09-12 Thread Riza Suminto (Code Review)
Riza Suminto has uploaded a new patch set (#10) to the change originally created by Abhishek Rawat. ( http://gerrit.cloudera.org:8080/18581 ) Change subject: IMPALA-11284: Do non-optional rewrites for || and Between predicate

[Impala-ASF-CR] IMPALA-11284: Do non-optional rewrites for || and Between predicate

2023-09-12 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/18581 ) Change subject: IMPALA-11284: Do non-optional rewrites for || and Between predicate .. Patch Set 11: (1 comment)

[Impala-ASF-CR] IMPALA-12357: Skip scheduling bloom filter from full-build scan

2023-09-08 Thread Riza Suminto (Code Review)
Hello Aman Sinha, David Rorke, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20366 to look at the new patch set (#16). Change subject: IMPALA-12357: Skip scheduling bloom filter from full-build scan

[Impala-ASF-CR] IMPALA-12357: Skip scheduling bloom filter from full-build scan

2023-09-07 Thread Riza Suminto (Code Review)
Hello Aman Sinha, David Rorke, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20366 to look at the new patch set (#15). Change subject: IMPALA-12357: Skip scheduling bloom filter from full-build scan

[Impala-ASF-CR] IMPALA-12357: Skip scheduling bloom filter from full-build scan

2023-09-07 Thread Riza Suminto (Code Review)
Hello Aman Sinha, David Rorke, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20366 to look at the new patch set (#14). Change subject: IMPALA-12357: Skip scheduling bloom filter from full-build scan

[Impala-ASF-CR] IMPALA-12357: Skip scheduling bloom filter from full-build scan

2023-09-07 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/20366 ) Change subject: IMPALA-12357: Skip scheduling bloom filter from full-build scan .. Patch Set 15: (4 comments)

[Impala-ASF-CR] IMPALA-11284: Do non-optional rewrites for || and Between predicate

2023-09-07 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/18581 ) Change subject: IMPALA-11284: Do non-optional rewrites for || and Between predicate .. Patch Set 7: (1 comment)

[Impala-ASF-CR] IMPALA-12357: Skip scheduling bloom filter from full-build scan

2023-09-07 Thread Riza Suminto (Code Review)
Hello Aman Sinha, David Rorke, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20366 to look at the new patch set (#13). Change subject: IMPALA-12357: Skip scheduling bloom filter from full-build scan

[Impala-ASF-CR] IMPALA-12357: Skip scheduling bloom filter from full-build scan

2023-09-07 Thread Riza Suminto (Code Review)
Hello Aman Sinha, David Rorke, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20366 to look at the new patch set (#12). Change subject: IMPALA-12357: Skip scheduling bloom filter from full-build scan

[Impala-ASF-CR] IMPALA-12357: Skip scheduling bloom filter from full-build scan

2023-09-07 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/20366 ) Change subject: IMPALA-12357: Skip scheduling bloom filter from full-build scan .. Patch Set 12: (2 comments)

[Impala-ASF-CR] IMPALA-11284: Do non-optional rewrites for || and Between predicate

2023-09-08 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/18581 ) Change subject: IMPALA-11284: Do non-optional rewrites for || and Between predicate .. Patch Set 9: (5 comments)

[Impala-ASF-CR] IMPALA-11284: Do non-optional rewrites for || and Between predicate

2023-09-08 Thread Riza Suminto (Code Review)
Riza Suminto has uploaded a new patch set (#9) to the change originally created by Abhishek Rawat. ( http://gerrit.cloudera.org:8080/18581 ) Change subject: IMPALA-11284: Do non-optional rewrites for || and Between predicate ..

[Impala-ASF-CR] IMPALA-12357: Skip scheduling bloom filter from full-build scan

2023-09-08 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/20366 ) Change subject: IMPALA-12357: Skip scheduling bloom filter from full-build scan .. Patch Set 16: (2 comments)

[Impala-ASF-CR] IMPALA-11284: Do non-optional rewrites for || and Between predicate

2023-09-08 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/18581 ) Change subject: IMPALA-11284: Do non-optional rewrites for || and Between predicate .. Patch Set 8: Patch set 8 is a rebase. I will

[Impala-ASF-CR] IMPALA-12357: Skip scheduling bloom filter from full-build scan

2023-09-08 Thread Riza Suminto (Code Review)
Hello Aman Sinha, David Rorke, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20366 to look at the new patch set (#17). Change subject: IMPALA-12357: Skip scheduling bloom filter from full-build scan

[Impala-ASF-CR] IMPALA-12357: Skip scheduling bloom filter from full-build scan

2023-09-08 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/20366 ) Change subject: IMPALA-12357: Skip scheduling bloom filter from full-build scan .. Patch Set 17: (1 comment)

[Impala-ASF-CR] IMPALA-12408: Optimize HdfsScanNode.computeScanRangeLocations()

2023-08-30 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/20434 ) Change subject: IMPALA-12408: Optimize HdfsScanNode.computeScanRangeLocations() .. Patch Set 6: Code-Review+2 (1 comment) Looks good,

[Impala-ASF-CR] IMPALA-12357: Skip scheduling bloom filter from full-build scan

2023-08-29 Thread Riza Suminto (Code Review)
Hello Aman Sinha, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20366 to look at the new patch set (#7). Change subject: IMPALA-12357: Skip scheduling bloom filter from full-build scan

[Impala-ASF-CR] IMPALA-12357: Skip scheduling bloom filter from full-build scan

2023-08-29 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/20366 ) Change subject: IMPALA-12357: Skip scheduling bloom filter from full-build scan .. Patch Set 7: (3 comments)

[Impala-ASF-CR] IMPALA-11068: Add query option to reduce scanner thread launch.

2023-09-14 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/18126 ) Change subject: IMPALA-11068: Add query option to reduce scanner thread launch. .. Patch Set 4: (5 comments)

[Impala-ASF-CR] IMPALA-11284: Do non-optional rewrites for || and Between predicate

2023-09-14 Thread Riza Suminto (Code Review)
Riza Suminto has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18581 ) Change subject: IMPALA-11284: Do non-optional rewrites for || and Between predicate .. IMPALA-11284: Do non-optional rewrites

[Impala-ASF-CR] IMPALA-11284: Do non-optional rewrites for || and Between predicate

2023-09-14 Thread Riza Suminto (Code Review)
Riza Suminto has removed a vote on this change. Change subject: IMPALA-11284: Do non-optional rewrites for || and Between predicate .. Removed Verified-1 by Impala Public Jenkins -- To view, visit

[Impala-ASF-CR] IMPALA-11068: Add query option to reduce scanner thread launch.

2023-09-14 Thread Riza Suminto (Code Review)
Hello Kurt Deschler, Daniel Becker, Joe McDonnell, Csaba Ringhofer, Bikramjeet Vig, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/18126 to look at the new patch set (#4). Change subject: IMPALA-11068: Add query option to reduce

[Impala-ASF-CR] IMPALA-11284: Do non-optional rewrites for || and Between predicate

2023-09-13 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/18581 ) Change subject: IMPALA-11284: Do non-optional rewrites for || and Between predicate .. Patch Set 11: Verified+1 > Patch Set 11:

[Impala-ASF-CR] IMPALA-12429: Reduce parallelism for TPC-DS q51a and q67a test.

2023-10-16 Thread Riza Suminto (Code Review)
Riza Suminto has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20581 Change subject: IMPALA-12429: Reduce parallelism for TPC-DS q51a and q67a test. .. IMPALA-12429: Reduce parallelism for TPC-DS q51a and

[Impala-ASF-CR] IMPALA-3825: Delegate runtime filter aggregation to some executors

2023-10-25 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/20612 ) Change subject: IMPALA-3825: Delegate runtime filter aggregation to some executors .. Patch Set 5: (1 comment)

[Impala-ASF-CR] IMPALA-12018: Consider runtime filter for cardinality reduction

2023-10-19 Thread Riza Suminto (Code Review)
Hello Daniel Becker, Abhishek Rawat, David Rorke, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20498 to look at the new patch set (#3). Change subject: IMPALA-12018: Consider runtime filter for cardinality

[Impala-ASF-CR] IMPALA-12429: Reduce parallelism for TPC-DS q51a and q67a test.

2023-10-19 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/20581 ) Change subject: IMPALA-12429: Reduce parallelism for TPC-DS q51a and q67a test. .. Patch Set 1: > Patch Set 1: Code-Review+2 > > This

[Impala-ASF-CR] IMPALA-12018: Consider runtime filter for cardinality reduction

2023-10-19 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/20498 ) Change subject: IMPALA-12018: Consider runtime filter for cardinality reduction .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-12518: Combine all exec option dimension in test vector.py

2023-10-26 Thread Riza Suminto (Code Review)
Riza Suminto has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20625 ) Change subject: IMPALA-12518: Combine all exec_option dimension in test_vector.py .. IMPALA-12518: Combine all exec_option

[Impala-ASF-CR] IMPALA-12518: Combine all exec option dimension in test vector.py

2023-10-26 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/20625 ) Change subject: IMPALA-12518: Combine all exec_option dimension in test_vector.py .. Patch Set 3: Thank you Zoltan and Michael! --

[Impala-ASF-CR] IMPALA-3825: Delegate runtime filter aggregation to some executors

2023-10-26 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/20612 ) Change subject: IMPALA-3825: Delegate runtime filter aggregation to some executors .. Patch Set 7: patch set 7 is a rebase -- To

[Impala-ASF-CR] IMPALA-12508: Improve query option "enabled runtime filter types"

2023-10-26 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/20627 ) Change subject: IMPALA-12508: Improve query option "enabled_runtime_filter_types" .. Patch Set 2: Code-Review-1 (1 comment)

[Impala-ASF-CR] IMPALA-3825: Delegate runtime filter aggregation to some executors

2023-10-26 Thread Riza Suminto (Code Review)
Hello Kurt Deschler, Abhishek Rawat, Csaba Ringhofer, Michael Smith, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20612 to look at the new patch set (#7). Change subject: IMPALA-3825: Delegate runtime filter aggregation to some

[Impala-ASF-CR] IMPALA-12508: Update query option "enabled runtime filter types" comments

2023-10-27 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/20627 ) Change subject: IMPALA-12508: Update query option "enabled_runtime_filter_types" comments .. Patch Set 3: Code-Review+1 (1 comment)

[Impala-ASF-CR] IMPALA-3825: Delegate runtime filter aggregation to some executors

2023-10-25 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/20612 ) Change subject: IMPALA-3825: Delegate runtime filter aggregation to some executors .. Patch Set 6: (2 comments)

[Impala-ASF-CR] IMPALA-3825: Delegate runtime filter aggregation to some executors

2023-10-25 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/20612 ) Change subject: IMPALA-3825: Delegate runtime filter aggregation to some executors .. Patch Set 6: (1 comment)

[Impala-ASF-CR] IMPALA-12518: Combine all exec option dimension in test vector.py

2023-10-25 Thread Riza Suminto (Code Review)
Riza Suminto has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20625 Change subject: IMPALA-12518: Combine all exec_option dimension in test_vector.py .. IMPALA-12518: Combine all exec_option dimension in

[Impala-ASF-CR] IMPALA-3825: Delegate runtime filter aggregation to some executors

2023-10-25 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/20612 ) Change subject: IMPALA-3825: Delegate runtime filter aggregation to some executors .. Patch Set 6: (1 comment)

[Impala-ASF-CR] IMPALA-3825: Delegate runtime filter aggregation to some executors

2023-10-25 Thread Riza Suminto (Code Review)
Hello Kurt Deschler, Abhishek Rawat, Csaba Ringhofer, Michael Smith, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20612 to look at the new patch set (#6). Change subject: IMPALA-3825: Delegate runtime filter aggregation to some

[Impala-ASF-CR] IMPALA-12524: Deduplicate TestTextScanRangeLengths

2023-10-27 Thread Riza Suminto (Code Review)
Hello Quanlong Huang, Michael Smith, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20630 to look at the new patch set (#2). Change subject: IMPALA-12524: Deduplicate TestTextScanRangeLengths

[Impala-ASF-CR] IMPALA-12524: Deduplicate TestTextScanRangeLengths

2023-10-27 Thread Riza Suminto (Code Review)
Riza Suminto has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20630 Change subject: IMPALA-12524: Deduplicate TestTextScanRangeLengths .. IMPALA-12524: Deduplicate TestTextScanRangeLengths This patch

[Impala-ASF-CR] IMPALA-12508: Update query option "enabled runtime filter types" comments

2023-10-31 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/20627 ) Change subject: IMPALA-12508: Update query option "enabled_runtime_filter_types" comments .. Patch Set 4: Code-Review+2 (1 comment)

[Impala-ASF-CR] IMPALA-12493: Allow retry after failed cancel query

2023-10-31 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/20584 ) Change subject: IMPALA-12493: Allow retry after failed cancel_query .. Patch Set 4: Code-Review+1 (1 comment)

[Impala-ASF-CR] IMPALA-12532: Fix bug in cancel query and validate state

2023-10-31 Thread Riza Suminto (Code Review)
Riza Suminto has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20641 Change subject: IMPALA-12532: Fix bug in cancel_query_and_validate_state .. IMPALA-12532: Fix bug in cancel_query_and_validate_state

[Impala-ASF-CR] IMPALA-12528: Deflake test hdfs scanner thread non reserved bytes

2023-10-31 Thread Riza Suminto (Code Review)
Riza Suminto has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20640 Change subject: IMPALA-12528: Deflake test_hdfs_scanner_thread_non_reserved_bytes .. IMPALA-12528: Deflake

[Impala-ASF-CR] IMPALA-12528: Deflake test hdfs scanner thread non reserved bytes

2023-10-31 Thread Riza Suminto (Code Review)
Hello Quanlong Huang, Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20640 to look at the new patch set (#2). Change subject: IMPALA-12528: Deflake test_hdfs_scanner_thread_non_reserved_bytes

[Impala-ASF-CR] IMPALA-12493: Allow retry after failed cancel query

2023-10-31 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/20584 ) Change subject: IMPALA-12493: Allow retry after failed cancel_query .. Patch Set 4: (1 comment)

[Impala-ASF-CR] IMPALA-12532: Fix bug in cancel query and validate state

2023-10-31 Thread Riza Suminto (Code Review)
Hello Wenzhe Zhou, Michael Smith, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20641 to look at the new patch set (#2). Change subject: IMPALA-12532: Fix bug in cancel_query_and_validate_state

[Impala-ASF-CR] IMPALA-12532: Fix bug in cancel query and validate state

2023-10-31 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/20641 ) Change subject: IMPALA-12532: Fix bug in cancel_query_and_validate_state .. Patch Set 2: > Patch Set 1: > > I see a few other examples

[Impala-ASF-CR] IMPALA-3825: Delegate runtime filter aggregation to some executors

2023-11-01 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/20612 ) Change subject: IMPALA-3825: Delegate runtime filter aggregation to some executors .. Patch Set 10: (2 comments)

[Impala-ASF-CR] IMPALA-12528: Deflake test hdfs scanner thread non reserved bytes

2023-11-01 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/20640 ) Change subject: IMPALA-12528: Deflake test_hdfs_scanner_thread_non_reserved_bytes .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-3825: Delegate runtime filter aggregation to some executors

2023-11-01 Thread Riza Suminto (Code Review)
Hello Kurt Deschler, Abhishek Rawat, Csaba Ringhofer, Michael Smith, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20612 to look at the new patch set (#8). Change subject: IMPALA-3825: Delegate runtime filter aggregation to some

[Impala-ASF-CR] IMPALA-3825: Delegate runtime filter aggregation to some executors

2023-11-01 Thread Riza Suminto (Code Review)
Hello Kurt Deschler, Abhishek Rawat, Csaba Ringhofer, Michael Smith, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20612 to look at the new patch set (#9). Change subject: IMPALA-3825: Delegate runtime filter aggregation to some

[Impala-ASF-CR] IMPALA-12528: Deflake test hdfs scanner thread non reserved bytes

2023-11-01 Thread Riza Suminto (Code Review)
Hello Quanlong Huang, Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20640 to look at the new patch set (#3). Change subject: IMPALA-12528: Deflake test_hdfs_scanner_thread_non_reserved_bytes

[Impala-ASF-CR] IMPALA-12528: Deflake test hdfs scanner thread non reserved bytes

2023-11-01 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/20640 ) Change subject: IMPALA-12528: Deflake test_hdfs_scanner_thread_non_reserved_bytes .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-3825: Delegate runtime filter aggregation to some executors

2023-11-01 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/20612 ) Change subject: IMPALA-3825: Delegate runtime filter aggregation to some executors .. Patch Set 8: (3 comments)

[Impala-ASF-CR] IMPALA-3825: Delegate runtime filter aggregation to some executors

2023-11-01 Thread Riza Suminto (Code Review)
Hello Kurt Deschler, Abhishek Rawat, Csaba Ringhofer, Michael Smith, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20612 to look at the new patch set (#10). Change subject: IMPALA-3825: Delegate runtime filter aggregation to some

[Impala-ASF-CR] IMPALA-12528: Deflake test hdfs scanner thread non reserved bytes

2023-11-01 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/20640 ) Change subject: IMPALA-12528: Deflake test_hdfs_scanner_thread_non_reserved_bytes .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-12493: Allow retry after failed cancel query

2023-10-31 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/20584 ) Change subject: IMPALA-12493: Allow retry after failed cancel_query .. Patch Set 4: (1 comment)

[Impala-ASF-CR] IMPALA-12493: Allow retry after failed cancel query

2023-11-02 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/20584 ) Change subject: IMPALA-12493: Allow retry after failed cancel_query .. Patch Set 6: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-12542: Wait for query cancellation in webserver test

2023-11-06 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/20668 ) Change subject: IMPALA-12542: Wait for query cancellation in webserver test .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-12542: Wait for query cancellation

2023-11-06 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/20668 ) Change subject: IMPALA-12542: Wait for query cancellation .. Patch Set 2: Code-Review+2 (1 comment) Thanks for looking into this!

[Impala-ASF-CR] IMPALA-12018: Consider runtime filter for cardinality reduction

2023-11-07 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/20498 ) Change subject: IMPALA-12018: Consider runtime filter for cardinality reduction .. Patch Set 5: patch set 5 is a rebase to catch up

[Impala-ASF-CR] IMPALA-12364: Display memory, disk and network metrics in webUI's query timeline

2023-11-07 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/20355 ) Change subject: IMPALA-12364: Display memory, disk and network metrics in webUI's query timeline .. Patch Set 24: (5 comments)

[Impala-ASF-CR] IMPALA-12525: Fix flaky test test statestored manual failover

2023-11-07 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/20657 ) Change subject: IMPALA-12525: Fix flaky test test_statestored_manual_failover .. Patch Set 5: (6 comments)

[Impala-ASF-CR] IMPALA-12525: Fix flaky test test statestored manual failover

2023-11-07 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/20657 ) Change subject: IMPALA-12525: Fix flaky test test_statestored_manual_failover .. Patch Set 6: Code-Review+1 (3 comments)

[Impala-ASF-CR] IMPALA-12018: Consider runtime filter for cardinality reduction

2023-10-31 Thread Riza Suminto (Code Review)
Hello Daniel Becker, Abhishek Rawat, David Rorke, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20498 to look at the new patch set (#4). Change subject: IMPALA-12018: Consider runtime filter for cardinality

[Impala-ASF-CR] IMPALA-12510: Floor PlanFragment.maxParallelism at 1

2023-10-23 Thread Riza Suminto (Code Review)
Riza Suminto has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20606 ) Change subject: IMPALA-12510: Floor PlanFragment.maxParallelism_ at 1 .. IMPALA-12510: Floor PlanFragment.maxParallelism_ at 1

[Impala-ASF-CR] IMPALA-12510: Floor PlanFragment.maxParallelism at 1

2023-10-23 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/20606 ) Change subject: IMPALA-12510: Floor PlanFragment.maxParallelism_ at 1 .. Patch Set 4: Verified+1 Manually put +1 on Verified vote

[Impala-ASF-CR] IMPALA-12510: Floor PlanFragment.maxParallelism at 1

2023-10-23 Thread Riza Suminto (Code Review)
Riza Suminto has removed a vote on this change. Change subject: IMPALA-12510: Floor PlanFragment.maxParallelism_ at 1 .. Removed Verified-1 by Impala Public Jenkins -- To view, visit http://gerrit.cloudera.org:8080/20606 To

[Impala-ASF-CR] IMPALA-12510: Floor PlanFragment.maxParallelism at 1

2023-10-23 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/20606 ) Change subject: IMPALA-12510: Floor PlanFragment.maxParallelism_ at 1 .. Patch Set 4: > Patch Set 4: Verified-1 > > Build failed:

[Impala-ASF-CR] IMPALA-12018: Consider runtime filter for cardinality reduction

2023-10-24 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/20498 ) Change subject: IMPALA-12018: Consider runtime filter for cardinality reduction .. Patch Set 3: (3 comments)

[Impala-ASF-CR] IMPALA-3825: Delegate runtime filter aggregation to some executors

2023-10-24 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/20612 ) Change subject: IMPALA-3825: Delegate runtime filter aggregation to some executors .. Patch Set 5: (18 comments)

[Impala-ASF-CR] IMPALA-3825: Delegate runtime filter aggregation to some executors

2023-10-24 Thread Riza Suminto (Code Review)
Hello Kurt Deschler, Abhishek Rawat, Csaba Ringhofer, Michael Smith, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20612 to look at the new patch set (#4). Change subject: IMPALA-3825: Delegate runtime filter aggregation to some

[Impala-ASF-CR] IMPALA-3825: Delegate runtime filter aggregation to some executors

2023-10-24 Thread Riza Suminto (Code Review)
Hello Kurt Deschler, Abhishek Rawat, Csaba Ringhofer, Michael Smith, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20612 to look at the new patch set (#5). Change subject: IMPALA-3825: Delegate runtime filter aggregation to some

[Impala-ASF-CR] IMPALA-12518: Combine all exec option dimension in test vector.py

2023-10-26 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/20625 ) Change subject: IMPALA-12518: Combine all exec_option dimension in test_vector.py .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-12508: Improve query option "enabled runtime filter types"

2023-10-26 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/20627 ) Change subject: IMPALA-12508: Improve query option "enabled_runtime_filter_types" .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-12518: Combine all exec option dimension in test vector.py

2023-10-26 Thread Riza Suminto (Code Review)
Hello Gabor Kaszab, Zoltan Borok-Nagy, Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20625 to look at the new patch set (#2). Change subject: IMPALA-12518: Combine all exec_option dimension in test_vector.py

[Impala-ASF-CR] IMPALA-12545: Use 'unique database' in test restart services.py::TestRestart

2023-11-06 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/20662 ) Change subject: IMPALA-12545: Use 'unique_database' in test_restart_services.py::TestRestart .. Patch Set 1: Code-Review+2 Looks good

[Impala-ASF-CR] IMPALA-12312: Using correct executor group set info for planning

2023-09-20 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/20273 ) Change subject: IMPALA-12312: Using correct executor group set info for planning .. Patch Set 6: (2 comments)

[Impala-ASF-CR] IMPALA-12364: Display memory, disk and network metrics in webUI's query timeline

2023-09-25 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/20355 ) Change subject: IMPALA-12364: Display memory, disk and network metrics in webUI's query timeline .. Patch Set 13: (13 comments)

[Impala-ASF-CR] IMPALA-12312: Using correct executor group set info for planning

2023-09-25 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/20273 ) Change subject: IMPALA-12312: Using correct executor group set info for planning .. Patch Set 7: (1 comment)

[Impala-ASF-CR] IMPALA-11068: Add query option to reduce scanner thread launch.

2023-10-02 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/18126 ) Change subject: IMPALA-11068: Add query option to reduce scanner thread launch. .. Patch Set 5: Patch set 4 is a rebase to resolve

<    1   2   3   4   5   6   7   8   9   10   >