Henry Robinson has posted comments on this change. (
http://gerrit.cloudera.org:8080/8401 )
Change subject: IMPALA-5473: [DOCS] Document TLS min version & cipher options
..
Patch Set 2:
(2 comments)
Henry Robinson has posted comments on this change.
Change subject: IMPALA-4671: Replace kudu::ServicePool with one that uses
Impala threads
..
Patch Set 1:
Why not make a separate implementation of a service pool, rather than
Henry Robinson has posted comments on this change.
Change subject: IMPALA-5849: Remove compile-time checks for OpenSSL > 1.0.0
..
Patch Set 5: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/7866
To
Henry Robinson has submitted this change and it was merged.
Change subject: IMPALA-5849: Remove compile-time checks for OpenSSL > 1.0.0
..
IMPALA-5849: Remove compile-time checks for OpenSSL > 1.0.0
(Prerequisite knowledge:
Hello Impala Public Jenkins, Bharath Vissapragada, Sailesh Mukil,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7866
to look at the new patch set (#5).
Change subject: IMPALA-5849: Remove compile-time checks for OpenSSL > 1.0.0
Henry Robinson has posted comments on this change.
Change subject: IMPALA-5849: Remove compile-time checks for OpenSSL > 1.0.0
..
Patch Set 4: Code-Review+2
Carry +2 w/rebase.
--
To view, visit
Henry Robinson has posted comments on this change.
Change subject: IMPALA-5849: Remove compile-time checks for OpenSSL > 1.0.0
..
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7866/3//COMMIT_MSG
Commit Message:
Hello Bharath Vissapragada, Sailesh Mukil,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7866
to look at the new patch set (#3).
Change subject: IMPALA-5849: Remove compile-time checks for OpenSSL > 1.0.0
Henry Robinson has posted comments on this change.
Change subject: IMPALA-5849: Remove compile-time checks for OpenSSL > 1.0.0
..
Patch Set 1:
(1 comment)
An update: I discovered that it is *not* backwards compatible to use
Henry Robinson has posted comments on this change.
Change subject: IMPALA-5849: Remove compile-time checks for OpenSSL > 1.0.0
..
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/7866/1//COMMIT_MSG
Commit
Henry Robinson has posted comments on this change.
Change subject: CDH-58701: Check for existence of sync_file_range()
..
Patch Set 1: Code-Review+2
did you manage to build this on Centos or rhel 5.5?
--
To view, visit
Hello Bharath Vissapragada,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7866
to look at the new patch set (#2).
Change subject: IMPALA-5849: Remove compile-time checks for OpenSSL > 1.0.0
Henry Robinson has uploaded a new change for review.
http://gerrit.cloudera.org:8080/7908
Change subject: IMPALA-5816: xfail wildcard TLS cert tests
..
IMPALA-5816: xfail wildcard TLS cert tests
Wildcard support is not
Henry Robinson has submitted this change and it was merged.
Change subject: IMPALA-5849: Disable compile-time checks for OpenSSL > 1.0.0
..
IMPALA-5849: Disable compile-time checks for OpenSSL > 1.0.0
Thrift commit taken from:
Henry Robinson has posted comments on this change.
Change subject: IMPALA-5849: Disable compile-time checks for OpenSSL > 1.0.0
..
Patch Set 5: Code-Review+2 Verified+1
Verified by a toolchain build.
--
To view, visit
Henry Robinson has posted comments on this change.
Change subject: KUDU-2041: Fix negotiation deadlock
..
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/7742
To unsubscribe, visit
Henry Robinson has posted comments on this change.
Change subject: IMPALA-5849: Disable compile-time checks for OpenSSL > 1.0.0
..
Patch Set 4:
(1 comment)
Also fix a bug in how the options are checked after setting.
Hello Sailesh Mukil,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7859
to look at the new patch set (#5).
Change subject: IMPALA-5849: Disable compile-time checks for OpenSSL > 1.0.0
..
Henry Robinson has posted comments on this change.
Change subject: IMPALA-5849: Disable compile-time checks for OpenSSL > 1.0.0
..
Patch Set 4:
(1 comment)
Henry Robinson has posted comments on this change.
Change subject: KUDU-2065: Support cancellation for outbound RPC call
..
Patch Set 1:
Wasn't there an outstanding bug with cancellation that was found in Kudu? Does
that
Henry Robinson has uploaded a new change for review.
http://gerrit.cloudera.org:8080/7866
Change subject: IMPALA-5849: Remove compile-time checks for OpenSSL > 1.0.0
..
IMPALA-5849: Remove compile-time checks for OpenSSL >
Henry Robinson has posted comments on this change.
Change subject: IMPALA-467: enable disabled metric verification
..
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/7827
To unsubscribe, visit
Henry Robinson has uploaded a new patch set (#4).
Change subject: IMPALA-5849: Disable compile-time checks for OpenSSL > 1.0.0
..
IMPALA-5849: Disable compile-time checks for OpenSSL > 1.0.0
Thrift commit taken from:
Henry Robinson has posted comments on this change.
Change subject: IMPALA-5853: GetResultSetMetadata() invalid query id error
message is confusing
..
Patch Set 1: Code-Review+2
(2 comments)
Henry Robinson has posted comments on this change.
Change subject: IMPALA-4856: Include KRPC services in plan fragment's
destinations
..
Patch Set 2:
(1 comment)
Henry Robinson has posted comments on this change.
Change subject: IMPALA-4856: Include KRPC services in plan fragment's
destinations
..
Patch Set 3:
(1 comment)
Henry Robinson has uploaded a new patch set (#3).
Change subject: IMPALA-5849: Disable compile-time checks for OpenSSL > 1.0.0
..
IMPALA-5849: Disable compile-time checks for OpenSSL > 1.0.0
Thrift commit taken from:
Henry Robinson has uploaded a new change for review.
http://gerrit.cloudera.org:8080/7859
Change subject: IMPALA-5849: Disable compile-time checks for OpenSSL > 1.0.0
..
IMPALA-5849: Disable compile-time checks for OpenSSL >
Henry Robinson has posted comments on this change.
Change subject: IMPALA-4856: Include KRPC services in plan fragment's
destinations
..
Patch Set 2:
(1 comment)
Henry Robinson has posted comments on this change.
Change subject: IMPALA-4856: Include KRPC services in plan fragment's
destinations
..
Patch Set 3:
(1 comment)
Henry Robinson has posted comments on this change.
Change subject: IMPALA-5394: Change ThriftServer() to always use
TAcceptQueueServer
..
Patch Set 7:
I wonder if you could write a test in thrift-server-test, that did
Henry Robinson has posted comments on this change.
Change subject: IMPALA-4669: [KRPC] Add kudu_rpc library to build
..
Patch Set 17: Code-Review+2
Forgot to add necessary changes to logging.cc to patch.
--
To view, visit
Hello Impala Public Jenkins, Michael Ho,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5719
to look at the new patch set (#17).
Change subject: IMPALA-4669: [KRPC] Add kudu_rpc library to build
Henry Robinson has posted comments on this change.
Change subject: IMPALA-4856: Include KRPC services in plan fragment's
destinations
..
Patch Set 2:
(4 comments)
Henry Robinson has uploaded a new change for review.
http://gerrit.cloudera.org:8080/7818
Change subject: IMPALA-5846: Fix output path for kudu libraries
..
IMPALA-5846: Fix output path for kudu libraries
Prior to this
Henry Robinson has posted comments on this change.
Change subject: IMPALA-4669: [KRPC] Add kudu_rpc library to build
..
Patch Set 14:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5719/14/be/src/kudu/rpc/CMakeLists.txt
File
Hello Impala Public Jenkins, Michael Ho,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5719
to look at the new patch set (#15).
Change subject: IMPALA-4669: [KRPC] Add kudu_rpc library to build
Henry Robinson has posted comments on this change.
Change subject: IMPALA-5108: idle_session_timeout kicks in later than expected
..
Patch Set 1:
The previous commit was merged - it will need a new change ID.
--
To view,
Henry Robinson has posted comments on this change.
Change subject: IMPALA-5811: Add 'backends' tab to query details pages
..
Patch Set 5:
(6 comments)
Hello Bharath Vissapragada, Tim Armstrong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7711
to look at the new patch set (#6).
Change subject: IMPALA-5811: Add 'backends' tab to query details pages
Henry Robinson has posted comments on this change.
Change subject: IMPALA-5775: (Addendum) Make SSL cluster actually come up in
test_client_ssl.py
..
Patch Set 2: Code-Review+2
--
To view, visit
Henry Robinson has posted comments on this change.
Change subject: IMPALA-5811: Add 'backends' tab to query details pages
..
Patch Set 4:
(1 comment)
Hello Bharath Vissapragada, Tim Armstrong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7711
to look at the new patch set (#5).
Change subject: IMPALA-5811: Add 'backends' tab to query details pages
Henry Robinson has posted comments on this change.
Change subject: Hide some deprecated flags
..
Patch Set 2:
Thanks - is there any more information you need before you can give a +2?
--
To view, visit
Henry Robinson has posted comments on this change.
Change subject: Hide some deprecated flags
..
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/7786/1//COMMIT_MSG
Commit Message:
Line 7: Hide some deprecated
Henry Robinson has uploaded a new patch set (#2).
Change subject: Hide some deprecated flags
..
Hide some deprecated flags
Hidden flags do not show up in /varz or --help.
Change-Id: I948b46cd6853f1d8ebaaadaba7b801dca886c7ad
Henry Robinson has uploaded a new change for review.
http://gerrit.cloudera.org:8080/7786
Change subject: Hide some deprecated flags
..
Hide some deprecated flags
Change-Id: I948b46cd6853f1d8ebaaadaba7b801dca886c7ad
---
M
Henry Robinson has posted comments on this change.
Change subject: IMPALA-5211: Simplifying ifnull/isnull/nvl where conditional is
a literal.
..
Patch Set 3:
(4 comments)
just passing through.
Henry Robinson has posted comments on this change.
Change subject: IMPALA-5811: Add 'backends' tab to query details pages
..
Patch Set 3:
(2 comments)
Added a test, thanks for the suggestion!
Henry Robinson has uploaded a new change for review.
http://gerrit.cloudera.org:8080/7768
Change subject: IMPALA-5825: Catch exceptions thrown by TSSLSocketFactory c'tor
..
IMPALA-5825: Catch exceptions thrown by
Henry Robinson has posted comments on this change.
Change subject: IMPALA-5394: Change ThriftServer() to always use
TAcceptQueueServer
..
Patch Set 5:
Hi John - anything I can do to help with this one? Let me know if you need
Henry Robinson has posted comments on this change.
Change subject: Cherry-pick constant renaming for be/src/kudu from Kudu commit
e719b
..
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/7740
To
Henry Robinson has posted comments on this change.
Change subject: tidy: enable rule for constant naming
..
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7740/2//COMMIT_MSG
Commit Message:
PS2, Line 7: tidy:
Henry Robinson has posted comments on this change.
Change subject: tidy: enable rule for constant naming
..
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7740/2//COMMIT_MSG
Commit Message:
PS2, Line 7: tidy:
Henry Robinson has posted comments on this change.
Change subject: tidy: enable rule for constant naming
..
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7740/1//COMMIT_MSG
Commit Message:
Line 7: tidy: enable
Henry Robinson has uploaded a new patch set (#2).
Change subject: IMPALA-5800: [Addendum] Fix bad import of squeasel.c
..
IMPALA-5800: [Addendum] Fix bad import of squeasel.c
The previous commit for IMPALA-5800 imported a
Henry Robinson has uploaded a new change for review.
http://gerrit.cloudera.org:8080/7752
Change subject: IMPALA-5800: [Addendum] Fix bad import of squeasel.c
..
IMPALA-5800: [Addendum] Fix bad import of squeasel.c
The
Henry Robinson has posted comments on this change.
Change subject: IMPALA-5108: idle_session_timeout kicks in later than expected
..
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/7709
To
Hello Impala Public Jenkins, Michael Ho,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5719
to look at the new patch set (#14).
Change subject: IMPALA-4669: [KRPC] Add kudu_rpc library to build
Henry Robinson has uploaded a new change for review.
http://gerrit.cloudera.org:8080/7732
Change subject: IMPALA-5775: (Addendum) Make SSL cluster actually come up in
test_client_ssl.py
..
IMPALA-5775: (Addendum) Make SSL
Henry Robinson has posted comments on this change.
Change subject: IMPALA-5108:idle_session_timeout kicks in later than expected
..
Patch Set 2: Code-Review+2
(3 comments)
Henry Robinson has abandoned this change.
Change subject: IMPALA-5108:idle_session_timeout kicks in later than expected
..
Abandoned
--
To view, visit http://gerrit.cloudera.org:8080/7712
To unsubscribe, visit
Henry Robinson has posted comments on this change.
Change subject: IMPALA-5811: Add 'backends' tab to query details pages
..
Patch Set 1:
(4 comments)
Henry Robinson has uploaded a new patch set (#3).
Change subject: IMPALA-5811: Add 'backends' tab to query details pages
..
IMPALA-5811: Add 'backends' tab to query details pages
Add a 'backends' tab to query details pages
Henry Robinson has posted comments on this change.
Change subject: IMPALA-5811: Add 'backends' tab to query details pages
..
Patch Set 2:
That's deliberate - preserve the last seen set of states. I could change
something to
Henry Robinson has uploaded a new patch set (#2).
Change subject: IMPALA-5811: Add 'backends' tab to query details pages
..
IMPALA-5811: Add 'backends' tab to query details pages
Add a 'backends' tab to query details pages
Henry Robinson has posted comments on this change.
Change subject: IMPALA-5811: Add 'backends' tab to query details pages
..
Patch Set 1:
Presumably the query was a DDL statement, so there was no coordinator. Thanks
for the
Henry Robinson has uploaded a new patch set (#2).
Change subject: IMPALA-4786: Clean up how ImpalaServers are created
..
IMPALA-4786: Clean up how ImpalaServers are created
ImpalaServer had to be created via an awkward
Henry Robinson has posted comments on this change.
Change subject: IMPALA-5108:idle_session_timeout kicks in later than expected
..
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7712/1//COMMIT_MSG
Commit
Henry Robinson has posted comments on this change.
Change subject: (PREVIEW) IMPALA-5684: Optionally run be tests in sharded mode
..
Patch Set 2:
Thanks for the review, btw - I'm working on some ergonomic improvements before
Henry Robinson has uploaded a new change for review.
http://gerrit.cloudera.org:8080/7711
Change subject: IMPALA-5811: Add 'backends' tab to query details pages
..
IMPALA-5811: Add 'backends' tab to query details pages
Add a
Henry Robinson has posted comments on this change.
Change subject: IMPALA-5108:idle_session_timeout kicks in later than expected
..
Patch Set 1:
(5 comments)
Hello Michael Ho,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5719
to look at the new patch set (#13).
Change subject: IMPALA-4669: [KRPC] Add kudu_rpc library to build
..
Henry Robinson has posted comments on this change.
Change subject: Propagate HAVE_PIPE2 compile time value to files that use it
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/7705
To
Henry Robinson has posted comments on this change.
Change subject: IMPALA-5158,IMPALA-5236: account for unused buffer pool
reservations
..
Patch Set 6:
FWIW (and this is veering away from an Apache discussion), I thought
Henry Robinson has posted comments on this change.
Change subject: IMPALA-2615: support [[nodiscard]] on Status
..
Patch Set 14:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7253/14/be/src/runtime/exec-env.cc
File
Henry Robinson has posted comments on this change.
Change subject: IMPALA-5749: coordinator race hits DCHECK
'num_remaining_backends_ > 0'
..
Patch Set 3: Code-Review+1
(3 comments)
Thanks - this seems a lot better to me.
Henry Robinson has posted comments on this change.
Change subject: IMPALA-4669: [KRPC] Add kudu_rpc library to build
..
Patch Set 12:
This patch builds on all platforms we test on here at Cloudera.
--
To view, visit
Henry Robinson has uploaded a new patch set (#12).
Change subject: IMPALA-4669: [KRPC] Add kudu_rpc library to build
..
IMPALA-4669: [KRPC] Add kudu_rpc library to build
Import FindKRPC.cmake from Apache Kudu.
One minor
Henry Robinson has posted comments on this change.
Change subject: IMPALA-5800: Configure Squeasel's cipher suite and TLS version
..
Patch Set 3: Code-Review+2
I feel pretty ok giving this a +2 myself, as the Impala-side
Henry Robinson has uploaded a new patch set (#3).
Change subject: IMPALA-5800: Configure Squeasel's cipher suite and TLS version
..
IMPALA-5800: Configure Squeasel's cipher suite and TLS version
* Import Squeasel as of
Henry Robinson has posted comments on this change.
Change subject: IMPALA-5800: Configure Squeasel's cipher suite and TLS version
..
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/7679/1//COMMIT_MSG
Commit
Henry Robinson has posted comments on this change.
Change subject: IMPALA-5800: Configure Squeasel's cipher suite and TLS version
..
Patch Set 2:
(1 comment)
Henry Robinson has posted comments on this change.
Change subject: IMPALA-5800: Configure Squeasel's cipher suite and TLS version
..
Patch Set 1:
(1 comment)
Henry Robinson has uploaded a new patch set (#2).
Change subject: IMPALA-5800: Configure Squeasel's cipher suite and TLS version
..
IMPALA-5800: Configure Squeasel's cipher suite and TLS version
* Import Squeasel from
Henry Robinson has posted comments on this change.
Change subject: IMPALA-5800: Configure Squeasel's cipher suite and TLS version
..
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/7679/1//COMMIT_MSG
Commit
Hello Sailesh Mukil,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7675
to look at the new patch set (#3).
Change subject: IMPALA-5775: Allow shell to support TLSv1, v1.1 and v1.2
..
Henry Robinson has posted comments on this change.
Change subject: IMPALA-5775: Allow shell to support TLSv1, v1.1 and v1.2
..
Patch Set 2:
(2 comments)
Henry Robinson has uploaded a new change for review.
http://gerrit.cloudera.org:8080/7679
Change subject: IMPALA-5800: Configure Squeasel's cipher suite and TLS version
..
IMPALA-5800: Configure Squeasel's cipher suite and
Henry Robinson has uploaded a new change for review.
http://gerrit.cloudera.org:8080/7676
Change subject: IMPALA-5109: Increase range of backend latency histogram
..
IMPALA-5109: Increase range of backend latency histogram
Henry Robinson has posted comments on this change.
Change subject: IMPALA-5743: Support TLS version configuration for Thrift
servers
..
Patch Set 6: Code-Review+2
Fix a couple of clang-tidy warnings.
--
To view, visit
Hello Impala Public Jenkins, Sailesh Mukil, Dan Hecht,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7606
to look at the new patch set (#6).
Change subject: IMPALA-5743: Support TLS version configuration for Thrift
servers
Hello Sailesh Mukil,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7675
to look at the new patch set (#2).
Change subject: IMPALA-5775: Allow shell to support TLSv1, v1.1 and v1.2
..
Henry Robinson has posted comments on this change.
Change subject: IMPALA-5775: Allow shell to support TLSv1, v1.1 and v1.2
..
Patch Set 1:
(1 comment)
Henry Robinson has uploaded a new change for review.
http://gerrit.cloudera.org:8080/7675
Change subject: IMPALA-5775: Allow shell to support TLSv1, v1.1 and v1.2
..
IMPALA-5775: Allow shell to support TLSv1, v1.1 and v1.2
Hello Sailesh Mukil, Dan Hecht,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7606
to look at the new patch set (#5).
Change subject: IMPALA-5743: Support TLS version configuration for Thrift
servers
Henry Robinson has posted comments on this change.
Change subject: IMPALA-4669: [SECURITY] Import Kudu security library from
kudu@314c9d8
..
Patch Set 17:
That build included this patch. Or do you have reason to believe it
Henry Robinson has submitted this change and it was merged.
Change subject: IMPALA-4669: [SECURITY] Add security library to build
..
IMPALA-4669: [SECURITY] Add security library to build
* Minor compilation fix
* Add krb5 as a
Henry Robinson has posted comments on this change.
Change subject: IMPALA-4669: [SECURITY] Add security library to build
..
Patch Set 20: Code-Review+2 Verified+1
Rebase, carry +1 and +2.
--
To view, visit
Henry Robinson has posted comments on this change.
Change subject: IMPALA-4669: [SECURITY] Import Kudu security library from
kudu@314c9d8
..
Patch Set 16: Code-Review+2 Verified+1
Verified by build:
1 - 100 of 874 matches
Mail list logo
