Dan Hecht has posted comments on this change.
Change subject: IMPALA-4990: fix run_tests.py --update_results
..
Patch Set 1:
Yeah, sorry I let this linger. I ran into trouble trying to write a test a
while back. Mike, are
Dan Hecht has posted comments on this change.
Change subject: IMPALA-5188: Add slot sorting in TupleDescriptor::LayoutEquals()
..
Patch Set 7: Code-Review+2
(1 comment)
Carry +2 given Alex signed off on the new fe changes.
Dan Hecht has posted comments on this change.
Change subject: IMPALA-5246: UDF's Close() should handle Expr's preparation
failure
..
Patch Set 1:
Free() already has a null check. What am I missing?
void
Dan Hecht has posted comments on this change.
Change subject: IMPALA-5166: clean up BufferPool counters
..
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/6690/3/be/src/runtime/bufferpool/buffer-pool.cc
File
Dan Hecht has posted comments on this change.
Change subject: IMPALA-5166: clean up BufferPool counters
..
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/6690/3/be/src/runtime/bufferpool/buffer-pool.cc
File
Dan Hecht has posted comments on this change.
Change subject: IMPALA-5238: transfer reservations between trackers
..
Patch Set 6:
(8 comments)
Dan Hecht has posted comments on this change.
Change subject: IMPALA-1972/IMPALA-3882: Fix QueryExecState::lock_ contention
..
Patch Set 2:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/6707/2//COMMIT_MSG
Commit Message:
Dan Hecht has posted comments on this change.
Change subject: IMPALA-5238: transfer reservations between trackers
..
Patch Set 6:
(1 comment)
Dan Hecht has posted comments on this change.
Change subject: IMPALA-5169: Add support for async pins in buffer pool
..
Patch Set 10:
(14 comments)
This public abstraction looks good now. Mostly some renaming suggestions to
Dan Hecht has posted comments on this change.
Change subject: IMPALA-1972/IMPALA-3882: Fix QueryExecState::lock_ contention
..
Patch Set 3:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/6707/2//COMMIT_MSG
Commit Message:
Dan Hecht has posted comments on this change.
Change subject: IMPALA-5238: transfer reservations between trackers
..
Patch Set 6:
(2 comments)
Dan Hecht has posted comments on this change.
Change subject: IMPALA-5158: Part 1: include untracked memory in MemTracker
dumps
..
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/6820
To
Dan Hecht has posted comments on this change.
Change subject: IMPALA-5220: memory maintenance cleanup
..
Patch Set 9: Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/6626/9/be/src/common/init.cc
File
Dan Hecht has posted comments on this change.
Change subject: IMPALA-5169: Add support for async pins in buffer pool
..
Patch Set 5:
(4 comments)
Didn't get all the way through but probably better to finish after you make the
Dan Hecht has posted comments on this change.
Change subject: IMPALA-5239: transfer reservations between trackers
..
Patch Set 3:
(5 comments)
http://gerrit.cloudera.org:8080/#/c/6708/3//COMMIT_MSG
Commit Message:
PS3, Line
Dan Hecht has posted comments on this change.
Change subject: IMPALA-5085: large rows in BufferedTupleStreamV2
..
Patch Set 3:
(7 comments)
http://gerrit.cloudera.org:8080/#/c/6638/3//COMMIT_MSG
Commit Message:
PS3, Line 16:
Dan Hecht has posted comments on this change.
Change subject: IMPALA-5166: clean up BufferPool counters
..
Patch Set 3:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/6690/3//COMMIT_MSG
Commit Message:
Line 9: Misc changes
Dan Hecht has posted comments on this change.
Change subject: IMPALA-5297: Reduce free-pool-test mem requirement to avoid OOM
..
Patch Set 3: Code-Review+2
> I measured the max rss w/ this change to be 88mb, down from 14gb is
Dan Hecht has posted comments on this change.
Change subject: IMPALA-5297: Reduce free-pool-test mem requirement to avoid OOM
..
Patch Set 1:
Looking at git history, the large allocations were added here, so let's be sure
Dan Hecht has posted comments on this change.
Change subject: IMPALA-5297: Reduce free-pool-test mem requirement to avoid OOM
..
Patch Set 1:
(1 comment)
Dan Hecht has posted comments on this change.
Change subject: IMPALA-5238: transfer reservations between trackers
..
Patch Set 5:
(6 comments)
Dan Hecht has posted comments on this change.
Change subject: IMPALA-5166: clean up BufferPool counters
..
Patch Set 6: Code-Review+2
(2 comments)
Dan Hecht has posted comments on this change.
Change subject: Revert "IMPALA-2716: Hive/Impala incompatibility for timestamp
data in Parquet"
..
Patch Set 1:
Was it a clean revert? If not, where were the conflicts?
--
To
Dan Hecht has posted comments on this change.
Change subject: IMPALA-1972/IMPALA-3882: Fix QueryExecState::lock_ contention
..
Patch Set 6:
> I haven't rebased this yet on to new QES changes so that you can
> diff it from
Dan Hecht has posted comments on this change.
Change subject: IMPALA-1972/IMPALA-3882: Fix QueryExecState::lock_ contention
..
Patch Set 6:
(4 comments)
Dan Hecht has posted comments on this change.
Change subject: IMPALA-1972/IMPALA-3882: Fix QueryExecState::lock_ contention
..
Patch Set 6:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/6707/6//COMMIT_MSG
Commit Message:
Dan Hecht has posted comments on this change.
Change subject: IMPALA-5238: transfer reservations between trackers
..
Patch Set 8: Code-Review+2
(2 comments)
Dan Hecht has posted comments on this change.
Change subject: IMPALA-1972/IMPALA-3882: Fix QueryExecState::lock_ contention
..
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/6707/2//COMMIT_MSG
Commit Message:
Dan Hecht has posted comments on this change.
Change subject: IMPALA-4965: Authorize access to runtime profile and exec
summary
..
Patch Set 8: Code-Review+2
(2 comments)
Dan Hecht has posted comments on this change.
Change subject: IMPALA-5221: Fix TSaslTransport negotiation order
..
Patch Set 1:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/7116/1/be/src/transport/TSasl.h
File
Dan Hecht has posted comments on this change.
Change subject: IMPALA-5031: Remove undefined behavior "reference binding to
null"
..
Patch Set 6:
(1 comment)
Dan Hecht has posted comments on this change.
Change subject: IMPALA-5487: Fix race in RuntimeProfile::toThrift()
..
Patch Set 1:
> (1 comment)
Let's remove it
--
To view, visit http://gerrit.cloudera.org:8080/7154
To
Dan Hecht has posted comments on this change.
Change subject: IMPALA-5487: Fix race in RuntimeProfile::toThrift()
..
Patch Set 2: Code-Review+2
Please have Tim and Sailesh also finish their reviews.
--
To view, visit
Dan Hecht has posted comments on this change.
Change subject: IMPALA-5427: Fix order of status handling in ClientRequestState
..
Patch Set 1:
(1 comment)
This is really subtle. In order to be correct, you'd need at least a
Dan Hecht has posted comments on this change.
Change subject: IMPALA-5427: Fix order of status handling in ClientRequestState
..
Patch Set 1:
> > (1 comment)
> >
> > This is really subtle. In order to be correct, you'd need
Dan Hecht has posted comments on this change.
Change subject: IMPALA-5446: dropped Sorter::Reset() status
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/7134
To unsubscribe, visit
Dan Hecht has posted comments on this change.
Change subject: IMPALA-5427: Fix race between CRS::UpdateQueryStatus() and
beeswax RPCs
..
Patch Set 3:
(2 comments)
Dan Hecht has posted comments on this change.
Change subject: IMPALA-5085: large rows in BufferedTupleStreamV2
..
Patch Set 10:
(23 comments)
Dan Hecht has posted comments on this change.
Change subject: IMPALA-5497: spilling hash joins that output build rows hit OOM
..
Patch Set 6: Code-Review+2
(2 comments)
Dan Hecht has posted comments on this change.
Change subject: IMPALA-5537: Retry RPC on somes exceptions with SSL connection
..
Patch Set 5: Code-Review+2
(3 comments)
Dan Hecht has posted comments on this change.
Change subject: IMPALA-5548 Fix some minor issues with HDFS / parquet column
readers
..
Patch Set 1:
(2 comments)
Dan Hecht has posted comments on this change.
Change subject: IMPALA-4703: reservation denial debug action
..
Patch Set 3:
(6 comments)
http://gerrit.cloudera.org:8080/#/c/7022/3/be/src/exec/exec-node.cc
File
Dan Hecht has posted comments on this change.
Change subject: IMPALA-5488: Fix handling of exclusive HDFS file handles
..
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/7181
To unsubscribe, visit
Dan Hecht has posted comments on this change.
Change subject: IMPALA-5537: Retry RPC on somes exceptions with SSL connection
..
Patch Set 7: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/7229
To unsubscribe,
Dan Hecht has posted comments on this change.
Change subject: IMPALA-3504: UDF for current timestamp in UTC
..
Patch Set 3:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/7203/3/be/src/runtime/runtime-state.h
File
Dan Hecht has posted comments on this change.
Change subject: IMPALA-5394: Set socket timeouts while opening TSaslTransport
..
Patch Set 2:
Cool, thanks.
--
To view, visit http://gerrit.cloudera.org:8080/7061
To unsubscribe,
Dan Hecht has posted comments on this change.
Change subject: IMPALA-5036: Parquet count star optimization
..
Patch Set 5:
(4 comments)
Dan Hecht has posted comments on this change.
Change subject: IMPALA-5548 Fix some minor nits with HDFS parquet column readers
..
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/7240
To
Dan Hecht has posted comments on this change.
Change subject: IMPALA-5548 Fix some minor nits with HDFS parquet column readers
..
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/7240
To
Dan Hecht has posted comments on this change.
Change subject: IMPALA-4703: reservation denial debug action
..
Patch Set 5: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/7022
To unsubscribe, visit
Dan Hecht has posted comments on this change.
Change subject: IMPALA-4866: Hash join node does not apply limits correctly
..
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/6778
To unsubscribe,
Dan Hecht has posted comments on this change.
Change subject: IMPALA-5562: Only recomputeMemLayout() if tuple has a layout.
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/7264
To unsubscribe,
Dan Hecht has posted comments on this change.
Change subject: IMPALA-5315: Cast to timestamp fails for -M-D format
..
Patch Set 5:
(1 comment)
Dan Hecht has posted comments on this change.
Change subject: IMPALA-5031: Remove undefined behavior "reference binding to
null"
..
Patch Set 7: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/7008
To
Dan Hecht has posted comments on this change.
Change subject: IMPALA-5394: Set socket timeouts while opening TSaslTransport
..
Patch Set 2:
What are the next steps here?
--
To view, visit http://gerrit.cloudera.org:8080/7061
Dan Hecht has posted comments on this change.
Change subject: IMPALA-3381: Support AM/PM marker in date and time format
strings
..
Patch Set 2:
What did we decide here? Can we move this forward or should we abandon the
Dan Hecht has posted comments on this change.
Change subject: IMPALA-4868: Increase
TestRequestPoolService.testUpdatingConfigs timeout
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/7118
To
Dan Hecht has posted comments on this change.
Change subject: IMPALA-5497: spilling hash joins that output build rows hit OOM
..
Patch Set 8: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/7180
To
Dan Hecht has posted comments on this change.
Change subject: IMPALA-5567: race in fragment instance teardown
..
Patch Set 4: Code-Review+2
(1 comment)
Dan Hecht has posted comments on this change.
Change subject: Revert "IMPALA-2716: Hive/Impala incompatibility for timestamp
data in Parquet"
..
Patch Set 2: Code-Review+2
--
To view, visit
Dan Hecht has posted comments on this change.
Change subject: IMPALA-1972/IMPALA-3882: Fix client_request_state_map_lock_
contention
..
Patch Set 9:
(1 comment)
Dan Hecht has posted comments on this change.
Change subject: IMPALA-1972/IMPALA-3882: Fix client_request_state_map_lock_
contention
..
Patch Set 9:
(1 comment)
Dan Hecht has posted comments on this change.
Change subject: IMPALA-1972/IMPALA-3882: Fix client_request_state_map_lock_
contention
..
Patch Set 9:
(1 comment)
Dan Hecht has posted comments on this change.
Change subject: IMPALA-1972/IMPALA-3882: Fix client_request_state_map_lock_
contention
..
Patch Set 10: Code-Review+2
(1 comment)
Dan Hecht has posted comments on this change.
Change subject: IMPALA-5160: adjust spill buffer size based on planner estimates
..
Patch Set 4:
(1 comment)
Would be interesting to see how this works on some real datasets.
Dan Hecht has posted comments on this change.
Change subject: IMPALA-5085: large rows in BufferedTupleStreamV2
..
Patch Set 5:
(7 comments)
Want to think more about the Allocate/AddRow stuff, but here's comments for the
Dan Hecht has posted comments on this change.
Change subject: IMPALA-4623: Enable file handle cache
..
Patch Set 21: Code-Review+2
Carry +2.
--
To view, visit http://gerrit.cloudera.org:8080/6478
To unsubscribe, visit
Dan Hecht has posted comments on this change.
Change subject: IMPALA-4623: Enable file handle cache
..
Patch Set 23: Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/6478/23/be/src/runtime/disk-io-mgr.h
File
Dan Hecht has posted comments on this change.
Change subject: IMPALA-4623: Enable file handle cache
..
Patch Set 19: Code-Review+2
Carry +2.
--
To view, visit http://gerrit.cloudera.org:8080/6478
To unsubscribe, visit
Dan Hecht has posted comments on this change.
Change subject: IMPALA-4890/5143: Coordinator race involving TearDown()
..
Patch Set 2: Code-Review+1
(2 comments)
LGTM but please see if Henry has any more comments.
Dan Hecht has posted comments on this change.
Change subject: IMPALA-5340: Query profile displays stale query state
..
Patch Set 2:
Any good way to regression test this?
--
To view, visit http://gerrit.cloudera.org:8080/6923
Dan Hecht has posted comments on this change.
Change subject: Revert "IMPALA-2716: Hive/Impala incompatibility for timestamp
data in Parquet"
..
Patch Set 1: Code-Review+2
(3 comments)
I only looked at the files with
Dan Hecht has posted comments on this change.
Change subject: IMPALA-5340: Query profile displays stale query state
..
Patch Set 2: Code-Review+2
> (1 comment)
>
> > Any good way to regression test this?
>
> Obviously
Dan Hecht has posted comments on this change.
Change subject: IMPALA-1972/IMPALA-3882: Fix client_request_state_map_lock_
contention
..
Patch Set 7:
(7 comments)
Dan Hecht has posted comments on this change.
Change subject: IMPALA-1972/IMPALA-3882: Fix client_request_state_map_lock_
contention
..
Patch Set 9:
(1 comment)
Dan Hecht has posted comments on this change.
Change subject: IMPALA-5331: Use new libHDFS API to address "Unknown Error 255"
..
Patch Set 7: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/6894
To
Dan Hecht has posted comments on this change.
Change subject: IMPALA-5031: Remove undefined behavior "reference binding to
null"
..
Patch Set 3: Code-Review+2
LGTM other than comments already raised.
--
To view, visit
Dan Hecht has posted comments on this change.
Change subject: IMPALA-5160: adjust spill buffer size based on planner estimates
..
Patch Set 6:
> I think it might be best, if possible, to agree on the planner
> mechanism first
Dan Hecht has posted comments on this change.
Change subject: IMPALA-5350: Tidy up thread groups for finst exec threads
..
Patch Set 2:
(1 comment)
Dan Hecht has posted comments on this change.
Change subject: IMPALA-5419: Check for cancellation when building hash tables
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/7047
To unsubscribe,
Dan Hecht has posted comments on this change.
Change subject: IMPALA-5377: Impala may crash if given a fragment instance
while restarting
..
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/7036
Dan Hecht has posted comments on this change.
Change subject: IMPALA-5386: Fix ReopenCachedHdfsFileHandle failure case
..
Patch Set 2:
See IMPALA-5403, which is something we should do in the near term, so it might
be best to
Dan Hecht has posted comments on this change.
Change subject: IMPALA-5386: Fix ReopenCachedHdfsFileHandle failure case
..
Patch Set 2:
> > See IMPALA-5403, which is something we should do in the near
> term,
> > so it might
Dan Hecht has posted comments on this change.
Change subject: IMPALA-5350: Tidy up thread groups for finst exec threads
..
Patch Set 2: Code-Review+2
(2 comments)
Dan Hecht has posted comments on this change.
Change subject: IMPALA-5085: large rows in BufferedTupleStreamV2
..
Patch Set 5:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/6638/5/be/src/runtime/buffered-tuple-stream-v2.cc
Dan Hecht has posted comments on this change.
Change subject: IMPALA-5363: Reset probe_batch_ after reaching limit
..
Patch Set 5: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/7014
To unsubscribe, visit
Dan Hecht has posted comments on this change.
Change subject: IMPALA-4164: Avoid overly aggressive inlining in LLVM IR
..
Patch Set 8: Code-Review+2
(1 comment)
Dan Hecht has posted comments on this change.
Change subject: IMPALA-5031: Remove undefined behavior "reference binding to
null"
..
Patch Set 4:
(1 comment)
Dan Hecht has posted comments on this change.
Change subject: IMPALA-5388: Only retry RPC on lost connection in send call
..
Patch Set 9: Code-Review+1
LGTM but would be good to have Henry and Sailesh sign off they have no
Dan Hecht has posted comments on this change.
Change subject: IMPALA-4965: Authorize access to runtime profile and exec
summary
..
Patch Set 7:
(6 comments)
Dan Hecht has posted comments on this change.
Change subject: IMPALA-5388: Only retry RPC on lost connection in send call
..
Patch Set 9: Code-Review+2
+2 after addressing Henry's comments.
--
To view, visit
Dan Hecht has posted comments on this change.
Change subject: IMPALA-4965: Authorize access to runtime profile and exec
summary
..
Patch Set 7:
(1 comment)
Dan Hecht has posted comments on this change.
Change subject: IMPALA-4988: Add query option read_parquet_statistics
..
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/7001
To unsubscribe, visit
Dan Hecht has posted comments on this change.
Change subject: IMPALA-5386: Fix ReopenCachedHdfsFileHandle failure case
..
Patch Set 2:
> > Did you look into the conditions which triggered the failure to
> > begin with ? Is
Dan Hecht has posted comments on this change.
Change subject: IMPALA-5315 Cast to timestamp fails for -M-D format
..
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7009/3/be/src/exprs/expr-test.cc
File
Dan Hecht has posted comments on this change.
Change subject: IMPALA-5315 Cast to timestamp fails for -M-D format
..
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7009/3/be/src/exprs/expr-test.cc
File
Dan Hecht has posted comments on this change.
Change subject: IMPALA-5031: Remove undefined behavior "reference binding to
null"
..
Patch Set 4:
(1 comment)
Dan Hecht has posted comments on this change.
Change subject: IMPALA-5388: Only retry RPC on lost connection in send call
..
Patch Set 4:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/7063/4/be/src/rpc/thrift-util.cc
File
Dan Hecht has posted comments on this change.
Change subject: IMPALA-1575: Yield admission control resources at query end
..
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/7079/1/be/src/runtime/coordinator.cc
Dan Hecht has posted comments on this change.
Change subject: IMPALA-5061: Populate null_count in parquet::statistics
..
Patch Set 8:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/7058/8/be/src/exec/parquet-column-stats.h
601 - 700 of 1021 matches
Mail list logo
