[kudu-CR] [web-ui] KUDU-1619 Separate tables for live and dead tservers on /tablet-servers

2016-09-22 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. Change subject: [web-ui] KUDU-1619 Separate tables for live and dead tservers on /tablet-servers .. [web-ui] KUDU-1619 Separate tables for live and dead tservers on /ta

[kudu-CR] [web-ui] KUDU-1619 Separate tables for live and dead tservers on /tablet-servers

2016-09-22 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [web-ui] KUDU-1619 Separate tables for live and dead tservers on /tablet-servers .. Patch Set 12: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/

[kudu-CR] [web-ui] KUDU-1619 Separate tables for live and dead tservers on /tablet-servers

2016-09-22 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [web-ui] KUDU-1619 Separate tables for live and dead tservers on /tablet-servers .. Patch Set 12: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:80

[kudu-CR] WIP: [tools] added insert-generated-rows into kudu tools

2016-09-22 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4412 to look at the new patch set (#10). Change subject: WIP: [tools] added insert-generated-rows into kudu tools .. WIP

[kudu-CR] [web-ui] KUDU-1619 Separate tables for live and dead tservers on /tablet-servers

2016-09-22 Thread Ninad Shringarpure (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4450 to look at the new patch set (#12). Change subject: [web-ui] KUDU-1619 Separate tables for live and dead tservers on /tablet-servers ..

[kudu-CR] [web-ui] KUDU-1619 Separate tables for live and dead tservers on /tablet-servers

2016-09-22 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [web-ui] KUDU-1619 Separate tables for live and dead tservers on /tablet-servers .. Patch Set 11: (1 comment) oops, missed one extra nit in previous reviews.

[kudu-CR] KUDU-1637 - [python] Add Support for < and > Predicates

2016-09-22 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-1637 - [python] Add Support for < and > Predicates .. Patch Set 1: Looks fine. Did you leave some test coverage with '<=' as well? -- To view, visit http://

[kudu-CR] [web-ui] KUDU-1619 Separate tables for live and dead tservers on /tablet-servers

2016-09-22 Thread Ninad Shringarpure (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4450 to look at the new patch set (#11). Change subject: [web-ui] KUDU-1619 Separate tables for live and dead tservers on /tablet-servers ..

[kudu-CR] [web-ui] KUDU-1619 Separate tables for live and dead tservers on /tablet-servers

2016-09-22 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [web-ui] KUDU-1619 Separate tables for live and dead tservers on /tablet-servers .. Patch Set 10: (2 comments) Almost there, just 2 style nits are left. http:

[kudu-CR] [doc] KUDU-1630 impala tables.html link is showing as text and not actual link

2016-09-22 Thread Ninad Shringarpure (Code Review)
Hello Dan Burkert, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4483 to look at the new patch set (#4). Change subject: [doc] KUDU-1630 impala_tables.html link is showing as text and not actual link ..

[kudu-CR] [doc] KUDU-1630 impala tables.html link is showing as text and not actual link

2016-09-22 Thread Ninad Shringarpure (Code Review)
Hello Dan Burkert, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4483 to look at the new patch set (#3). Change subject: [doc] KUDU-1630 impala_tables.html link is showing as text and not actual link ..

[kudu-CR] thirdparty: fix up libtool scripts if needed

2016-09-22 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: thirdparty: fix up libtool scripts if needed .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/4512/1//COMMIT_MSG Commit Message: Line 14: and the

[kudu-CR] [web-ui] KUDU-1619 Separate tables for live and dead tservers on /tablet-servers

2016-09-22 Thread Ninad Shringarpure (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4450 to look at the new patch set (#10). Change subject: [web-ui] KUDU-1619 Separate tables for live and dead tservers on /tablet-servers ..

[kudu-CR] c++ client: stop requiring the old gcc ABI

2016-09-22 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: c++ client: stop requiring the old gcc ABI .. Patch Set 1: (4 comments) > Do you think it's worth adding -Wabi option into the clang options > to emit warnings in

[kudu-CR] KUDU-1612 - [python] Enable setting of read mode for scanning

2016-09-22 Thread Jordan Birdsell (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4520 to look at the new patch set (#2). Change subject: KUDU-1612 - [python] Enable setting of read mode for scanning ..

[kudu-CR] KUDU-1637 - [python] Add Support for < and > Predicates

2016-09-22 Thread Jordan Birdsell (Code Review)
Jordan Birdsell has uploaded a new change for review. http://gerrit.cloudera.org:8080/4524 Change subject: KUDU-1637 - [python] Add Support for < and > Predicates .. KUDU-1637 - [python] Add Support for < and > Predicates Cur

[kudu-CR] [util] minor clean-up on kudu::Subprocess

2016-09-22 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: [util] minor clean-up on kudu::Subprocess .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4502/1/src/kudu/util/subprocess.cc File src/kudu/util/sub

[kudu-CR] KUDU-1363: Add IN-list predicate type

2016-09-22 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-1363: Add IN-list predicate type .. Patch Set 9: (2 comments) http://gerrit.cloudera.org:8080/#/c/2986/7/src/kudu/client/scan_predicate-internal.h File src/ku

[kudu-CR] [WIP][java] KUDU-1563. Add support for INSERT IGNORE

2016-09-22 Thread Brock Noland (Code Review)
Brock Noland has uploaded a new patch set (#2). Change subject: [WIP][java] KUDU-1563. Add support for INSERT IGNORE .. [WIP][java] KUDU-1563. Add support for INSERT IGNORE Implements java support for the `INSERT IGNORE' operati

[kudu-CR] [WIP][java] KUDU-1563. Add support for INSERT IGNORE

2016-09-22 Thread Brock Noland (Code Review)
Brock Noland has uploaded a new change for review. http://gerrit.cloudera.org:8080/4523 Change subject: [WIP][java] KUDU-1563. Add support for INSERT IGNORE .. [WIP][java] KUDU-1563. Add support for INSERT IGNORE Implements j

[kudu-CR] [WIP][python] KUDU-1563. Add support for INSERT IGNORE

2016-09-22 Thread Brock Noland (Code Review)
Brock Noland has uploaded a new change for review. http://gerrit.cloudera.org:8080/4522 Change subject: [WIP][python] KUDU-1563. Add support for INSERT IGNORE .. [WIP][python] KUDU-1563. Add support for INSERT IGNORE Implemen

[kudu-CR] [WIP] KUDU-1563. Add support for INSERT IGNORE

2016-09-22 Thread Brock Noland (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4491 to look at the new patch set (#3). Change subject: [WIP] KUDU-1563. Add support for INSERT IGNORE .. [WIP] KUDU-156

[kudu-CR] [WIP] KUDU-1563. Add support for INSERT IGNORE

2016-09-22 Thread Brock Noland (Code Review)
Brock Noland has posted comments on this change. Change subject: [WIP] KUDU-1563. Add support for INSERT IGNORE .. Patch Set 2: (1 comment) I am going to push a new series of patches. Still a WIP though. http://gerrit.clouder

[kudu-CR] KUDU-1363: Add IN-list predicate type

2016-09-22 Thread Dan Burkert (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/2986 to look at the new patch set (#9). Change subject: KUDU-1363: Add IN-list predicate type .. KUDU-1363: Add IN-list

[kudu-CR] KUDU-1612 - [python] Enable setting of read mode for scanning

2016-09-22 Thread Jordan Birdsell (Code Review)
Jordan Birdsell has uploaded a new change for review. http://gerrit.cloudera.org:8080/4520 Change subject: KUDU-1612 - [python] Enable setting of read mode for scanning .. KUDU-1612 - [python] Enable setting of read mode for s

[kudu-CR] thirdparty: split into dependency groups

2016-09-22 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: thirdparty: split into dependency groups .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4513/1/thirdparty/build-if-necessary.sh File thirdparty

[kudu-CR] [misc] : Remove few more warnings

2016-09-22 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: [misc] : Remove few more warnings .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4518 To unsubscribe, visit http://gerrit.cloudera

[kudu-CR] [misc] : Remove few more warnings

2016-09-22 Thread Dinesh Bhat (Code Review)
Dinesh Bhat has posted comments on this change. Change subject: [misc] : Remove few more warnings .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/4518/1/src/kudu/benchmarks/rle.cc File src/kudu/benchmarks/rle.c

[kudu-CR] [misc] : Remove few more warnings

2016-09-22 Thread Dinesh Bhat (Code Review)
Hello Dan Burkert, Adar Dembo, Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4518 to look at the new patch set (#2). Change subject: [misc] : Remove few more warnings ...

[kudu-CR] [util] minor clean-up on kudu::Subprocess

2016-09-22 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [util] minor clean-up on kudu::Subprocess .. Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/4502/1/src/kudu/util/subprocess.cc File src/kudu/util

[kudu-CR] [c++client/samples] added README for the sample

2016-09-22 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4517 to look at the new patch set (#2). Change subject: [c++client/samples] added README for the sample .. [c++client/sa

[kudu-CR] [c++client/samples] added README for the sample

2016-09-22 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [c++client/samples] added README for the sample .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4517/1/src/kudu/client/samples/README.adoc File

[kudu-CR] [misc] : Remove few more warnings

2016-09-22 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: [misc] : Remove few more warnings .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4518/1/src/kudu/benchmarks/rle.cc File src/kudu/benchmarks/rle.cc

[kudu-CR] [misc] : Remove few more warnings

2016-09-22 Thread Dinesh Bhat (Code Review)
Dinesh Bhat has posted comments on this change. Change subject: [misc] : Remove few more warnings .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4518/1/src/kudu/benchmarks/rle.cc File src/kudu/benchmarks/rle.c

[kudu-CR] [misc] : Remove few more warnings

2016-09-22 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: [misc] : Remove few more warnings .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4518/1/src/kudu/benchmarks/rle.cc File src/kudu/benchmarks/rle.cc

[kudu-CR] [c++client/samples] added README for the sample

2016-09-22 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [c++client/samples] added README for the sample .. Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/4517/1/src/kudu/client/samples/README.adoc File

[kudu-CR] [misc] : Remove few more warnings

2016-09-22 Thread Dinesh Bhat (Code Review)
Hello Dan Burkert, Adar Dembo, Alexey Serbin, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/4518 to review the following change. Change subject: [misc] : Remove few more warnings .. [misc]

[kudu-CR] [web-ui] KUDU-1619 Separate tables for live and dead tservers on /tablet-servers

2016-09-22 Thread Ninad Shringarpure (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4450 to look at the new patch set (#9). Change subject: [web-ui] KUDU-1619 Separate tables for live and dead tservers on /tablet-servers ...

[kudu-CR] c++ client: stop requiring the old gcc ABI

2016-09-22 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: c++ client: stop requiring the old gcc ABI .. Patch Set 1: Do you think it's worth adding -Wabi warning flag into the clang options to catch possible ABI incomp

[kudu-CR] [web-ui] KUDU-1619 Separate tables for live and dead tservers on /tablet-servers

2016-09-22 Thread Ninad Shringarpure (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4450 to look at the new patch set (#8). Change subject: [web-ui] KUDU-1619 Separate tables for live and dead tservers on /tablet-servers ...

[kudu-CR] [web-ui] KUDU-1619 Separate tables for live and dead tservers on /tablet-servers

2016-09-22 Thread Ninad Shringarpure (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4450 to look at the new patch set (#7). Change subject: [web-ui] KUDU-1619 Separate tables for live and dead tservers on /tablet-servers ...

[kudu-CR] WIP: consensus: refactor tracking of received OpIds out of ReplicaState

2016-09-22 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: WIP: consensus: refactor tracking of received OpIds out of ReplicaState .. Patch Set 1: Would appreciate a review on this general direction before taking the time

[kudu-CR] c++ client: stop requiring the old gcc ABI

2016-09-22 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: c++ client: stop requiring the old gcc ABI .. Patch Set 1: (1 comment) > Uploaded patch set 1. Do you think it's worth adding -Wabi option into the clang optio

[kudu-CR] WIP: KUDU-1567. Decouple hard-minimum WAL segment retention from target

2016-09-22 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: WIP: KUDU-1567. Decouple hard-minimum WAL segment retention from target .. Patch Set 4: would appreciate some comments if people agree with this direction before

[kudu-CR] thirdparty: fix up libtool scripts if needed

2016-09-22 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: thirdparty: fix up libtool scripts if needed .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/4512/1//COMMIT_MSG Commit Message: Line 14: and the

[kudu-CR] [web-ui] KUDU-1619 Separate tables for live and dead tservers on /tablet-servers

2016-09-22 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [web-ui] KUDU-1619 Separate tables for live and dead tservers on /tablet-servers .. Patch Set 6: (3 comments) http://gerrit.cloudera.org:8080/#/c/4450/6/src/ku

[kudu-CR] [c++client/samples] added README for the sample

2016-09-22 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: [c++client/samples] added README for the sample .. Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/4517/1/src/kudu/client/samples/README.adoc File s

[kudu-CR] [c++client/samples] added README for the sample

2016-09-22 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [c++client/samples] added README for the sample .. Patch Set 1: Verified+1 The build failure is not relevant to this patch. -- To view, visit http://gerrit.clo

[kudu-CR] [WIP] KUDU-1563. Add support for INSERT IGNORE

2016-09-22 Thread Brock Noland (Code Review)
Brock Noland has posted comments on this change. Change subject: [WIP] KUDU-1563. Add support for INSERT IGNORE .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/4491/2/src/kudu/tablet/tablet.cc File src/kudu/ta

[kudu-CR] [web-ui] KUDU-1619 Separate tables for live and dead tservers on /tablet-servers

2016-09-22 Thread Ninad Shringarpure (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4450 to look at the new patch set (#6). Change subject: [web-ui] KUDU-1619 Separate tables for live and dead tservers on /tablet-servers ...

[kudu-CR] thirdparty: upgrade LLVM to 3.9.0

2016-09-22 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: thirdparty: upgrade LLVM to 3.9.0 .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4507/1/thirdparty/vars.sh File thirdparty/vars.sh: Line 115: # 3

[kudu-CR] [c++client/samples] added README for the sample

2016-09-22 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded a new change for review. http://gerrit.cloudera.org:8080/4517 Change subject: [c++client/samples] added README for the sample .. [c++client/samples] added README for the sample Added README in Ascii

[kudu-CR] [c++compilation] fixed 'unused' warnings

2016-09-22 Thread Dinesh Bhat (Code Review)
Dinesh Bhat has posted comments on this change. Change subject: [c++compilation] fixed 'unused' warnings .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/4503/1/src/kudu/codegen/row_projector.cc File src/kudu/co

[kudu-CR] [doc] KUDU-1627 Potentially Missing words in the quick start doc

2016-09-22 Thread Dan Burkert (Code Review)
Dan Burkert has submitted this change and it was merged. Change subject: [doc] KUDU-1627 Potentially Missing words in the quick start doc .. [doc] KUDU-1627 Potentially Missing words in the quick start doc Asciidoc was consider

[kudu-CR] [doc] KUDU-1627 Potentially Missing words in the quick start doc

2016-09-22 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: [doc] KUDU-1627 Potentially Missing words in the quick start doc .. Patch Set 3: Code-Review+2 Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/4480 T

[kudu-CR] thirdparty: fix up libtool scripts if needed

2016-09-22 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: thirdparty: fix up libtool scripts if needed .. Patch Set 1: Code-Review+1 Yikes. +1 in case Todd has any better ideas. -- To view, visit http://gerrit.cloudera

[kudu-CR] thirdparty: use libc++ instead libstdc++ for TSAN builds

2016-09-22 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: thirdparty: use libc++ instead libstdc++ for TSAN builds .. Patch Set 1: (5 comments) http://gerrit.cloudera.org:8080/#/c/4511/1//COMMIT_MSG Commit Message: PS1,

[kudu-CR] thirdparty: split into dependency groups

2016-09-22 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: thirdparty: split into dependency groups .. Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/4513/1//COMMIT_MSG Commit Message: Line 29: "instrument

[kudu-CR] [doc] KUDU-1627 Potentially Missing words in the quick start doc

2016-09-22 Thread Ninad Shringarpure (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4480 to look at the new patch set (#3). Change subject: [doc] KUDU-1627 Potentially Missing words in the quick start doc

[kudu-CR] [doc] KUDU-1630 impala tables.html link is showing as text and not actual link

2016-09-22 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: [doc] KUDU-1630 impala_tables.html link is showing as text and not actual link .. Patch Set 2: -Code-Review Verified+1 -- To view, visit http://gerrit.cloudera.o

[kudu-CR] c++ client: stop requiring the old gcc ABI

2016-09-22 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: c++ client: stop requiring the old gcc ABI .. Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/4515/1//COMMIT_MSG Commit Message: PS1, Line 12: The

[kudu-CR] [doc] KUDU-1630 impala tables.html link is showing as text and not actual link

2016-09-22 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: [doc] KUDU-1630 impala_tables.html link is showing as text and not actual link .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/4483/2/docs/kudu_i

[kudu-CR] [doc] KUDU-1630 impala tables.html link is showing as text and not actual link

2016-09-22 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: [doc] KUDU-1630 impala_tables.html link is showing as text and not actual link .. Patch Set 2: Code-Review+1 CI is having a rough time with recent build changes.

[kudu-CR] thirdparty: stifle unused argument warnings when building with clang

2016-09-22 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: thirdparty: stifle unused argument warnings when building with clang .. Patch Set 1: Code-Review+2 looks good, although the build failure may be legit. -- To vi

[kudu-CR] thirdparty: upgrade cmake to 3.6.1

2016-09-22 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: thirdparty: upgrade cmake to 3.6.1 .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4506 To unsubscribe, visit http://gerrit.cloude

[kudu-CR] thirdparty: patch glog to omit tests from build

2016-09-22 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: thirdparty: patch glog to omit tests from build .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4508 To unsubscribe, visit http://

[kudu-CR] tsan-suppressions: suppress various glog/gflags data races

2016-09-22 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: tsan-suppressions: suppress various glog/gflags data races .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4509 To unsubscribe, vi

[kudu-CR] c++ client: adjust kudu::client::sp

2016-09-22 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: c++ client: adjust kudu::client::sp .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4510 To unsubscribe, visit http://gerrit.cloud

[kudu-CR] [WIP] KUDU-1563. Add support for INSERT IGNORE

2016-09-22 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: [WIP] KUDU-1563. Add support for INSERT IGNORE .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/4491/2/java/kudu-client/src/main/java/org/ap

[kudu-CR] [doc] KUDU-1630 impala tables.html link is showing as text and not actual link

2016-09-22 Thread Ninad Shringarpure (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4483 to look at the new patch set (#2). Change subject: [doc] KUDU-1630 impala_tables.html link is showing as text and not actual link .

[kudu-CR] Document Impala and Spark integration known issues & limitations

2016-09-22 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: Document Impala and Spark integration known issues & limitations .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/4443/3/docs/developing.ado

[kudu-CR] [website] broken link to an adoc

2016-09-22 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has submitted this change and it was merged. Change subject: [website] broken link to an adoc .. [website] broken link to an adoc Change-Id: I8fe88073807eceb8927d6ca7ddf109bd0a9fd9d3 Reviewed-on: http://gerri

[kudu-CR] KUDU-1614 - [python] Enable Set/Get of unixtime micros

2016-09-22 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-1614 - [python] Enable Set/Get of unixtime_micros .. Patch Set 9: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4417 To unsubscribe, visit

[kudu-CR] KUDU-1614 - [python] Enable Set/Get of unixtime micros

2016-09-22 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: KUDU-1614 - [python] Enable Set/Get of unixtime_micros .. KUDU-1614 - [python] Enable Set/Get of unixtime_micros Currently, the python client in Kudu does

[kudu-CR] KUDU-1614 - [python] Enable Set/Get of unixtime micros

2016-09-22 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-1614 - [python] Enable Set/Get of unixtime_micros .. Patch Set 8: (1 comment) http://gerrit.cloudera.org:8080/#/c/4417/8/python/kudu/client.pyx File python/k

[kudu-CR] [doc] KUDU-1630 impala tables.html link is showing as text and not actual link

2016-09-22 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: [doc] KUDU-1630 impala_tables.html link is showing as text and not actual link .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4483/1/docs/kudu_i

[kudu-CR] [doc] KUDU-1627 Potentially Missing words in the quick start doc

2016-09-22 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: [doc] KUDU-1627 Potentially Missing words in the quick start doc .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/4480/2//COMMIT_MSG Commit Message

[kudu-CR] c++ client: adjust kudu::client::sp

2016-09-22 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: c++ client: adjust kudu::client::sp .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4510 To unsubscribe, visit http://gerrit.cloud

[kudu-CR] tsan-suppressions: suppress various glog/gflags data races

2016-09-22 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: tsan-suppressions: suppress various glog/gflags data races .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4509 To unsubscribe, vi

[kudu-CR] thirdparty: patch glog to omit tests from build

2016-09-22 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: thirdparty: patch glog to omit tests from build .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4508 To unsubscribe, visit http://

[kudu-CR] thirdparty: upgrade LLVM to 3.9.0

2016-09-22 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: thirdparty: upgrade LLVM to 3.9.0 .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4507/1/thirdparty/vars.sh File thirdparty/vars.sh: Line 115: #

[kudu-CR] ensure every gflag is defined outside of a namespace

2016-09-22 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: ensure every gflag is defined outside of a namespace .. Patch Set 1: Code-Review+2 (1 comment) lgtm, not sure what the jenkins failure's about http://gerrit.clou

[kudu-CR] thirdparty: upgrade cmake to 3.6.1

2016-09-22 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: thirdparty: upgrade cmake to 3.6.1 .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4506 To unsubscribe, visit http://gerrit.cloude