[kudu-CR] client: micro-optimizations to reduce CPU and allocations

2020-03-19 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15439 ) Change subject: client: micro-optimizations to reduce CPU and allocations .. client: micro-optimizations to reduce CPU and

[kudu-CR] client: micro-optimizations to reduce CPU and allocations

2020-03-19 Thread Todd Lipcon (Code Review)
Todd Lipcon has removed a vote on this change. Change subject: client: micro-optimizations to reduce CPU and allocations .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/15439 To

[kudu-CR] client: micro-optimizations to reduce CPU and allocations

2020-03-19 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/15439 ) Change subject: client: micro-optimizations to reduce CPU and allocations .. Patch Set 4: Verified+1 Test failures seem unrelated (two

[kudu-CR] client: micro-optimize result batch cell getters by outlining cold path

2020-03-19 Thread Todd Lipcon (Code Review)
Hello Tidy Bot, Alexey Serbin, Andrew Wong, Kudu Jenkins, Andrew Wong, Adar Dembo, Bankim Bhavsar, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15503 to look at the new patch set (#2). Change subject: client: micro-optimize result batch cell getters by

[kudu-CR] [ranger] fix incorrect authz enforcement in Ranger authz provider

2020-03-19 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15436 ) Change subject: [ranger] fix incorrect authz enforcement in Ranger authz provider .. Patch Set 8: (2 comments) I presume you tested

[kudu-CR] [ranger] fix incorrect authz enforcement in Ranger authz provider

2020-03-19 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15436 ) Change subject: [ranger] fix incorrect authz enforcement in Ranger authz provider .. Patch Set 8: Code-Review+2 -- To view, visit

[kudu-CR] tablet: plumb delta stats into delta compaction outputs

2020-03-19 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15506 ) Change subject: tablet: plumb delta stats into delta compaction outputs .. Patch Set 3: (1 comment)

[kudu-CR] tell IWYU to keep all inclusions of kudu/client/shared ptr.h

2020-03-19 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15490 ) Change subject: tell IWYU to keep all inclusions of kudu/client/shared_ptr.h .. Patch Set 2: Verified+1 Overriding Jenkins, dist-test

[kudu-CR] tell IWYU to keep all inclusions of kudu/client/shared ptr.h

2020-03-19 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15490 ) Change subject: tell IWYU to keep all inclusions of kudu/client/shared_ptr.h .. tell IWYU to keep all inclusions of

[kudu-CR] tell IWYU to keep all inclusions of kudu/client/shared ptr.h

2020-03-19 Thread Adar Dembo (Code Review)
Adar Dembo has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/15490 ) Change subject: tell IWYU to keep all inclusions of kudu/client/shared_ptr.h .. Removed reviewer Kudu Jenkins with the following

[kudu-CR] tserver: avoid spinlock in scanners hot path

2020-03-19 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/15502 ) Change subject: tserver: avoid spinlock in scanners hot path .. Patch Set 2: (1 comment)

[kudu-CR] tserver: avoid spinlock in scanners hot path

2020-03-19 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15502 ) Change subject: tserver: avoid spinlock in scanners hot path .. Patch Set 2: Code-Review+2 -- To view, visit

[kudu-CR] tserver: avoid spinlock in scanners hot path

2020-03-19 Thread Todd Lipcon (Code Review)
Hello Andrew Wong, Kudu Jenkins, Andrew Wong, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15502 to look at the new patch set (#2). Change subject: tserver: avoid spinlock in scanners hot path

[kudu-CR] client: avoid an extra construction of ColumnSchema

2020-03-19 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15501 ) Change subject: client: avoid an extra construction of ColumnSchema .. client: avoid an extra construction of ColumnSchema

[kudu-CR] client: avoid an extra construction of ColumnSchema

2020-03-19 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/15501 ) Change subject: client: avoid an extra construction of ColumnSchema .. Patch Set 1: Verified+1 I'm skipping the IWYU fix here since I

[kudu-CR] client: avoid an extra construction of ColumnSchema

2020-03-19 Thread Todd Lipcon (Code Review)
Todd Lipcon has removed a vote on this change. Change subject: client: avoid an extra construction of ColumnSchema .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/15501 To

[kudu-CR] rpc: use a lighter weight completion for sync RPCs

2020-03-19 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15441 ) Change subject: rpc: use a lighter weight completion for sync RPCs .. rpc: use a lighter weight completion for sync RPCs This

[kudu-CR] KUDU-3079 Add MiniPostgres

2020-03-19 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15374 ) Change subject: KUDU-3079 Add MiniPostgres .. Patch Set 11: (2 comments)

[kudu-CR] KUDU-3079 Add MiniPostgres

2020-03-19 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/15374 ) Change subject: KUDU-3079 Add MiniPostgres .. Patch Set 11: (4 comments)

[kudu-CR] [thirdparty] python3 is good for building LLVM

2020-03-19 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15504 ) Change subject: [thirdparty] python3 is good for building LLVM .. Patch Set 6: Code-Review+2 -- To view, visit

[kudu-CR] tablet: plumb delta stats into delta compaction outputs

2020-03-19 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15506 ) Change subject: tablet: plumb delta stats into delta compaction outputs .. Patch Set 3: (5 comments)

[kudu-CR] tablet: cache delta stats when flushing a DMS

2020-03-19 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15460 ) Change subject: tablet: cache delta stats when flushing a DMS .. Patch Set 4: Code-Review+2 -- To view, visit

[kudu-CR] KUDU-1625: background op to GC ancient, fully deleted rowsets

2020-03-19 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15145 ) Change subject: KUDU-1625: background op to GC ancient, fully deleted rowsets .. Patch Set 7: (8 comments)

[kudu-CR] client: avoid an extra construction of ColumnSchema

2020-03-19 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15501 ) Change subject: client: avoid an extra construction of ColumnSchema .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] [thirdparty] python3 is good for building LLVM

2020-03-19 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, Adar Dembo, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15504 to look at the new patch set (#6). Change subject: [thirdparty] python3 is good for building LLVM

[kudu-CR] [thirdparty] python3 is good for building LLVM

2020-03-19 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15504 ) Change subject: [thirdparty] python3 is good for building LLVM .. Patch Set 5: (1 comment)

[kudu-CR] client: micro-optimize getters by outlining cold path

2020-03-19 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15503 ) Change subject: client: micro-optimize getters by outlining cold path .. Patch Set 1: Code-Review+2 (1 comment)

[kudu-CR] client: micro-optimizations to reduce CPU and allocations

2020-03-19 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15439 ) Change subject: client: micro-optimizations to reduce CPU and allocations .. Patch Set 4: Code-Review+2 -- To view, visit

[kudu-CR] [ranger] fix incorrect authz enforcement in Ranger authz provider

2020-03-19 Thread Hao Hao (Code Review)
Hello Tidy Bot, Attila Bukor, Kudu Jenkins, Andrew Wong, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15436 to look at the new patch set (#8). Change subject: [ranger] fix incorrect authz enforcement in Ranger authz provider

[kudu-CR] [ranger] fix incorrect authz enforcement in Ranger authz provider

2020-03-19 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/15436 ) Change subject: [ranger] fix incorrect authz enforcement in Ranger authz provider .. Patch Set 8: (1 comment)

[kudu-CR] [thirdparty] python3 is good for building LLVM

2020-03-19 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15504 ) Change subject: [thirdparty] python3 is good for building LLVM .. Patch Set 5: (1 comment)

[kudu-CR] client: micro-optimize getters by outlining cold path

2020-03-19 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15503 ) Change subject: client: micro-optimize getters by outlining cold path .. Patch Set 1: Code-Review+2 (1 comment)

[kudu-CR] tserver: avoid spinlock in scanners hot path

2020-03-19 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15502 ) Change subject: tserver: avoid spinlock in scanners hot path .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] client: avoid an extra construction of ColumnSchema

2020-03-19 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15501 ) Change subject: client: avoid an extra construction of ColumnSchema .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] rpc: use a lighter weight completion for sync RPCs

2020-03-19 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15441 ) Change subject: rpc: use a lighter weight completion for sync RPCs .. Patch Set 2: Code-Review+2 -- To view, visit

[kudu-CR] client: micro-optimizations to reduce CPU and allocations

2020-03-19 Thread Todd Lipcon (Code Review)
Hello Kudu Jenkins, Andrew Wong, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15439 to look at the new patch set (#4). Change subject: client: micro-optimizations to reduce CPU and allocations

[kudu-CR] client: micro-optimizations to reduce CPU and allocations

2020-03-19 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/15439 ) Change subject: client: micro-optimizations to reduce CPU and allocations .. Patch Set 3: (2 comments)

[kudu-CR] rpc: reduce context switches and receive calls

2020-03-19 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15440 ) Change subject: rpc: reduce context switches and receive calls .. rpc: reduce context switches and receive calls * When

[kudu-CR] client: micro-optimizations to reduce CPU and allocations

2020-03-19 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15439 ) Change subject: client: micro-optimizations to reduce CPU and allocations .. Patch Set 3: Nothing to add to Andrew's comments. -- To

[kudu-CR] tablet: plumb delta stats into delta compaction outputs

2020-03-19 Thread Andrew Wong (Code Review)
Hello Tidy Bot, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15506 to look at the new patch set (#3). Change subject: tablet: plumb delta stats into delta compaction outputs

[kudu-CR] KUDU-1625: background op to GC ancient, fully deleted rowsets

2020-03-19 Thread Andrew Wong (Code Review)
Hello Tidy Bot, Alexey Serbin, Attila Bukor, Kudu Jenkins, Adar Dembo, Volodymyr Verovkin, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15145 to look at the new patch set (#7). Change subject: KUDU-1625: background op to GC ancient, fully deleted

[kudu-CR] [thirdparty] python3 is good for building LLVM

2020-03-19 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15504 ) Change subject: [thirdparty] python3 is good for building LLVM .. Patch Set 5: Verified+1 unrelated failures in isolate: failed to

[kudu-CR] [thirdparty] python3 is good for building LLVM

2020-03-19 Thread Alexey Serbin (Code Review)
Alexey Serbin has removed a vote on this change. Change subject: [thirdparty] python3 is good for building LLVM .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/15504 To unsubscribe,

[kudu-CR] [ranger] fix incorrect authz enforcement in Ranger authz provider

2020-03-19 Thread Hao Hao (Code Review)
Hello Attila Bukor, Kudu Jenkins, Andrew Wong, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15436 to look at the new patch set (#7). Change subject: [ranger] fix incorrect authz enforcement in Ranger authz provider

[kudu-CR] [thirdparty] python3 is good for building LLVM

2020-03-19 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/15504 ) Change subject: [thirdparty] python3 is good for building LLVM .. Patch Set 5: Code-Review+1 -- To view, visit

[kudu-CR] [util] KUDU-3067 add OpenStack metadata detector

2020-03-19 Thread liusheng (Code Review)
liusheng has posted comments on this change. ( http://gerrit.cloudera.org:8080/15488 ) Change subject: [util] KUDU-3067 add OpenStack metadata detector .. Patch Set 2: > > @Alexey Serbin Thanks for address this, LGTM > >

[kudu-CR] client: micro-optimize getters by outlining cold path

2020-03-19 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15503 ) Change subject: client: micro-optimize getters by outlining cold path .. Patch Set 1: Code-Review+1 TIL: Outlining can improve

[kudu-CR] rpc: reduce context switches and receive calls

2020-03-19 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15440 ) Change subject: rpc: reduce context switches and receive calls .. Patch Set 2: Code-Review+1 -- To view, visit

[kudu-CR] client: avoid an extra construction of ColumnSchema

2020-03-19 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15501 ) Change subject: client: avoid an extra construction of ColumnSchema .. Patch Set 1: Code-Review+1 -- To view, visit

[kudu-CR] rpc: use a lighter weight completion for sync RPCs

2020-03-19 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15441 ) Change subject: rpc: use a lighter weight completion for sync RPCs .. Patch Set 2: Code-Review+1 -- To view, visit

[kudu-CR] [thirdparty] python3 is good for building LLVM

2020-03-19 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15504 ) Change subject: [thirdparty] python3 is good for building LLVM .. Patch Set 4: (1 comment)

[kudu-CR] [thirdparty] python3 is good for building LLVM

2020-03-19 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, Adar Dembo, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15504 to look at the new patch set (#5). Change subject: [thirdparty] python3 is good for building LLVM

[kudu-CR] [ranger] fix incorrect authz enforcement in Ranger authz provider

2020-03-19 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/15436 ) Change subject: [ranger] fix incorrect authz enforcement in Ranger authz provider .. Patch Set 6: (1 comment)

[kudu-CR] [java] use KuduTestHarness in TestSecurity

2020-03-19 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15433 ) Change subject: [java] use KuduTestHarness in TestSecurity .. Patch Set 1: (1 comment)

[kudu-CR] [java] use KuduTestHarness in TestSecurity

2020-03-19 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15433 to look at the new patch set (#2). Change subject: [java] use KuduTestHarness in TestSecurity ..

[kudu-CR] [thirdparty] python3 is good for building LLVM

2020-03-19 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/15504 ) Change subject: [thirdparty] python3 is good for building LLVM .. Patch Set 4: Code-Review+1 (1 comment)

[kudu-CR] [thirdparty] python3 is good for building LLVM

2020-03-19 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, Adar Dembo, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15504 to look at the new patch set (#4). Change subject: [thirdparty] python3 is good for building LLVM

[kudu-CR] [thirdparty] python3 is good for building LLVM

2020-03-19 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15504 ) Change subject: [thirdparty] python3 is good for building LLVM .. Patch Set 3: (2 comments)

[kudu-CR] client: micro-optimize getters by outlining cold path

2020-03-19 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15503 ) Change subject: client: micro-optimize getters by outlining cold path .. Patch Set 1: Code-Review+1 (1 comment)

[kudu-CR] client: avoid an extra construction of ColumnSchema

2020-03-19 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15501 ) Change subject: client: avoid an extra construction of ColumnSchema .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] tablet: cache delta stats when flushing a DMS

2020-03-19 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15460 ) Change subject: tablet: cache delta stats when flushing a DMS .. Patch Set 3: (2 comments)

[kudu-CR] tablet: cache delta stats when flushing a DMS

2020-03-19 Thread Andrew Wong (Code Review)
Hello Tidy Bot, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15460 to look at the new patch set (#3). Change subject: tablet: cache delta stats when flushing a DMS

[kudu-CR] KUDU-1625: background op to GC ancient, fully deleted rowsets

2020-03-19 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15145 ) Change subject: KUDU-1625: background op to GC ancient, fully deleted rowsets .. Patch Set 5: (3 comments)

[kudu-CR] KUDU-1625: background op to GC ancient, fully deleted rowsets

2020-03-19 Thread Andrew Wong (Code Review)
Hello Tidy Bot, Alexey Serbin, Attila Bukor, Kudu Jenkins, Adar Dembo, Volodymyr Verovkin, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15145 to look at the new patch set (#6). Change subject: KUDU-1625: background op to GC ancient, fully deleted

[kudu-CR] [thirdparty] python3 is good for building LLVM

2020-03-19 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/15504 ) Change subject: [thirdparty] python3 is good for building LLVM .. Patch Set 3: (3 comments)

[kudu-CR] KUDU-2780: create thread for auto-rebalancing

2020-03-19 Thread Hannah Nguyen (Code Review)
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Andrew Wong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14177 to look at the new patch set (#26). Change subject: KUDU-2780: create thread for auto-rebalancing

[kudu-CR] KUDU-2780: create thread for auto-rebalancing

2020-03-19 Thread Hannah Nguyen (Code Review)
Hannah Nguyen has posted comments on this change. ( http://gerrit.cloudera.org:8080/14177 ) Change subject: KUDU-2780: create thread for auto-rebalancing .. Patch Set 25: (10 comments)

[kudu-CR] [ranger] fix incorrect authz enforcement in Ranger authz provider

2020-03-19 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15436 ) Change subject: [ranger] fix incorrect authz enforcement in Ranger authz provider .. Patch Set 6: (1 comment)

[kudu-CR] client: micro-optimizations to reduce CPU and allocations

2020-03-19 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15439 ) Change subject: client: micro-optimizations to reduce CPU and allocations .. Patch Set 3: Code-Review+2 (2 comments)

[kudu-CR] [ranger] fix incorrect authz enforcement in Ranger authz provider

2020-03-19 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/15436 ) Change subject: [ranger] fix incorrect authz enforcement in Ranger authz provider .. Patch Set 6: (1 comment)

[kudu-CR] [thirdparty] python3 is good for building LLVM

2020-03-19 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15504 to look at the new patch set (#3). Change subject: [thirdparty] python3 is good for building LLVM ..

[kudu-CR] [ranger] fix incorrect authz enforcement in Ranger authz provider

2020-03-19 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15436 ) Change subject: [ranger] fix incorrect authz enforcement in Ranger authz provider .. Patch Set 6: (1 comment)

[kudu-CR] [ranger] fix incorrect authz enforcement in Ranger authz provider

2020-03-19 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/15436 ) Change subject: [ranger] fix incorrect authz enforcement in Ranger authz provider .. Patch Set 6: (1 comment)

[kudu-CR] [thirdparty] python3 is good for building LLVM

2020-03-19 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15504 to look at the new patch set (#2). Change subject: [thirdparty] python3 is good for building LLVM ..

[kudu-CR] [ranger] fix incorrect authz enforcement in Ranger authz provider

2020-03-19 Thread Hao Hao (Code Review)
Hello Attila Bukor, Kudu Jenkins, Andrew Wong, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15436 to look at the new patch set (#6). Change subject: [ranger] fix incorrect authz enforcement in Ranger authz provider

[kudu-CR] rpc: reduce context switches and receive calls

2020-03-19 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15440 ) Change subject: rpc: reduce context switches and receive calls .. Patch Set 2: Verified+1 Code-Review+2 One test reported failure

[kudu-CR] rpc: reduce context switches and receive calls

2020-03-19 Thread Andrew Wong (Code Review)
Andrew Wong has removed a vote on this change. Change subject: rpc: reduce context switches and receive calls .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/15440 To unsubscribe,

[kudu-CR] [ranger] fix incorrect authz enforcement in Ranger authz provider

2020-03-19 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15436 ) Change subject: [ranger] fix incorrect authz enforcement in Ranger authz provider .. Patch Set 5: (2 comments)

[kudu-CR] KUDU-1625: background op to GC ancient, fully deleted rowsets

2020-03-19 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15145 ) Change subject: KUDU-1625: background op to GC ancient, fully deleted rowsets .. Patch Set 5: (31 comments)

[kudu-CR] [ranger] fix incorrect authz enforcement in Ranger authz provider

2020-03-19 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/15436 ) Change subject: [ranger] fix incorrect authz enforcement in Ranger authz provider .. Patch Set 5: (1 comment)

[kudu-CR] KUDU-1625: background op to GC ancient, fully deleted rowsets

2020-03-19 Thread Andrew Wong (Code Review)
Hello Tidy Bot, Alexey Serbin, Attila Bukor, Kudu Jenkins, Adar Dembo, Volodymyr Verovkin, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15145 to look at the new patch set (#5). Change subject: KUDU-1625: background op to GC ancient, fully deleted

[kudu-CR] tablet: plumb delta stats into delta compaction outputs

2020-03-19 Thread Andrew Wong (Code Review)
Andrew Wong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15506 Change subject: tablet: plumb delta stats into delta compaction outputs .. tablet: plumb delta stats into delta compaction outputs This

[kudu-CR] tablet: cache delta stats when flushing a DMS

2020-03-19 Thread Andrew Wong (Code Review)
Hello Tidy Bot, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15460 to look at the new patch set (#2). Change subject: tablet: cache delta stats when flushing a DMS

[kudu-CR] [thirdparty] python3 is good for building LLVM

2020-03-19 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15504 Change subject: [thirdparty] python3 is good for building LLVM .. [thirdparty] python3 is good for building LLVM With python2

[kudu-CR] client: micro-optimize getters by outlining cold path

2020-03-19 Thread Todd Lipcon (Code Review)
Hello Andrew Wong, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/15503 to review the following change. Change subject: client: micro-optimize getters by outlining cold path .. client:

[kudu-CR] tserver: avoid spinlock in scanners hot path

2020-03-19 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15502 ) Change subject: tserver: avoid spinlock in scanners hot path .. Patch Set 1: Code-Review+2 (2 comments)

[kudu-CR] [ranger] fix incorrect authz enforcement in Ranger authz provider

2020-03-19 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15436 ) Change subject: [ranger] fix incorrect authz enforcement in Ranger authz provider .. Patch Set 5: (1 comment)

[kudu-CR] tserver: avoid spinlock in scanners hot path

2020-03-19 Thread Todd Lipcon (Code Review)
Hello Andrew Wong, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/15502 to review the following change. Change subject: tserver: avoid spinlock in scanners hot path .. tserver: avoid

[kudu-CR] client: avoid an extra construction of ColumnSchema

2020-03-19 Thread Todd Lipcon (Code Review)
Hello Andrew Wong, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/15501 to review the following change. Change subject: client: avoid an extra construction of ColumnSchema .. client: avoid

[kudu-CR] [ranger] fix incorrect authz enforcement in Ranger authz provider

2020-03-19 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/15436 ) Change subject: [ranger] fix incorrect authz enforcement in Ranger authz provider .. Patch Set 5: (2 comments)

[kudu-CR] rpc: use a lighter weight completion for sync RPCs

2020-03-19 Thread Todd Lipcon (Code Review)
Hello Kudu Jenkins, Adar Dembo, Bankim Bhavsar, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15441 to look at the new patch set (#2). Change subject: rpc: use a lighter weight completion for sync RPCs

[kudu-CR] rpc: use a lighter weight completion for sync RPCs

2020-03-19 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/15441 ) Change subject: rpc: use a lighter weight completion for sync RPCs .. Patch Set 1: (4 comments)

[kudu-CR] rpc: use a lighter weight completion for sync RPCs

2020-03-19 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/15441 ) Change subject: rpc: use a lighter weight completion for sync RPCs .. Patch Set 1: (1 comment)

[kudu-CR] rpc: reduce context switches and receive calls

2020-03-19 Thread Todd Lipcon (Code Review)
Hello Kudu Jenkins, Andrew Wong, Adar Dembo, Bankim Bhavsar, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15440 to look at the new patch set (#2). Change subject: rpc: reduce context switches and receive calls

[kudu-CR] rpc: reduce context switches and receive calls

2020-03-19 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/15440 ) Change subject: rpc: reduce context switches and receive calls .. Patch Set 1: (4 comments) > Patch Set 1: > > (2 comments) > > Would

[kudu-CR] client: micro-optimizations to reduce CPU and allocations

2020-03-19 Thread Todd Lipcon (Code Review)
Hello Kudu Jenkins, Andrew Wong, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15439 to look at the new patch set (#3). Change subject: client: micro-optimizations to reduce CPU and allocations

[kudu-CR] client: micro-optimizations to reduce CPU and allocations

2020-03-19 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/15439 ) Change subject: client: micro-optimizations to reduce CPU and allocations .. Patch Set 2: (1 comment)

[kudu-CR] KUDU-3079 Add MiniPostgres

2020-03-19 Thread Attila Bukor (Code Review)
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/15374 ) Change subject: KUDU-3079 Add MiniPostgres .. Patch Set 11: (7 comments)

[kudu-CR] KUDU-3079 Add MiniRanger

2020-03-19 Thread Attila Bukor (Code Review)
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Andrew Wong, Adar Dembo, Grant Henke, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15483 to look at the new patch set (#11). Change subject: KUDU-3079 Add MiniRanger

[kudu-CR] KUDU-3079 Add MiniPostgres

2020-03-19 Thread Attila Bukor (Code Review)
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Andrew Wong, Adar Dembo, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15374 to look at the new patch set (#11). Change subject: KUDU-3079 Add MiniPostgres

  1   2   >