[kudu-CR] consensus: KUDU-2147. Unknown leader should not be treated as valid UUID

2017-09-20 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: consensus: KUDU-2147. Unknown leader should not be treated as valid UUID .. Patch Set 2: Code-Review+2 Looks good to me but would be good to check in with David/Al

[kudu-CR] KUDU-2149: avoid election stacking by restoring failure monitor semantics

2017-09-20 Thread Adar Dembo (Code Review)
Hello Mike Percy, Todd Lipcon, Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8107 to look at the new patch set (#5). Change subject: KUDU-2149: avoid election stacking by restoring failure monitor semantics ..

[kudu-CR] KUDU-2149: avoid election stacking by restoring failure monitor semantics

2017-09-20 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-2149: avoid election stacking by restoring failure monitor semantics .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/8107/4/src/kudu/consensu

[kudu-CR] KUDU-2149: avoid election stacking by restoring failure monitor semantics

2017-09-20 Thread Adar Dembo (Code Review)
Hello Mike Percy, Todd Lipcon, Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8107 to look at the new patch set (#6). Change subject: KUDU-2149: avoid election stacking by restoring failure monitor semantics ..

[kudu-CR] consensus: KUDU-2147. Unknown leader should not be treated as valid UUID

2017-09-20 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: consensus: KUDU-2147. Unknown leader should not be treated as valid UUID .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/8109 To u

[kudu-CR] consensus: KUDU-2147. Unknown leader should not be treated as valid UUID

2017-09-20 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: consensus: KUDU-2147. Unknown leader should not be treated as valid UUID .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/8109 To u

[kudu-CR] KUDU-2149: avoid election stacking by restoring failure monitor semantics

2017-09-20 Thread Adar Dembo (Code Review)
Hello Mike Percy, Todd Lipcon, Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8107 to look at the new patch set (#7). Change subject: KUDU-2149: avoid election stacking by restoring failure monitor semantics ..

[kudu-CR] KUDU-2149: avoid election stacking by restoring failure monitor semantics

2017-09-20 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-2149: avoid election stacking by restoring failure monitor semantics .. Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/8107/6/src/kudu/consensu

[kudu-CR] thirdparty: fix to protobuf bump

2017-09-20 Thread Adar Dembo (Code Review)
Hello Dan Burkert, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/8115 to review the following change. Change subject: thirdparty: fix to protobuf bump .. thirdparty: fix to protobuf bump

[kudu-CR] KUDU-2055 [part 1]: Coalesce hole punching when deleting groups of blocks

2017-09-20 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-2055 [part 1]: Coalesce hole punching when deleting groups of blocks .. Patch Set 8: (10 comments) http://gerrit.cloudera.org:8080/#/c/7656/8/src/kudu/fs/blo

[kudu-CR] KUDU-2149: avoid election stacking by restoring failure monitor semantics

2017-09-20 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. Change subject: KUDU-2149: avoid election stacking by restoring failure monitor semantics .. KUDU-2149: avoid election stacking by restoring failure monitor semantics Pri

[kudu-CR] periodic: prevent runaway callback loops

2017-09-20 Thread Adar Dembo (Code Review)
Hello Todd Lipcon, Alexey Serbin, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/8116 to review the following change. Change subject: periodic: prevent runaway callback loops .. periodic: p

[kudu-CR] catalog manager: make ScopedTabletInfoCommitter generic

2017-09-20 Thread Adar Dembo (Code Review)
Hello Alexey Serbin, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8089 to look at the new patch set (#7). Change subject: catalog_manager: make ScopedTabletInfoCommitter generic .. cata

[kudu-CR] KUDU-1125: issue one catalog write per tablet report

2017-09-20 Thread Adar Dembo (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8090 to look at the new patch set (#5). Change subject: KUDU-1125: issue one catalog write per tablet report .. KUDU-112

[kudu-CR] KUDU-2055 [part 1]: Coalesce hole punching when deleting groups of blocks

2017-09-21 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/7656 ) Change subject: KUDU-2055 [part 1]: Coalesce hole punching when deleting groups of blocks .. Patch Set 9: (3 comments) http://gerrit.clo

[kudu-CR] Add mustache template for /table

2017-09-22 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/8067 ) Change subject: Add mustache template for /table .. Patch Set 11: (2 comments) http://gerrit.cloudera.org:8080/#/c/8067/11/src/kudu/maste

[kudu-CR] KUDU-2055 [part 2]: Add util to construct sorted disjoint interval list

2017-09-22 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/8041 ) Change subject: KUDU-2055 [part 2]: Add util to construct sorted disjoint interval list .. Patch Set 5: (2 comments) http://gerrit.cloud

[kudu-CR] Fix changes that were left out of KUDU-501 and /table template patches

2017-09-22 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/8125 ) Change subject: Fix changes that were left out of KUDU-501 and /table template patches .. Patch Set 1: Code-Review+2 Looks good. I presum

[kudu-CR] KUDU-2055 [part 2]: Add util to construct sorted disjoint interval list

2017-09-22 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/8041 ) Change subject: KUDU-2055 [part 2]: Add util to construct sorted disjoint interval list .. Patch Set 5: (1 comment) http://gerrit.cloude

[kudu-CR] WIP: Pull StatusOr and related tests from protobuf

2017-09-22 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/8127 ) Change subject: WIP: Pull StatusOr and related tests from protobuf .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/8127/1

[kudu-CR] thirdparty: fix to protobuf bump

2017-09-22 Thread Adar Dembo (Code Review)
Hello Dan Burkert, David Ribeiro Alves, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8115 to look at the new patch set (#2). Change subject: thirdparty: fix to protobuf bump ..

[kudu-CR] thirdparty: fix to protobuf bump

2017-09-22 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/8115 ) Change subject: thirdparty: fix to protobuf bump .. Patch Set 2: > Patch Set 1: > > > Patch Set 1: > > > > |I removed the patch level stuf

[kudu-CR] thirdparty: fix to protobuf bump

2017-09-22 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8115 ) Change subject: thirdparty: fix to protobuf bump .. thirdparty: fix to protobuf bump Commit 57de48d bumped protobuf to 3.4.1 but d

[kudu-CR] Prioritize freeing memory over releasing WAL segments

2017-09-22 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/8128 ) Change subject: Prioritize freeing memory over releasing WAL segments .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/812

[kudu-CR] periodic: prevent runaway callback loops

2017-09-22 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/8116 ) Change subject: periodic: prevent runaway callback loops .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/8116/1/src/kudu

[kudu-CR] periodic: prevent runaway callback loops

2017-09-22 Thread Adar Dembo (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8116 to look at the new patch set (#2). Change subject: periodic: prevent runaway callback loops .

[kudu-CR] periodic: prevent runaway callback loops

2017-09-22 Thread Adar Dembo (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8116 to look at the new patch set (#3). Change subject: periodic: prevent runaway callback loops .

[kudu-CR] Revert "[tests] fix flakiness in catalog manager tsk-itest"

2017-09-22 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/8129 ) Change subject: Revert "[tests] fix flakiness in catalog_manager_tsk-itest" .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit

[kudu-CR] catalog manager: make ScopedTabletInfoCommitter generic

2017-09-22 Thread Adar Dembo (Code Review)
Hello Mike Percy, Alexey Serbin, Dan Burkert, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8089 to look at the new patch set (#8). Change subject: catalog_manager: make ScopedTabletInfoCommitter generic .

[kudu-CR] KUDU-1125: issue one catalog write per tablet report

2017-09-22 Thread Adar Dembo (Code Review)
Hello Mike Percy, Dan Burkert, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8090 to look at the new patch set (#6). Change subject: KUDU-1125: issue one catalog write per tablet report ...

[kudu-CR] catalog manager: make ScopedTabletInfoCommitter generic

2017-09-22 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/8089 ) Change subject: catalog_manager: make ScopedTabletInfoCommitter generic .. Patch Set 7: (5 comments) http://gerrit.cloudera.org:8080/#/c/

[kudu-CR] KUDU-1125: issue one catalog write per tablet report

2017-09-22 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/8090 ) Change subject: KUDU-1125: issue one catalog write per tablet report .. Patch Set 5: (12 comments) http://gerrit.cloudera.org:8080/#/c/80

[kudu-CR] catalog manager: make ScopedTabletInfoCommitter generic

2017-09-22 Thread Adar Dembo (Code Review)
Adar Dembo has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/8089 ) Change subject: catalog_manager: make ScopedTabletInfoCommitter generic .. Removed reviewer Kudu Jenkins with the following votes:

[kudu-CR] catalog manager: make ScopedTabletInfoCommitter generic

2017-09-22 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/8089 ) Change subject: catalog_manager: make ScopedTabletInfoCommitter generic .. Patch Set 8: Verified+1 Overriding Jenkins, the latest run hit

[kudu-CR] KUDU-2055 [part 1]: Add fs::BlockDeletionTransaction API

2017-09-22 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/7656 ) Change subject: KUDU-2055 [part 1]: Add fs::BlockDeletionTransaction API .. Patch Set 11: Code-Review+2 -- To view, visit http://gerrit.c

[kudu-CR] periodic: prevent runaway callback loops

2017-09-22 Thread Adar Dembo (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8116 to look at the new patch set (#4). Change subject: periodic: prevent runaway callback loops .

[kudu-CR] periodic: add one-shot timers

2017-09-22 Thread Adar Dembo (Code Review)
Hello Alexey Serbin, Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/8130 to review the following change. Change subject: periodic: add one-shot timers .. periodic: add one-shot

[kudu-CR] periodic: add one-shot timers

2017-09-22 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/8130 ) Change subject: periodic: add one-shot timers .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/8130/1/src/kudu/rpc/periodi

[kudu-CR] WIP: consensus: disarm failure detector around elections

2017-09-23 Thread Adar Dembo (Code Review)
Hello Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/8134 to review the following change. Change subject: WIP: consensus: disarm failure detector around elections .. WIP: conse

[kudu-CR] periodic: add one-shot timers

2017-09-23 Thread Adar Dembo (Code Review)
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8130 to look at the new patch set (#2). Change subject: periodic: add one-shot timers ..

[kudu-CR] WIP: consensus: disarm failure detector around elections

2017-09-23 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/8134 ) Change subject: WIP: consensus: disarm failure detector around elections .. Patch Set 1: I looped raft_consensus-itest 1000 times in slow

[kudu-CR] catalog manager: make ScopedTabletInfoCommitter generic

2017-09-25 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/8089 ) Change subject: catalog_manager: make ScopedTabletInfoCommitter generic .. Patch Set 8: (2 comments) http://gerrit.cloudera.org:8080/#/c/

[kudu-CR] catalog manager: make ScopedTabletInfoCommitter generic

2017-09-25 Thread Adar Dembo (Code Review)
Hello Mike Percy, Alexey Serbin, Dan Burkert, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8089 to look at the new patch set (#9). Change subject: catalog_manager: make ScopedTabletInfoCommitter generic ...

[kudu-CR] WIP: use C++ ExternalMiniCluster for Java and Python tests

2017-09-26 Thread Adar Dembo (Code Review)
Hello Tidy Bot, Alexey Serbin, Dan Burkert, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7853 to look at the new patch set (#3). Change subject: WIP: use C++ ExternalMiniCluster for Java and Python tests

[kudu-CR] WIP: use C++ ExternalMiniCluster for Java and Python tests

2017-09-26 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/7853 ) Change subject: WIP: use C++ ExternalMiniCluster for Java and Python tests .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/

[kudu-CR] WIP: use C++ ExternalMiniCluster for Java and Python tests

2017-09-26 Thread Adar Dembo (Code Review)
Hello Tidy Bot, Alexey Serbin, Dan Burkert, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7853 to look at the new patch set (#4). Change subject: WIP: use C++ ExternalMiniCluster for Java and Python tests

[kudu-CR] python: pin to cython 0.26.1

2017-09-27 Thread Adar Dembo (Code Review)
Hello Jean-Daniel Cryans, Wes McKinney, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/8155 to review the following change. Change subject: python: pin to cython 0.26.1 .. python: pin to cy

[kudu-CR] python: pin to cython 0.26.1

2017-09-27 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8155 ) Change subject: python: pin to cython 0.26.1 .. python: pin to cython 0.26.1 Some of our el6-based builds are running into an inst

[kudu-CR] [cluster itest util] fix typo in format string

2017-09-27 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/8156 ) Change subject: [cluster_itest_util] fix typo in format string .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org

[kudu-CR] subprocess: Call should redirect stdout to stderr when stdout not requested

2017-09-27 Thread Adar Dembo (Code Review)
Hello Dan Burkert, Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/8157 to review the following change. Change subject: subprocess: Call should redirect stdout to stderr when stdout not requested .

[kudu-CR] subprocess: Call should redirect stdout to stderr when stdout not requested

2017-09-27 Thread Adar Dembo (Code Review)
Hello Dan Burkert, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8157 to look at the new patch set (#2). Change subject: subprocess: Call should redirect stdout to stderr when stdout not requested ...

[kudu-CR] master-test: deflake a test

2017-09-27 Thread Adar Dembo (Code Review)
Hello Alexey Serbin, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/8158 to review the following change. Change subject: master-test: deflake a test .. master-test: deflake a test In this

[kudu-CR] master-test: fix test-only TSAN data race

2017-09-27 Thread Adar Dembo (Code Review)
Hello Alexey Serbin, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/8159 to review the following change. Change subject: master-test: fix test-only TSAN data race .. master-test: fix test-o

[kudu-CR] master-test: fix another source of test flakiness

2017-09-27 Thread Adar Dembo (Code Review)
Hello Alexey Serbin, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/8160 to review the following change. Change subject: master-test: fix another source of test flakiness .. master-test: fi

[kudu-CR] subprocess: Call should redirect stdout to stderr when stdout not requested

2017-09-27 Thread Adar Dembo (Code Review)
Adar Dembo has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/8157 ) Change subject: subprocess: Call should redirect stdout to stderr when stdout not requested .. Removed reviewer Kudu Jenkins with

[kudu-CR] subprocess: Call should redirect stdout to stderr when stdout not requested

2017-09-27 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/8157 ) Change subject: subprocess: Call should redirect stdout to stderr when stdout not requested .. Patch Set 2: Verified+1 Overriding Jenkins

[kudu-CR] master-test: fix another source of test flakiness

2017-09-27 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/8160 ) Change subject: master-test: fix another source of test flakiness .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/8160/1/

[kudu-CR] master-test: deflake a test

2017-09-27 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8158 ) Change subject: master-test: deflake a test .. master-test: deflake a test In this test the master would periodically crash in Res

[kudu-CR] master-test: fix another source of test flakiness

2017-09-27 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8160 ) Change subject: master-test: fix another source of test flakiness .. master-test: fix another source of test flakiness This timeou

[kudu-CR] master-test: fix test-only TSAN data race

2017-09-27 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8159 ) Change subject: master-test: fix test-only TSAN data race .. master-test: fix test-only TSAN data race MasterTest.TestRegisterAn

[kudu-CR] WIP: Pull StatusOr and related tests from protobuf

2017-09-28 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/8127 ) Change subject: WIP: Pull StatusOr and related tests from protobuf .. Patch Set 1: At first I thought this was supposed to be a StatusAnd,

[kudu-CR] env posix: add another failure case to Walk

2017-09-28 Thread Adar Dembo (Code Review)
Hello Alexey Serbin, Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/8171 to review the following change. Change subject: env_posix: add another failure case to Walk .. env_posi

[kudu-CR] env posix: add another failure case to Walk

2017-09-28 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/8171 ) Change subject: env_posix: add another failure case to Walk .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/8171/1/src/ku

[kudu-CR] subprocess: Call should redirect stdout to stderr when stdout not requested

2017-09-29 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/8157 ) Change subject: subprocess: Call should redirect stdout to stderr when stdout not requested .. Patch Set 2: (1 comment) http://gerrit.cl

[kudu-CR] python: pin to cython 0.26.1

2017-09-29 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/8155 ) Change subject: python: pin to cython 0.26.1 .. Patch Set 2: > Patch Set 2: > > Should we backport this to past branches so that we can bu

[kudu-CR] mini-cluster: new module for the mini cluster implementations

2017-09-29 Thread Adar Dembo (Code Review)
Hello Mike Percy, Alexey Serbin, Dan Burkert, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/8173 to review the following change. Change subject: mini-cluster: new module for the mini cluster implementations ..

[kudu-CR] env posix: add more failure cases to Walk

2017-09-29 Thread Adar Dembo (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8171 to look at the new patch set (#2). Change subject: env_posix: add more failure cases to Walk

[kudu-CR] env posix: add more failure cases to Walk

2017-09-29 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/8171 ) Change subject: env_posix: add more failure cases to Walk .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/8171/1/src/kudu

[kudu-CR] subprocess: Call should redirect stdout to stderr when stdout not requested

2017-09-29 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/8157 ) Change subject: subprocess: Call should redirect stdout to stderr when stdout not requested .. Patch Set 3: (1 comment) > I don't disagr

[kudu-CR](branch-1.5.x) python: pin to cython 0.26.1

2017-09-29 Thread Adar Dembo (Code Review)
Adar Dembo has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8174 Change subject: python: pin to cython 0.26.1 .. python: pin to cython 0.26.1 Some of our el6-based builds are running into an installation

[kudu-CR] python: pin to cython 0.26.1

2017-09-29 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/8155 ) Change subject: python: pin to cython 0.26.1 .. Patch Set 2: > Patch Set 2: > > Perhaps 1.3.x, 1.4.x, and 1.5.x, assuming they all cherry-

[kudu-CR](branch-1.3.x) python: pin to cython 0.26.1

2017-09-29 Thread Adar Dembo (Code Review)
Adar Dembo has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8176 Change subject: python: pin to cython 0.26.1 .. python: pin to cython 0.26.1 Some of our el6-based builds are running into an installation

[kudu-CR](branch-1.4.x) python: pin to cython 0.26.1

2017-09-29 Thread Adar Dembo (Code Review)
Adar Dembo has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8175 Change subject: python: pin to cython 0.26.1 .. python: pin to cython 0.26.1 Some of our el6-based builds are running into an installation

[kudu-CR] env posix: add more failure cases to Walk

2017-09-29 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8171 ) Change subject: env_posix: add more failure cases to Walk .. env_posix: add more failure cases to Walk The manpage for fts_read ha

[kudu-CR] catalog manager: make ScopedTabletInfoCommitter generic

2017-09-29 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8089 ) Change subject: catalog_manager: make ScopedTabletInfoCommitter generic .. catalog_manager: make ScopedTabletInfoCommitter generic

[kudu-CR] env posix: add more failure cases to Walk

2017-09-29 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/8171 ) Change subject: env_posix: add more failure cases to Walk .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/8171/3/src/kudu

[kudu-CR] env-test: add NO FATALS to create file and create dir calls

2017-09-29 Thread Adar Dembo (Code Review)
Hello Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/8178 to review the following change. Change subject: env-test: add NO_FATALS to create_file and create_dir calls .. env-tes

[kudu-CR] subprocess: Call should redirect stdout to stderr when stdout not requested

2017-09-29 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/8157 ) Change subject: subprocess: Call should redirect stdout to stderr when stdout not requested .. Patch Set 3: (1 comment) http://gerrit.cl

[kudu-CR] mini-cluster: new module for the mini cluster implementations

2017-09-29 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/8173 ) Change subject: mini-cluster: new module for the mini cluster implementations .. Patch Set 1: (3 comments) http://gerrit.cloudera.org:808

[kudu-CR] subprocess: some cosmetic changes

2017-09-29 Thread Adar Dembo (Code Review)
Hello Mike Percy, Alexey Serbin, Dan Burkert, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8157 to look at the new patch set (#4). Change subject: subprocess: some cosmetic changes ...

[kudu-CR] external mini cluster: don't pipe daemon subprocess stdout

2017-09-29 Thread Adar Dembo (Code Review)
Hello Dan Burkert, Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/8187 to review the following change. Change subject: external_mini_cluster: don't pipe daemon subprocess stdout ...

[kudu-CR] periodic: prevent runaway callback loops

2017-09-29 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8116 ) Change subject: periodic: prevent runaway callback loops .. periodic: prevent runaway callback loops One of the key semantics of P

[kudu-CR] tool: add cluster shell action

2017-09-29 Thread Adar Dembo (Code Review)
Hello Tidy Bot, Alexey Serbin, Dan Burkert, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7853 to look at the new patch set (#5). Change subject: tool: add cluster shell action

[kudu-CR] tool: add cluster shell action

2017-09-29 Thread Adar Dembo (Code Review)
Hello Tidy Bot, Alexey Serbin, Dan Burkert, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7853 to look at the new patch set (#6). Change subject: tool: add cluster shell action

[kudu-CR] env-test: add NO FATALS to create file and create dir calls

2017-09-29 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8178 ) Change subject: env-test: add NO_FATALS to create_file and create_dir calls .. env-test: add NO_FATALS to create_file and create_di

[kudu-CR](branch-1.4.x) python: pin to cython 0.26.1

2017-10-01 Thread Adar Dembo (Code Review)
Adar Dembo has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/8175 ) Change subject: python: pin to cython 0.26.1 .. Removed reviewer Kudu Jenkins with the following votes: * Verified-1 by Kudu Jenki

[kudu-CR](branch-1.4.x) python: pin to cython 0.26.1

2017-10-01 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/8175 ) Change subject: python: pin to cython 0.26.1 .. Patch Set 1: Verified+1 Overriding Jenkins, unrelated alter_table-test failure. I filed KU

[kudu-CR](branch-1.4.x) python: pin to cython 0.26.1

2017-10-01 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8175 ) Change subject: python: pin to cython 0.26.1 .. python: pin to cython 0.26.1 Some of our el6-based builds are running into an inst

[kudu-CR](branch-1.5.x) python: pin to cython 0.26.1

2017-10-01 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8174 ) Change subject: python: pin to cython 0.26.1 .. python: pin to cython 0.26.1 Some of our el6-based builds are running into an inst

[kudu-CR](branch-1.3.x) python: pin to cython 0.26.1

2017-10-01 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8176 ) Change subject: python: pin to cython 0.26.1 .. python: pin to cython 0.26.1 Some of our el6-based builds are running into an inst

[kudu-CR] KUDU-2132 Error dropping columns renamed to old key column names

2017-10-01 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/8188 ) Change subject: KUDU-2132 Error dropping columns renamed to old key column names .. Patch Set 1: (3 comments) Looks good to me, nice catc

[kudu-CR] mini-cluster: new module for the mini cluster implementations

2017-10-01 Thread Adar Dembo (Code Review)
Hello Mike Percy, Alexey Serbin, Dan Burkert, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8173 to look at the new patch set (#3). Change subject: mini-cluster: new module for the mini cluster implementations ...

[kudu-CR] tool: add cluster shell action

2017-10-01 Thread Adar Dembo (Code Review)
Hello Tidy Bot, Alexey Serbin, Dan Burkert, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7853 to look at the new patch set (#7). Change subject: tool: add cluster shell action

[kudu-CR] periodic: add one-shot timers

2017-10-01 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/8130 ) Change subject: periodic: add one-shot timers .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/8130/2/src/kudu/rpc/periodi

[kudu-CR] periodic: add one-shot timers

2017-10-01 Thread Adar Dembo (Code Review)
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8130 to look at the new patch set (#3). Change subject: periodic: add one-shot timers ..

[kudu-CR] periodic: add one-shot timers

2017-10-02 Thread Adar Dembo (Code Review)
Adar Dembo has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/8130 ) Change subject: periodic: add one-shot timers .. Removed reviewer Kudu Jenkins with the following votes: * Verified-1 by Kudu Jenk

[kudu-CR] periodic: add one-shot timers

2017-10-02 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/8130 ) Change subject: periodic: add one-shot timers .. Patch Set 3: Verified+1 Overriding Jenkins, got clock synchronization errors in some of t

[kudu-CR] external mini cluster: don't pipe daemon subprocess stdout

2017-10-02 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/8187 ) Change subject: external_mini_cluster: don't pipe daemon subprocess stdout .. Patch Set 2: Verified+1 Overriding Jenkins, there was an unr

[kudu-CR] external mini cluster: don't pipe daemon subprocess stdout

2017-10-02 Thread Adar Dembo (Code Review)
Adar Dembo has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/8187 ) Change subject: external_mini_cluster: don't pipe daemon subprocess stdout .. Removed reviewer Kudu Jenkins with the following vote

[kudu-CR] KUDU-2132 Error dropping columns renamed to old key column names

2017-10-02 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/8188 ) Change subject: KUDU-2132 Error dropping columns renamed to old key column names .. Patch Set 2: Code-Review+1 Will defer to Dan. -- To

<    4   5   6   7   8   9   10   11   12   13   >