Re: Review Request 44372: Upgrade http-parser to 2.6.1 to support PowerPC LE platform.

2016-03-23 Thread Vinod Kone
> On March 22, 2016, 2:35 a.m., haosdent huang wrote: > > Hi, zhiwei. Thank you for your patch. But seems it still doesn't contain > > the binary file correctly after I apply this patch. > > > > ``` > > diff --git a/3rdparty/libprocess/3rdparty/http-parser-2.6.1.tar.gz > >

Re: Review Request 43569: Updated log message if container not found.

2016-03-23 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43569/#review125098 --- Patch looks great! Reviews applied: [43015, 43569] Passed

Re: Review Request 45151: Updated FrameworkInfo::Capability::Type enum for upgradability.

2016-03-23 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45151/ --- (Updated March 23, 2016, 5:58 p.m.) Review request for mesos, Joris Van

Re: Review Request 44946: Add utility functions to manipulate XFS project quotas.

2016-03-23 Thread James Peach
> On March 23, 2016, 5:39 p.m., Jiang Yan Xu wrote: > > src/slave/containerizer/mesos/isolators/disk/xfs/utils.cpp, lines 17-19 > > > > > > So this is bug of the xfs headers? > > > > I guess it's still not

Re: Review Request 45151: Updated FrameworkInfo::Capability::Type enum for upgradability.

2016-03-23 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45151/#review125076 --- Ship it! Ship It! - Vinod Kone On March 22, 2016, 7:32

Re: Review Request 45093: Added mesos containerizer test DestroyWhileProvisioning.

2016-03-23 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45093/#review125094 --- Fix it, then Ship it!

Re: Review Request 44092: Windows:[2/3] Transitioned `os::recv` to use `os::pagesize`.

2016-03-23 Thread Daniel Pravat
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44092/ --- (Updated March 23, 2016, 6:23 p.m.) Review request for mesos, Alex Naparu,

Re: Review Request 42684: Multiple Disk: Added persistent volumes tests for `MOUNT` type.

2016-03-23 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42684/#review125062 --- Ship it! Ship It! - Jie Yu On March 21, 2016, 1:42 p.m.,

Re: Review Request 44372: Upgrade http-parser to 2.6.1 to support PowerPC LE platform.

2016-03-23 Thread haosdent huang
> On March 22, 2016, 2:35 a.m., haosdent huang wrote: > > Hi, zhiwei. Thank you for your patch. But seems it still doesn't contain > > the binary file correctly after I apply this patch. > > > > ``` > > diff --git a/3rdparty/libprocess/3rdparty/http-parser-2.6.1.tar.gz > >

Re: Review Request 44657: Used `KillPolicy` and shutdown grace period in command executor.

2016-03-23 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44657/ --- (Updated March 23, 2016, 4:56 p.m.) Review request for mesos, Ben Mahler and

Re: Review Request 45014: Add /containers endpoint to return ResourceUsage.

2016-03-23 Thread Jie Yu
> On March 22, 2016, 5:39 a.m., Jie Yu wrote: > > Instead of handling /containers endpoint in Slave, I would suggest we > > dispatch the request to ResourceMonitor. I will rename ResourceMonitor to > > ContainerMonitor, and we will be deprecating the /monitor/statistics > > endpoints in the

Re: Review Request 44854: Added validation for executor's shutdown grace period.

2016-03-23 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44854/#review125090 --- Fix it, then Ship it! Thanks for moving the test!

Re: Review Request 44760: Windows: Fixed non-blocking connect.

2016-03-23 Thread Daniel Pravat
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44760/ --- (Updated March 23, 2016, 8:49 p.m.) Review request for mesos, Alex Naparu,

Re: Review Request 44994: Added a test for executor shutdown grace period.

2016-03-23 Thread Alexander Rukletsov
> On March 18, 2016, 11:24 p.m., Ben Mahler wrote: > > src/tests/slave_tests.cpp, line 3264 > > > > > > You don't need a settle here, AWAIT_READY will settle if the clock is > > paused. > > Alexander Rukletsov

Re: Review Request 45240: Fixed typo in comment.

2016-03-23 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45240/#review125125 --- Ship it! Ship It! - Ben Mahler On March 23, 2016, 7:50

Re: Review Request 45241: Fixed invalid HTML in monitoring documentation.

2016-03-23 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45241/#review125126 --- Ship it! Ship It! - Ben Mahler On March 23, 2016, 7:50

Re: Review Request 45242: Fixed invalid HTML in upgrades documentation.

2016-03-23 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45242/#review125127 --- Ship it! Ship It! - Ben Mahler On March 23, 2016, 7:52

Re: Review Request 45092: Fixed containerizer potential race destroy while provisioning.

2016-03-23 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45092/ --- (Updated March 23, 2016, 2:17 p.m.) Review request for mesos, Artem

Re: Review Request 44514: Implemented prepare() method of "network/cni" isolator.

2016-03-23 Thread Cong Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44514/#review125131 --- src/slave/containerizer/mesos/isolators/network/cni/cni.cpp

Re: Review Request 45186: Implemented user specified system config files support.

2016-03-23 Thread Gilbert Song
> On March 22, 2016, 11:51 p.m., Guangya Liu wrote: > > src/slave/containerizer/mesos/isolators/docker/runtime.cpp, lines 231-233 > > > > > > Put this check to the block of > > if

Re: Review Request 45186: Implemented user specified system config files support.

2016-03-23 Thread Gilbert Song
> On March 22, 2016, 11:46 p.m., Guangya Liu wrote: > > src/slave/containerizer/mesos/isolators/docker/runtime.cpp, lines 204-205 > > > > > > what about: > > > > foreach ( > > const string& file, >

Re: Review Request 45003: Fixed rmdir comment for FTS_SLNONE as per coding guidelines.

2016-03-23 Thread Cong Wang
> On March 20, 2016, 2:33 a.m., Neil Conway wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/rmdir.hpp, line 71 > > > > > > This comment seems incorrect: > > > > (1) The relevant

Re: Review Request 45002: Added FTS_PHYSICAL option to fts_open for rmdir.

2016-03-23 Thread Cong Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45002/#review125120 --- Ship it! Ship It! - Cong Wang On March 18, 2016, 12:16

Re: Review Request 44709: Allowed unknown flags in command and docker executors.

2016-03-23 Thread Alexander Rukletsov
> On March 18, 2016, 11:32 p.m., Jie Yu wrote: > > src/docker/executor.cpp, lines 588-590 > > > > > > This is more like a question: are you talking about the case where the > > agent binary is updated, while the

Review Request 45242: Fixed invalid HTML in upgrades documentation.

2016-03-23 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45242/ --- Review request for mesos and Till Toenshoff. Repository: mesos Description

Review Request 45240: Fixed typo in comment.

2016-03-23 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45240/ --- Review request for mesos and Ben Mahler. Repository: mesos Description

Review Request 45241: Fixed invalid HTML in monitoring documentation.

2016-03-23 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45241/ --- Review request for mesos and Ben Mahler. Repository: mesos Description

Re: Review Request 45002: Added FTS_PHYSICAL option to fts_open for rmdir.

2016-03-23 Thread Cong Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45002/#review125121 --- Not related to your patch, but it also makes sense to add

Re: Review Request 44138: Windows:[1/2] Lifted socket API into Stout.

2016-03-23 Thread Daniel Pravat
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44138/ --- (Updated March 23, 2016, 8:47 p.m.) Review request for mesos, Alex Naparu,

Re: Review Request 44854: Added validation for executor's shutdown grace period.

2016-03-23 Thread Alexander Rukletsov
> On March 23, 2016, 6:49 p.m., Ben Mahler wrote: > > src/tests/master_validation_tests.cpp, lines 1175-1176 > > > > > > Why the explicit detector? After recent test harness refactoring, there is no `StartSlave()`

Re: Review Request 44514: Implemented prepare() method of "network/cni" isolator.

2016-03-23 Thread Cong Wang
> On March 11, 2016, 6:19 p.m., Avinash sridharan wrote: > > src/slave/containerizer/mesos/isolators/network/cni.cpp, line 228 > > > > > > Can there be a use case where you want multiple NICs to be attached to > >

Re: Review Request 45093: Added mesos containerizer test DestroyWhileProvisioning.

2016-03-23 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45093/ --- (Updated March 23, 2016, 2:23 p.m.) Review request for mesos, Artem

Review Request 45243: WIP: Added a metric for querying the number offer filters for a role.

2016-03-23 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45243/ --- Review request for mesos and Ben Mahler. Repository: mesos Description

Re: Review Request 44515: Added agent flags for HTTP authentication.

2016-03-23 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44515/ --- (Updated March 23, 2016, 9:38 a.m.) Review request for mesos, Adam B,

Re: Review Request 45204: Fixed master flags endpoint help and regenerated endpoint documentation.

2016-03-23 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45204/ --- (Updated March 23, 2016, 9:49 a.m.) Review request for mesos, Adam B and Till

Re: Review Request 45036: Added authentication information to agent endpoints.

2016-03-23 Thread Joerg Schad
> On March 21, 2016, 10:28 a.m., Adam B wrote: > > src/slave/http.cpp, lines 351-354 > > > > > > Looks like `Master::Http::FLAGS_HELP()` is incorrectly using > > AUTHENTICATION() as its DESCRIPTION parameter..

Review Request 45209: Made sure all Python modules are installed.

2016-03-23 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45209/ --- Review request for mesos and Till Toenshoff. Bugs: MESOS-5010

Re: Review Request 44139: Windows:[2/2] Lifted socket API into Stout.

2016-03-23 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44139/#review125013 --- Ship it! Ship It! - Joris Van Remoortere On March 21, 2016,

Re: Review Request 44747: Stout: Added implementation of `write` that works on Windows.

2016-03-23 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44747/#review125009 --- Ship it! - Joris Van Remoortere On March 22, 2016, 5:20

Re: Review Request 44138: Windows:[1/2] Lifted socket API into Stout.

2016-03-23 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44138/#review124782 --- Fix it, then Ship it!

Re: Review Request 44553: Added authentication to agent HTTP endpoints.

2016-03-23 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44553/ --- (Updated March 23, 2016, 11:39 a.m.) Review request for mesos, Adam B,

Re: Review Request 44553: Added authentication to agent HTTP endpoints.

2016-03-23 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44553/ --- (Updated March 23, 2016, 11:23 a.m.) Review request for mesos, Adam B,

Review Request 45211: Adjusted include order.

2016-03-23 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45211/ --- Review request for mesos, Gilbert Song and Jie Yu. Repository: mesos

Re: Review Request 44450: Rescind all outstanding offers to satisfy weights update.

2016-03-23 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44450/#review124997 --- Patch looks great! Reviews applied: [44450] Passed command:

Re: Review Request 44515: Added agent flags for HTTP authentication.

2016-03-23 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44515/#review124996 --- Fix it, then Ship it! src/slave/slave.cpp (line 358)

Re: Review Request 45183: Implemented mounting host system config files to container.

2016-03-23 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45183/ --- (Updated March 23, 2016, 2:49 p.m.) Review request for mesos, Guangya Liu,

Re: Review Request 45184: Added test for mounting host system config files.

2016-03-23 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45184/ --- (Updated March 23, 2016, 2:50 p.m.) Review request for mesos, Guangya Liu,

Re: Review Request 45067: Updated the long-lived-framework example.

2016-03-23 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45067/ --- (Updated March 23, 2016, 3:50 p.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 44657: Used `KillPolicy` and shutdown grace period in command executor.

2016-03-23 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44657/ --- (Updated March 23, 2016, 9:45 p.m.) Review request for mesos, Ben Mahler and

Re: Review Request 45092: Fixed containerizer potential race destroy while provisioning.

2016-03-23 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45092/#review125143 --- Ship it! src/slave/containerizer/mesos/containerizer.cpp

Re: Review Request 45151: Updated FrameworkInfo::Capability::Type enum for upgradability.

2016-03-23 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45151/#review125151 --- Patch looks great! Reviews applied: [45151] Passed command:

Re: Review Request 44657: Used `KillPolicy` and shutdown grace period in command executor.

2016-03-23 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44657/ --- (Updated March 23, 2016, 11:01 p.m.) Review request for mesos, Ben Mahler and

Re: Review Request 44660: Used `KillPolicy` and shutdown grace period in docker executor.

2016-03-23 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44660/ --- (Updated March 23, 2016, 11:25 p.m.) Review request for mesos, Ben Mahler,

Re: Review Request 44657: Used `KillPolicy` and shutdown grace period in command executor.

2016-03-23 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44657/ --- (Updated March 23, 2016, 11:25 p.m.) Review request for mesos, Ben Mahler and

Re: Review Request 45040: Added a test for task's kill policy.

2016-03-23 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45040/ --- (Updated March 23, 2016, 11:24 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 44707: Added validation for task's kill policy.

2016-03-23 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44707/ --- (Updated March 23, 2016, 11:24 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 45067: Updated the long-lived-framework example.

2016-03-23 Thread Joseph Wu
> On March 18, 2016, 11:42 p.m., haosdent huang wrote: > > src/examples/long_lived_framework.cpp, line 168 > > > > > > I think use > > ``` > > if (flags.master.isNone()) { > > EXIT(EXIT_FAILURE) >

Re: Review Request 45067: Updated the long-lived-framework example.

2016-03-23 Thread Joseph Wu
> On March 18, 2016, 6:35 p.m., Neil Conway wrote: > > src/examples/long_lived_framework.cpp, line 135 > > > > > > Don't we need `TaskState_Name` here? Yeah, for some reason, I thought that used an internal header.

Re: Review Request 44655: Made `shutdown_grace_period` configurable in `ExecutorInfo`.

2016-03-23 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44655/ --- (Updated March 23, 2016, 11:15 p.m.) Review request for mesos, Ben Mahler and

Re: Review Request 44994: Added a test for executor shutdown grace period.

2016-03-23 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44994/ --- (Updated March 23, 2016, 11:22 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 44656: Introduced `KillPolicy` protobuf.

2016-03-23 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44656/ --- (Updated March 23, 2016, 11:27 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 44661: Deprecated the `docker_stop_timeout` flag.

2016-03-23 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44661/ --- (Updated March 23, 2016, 11:26 p.m.) Review request for mesos, Ben Mahler and

Re: Review Request 45003: Fixed rmdir comment for FTS_SLNONE as per coding guidelines.

2016-03-23 Thread Jojy Varghese
> On March 20, 2016, 2:33 a.m., Neil Conway wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/rmdir.hpp, line 71 > > > > > > This comment seems incorrect: > > > > (1) The relevant

Re: Review Request 45002: Added FTS_PHYSICAL option to fts_open for rmdir.

2016-03-23 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45002/#review125066 --- Fix it, then Ship it!

Re: Review Request 44091: Windows:[1/3] Implemented `os::pagesize`.

2016-03-23 Thread Daniel Pravat
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44091/ --- (Updated March 23, 2016, 5:42 p.m.) Review request for mesos, Alex Naparu,

Review Request 45266: Add zookeeper-3.4.8.tar.gz.

2016-03-23 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45266/ --- Review request for mesos. Repository: mesos Description --- Add

Re: Review Request 44670: Added master_detector and master_contender flags.

2016-03-23 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44670/#review125192 --- Patch looks great! Reviews applied: [44287, 44288, 44543, 44544,

Re: Review Request 44138: Windows:[1/2] Lifted socket API into Stout.

2016-03-23 Thread Daniel Pravat
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44138/ --- (Updated March 24, 2016, 3:17 a.m.) Review request for mesos, Alex Naparu,

Review Request 45267: Fixed a memory leak in process::subprocess.

2016-03-23 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45267/ --- Review request for mesos and Jie Yu. Bugs: MESOS-5021

Review Request 45269: Test upload zookeeper tar.

2016-03-23 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45269/ --- Review request for mesos. Summary (updated) - Test upload

Re: Review Request 45267: Fixed a memory leak in process::subprocess.

2016-03-23 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45267/#review125199 --- Ship it! Ship It! - Jie Yu On March 24, 2016, 3:41 a.m.,

Re: Review Request 44138: Windows:[1/2] Lifted socket API into Stout.

2016-03-23 Thread Daniel Pravat
> On March 23, 2016, 12:40 p.m., Joris Van Remoortere wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/socket.hpp, line > > 35 > > > > > > Should `EINPROGRESS` be in here? > > would a retry

Re: Review Request 45267: Fixed a memory leak in process::subprocess.

2016-03-23 Thread Klaus Ma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45267/#review125200 --- Ship it! Ship It! - Klaus Ma On March 24, 2016, 11:41 a.m.,

Re: Review Request 45248: Added authentication to the '/files' endpoints.

2016-03-23 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45248/ --- (Updated March 24, 2016, 12:58 a.m.) Review request for mesos, Adam B, Ben

Re: Review Request 45002: Added FTS_PHYSICAL option to fts_open for rmdir.

2016-03-23 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45002/ --- (Updated March 24, 2016, 1:07 a.m.) Review request for mesos, Jie Yu and Neil

Re: Review Request 45003: Fixed rmdir comment for FTS_SLNONE as per coding guidelines.

2016-03-23 Thread Neil Conway
> On March 20, 2016, 2:33 a.m., Neil Conway wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/rmdir.hpp, line 71 > > > > > > This comment seems incorrect: > > > > (1) The relevant

Re: Review Request 45002: Added FTS_PHYSICAL option to fts_open for rmdir.

2016-03-23 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45002/#review125167 --- 3rdparty/libprocess/3rdparty/stout/tests/os/rmdir_tests.cpp

Re: Review Request 44372: Upgrade http-parser to 2.6.1 to support PowerPC LE platform.

2016-03-23 Thread Joseph Wu
> On March 21, 2016, 7:35 p.m., haosdent huang wrote: > > Hi, zhiwei. Thank you for your patch. But seems it still doesn't contain > > the binary file correctly after I apply this patch. > > > > ``` > > diff --git a/3rdparty/libprocess/3rdparty/http-parser-2.6.1.tar.gz > >

Re: Review Request 44257: Upgrade protobuf to 2.6.1 to support PowerPC LE platform.

2016-03-23 Thread Zhiwei Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44257/ --- (Updated March 24, 2016, 9:28 a.m.) Review request for mesos, Ben Mahler, Alex

Re: Review Request 44378: Upgrade libev to 4.22 to support PowerPC LE platform.

2016-03-23 Thread Zhiwei Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44378/ --- (Updated March 24, 2016, 10:02 a.m.) Review request for mesos, Ben Mahler,

Re: Review Request 44660: Used `KillPolicy` and shutdown grace period in docker executor.

2016-03-23 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44660/#review124353 --- Sorry I forgot to publish some stale comments from before, these

Re: Review Request 45186: Implemented user specified system config files support.

2016-03-23 Thread Guangya Liu
> On 三月 23, 2016, 6:51 a.m., Guangya Liu wrote: > > src/slave/containerizer/mesos/isolators/docker/runtime.cpp, lines 231-233 > > > > > > Put this check to the block of > > if

Re: Review Request 45186: Implemented user specified system config files support.

2016-03-23 Thread Guangya Liu
> On 三月 23, 2016, 6:46 a.m., Guangya Liu wrote: > > src/slave/containerizer/mesos/isolators/docker/runtime.cpp, lines 204-205 > > > > > > what about: > > > > foreach ( > > const string& file, > >

Re: Review Request 45003: Fixed rmdir comment for FTS_SLNONE as per coding guidelines.

2016-03-23 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45003/#review125161 --- Fix it, then Ship it!

Re: Review Request 45003: Fixed rmdir comment for FTS_SLNONE as per coding guidelines.

2016-03-23 Thread Neil Conway
> On March 20, 2016, 2:33 a.m., Neil Conway wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/rmdir.hpp, line 71 > > > > > > This comment seems incorrect: > > > > (1) The relevant

Re: Review Request 45002: Added FTS_PHYSICAL option to fts_open for rmdir.

2016-03-23 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45002/ --- (Updated March 24, 2016, 1:34 a.m.) Review request for mesos, Jie Yu and Neil

Re: Review Request 44255: Add metrics for {RESERVE, UNRESERVE, CREATE, DESTROY} offer operation.

2016-03-23 Thread fan du
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44255/ --- (Updated 三月 24, 2016, 1:54 a.m.) Review request for mesos, Greg Mann, Guangya

Re: Review Request 45000: MESOS-3902: [Updated] Fix location header in redirect from non-leader.

2016-03-23 Thread Ashwin Murthy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45000/ --- (Updated March 24, 2016, 2:24 a.m.) Review request for mesos and Vinod Kone.

Re: Review Request 45217: Implemented docker volume driver isolator interface.

2016-03-23 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45217/ --- (Updated 三月 24, 2016, 2:25 a.m.) Review request for mesos and Jie Yu. Bugs:

Re: Review Request 45214: Updated protobuf to support external storage.

2016-03-23 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45214/ --- (Updated 三月 24, 2016, 2:24 a.m.) Review request for mesos and Jie Yu. Bugs:

Re: Review Request 44660: Used `KillPolicy` and shutdown grace period in docker executor.

2016-03-23 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44660/#review125185 --- Fix it, then Ship it! include/mesos/mesos.proto (lines 359 -

Re: Review Request 44372: Upgrade http-parser to 2.6.1 to support PowerPC LE platform.

2016-03-23 Thread Zhiwei Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44372/ --- (Updated March 24, 2016, 9:13 a.m.) Review request for mesos, Ben Mahler, Alex

Re: Review Request 45003: Fixed rmdir comment for FTS_SLNONE as per coding guidelines.

2016-03-23 Thread Jojy Varghese
> On March 20, 2016, 2:33 a.m., Neil Conway wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/rmdir.hpp, line 71 > > > > > > This comment seems incorrect: > > > > (1) The relevant

Re: Review Request 45003: Fixed rmdir comment for FTS_SLNONE as per coding guidelines.

2016-03-23 Thread Jojy Varghese
> On March 20, 2016, 2:33 a.m., Neil Conway wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/rmdir.hpp, line 71 > > > > > > This comment seems incorrect: > > > > (1) The relevant

Re: Review Request 44372: Upgrade http-parser to 2.6.1 to support PowerPC LE platform.

2016-03-23 Thread Zhiwei Chen
> On March 22, 2016, 10:35 a.m., haosdent huang wrote: > > Hi, zhiwei. Thank you for your patch. But seems it still doesn't contain > > the binary file correctly after I apply this patch. > > > > ``` > > diff --git a/3rdparty/libprocess/3rdparty/http-parser-2.6.1.tar.gz > >

Re: Review Request 45000: MESOS-3902: Fix in location header during redirect from non-leader.

2016-03-23 Thread Ashwin Murthy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45000/ --- (Updated March 24, 2016, 2:19 a.m.) Review request for mesos and Vinod Kone.

Re: Review Request 44661: Deprecated the `docker_stop_timeout` flag.

2016-03-23 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44661/#review125186 --- Fix it, then Ship it! Thanks! CHANGELOG (line 6)

Re: Review Request 44514: Implemented prepare() method of "network/cni" isolator.

2016-03-23 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44514/ --- (Updated March 24, 2016, 10:34 a.m.) Review request for mesos, Avinash

Review Request 45265: Plugged in dvd isolator into agent.

2016-03-23 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45265/ --- Review request for mesos and Jie Yu. Repository: mesos Description ---

Re: Review Request 45249: Added new '/files' endpoints tests using authentication.

2016-03-23 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45249/ --- (Updated March 24, 2016, 1:05 a.m.) Review request for mesos, Adam B, Ben

  1   2   >