Adar Dembo has posted comments on this change.
Change subject: docs: design for handling permanent master failures
..
Patch Set 2:
The doc has been changed significantly. The "real" approach now requires DNS
cnames and thus
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/3393
to look at the new patch set (#3).
Change subject: docs: design for handling permanent master failures
..
docs:
Adar Dembo has posted comments on this change.
Change subject: docs: design for handling permanent master failures
..
Patch Set 2:
(3 comments)
Adar Dembo has posted comments on this change.
Change subject: KUDU-526: use on-disk cmeta when loading existing master state
..
Patch Set 2: Verified+1
Overriding Jenkins, the isolate server died mid-run and several tests
Adar Dembo has posted comments on this change.
Change subject: KUDU-1538: prevent block ID reuse to avoid potential data loss
..
Patch Set 2:
(3 comments)
Seems like the path of least resistance.
I was inclined to vote for
Adar Dembo has uploaded a new change for review.
http://gerrit.cloudera.org:8080/3811
Change subject: remote_bootstrap_client: mild API changes
..
remote_bootstrap_client: mild API changes
1. I removed the uuid argument from
Adar Dembo has uploaded a new change for review.
http://gerrit.cloudera.org:8080/3810
Change subject: external_mini_cluster: adjust single master data directory
..
external_mini_cluster: adjust single master data directory
Adar Dembo has uploaded a new change for review.
http://gerrit.cloudera.org:8080/3812
Change subject: build-and-test: also clean up old failsafe reports
..
build-and-test: also clean up old failsafe reports
With failsafe is
Adar Dembo has posted comments on this change.
Change subject: KUDU-1358 (part 3): new multi-master stress test
..
Patch Set 13:
> have you looped this one? Also, Dan, any further comments?
Yes, I did quite a few 1000 run
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/3811
to look at the new patch set (#4).
Change subject: remote_bootstrap_client: mild API changes
..
Adar Dembo has posted comments on this change.
Change subject: c++ client: remove unnecessary code
..
Patch Set 3:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/3809/3/src/kudu/client/client-internal.cc
File
Adar Dembo has posted comments on this change.
Change subject: docs: design for handling permanent master failures
..
Patch Set 3:
(3 comments)
Adar Dembo has posted comments on this change.
Change subject: [util] fixed build on MacOS X
..
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/3836/1/src/kudu/util/CMakeLists.txt
File
Hello Mike Percy, Todd Lipcon,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/3826
to review the following change.
Change subject: push_to_asf.py: update repo URL
..
push_to_asf.py: update
Adar Dembo has posted comments on this change.
Change subject: fs_tool: improve format for dumping a rowset
..
Patch Set 1:
Given that the tool will now take a different code path entirely, could you
amend the commit message
Adar Dembo has posted comments on this change.
Change subject: [java client] Support add/remove partition
..
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/3854
To unsubscribe, visit
Adar Dembo has posted comments on this change.
Change subject: Memory tracking for result tracker
..
Patch Set 19:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/3627/19/src/kudu/rpc/result_tracker.h
File
Adar Dembo has posted comments on this change.
Change subject: Reorganize range partition client API
..
Patch Set 3:
(14 comments)
http://gerrit.cloudera.org:8080/#/c/3882/3/src/kudu/client/client-test.cc
File
Adar Dembo has posted comments on this change.
Change subject: Fix bug in partition key debug printing
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/3879
To unsubscribe, visit
Adar Dembo has posted comments on this change.
Change subject: Add table id to AlterTableResponsePB
..
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/3859
To unsubscribe, visit
Adar Dembo has posted comments on this change.
Change subject: Add table id to AlterTableResponsePB
..
Patch Set 3: Code-Review+2
(1 comment)
Adar Dembo has posted comments on this change.
Change subject: Fix bug in partition key debug printing
..
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/3879
To unsubscribe, visit
Hello Mike Percy, Todd Lipcon,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/3880
to review the following change.
Change subject: KUDU-1474: single to multi-master deployment migration
..
Adar Dembo has submitted this change and it was merged.
Change subject: [util] fixed build on MacOS X
..
[util] fixed build on MacOS X
This is a follow-up for a9265d92424dc305c480d6c44d006b8545bd2227.
Change-Id:
Adar Dembo has posted comments on this change.
Change subject: [util] fixed build on MacOS X
..
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/3836
To unsubscribe, visit
Adar Dembo has posted comments on this change.
Change subject: KUDU-236. Implement tablet history GC
..
Patch Set 11:
Could you also add a GCing thread to mt-tablet-test? It's a good way to test
interactions between
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/3880
to look at the new patch set (#6).
Change subject: KUDU-1474: single to multi-master deployment migration
..
Adar Dembo has posted comments on this change.
Change subject: KUDU-236. Implement tablet history GC
..
Patch Set 11:
(1 comment)
Just passing through with a question.
Adar Dembo has submitted this change and it was merged.
Change subject: Replace gscoped_ptr with unique_ptr for ConsensusMetadata
..
Replace gscoped_ptr with unique_ptr for ConsensusMetadata
Change-Id:
Adar Dembo has posted comments on this change.
Change subject: monotime: remove granularity argument
..
Patch Set 1: Code-Review+2
Personally, I'm fine with the outright removal.
--
To view, visit
Adar Dembo has posted comments on this change.
Change subject: Memory tracking for result tracker
..
Patch Set 20:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/3627/19/src/kudu/rpc/result_tracker.cc
File
Adar Dembo has posted comments on this change.
Change subject: Reorganize range partition client API
..
Patch Set 5: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/3882
To unsubscribe, visit
Adar Dembo has posted comments on this change.
Change subject: KUDU-1474: single to multi-master deployment migration
..
Patch Set 4:
(32 comments)
Adar Dembo has posted comments on this change.
Change subject: KUDU-1559. Fix block manager metric for aborted blocks
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/3964
To unsubscribe, visit
Adar Dembo has posted comments on this change.
Change subject: [java-client] Reorganize range partition client API
..
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/3958
To unsubscribe, visit
Adar Dembo has posted comments on this change.
Change subject: KUDU-1474: single to multi-master deployment migration
..
Patch Set 4:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/3880/4/src/kudu/master/sys_catalog.h
File
Hello Dan Burkert, Todd Lipcon, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/3880
to look at the new patch set (#5).
Change subject: KUDU-1474: single to multi-master deployment migration
Hello Dan Burkert, Todd Lipcon,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/3967
to review the following change.
Change subject: Replace gscoped_ptr with unique_ptr for ConsensusMetadata
Hello Dan Burkert, Todd Lipcon,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/3969
to review the following change.
Change subject: integration_tests: end-to-end master permanent failure test
Hello Dan Burkert, Todd Lipcon,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/3968
to review the following change.
Change subject: fs: allow format with arbitrary uuid
..
fs: allow format
Adar Dembo has posted comments on this change.
Change subject: master: additional leader lock assertions in catalog manager
..
Patch Set 5:
(4 comments)
Adar Dembo has submitted this change and it was merged.
Change subject: remote_bootstrap_client: mild API changes
..
remote_bootstrap_client: mild API changes
1. I removed the uuid argument from the constructor; it's always
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/3684
to look at the new patch set (#6).
Change subject: master: additional leader lock assertions in catalog manager
..
Adar Dembo has posted comments on this change.
Change subject: KUDU-526: use on-disk cmeta when loading existing master state
..
Patch Set 3:
(1 comment)
Adar Dembo has posted comments on this change.
Change subject: [java-client] Re-enable multi-master tests
..
Patch Set 4:
> Oh, apparently it needs a manual rebase (I guess due to the package
> change)
Yeah, I'll take care
Adar Dembo has posted comments on this change.
Change subject: Fix remaining instance of kududb package in docs
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/3844
To unsubscribe, visit
Adar Dembo has posted comments on this change.
Change subject: [flume] fix import of shaded guava class
..
Patch Set 1: Code-Review+2
How did you spot this?
--
To view, visit http://gerrit.cloudera.org:8080/3845
To
Hello Todd Lipcon,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/3847
to review the following change.
Change subject: heartbeater: slight fixes to backoff behavior
..
heartbeater: slight
Adar Dembo has submitted this change and it was merged.
Change subject: [java client] Upgrade hadoop-client to 2.7.2
..
[java client] Upgrade hadoop-client to 2.7.2
With the old version, I was hitting HADOOP-10961 when running
Adar Dembo has posted comments on this change.
Change subject: [C++ client] doxygenized all C++ client API
..
Patch Set 2:
(86 comments)
Looks like client_samples-test failed, btw.
Adar Dembo has posted comments on this change.
Change subject: Add weekly update for 8/8
..
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/3864/1/_posts/2016-08-08-weekly-update.md
File
Adar Dembo has posted comments on this change.
Change subject: Add weekly update for 8/8
..
Patch Set 2: Code-Review+2
Glad I noticed the more important error.
--
To view, visit http://gerrit.cloudera.org:8080/3864
To
Adar Dembo has posted comments on this change.
Change subject: [java client] Support add/remove partition
..
Patch Set 1:
(18 comments)
Adar Dembo has posted comments on this change.
Change subject: [C++ client] doxygenized all C++ client API
..
Patch Set 4:
(4 comments)
http://gerrit.cloudera.org:8080/#/c/3840/2/src/kudu/client/callbacks.h
File
Adar Dembo has posted comments on this change.
Change subject: [doxygen] made DESTDIR applicable for ninja builds
..
Patch Set 1: Code-Review+2
Looks good provided you've tested it with both make and ninja.
--
To view, visit
Adar Dembo has posted comments on this change.
Change subject: push_to_asf.py: update repo URL
..
Patch Set 1: Verified+1
Failure in AlterTableRandomizedTest, definitely unrelated to this patch.
--
To view, visit
Adar Dembo has posted comments on this change.
Change subject: Fix block_manager-test running in some builds
..
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/3733
To unsubscribe, visit
Adar Dembo has submitted this change and it was merged.
Change subject: Fix block_manager-test running in some builds
..
Fix block_manager-test running in some builds
Even though the patch for KUDU-1538 passed pre-commit, it
Hello Todd Lipcon, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/3809
to look at the new patch set (#3).
Change subject: c++ client: remove unnecessary code
..
c++ client:
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/3684
to look at the new patch set (#5).
Change subject: master: additional leader lock assertions in catalog manager
..
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/3811
to look at the new patch set (#3).
Change subject: remote_bootstrap_client: mild API changes
..
Adar Dembo has posted comments on this change.
Change subject: [java client] Support add/remove partition
..
Patch Set 2:
(12 comments)
Adar Dembo has posted comments on this change.
Change subject: cfile-test: some test micro-optimization to avoid timeouts
..
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/3875/1//COMMIT_MSG
Commit Message:
Adar Dembo has posted comments on this change.
Change subject: remote_bootstrap_client: mild API changes
..
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/3811/3//COMMIT_MSG
Commit Message:
Line 15:logging,
Hello Todd Lipcon, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/3997
to look at the new patch set (#2).
Change subject: catalog_manager: avoid race in InitSysCatalogAsync() and
GetTabletPeer()
Adar Dembo has submitted this change and it was merged.
Change subject: mini_cluster: avoid SIGSEGV when master fails to start up
..
mini_cluster: avoid SIGSEGV when master fails to start up
My machine's clock became
Adar Dembo has submitted this change and it was merged.
Change subject: catalog_manager: avoid race in InitSysCatalogAsync() and
GetTabletPeer()
..
catalog_manager: avoid race in InitSysCatalogAsync() and GetTabletPeer()
Adar Dembo has posted comments on this change.
Change subject: Fix ScanToken generation with non-covering range partitions
..
Patch Set 1: Code-Review+2
Would be nice to consolidate that code, but I don't see an easy way to do
Adar Dembo has abandoned this change.
Change subject: catalog_manager: avoid more races between Init() and
GetTabletPeer()
..
Abandoned
After some more digging, it appears the race is between Shutdown() and an RPC
in
Adar Dembo has posted comments on this change.
Change subject: Add time/watermark based garbage collection to ResultTracker
..
Patch Set 18: Code-Review+2
(1 comment)
Adar Dembo has posted comments on this change.
Change subject: [util/monotime] added handy operators for MonoTime
..
Patch Set 1:
(12 comments)
Is the use case for these guys very compelling? Although the Google style guide
Adar Dembo has posted comments on this change.
Change subject: tool: rewrite parser logic
..
Patch Set 3:
> looks good but the patch it's based on seems to have exploded.
Yeah, I rebased to switch the order around. And I
Adar Dembo has posted comments on this change.
Change subject: Start a background thread to run ResultTracker GC
..
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/3961/3/src/kudu/rpc/result_tracker.cc
File
Adar Dembo has posted comments on this change.
Change subject: Memory tracking for result tracker
..
Patch Set 21: Code-Review+2
(2 comments)
http://gerrit.cloudera.org:8080/#/c/3627/19/src/kudu/rpc/result_tracker.cc
File
Adar Dembo has posted comments on this change.
Change subject: Start a background thread to run ResultTracker GC
..
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/3961/3/src/kudu/rpc/result_tracker.cc
File
Adar Dembo has restored this change.
Change subject: catalog_manager: avoid more races between Init() and
GetTabletPeer()
..
Restored
I found a way to hack through this.
--
To view, visit
Adar Dembo has posted comments on this change.
Change subject: Add weekly update for 8/16
..
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/4008
To unsubscribe, visit
Adar Dembo has posted comments on this change.
Change subject: KUDU-236 (part 1). Implement tablet history GC
..
Patch Set 14:
> > Could you also add a GCing thread to mt-tablet-test? It's a good
> > way to test interactions
Adar Dembo has posted comments on this change.
Change subject: docs: design for handling permanent master failures
..
Patch Set 4:
(1 comment)
Adar Dembo has posted comments on this change.
Change subject: [c++-client] fix KuduScanTokenBuilder token generation bugs
..
Patch Set 2:
(3 comments)
Adar Dembo has posted comments on this change.
Change subject: [util/monotime] added handy operators for MonoTime
..
Patch Set 2:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/3999/1/src/kudu/util/monotime.h
File
Adar Dembo has posted comments on this change.
Change subject: new range partitioning features blog post
..
Patch Set 1:
(15 comments)
I mostly proofread for style.
Adar Dembo has posted comments on this change.
Change subject: Bump Squeasel version
..
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/5855
To unsubscribe, visit
Adar Dembo has posted comments on this change.
Change subject: thirdparty: patch cmake to avoid select() when reading from
subprocess pipes
..
Patch Set 1: Code-Review-2
MJ and I discussed this further and decided it might be
Hello Matthew Jacobs, Todd Lipcon,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/5857
to review the following change.
Change subject: thirdparty: patch cmake to avoid select() when reading from
subprocess pipes
Adar Dembo has posted comments on this change.
Change subject: thirdparty: patch cmake to avoid select() when reading from
subprocess pipes
..
Patch Set 1:
> hrm... is there any patch upstream in cmake to switch from select()
Adar Dembo has posted comments on this change.
Change subject: Fix to KUDU-1642 patch
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/5856
To unsubscribe, visit
Adar Dembo has posted comments on this change.
Change subject: Bump Squeasel version
..
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5855/1/thirdparty/build-definitions.sh
File thirdparty/build-definitions.sh:
Adar Dembo has posted comments on this change.
Change subject: thirdparty: patch cmake to avoid select() when reading from
subprocess pipes
..
Patch Set 1:
> This should only affect the cmake build itself, i.e. thirdparty.
Adar Dembo has posted comments on this change.
Change subject: master_rpc: pass back more details from ConnectToCluster
..
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/5892
To unsubscribe,
Adar Dembo has posted comments on this change.
Change subject: [thirdparty] Avoid building tsan on macOS on specific dep builds
..
Patch Set 1:
(1 comment)
Adar Dembo has posted comments on this change.
Change subject: [master] store CA information in the system table
..
Patch Set 9:
(20 comments)
I didn't review the changes to master_cert_authority since I have no context
for
Adar Dembo has posted comments on this change.
Change subject: Fix some clang-tidy errors for std::move
..
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/5867
To unsubscribe, visit
Adar Dembo has posted comments on this change.
Change subject: Make reduce flake from KUDU-1642 tests in client-test
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/5882
To unsubscribe, visit
Adar Dembo has posted comments on this change.
Change subject: client: rename various function calls and classes to
ConnectToCluster
..
Patch Set 2: Code-Review+2
(1 comment)
Adar Dembo has posted comments on this change.
Change subject: Move 'master_rpc.{h,cc}' into the client/ module
..
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/5864
To unsubscribe, visit
Adar Dembo has posted comments on this change.
Change subject: [mini_cluster] fix crash in GetLeaderMasterIndex()
..
Patch Set 2:
(1 comment)
Adar Dembo has posted comments on this change.
Change subject: WIP: Add new ConnectToMaster RPC, implement client fallback
..
Patch Set 1:
(8 comments)
http://gerrit.cloudera.org:8080/#/c/5869/1/src/kudu/client/master_rpc.cc
Adar Dembo has posted comments on this change.
Change subject: Move 'master_rpc.h' into the client/ module
..
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/5864/1//COMMIT_MSG
Commit Message:
Line 7: Move
Adar Dembo has posted comments on this change.
Change subject: client: rename various function calls and classes to
ConnectToCluster
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/5868
To
1 - 100 of 7936 matches
Mail list logo
