[kudu-CR] docs: design for handling permanent master failures

2016-07-26 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: docs: design for handling permanent master failures .. Patch Set 2: The doc has been changed significantly. The "real" approach now requires DNS cnames and thus

[kudu-CR] docs: design for handling permanent master failures

2016-07-26 Thread Adar Dembo (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3393 to look at the new patch set (#3). Change subject: docs: design for handling permanent master failures .. docs:

[kudu-CR] docs: design for handling permanent master failures

2016-07-26 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: docs: design for handling permanent master failures .. Patch Set 2: (3 comments)

[kudu-CR] KUDU-526: use on-disk cmeta when loading existing master state

2016-07-26 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-526: use on-disk cmeta when loading existing master state .. Patch Set 2: Verified+1 Overriding Jenkins, the isolate server died mid-run and several tests

[kudu-CR] C++ client: deprecating KuduPartialRow::SetString()

2016-07-21 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: C++ client: deprecating KuduPartialRow::SetString() .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/3723/1/src/kudu/client/stubs.h File

[kudu-CR] KUDU-1538: prevent block ID reuse to avoid potential data loss

2016-07-21 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-1538: prevent block ID reuse to avoid potential data loss .. Patch Set 2: (3 comments) Seems like the path of least resistance. I was inclined to vote for

[kudu-CR] remote bootstrap client: mild API changes

2016-07-28 Thread Adar Dembo (Code Review)
Adar Dembo has uploaded a new change for review. http://gerrit.cloudera.org:8080/3811 Change subject: remote_bootstrap_client: mild API changes .. remote_bootstrap_client: mild API changes 1. I removed the uuid argument from

[kudu-CR] external mini cluster: adjust single master data directory

2016-07-28 Thread Adar Dembo (Code Review)
Adar Dembo has uploaded a new change for review. http://gerrit.cloudera.org:8080/3810 Change subject: external_mini_cluster: adjust single master data directory .. external_mini_cluster: adjust single master data directory

[kudu-CR] build-and-test: also clean up old failsafe reports

2016-07-28 Thread Adar Dembo (Code Review)
Adar Dembo has uploaded a new change for review. http://gerrit.cloudera.org:8080/3812 Change subject: build-and-test: also clean up old failsafe reports .. build-and-test: also clean up old failsafe reports With failsafe is

[kudu-CR] KUDU-1358 (part 3): new multi-master stress test

2016-07-31 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-1358 (part 3): new multi-master stress test .. Patch Set 13: > have you looped this one? Also, Dan, any further comments? Yes, I did quite a few 1000 run

[kudu-CR] remote bootstrap client: mild API changes

2016-08-02 Thread Adar Dembo (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3811 to look at the new patch set (#4). Change subject: remote_bootstrap_client: mild API changes ..

[kudu-CR] c++ client: remove unnecessary code

2016-08-02 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: c++ client: remove unnecessary code .. Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/3809/3/src/kudu/client/client-internal.cc File

[kudu-CR] docs: design for handling permanent master failures

2016-08-02 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: docs: design for handling permanent master failures .. Patch Set 3: (3 comments)

[kudu-CR] [util] fixed build on MacOS X

2016-08-02 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: [util] fixed build on MacOS X .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/3836/1/src/kudu/util/CMakeLists.txt File

[kudu-CR] alter table-randomized-test: increase write timeout

2016-08-01 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. Change subject: alter_table-randomized-test: increase write timeout .. alter_table-randomized-test: increase write timeout The timeout was being hit when election cycles

[kudu-CR] push to asf.py: update repo URL

2016-08-01 Thread Adar Dembo (Code Review)
Hello Mike Percy, Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/3826 to review the following change. Change subject: push_to_asf.py: update repo URL .. push_to_asf.py: update

[kudu-CR] KUDU-1474: single to multi-master deployment migration

2016-08-10 Thread Adar Dembo (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3880 to look at the new patch set (#4). Change subject: KUDU-1474: single to multi-master deployment migration ..

[kudu-CR] fs tool: improve format for dumping a rowset

2016-08-11 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: fs_tool: improve format for dumping a rowset .. Patch Set 1: Given that the tool will now take a different code path entirely, could you amend the commit message

[kudu-CR] [java client] Support add/remove partition

2016-08-09 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: [java client] Support add/remove partition .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3854 To unsubscribe, visit

[kudu-CR] Memory tracking for result tracker

2016-08-10 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Memory tracking for result tracker .. Patch Set 19: (1 comment) http://gerrit.cloudera.org:8080/#/c/3627/19/src/kudu/rpc/result_tracker.h File

[kudu-CR] Reorganize range partition client API

2016-08-10 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Reorganize range partition client API .. Patch Set 3: (14 comments) http://gerrit.cloudera.org:8080/#/c/3882/3/src/kudu/client/client-test.cc File

[kudu-CR] Fix bug in partition key debug printing

2016-08-09 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Fix bug in partition key debug printing .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3879 To unsubscribe, visit

[kudu-CR] Fix bug in partition key debug printing

2016-08-09 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Fix bug in partition key debug printing .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3879 To unsubscribe, visit

[kudu-CR] Add table id to AlterTableResponsePB

2016-08-09 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Add table id to AlterTableResponsePB .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3859 To unsubscribe, visit

[kudu-CR] Add table id to AlterTableResponsePB

2016-08-09 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Add table id to AlterTableResponsePB .. Patch Set 3: Code-Review+2 (1 comment)

[kudu-CR] Fix bug in partition key debug printing

2016-08-09 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Fix bug in partition key debug printing .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3879 To unsubscribe, visit

[kudu-CR] KUDU-1474: single to multi-master deployment migration

2016-08-09 Thread Adar Dembo (Code Review)
Hello Mike Percy, Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/3880 to review the following change. Change subject: KUDU-1474: single to multi-master deployment migration ..

[kudu-CR] [util] fixed build on MacOS X

2016-08-03 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. Change subject: [util] fixed build on MacOS X .. [util] fixed build on MacOS X This is a follow-up for a9265d92424dc305c480d6c44d006b8545bd2227. Change-Id:

[kudu-CR] [util] fixed build on MacOS X

2016-08-03 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: [util] fixed build on MacOS X .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3836 To unsubscribe, visit

[kudu-CR] KUDU-236. Implement tablet history GC

2016-08-14 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-236. Implement tablet history GC .. Patch Set 11: Could you also add a GCing thread to mt-tablet-test? It's a good way to test interactions between

[kudu-CR] KUDU-1474: single to multi-master deployment migration

2016-08-14 Thread Adar Dembo (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3880 to look at the new patch set (#6). Change subject: KUDU-1474: single to multi-master deployment migration ..

[kudu-CR] integration tests: end-to-end master permanent failure test

2016-08-14 Thread Adar Dembo (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3969 to look at the new patch set (#2). Change subject: integration_tests: end-to-end master permanent failure test ..

[kudu-CR] KUDU-236. Implement tablet history GC

2016-08-14 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-236. Implement tablet history GC .. Patch Set 11: (1 comment) Just passing through with a question.

[kudu-CR] KUDU-526: use on-disk cmeta when loading existing master state

2016-08-15 Thread Adar Dembo (Code Review)
Hello Mike Percy, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3786 to look at the new patch set (#5). Change subject: KUDU-526: use on-disk cmeta when loading existing master state

[kudu-CR] Replace gscoped ptr with unique ptr for ConsensusMetadata

2016-08-15 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. Change subject: Replace gscoped_ptr with unique_ptr for ConsensusMetadata .. Replace gscoped_ptr with unique_ptr for ConsensusMetadata Change-Id:

[kudu-CR] KUDU-526: use on-disk cmeta when loading existing master state

2016-08-14 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-526: use on-disk cmeta when loading existing master state .. Patch Set 3: (1 comment)

[kudu-CR] monotime: remove granularity argument

2016-08-13 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: monotime: remove granularity argument .. Patch Set 1: Code-Review+2 Personally, I'm fine with the outright removal. -- To view, visit

[kudu-CR] Memory tracking for result tracker

2016-08-13 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Memory tracking for result tracker .. Patch Set 20: (3 comments) http://gerrit.cloudera.org:8080/#/c/3627/19/src/kudu/rpc/result_tracker.cc File

[kudu-CR] Reorganize range partition client API

2016-08-13 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Reorganize range partition client API .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3882 To unsubscribe, visit

[kudu-CR] KUDU-1474: single to multi-master deployment migration

2016-08-13 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-1474: single to multi-master deployment migration .. Patch Set 4: (32 comments)

[kudu-CR] KUDU-1559. Fix block manager metric for aborted blocks

2016-08-13 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-1559. Fix block manager metric for aborted blocks .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3964 To unsubscribe, visit

[kudu-CR] [java-client] Reorganize range partition client API

2016-08-13 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: [java-client] Reorganize range partition client API .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3958 To unsubscribe, visit

[kudu-CR] KUDU-1474: single to multi-master deployment migration

2016-08-13 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-1474: single to multi-master deployment migration .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/3880/4/src/kudu/master/sys_catalog.h File

[kudu-CR] KUDU-1474: single to multi-master deployment migration

2016-08-13 Thread Adar Dembo (Code Review)
Hello Dan Burkert, Todd Lipcon, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3880 to look at the new patch set (#5). Change subject: KUDU-1474: single to multi-master deployment migration

[kudu-CR] Replace gscoped ptr with unique ptr for ConsensusMetadata

2016-08-13 Thread Adar Dembo (Code Review)
Hello Dan Burkert, Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/3967 to review the following change. Change subject: Replace gscoped_ptr with unique_ptr for ConsensusMetadata

[kudu-CR] integration tests: end-to-end master permanent failure test

2016-08-13 Thread Adar Dembo (Code Review)
Hello Dan Burkert, Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/3969 to review the following change. Change subject: integration_tests: end-to-end master permanent failure test

[kudu-CR] fs: allow format with arbitrary uuid

2016-08-13 Thread Adar Dembo (Code Review)
Hello Dan Burkert, Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/3968 to review the following change. Change subject: fs: allow format with arbitrary uuid .. fs: allow format

[kudu-CR] test result server: improve indexes, add sorting

2016-08-10 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: test_result_server: improve indexes, add sorting .. Patch Set 1: Code-Review+2 (1 comment)

[kudu-CR] master: additional leader lock assertions in catalog manager

2016-08-04 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: master: additional leader lock assertions in catalog manager .. Patch Set 5: (4 comments)

[kudu-CR] remote bootstrap client: mild API changes

2016-08-04 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. Change subject: remote_bootstrap_client: mild API changes .. remote_bootstrap_client: mild API changes 1. I removed the uuid argument from the constructor; it's always

[kudu-CR] master: additional leader lock assertions in catalog manager

2016-08-04 Thread Adar Dembo (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3684 to look at the new patch set (#6). Change subject: master: additional leader lock assertions in catalog manager ..

[kudu-CR] KUDU-526: use on-disk cmeta when loading existing master state

2016-08-04 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-526: use on-disk cmeta when loading existing master state .. Patch Set 3: (1 comment)

[kudu-CR] [java-client] Re-enable multi-master tests

2016-08-04 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: [java-client] Re-enable multi-master tests .. Patch Set 4: > Oh, apparently it needs a manual rebase (I guess due to the package > change) Yeah, I'll take care

[kudu-CR] Fix remaining instance of kududb package in docs

2016-08-05 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Fix remaining instance of kududb package in docs .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3844 To unsubscribe, visit

[kudu-CR] [flume] fix import of shaded guava class

2016-08-05 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: [flume] fix import of shaded guava class .. Patch Set 1: Code-Review+2 How did you spot this? -- To view, visit http://gerrit.cloudera.org:8080/3845 To

[kudu-CR] heartbeater: slight fixes to backoff behavior

2016-08-05 Thread Adar Dembo (Code Review)
Hello Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/3847 to review the following change. Change subject: heartbeater: slight fixes to backoff behavior .. heartbeater: slight

[kudu-CR] [java client] Upgrade hadoop-client to 2.7.2

2016-08-05 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. Change subject: [java client] Upgrade hadoop-client to 2.7.2 .. [java client] Upgrade hadoop-client to 2.7.2 With the old version, I was hitting HADOOP-10961 when running

[kudu-CR] [C++ client] doxygenized all C++ client API

2016-08-05 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: [C++ client] doxygenized all C++ client API .. Patch Set 2: (86 comments) Looks like client_samples-test failed, btw.

[kudu-CR] [java-client] Re-enable multi-master tests

2016-08-05 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. Change subject: [java-client] Re-enable multi-master tests .. [java-client] Re-enable multi-master tests This patch makes TestMasterFailover useful again. It also adds

[kudu-CR](gh-pages) Add weekly update for 8/8

2016-08-08 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Add weekly update for 8/8 .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/3864/1/_posts/2016-08-08-weekly-update.md File

[kudu-CR](gh-pages) Add weekly update for 8/8

2016-08-08 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Add weekly update for 8/8 .. Patch Set 2: Code-Review+2 Glad I noticed the more important error. -- To view, visit http://gerrit.cloudera.org:8080/3864 To

[kudu-CR] Upgrade to NVML 1.1

2016-08-08 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Upgrade to NVML 1.1 .. Patch Set 1: Code-Review+2 What's the motivation? Get off a beta release? -- To view, visit http://gerrit.cloudera.org:8080/3866 To

[kudu-CR] [java client] Support add/remove partition

2016-08-08 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: [java client] Support add/remove partition .. Patch Set 1: (18 comments)

[kudu-CR] [C++ client] doxygenized all C++ client API

2016-08-08 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: [C++ client] doxygenized all C++ client API .. Patch Set 4: (4 comments) http://gerrit.cloudera.org:8080/#/c/3840/2/src/kudu/client/callbacks.h File

[kudu-CR] [java-client] Re-enable multi-master tests

2016-08-05 Thread Adar Dembo (Code Review)
Hello Dan Burkert, Jean-Daniel Cryans, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3654 to look at the new patch set (#5). Change subject: [java-client] Re-enable multi-master tests ..

[kudu-CR] [java client] Upgrade hadoop-client to 2.7.2

2016-08-05 Thread Adar Dembo (Code Review)
Hello Dan Burkert, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/3849 to review the following change. Change subject: [java client] Upgrade hadoop-client to 2.7.2 .. [java client] Upgrade

[kudu-CR] [C++ client] doxygenized all C++ client API

2016-08-08 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: [C++ client] doxygenized all C++ client API .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3840 To unsubscribe, visit

[kudu-CR] [doxygen] made DESTDIR applicable for ninja builds

2016-08-01 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. Change subject: [doxygen] made DESTDIR applicable for ninja builds .. [doxygen] made DESTDIR applicable for ninja builds Moved the DESTDIR parameter into the environment

[kudu-CR] push to asf.py: update repo URL

2016-08-01 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: push_to_asf.py: update repo URL .. Patch Set 1: > Guess we should send an email to dev@ so everyone can change their > own apache remotes, too? Sounds like a job

[kudu-CR] [doxygen] made DESTDIR applicable for ninja builds

2016-08-01 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: [doxygen] made DESTDIR applicable for ninja builds .. Patch Set 1: Code-Review+2 Looks good provided you've tested it with both make and ninja. -- To view, visit

[kudu-CR](gh-pages) site tool: update repository URLs

2016-08-01 Thread Adar Dembo (Code Review)
Hello Mike Percy, Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/3827 to review the following change. Change subject: site_tool: update repository URLs .. site_tool: update

[kudu-CR] push to asf.py: update repo URL

2016-08-01 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. Change subject: push_to_asf.py: update repo URL .. push_to_asf.py: update repo URL Change-Id: Ibabca8039d4c749c05ab789959e04aab69d15223 Reviewed-on:

[kudu-CR] push to asf.py: update repo URL

2016-08-01 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: push_to_asf.py: update repo URL .. Patch Set 1: Verified+1 Failure in AlterTableRandomizedTest, definitely unrelated to this patch. -- To view, visit

[kudu-CR] Fix block manager-test running in some builds

2016-08-02 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Fix block_manager-test running in some builds .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3733 To unsubscribe, visit

[kudu-CR] Fix block manager-test running in some builds

2016-08-02 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. Change subject: Fix block_manager-test running in some builds .. Fix block_manager-test running in some builds Even though the patch for KUDU-1538 passed pre-commit, it

[kudu-CR] external mini cluster: adjust single master data directory

2016-08-02 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. Change subject: external_mini_cluster: adjust single master data directory .. external_mini_cluster: adjust single master data directory If we stored single master data

[kudu-CR] c++ client: remove unnecessary code

2016-08-02 Thread Adar Dembo (Code Review)
Hello Todd Lipcon, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3809 to look at the new patch set (#3). Change subject: c++ client: remove unnecessary code .. c++ client:

[kudu-CR] master: additional leader lock assertions in catalog manager

2016-08-02 Thread Adar Dembo (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3684 to look at the new patch set (#5). Change subject: master: additional leader lock assertions in catalog manager ..

[kudu-CR] remote bootstrap client: mild API changes

2016-08-02 Thread Adar Dembo (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3811 to look at the new patch set (#3). Change subject: remote_bootstrap_client: mild API changes ..

[kudu-CR] c++ client: remove unnecessary code

2016-08-02 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: c++ client: remove unnecessary code .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/3809/2/src/kudu/client/client-internal.cc File

[kudu-CR] [java client] Support add/remove partition

2016-08-09 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: [java client] Support add/remove partition .. Patch Set 2: (12 comments)

[kudu-CR] cfile-test: some test micro-optimization to avoid timeouts

2016-08-09 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: cfile-test: some test micro-optimization to avoid timeouts .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/3875/1//COMMIT_MSG Commit Message:

[kudu-CR] remote bootstrap client: mild API changes

2016-08-02 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: remote_bootstrap_client: mild API changes .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/3811/3//COMMIT_MSG Commit Message: Line 15:logging,

[kudu-CR] catalog manager: avoid race in InitSysCatalogAsync() and GetTabletPeer()

2016-08-16 Thread Adar Dembo (Code Review)
Hello Todd Lipcon, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3997 to look at the new patch set (#2). Change subject: catalog_manager: avoid race in InitSysCatalogAsync() and GetTabletPeer()

[kudu-CR] mini cluster: avoid SIGSEGV when master fails to start up

2016-08-16 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. Change subject: mini_cluster: avoid SIGSEGV when master fails to start up .. mini_cluster: avoid SIGSEGV when master fails to start up My machine's clock became

[kudu-CR] catalog manager: avoid race in InitSysCatalogAsync() and GetTabletPeer()

2016-08-16 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. Change subject: catalog_manager: avoid race in InitSysCatalogAsync() and GetTabletPeer() .. catalog_manager: avoid race in InitSysCatalogAsync() and GetTabletPeer()

[kudu-CR] Fix ScanToken generation with non-covering range partitions

2016-08-16 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Fix ScanToken generation with non-covering range partitions .. Patch Set 1: Code-Review+2 Would be nice to consolidate that code, but I don't see an easy way to do

[kudu-CR] catalog manager: avoid more races between Init() and GetTabletPeer()

2016-08-16 Thread Adar Dembo (Code Review)
Adar Dembo has abandoned this change. Change subject: catalog_manager: avoid more races between Init() and GetTabletPeer() .. Abandoned After some more digging, it appears the race is between Shutdown() and an RPC in

[kudu-CR] Add time/watermark based garbage collection to ResultTracker

2016-08-15 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Add time/watermark based garbage collection to ResultTracker .. Patch Set 18: Code-Review+2 (1 comment)

[kudu-CR] [util/monotime] added handy operators for MonoTime

2016-08-16 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: [util/monotime] added handy operators for MonoTime .. Patch Set 1: (12 comments) Is the use case for these guys very compelling? Although the Google style guide

[kudu-CR] tool: rewrite parser logic

2016-08-15 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: tool: rewrite parser logic .. Patch Set 3: > looks good but the patch it's based on seems to have exploded. Yeah, I rebased to switch the order around. And I

[kudu-CR] Start a background thread to run ResultTracker GC

2016-08-15 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Start a background thread to run ResultTracker GC .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/3961/3/src/kudu/rpc/result_tracker.cc File

[kudu-CR] Memory tracking for result tracker

2016-08-15 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Memory tracking for result tracker .. Patch Set 21: Code-Review+2 (2 comments) http://gerrit.cloudera.org:8080/#/c/3627/19/src/kudu/rpc/result_tracker.cc File

[kudu-CR] Start a background thread to run ResultTracker GC

2016-08-15 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Start a background thread to run ResultTracker GC .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/3961/3/src/kudu/rpc/result_tracker.cc File

[kudu-CR] catalog manager: avoid more races between Init() and GetTabletPeer()

2016-08-16 Thread Adar Dembo (Code Review)
Adar Dembo has restored this change. Change subject: catalog_manager: avoid more races between Init() and GetTabletPeer() .. Restored I found a way to hack through this. -- To view, visit

[kudu-CR](gh-pages) Add weekly update for 8/16

2016-08-16 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Add weekly update for 8/16 .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4008 To unsubscribe, visit

[kudu-CR] Enable replay cache by default

2016-08-16 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Enable replay cache by default .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4002 To unsubscribe, visit

[kudu-CR] KUDU-236 (part 1). Implement tablet history GC

2016-08-15 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-236 (part 1). Implement tablet history GC .. Patch Set 14: > > Could you also add a GCing thread to mt-tablet-test? It's a good > > way to test interactions

[kudu-CR] docs: design for handling permanent master failures

2016-08-16 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: docs: design for handling permanent master failures .. Patch Set 4: (1 comment)

[kudu-CR] [c++-client] fix KuduScanTokenBuilder token generation bugs

2016-08-16 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: [c++-client] fix KuduScanTokenBuilder token generation bugs .. Patch Set 2: (3 comments)

  1   2   3   4   5   6   7   8   9   10   >