[kudu-CR] increase table locations-itest timeout

2016-06-02 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: increase table_locations-itest timeout .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3287 To unsubscribe, visit

[kudu-CR] Avoid missing 'override' keyword warnings in raft consensus-test.cc

2016-06-02 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Avoid missing 'override' keyword warnings in raft_consensus-test.cc .. Patch Set 1: (1 comment)

[kudu-CR] Don't default 'request' to null in WriteTransactionState's ctor

2016-06-02 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Don't default 'request' to null in WriteTransactionState's ctor .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3290 To

[kudu-CR] KUDU-1308 [c++-client]: support tables with non-covering range partitions

2016-06-02 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-1308 [c++-client]: support tables with non-covering range partitions .. Patch Set 4: (1 comment)

[kudu-CR] KUDU-1473: fix some tablet lock usage in CatalogManager

2016-06-08 Thread Adar Dembo (Code Review)
Adar Dembo has uploaded a new patch set (#6). Change subject: KUDU-1473: fix some tablet lock usage in CatalogManager .. KUDU-1473: fix some tablet lock usage in CatalogManager This was probably due to the refactoring done in

[kudu-CR] KUDU-1473: fix some tablet lock usage in CatalogManager

2016-06-08 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-1473: fix some tablet lock usage in CatalogManager .. Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/3309/5//COMMIT_MSG Commit Message: PS5,

[kudu-CR] KUDU-1353: remove per-tablet replica locations cache

2016-06-08 Thread Adar Dembo (Code Review)
Hello Jean-Daniel Cryans, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/2887 to look at the new patch set (#11). Change subject: KUDU-1353: remove per-tablet replica locations cache ..

[kudu-CR] WIP: KUDU-1466: improve error message when writes fail at TS

2016-06-07 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: WIP: KUDU-1466: improve error message when writes fail at TS .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/3326/1//COMMIT_MSG Commit Message:

[kudu-CR] ts itest-base.h: wait for bootstrapping to finish when waiting for replicas

2016-06-07 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: ts_itest-base.h: wait for bootstrapping to finish when waiting for replicas .. Patch Set 3: Verified+1 Overriding Jenkins, the one failure is a flaky test fixed

[kudu-CR] KUDU-1353: remove per-tablet replica locations cache

2016-06-07 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-1353: remove per-tablet replica locations cache .. Patch Set 10: Verified+1 Overriding Jenkins, the one failure was a Java test (testDisconnect) in TSAN

[kudu-CR] KUDU-1473: fix some tablet lock usage in CatalogManager

2016-06-07 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-1473: fix some tablet lock usage in CatalogManager .. Patch Set 5: Verified+1 Overriding Jenkins, the one failure was a Java test (testDisconnect) in TSAN

[kudu-CR] KUDU-1473: fix some tablet lock usage in CatalogManager

2016-06-07 Thread Adar Dembo (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3309 to look at the new patch set (#4). Change subject: KUDU-1473: fix some tablet lock usage in CatalogManager ..

[kudu-CR] update dist-test configuration for new client.py location

2016-06-07 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: update dist-test configuration for new client.py location .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3332 To unsubscribe,

[kudu-CR] KUDU-1363: Add in-list predicates for extracting a set of equalities.

2016-06-07 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-1363: Add in-list predicates for extracting a set of equalities. .. Patch Set 5: (20 comments) OK, finished reviewing everything except some of the hairier

[kudu-CR] KUDU-1473: fix some tablet lock usage in CatalogManager

2016-06-07 Thread Adar Dembo (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3309 to look at the new patch set (#5). Change subject: KUDU-1473: fix some tablet lock usage in CatalogManager ..

[kudu-CR] KUDU-1353: remove per-tablet replica locations cache

2016-06-07 Thread Adar Dembo (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/2887 to look at the new patch set (#10). Change subject: KUDU-1353: remove per-tablet replica locations cache ..

[kudu-CR] KUDU-1353: remove per-tablet replica locations cache

2016-06-07 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-1353: remove per-tablet replica locations cache .. Patch Set 9: (1 comment)

[kudu-CR] KUDU-1353: remove per-tablet replica locations cache

2016-06-07 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-1353: remove per-tablet replica locations cache .. Patch Set 8: (2 comments) http://gerrit.cloudera.org:8080/#/c/2887/8/src/kudu/master/catalog_manager.cc

[kudu-CR] KUDU-1353: remove per-tablet replica locations cache

2016-06-07 Thread Adar Dembo (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/2887 to look at the new patch set (#9). Change subject: KUDU-1353: remove per-tablet replica locations cache ..

[kudu-CR] [java client] fix reruns of TestKuduTable.testGetLocations

2016-06-07 Thread Adar Dembo (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3319 to look at the new patch set (#3). Change subject: [java client] fix reruns of TestKuduTable.testGetLocations ..

[kudu-CR] KUDU-1473: fix some tablet lock usage in CatalogManager

2016-06-07 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-1473: fix some tablet lock usage in CatalogManager .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/3309/2//COMMIT_MSG Commit Message: Line

[kudu-CR] [java client] fix reruns of TestKuduTable.testGetLocations

2016-06-06 Thread Adar Dembo (Code Review)
Hello Dan Burkert, Jean-Daniel Cryans, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/3319 to review the following change. Change subject: [java client] fix reruns of TestKuduTable.testGetLocations

[kudu-CR] [java client] Fix a race in TabletClient cleanup

2016-06-10 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: [java client] Fix a race in TabletClient cleanup .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3340 To unsubscribe, visit

[kudu-CR] [java client] Fix a race in TabletClient cleanup

2016-06-10 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. Change subject: [java client] Fix a race in TabletClient cleanup .. [java client] Fix a race in TabletClient cleanup Dan noticed some weird things going on after fixing

[kudu-CR] Do not run (g)addr2line translator on MacOS X

2016-06-10 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Do not run (g)addr2line translator on MacOS X .. Patch Set 2: Code-Review+1 Thanks for making those changes. Looks good to me, though ultimately I'll defer to

[kudu-CR] KUDU-1353: remove per-tablet replica locations cache

2016-06-09 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-1353: remove per-tablet replica locations cache .. Patch Set 11: Another testDisconnect Java failure. -- To view, visit http://gerrit.cloudera.org:8080/2887

[kudu-CR] KUDU-1473: fix some tablet lock usage in CatalogManager

2016-06-09 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-1473: fix some tablet lock usage in CatalogManager .. Patch Set 6: Verified+1 Another Java testDisconnect failure. -- To view, visit

[kudu-CR] Update documentation

2016-06-09 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Update documentation .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3351 To unsubscribe, visit

[kudu-CR] Always write last known addr into ConsensusMetadata

2016-06-09 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Always write last_known_addr into ConsensusMetadata .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/3349/1/src/kudu/master/sys_catalog.cc File

[kudu-CR] create-demo-table must specify parition columns

2016-06-10 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: create-demo-table must specify parition columns .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/3368/1//COMMIT_MSG Commit Message: PS1, Line 7:

[kudu-CR] create-demo-table must specify partition columns

2016-06-10 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: create-demo-table must specify partition columns .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3368 To unsubscribe, visit

[kudu-CR] KUDU-1363: Add in-list predicates for extracting a set of equalities.

2016-06-09 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-1363: Add in-list predicates for extracting a set of equalities. .. Patch Set 7: > The main reason for not using unordered_set was because the > collection

[kudu-CR] KUDU-1363: Add in-list predicates for extracting a set of equalities.

2016-06-09 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-1363: Add in-list predicates for extracting a set of equalities. .. Patch Set 6: (5 comments) Did you see my high-level comment about std::unordered_set vs.

[kudu-CR] [java client] Fix a race in TabletClient cleanup

2016-06-09 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: [java client] Fix a race in TabletClient cleanup .. Patch Set 2: (3 comments)

[kudu-CR](gh-pages) Blog post for 0.9.0 release

2016-06-09 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Blog post for 0.9.0 release .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/3357/1/_posts/2016-06-10-apache-kudu-0-9-0-released.md File

[kudu-CR](gh-pages) Add 0.9.0 release and refresh docs

2016-06-09 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Add 0.9.0 release and refresh docs .. Patch Set 1: Code-Review+2 (shipit) -- To view, visit http://gerrit.cloudera.org:8080/3355 To unsubscribe, visit

[kudu-CR](gh-pages) Blog post for 0.9.0 release

2016-06-09 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Blog post for 0.9.0 release .. Patch Set 2: Code-Review+2 (shipit) -- To view, visit http://gerrit.cloudera.org:8080/3357 To unsubscribe, visit

[kudu-CR] KUDU-1473: fix some tablet lock usage in CatalogManager

2016-06-09 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. Change subject: KUDU-1473: fix some tablet lock usage in CatalogManager .. KUDU-1473: fix some tablet lock usage in CatalogManager This was probably due to the

[kudu-CR] KUDU-1473: fix some tablet lock usage in CatalogManager

2016-06-09 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-1473: fix some tablet lock usage in CatalogManager .. Patch Set 7: Verified+1 Overriding Jenkins, another Java testDisconnect failure. -- To view, visit

[kudu-CR] Do not run (g)addr2line translator on MacOS X

2016-06-09 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Do not run (g)addr2line translator on MacOS X .. Patch Set 1: (2 comments) My understanding is that sanitizer-enabled Kudu builds on Mac OS will report correct

[kudu-CR] kudu-1475: set is is initialized to false in log pre-allocated case

2016-06-03 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: kudu-1475: set is is_initialized_ to false in log pre-allocated case .. Patch Set 3: (1 comment) BTW, your tests are failing because this patch is based on one

[kudu-CR] KUDU-1473: fix some tablet lock usage in CatalogManager

2016-06-03 Thread Adar Dembo (Code Review)
Hello Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/3309 to review the following change. Change subject: KUDU-1473: fix some tablet lock usage in CatalogManager .. KUDU-1473:

[kudu-CR] ts itest-base.h: wait for bootstrapping to finish when waiting for replicas

2016-06-03 Thread Adar Dembo (Code Review)
Hello Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/3308 to review the following change. Change subject: ts_itest-base.h: wait for bootstrapping to finish when waiting for replicas

[kudu-CR] KUDU-1353: remove per-tablet replica locations cache

2016-06-03 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-1353: remove per-tablet replica locations cache .. Patch Set 7: I've rebased this on top of a new patch that should fix the test failures I mentioned

[kudu-CR] Update Java client for new master GetTableLocations semantics

2016-06-03 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Update Java client for new master GetTableLocations semantics .. Patch Set 1: (1 comment) It would be great if we could test the modified code paths.

[kudu-CR] KUDU-1267: Calling getString() on RowResult for wrong type gave weird exception

2016-05-25 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-1267: Calling getString() on RowResult for wrong type gave weird exception .. Patch Set 6: Ted, your patch still isn't compiling. Take a look at the latest

[kudu-CR] Remove default table partitioning

2016-05-25 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Remove default table partitioning .. Patch Set 11: Python tests are still broken, and it looks like there's an RpcBenchmark failure too? Oh, and I think you

[kudu-CR] KUDU-749 (part 2): avoid O(n^2) behavior when compacting deltas

2016-05-25 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-749 (part 2): avoid O(n^2) behavior when compacting deltas .. Patch Set 2: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/3221/2//COMMIT_MSG

[kudu-CR] ts itest-base.h: wait for bootstrapping to finish when waiting for replicas

2016-06-06 Thread Adar Dembo (Code Review)
Adar Dembo has uploaded a new patch set (#2). Change subject: ts_itest-base.h: wait for bootstrapping to finish when waiting for replicas .. ts_itest-base.h: wait for bootstrapping to finish when waiting for replicas

[kudu-CR] ts itest-base.h: wait for bootstrapping to finish when waiting for replicas

2016-06-06 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: ts_itest-base.h: wait for bootstrapping to finish when waiting for replicas .. Patch Set 1: (3 comments)

[kudu-CR] Don't use InMemoryEnv in deltafile-test

2016-05-28 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Don't use InMemoryEnv in deltafile-test .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3235 To unsubscribe, visit

[kudu-CR] log: Mark allocation finished even if allocation had an error

2016-05-27 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: log: Mark allocation finished even if allocation had an error .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/3234/1/src/kudu/consensus/log.cc

[kudu-CR] Allow for reserving disk space for non-Kudu processes

2016-05-27 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Allow for reserving disk space for non-Kudu processes .. Patch Set 4: (4 comments) http://gerrit.cloudera.org:8080/#/c/3135/4//COMMIT_MSG Commit Message: Line

[kudu-CR] KUDU-1307 [master] support tables with range partition bounds

2016-05-31 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-1307 [master] support tables with range partition bounds .. Patch Set 12: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/2806 To

[kudu-CR] Specify guaranteed semantics of GetTableLocations RPC

2016-05-31 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Specify guaranteed semantics of GetTableLocations RPC .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3240 To unsubscribe, visit

[kudu-CR] fix compile error when compiling column_predicate-test.cc

2016-05-31 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: fix compile error when compiling column_predicate-test.cc .. Patch Set 8: (2 comments) http://gerrit.cloudera.org:8080/#/c/3233/8//COMMIT_MSG Commit Message:

[kudu-CR] KUDU-1267: Calling getString() on RowResult for wrong type gave weird exception

2016-05-25 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. Change subject: KUDU-1267: Calling getString() on RowResult for wrong type gave weird exception .. KUDU-1267: Calling getString() on RowResult for wrong type gave weird

[kudu-CR] Make BuildLog() return Status

2016-05-27 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Make BuildLog() return Status .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3134 To unsubscribe, visit

[kudu-CR] Allow for reserving disk space for non-Kudu processes

2016-05-27 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Allow for reserving disk space for non-Kudu processes .. Patch Set 4: (16 comments) I reviewed everything but the LBM changes. I've indicated enough high-level

[kudu-CR] KUDU-1307 [master] support tables with range partition bounds

2016-05-27 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-1307 [master] support tables with range partition bounds .. Patch Set 11: (1 comment)

[kudu-CR] Specify guaranteed semantics of GetTableLocations RPC

2016-05-27 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Specify guaranteed semantics of GetTableLocations RPC .. Patch Set 1: (2 comments) Would be nice to see a test (perhaps in master-test) for the new semantics.

[kudu-CR] Don't use InMemoryEnv in deltafile-test

2016-05-27 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Don't use InMemoryEnv in deltafile-test .. Patch Set 1: (1 comment) Sure. I never cared much for MemEnv; more hassle than good, I think. The test doesn't get

[kudu-CR] Remove last two usages of MemEnv in tests

2016-05-31 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Remove last two usages of MemEnv in tests .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3257 To unsubscribe, visit

[kudu-CR] Remove InMemoryEnv completely

2016-05-31 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Remove InMemoryEnv completely .. Patch Set 1: > There are no mentions of MemEnv or InMemoryEnv anywhere else in the code base > that I could find. I found a

[kudu-CR] Remove InMemoryEnv completely

2016-05-31 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Remove InMemoryEnv completely .. Patch Set 1: I think memenv would have been useful had we ever used it in non-trivial tests (i.e. tests that perform real I/O).

[kudu-CR] Replace uses of boost::thread with std::thread

2016-05-31 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Replace uses of boost::thread with std::thread .. Patch Set 14: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/1868 To unsubscribe, visit

[kudu-CR] Remove InMemoryEnv completely

2016-05-31 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Remove InMemoryEnv completely .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3258 To unsubscribe, visit

[kudu-CR] KUDU-1308 [c++-client]: support tables with non-covering range partitions

2016-05-31 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-1308 [c++-client]: support tables with non-covering range partitions .. Patch Set 2: (15 comments) I reviewed everything but the change to

[kudu-CR] Fix reorder warning in TabletMetadata

2016-06-02 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Fix reorder warning in TabletMetadata .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3281 To unsubscribe, visit

[kudu-CR] Improve tpch usability

2016-06-02 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Improve tpch usability .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/3279/2/src/kudu/scripts/tpch.sh File src/kudu/scripts/tpch.sh: Line 129:

[kudu-CR] Improve tpch usability

2016-06-02 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Improve tpch usability .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/3279/1/src/kudu/scripts/tpch.sh File src/kudu/scripts/tpch.sh: Line 70:

[kudu-CR] KUDU-1308 [c++-client]: support tables with non-covering range partitions

2016-06-01 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-1308 [c++-client]: support tables with non-covering range partitions .. Patch Set 2: (4 comments)

[kudu-CR] fix compile error when compiling column_predicate-test.cc

2016-06-01 Thread Adar Dembo (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3233 to look at the new patch set (#10). Change subject: fix compile error when compiling column_predicate-test.cc ..

[kudu-CR] Replace boost::{lock, unique_lock, mutex} with std lib equivalents

2016-06-01 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Replace boost::{lock, unique_lock, mutex} with std lib equivalents .. Patch Set 3: Code-Review+2 (2 comments) Would be nice to add some "using std::lock_guard"

[kudu-CR] Replace kudu::{lock_guard, unique_lock} with std lib equivalents

2016-06-01 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Replace kudu::{lock_guard, unique_lock} with std lib equivalents .. Patch Set 5: I started reviewing, then thought maybe this is the right patch to add "using

[kudu-CR] Replace kudu::{lock_guard, unique_lock} with std lib equivalents

2016-06-01 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Replace kudu::{lock_guard, unique_lock} with std lib equivalents .. Patch Set 7: > Although I'm not overriding Adar's concern, he should chime back > in. I don't

[kudu-CR] Add TableCreator::add_range_split and deprecate TableCreator::split_rows

2016-06-01 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Add TableCreator::add_range_split and deprecate TableCreator::split_rows .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/3275/2//COMMIT_MSG

[kudu-CR] Improve tpch usability

2016-06-01 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Improve tpch usability .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/3279/1/src/kudu/scripts/tpch.sh File src/kudu/scripts/tpch.sh: Line 70:

[kudu-CR] catalog manager: fix a locking error

2016-06-21 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. Change subject: catalog_manager: fix a locking error .. catalog_manager: fix a locking error This lock acquisition took the wrong lock, which meant it didn't add any

[kudu-CR] Integrate the ResultTracker into the rpc subsystem and add a test

2016-06-21 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Integrate the ResultTracker into the rpc subsystem and add a test .. Patch Set 11: (3 comments) http://gerrit.cloudera.org:8080/#/c/3192/6//COMMIT_MSG Commit

[kudu-CR] log: Mark allocation finished even if allocation had an error

2016-06-21 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: log: Mark allocation finished even if allocation had an error .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/3234/1/src/kudu/consensus/log.cc

[kudu-CR] catalog manager: fix a locking brain fart

2016-06-21 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: catalog_manager: fix a locking brain fart .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/3425/1//COMMIT_MSG Commit Message: Line 7:

[kudu-CR] Add additional documentation for bad installation

2016-06-21 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. Change subject: Add additional documentation for bad installation .. Add additional documentation for bad installation Added more to the documentation for botched

[kudu-CR] catalog manager: fix a locking error

2016-06-21 Thread Adar Dembo (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3425 to look at the new patch set (#2). Change subject: catalog_manager: fix a locking error .. catalog_manager: fix a

[kudu-CR] consensus: Crash if we fail to append to the WAL

2016-06-21 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: consensus: Crash if we fail to append to the WAL .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/3406/3/src/kudu/util/status_callback.cc File

[kudu-CR] Update Java client for new master GetTableLocations semantics

2016-06-14 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Update Java client for new master GetTableLocations semantics .. Patch Set 2: (4 comments)

[kudu-CR] Add Raft remote bootstrap design doc

2016-06-16 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Add Raft remote bootstrap design doc .. Patch Set 2: (4 comments) Looks good, just a few formatting nits.

[kudu-CR] Link to raft config change design from design-docs index page

2016-06-16 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Link to raft config change design from design-docs index page .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3394 To unsubscribe,

[kudu-CR] [java-client] use tablet cache for locateTablet calls

2016-06-16 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: [java-client] use tablet cache for locateTablet calls .. Patch Set 4: Code-Review+2 (1 comment) Feel free to punt on the nit if you want to merge right now.

[kudu-CR] docs: informal design for handling permanent master failures

2016-06-17 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: docs: informal design for handling permanent master failures .. Patch Set 1: (15 comments)

[kudu-CR] docs: design for handling permanent master failures

2016-06-17 Thread Adar Dembo (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3393 to look at the new patch set (#2). Change subject: docs: design for handling permanent master failures .. docs:

[kudu-CR] Reformat raft-config-change.md to clean it up

2016-06-17 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Reformat raft-config-change.md to clean it up .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/3399/3/docs/design-docs/raft-config-change.md File

[kudu-CR] Reformat raft-config-change.md to clean it up

2016-06-17 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Reformat raft-config-change.md to clean it up .. Patch Set 3: Code-Review+2 (1 comment)

[kudu-CR] Add Raft remote bootstrap design doc

2016-06-17 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. Change subject: Add Raft remote bootstrap design doc .. Add Raft remote bootstrap design doc This was ported over from a Google doc Change-Id:

[kudu-CR] Add Raft remote bootstrap design doc

2016-06-17 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Add Raft remote bootstrap design doc .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3395 To unsubscribe, visit

[kudu-CR] Mark the Response accessors in transactions/transaction's state const

2016-06-21 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Mark the Response accessors in transactions/transaction's state const .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3419 To

[kudu-CR] Add additional documentation for bad installation

2016-06-21 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Add additional documentation for bad installation .. Patch Set 2: Since you're modifying an asciidoc file, could you generate rendered output too? The easiest way

[kudu-CR] catalog manager: fix a locking brain fart

2016-06-21 Thread Adar Dembo (Code Review)
Hello David Ribeiro Alves, Mike Percy, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/3425 to review the following change. Change subject: catalog_manager: fix a locking brain fart ..

[kudu-CR] build: squelch symbol visibility warnings seen with cmake 3.5

2016-06-17 Thread Adar Dembo (Code Review)
Hello Dan Burkert, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/3405 to review the following change. Change subject: build: squelch symbol visibility warnings seen with cmake 3.5 ..

[kudu-CR] build: squelch symbol visibility warnings seen with cmake 3.5

2016-06-17 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. Change subject: build: squelch symbol visibility warnings seen with cmake 3.5 .. build: squelch symbol visibility warnings seen with cmake 3.5 When building with cmake

  1   2   3   4   >