Adar Dembo has uploaded a new patch set (#6).
Change subject: KUDU-1473: fix some tablet lock usage in CatalogManager
..
KUDU-1473: fix some tablet lock usage in CatalogManager
This was probably due to the refactoring done in
Hello Jean-Daniel Cryans,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/2887
to look at the new patch set (#11).
Change subject: KUDU-1353: remove per-tablet replica locations cache
..
Adar Dembo has posted comments on this change.
Change subject: WIP: KUDU-1466: improve error message when writes fail at TS
..
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/3326/1//COMMIT_MSG
Commit Message:
Adar Dembo has posted comments on this change.
Change subject: KUDU-1353: remove per-tablet replica locations cache
..
Patch Set 10: Verified+1
Overriding Jenkins, the one failure was a Java test (testDisconnect) in TSAN
Adar Dembo has posted comments on this change.
Change subject: KUDU-1473: fix some tablet lock usage in CatalogManager
..
Patch Set 5: Verified+1
Overriding Jenkins, the one failure was a Java test (testDisconnect) in TSAN
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/3309
to look at the new patch set (#4).
Change subject: KUDU-1473: fix some tablet lock usage in CatalogManager
..
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/3309
to look at the new patch set (#5).
Change subject: KUDU-1473: fix some tablet lock usage in CatalogManager
..
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/2887
to look at the new patch set (#10).
Change subject: KUDU-1353: remove per-tablet replica locations cache
..
Adar Dembo has posted comments on this change.
Change subject: KUDU-1353: remove per-tablet replica locations cache
..
Patch Set 9:
(1 comment)
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/3319
to look at the new patch set (#3).
Change subject: [java client] fix reruns of TestKuduTable.testGetLocations
..
Adar Dembo has posted comments on this change.
Change subject: KUDU-1473: fix some tablet lock usage in CatalogManager
..
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/3309/2//COMMIT_MSG
Commit Message:
Line
Hello Dan Burkert, Jean-Daniel Cryans,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/3319
to review the following change.
Change subject: [java client] fix reruns of TestKuduTable.testGetLocations
Adar Dembo has posted comments on this change.
Change subject: [java client] Fix a race in TabletClient cleanup
..
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/3340
To unsubscribe, visit
Adar Dembo has submitted this change and it was merged.
Change subject: [java client] Fix a race in TabletClient cleanup
..
[java client] Fix a race in TabletClient cleanup
Dan noticed some weird things going on after fixing
Adar Dembo has posted comments on this change.
Change subject: Do not run (g)addr2line translator on MacOS X
..
Patch Set 2: Code-Review+1
Thanks for making those changes. Looks good to me, though ultimately I'll defer
to
Adar Dembo has posted comments on this change.
Change subject: KUDU-1353: remove per-tablet replica locations cache
..
Patch Set 11:
Another testDisconnect Java failure.
--
To view, visit http://gerrit.cloudera.org:8080/2887
Adar Dembo has posted comments on this change.
Change subject: KUDU-1473: fix some tablet lock usage in CatalogManager
..
Patch Set 6: Verified+1
Another Java testDisconnect failure.
--
To view, visit
Adar Dembo has posted comments on this change.
Change subject: Update documentation
..
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/3351
To unsubscribe, visit
Adar Dembo has posted comments on this change.
Change subject: Always write last_known_addr into ConsensusMetadata
..
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/3349/1/src/kudu/master/sys_catalog.cc
File
Adar Dembo has posted comments on this change.
Change subject: create-demo-table must specify parition columns
..
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/3368/1//COMMIT_MSG
Commit Message:
PS1, Line 7:
Adar Dembo has posted comments on this change.
Change subject: create-demo-table must specify partition columns
..
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/3368
To unsubscribe, visit
Adar Dembo has posted comments on this change.
Change subject: KUDU-1363: Add in-list predicates for extracting a set of
equalities.
..
Patch Set 7:
> The main reason for not using unordered_set was because the
> collection
Adar Dembo has posted comments on this change.
Change subject: [java client] Fix a race in TabletClient cleanup
..
Patch Set 2:
(3 comments)
Adar Dembo has posted comments on this change.
Change subject: Blog post for 0.9.0 release
..
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/3357/1/_posts/2016-06-10-apache-kudu-0-9-0-released.md
File
Adar Dembo has posted comments on this change.
Change subject: Add 0.9.0 release and refresh docs
..
Patch Set 1: Code-Review+2
(shipit)
--
To view, visit http://gerrit.cloudera.org:8080/3355
To unsubscribe, visit
Adar Dembo has submitted this change and it was merged.
Change subject: KUDU-1473: fix some tablet lock usage in CatalogManager
..
KUDU-1473: fix some tablet lock usage in CatalogManager
This was probably due to the
Adar Dembo has posted comments on this change.
Change subject: Do not run (g)addr2line translator on MacOS X
..
Patch Set 1:
(2 comments)
My understanding is that sanitizer-enabled Kudu builds on Mac OS will report
correct
Adar Dembo has posted comments on this change.
Change subject: kudu-1475: set is is_initialized_ to false in log pre-allocated
case
..
Patch Set 3:
(1 comment)
BTW, your tests are failing because this patch is based on one
Hello Todd Lipcon,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/3309
to review the following change.
Change subject: KUDU-1473: fix some tablet lock usage in CatalogManager
..
KUDU-1473:
Adar Dembo has posted comments on this change.
Change subject: KUDU-1353: remove per-tablet replica locations cache
..
Patch Set 7:
I've rebased this on top of a new patch that should fix the test failures I
mentioned
Adar Dembo has posted comments on this change.
Change subject: Update Java client for new master GetTableLocations semantics
..
Patch Set 1:
(1 comment)
It would be great if we could test the modified code paths.
Adar Dembo has posted comments on this change.
Change subject: KUDU-1267: Calling getString() on RowResult for wrong type gave
weird exception
..
Patch Set 6:
Ted, your patch still isn't compiling. Take a look at the latest
Adar Dembo has posted comments on this change.
Change subject: Remove default table partitioning
..
Patch Set 11:
Python tests are still broken, and it looks like there's an RpcBenchmark
failure too?
Oh, and I think you
Adar Dembo has uploaded a new patch set (#2).
Change subject: ts_itest-base.h: wait for bootstrapping to finish when waiting
for replicas
..
ts_itest-base.h: wait for bootstrapping to finish when waiting for replicas
Adar Dembo has posted comments on this change.
Change subject: ts_itest-base.h: wait for bootstrapping to finish when waiting
for replicas
..
Patch Set 1:
(3 comments)
Adar Dembo has posted comments on this change.
Change subject: Don't use InMemoryEnv in deltafile-test
..
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/3235
To unsubscribe, visit
Adar Dembo has posted comments on this change.
Change subject: log: Mark allocation finished even if allocation had an error
..
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/3234/1/src/kudu/consensus/log.cc
Adar Dembo has posted comments on this change.
Change subject: Allow for reserving disk space for non-Kudu processes
..
Patch Set 4:
(4 comments)
http://gerrit.cloudera.org:8080/#/c/3135/4//COMMIT_MSG
Commit Message:
Line
Adar Dembo has posted comments on this change.
Change subject: KUDU-1307 [master] support tables with range partition bounds
..
Patch Set 12: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/2806
To
Adar Dembo has posted comments on this change.
Change subject: Specify guaranteed semantics of GetTableLocations RPC
..
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/3240
To unsubscribe, visit
Adar Dembo has posted comments on this change.
Change subject: fix compile error when compiling column_predicate-test.cc
..
Patch Set 8:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/3233/8//COMMIT_MSG
Commit Message:
Adar Dembo has submitted this change and it was merged.
Change subject: KUDU-1267: Calling getString() on RowResult for wrong type gave
weird exception
..
KUDU-1267: Calling getString() on RowResult for wrong type gave weird
Adar Dembo has posted comments on this change.
Change subject: Allow for reserving disk space for non-Kudu processes
..
Patch Set 4:
(16 comments)
I reviewed everything but the LBM changes. I've indicated enough high-level
Adar Dembo has posted comments on this change.
Change subject: KUDU-1307 [master] support tables with range partition bounds
..
Patch Set 11:
(1 comment)
Adar Dembo has posted comments on this change.
Change subject: Remove last two usages of MemEnv in tests
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/3257
To unsubscribe, visit
Adar Dembo has posted comments on this change.
Change subject: Remove InMemoryEnv completely
..
Patch Set 1:
> There are no mentions of MemEnv or InMemoryEnv anywhere else in the code base
> that I could find.
I found a
Adar Dembo has posted comments on this change.
Change subject: Remove InMemoryEnv completely
..
Patch Set 1:
I think memenv would have been useful had we ever used it in non-trivial tests
(i.e. tests that perform real I/O).
Adar Dembo has posted comments on this change.
Change subject: Replace uses of boost::thread with std::thread
..
Patch Set 14: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/1868
To unsubscribe, visit
Adar Dembo has posted comments on this change.
Change subject: Remove InMemoryEnv completely
..
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/3258
To unsubscribe, visit
Adar Dembo has posted comments on this change.
Change subject: KUDU-1308 [c++-client]: support tables with non-covering range
partitions
..
Patch Set 2:
(15 comments)
I reviewed everything but the change to
Adar Dembo has posted comments on this change.
Change subject: Improve tpch usability
..
Patch Set 2:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/3279/2/src/kudu/scripts/tpch.sh
File src/kudu/scripts/tpch.sh:
Line 129:
Adar Dembo has posted comments on this change.
Change subject: Improve tpch usability
..
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/3279/1/src/kudu/scripts/tpch.sh
File src/kudu/scripts/tpch.sh:
Line 70:
Adar Dembo has posted comments on this change.
Change subject: KUDU-1308 [c++-client]: support tables with non-covering range
partitions
..
Patch Set 2:
(4 comments)
Adar Dembo has posted comments on this change.
Change subject: Replace boost::{lock, unique_lock, mutex} with std lib
equivalents
..
Patch Set 3: Code-Review+2
(2 comments)
Would be nice to add some "using std::lock_guard"
Adar Dembo has posted comments on this change.
Change subject: Replace kudu::{lock_guard, unique_lock} with std lib equivalents
..
Patch Set 5:
I started reviewing, then thought maybe this is the right patch to add "using
Adar Dembo has posted comments on this change.
Change subject: Replace kudu::{lock_guard, unique_lock} with std lib equivalents
..
Patch Set 7:
> Although I'm not overriding Adar's concern, he should chime back
> in.
I don't
Adar Dembo has posted comments on this change.
Change subject: Add TableCreator::add_range_split and deprecate
TableCreator::split_rows
..
Patch Set 2:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/3275/2//COMMIT_MSG
Adar Dembo has submitted this change and it was merged.
Change subject: catalog_manager: fix a locking error
..
catalog_manager: fix a locking error
This lock acquisition took the wrong lock, which meant it didn't add any
Adar Dembo has posted comments on this change.
Change subject: log: Mark allocation finished even if allocation had an error
..
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/3234/1/src/kudu/consensus/log.cc
Adar Dembo has posted comments on this change.
Change subject: catalog_manager: fix a locking brain fart
..
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/3425/1//COMMIT_MSG
Commit Message:
Line 7:
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/3425
to look at the new patch set (#2).
Change subject: catalog_manager: fix a locking error
..
catalog_manager: fix a
Adar Dembo has posted comments on this change.
Change subject: consensus: Crash if we fail to append to the WAL
..
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/3406/3/src/kudu/util/status_callback.cc
File
Adar Dembo has posted comments on this change.
Change subject: Update Java client for new master GetTableLocations semantics
..
Patch Set 2:
(4 comments)
Adar Dembo has posted comments on this change.
Change subject: Add Raft remote bootstrap design doc
..
Patch Set 2:
(4 comments)
Looks good, just a few formatting nits.
Adar Dembo has posted comments on this change.
Change subject: Link to raft config change design from design-docs index page
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/3394
To unsubscribe,
Adar Dembo has posted comments on this change.
Change subject: [java-client] use tablet cache for locateTablet calls
..
Patch Set 4: Code-Review+2
(1 comment)
Feel free to punt on the nit if you want to merge right now.
Adar Dembo has posted comments on this change.
Change subject: docs: informal design for handling permanent master failures
..
Patch Set 1:
(15 comments)
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/3393
to look at the new patch set (#2).
Change subject: docs: design for handling permanent master failures
..
docs:
Adar Dembo has posted comments on this change.
Change subject: Reformat raft-config-change.md to clean it up
..
Patch Set 3: Code-Review+2
(1 comment)
Adar Dembo has submitted this change and it was merged.
Change subject: Add Raft remote bootstrap design doc
..
Add Raft remote bootstrap design doc
This was ported over from a Google doc
Change-Id:
Adar Dembo has posted comments on this change.
Change subject: Add Raft remote bootstrap design doc
..
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/3395
To unsubscribe, visit
Adar Dembo has posted comments on this change.
Change subject: Mark the Response accessors in transactions/transaction's state
const
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/3419
To
Adar Dembo has posted comments on this change.
Change subject: Add additional documentation for bad installation
..
Patch Set 2:
Since you're modifying an asciidoc file, could you generate rendered output
too? The easiest way
Hello David Ribeiro Alves, Mike Percy,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/3425
to review the following change.
Change subject: catalog_manager: fix a locking brain fart
..
Hello Dan Burkert,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/3405
to review the following change.
Change subject: build: squelch symbol visibility warnings seen with cmake 3.5
..
Adar Dembo has submitted this change and it was merged.
Change subject: build: squelch symbol visibility warnings seen with cmake 3.5
..
build: squelch symbol visibility warnings seen with cmake 3.5
When building with cmake
Adar Dembo has posted comments on this change.
Change subject: Add Env::GetBytesFree() method
..
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/3451/2/src/kudu/util/env_posix.cc
File src/kudu/util/env_posix.cc:
Adar Dembo has posted comments on this change.
Change subject: Allow for reserving disk space for non-Kudu processes
..
Patch Set 5:
(24 comments)
http://gerrit.cloudera.org:8080/#/c/3135/5/src/kudu/consensus/log.cc
File
Adar Dembo has posted comments on this change.
Change subject: KUDU-1491. Address TSAN warning for compaction
..
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/3454
To unsubscribe, visit
Hello David Ribeiro Alves, Kudu Jenkins,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/3461
to review the following change.
Change subject: catalog_manager: fix a locking error
..
Adar Dembo has posted comments on this change.
Change subject: Add Env::GetBytesFree() method
..
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/3451
To unsubscribe, visit
Adar Dembo has posted comments on this change.
Change subject: KUDU-1491. Address TSAN warning for compaction
..
Patch Set 1: Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/3454/1/src/kudu/tablet/compaction.cc
Adar Dembo has submitted this change and it was merged.
Change subject: catalog_manager: fix a locking error
..
catalog_manager: fix a locking error
This lock acquisition took the wrong lock, which meant it didn't add any
Adar Dembo has uploaded a new patch set (#2).
Change subject: catalog_manager: prevent spurious dirty callbacks from crashing
the process
..
catalog_manager: prevent spurious dirty callbacks from crashing the process
The
Hello Mike Percy, Todd Lipcon,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/3465
to review the following change.
Change subject: catalog_manager: prevent spurious dirty callbacks from crashing
the process
Adar Dembo has posted comments on this change.
Change subject: log: Mark allocation finished even if allocation had an error
..
Patch Set 5: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/3234
To unsubscribe,
Adar Dembo has posted comments on this change.
Change subject: KUDU-1331] Add scripts to build environment easier with Docker
..
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/2162/3/start-build-env.sh
File
Adar Dembo has posted comments on this change.
Change subject: tsan: remove two old suppressions
..
Patch Set 1: Code-Review+2
Okay, sure.
--
To view, visit http://gerrit.cloudera.org:8080/3411
To unsubscribe, visit
Adar Dembo has posted comments on this change.
Change subject: Make 'num_attempts' in RequestIdPB required
..
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/3408/2//COMMIT_MSG
Commit Message:
Line 15: requires
Adar Dembo has posted comments on this change.
Change subject: Make 'num_attempts' in RequestIdPB required
..
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/3408
To unsubscribe, visit
Adar Dembo has posted comments on this change.
Change subject: Allow crcutil* symbols in the client
..
Patch Set 4:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/3412/4/src/kudu/client/symbols.map
File
Adar Dembo has posted comments on this change.
Change subject: Allow crcutil* symbols in the client
..
Patch Set 5: Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/3412/4/src/kudu/client/symbols.map
File
Adar Dembo has posted comments on this change.
Change subject: [java-client] use tablet cache for locateTablet calls
..
Patch Set 2:
(1 comment)
Adar Dembo has posted comments on this change.
Change subject: Add required Debian version to installation page
..
Patch Set 1:
> I thought you had? Debian is mentioned along with Ubuntu
> everywhere in the docs, except in
Adar Dembo has posted comments on this change.
Change subject: Add required Debian version to installation page
..
Patch Set 1:
> I thought you had? Debian is mentioned along with Ubuntu
> everywhere in the docs, except in
Adar Dembo has posted comments on this change.
Change subject: [java-client] use tablet cache for locateTablet calls
..
Patch Set 2:
(5 comments)
http://gerrit.cloudera.org:8080/#/c/3386/2//COMMIT_MSG
Commit Message:
PS2,
Adar Dembo has posted comments on this change.
Change subject: Update Java client for new master GetTableLocations semantics
..
Patch Set 4: Code-Review+2
Much cleaner, this was a good idea.
--
To view, visit
Adar Dembo has posted comments on this change.
Change subject: Add required Debian version to installation page
..
Patch Set 1: Code-Review+2
I presume someone has built Kudu on Debian 8?
--
To view, visit
Adar Dembo has posted comments on this change.
Change subject: docs: informal design for handling permanent master failures
..
Patch Set 1:
Rendered content available here:
Hello David Ribeiro Alves, Mike Percy, Todd Lipcon,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/3393
to review the following change.
Change subject: docs: informal design for handling permanent master failures
1 - 100 of 308 matches
Mail list logo
