/
Testing
---
make check
Thanks,
Vinod Kone
584b042e32865fdf875bf41ebcfb7f9c327d882a
src/tests/scheduler_tests.cpp 4a89a7a88b50bb8c254f5076661ce07ac9fc7657
Diff: https://reviews.apache.org/r/32845/diff/
Testing
---
make check
Thanks,
Vinod Kone
bd9fced0f58aa3bc0ff147dbefb77cea4734a79e
Diff: https://reviews.apache.org/r/33465/diff/
Testing
---
make check
Thanks,
Vinod Kone
e30b951eda2b3b0d5b2a80716f0b32c6bbe041bc
Diff: https://reviews.apache.org/r/32506/diff/
Testing
---
make check
Thanks,
Vinod Kone
instead of
Resource*s*Estimator. The former is just easier to pronounce. Also, this is to
be consistent with things like ResourceMonitor and StatusUpdateManager which
also deal with multiples of resources and status updates.
- Vinod Kone
On May 6, 2015, 10:35 p.m., Jie Yu wrote
fb448256d7ced1f47ea48ccfca2ae267bc26ef94
src/master/master.hpp 49ee050ca4d2b2c5f75ce864fcf6ae703dfdeadd
src/master/master.cpp bee842557c8397428ca51e46faa182a391584be3
Diff: https://reviews.apache.org/r/33871/diff/
Testing
---
make check
Thanks,
Vinod Kone
://reviews.apache.org/r/33875/#comment133504
s/monitoring/executor/
- Vinod Kone
On May 6, 2015, 4:01 p.m., Niklas Nielsen wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33875
49ee050ca4d2b2c5f75ce864fcf6ae703dfdeadd
src/master/master.cpp bee842557c8397428ca51e46faa182a391584be3
Diff: https://reviews.apache.org/r/33871/diff/
Testing
---
make check
Thanks,
Vinod Kone
https://reviews.apache.org/r/33823/#comment133317
s/StatusUpdate/Update/
include/mesos/executor/executor.proto
https://reviews.apache.org/r/33823/#comment133318
No corresponding Type for this?
Also, how and when is this used?
- Vinod Kone
On May 4, 2015, 10:21 p.m
235930ff2dbb3ea49a3a0696dc070f2bd56fba4b
src/tests/resources_tests.cpp a7ec59ea217ad71f7d1e93ca6039d5b2491b3237
Diff: https://reviews.apache.org/r/33865/diff/
Testing
---
make check
Thanks,
Vinod Kone
On May 6, 2015, 10:39 p.m., Vinod Kone wrote:
include/mesos/master/allocator.hpp, lines 54-55
https://reviews.apache.org/r/33513/diff/4/?file=951247#file951247line54
Instead of empty string, make the argument Optionstring?
Alexander Rukletsov wrote:
I think a common pattern
:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33152/
---
(Updated April 14, 2015, 1:46 a.m.)
Review request for mesos and Vinod Kone.
Repository: mesos
Description
---
See
/diff/
Testing
---
make check
Thanks,
Vinod Kone
---
On May 5, 2015, 9:13 p.m., Vinod Kone wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33865
: https://reviews.apache.org/r/34306/diff/
Testing
---
Thanks,
Vinod Kone
Description
---
Moved the documenation close to the fields for clarity. No functional changes.
Diffs
-
include/mesos/mesos.proto 9cc5782256156ed59fd4640091413b76480d939f
Diff: https://reviews.apache.org/r/34304/diff/
Testing
---
Thanks,
Vinod Kone
/#comment135130
s/UpdateOversubcribedResourcesMessage/SendOversubscribedResources/
src/tests/oversubscription_tests.cpp
https://reviews.apache.org/r/34299/#comment135131
s/estimation/estimation of oversubscribed resources/
- Vinod Kone
On May 15, 2015, 11:38 p.m., Jie Yu wrote
Description
---
Did this for consistency with validateDiskInfo().
Diffs
-
src/master/validation.cpp c3e96ae0e684f3f365e9aa365bccc953d32b0452
Diff: https://reviews.apache.org/r/34298/diff/
Testing
---
make check
Thanks,
Vinod Kone
---
On May 14, 2015, 11:57 p.m., Vinod Kone wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33865
/resources_tests.cpp a7ec59ea217ad71f7d1e93ca6039d5b2491b3237
Diff: https://reviews.apache.org/r/33865/diff/
Testing
---
make check
Thanks,
Vinod Kone
/
src/tests/oversubscription_tests.cpp
https://reviews.apache.org/r/34299/#comment135321
s/oversubscribed/oversubscribable/
src/messages/messages.proto
https://reviews.apache.org/r/34299/#comment135312
s/Oversubscribed/Oversubscribe/ ?
- Vinod Kone
On May 18, 2015, 5:58 p.m., Jie
/detector.cpp) for
consistency.
- Vinod Kone
On May 13, 2015, 5:50 p.m., Tom Arnfeld wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34152
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33155/#review83648
---
Ship it!
Ship It!
- Vinod Kone
On May 12, 2015, 11:32 p.m., Ben
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34308/#review84426
---
Ship it!
Ship It!
- Vinod Kone
On May 20, 2015, 12:29 a.m., Ian
testing changing policy?
- Vinod Kone
On May 18, 2015, 8:48 p.m., Ian Downes wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34309
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34389/#review84360
---
Ship it!
Ship It!
- Vinod Kone
On May 19, 2015, 1:56 a.m., Ben
:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34309/
---
(Updated May 18, 2015, 8:48 p.m.)
Review request for mesos, Joris Van Remoortere, Niklas Nielsen, and Vinod
Kone.
Bugs: MESOS
/#comment135600
So basename can never return an error? When did ::basename() return NULL?
- Vinod Kone
On May 17, 2015, 10:42 p.m., Till Toenshoff wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org
haven't checked all the edge cases, but you get the idea.
3rdparty/libprocess/3rdparty/stout/tests/path_tests.cpp
https://reviews.apache.org/r/34256/#comment135593
nice tests.
- Vinod Kone
On May 17, 2015, 7:46 p.m., Till Toenshoff wrote
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34259/#review84379
---
Ship it!
Ship It!
- Vinod Kone
On May 17, 2015, 7:47 p.m., Till
: 1234
Vinod Kone wrote:
Nik, the general rule is that we don't include stuff in the log message
that the caller already has access to, because it makes it hard to chain
errors (e.g., the caller has no idea whether to include pid in its own log
message or not).
Niklas Nielsen wrote
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34483/#review84568
---
Ship it!
Ship It!
- Vinod Kone
On May 20, 2015, 6:04 p.m., Jie
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34482/#review84552
---
Ship it!
Ship It!
- Vinod Kone
On May 20, 2015, 5:48 p.m., Jie
(updated)
-
include/mesos/mesos.proto 9cc5782256156ed59fd4640091413b76480d939f
Diff: https://reviews.apache.org/r/34306/diff/
Testing (updated)
---
make check
Thanks,
Vinod Kone
/
Testing
---
Thanks,
Vinod Kone
to make this extensible in future. For example,
receiving optimistic offers might be another capability.
Diffs
-
include/mesos/mesos.proto 9cc5782256156ed59fd4640091413b76480d939f
Diff: https://reviews.apache.org/r/34306/diff/
Testing
---
make check
Thanks,
Vinod Kone
: mesos
Description
---
Now contributors don't have to manually set the depends on field!
Diffs
-
support/post-reviews.py 48497254ea5b60d8392d1e293268638764992fc1
Diff: https://reviews.apache.org/r/34503/diff/
Testing
---
Tested with a chain of reviews.
Thanks,
Vinod Kone
---
On May 20, 2015, 10:50 p.m., Vinod Kone wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34503
with a chain of reviews.
Thanks,
Vinod Kone
://reviews.apache.org/r/35028/#comment138779
s/Could not/Failed to/
src/tests/oversubscription_tests.cpp
https://reviews.apache.org/r/35028/#comment138780
s/Ld/LD/
also why conversion to C string?
- Vinod Kone
On June 4, 2015, 5:56 p.m., Jie Yu wrote
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35024/#review86505
---
Ship it!
Ship It!
- Vinod Kone
On June 3, 2015, 10:08 p.m
immediately after it gets an
estimate from the estimator, it might query the estimator again.
src/slave/resource_estimators/fixed.cpp
https://reviews.apache.org/r/35028/#comment138562
why not let the process handle this? that way you don't have to maintain a
copy?
- Vinod Kone
On June 3, 2015
/#comment138734
This is getting a little hairy. As the TODO says we really ought bubble
this up via the Termination protobuf. Have you looked into it?
- Vinod Kone
On June 4, 2015, 5:43 p.m., Niklas Nielsen wrote:
---
This is an automatically
Want to do that instead?
Jie Yu wrote:
I thought we decided to use char[] consistently? That's what we've been
doing in isolators.
Should we make a decision and change that in the style guide?
cc Ben Mahler, Vinod Kone
Jie Yu wrote:
```
[tw-172-25-131
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35118/#review87083
---
Ship it!
Ship It!
- Vinod Kone
On June 5, 2015, 9:09 p.m
On June 5, 2015, 5:42 p.m., Vinod Kone wrote:
src/master/allocator/mesos/hierarchical.hpp, lines 455-456
https://reviews.apache.org/r/33159/diff/4/?file=979945#file979945line455
I don't follow. Why are these CHECKs? Is there currently code in the
master that guarantees
://reviews.apache.org/r/33159/#comment138910
I don't follow. Why are these CHECKs? Is there currently code in the master
that guarantees that these checks won't fail?
- Vinod Kone
On June 5, 2015, 1:35 p.m., Joris Van Remoortere wrote
/#comment138923
ips sounds like multiple IPs though i know you meant it as IP as a string.
just call it ipString
src/common/parse.hpp
https://reviews.apache.org/r/34687/#comment138922
s/this/This/
- Vinod Kone
On June 3, 2015, 9 p.m., Marco Massenzio wrote
/34970/#comment138943
Also mention that, if this is not specified, as many tasks as possible are
launched?
src/examples/no_executor_framework.cpp
https://reviews.apache.org/r/34970/#comment138942
Only set this if flags.task_revocable_resources.isSome() ?
- Vinod Kone
On June 5, 2015, 7
On June 5, 2015, 6:42 p.m., Vinod Kone wrote:
I made some minor comments below but I think a better way to do this is to
*not* write custom masterinfo json - protobuf converters. I prefer we
just add a new optional field (say ipAddress of type string). Then you can
just leverage
on this method.
- Vinod Kone
On June 5, 2015, 9:09 p.m., Jiang Yan Xu wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35118
/35119/#comment138952
s/irrevocable/non-revocable/
src/master/metrics.cpp
https://reviews.apache.org/r/35119/#comment138953
ditto.
- Vinod Kone
On June 5, 2015, 9:13 p.m., Jiang Yan Xu wrote:
---
This is an automatically
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35131/#review86864
---
Ship it!
Ship It!
- Vinod Kone
On June 5, 2015, 1:20 p.m., Till
is evaluated.
- Vinod Kone
On June 2, 2015, 7:37 p.m., Bartek Plotka wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34816
On May 29, 2015, 7:23 p.m., Vinod Kone wrote:
src/tests/oversubscription_tests.cpp, line 117
https://reviews.apache.org/r/34633/diff/1/?file=970999#file970999line117
Why not implement the TODO?
s/AWAIT_READY(received)/AWAIT_ASSERT_EQ(expected, received)/ ?
Niklas
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34962/#review86340
---
Ship it!
Ship It!
- Vinod Kone
On June 3, 2015, 12:11 a.m., Jie
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34968/#review86341
---
Ship it!
Ship It!
- Vinod Kone
On June 3, 2015, 1:07 a.m., Ben
in them.
- Vinod Kone
On June 9, 2015, 12:38 a.m., Jiang Yan Xu wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35239
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35270/#review87318
---
Ship it!
Ship It!
- Vinod Kone
On June 9, 2015, 11:31 p.m
://reviews.apache.org/r/34260/#comment141598
include path header?
- Vinod Kone
On June 23, 2015, 8:26 a.m., Till Toenshoff wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34260
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35773/#review89003
---
Ship it!
Ship It!
- Vinod Kone
On June 23, 2015, 8:29 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35775/#review89005
---
Ship it!
Ship It!
- Vinod Kone
On June 23, 2015, 8:27 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35774/#review89004
---
Ship it!
Ship It!
- Vinod Kone
On June 23, 2015, 8:26 a.m
slashes?
3rdparty/libprocess/3rdparty/stout/include/stout/path.hpp (line 81)
https://reviews.apache.org/r/34256/#comment141591
s/non trailing// ?
- Vinod Kone
On June 23, 2015, 8:26 a.m., Till Toenshoff wrote
/master.hpp (lines 535 - 539)
https://reviews.apache.org/r/35797/#comment141667
I think you can simply do
info.mutable_capabilities()-CopyFrom(source.capabilities());
- Vinod Kone
On June 23, 2015, 8:08 p.m., Aditi Dixit wrote
in 7.720996758secs
Updated 1 slaves in 16.4897123807167mins
[ OK ] SlaveCount/HierarchicalAllocator_BENCHMARK_Test.UpdateSlave/2
(999001 ms)
Thanks,
Vinod Kone
ms)
[--] 6 tests from SlaveCount/HierarchicalAllocator_BENCHMARK_Test
(169998 ms total)
Thanks,
Vinod Kone
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35841/#review89415
---
Ship it!
Ship It!
- Vinod Kone
On June 25, 2015, 5:27 p.m
/stout/abort.hpp (line 20)
https://reviews.apache.org/r/35861/#comment142017
get rid of this?
3rdparty/libprocess/3rdparty/stout/include/stout/ip.hpp (line 17)
https://reviews.apache.org/r/35861/#comment142018
new line?
- Vinod Kone
On June 25, 2015, 6:32 p.m., Paul Brett wrote
)
https://reviews.apache.org/r/35836/#comment141965
For posterity, can you add a comment here on why we store allocated in
the allocator despite having that information in the sorter?
- Vinod Kone
On June 24, 2015, 9:53 p.m., Jie Yu wrote
/scheduler/scheduler.cpp 1efc6fb351e49deaa8f626823592bc9155f5137b
Diff: https://reviews.apache.org/r/35857/diff/
Testing
---
make check
NOTE: Didn't add a new test because an existing test
(SchedulerTest.TaskRunning) already exercises this code path.
Thanks,
Vinod Kone
in the test.
- Vinod Kone
On June 24, 2015, 6:01 p.m., Marco Massenzio wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35815
/scheduler/scheduler.cpp 1efc6fb351e49deaa8f626823592bc9155f5137b
src/tests/scheduler_tests.cpp cbe6c91a1b4f864ceb11cf062da0ada6c9666f9f
Diff: https://reviews.apache.org/r/35856/diff/
Testing
---
make check
Thanks,
Vinod Kone
/scheduler/scheduler.cpp 1efc6fb351e49deaa8f626823592bc9155f5137b
src/tests/scheduler_tests.cpp cbe6c91a1b4f864ceb11cf062da0ada6c9666f9f
Diff: https://reviews.apache.org/r/35855/diff/
Testing
---
make check
Thanks,
Vinod Kone
---
make check
Thanks,
Vinod Kone
generated e-mail. To reply, visit:
https://reviews.apache.org/r/35571/
---
(Updated June 18, 2015, 3:31 p.m.)
Review request for mesos, Niklas Nielsen and Vinod Kone.
Bugs: MESOS-2340
https://issues.apache.org/jira/browse
On June 11, 2015, 7:34 p.m., Vinod Kone wrote:
3rdparty/libprocess/src/process.cpp, lines 820-836
https://reviews.apache.org/r/34128/diff/2/?file=963212#file963212line820
If two libprocess based unix processes (e.g., scheudler and master) are
within the *same* bridged container
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35943/#review89572
---
Ship it!
Ship It!
- Vinod Kone
On June 26, 2015, 9:11 p.m., Ben
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35914/#review89571
---
Ship it!
Ship It!
- Vinod Kone
On June 26, 2015, 9:11 p.m., Ben
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35909/#review89568
---
Ship it!
Ship It!
- Vinod Kone
On June 26, 2015, 9:11 p.m., Ben
would also be
doing this one call at a time, to be able to test it properly. i'm discarding
this review but will likely use it as a reference for my patch set.
- Vinod Kone
On June 23, 2015, 10:21 p.m., Isabel Jimenez wrote
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33241/#review89230
---
Ship it!
LGTM. I'll get this committed.
- Vinod Kone
On June 24
/exec.cpp (line 498)
https://reviews.apache.org/r/35910/#comment142198
what do you mean by needs to be validated? can you elaborate?
- Vinod Kone
On June 26, 2015, 9:11 p.m., Ben Mahler wrote:
---
This is an automatically generated
On June 26, 2015, 9:44 p.m., Vinod Kone wrote:
src/exec/exec.cpp, lines 496-497
https://reviews.apache.org/r/35910/diff/1/?file=993586#file993586line496
s/create/overwrite/
s/pure clients/HTTP API/
Can you move this down to #514 where we also overwrite
://reviews.apache.org/r/35912/#comment142217
s/master-generated/master and scheduler driver/
- Vinod Kone
On June 26, 2015, 9:11 p.m., Ben Mahler wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
://reviews.apache.org/r/35935/#comment142218
I don't follow why you couldn't have just used the master in this test?
What's the hard part?
AFAICT, you can reconcile a bunch of unlaunched tasks which would stress
test the createStatusUpdate() part?
- Vinod Kone
On June 26, 2015, 9:33 p.m
for mesos, Ben Mahler, Niklas Nielsen, and Vinod Kone.
Bugs: MESOS-2818
https://issues.apache.org/jira/browse/MESOS-2818
Repository: mesos
Description
---
Refactored the ResourceMonitor to get statistics from the Slave.
1) Modified ResourceUsage to include allocation
to call it 'Container' instead?
Vinod Kone wrote:
+1
Jie Yu wrote:
OK, This is not consistent in the code base. We use Executor in master
and slave to represent the entire executor (executor itself + its tasks). For
example, in master, we have executor-addTask. In slave, we have
with the
proper fix as discussed.
- Vinod Kone
On June 9, 2015, 9:32 a.m., Bernd Mathiske wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35247
---
On June 1, 2015, 11:11 p.m., Vinod Kone wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34910
/resources_tests.cpp 4952e1b5409103087ab7d7ad91bf907515d3c567
Diff: https://reviews.apache.org/r/35309/diff/
Testing
---
make check
Thanks,
Vinod Kone
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34911/#review86457
---
On June 1, 2015, 11:15 p.m., Vinod Kone wrote:
---
This is an automatically generated e
---
On June 1, 2015, 11:15 p.m., Vinod Kone wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34911
/
Testing
---
make check
Thanks,
Vinod Kone
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30952/#review87438
---
Ship it!
Ship It!
- Vinod Kone
On June 10, 2015, 12:08 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35259/#review87439
---
Ship it!
Ship It!
- Vinod Kone
On June 9, 2015, 7:50 p.m., Jie
On June 9, 2015, 6:11 p.m., Vinod Kone wrote:
src/tests/fetcher_cache_tests.cpp, lines 201-207
https://reviews.apache.org/r/35247/diff/1/?file=981340#file981340line201
While this looks good as a temporary fix, what is the long term
strategy here?
I really don't like
/#comment139774
why the temporary?
- Vinod Kone
On June 10, 2015, 7:50 p.m., Ben Mahler wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35313
On June 5, 2015, 6:42 p.m., Vinod Kone wrote:
I made some minor comments below but I think a better way to do this is to
*not* write custom masterinfo json - protobuf converters. I prefer we
just add a new optional field (say ipAddress of type string). Then you can
just leverage
/common/http_tests.cpp
https://reviews.apache.org/r/35367/#comment140054
camelcase?
- Vinod Kone
On June 11, 2015, 7:56 p.m., Jiang Yan Xu wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
1 - 100 of 3008 matches
Mail list logo