Re: Review Request 33465: Removed 'uuid' field from UPDATE call.

2015-04-25 Thread Vinod Kone
e-mail. To reply, visit: https://reviews.apache.org/r/33465/#review81372 --- On April 23, 2015, 5:48 a.m., Vinod Kone wrote: --- This is an automatically generated e-mail. To reply

Re: Review Request 33465: Removed 'uuid' field from UPDATE call.

2015-04-25 Thread Vinod Kone
66fd2b3146568900356cc48e0f17c6720665ae80 src/scheduler/scheduler.cpp bd9fced0f58aa3bc0ff147dbefb77cea4734a79e src/tests/scheduler_tests.cpp 4a89a7a88b50bb8c254f5076661ce07ac9fc7657 Diff: https://reviews.apache.org/r/33465/diff/ Testing --- make check Thanks, Vinod Kone

Re: Review Request 32509: Documented the scheduler Event/Call protobufs.

2015-04-22 Thread Vinod Kone
--- On April 22, 2015, 9:44 p.m., Vinod Kone wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32509/ --- (Updated April 22

Re: Review Request 32509: Documented the scheduler Event/Call protobufs.

2015-04-22 Thread Vinod Kone
://reviews.apache.org/r/32509/diff/ Testing --- make check Thanks, Vinod Kone

Review Request 33465: Removed 'uuid' field from UPDATE call.

2015-04-22 Thread Vinod Kone
/ Testing --- make check Thanks, Vinod Kone

Re: Review Request 32844: Added SUBSCRIBE call and SUBSCRIBED event.

2015-04-22 Thread Vinod Kone
/ Testing --- make check Thanks, Vinod Kone

Re: Review Request 32845: Renamed UNREGISTER call to UNSUBSCRIBE.

2015-04-22 Thread Vinod Kone
584b042e32865fdf875bf41ebcfb7f9c327d882a src/tests/scheduler_tests.cpp 4a89a7a88b50bb8c254f5076661ce07ac9fc7657 Diff: https://reviews.apache.org/r/32845/diff/ Testing --- make check Thanks, Vinod Kone

Re: Review Request 32845: Renamed UNREGISTER call to UNSUBSCRIBE.

2015-04-22 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32845/#review80870 --- On April 20, 2015, 8:04 p.m., Vinod Kone wrote: --- This is an automatically

Re: Review Request 32844: Added SUBSCRIBE call and SUBSCRIBED event.

2015-04-22 Thread Vinod Kone
/ Testing --- make check Thanks, Vinod Kone

Re: Review Request 32505: Added SHUTDOWN scheduler call.

2015-04-22 Thread Vinod Kone
://reviews.apache.org/r/32505/diff/ Testing --- make check Thanks, Vinod Kone

Re: Review Request 33465: Removed 'uuid' field from UPDATE call.

2015-04-22 Thread Vinod Kone
bd9fced0f58aa3bc0ff147dbefb77cea4734a79e Diff: https://reviews.apache.org/r/33465/diff/ Testing --- make check Thanks, Vinod Kone

Re: Review Request 32506: Added output stream operators for scheduler Calls and Events.

2015-04-22 Thread Vinod Kone
e30b951eda2b3b0d5b2a80716f0b32c6bbe041bc Diff: https://reviews.apache.org/r/32506/diff/ Testing --- make check Thanks, Vinod Kone

Re: Review Request 33918: Added resources estimator abstraction for oversubscription.

2015-05-06 Thread Vinod Kone
instead of Resource*s*Estimator. The former is just easier to pronounce. Also, this is to be consistent with things like ResourceMonitor and StatusUpdateManager which also deal with multiples of resources and status updates. - Vinod Kone On May 6, 2015, 10:35 p.m., Jie Yu wrote

Re: Review Request 33871: Added /teardown endpoint that is going to replace /shutdown endpoint.

2015-05-06 Thread Vinod Kone
fb448256d7ced1f47ea48ccfca2ae267bc26ef94 src/master/master.hpp 49ee050ca4d2b2c5f75ce864fcf6ae703dfdeadd src/master/master.cpp bee842557c8397428ca51e46faa182a391584be3 Diff: https://reviews.apache.org/r/33871/diff/ Testing --- make check Thanks, Vinod Kone

Re: Review Request 33875: Removed unused collect cycle in resource monitor

2015-05-06 Thread Vinod Kone
://reviews.apache.org/r/33875/#comment133504 s/monitoring/executor/ - Vinod Kone On May 6, 2015, 4:01 p.m., Niklas Nielsen wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33875

Review Request 33871: Added /teardown endpoint that is going to replace /shutdown endpoint.

2015-05-06 Thread Vinod Kone
49ee050ca4d2b2c5f75ce864fcf6ae703dfdeadd src/master/master.cpp bee842557c8397428ca51e46faa182a391584be3 Diff: https://reviews.apache.org/r/33871/diff/ Testing --- make check Thanks, Vinod Kone

Re: Review Request 33823: Protocol file with the HTTP API messages between executor and slave

2015-05-05 Thread Vinod Kone
https://reviews.apache.org/r/33823/#comment133317 s/StatusUpdate/Update/ include/mesos/executor/executor.proto https://reviews.apache.org/r/33823/#comment133318 No corresponding Type for this? Also, how and when is this used? - Vinod Kone On May 4, 2015, 10:21 p.m

Review Request 33865: Added RevocableInfo message to Resource protobuf.

2015-05-05 Thread Vinod Kone
235930ff2dbb3ea49a3a0696dc070f2bd56fba4b src/tests/resources_tests.cpp a7ec59ea217ad71f7d1e93ca6039d5b2491b3237 Diff: https://reviews.apache.org/r/33865/diff/ Testing --- make check Thanks, Vinod Kone

Re: Review Request 33513: Added a modules-aware factory for allocators.

2015-05-08 Thread Vinod Kone
On May 6, 2015, 10:39 p.m., Vinod Kone wrote: include/mesos/master/allocator.hpp, lines 54-55 https://reviews.apache.org/r/33513/diff/4/?file=951247#file951247line54 Instead of empty string, make the argument Optionstring? Alexander Rukletsov wrote: I think a common pattern

Re: Review Request 33152: Moved the slave shutdown test into slave_tests.cpp.

2015-05-12 Thread Vinod Kone
: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33152/ --- (Updated April 14, 2015, 1:46 a.m.) Review request for mesos and Vinod Kone. Repository: mesos Description --- See

Re: Review Request 33154: Added reason metrics for slave removals.

2015-05-12 Thread Vinod Kone
a const ref of 'reason' per Alex's comments? - Vinod Kone On May 12, 2015, 2:51 a.m., Ben Mahler wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33154

Re: Review Request 33865: Added RevocableInfo message to Resource protobuf.

2015-05-14 Thread Vinod Kone
/diff/ Testing --- make check Thanks, Vinod Kone

Re: Review Request 33865: Added RevocableInfo message to Resource protobuf.

2015-05-14 Thread Vinod Kone
--- On May 5, 2015, 9:13 p.m., Vinod Kone wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33865

Review Request 34306: Added 'revocable_offers' field to FrameworkInfo.

2015-05-15 Thread Vinod Kone
: https://reviews.apache.org/r/34306/diff/ Testing --- Thanks, Vinod Kone

Review Request 34304: Updated documentation of FrameworkInfo.

2015-05-15 Thread Vinod Kone
Description --- Moved the documenation close to the fields for clarity. No functional changes. Diffs - include/mesos/mesos.proto 9cc5782256156ed59fd4640091413b76480d939f Diff: https://reviews.apache.org/r/34304/diff/ Testing --- Thanks, Vinod Kone

Re: Review Request 34299: Changed to use a push model for resource estimator.

2015-05-15 Thread Vinod Kone
/#comment135130 s/UpdateOversubcribedResourcesMessage/SendOversubscribedResources/ src/tests/oversubscription_tests.cpp https://reviews.apache.org/r/34299/#comment135131 s/estimation/estimation of oversubscribed resources/ - Vinod Kone On May 15, 2015, 11:38 p.m., Jie Yu wrote

Review Request 34298: Explictly validated that all resources specified in reserve or unreserve operations are dynamically reserved.

2015-05-15 Thread Vinod Kone
Description --- Did this for consistency with validateDiskInfo(). Diffs - src/master/validation.cpp c3e96ae0e684f3f365e9aa365bccc953d32b0452 Diff: https://reviews.apache.org/r/34298/diff/ Testing --- make check Thanks, Vinod Kone

Re: Review Request 33865: Added RevocableInfo message to Resource protobuf.

2015-05-15 Thread Vinod Kone
--- On May 14, 2015, 11:57 p.m., Vinod Kone wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33865

Re: Review Request 33865: Added RevocableInfo message to Resource protobuf.

2015-05-15 Thread Vinod Kone
/resources_tests.cpp a7ec59ea217ad71f7d1e93ca6039d5b2491b3237 Diff: https://reviews.apache.org/r/33865/diff/ Testing --- make check Thanks, Vinod Kone

Re: Review Request 34299: Changed to use a push model for resource estimator.

2015-05-18 Thread Vinod Kone
/ src/tests/oversubscription_tests.cpp https://reviews.apache.org/r/34299/#comment135321 s/oversubscribed/oversubscribable/ src/messages/messages.proto https://reviews.apache.org/r/34299/#comment135312 s/Oversubscribed/Oversubscribe/ ? - Vinod Kone On May 18, 2015, 5:58 p.m., Jie

Re: Review Request 34152: Master flag validation now supports zookeeper

2015-05-13 Thread Vinod Kone
/detector.cpp) for consistency. - Vinod Kone On May 13, 2015, 5:50 p.m., Tom Arnfeld wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34152

Re: Review Request 33155: Added tests for slave removal metrics.

2015-05-13 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33155/#review83648 --- Ship it! Ship It! - Vinod Kone On May 12, 2015, 11:32 p.m., Ben

Re: Review Request 34308: Filter revocable resources.

2015-05-19 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34308/#review84426 --- Ship it! Ship It! - Vinod Kone On May 20, 2015, 12:29 a.m., Ian

Re: Review Request 34309: Support manipulating scheduler policy on Linux.

2015-05-19 Thread Vinod Kone
testing changing policy? - Vinod Kone On May 18, 2015, 8:48 p.m., Ian Downes wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34309

Re: Review Request 34389: Removed Master::getSlave.

2015-05-19 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34389/#review84360 --- Ship it! Ship It! - Vinod Kone On May 19, 2015, 1:56 a.m., Ben

Re: Review Request 34309: Support manipulating scheduler policy on Linux.

2015-05-19 Thread Vinod Kone
: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34309/ --- (Updated May 18, 2015, 8:48 p.m.) Review request for mesos, Joris Van Remoortere, Niklas Nielsen, and Vinod Kone. Bugs: MESOS

Re: Review Request 34260: Replaced os::dirname and os::basename with Path::dirname and Path::basename.

2015-05-19 Thread Vinod Kone
/#comment135600 So basename can never return an error? When did ::basename() return NULL? - Vinod Kone On May 17, 2015, 10:42 p.m., Till Toenshoff wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org

Re: Review Request 34256: Added Path::dirname() and Path::basename().

2015-05-19 Thread Vinod Kone
haven't checked all the edge cases, but you get the idea. 3rdparty/libprocess/3rdparty/stout/tests/path_tests.cpp https://reviews.apache.org/r/34256/#comment135593 nice tests. - Vinod Kone On May 17, 2015, 7:46 p.m., Till Toenshoff wrote

Re: Review Request 34259: Replaced os::dirname and os::basename with Path::dirname and Path::basename.

2015-05-19 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34259/#review84379 --- Ship it! Ship It! - Vinod Kone On May 17, 2015, 7:47 p.m., Till

Re: Review Request 34310: Use IDLE scheduling for revocable CPU in cgroups isolator.

2015-05-19 Thread Vinod Kone
://reviews.apache.org/r/34310/#comment135584 Optional? because this only gets set/updated in update(). - Vinod Kone On May 18, 2015, 8:49 p.m., Ian Downes wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request 34309: Support manipulating scheduler policy on Linux.

2015-05-19 Thread Vinod Kone
: 1234 Vinod Kone wrote: Nik, the general rule is that we don't include stuff in the log message that the caller already has access to, because it makes it hard to chain errors (e.g., the caller has no idea whether to include pid in its own log message or not). Niklas Nielsen wrote

Re: Review Request 34483: Moved the repository url constant to reviewboardrc.

2015-05-20 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34483/#review84568 --- Ship it! Ship It! - Vinod Kone On May 20, 2015, 6:04 p.m., Jie

Re: Review Request 34488: Allowed post-reviews.py to configure tracking branch.

2015-05-20 Thread Vinod Kone
/#comment135921 s/Parsing/Parse/ support/post-reviews.py https://reviews.apache.org/r/34488/#comment135922 if someone specifies --tracking-branch on the command line, does that mean it'll be passed to 'rbt' twice? - Vinod Kone On May 20, 2015, 6:56 p.m., Jie Yu wrote

Re: Review Request 34485: Renamed parent_branch to tracking_branch in post-reviews.py.

2015-05-20 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34485/#review84588 --- Ship it! Ship It! - Vinod Kone On May 20, 2015, 6:17 p.m., Jie

Re: Review Request 33823: Protocol file with the HTTP API messages between executor and slave

2015-05-20 Thread Vinod Kone
this. - Vinod Kone On May 20, 2015, 6:41 a.m., Alexander Rojas wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33823/ --- (Updated

Re: Review Request 34482: Fixed a bug in post-reviews.py.

2015-05-20 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34482/#review84552 --- Ship it! Ship It! - Vinod Kone On May 20, 2015, 5:48 p.m., Jie

Re: Review Request 34306: Added 'revocable_offers' field to FrameworkInfo.

2015-05-20 Thread Vinod Kone
(updated) - include/mesos/mesos.proto 9cc5782256156ed59fd4640091413b76480d939f Diff: https://reviews.apache.org/r/34306/diff/ Testing (updated) --- make check Thanks, Vinod Kone

Re: Review Request 34488: Allowed post-reviews.py to configure tracking branch.

2015-05-20 Thread Vinod Kone
/34488/#comment135975 more pythonic way would be: tracking_branch = args.tracking_branch if args.tracking_branch else 'master' - Vinod Kone On May 20, 2015, 11:31 p.m., Jie Yu wrote: --- This is an automatically generated e

Re: Review Request 34304: Updated documentation of FrameworkInfo.

2015-05-20 Thread Vinod Kone
/ Testing --- Thanks, Vinod Kone

Re: Review Request 34306: Added capabilities field to FrameworkInfo.

2015-05-20 Thread Vinod Kone
to make this extensible in future. For example, receiving optimistic offers might be another capability. Diffs - include/mesos/mesos.proto 9cc5782256156ed59fd4640091413b76480d939f Diff: https://reviews.apache.org/r/34306/diff/ Testing --- make check Thanks, Vinod Kone

Review Request 34503: Updated post-reviews.py to auto set 'depends on' field.

2015-05-20 Thread Vinod Kone
: mesos Description --- Now contributors don't have to manually set the depends on field! Diffs - support/post-reviews.py 48497254ea5b60d8392d1e293268638764992fc1 Diff: https://reviews.apache.org/r/34503/diff/ Testing --- Tested with a chain of reviews. Thanks, Vinod Kone

Re: Review Request 34503: Updated post-reviews.py to auto set 'depends on' field.

2015-05-20 Thread Vinod Kone
--- On May 20, 2015, 10:50 p.m., Vinod Kone wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34503

Re: Review Request 34503: Updated post-reviews.py to auto set 'depends on' field.

2015-05-20 Thread Vinod Kone
with a chain of reviews. Thanks, Vinod Kone

Re: Review Request 35028: Added a fixed resource estimator.

2015-06-04 Thread Vinod Kone
://reviews.apache.org/r/35028/#comment138779 s/Could not/Failed to/ src/tests/oversubscription_tests.cpp https://reviews.apache.org/r/35028/#comment138780 s/Ld/LD/ also why conversion to C string? - Vinod Kone On June 4, 2015, 5:56 p.m., Jie Yu wrote

Review Request 35038: Updated slave to query resource estimator whenever it wants to forward an update.

2015-06-03 Thread Vinod Kone
271cb03770cd08406054dfce35d0821475e49b05 src/tests/oversubscription_tests.cpp f047b90d8f0b4dfe7e6cad6dc58909451e9f894b Diff: https://reviews.apache.org/r/35038/diff/ Testing --- make check Thanks, Vinod Kone

Re: Review Request 35038: Updated slave to query resource estimator whenever it wants to forward an update.

2015-06-03 Thread Vinod Kone
/oversubscription_tests.cpp f047b90d8f0b4dfe7e6cad6dc58909451e9f894b Diff: https://reviews.apache.org/r/35038/diff/ Testing --- make check Thanks, Vinod Kone

Re: Review Request 35024: Fixed _resources_used() to include only *regular* resources.

2015-06-03 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35024/#review86505 --- Ship it! Ship It! - Vinod Kone On June 3, 2015, 10:08 p.m

Re: Review Request 35028: Added a fixed resource estimator.

2015-06-03 Thread Vinod Kone
immediately after it gets an estimate from the estimator, it might query the estimator again. src/slave/resource_estimators/fixed.cpp https://reviews.apache.org/r/35028/#comment138562 why not let the process handle this? that way you don't have to maintain a copy? - Vinod Kone On June 3, 2015

Re: Review Request 34720: Added kill executor correction to slave.

2015-06-04 Thread Vinod Kone
/#comment138734 This is getting a little hairy. As the TODO says we really ought bubble this up via the Termination protobuf. Have you looked into it? - Vinod Kone On June 4, 2015, 5:43 p.m., Niklas Nielsen wrote: --- This is an automatically

Re: Review Request 35028: Added a fixed resource estimator.

2015-06-04 Thread Vinod Kone
Want to do that instead? Jie Yu wrote: I thought we decided to use char[] consistently? That's what we've been doing in isolators. Should we make a decision and change that in the style guide? cc Ben Mahler, Vinod Kone Jie Yu wrote: ``` [tw-172-25-131

Re: Review Request 34260: Replaced os::dirname and os::basename with Path::dirname and Path::basename.

2015-06-08 Thread Vinod Kone
On May 19, 2015, 8:13 p.m., Vinod Kone wrote: src/cli/mesos.cpp, line 31 https://reviews.apache.org/r/34260/diff/6/?file=962331#file962331line31 So basename can never return an error? When did ::basename() return NULL? Alexander Rojas wrote: I checked in the `::basename

Re: Review Request 35118: Made updateSlave() update its 'totalResources'.

2015-06-08 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35118/#review87083 --- Ship it! Ship It! - Vinod Kone On June 5, 2015, 9:09 p.m

Re: Review Request 33159: Pump updateFramework through Allocator from Master.

2015-06-05 Thread Vinod Kone
On June 5, 2015, 5:42 p.m., Vinod Kone wrote: src/master/allocator/mesos/hierarchical.hpp, lines 455-456 https://reviews.apache.org/r/33159/diff/4/?file=979945#file979945line455 I don't follow. Why are these CHECKs? Is there currently code in the master that guarantees

Re: Review Request 33159: Pump updateFramework through Allocator from Master.

2015-06-05 Thread Vinod Kone
://reviews.apache.org/r/33159/#comment138910 I don't follow. Why are these CHECKs? Is there currently code in the master that guarantees that these checks won't fail? - Vinod Kone On June 5, 2015, 1:35 p.m., Joris Van Remoortere wrote

Re: Review Request 34687: (De)Serializing MasterInfo PB to JSON

2015-06-05 Thread Vinod Kone
/#comment138923 ips sounds like multiple IPs though i know you meant it as IP as a string. just call it ipString src/common/parse.hpp https://reviews.apache.org/r/34687/#comment138922 s/this/This/ - Vinod Kone On June 3, 2015, 9 p.m., Marco Massenzio wrote

Re: Review Request 34970: Cleaned up and generalized NoExecutorScheduler to be more configurable.

2015-06-05 Thread Vinod Kone
/34970/#comment138943 Also mention that, if this is not specified, as many tasks as possible are launched? src/examples/no_executor_framework.cpp https://reviews.apache.org/r/34970/#comment138942 Only set this if flags.task_revocable_resources.isSome() ? - Vinod Kone On June 5, 2015, 7

Re: Review Request 34687: (De)Serializing MasterInfo PB to JSON

2015-06-05 Thread Vinod Kone
On June 5, 2015, 6:42 p.m., Vinod Kone wrote: I made some minor comments below but I think a better way to do this is to *not* write custom masterinfo json - protobuf converters. I prefer we just add a new optional field (say ipAddress of type string). Then you can just leverage

Re: Review Request 35118: Made updateSlave() update its 'totalResources'.

2015-06-05 Thread Vinod Kone
on this method. - Vinod Kone On June 5, 2015, 9:09 p.m., Jiang Yan Xu wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35118

Re: Review Request 35119: Introduced metrics for revocable resources.

2015-06-05 Thread Vinod Kone
/35119/#comment138952 s/irrevocable/non-revocable/ src/master/metrics.cpp https://reviews.apache.org/r/35119/#comment138953 ditto. - Vinod Kone On June 5, 2015, 9:13 p.m., Jiang Yan Xu wrote: --- This is an automatically

Re: Review Request 35131: Replaced os::dirname and os::basename with Path::dirname and Path::basename.

2015-06-05 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35131/#review86864 --- Ship it! Ship It! - Vinod Kone On June 5, 2015, 1:20 p.m., Till

Re: Review Request 34687: (De)Serializing MasterInfo PB to JSON

2015-06-05 Thread Vinod Kone
On June 5, 2015, 6:42 p.m., Vinod Kone wrote: I made some minor comments below but I think a better way to do this is to *not* write custom masterinfo json - protobuf converters. I prefer we just add a new optional field (say ipAddress of type string). Then you can just leverage

Re: Review Request 34816: Changed TestResourceEstimator to be mocked.

2015-06-02 Thread Vinod Kone
is evaluated. - Vinod Kone On June 2, 2015, 7:37 p.m., Bartek Plotka wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34816

Re: Review Request 34633: Added QoS Controller test.

2015-06-03 Thread Vinod Kone
On May 29, 2015, 7:23 p.m., Vinod Kone wrote: src/tests/oversubscription_tests.cpp, line 117 https://reviews.apache.org/r/34633/diff/1/?file=970999#file970999line117 Why not implement the TODO? s/AWAIT_READY(received)/AWAIT_ASSERT_EQ(expected, received)/ ? Niklas

Re: Review Request 34962: Moved NoopResourceEstimator to a separate file.

2015-06-02 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34962/#review86340 --- Ship it! Ship It! - Vinod Kone On June 3, 2015, 12:11 a.m., Jie

Re: Review Request 34968: Fixed a deadlock in libprocess Metrics initialization.

2015-06-02 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34968/#review86341 --- Ship it! Ship It! - Vinod Kone On June 3, 2015, 1:07 a.m., Ben

Re: Review Request 35239: Update the JSON model for Resources to display their revocablility attribute.

2015-06-09 Thread Vinod Kone
in them. - Vinod Kone On June 9, 2015, 12:38 a.m., Jiang Yan Xu wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35239

Re: Review Request 35270: make a bunch of JSONP callback URLs in mesos UI protocol-relative

2015-06-09 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35270/#review87318 --- Ship it! Ship It! - Vinod Kone On June 9, 2015, 11:31 p.m

Re: Review Request 34260: Replaced os::dirname and os::basename with Path::dirname and Path::basename.

2015-06-23 Thread Vinod Kone
://reviews.apache.org/r/34260/#comment141598 include path header? - Vinod Kone On June 23, 2015, 8:26 a.m., Till Toenshoff wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34260

Re: Review Request 35773: Removed libgen.h include.

2015-06-23 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35773/#review89003 --- Ship it! Ship It! - Vinod Kone On June 23, 2015, 8:29 a.m

Re: Review Request 34258: Removed os::dirname and os::basename.

2015-06-23 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34258/#review89002 --- Ship it! Ship It! - Vinod Kone On June 23, 2015, 8:26 a.m

Re: Review Request 35775: Removed libgen.h include.

2015-06-23 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35775/#review89005 --- Ship it! Ship It! - Vinod Kone On June 23, 2015, 8:27 a.m

Re: Review Request 35774: Removed libgen.h include.

2015-06-23 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35774/#review89004 --- Ship it! Ship It! - Vinod Kone On June 23, 2015, 8:26 a.m

Re: Review Request 34256: Added Path::dirname() and Path::basename().

2015-06-23 Thread Vinod Kone
slashes? 3rdparty/libprocess/3rdparty/stout/include/stout/path.hpp (line 81) https://reviews.apache.org/r/34256/#comment141591 s/non trailing// ? - Vinod Kone On June 23, 2015, 8:26 a.m., Till Toenshoff wrote

Re: Review Request 35797: Updated FrameworkInfo to update capabilities (Part 1)

2015-06-23 Thread Vinod Kone
/master.hpp (lines 535 - 539) https://reviews.apache.org/r/35797/#comment141667 I think you can simply do info.mutable_capabilities()-CopyFrom(source.capabilities()); - Vinod Kone On June 23, 2015, 8:08 p.m., Aditi Dixit wrote

Review Request 35680: Added Sorter::allocation() overload for getting resources of a particular slave.

2015-06-19 Thread Vinod Kone
, Vinod Kone

Review Request 35679: Added benchmark test for Allocator::updateSlave().

2015-06-19 Thread Vinod Kone
in 7.720996758secs Updated 1 slaves in 16.4897123807167mins [ OK ] SlaveCount/HierarchicalAllocator_BENCHMARK_Test.UpdateSlave/2 (999001 ms) Thanks, Vinod Kone

Review Request 35682: Sped up Allocator::updateSlave() and Allocator::updateAllocation().

2015-06-19 Thread Vinod Kone
ms) [--] 6 tests from SlaveCount/HierarchicalAllocator_BENCHMARK_Test (169998 ms total) Thanks, Vinod Kone

Re: Review Request 35715: Added revocable resource state validation.

2015-06-21 Thread Vinod Kone
://reviews.apache.org/r/35715/#comment141265 These checks are done in master's validation.cpp - Vinod Kone On June 21, 2015, 5:10 p.m., Michael Park wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r

Re: Review Request 35841: Fix usage of ATOMIC_FLAG_INIT

2015-06-25 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35841/#review89415 --- Ship it! Ship It! - Vinod Kone On June 25, 2015, 5:27 p.m

Re: Review Request 35861: Correct include list errors for stout

2015-06-25 Thread Vinod Kone
/stout/abort.hpp (line 20) https://reviews.apache.org/r/35861/#comment142017 get rid of this? 3rdparty/libprocess/3rdparty/stout/include/stout/ip.hpp (line 17) https://reviews.apache.org/r/35861/#comment142018 new line? - Vinod Kone On June 25, 2015, 6:32 p.m., Paul Brett wrote

Re: Review Request 35836: Replaced slave's 'available' with 'allocated' in hierarchical allocator.

2015-06-25 Thread Vinod Kone
) https://reviews.apache.org/r/35836/#comment141965 For posterity, can you add a comment here on why we store allocated in the allocator despite having that information in the sorter? - Vinod Kone On June 24, 2015, 9:53 p.m., Jie Yu wrote

Review Request 35857: Added Acknowledge call support to the master and the C++ scheduler library.

2015-06-24 Thread Vinod Kone
/scheduler/scheduler.cpp 1efc6fb351e49deaa8f626823592bc9155f5137b Diff: https://reviews.apache.org/r/35857/diff/ Testing --- make check NOTE: Didn't add a new test because an existing test (SchedulerTest.TaskRunning) already exercises this code path. Thanks, Vinod Kone

Review Request 35858: Added Message call support to the master and the C++ scheduler library.

2015-06-24 Thread Vinod Kone
/scheduler/scheduler.cpp 1efc6fb351e49deaa8f626823592bc9155f5137b src/tests/scheduler_tests.cpp cbe6c91a1b4f864ceb11cf062da0ada6c9666f9f Diff: https://reviews.apache.org/r/35858/diff/ Testing --- make check Thanks, Vinod Kone

Re: Review Request 35815: Testing JSON paylodad in ZooKeeper

2015-06-24 Thread Vinod Kone
in the test. - Vinod Kone On June 24, 2015, 6:01 p.m., Marco Massenzio wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35815

Review Request 35856: Added Revive call support to the master and C++ scheduler library.

2015-06-24 Thread Vinod Kone
/scheduler/scheduler.cpp 1efc6fb351e49deaa8f626823592bc9155f5137b src/tests/scheduler_tests.cpp cbe6c91a1b4f864ceb11cf062da0ada6c9666f9f Diff: https://reviews.apache.org/r/35856/diff/ Testing --- make check Thanks, Vinod Kone

Review Request 35855: Added Decline call support to the master and C++ scheduler library.

2015-06-24 Thread Vinod Kone
/scheduler/scheduler.cpp 1efc6fb351e49deaa8f626823592bc9155f5137b src/tests/scheduler_tests.cpp cbe6c91a1b4f864ceb11cf062da0ada6c9666f9f Diff: https://reviews.apache.org/r/35855/diff/ Testing --- make check Thanks, Vinod Kone

Re: Review Request 35857: Added Acknowledge call support to the master and the C++ scheduler library.

2015-06-24 Thread Vinod Kone
(SchedulerTest.TaskRunning) already exercises this code path. Thanks, Vinod Kone

Re: Review Request 35855: Added Decline call support to the master and C++ scheduler library.

2015-06-24 Thread Vinod Kone
--- make check Thanks, Vinod Kone

Re: Review Request 35571: Adding ability to decode JSON from ZK

2015-06-18 Thread Vinod Kone
generated e-mail. To reply, visit: https://reviews.apache.org/r/35571/ --- (Updated June 18, 2015, 3:31 p.m.) Review request for mesos, Niklas Nielsen and Vinod Kone. Bugs: MESOS-2340 https://issues.apache.org/jira/browse

Re: Review Request 35571: Adding ability to decode JSON from ZK

2015-06-18 Thread Vinod Kone
and #481. - Vinod Kone On June 18, 2015, 3:31 p.m., Marco Massenzio wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35571

  1   2   3   4   5   6   7   8   9   10   >