Martin Betak has posted comments on this change.
Change subject: rng: allow urandom as virtio rng entropy source
..
Patch Set 5: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/59031
To unsubscribe, visit
Martin Betak has posted comments on this change.
Change subject: rpc: Add test for 'int' parameters in Bridge
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/56884/2/tests/bridgeTests.py
File tests/bridgeTests.py:
Martin Betak has posted comments on this change.
Change subject: rpc: Add test for 'int' parameters in Bridge
..
Patch Set 2: Verified+1
--
To view, visit https://gerrit.ovirt.org/56884
To unsubscribe, visit
Martin Betak has posted comments on this change.
Change subject: rpc: Add test for 'int' parameters in Bridge
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/56884/1/tests/bridgeTests.py
File tests/bridgeTests.py:
Martin Betak has posted comments on this change.
Change subject: rpc: Add test for 'int' parameters in Bridge
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/56884/1/tests/bridgeTests.py
File tests/bridgeTests.py:
Martin Betak has posted comments on this change.
Change subject: rpc: Make Bridge#_type_fixup more robust
..
Patch Set 1:
(1 comment)
Added a test for this in https://gerrit.ovirt.org/#/c/56884/1 but because it
depends on
Martin Betak has posted comments on this change.
Change subject: rpc: Add test for 'int' parameters in Bridge
..
Patch Set 1: Verified+1
Verified by running tests.
--
To view, visit https://gerrit.ovirt.org/56884
To
Martin Betak has uploaded a new change for review.
Change subject: rpc: Add test for 'int' parameters in Bridge
..
rpc: Add test for 'int' parameters in Bridge
Change-Id: Ie8a2672c53411bed1ac711fffccb543bcfb16024
Signed-off-by:
Martin Betak has posted comments on this change.
Change subject: rpc: Make Bridge#_type_fixup more robust
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/56811/1/lib/vdsm/rpc/Bridge.py
File lib/vdsm/rpc/Bridge.py:
Martin Betak has posted comments on this change.
Change subject: rpc: Make Bridge#_type_fixup more robust
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/56811
To unsubscribe, visit
Martin Betak has posted comments on this change.
Change subject: migration: Enable lazy setting of incoming/outgoing limits
..
Patch Set 27: Verified+1
--
To view, visit https://gerrit.ovirt.org/53305
To unsubscribe, visit
Martin Betak has uploaded a new change for review.
Change subject: rpc: Make Bridge#_type_fixup more robust
..
rpc: Make Bridge#_type_fixup more robust
_type_fixup method assumed that all top-level arguments of rpc calls are
Martin Betak has posted comments on this change.
Change subject: migration: Enable lazy setting of incoming/outgoing limits
..
Patch Set 25:
(2 comments)
https://gerrit.ovirt.org/#/c/53305/25//COMMIT_MSG
Commit Message:
Martin Betak has posted comments on this change.
Change subject: migration: Enable lazy setting of incoming/outgoing limits
..
Patch Set 21:
(1 comment)
https://gerrit.ovirt.org/#/c/53305/21/vdsm/API.py
File vdsm/API.py:
Martin Betak has posted comments on this change.
Change subject: migration: Add Dynamic Bounded Semaphores
..
Patch Set 23:
(2 comments)
https://gerrit.ovirt.org/#/c/53304/23/tests/vmUtilsTests.py
File tests/vmUtilsTests.py:
Martin Betak has posted comments on this change.
Change subject: migration: Add Dynamic Bounded Semaphores
..
Patch Set 23: Verified+1
Verfied using unit tests. Since last patch-set was test-only change, restoring
+V.
--
To
Martin Betak has posted comments on this change.
Change subject: migration: Add Dynamic Bounded Semaphores
..
Patch Set 22:
(7 comments)
https://gerrit.ovirt.org/#/c/53304/22/tests/vmUtilsTests.py
File tests/vmUtilsTests.py:
Martin Betak has posted comments on this change.
Change subject: migration: Add Dynamic Bounded Semaphores
..
Patch Set 21: Verified+1
--
To view, visit https://gerrit.ovirt.org/53304
To unsubscribe, visit
Martin Betak has posted comments on this change.
Change subject: migration: Add retry on full capacity
..
Patch Set 27: Verified+1
--
To view, visit https://gerrit.ovirt.org/52799
To unsubscribe, visit
Martin Betak has posted comments on this change.
Change subject: migration: Add retry on full capacity
..
Patch Set 27:
(1 comment)
https://gerrit.ovirt.org/#/c/52799/27/vdsm/virt/migration.py
File vdsm/virt/migration.py:
Martin Betak has posted comments on this change.
Change subject: migration: Add retry on full capacity
..
Patch Set 26:
(1 comment)
https://gerrit.ovirt.org/#/c/52799/26/vdsm/virt/migration.py
File vdsm/virt/migration.py:
Martin Betak has posted comments on this change.
Change subject: migration: Enable lazy setting of incoming/outgoing limits
..
Patch Set 21:
(1 comment)
https://gerrit.ovirt.org/#/c/53305/21/vdsm/API.py
File vdsm/API.py:
Martin Betak has posted comments on this change.
Change subject: migration: Enable cancellation of migrations during retry
..
Patch Set 1:
Verified using the standard mass migration suite and cancelling a migration in
the 10
Martin Betak has posted comments on this change.
Change subject: migration: Add Dynamic Bounded Semaphores
..
Patch Set 20: Verified+1
--
To view, visit https://gerrit.ovirt.org/53304
To unsubscribe, visit
Martin Betak has posted comments on this change.
Change subject: migration: Add Dynamic Bounded Semaphores
..
Patch Set 18:
(1 comment)
https://gerrit.ovirt.org/#/c/53304/18/lib/vdsm/virt/utils.py
File lib/vdsm/virt/utils.py:
Martin Betak has posted comments on this change.
Change subject: migration: Enable lazy setting of incoming/outgoing limits
..
Patch Set 20:
(3 comments)
https://gerrit.ovirt.org/#/c/53305/20/lib/api/vdsmapi-schema.json
File
Martin Betak has posted comments on this change.
Change subject: migration: Add retry on full capacity
..
Patch Set 26: Verified+1
--
To view, visit https://gerrit.ovirt.org/52799
To unsubscribe, visit
Martin Betak has posted comments on this change.
Change subject: migration: Enable cancellation of migrations during retry
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/55742
To unsubscribe, visit
Martin Betak has uploaded a new change for review.
Change subject: migration: Enable cancellation of migrations during retry
..
migration: Enable cancellation of migrations during retry
Migrated _migrationCancelledEvent to
Martin Betak has posted comments on this change.
Change subject: migration: Add retry on full capacity
..
Patch Set 23:
(1 comment)
https://gerrit.ovirt.org/#/c/52799/23/vdsm/virt/migration.py
File vdsm/virt/migration.py:
Martin Betak has posted comments on this change.
Change subject: migration: Add retry on full capacity
..
Patch Set 25:
(2 comments)
https://gerrit.ovirt.org/#/c/52799/23/vdsm/virt/migration.py
File vdsm/virt/migration.py:
Martin Betak has posted comments on this change.
Change subject: migration: Add retry on full capacity
..
Patch Set 25:
(1 comment)
https://gerrit.ovirt.org/#/c/52799/25/vdsm/virt/migration.py
File vdsm/virt/migration.py:
Martin Betak has posted comments on this change.
Change subject: migration: Add retry on full capacity
..
Patch Set 23:
(1 comment)
https://gerrit.ovirt.org/#/c/52799/23/vdsm/virt/migration.py
File vdsm/virt/migration.py:
Martin Betak has posted comments on this change.
Change subject: migration: Add retry on full capacity
..
Patch Set 25:
(1 comment)
https://gerrit.ovirt.org/#/c/52799/25/vdsm/virt/migration.py
File vdsm/virt/migration.py:
Martin Betak has posted comments on this change.
Change subject: migration: Add DynamicThrottling semaphores
..
Patch Set 18:
(1 comment)
https://gerrit.ovirt.org/#/c/53304/18/tests/vmUtilsTests.py
File tests/vmUtilsTests.py:
Martin Betak has posted comments on this change.
Change subject: migration: Add DynamicThrottling semaphores
..
Patch Set 18:
(1 comment)
https://gerrit.ovirt.org/#/c/53304/18/lib/vdsm/virt/utils.py
File
Martin Betak has posted comments on this change.
Change subject: migration: Add DynamicThrottling semaphores
..
Patch Set 18:
(1 comment)
https://gerrit.ovirt.org/#/c/53304/18/tests/vmUtilsTests.py
File tests/vmUtilsTests.py:
Martin Betak has posted comments on this change.
Change subject: migration: Add retry on full capacity
..
Patch Set 23:
(1 comment)
https://gerrit.ovirt.org/#/c/52799/23/vdsm/virt/migration.py
File vdsm/virt/migration.py:
Martin Betak has posted comments on this change.
Change subject: migration: Add retry on full capacity
..
Patch Set 23:
(1 comment)
https://gerrit.ovirt.org/#/c/52799/23/vdsm/virt/migration.py
File vdsm/virt/migration.py:
Martin Betak has posted comments on this change.
Change subject: migration: Add retry on full capacity
..
Patch Set 23:
(2 comments)
https://gerrit.ovirt.org/#/c/52799/23/vdsm/virt/migration.py
File vdsm/virt/migration.py:
Martin Betak has posted comments on this change.
Change subject: migration: Add retry on full capacity
..
Patch Set 23:
(2 comments)
https://gerrit.ovirt.org/#/c/52799/23/lib/vdsm/config.py.in
File lib/vdsm/config.py.in:
Martin Betak has posted comments on this change.
Change subject: migration: Add retry on full capacity
..
Patch Set 23:
(3 comments)
https://gerrit.ovirt.org/#/c/52799/23/vdsm/virt/migration.py
File vdsm/virt/migration.py:
Martin Betak has posted comments on this change.
Change subject: migration: Add DynamicThrottling semaphores
..
Patch Set 17: Verified+1
--
To view, visit https://gerrit.ovirt.org/53304
To unsubscribe, visit
Martin Betak has posted comments on this change.
Change subject: migration: Add retry on full capacity
..
Patch Set 22: Verified+1
--
To view, visit https://gerrit.ovirt.org/52799
To unsubscribe, visit
Martin Betak has posted comments on this change.
Change subject: migration: Enable lazy setting of incoming/outgoing limits
..
Patch Set 18: Verified+1
--
To view, visit https://gerrit.ovirt.org/53305
To unsubscribe, visit
Martin Betak has posted comments on this change.
Change subject: vm: Move saveState() out of constructor
..
Patch Set 7: Verified+1
Verified using standard mass migration process with extreme throttling to
trigger multiple
Martin Betak has posted comments on this change.
Change subject: vm: Move saveState() out of constructor
..
Patch Set 6:
(1 comment)
https://gerrit.ovirt.org/#/c/53950/6/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 685:
Martin Betak has posted comments on this change.
Change subject: vm: Move saveState() out of constructor
..
Patch Set 6:
(1 comment)
https://gerrit.ovirt.org/#/c/53950/6/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 685:
Martin Betak has posted comments on this change.
Change subject: vm: Move saveState() out of constructor
..
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/53950/3/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 686:
Martin Betak has posted comments on this change.
Change subject: migration: Add retry on full capacity
..
Patch Set 20:
@Yaniv: Indeed it is true that scheduler in ideal scenario should cover 99% of
cases. This code is there
Martin Betak has posted comments on this change.
Change subject: response: Add support for specific error checking in is_error
..
Patch Set 2:
@fromani: Sure, verified by running tests and also by full e2e manual tests of
Martin Betak has posted comments on this change.
Change subject: migration: Add retry on full capacity
..
Patch Set 18: Verified+1
--
To view, visit https://gerrit.ovirt.org/52799
To unsubscribe, visit
Martin Betak has posted comments on this change.
Change subject: migration: Enable lazy setting of incoming/outgoing limits
..
Patch Set 14: Verified+1
--
To view, visit https://gerrit.ovirt.org/53305
To unsubscribe, visit
Martin Betak has posted comments on this change.
Change subject: vm: Move saveState() out of constructor
..
Patch Set 3: Verified+1
--
To view, visit https://gerrit.ovirt.org/53950
To unsubscribe, visit
Martin Betak has posted comments on this change.
Change subject: response: Add support for specific error checking in is_error
..
Patch Set 2: Verified+1
--
To view, visit https://gerrit.ovirt.org/54036
To unsubscribe, visit
Martin Betak has posted comments on this change.
Change subject: response: Add support for specific error checking in is_error
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/54036/1/tests/responseTests.py
File
Martin Betak has posted comments on this change.
Change subject: migration: Add DynamicThrottling semaphores
..
Patch Set 11:
(1 comment)
https://gerrit.ovirt.org/#/c/53304/11/vdsm/virt/utils.py
File vdsm/virt/utils.py:
Line
Martin Betak has uploaded a new change for review.
Change subject: response: Add support for specific error checking in is_error
..
response: Add support for specific error checking in is_error
response.is_error can now take an
Martin Betak has posted comments on this change.
Change subject: migration: Add retry on full capacity
..
Patch Set 14:
(1 comment)
https://gerrit.ovirt.org/#/c/52799/14/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 686:
Martin Betak has uploaded a new change for review.
Change subject: vm: Move saveState() out of constructor
..
vm: Move saveState() out of constructor
Moved saveState() call to the begining of async start of VM in order to:
*
Martin Betak has posted comments on this change.
Change subject: migration: Add retry on full capacity
..
Patch Set 14:
(1 comment)
https://gerrit.ovirt.org/#/c/52799/14/vdsm/virt/migration.py
File vdsm/virt/migration.py:
Martin Betak has posted comments on this change.
Change subject: virt: add run_async helper
..
Patch Set 14:
no longer needed but still pretty nice piece of code I would say. Pity that
gerrit doesn't have *Archive* feature
Martin Betak has abandoned this change.
Change subject: utils: Add @throttle decorator
..
Abandoned
--
To view, visit https://gerrit.ovirt.org/47087
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType:
Martin Betak has abandoned this change.
Change subject: migration: Add migrateChangeGlobalParams verb
..
Abandoned
superceeded by I79ab97f15788e4024c94d051e4aade713d760acf
--
To view, visit https://gerrit.ovirt.org/47409
To
Martin Betak has abandoned this change.
Change subject: migration: Add retry logic for incoming limit
..
Abandoned
superceeded by I988fa2e501eb77d121668b22cc533b744a3dc755
--
To view, visit https://gerrit.ovirt.org/46971
To
Martin Betak has posted comments on this change.
Change subject: virt: Make VM domain descriptor accessible
..
Patch Set 2: Verified+1
--
To view, visit https://gerrit.ovirt.org/53371
To unsubscribe, visit
Martin Betak has posted comments on this change.
Change subject: virt: Replace vm._dom.XMLDesc(0) with domain descriptor usage
..
Patch Set 4: Verified+1
--
To view, visit https://gerrit.ovirt.org/52882
To unsubscribe, visit
Martin Betak has abandoned this change.
Change subject: virt: vm.py: Make _updateDomainDescriptor() return new XML
..
Abandoned
--
To view, visit https://gerrit.ovirt.org/53372
To unsubscribe, visit
Martin Betak has posted comments on this change.
Change subject: virt: Make VM domain descriptor public
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/53371/1/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 291:
Martin Betak has posted comments on this change.
Change subject: migration: Add incoming migration semaphore
..
Patch Set 31: Verified+1
--
To view, visit https://gerrit.ovirt.org/45954
To unsubscribe, visit
Martin Betak has posted comments on this change.
Change subject: migration: Add retry on full capacity
..
Patch Set 13: Verified+1
--
To view, visit https://gerrit.ovirt.org/52799
To unsubscribe, visit
Martin Betak has posted comments on this change.
Change subject: migration: Enable lazy setting of incoming/outgoing limits
..
Patch Set 9: Verified+1
--
To view, visit https://gerrit.ovirt.org/53305
To unsubscribe, visit
Martin Betak has posted comments on this change.
Change subject: migration: Add DynamicThrottling semaphores
..
Patch Set 8: Verified+1
--
To view, visit https://gerrit.ovirt.org/53304
To unsubscribe, visit
Martin Betak has posted comments on this change.
Change subject: vm: Make run() return status
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/53745
To unsubscribe, visit https://gerrit.ovirt.org/settings
Martin Betak has uploaded a new change for review.
Change subject: vm: Make run() return status
..
vm: Make run() return status
Change-Id: Ia21eefb7ff9ccb144c000c620788567692489f11
Signed-off-by: Martin Betak
Martin Betak has posted comments on this change.
Change subject: migration: Enable lazy setting of incoming/outgoing limits
..
Patch Set 6: Verified+1
--
To view, visit https://gerrit.ovirt.org/53305
To unsubscribe, visit
Martin Betak has posted comments on this change.
Change subject: migration: Add DynamicThrottling semaphores
..
Patch Set 5: Verified+1
--
To view, visit https://gerrit.ovirt.org/53304
To unsubscribe, visit
Martin Betak has posted comments on this change.
Change subject: migration: Add DynamicThrottling semaphores
..
Patch Set 4: Verified+1
--
To view, visit https://gerrit.ovirt.org/53304
To unsubscribe, visit
Martin Betak has posted comments on this change.
Change subject: migration: Add retry on full capacity
..
Patch Set 10: Verified+1
--
To view, visit https://gerrit.ovirt.org/52799
To unsubscribe, visit
Martin Betak has posted comments on this change.
Change subject: migration: Add incoming migration semaphore
..
Patch Set 28: Verified+1
--
To view, visit https://gerrit.ovirt.org/45954
To unsubscribe, visit
Martin Betak has posted comments on this change.
Change subject: virt: add run_async helper
..
Patch Set 14: Verified+1
--
To view, visit https://gerrit.ovirt.org/49570
To unsubscribe, visit https://gerrit.ovirt.org/settings
Martin Betak has posted comments on this change.
Change subject: migration: Add DynamicThrottling semaphores
..
Patch Set 3:
(2 comments)
https://gerrit.ovirt.org/#/c/53304/3/tests/vmUtilsTests.py
File tests/vmUtilsTests.py:
Martin Betak has posted comments on this change.
Change subject: migration: Add DynamicThrottling semaphores
..
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/53304/3/tests/vmUtilsTests.py
File tests/vmUtilsTests.py:
Martin Betak has posted comments on this change.
Change subject: migration: Add DynamicThrottling semaphores
..
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/53304/3/tests/vmUtilsTests.py
File tests/vmUtilsTests.py:
Martin Betak has posted comments on this change.
Change subject: migration: Add DynamicThrottling semaphores
..
Patch Set 3:
(2 comments)
https://gerrit.ovirt.org/#/c/53304/3/tests/vmUtilsTests.py
File tests/vmUtilsTests.py:
Martin Betak has posted comments on this change.
Change subject: virt: add run_async helper
..
Patch Set 11:
(3 comments)
https://gerrit.ovirt.org/#/c/49570/11//COMMIT_MSG
Commit Message:
Line 11: support
> supportS
Done
Martin Betak has posted comments on this change.
Change subject: virt: Replace vm._dom.XMLDesc(0) with domain descriptor usage
..
Patch Set 1:
(2 comments)
https://gerrit.ovirt.org/#/c/52882/1/vdsm/virt/vm.py
File
Martin Betak has uploaded a new change for review.
Change subject: virt: Make VM domain descriptor public
..
virt: Make VM domain descriptor public
Change-Id: I58dacec299fd6176b10b4180e2737d6b2f59ccbc
Signed-off-by: Martin
Martin Betak has uploaded a new change for review.
Change subject: virt: vm.py: Make _updateDomainDescriptor() return new XML
..
virt: vm.py: Make _updateDomainDescriptor() return new XML
Change-Id:
Martin Betak has posted comments on this change.
Change subject: virt: add run_async helper
..
Patch Set 10: Verified+1
--
To view, visit https://gerrit.ovirt.org/49570
To unsubscribe, visit https://gerrit.ovirt.org/settings
Martin Betak has uploaded a new change for review.
Change subject: migration: Enable lazy setting of incoming/outgoing limits
..
migration: Enable lazy setting of incoming/outgoing limits
Change-Id:
Martin Betak has uploaded a new change for review.
Change subject: migration: Add DynamicThrottling semaphores
..
migration: Add DynamicThrottling semaphores
Change-Id: I67376d0bd990f89e0a013887cef1a0cb05fb855d
Signed-off-by:
Martin Betak has posted comments on this change.
Change subject: numa: only use libvirt for memory info
..
Patch Set 4:
(1 comment)
https://gerrit.ovirt.org/#/c/53091/4//COMMIT_MSG
Commit Message:
Line 10: depending on the
Martin Betak has posted comments on this change.
Change subject: numa: only use libvirt for memory info
..
Patch Set 5: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/53091
To unsubscribe, visit
Martin Betak has posted comments on this change.
Change subject: hooks: Remove dead code from before_vm_migrate_destination
..
Patch Set 3: Verified+1
--
To view, visit https://gerrit.ovirt.org/52998
To unsubscribe, visit
Martin Betak has abandoned this change.
Change subject: vdsm: Remove unreachable code
..
Abandoned
duplicate change
--
To view, visit https://gerrit.ovirt.org/52997
To unsubscribe, visit https://gerrit.ovirt.org/settings
Martin Betak has posted comments on this change.
Change subject: vdsm: Remove unreachable code
..
Patch Set 2: Verified+1
--
To view, visit https://gerrit.ovirt.org/52980
To unsubscribe, visit
Martin Betak has uploaded a new change for review.
Change subject: hooks: Remove dead code from before_vm_migrate_destination
..
hooks: Remove dead code from before_vm_migrate_destination
Change-Id:
Martin Betak has uploaded a new change for review.
Change subject: vdsm: Remove unreachable code
..
vdsm: Remove unreachable code
Change-Id: Ie84749d01a735bc8177c7d16fb0612636f547004
Signed-off-by: Martin Betak
Martin Betak has posted comments on this change.
Change subject: vdsm: Remove unreachable code
..
Patch Set 2:
split the hook part as per mpolednik's request
--
To view, visit https://gerrit.ovirt.org/52980
To unsubscribe,
1 - 100 of 249 matches
Mail list logo