Michael Ho has posted comments on this change.
Change subject: IMPALA-4026: Implement double-buffering for BlockingQueue.
..
Patch Set 2:
Patch #2 reverts to using the boost library condition variable for now. Given
the wide
Michael Ho has uploaded a new patch set (#2).
Change subject: IMPALA-4026: Implement double-buffering for BlockingQueue.
..
IMPALA-4026: Implement double-buffering for BlockingQueue.
With recent changes to improve the parquet
Michael Ho has posted comments on this change.
Change subject: IMPALA-4026: Implement double-buffering for BlockingQueue.
..
Patch Set 1:
(3 comments)
It appears to me that primitive_conjunct_odering_5 and
Michael Ho has posted comments on this change.
Change subject: IMPALA-4026: Implement double-buffering for BlockingQueue.
..
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/4350/1//COMMIT_MSG
Commit Message:
Michael Ho has posted comments on this change.
Change subject: IMPALA-4026: Implement double-buffering for BlockingQueue.
..
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/4350/1//COMMIT_MSG
Commit Message:
Michael Ho has posted comments on this change.
Change subject: IMPALA-4026: Implement double-buffering for BlockingQueue.
..
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/4350/1//COMMIT_MSG
Commit Message:
Michael Ho has posted comments on this change.
Change subject: IMPALA-1616: Improve the Memory Limit Exceeded error report
..
Patch Set 3: Code-Review+1
(1 comment)
Michael Ho has posted comments on this change.
Change subject: IMPALA-4008: don't bake in hash table and hash join pointers
..
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/4326/2/be/src/exec/hash-table.cc
File
Michael Ho has uploaded a new change for review.
http://gerrit.cloudera.org:8080/4350
Change subject: IMPALA-4026: Implement double-buffering for BlockingQueue.
..
IMPALA-4026: Implement double-buffering for BlockingQueue.
Michael Ho has posted comments on this change.
Change subject: IMPALA-4008: don't bake in hash table and hash join pointers
..
Patch Set 2:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/4326/2/be/src/exec/hash-table.cc
Michael Ho has posted comments on this change.
Change subject: IMPALA-4008: don't bake in hash table and hash join pointers
..
Patch Set 2:
(12 comments)
http://gerrit.cloudera.org:8080/#/c/4326/2/be/src/exec/hash-table.cc
Michael Ho has posted comments on this change.
Change subject: IMPALA-3815: clean up cross-compiled comparator
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/4307
To unsubscribe, visit
Michael Ho has posted comments on this change.
Change subject: IMPALA-3637,IMPALA-3636: refactor codegen constant replacement
..
Patch Set 2:
(16 comments)
The change looks good. Mostly comments are about clarification in
Michael Ho has posted comments on this change.
Change subject: IMPALA-4051: Avoid unnecessary copy of RowDescriptor into
RowBatch
..
Patch Set 2:
(1 comment)
Michael Ho has posted comments on this change.
Change subject: IMPALA-2831: Bound the number of scanner threads per scan node.
..
Patch Set 4:
(1 comment)
Michael Ho has posted comments on this change.
Change subject: IMPALA-2831: Bound the number of scanner threads per scan node.
..
Patch Set 5: Code-Review+2
Carry +2 forward.
--
To view, visit
Hello Dan Hecht,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4174
to look at the new patch set (#5).
Change subject: IMPALA-2831: Bound the number of scanner threads per scan node.
..
Michael Ho has posted comments on this change.
Change subject: IMPALA-2831: Bound the number of scanner threads per scan node.
..
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/4174/1//COMMIT_MSG
Commit
Michael Ho has uploaded a new patch set (#4).
Change subject: IMPALA-2831: Bound the number of scanner threads per scan node.
..
IMPALA-2831: Bound the number of scanner threads per scan node.
Our current code base allows a
Michael Ho has uploaded a new patch set (#3).
Change subject: IMPALA-2831: Bound the number of scanner threads per scan node.
..
IMPALA-2831: Bound the number of scanner threads per scan node.
Our current code base allows a
Michael Ho has posted comments on this change.
Change subject: IMPALA-2831: Bound the number of scanner threads per scan node.
..
Patch Set 1:
(2 comments)
Michael Ho has uploaded a new patch set (#2).
Change subject: IMPALA-2831: Bound the number of scanner threads per scan node.
..
IMPALA-2831: Bound the number of scanner threads per scan node.
Our current code base allows a
Michael Ho has posted comments on this change.
Change subject: IMPALA-2831: Bound the number of scanner threads per scan node.
..
Patch Set 1:
(2 comments)
Michael Ho has uploaded a new change for review.
http://gerrit.cloudera.org:8080/4174
Change subject: IMPALA-2831: Bound the number of scanner threads per scan node.
..
IMPALA-2831: Bound the number of scanner threads per
Michael Ho has posted comments on this change.
Change subject: IMPALA-4006: dangerous rm -rf statements in scripts
..
Patch Set 6: Code-Review+1
(1 comment)
http://gerrit.cloudera.org:8080/#/c/4078/6/bin/run-all-tests.sh
File
Michael Ho has posted comments on this change.
Change subject: IMPALA-4006: dangerous rm -rf statements in scripts
..
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/4078/3/bin/impala-config.sh
File
Michael Ho has posted comments on this change.
Change subject: IMPALA-4006: dangerous rm -rf statements in scripts
..
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/4078/1/bin/clean.sh
File bin/clean.sh:
PS1,
Michael Ho has posted comments on this change.
Change subject: IMPALA-4006: dangerous rm -rf statements in scripts
..
Patch Set 3:
(5 comments)
It appears that you are already fixing some of the places which are considered
Michael Ho has posted comments on this change.
Change subject: CDH-43354: Bump CDH components' versions.
..
Patch Set 1:
A core run passed:
http://sandbox.jenkins.cloudera.com/job/impala-private-build-and-test/4002/
--
To
Michael Ho has uploaded a new change for review.
http://gerrit.cloudera.org:8080/4084
Change subject: CDH-43354: Bump CDH components' versions.
..
CDH-43354: Bump CDH components' versions.
Change-Id:
Michael Ho has posted comments on this change.
Change subject: IMPALA-4006 impala-config.sh contains dangerous rm -rf
statements
..
Patch Set 1:
(12 comments)
Thanks for cleaning things up. Not sure if there is a easier way
Michael Ho has posted comments on this change.
Change subject: IMPALA-3988: Only use first 96 bits of query id
..
Patch Set 7: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/4065
To unsubscribe, visit
Michael Ho has posted comments on this change.
Change subject: IMPALA-3988: Only use first 96 bits of query id
..
Patch Set 7:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/4065/7/be/src/util/uid-util.h
File
Michael Ho has uploaded a new change for review.
http://gerrit.cloudera.org:8080/4074
Change subject: IMPALA-4004: Don't access nested types in test_failpoints.py
..
IMPALA-4004: Don't access nested types in
Michael Ho has posted comments on this change.
Change subject: IMPALA-3988: Only use first 96 bits of query id
..
Patch Set 6:
(5 comments)
http://gerrit.cloudera.org:8080/#/c/4065/6/be/src/scheduling/simple-scheduler.cc
File
Michael Ho has posted comments on this change.
Change subject: IMPALA-3662: Don't double allocate tuples buffer in parquet
scanner
..
Patch Set 3: Code-Review+2
Rebase. Carry +2.
--
To view, visit
Michael Ho has posted comments on this change.
Change subject: IMPALA-3962: Clean up scratch tuple batch on scan failures
..
Patch Set 5: Code-Review+2
Carry +2 forward.
--
To view, visit http://gerrit.cloudera.org:8080/3991
Michael Ho has posted comments on this change.
Change subject: IMPALA-3962: Clean up scratch tuple batch on scan failures
..
Patch Set 4:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/3991/4/be/src/exec/exec-node.cc
File
Hello Dan Hecht,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/3991
to look at the new patch set (#5).
Change subject: IMPALA-3962: Clean up scratch tuple batch on scan failures
..
Michael Ho has posted comments on this change.
Change subject: IMPALA-3662: Don't double allocate tuples buffer in parquet
scanner
..
Patch Set 1:
(2 comments)
Michael Ho has uploaded a new patch set (#2).
Change subject: IMPALA-3662: Don't double allocate tuples buffer in parquet
scanner
..
IMPALA-3662: Don't double allocate tuples buffer in parquet scanner
Michael Ho has uploaded a new change for review.
http://gerrit.cloudera.org:8080/4064
Change subject: IMPALA-3662: Don't double allocate tuples' buffer in parquet
scanner
..
IMPALA-3662: Don't double allocate tuples' buffer
Michael Ho has uploaded a new patch set (#4).
Change subject: IMPALA-3962: Clean up scratch tuple batch on scan failures
..
IMPALA-3962: Clean up scratch tuple batch on scan failures
The parquet scanner doesn't clean up
Michael Ho has posted comments on this change.
Change subject: IMPALA-3962: Clean up scratch tuple batch on scan failures
..
Patch Set 3:
(4 comments)
http://gerrit.cloudera.org:8080/#/c/3991/3/be/src/exec/exec-node.cc
File
Michael Ho has posted comments on this change.
Change subject: IMPALA-3090: always log memory limit errors
..
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/4049
To unsubscribe, visit
Michael Ho has posted comments on this change.
Change subject: IMPALA-3962: Clean up scratch tuple batch on scan failures
..
Patch Set 1:
(4 comments)
Michael Ho has posted comments on this change.
Change subject: IMPALA-3090: always log memory limit errors
..
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/4049/1/be/src/runtime/mem-tracker.h
File
Michael Ho has posted comments on this change.
Change subject: IMPALA-3567 Part 2, IMPALA-3899: factor out PHJ builder
..
Patch Set 4:
(16 comments)
Still going through the changes and digesting them. Some comments for now.
Michael Ho has posted comments on this change.
Change subject: IMPALA-3629: Codegen TransferScratchTuples() in
hdfs-parquet-scanner
..
Patch Set 9: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/3774
To
Michael Ho has uploaded a new patch set (#3).
Change subject: IMPALA-3962: Clean up scratch tuple batch on scan failures
..
IMPALA-3962: Clean up scratch tuple batch on scan failures
The parquet scanner doesn't clean up
Michael Ho has uploaded a new patch set (#2).
Change subject: IMPALA-3962: Clean up scratch tuple batch on scan failures
..
IMPALA-3962: Clean up scratch tuple batch on scan failures
The parquet scanner doesn't clean up
Michael Ho has posted comments on this change.
Change subject: IMPALA-3962: Clean up scratch tuple batch on scan failures
..
Patch Set 1:
To answer the question of why the stress test hit this: the query was cancelled
(I
Michael Ho has posted comments on this change.
Change subject: IMPALA-3962: Clean up scratch tuple batch on scan failures
..
Patch Set 1:
(3 comments)
Michael Ho has posted comments on this change.
Change subject: IMPALA-3962: Clean up scratch tuple batch on scan failures
..
Patch Set 1:
We probably need to create a malformed table with bad data in some columns.
--
To
Michael Ho has posted comments on this change.
Change subject: IMPALA-3964: Fix crash when a count(*) is performed on a nested
collection.
..
Patch Set 4: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/3940
Michael Ho has posted comments on this change.
Change subject: IMPALA-3201: buffer pool header only
..
Patch Set 1:
Please feel free to address them in the next patch though.
--
To view, visit
Michael Ho has posted comments on this change.
Change subject: IMPALA-3201: buffer pool header only
..
Patch Set 1:
Sorry to jump in late at this point but there are also some comments at
https://gerrit.cloudera.org/#/c/2569
Michael Ho has uploaded a new change for review.
http://gerrit.cloudera.org:8080/3991
Change subject: IMPALA-3962: Clean up scratch tuple batch on scan failures
..
IMPALA-3962: Clean up scratch tuple batch on scan failures
Michael Ho has posted comments on this change.
Change subject: IMPALA-3964: Fix crash when a count(*) is performed on a nested
collection.
..
Patch Set 3:
(1 comment)
Michael Ho has posted comments on this change.
Change subject: IMPALA-1619, IMPALA-3018: Address various small memory
allocation related bugs
..
Patch Set 2:
Added a new test in free-pool-test.cc
--
To view, visit
Hello Tim Armstrong, Dan Hecht,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/3807
to look at the new patch set (#2).
Change subject: IMPALA-1619, IMPALA-3018: Address various small memory
allocation related bugs
Michael Ho has posted comments on this change.
Change subject: IMPALA-3629: Codegen TransferScratchTuples() in
hdfs-parquet-scanner
..
Patch Set 7:
(5 comments)
Michael Ho has submitted this change and it was merged.
Change subject: IMPALA-3829: OpenSession() logs errors on valid configuration
keys
..
IMPALA-3829: OpenSession() logs errors on valid configuration keys
Refactored
Michael Ho has posted comments on this change.
Change subject: IMPALA-3964: Fix crash when a count(*) is performed on a nested
collection.
..
Patch Set 3:
(1 comment)
Michael Ho has posted comments on this change.
Change subject: IMPALA-3829: OpenSession() logs errors on valid configuration
keys
..
Patch Set 3: Code-Review+2
Carry Henry's +2 forward. Attila cannot yet +2 at this point.
--
Michael Ho has posted comments on this change.
Change subject: IMPALA-3946: fix MemPool integrity issues with empty chunks
..
Patch Set 2: Code-Review+1
(1 comment)
Michael Ho has posted comments on this change.
Change subject: IMPALA-1112: Remove some unncessary code from cross-compilation
..
Patch Set 4: Code-Review+2
Carry +2 forward.
--
To view, visit
Michael Ho has posted comments on this change.
Change subject: IMPALA-3946: fix MemPool integrity issues with empty chunks
..
Patch Set 1:
(4 comments)
Michael Ho has posted comments on this change.
Change subject: IMPALA-1731,IMPALA-3868: Float values are not parsed correctly
..
Patch Set 3: Code-Review+1
(1 comment)
Michael Ho has posted comments on this change.
Change subject: IMPALA-3637,IMPALA-3636: refactor codegen constant replacement
..
Patch Set 1:
(12 comments)
Michael Ho has posted comments on this change.
Change subject: IMPALA-3829: OpenSession() logs errors on valid configuration
keys
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/3808
To
Michael Ho has posted comments on this change.
Change subject: IMPALA-3829: OpenSession() logs errors on valid configuration
keys
..
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/3808/1/tests/hs2/test_hs2.py
Michael Ho has posted comments on this change.
Change subject: IMPALA-1731,IMPALA-3868: Float values are not parsed correctly
..
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/3791/2/be/src/exprs/expr-test.cc
Michael Ho has posted comments on this change.
Change subject: IMPALA-3629: Codegen TransferScratchTuples() in
hdfs-parquet-scanner
..
Patch Set 3:
(4 comments)
Michael Ho has uploaded a new change for review.
http://gerrit.cloudera.org:8080/3807
Change subject: IMPALA-1619, IMPALA-3018: Address various small memory
allocation related bugs
..
IMPALA-1619, IMPALA-3018: Address
Michael Ho has posted comments on this change.
Change subject: IMPALA-1112: Remove some unncessary code from cross-compilation
..
Patch Set 2:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/3793/2//COMMIT_MSG
Commit
Hello Tim Armstrong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/3793
to look at the new patch set (#3).
Change subject: IMPALA-1112: Remove some unncessary code from cross-compilation
Michael Ho has uploaded a new patch set (#2).
Change subject: IMPALA-1112: Remove some unncessary code from cross-compilation
..
IMPALA-1112: Remove some unncessary code from cross-compilation
This change stops including some
Michael Ho has abandoned this change.
Change subject: IMPALA-3906: Materialize implicitly referenced IR functions
..
Abandoned
Review is moved over to https://gerrit.cloudera.org/#/c/3792/
--
To view, visit
Michael Ho has uploaded a new change for review.
http://gerrit.cloudera.org:8080/3793
Change subject: IMPALA-1112: Remove some unncessary code from cross-compilation
..
IMPALA-1112: Remove some unncessary code from
Michael Ho has posted comments on this change.
Change subject: IMPALA-3906: Materialize implicitly referenced IR functions
..
Patch Set 4:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/3740/4/be/src/codegen/llvm-codegen.h
Michael Ho has posted comments on this change.
Change subject: IMPALA-3906: Materialize implicitly referenced IR functions
..
Patch Set 1: Code-Review+2
Review is at https://gerrit.cloudera.org/#/c/3740/. Carry +2 over.
--
Michael Ho has uploaded a new change for review.
http://gerrit.cloudera.org:8080/3792
Change subject: IMPALA-3906: Materialize implicitly referenced IR functions
..
IMPALA-3906: Materialize implicitly referenced IR functions
Hello Tim Armstrong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/3740
to look at the new patch set (#4).
Change subject: IMPALA-3906: Materialize implicitly referenced IR functions
..
Michael Ho has posted comments on this change.
Change subject: IMPALA-3906: Materialize implicitly referenced IR functions
..
Patch Set 2:
(7 comments)
http://gerrit.cloudera.org:8080/#/c/3740/2/be/src/codegen/llvm-codegen.cc
Michael Ho has posted comments on this change.
Change subject: IMPALA-3906: Materialize implicitly referenced IR functions
..
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/3740/2/be/src/codegen/llvm-codegen.h
Hello Tim Armstrong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/3740
to look at the new patch set (#3).
Change subject: IMPALA-3906: Materialize implicitly referenced IR functions
..
Michael Ho has posted comments on this change.
Change subject: IMPALA-3906: Materialize implicitly referenced IR functions
..
Patch Set 1:
(9 comments)
http://gerrit.cloudera.org:8080/#/c/3740/1/be/src/codegen/llvm-codegen.cc
Michael Ho has posted comments on this change.
Change subject: IMPALA-3906: Materialize implicitly referenced IR functions
..
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/3740/1/be/src/codegen/llvm-codegen.cc
Michael Ho has uploaded a new change for review.
http://gerrit.cloudera.org:8080/3740
Change subject: IMPALA-3906: Materialize implicitly referenced IR functions
..
IMPALA-3906: Materialize implicitly referenced IR functions
Michael Ho has posted comments on this change.
Change subject: IMPALA-3854: Fix use-after-free in HdfsTextScanner::Close()
..
Patch Set 5: Code-Review+2
Michael Ho has posted comments on this change.
Change subject: IMPALA-3854: Fix use-after-free in HdfsTextScanner::Close()
..
Patch Set 4:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/3630/4//COMMIT_MSG
Commit Message:
Hello Alex Behm, Dan Hecht,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/3630
to look at the new patch set (#5).
Change subject: IMPALA-3854: Fix use-after-free in HdfsTextScanner::Close()
Michael Ho has posted comments on this change.
Change subject: IMPALA-3637,IMPALA-3636: refactor codegen constant replacement
..
Patch Set 6:
(4 comments)
Michael Ho has posted comments on this change.
Change subject: IMPALA-3637,IMPALA-3636: refactor codegen constant replacement
..
Patch Set 6:
(2 comments)
Michael Ho has posted comments on this change.
Change subject: IMPALA-3674: Lazy materialization of LLVM module bitcode.
..
Patch Set 12:
GVM preemptively aborted due to hitting IMPALA-3470
--
To view, visit
Michael Ho has posted comments on this change.
Change subject: IMPALA-3637,IMPALA-3636: refactor codegen constant replacement
..
Patch Set 7:
Sorry, let me get back to it later today.
--
To view, visit
Michael Ho has posted comments on this change.
Change subject: IMPALA-3201: headers and reservation logic for new buffer pool
..
Patch Set 23:
(8 comments)
Michael Ho has posted comments on this change.
Change subject: IMPALA-3829: OpenSession() logs errors on valid configuration
keys
..
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/3662
To
Michael Ho has posted comments on this change.
Change subject: IMPALA-3674: Lazy materialization of LLVM module bitcode.
..
Patch Set 12: Code-Review+2
Carry +2 forward.
--
To view, visit http://gerrit.cloudera.org:8080/3220
1 - 100 of 465 matches
Mail list logo
