LGTM.
I like how simple the core diff is.
http://gwt-code-reviews.appspot.com/1520808/diff/1/user/test/com/google/web/bindery/requestfactory/gwt/client/RequestFactoryPolymorphicTest.java
File
user/test/com/google/web/bindery/requestfactory/gwt/client/RequestFactoryPolymorphicTest.java
(right):
on collapsed
property values.
Patch by: bobv
Review by: rjrjr
Please review this at http://gwt-code-reviews.appspot.com/1525804/
Affected files:
M dev/core/src/com/google/gwt/dev/cfg/BindingProperty.java
M dev/core/src/com/google/gwt/dev/cfg/PropertyPermutations.java
M dev/core/test/com/google/gwt
Reviewers: rjrjr,
Description:
Support chained requests where the returned proxy type is not reachable
from the canonical RequestContext.
Issue 6641.
Patch by: bobv
Review by: rjrjr
Please review this at http://gwt-code-reviews.appspot.com/1499810/
Affected files:
M user/src/com/google/web
PTAL
http://gwt-code-reviews.appspot.com/1499810/diff/1/user/src/com/google/web/bindery/autobean/vm/impl/FactoryHandler.java
File
user/src/com/google/web/bindery/autobean/vm/impl/FactoryHandler.java
(right):
http://gwt-code-reviews.appspot.com/1503804/diff/1/samples/dynatablerf/build.xml
File samples/dynatablerf/build.xml (right):
http://gwt-code-reviews.appspot.com/1503804/diff/1/samples/dynatablerf/build.xml#newcode8
samples/dynatablerf/build.xml:8: !-- Run the annotation processor --
On
Per offline conversation, I've removed the annotation processor from
requestfactory-client.jar. This means that the server code must be
built with requestfactory-apt.jar, but doesn't need to be deployed with
it.
http://gwt-code-reviews.appspot.com/1503804/
--
Reviewers: rjrjr,
Message:
Review requested.
Description:
Prevent an AutoBean property named property from causing a compilation
error.
Patch by: bobv
Review by: rjrjr
Please review this at http://gwt-code-reviews.appspot.com/1505804/
Affected files:
M
user/src/com/google/web/bindery
:
import com.google.gwt.dev.util.collect.HashSet;
Weird import problem.
Description:
Replace RequestFactoryInterfaceValidator with an
annotation-processor-based approach.
Add a ValidationTool to precompute server and JRE-client metadata.
Patch by: bobv
Review by: rjrjr, tbroyer
Please review
Reviewers: rjrjr,
Description:
Improve error message when a RequestFactory 2.3 request is received.
Issue 6628.
Patch by: bobv
Review by: rjrjr
Please review this at http://gwt-code-reviews.appspot.com/1503803/
Affected files:
M
user/src/com/google/web/bindery/requestfactory/server
Reviewers: rjrjr,
Message:
This is a re-spin of a patch that was written back in October but that
got dropped. The original patch is at
http://gwt-code-reviews.appspot.com/943802.
Description:
Add font-face support to CssResource.
Patch by: bobv
Review by: rjrjr
Please review this at http
Reviewers: drfibonacci,
Description:
Only require @Service mapping for RequestContext types referenced from a
RequestFactory.
This allows RequestContext base types to be defined.
Patch by: bobv
Review by: drfibonacci
Please review this at http://gwt-code-reviews.appspot.com/1478803/
Affected
Reviewers: pquitslund,
Description:
Use erasure to handle wildcard types in RfValidator.
Restore FindRequest to 2.4 parameterization.
Patch by: bobv
Review by: pquitslund
Please review this at http://gwt-code-reviews.appspot.com/1467814/
Affected files:
M
user/src/com/google/web/bindery
Reviewers: rchandia,
Description:
Bypass RfValidatorTest when no JDK is available.
Patch by: bobv
Review by: rchandia
Please review this at http://gwt-code-reviews.appspot.com/1465810/
Affected files:
M user/test/com/google/web/bindery/requestfactory/apt/RfValidatorTest.java
Index:
user
Reviewers: keertip, pquitslund, tbroyer,
Description:
Add compile-time tests for APT-based RequestFactory interface validator.
Move all validator message formatting to a single class.
Patch by: bobv
Review by: keertip,pquitslund, t.broyer
Suggested by: t.broyer
Please review this at http://gwt
:
On 2011/06/30 15:16:48, bobv wrote:
This is more verbose, but it will unambiguously identify the
unchecked method
in
question.
This doesn't print what one would expect:
Another place where Eclipse and javac differ :-)
I don't mind having the warning on the getId method because of a
previous
I was able to recreate the stack overflow with type variables as simple
as T extends EnumT. The latest patch addresses this and I've
changed the error-handling code to trap Throwables to fail better.
On Wed, Jun 29, 2011 at 8:46 AM, t.bro...@gmail.com wrote:
Still having stackoverflows when enabling the annotation processor in
Eclipse. The error I got the last time I tried had a very similar
stacktrace (see below).
Do you have any self-parameterized types? FooQ extends FooQ kind
of
LGTM
http://gwt-code-reviews.appspot.com/1462804/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
LGTM
http://gwt-code-reviews.appspot.com/1470801/diff/1/user/test/com/google/gwt/dev/jjs/test/SingleJsoImplTest.java
File user/test/com/google/gwt/dev/jjs/test/SingleJsoImplTest.java
(right):
1) I changed the State.maybeX() methods to add their jobs to a
work-queue instead of processing them immediately. I think that should
significantly reduce the stack depth.
2) Requiring a @ProxyFor annotation has also been deferred until after
all types have been scanned. This should prevent
LGTM
I wonder why the optional attribute of the classpath entry wasn't
preventing this from causing problems.
http://gwt-code-reviews.appspot.com/1466807/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Updated patch incorporating Thomas's feedback.
http://gwt-code-reviews.appspot.com/1467804/diff/1/user/build.xml
File user/build.xml (right):
http://gwt-code-reviews.appspot.com/1467804/diff/1/user/build.xml#newcode155
user/build.xml:155: exclude
the RequestFactoryInterfaceValidator and
it's classfile-based approach.
Patch by: bobv
Review by: ???
Please review this at http://gwt-code-reviews.appspot.com/1467804/
Affected files:
M eclipse/samples/DynaTableRf/.classpath
A eclipse/samples/DynaTableRf/.factorypath
M user/build.xml
A
user/src/com
On Wed, Jun 22, 2011 at 4:57 AM, Thomas Broyer t.bro...@gmail.com wrote:
I'm trying to add a unit test for issue 5926 and I don't know how to deal
with the TypeTokenResolver to easily run the test from within Eclipse.
I enabled the requestfactory-apt.jar annotation processor on the gwt-user
LGTM. Will commit and integrate into 2.4 branch.
http://gwt-code-reviews.appspot.com/1467802/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/1451818/diff/5001/user/src/com/google/gwt/core/client/ScriptInjector.java
File user/src/com/google/gwt/core/client/ScriptInjector.java (right):
But I wonder: isn't this change making RequestFactory incompatible with
AppEngine?
Reverting to original behavior of calling cleanup() from get()/set().
--
Bob Vawter
Google Web Toolkit Team
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
by: bobv
Review by: rjrjr, rice
Please review this at http://gwt-code-reviews.appspot.com/1462801/
Affected files:
M user/src/com/google/web/bindery/requestfactory/apt/RfApt.java
M
user/src/com/google/web/bindery/requestfactory/vm/impl/TypeTokenResolver.java
Index: user/src/com/google/web
Reviewers: rjrjr,
Description:
Add some test framework code for RequestFactory to support simple load
testing.
Patch by: bobv
Review by: rjrjr
Please review this at http://gwt-code-reviews.appspot.com/1453814/
Affected files:
M
user/src/com/google/web/bindery/requestfactory/server
LGTM
http://gwt-code-reviews.appspot.com/1446819/diff/3008/user/src/com/google/gwt/event/shared/LegacyHandlerWrapper.java
File user/src/com/google/gwt/event/shared/LegacyHandlerWrapper.java
(right):
http://gwt-code-reviews.appspot.com/1453814/diff/1/user/src/com/google/web/bindery/requestfactory/vm/testing/UrlRequestTransport.java
File
user/src/com/google/web/bindery/requestfactory/vm/testing/UrlRequestTransport.java
(right):
. The heaps could be made smaller if it weren't for the Unicode
tests having insanely nesting.
Description:
Ensure all ProxyAutoBeans not directly referenced from root object or
via a shim can be garbage-collected.
Issue 6193.
Patch by: bobv
Suggested by: t.broyer
Review by: rjrjr
Please review
Just a look at the user/src classes so far.
http://gwt-code-reviews.appspot.com/1449817/diff/4001/user/src/com/google/gwt/user/client/ui/DefaultEventBusProvider.java
File user/src/com/google/gwt/user/client/ui/DefaultEventBusProvider.java
(right):
http://gwt-code-reviews.appspot.com/1449817/diff/4001/user/src/com/google/gwt/user/client/ui/IsEventSource.java
File user/src/com/google/gwt/user/client/ui/IsEventSource.java (right):
copied from http://gwt-code-reviews.appspot.com/1377804
Patch by: bobv, tbroyer
Review by: rjrjr, tbroyer
Please review this at http://gwt-code-reviews.appspot.com/1453813/
Affected files:
M user/src/com/google/web/bindery/requestfactory/server/Resolver.java
M
user/src/com/google/web/bindery
http://gwt-code-reviews.appspot.com/1453813/diff/1/user/src/com/google/web/bindery/requestfactory/server/Resolver.java
File user/src/com/google/web/bindery/requestfactory/server/Resolver.java
(right):
Reviewers: rjrjr, jasonhall,
Description:
Add ServerFailure.getRequestContext().
Provide getters for Request - RequestContext - RequestFactory -
RequestTransport.
Add fakes for modified interfaces.
Patch by: bobv
Review by: rjrjr
Suggested by: jasonhall
Please review this at http://gwt-code
Fixed lame comment and committed at r10316.
http://gwt-code-reviews.appspot.com/1451815/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Both polymorphic return and parameter values are supported. Turns out
that polymorphic parameters already worked.
Committed at r10317.
http://gwt-code-reviews.appspot.com/1453811/diff/1/user/src/com/google/web/bindery/requestfactory/gwt/rebind/model/RequestFactoryModel.java
File
Reviewers: rjrjr,
Description:
Clean up RequestFactoryInterfaceValidator and Deobfuscator to simplify
ResolverServiceLayer.
This allows the validator to be jettisoned in favor of a lighter-weight
object.
Patch by: bobv
Review by: rjrjr
Please review this at http://gwt-code-reviews.appspot.com
Ready for another look.
http://gwt-code-reviews.appspot.com/1447815/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
an obfuscated type manifest and add
it
to the gwt-user project. This is only necessary when using the
JRE-compatible
RequestFactory client code.
Review at http://gwt-code-reviews.appspot.com/1447815
Patch by: bobv
Review by: rjrjr
Some release notes also added to the relevant issues:
6234
Reviewers: rjrjr,
Description:
Suport polymorphic return values in RequestFactory.
Issue 5367.
Patch by: bobv
Review by: rjrjr
Please review this at http://gwt-code-reviews.appspot.com/1453811/
Affected files:
M
user/src/com/google/web/bindery/requestfactory/gwt/rebind
http://gwt-code-reviews.appspot.com/1447815/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
To verify that the annotation processor is working in Eclipse, open up
the Error Log view. You should see diagnostic messages from the
processor. I'll turn those off before final submission. Since this
patch updates the gwt-user project, you might need to shut Eclipse down
first before
Reviewers: rjrjr,
Description:
Support is/has methods in Editor framework.
Issue 6040.
Patch by: bobv
Review by: rjrjr
Please review this at http://gwt-code-reviews.appspot.com/1443812/
Affected files:
M user/src/com/google/gwt/editor/rebind/model/EditorModel.java
M user/test/com/google
LGTM
http://gwt-code-reviews.appspot.com/1451808/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Reviewers: rjrjr,
Description:
Add a way to disable image inlining on a per-image basis.
Patch by: bobv
Review by: rjrjr
Please review this at http://gwt-code-reviews.appspot.com/1451809/
Affected files:
M user/src/com/google/gwt/resources/client/ImageResource.java
M user/src/com/google
Reviewers: rjrjr,
Description:
Mass auto-format of RequestFactory code before landing a big patch.
Patch by: bobv
Review by: rjrjr
Please review this at http://gwt-code-reviews.appspot.com/1450811/
Affected files:
M
user/src/com/google/web/bindery/requestfactory/gwt/client
to
create the operation.
Use obfuscated type and operation tokens to reduce payload and JS size
(issue
5394). Without this change, the operation tokens can be excessively
lengthy. The RequestFactory interface is used as the gwt.rpc analog.
Patch by: bobv
Review by: rjrjr
Please review this at http
{
Re-sorted the file.
Description:
Add a test to RequestFactoryInterfaceValidator that the findFoo() domain
method is static.
http://code.google.com/p/google-web-toolkit/issues/detail?id=6428
Patch by: bobv
Review by: rjrjr
Reported by: zundel
Please review this at http://gwt-code
Reviewers: rjrjr,
Description:
Use identity semantics when canonicalizing JsonSplittable instances.
This is necessary to support Android, where the org.json arrays appear
to have value-based equality.
http://code.google.com/p/google-web-toolkit/issues/detail?id=6390
Patch by: bobv
Review
The base interface for RequestFactory service endpoints.
Add disclaimer explaining that this interface (and the others) are
normally
implemented by generated code, and are subject to incompatible
updates?
Done. Also added a FakeRequestContext base type in a testing
subpackage.
And should
On Thu, May 26, 2011 at 2:23 PM, Thomas Broyer t.bro...@gmail.com wrote:
How about simply using a ServiceLayerDecorator that overrides
resolveLocator, delegating to super.resolveLocator and, if it returns null
then return the default locator instead?
+1
The ServiceLayer design is intended to
Reviewers: rjrjr,
Description:
Add BatchedRequestScope utility class to aggregate all requests made
within a single tick of the event loop.
Add FanoutReceiver utility class.
Remove redundant tests from RequestFactoryGwtJreSuite.
Patch by: bobv
Review by: rjrjr
Please review this at http://gwt
http://gwt-code-reviews.appspot.com/1449804/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
type.
Patch by: bobv
Review by: rjrjr
Please review this at http://gwt-code-reviews.appspot.com/1448806/
Affected files:
M
user/src/com/google/web/bindery/requestfactory/shared/RequestContext.java
M
user/src/com/google/web/bindery/requestfactory/shared/RequestFactory.java
M
user/src
http://gwt-code-reviews.appspot.com/1442807/diff/4001/dev/core/src/com/google/gwt/core/ext/soyc/impl/SplitPointRecorder.java
File
dev/core/src/com/google/gwt/core/ext/soyc/impl/SplitPointRecorder.java
(right):
Does it makes sense
to add the ServletContext into RequestFactoryServlet inside GWT proper? If
so, I can submit a patch for you.
That sounds like a very clean approach. When you submit the patch,
please create an issue in the GWT issue tracker with the URL of the
code review.
--
Bob Vawter
the -Xmx value.
Description:
Fix AutoBean VM memory leak due to circular references between the
ProxyAutoBean, ShimHandler, and WeakReference.
Issue 6193.
Patch by: bobv
Review by: tbroyer, rjrjr
Please review this at http://gwt-code-reviews.appspot.com/1448803/
Affected files:
M user/src/com
Reviewers: zundel,
Description:
Fix inconsistent use of finishTest() in RequestFactoryTest.
Patch by: bobv
Review by: zundel
Please review this at http://gwt-code-reviews.appspot.com/1421808/
Affected files:
M
user/test/com/google/web/bindery/requestfactory/gwt/client
On Wed, Apr 27, 2011 at 10:56 PM, Patrick Julien pjul...@gmail.com wrote:
How does this actually work?
class MyEditor implements HasRequestConextFoo {
// HasRequestContext extends the Editor interface
}
If I implement HasRequestContextT anywhere, the containing request
factory editor driver
LGTM
http://gwt-code-reviews.appspot.com/1423808/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/1425808/diff/1/samples/mobilewebapp/src/com/google/gwt/sample/mobilewebapp/client/activity/TaskEditActivity.java
File
samples/mobilewebapp/src/com/google/gwt/sample/mobilewebapp/client/activity/TaskEditActivity.java
(right):
Which to me leaves the question: is our usage described at [1] an
intended use case, that's here to stay? or simply a fortunate
unspecified behavior, and we should change our code to this new
append() feature?
For now, I'm going to call it a fortunate unspecified behavior. At
some point in
http://code.google.com/p/google-web-toolkit/wiki/RequestFactoryMovingParts
The RFMP doc is targeted at potential contributors or those with
non-trivial integration schemes. For those who have been using
RequestFactory, what implementation details would you like to have
more documentation on?
.
Description:
Switch RequestFactory to use the real ConstraintViolation instead of the
hacky Violation interface.
Deprecate Violation and Receiver.onViolation().
Patch by: bobv
Review by: rjrjr
Please review this at http://gwt-code-reviews.appspot.com/1422809/
Affected files:
M
samples/dynatablerf
Reviewers: rjrjr,
Description:
Add RequestContext.append() to allow actions across different domain
service types to be combined in a single HTTP request.
Patch by: bobv
Review by: rjrjr
Please review this at http://gwt-code-reviews.appspot.com/1423805/
Affected files:
M
user/src/com
LGTM
http://gwt-code-reviews.appspot.com/1428802/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
r10052
http://gwt-code-reviews.appspot.com/1423805/diff/1/user/src/com/google/web/bindery/requestfactory/shared/impl/AbstractRequestContext.java
File
user/src/com/google/web/bindery/requestfactory/shared/impl/AbstractRequestContext.java
(right):
r10053
http://gwt-code-reviews.appspot.com/1422809/diff/1/user/src/com/google/web/bindery/requestfactory/gwt/client/impl/AbstractRequestFactoryEditorDriver.java
File
user/src/com/google/web/bindery/requestfactory/gwt/client/impl/AbstractRequestFactoryEditorDriver.java
(right):
http://gwt-code-reviews.appspot.com/1425805/diff/3002/user/src/com/google/web/bindery/requestfactory/server/RequestFactoryJarExtractor.java
File
user/src/com/google/web/bindery/requestfactory/server/RequestFactoryJarExtractor.java
(right):
LGTM.
http://gwt-code-reviews.appspot.com/1420803/diff/31/dev/core/src/com/google/gwt/dev/jjs/ast/JAnnotation.java
File dev/core/src/com/google/gwt/dev/jjs/ast/JAnnotation.java (left):
LGTM
http://gwt-code-reviews.appspot.com/1423803/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Committed with minor modifications at r10022.
http://gwt-code-reviews.appspot.com/1338807/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
LGTM.
http://gwt-code-reviews.appspot.com/1425804/diff/1/user/src/com/google/gwt/event/shared/EventBus.java
File user/src/com/google/gwt/event/shared/EventBus.java (right):
http://gwt-code-reviews.appspot.com/1425804/diff/1/user/src/com/google/gwt/event/shared/EventBus.java#newcode28
http://gwt-code-reviews.appspot.com/1380807/diff/11003/user/src/com/google/gwt/user/rebind/rpc/Shared.java
File user/src/com/google/gwt/user/rebind/rpc/Shared.java (right):
http://gwt-code-reviews.appspot.com/1380807/diff/11003/user/src/com/google/gwt/user/rebind/rpc/Shared.java#newcode56
On Mon, Apr 18, 2011 at 1:26 PM, Ray Ryan rj...@google.com wrote:
This looks like a job for…bobv!
Will check this out tonight.
--
Bob Vawter
Google Web Toolkit Team
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
This code needs comments. I'm having a hard time figuring out what it
does.
http://gwt-code-reviews.appspot.com/1424803/diff/1/dev/core/src/com/google/gwt/dev/cfg/PropertyPermutations.java
File dev/core/src/com/google/gwt/dev/cfg/PropertyPermutations.java
(right):
Updated the patch, remembering to move the client.impl code into
autobean.gwt.client.impl.
http://gwt-code-reviews.appspot.com/1414803/diff/1/user/src/com/google/web/bindery/autobean/vm/AutoBeanFactorySource.java
File
user/src/com/google/web/bindery/autobean/vm/AutoBeanFactorySource.java
LGTM
http://gwt-code-reviews.appspot.com/1394803/diff/10001/user/src/com/google/gwt/event/shared/HandlerManager.java
File user/src/com/google/gwt/event/shared/HandlerManager.java (right):
Reviewers: rjrjr, rice,
Description:
Move AutoBean package to com.google.web.bindery.autobean package.
http://code.google.com/p/google-web-toolkit/issues/detail?id=6253
Patch by: bobv
Review by: rjrjr
Please review this at http://gwt-code-reviews.appspot.com/1414803/
Affected files:
M tools
LGTM
http://gwt-code-reviews.appspot.com/1414801/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/1380807/diff/4001/user/src/com/google/gwt/user/rebind/rpc/SerializableTypeOracleBuilder.java
File
user/src/com/google/gwt/user/rebind/rpc/SerializableTypeOracleBuilder.java
(right):
reify := make real
I found a couple of bugs running internal test suites that have been
fixed in the latest patch with a test added to the GWT code base.
http://gwt-code-reviews.appspot.com/1407802/diff/1/user/src/com/google/gwt/autobean/rebind/AutoBeanFactoryGenerator.java
File
Re-rolling the patch with changes just to JsoSplittable and
SplittableTest to fix the Safari4 test failure and improve the
robustness of the type detection code.
http://gwt-code-reviews.appspot.com/1407802/diff/6001/user/src/com/google/gwt/autobean/client/impl/JsoSplittable.java
File
Reviewers: rice,
Description:
Reformat autobeans package to cut down on diff churn for lazy
reification patch.
Patch by: bobv
Review by: rice
Please review this at http://gwt-code-reviews.appspot.com/1407801/
Affected files:
M
user/src/com/google/gwt/autobean/client/impl
LGTM
http://gwt-code-reviews.appspot.com/1406801/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Reviewers: rice, rjrjr,
Description:
Convert AutoBeans to use JSOs as their backing store with lazy
reification of
values.
Use JsonSplittable in DevMode to avoid JSNI overhead.
Patch by: bobv
Review by: rice, rjrjr
Please review this at http://gwt-code-reviews.appspot.com/1407802/
Affected
LVGTM
http://gwt-code-reviews.appspot.com/1403802/diff/4105/user/src/com/google/web/bindery/requestfactory/vm/RequestFactorySource.java
File
user/src/com/google/web/bindery/requestfactory/vm/RequestFactorySource.java
(right):
This change would break the contract of the WeakMapping, since the
value object isn't guaranteed to outlive the key object.
A better way to fix AutoBeans is to only use WeakMapping for
non-generated bean implementations, and have the shim implement a
private interface that's queried by
[+scottb, jbrosenberg]
Jason or Scott, can you take a look at this? You have been working in
this area more recently than I.
Please review this at http://gwt-code-reviews.appspot.com/1357804/
--
Bob Vawter
Google Web Toolkit Team
--
The move looks pretty straightforward. Just some thoughts that occurred
to me while looking at this:
- RequestFactoryMagic should be moved out of the testing sub-package.
- Are we happy with the client, shared, server package naming scheme?
- Should the GWT-specific code in the new
http://gwt-code-reviews.appspot.com/1380807/diff/1001/user/src/com/google/gwt/user/rebind/rpc/FieldSerializerCreator.java
File user/src/com/google/gwt/user/rebind/rpc/FieldSerializerCreator.java
(right):
Hollow out the to-be-deleted classes to avoid the massive duplication of
code going on in this patch. The old types should extend the new types
and where that isn't possible, the old type should be rewritten as a
delegate.
Anything in the rebind or **/impl packages can be a straight move.
Here's the plan:
http://code.google.com/p/google-web-toolkit/wiki/ProtocolBuffers
If you are using protocol buffers in your backend, what features or
concerns are important to you in extending pb's into your GWT client
code?
--
Bob Vawter
Google Web Toolkit Team
--
LGTM w/ nits.
http://gwt-code-reviews.appspot.com/1384806/diff/2001/user/test/com/google/gwt/requestfactory/shared/ServiceInheritanceTest.java
File
user/test/com/google/gwt/requestfactory/shared/ServiceInheritanceTest.java
(right):
Add the base test class to RequestFactorySuite.
http://gwt-code-reviews.appspot.com/1384802/diff/4001/user/src/com/google/gwt/requestfactory/server/ServiceLayer.java
File user/src/com/google/gwt/requestfactory/server/ServiceLayer.java
(right):
LGTM.
http://gwt-code-reviews.appspot.com/1387801/diff/5/user/src/com/google/gwt/core/client/AsyncProvider.java
File user/src/com/google/gwt/core/client/AsyncProvider.java (right):
How about http://gwt-code-reviews.appspot.com/1374804 instead to allow
developer control over the classloader instead?
--
Bob Vawter
Google Web Toolkit Team
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
1 - 100 of 723 matches
Mail list logo
