[
https://issues.apache.org/jira/browse/HBASE-19092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17252562#comment-17252562
]
Michael Stack commented on HBASE-19092:
---
I was just looking at cleaning up our tall Cell hierarchy
[
https://issues.apache.org/jira/browse/HBASE-19092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16273842#comment-16273842
]
Ted Yu commented on HBASE-19092:
Ram:
Can you update the release notes ?
There is some typo, e.g.
[
https://issues.apache.org/jira/browse/HBASE-19092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16265199#comment-16265199
]
Hudson commented on HBASE-19092:
FAILURE: Integrated in Jenkins build HBase-2.0 #907 (See
[
https://issues.apache.org/jira/browse/HBASE-19092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16265100#comment-16265100
]
Hudson commented on HBASE-19092:
FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #4109 (See
[
https://issues.apache.org/jira/browse/HBASE-19092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16265007#comment-16265007
]
Chia-Ping Tsai commented on HBASE-19092:
bq. I think we can add a release note after HBASE-19112?
[
https://issues.apache.org/jira/browse/HBASE-19092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16264999#comment-16264999
]
ramkrishna.s.vasudevan commented on HBASE-19092:
I think we can add a release note after
[
https://issues.apache.org/jira/browse/HBASE-19092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16264641#comment-16264641
]
ramkrishna.s.vasudevan commented on HBASE-19092:
[~anoop.hbase]
Do you want to have a
[
https://issues.apache.org/jira/browse/HBASE-19092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16264232#comment-16264232
]
Chia-Ping Tsai commented on HBASE-19092:
Some trivial comment are in rb. LGTM overall.
[
https://issues.apache.org/jira/browse/HBASE-19092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16263817#comment-16263817
]
ramkrishna.s.vasudevan commented on HBASE-19092:
Thanks for the reviews. Any other
[
https://issues.apache.org/jira/browse/HBASE-19092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16263816#comment-16263816
]
ramkrishna.s.vasudevan commented on HBASE-19092:
Ya getType should be in RawCell but that
[
https://issues.apache.org/jira/browse/HBASE-19092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16263353#comment-16263353
]
Hadoop QA commented on HBASE-19092:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-19092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16263335#comment-16263335
]
stack commented on HBASE-19092:
---
bq. But one thing is that now as part of this patch we are now making
[
https://issues.apache.org/jira/browse/HBASE-19092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16263000#comment-16263000
]
ramkrishna.s.vasudevan commented on HBASE-19092:
[~chia7712] FYI.
> Make Tag
[
https://issues.apache.org/jira/browse/HBASE-19092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16262974#comment-16262974
]
ramkrishna.s.vasudevan commented on HBASE-19092:
bq.RawCell had Tags-only and the
[
https://issues.apache.org/jira/browse/HBASE-19092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16262857#comment-16262857
]
stack commented on HBASE-19092:
---
RawCell would have the Tag APIs we've added to ExtendedCell. In the CP doc
[
https://issues.apache.org/jira/browse/HBASE-19092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16262409#comment-16262409
]
Hadoop QA commented on HBASE-19092:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-19092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16262278#comment-16262278
]
Chia-Ping Tsai commented on HBASE-19092:
bq. I mean the hard task part of applying
[
https://issues.apache.org/jira/browse/HBASE-19092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16262256#comment-16262256
]
ramkrishna.s.vasudevan commented on HBASE-19092:
bq.Our formatter is obsolete. see
[
https://issues.apache.org/jira/browse/HBASE-19092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16262247#comment-16262247
]
Chia-Ping Tsai commented on HBASE-19092:
Let me file a issue for formatter
> Make Tag
[
https://issues.apache.org/jira/browse/HBASE-19092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16262246#comment-16262246
]
Chia-Ping Tsai commented on HBASE-19092:
bq. Fixes test cases and checkstyle. I have not fixed
[
https://issues.apache.org/jira/browse/HBASE-19092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16262165#comment-16262165
]
ramkrishna.s.vasudevan commented on HBASE-19092:
bq.Perhaps it is time to introduce the
[
https://issues.apache.org/jira/browse/HBASE-19092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16262117#comment-16262117
]
Chia-Ping Tsai commented on HBASE-19092:
{quote}
The alternatives are taking us away from where
[
https://issues.apache.org/jira/browse/HBASE-19092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16262083#comment-16262083
]
Hadoop QA commented on HBASE-19092:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-19092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16262034#comment-16262034
]
stack commented on HBASE-19092:
---
I'd be +1 on 003. What you think [~anoop.hbase] (or [~chia7712] -- are you
[
https://issues.apache.org/jira/browse/HBASE-19092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16261972#comment-16261972
]
ramkrishna.s.vasudevan commented on HBASE-19092:
bq.. An ugly typecast is ok for now I'd
[
https://issues.apache.org/jira/browse/HBASE-19092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16261450#comment-16261450
]
stack commented on HBASE-19092:
---
bq. So you agree with putting the getTags and getTag in ExtendedCell?
[
https://issues.apache.org/jira/browse/HBASE-19092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16260311#comment-16260311
]
ramkrishna.s.vasudevan commented on HBASE-19092:
bq. its just not clean in hbase2. I
[
https://issues.apache.org/jira/browse/HBASE-19092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16259093#comment-16259093
]
Anoop Sam John commented on HBASE-19092:
Yep. That is what we want ideally. It is not so simple
[
https://issues.apache.org/jira/browse/HBASE-19092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16259080#comment-16259080
]
Chia-Ping Tsai commented on HBASE-19092:
bq. We want Tags to be part of Cell. When we do it for
[
https://issues.apache.org/jira/browse/HBASE-19092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16258858#comment-16258858
]
Anoop Sam John commented on HBASE-19092:
bq. we want Tags integral to Cell, not apart as they
[
https://issues.apache.org/jira/browse/HBASE-19092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16258835#comment-16258835
]
stack commented on HBASE-19092:
---
[~anoop.hbase] says
bq. This will look as a bad design IMHO.
... if CPs
[
https://issues.apache.org/jira/browse/HBASE-19092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16258818#comment-16258818
]
ramkrishna.s.vasudevan commented on HBASE-19092:
bq.Tag#get(Cell) might be best for now
[
https://issues.apache.org/jira/browse/HBASE-19092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16257323#comment-16257323
]
stack commented on HBASE-19092:
---
bq. But we can not chnage the server to work with ExtCell now.
Right. As
[
https://issues.apache.org/jira/browse/HBASE-19092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16257298#comment-16257298
]
Anoop Sam John commented on HBASE-19092:
Ya for creation of Cells, they will get an
[
https://issues.apache.org/jira/browse/HBASE-19092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16257290#comment-16257290
]
stack commented on HBASE-19092:
---
bq. All the CPs get the type as Cell not ExtendedCell.
What is the
[
https://issues.apache.org/jira/browse/HBASE-19092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16257283#comment-16257283
]
Anoop Sam John commented on HBASE-19092:
All the CPs get the type as Cell not ExtendedCell. Now
[
https://issues.apache.org/jira/browse/HBASE-19092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16256976#comment-16256976
]
Chia-Ping Tsai commented on HBASE-19092:
bq. So he was of the opinion that since CPs are not
[
https://issues.apache.org/jira/browse/HBASE-19092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16256705#comment-16256705
]
ramkrishna.s.vasudevan commented on HBASE-19092:
The main discussion with Anoop was that
[
https://issues.apache.org/jira/browse/HBASE-19092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16256598#comment-16256598
]
stack commented on HBASE-19092:
---
Yeah, would be good if CPs didn't have to concern themselves w/ type.
ECB
[
https://issues.apache.org/jira/browse/HBASE-19092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16256493#comment-16256493
]
ramkrishna.s.vasudevan commented on HBASE-19092:
bq.We still need TagUtil?
Ya. Some
[
https://issues.apache.org/jira/browse/HBASE-19092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16256048#comment-16256048
]
stack commented on HBASE-19092:
---
Took a look at patch. Looks good.
We still need TagUtil?
Should CPs know
[
https://issues.apache.org/jira/browse/HBASE-19092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16255040#comment-16255040
]
Hadoop QA commented on HBASE-19092:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-19092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16253815#comment-16253815
]
Hadoop QA commented on HBASE-19092:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-19092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16253511#comment-16253511
]
Anoop Sam John commented on HBASE-19092:
Latest patch is there in RB? If not pls put.
> Make Tag
[
https://issues.apache.org/jira/browse/HBASE-19092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16253014#comment-16253014
]
Hadoop QA commented on HBASE-19092:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-19092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16253012#comment-16253012
]
stack commented on HBASE-19092:
---
bq. Tag.asList(Cell)
This sounds like a good idea. Better if CPs don't
[
https://issues.apache.org/jira/browse/HBASE-19092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16252992#comment-16252992
]
Hadoop QA commented on HBASE-19092:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-19092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16252986#comment-16252986
]
ramkrishna.s.vasudevan commented on HBASE-19092:
So in another JIRA I saw a discussion
[
https://issues.apache.org/jira/browse/HBASE-19092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16251756#comment-16251756
]
ramkrishna.s.vasudevan commented on HBASE-19092:
I did a grep on the Timeline server code
[
https://issues.apache.org/jira/browse/HBASE-19092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16251713#comment-16251713
]
stack commented on HBASE-19092:
---
Of course. I can have a go if u run out of time.
> Make Tag
[
https://issues.apache.org/jira/browse/HBASE-19092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16251684#comment-16251684
]
ramkrishna.s.vasudevan commented on HBASE-19092:
bq.Can we try converting their code
[
https://issues.apache.org/jira/browse/HBASE-19092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16251655#comment-16251655
]
stack commented on HBASE-19092:
---
bq. Lets get feed back from the timeline server folks.
Can we try
[
https://issues.apache.org/jira/browse/HBASE-19092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16251393#comment-16251393
]
Anoop Sam John commented on HBASE-19092:
TagUtil (no 's') if for each of the Tag. It act on one
[
https://issues.apache.org/jira/browse/HBASE-19092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16251317#comment-16251317
]
ramkrishna.s.vasudevan commented on HBASE-19092:
bq.Is PrivateCellUtil used in Mutation?
[
https://issues.apache.org/jira/browse/HBASE-19092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16251222#comment-16251222
]
Anoop Sam John commented on HBASE-19092:
bq.{@link PrivateCellUtil#MAX_TAGS_LENGTH} define, in
[
https://issues.apache.org/jira/browse/HBASE-19092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16250980#comment-16250980
]
stack commented on HBASE-19092:
---
Is PrivateCellUtil used in Mutation? Is PCU what CU became?
TagUtil.clone
[
https://issues.apache.org/jira/browse/HBASE-19092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16250942#comment-16250942
]
Hadoop QA commented on HBASE-19092:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-19092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16244451#comment-16244451
]
stack commented on HBASE-19092:
---
Responded up on doc [~ram_krish]
> Make Tag IA.LimitedPrivate and expose
[
https://issues.apache.org/jira/browse/HBASE-19092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16244437#comment-16244437
]
stack commented on HBASE-19092:
---
Timeline Service creates Tags. How we do that? Looking at doc...
> Make
[
https://issues.apache.org/jira/browse/HBASE-19092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16244323#comment-16244323
]
ramkrishna.s.vasudevan commented on HBASE-19092:
[~saint.ack[~saint@gmail.com]
I have
[
https://issues.apache.org/jira/browse/HBASE-19092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16239144#comment-16239144
]
stack commented on HBASE-19092:
---
Thanks for the write-up [~ram_krish] I added some notes. Lets do a few
[
https://issues.apache.org/jira/browse/HBASE-19092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16237392#comment-16237392
]
ramkrishna.s.vasudevan commented on HBASE-19092:
Added a doc link to continue the
[
https://issues.apache.org/jira/browse/HBASE-19092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16227119#comment-16227119
]
ramkrishna.s.vasudevan commented on HBASE-19092:
bq.What you thnking? I think adding
[
https://issues.apache.org/jira/browse/HBASE-19092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16227049#comment-16227049
]
stack commented on HBASE-19092:
---
bq. My point was let us add all static helper methods to work on
[
https://issues.apache.org/jira/browse/HBASE-19092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16227033#comment-16227033
]
ramkrishna.s.vasudevan commented on HBASE-19092:
bq.Would this include means of building
[
https://issues.apache.org/jira/browse/HBASE-19092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16226782#comment-16226782
]
stack commented on HBASE-19092:
---
bq. I think instead of LPTagUtil we could add all the static methods to
[
https://issues.apache.org/jira/browse/HBASE-19092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16226552#comment-16226552
]
ramkrishna.s.vasudevan commented on HBASE-19092:
The list of APIs are
{code}
[
https://issues.apache.org/jira/browse/HBASE-19092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16226516#comment-16226516
]
Anoop Sam John commented on HBASE-19092:
What all CellUtil APIs we would need in LP exposed util?
[
https://issues.apache.org/jira/browse/HBASE-19092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16226504#comment-16226504
]
ramkrishna.s.vasudevan commented on HBASE-19092:
bq. Like the matching methods, these
[
https://issues.apache.org/jira/browse/HBASE-19092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16226491#comment-16226491
]
Anoop Sam John commented on HBASE-19092:
bq.I think instead of LPTagUtil we could add all the
[
https://issues.apache.org/jira/browse/HBASE-19092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16226484#comment-16226484
]
ramkrishna.s.vasudevan commented on HBASE-19092:
I think instead of LPTagUtil we could
[
https://issues.apache.org/jira/browse/HBASE-19092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16226303#comment-16226303
]
ramkrishna.s.vasudevan commented on HBASE-19092:
bq.Yes. Was thinking getCellBuilder.
[
https://issues.apache.org/jira/browse/HBASE-19092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16226279#comment-16226279
]
stack commented on HBASE-19092:
---
Yes. Was thinking getCellBuilder. They'd maybe need a tags builder too? Or
[
https://issues.apache.org/jira/browse/HBASE-19092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16226274#comment-16226274
]
ramkrishna.s.vasudevan commented on HBASE-19092:
Ok seeing your comment now. Will read it
[
https://issues.apache.org/jira/browse/HBASE-19092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16226273#comment-16226273
]
ramkrishna.s.vasudevan commented on HBASE-19092:
bq.Could even filter it via the CP Env
[
https://issues.apache.org/jira/browse/HBASE-19092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16226269#comment-16226269
]
stack commented on HBASE-19092:
---
bq. Which means for CPs we don't give them a chance to build a tag.
We
[
https://issues.apache.org/jira/browse/HBASE-19092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16226254#comment-16226254
]
ramkrishna.s.vasudevan commented on HBASE-19092:
bq.At this stage I'd say just let them
[
https://issues.apache.org/jira/browse/HBASE-19092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16225535#comment-16225535
]
stack commented on HBASE-19092:
---
bq. So I thought a new builder is better rather than using the
[
https://issues.apache.org/jira/browse/HBASE-19092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16224413#comment-16224413
]
ramkrishna.s.vasudevan commented on HBASE-19092:
bq.For CellUtil, would it make sense to
[
https://issues.apache.org/jira/browse/HBASE-19092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16224409#comment-16224409
]
ramkrishna.s.vasudevan commented on HBASE-19092:
Thanks for the comments
[
https://issues.apache.org/jira/browse/HBASE-19092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16223758#comment-16223758
]
Josh Elser commented on HBASE-19092:
bq. Is there any overlap between CellUtil,
[
https://issues.apache.org/jira/browse/HBASE-19092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16223685#comment-16223685
]
stack commented on HBASE-19092:
---
Thanks for working on this [~ram_krish]
Is there any overlap between
[
https://issues.apache.org/jira/browse/HBASE-19092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16223518#comment-16223518
]
Hadoop QA commented on HBASE-19092:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-19092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16223385#comment-16223385
]
ramkrishna.s.vasudevan commented on HBASE-19092:
[~vrushalic]
Pls have a look at let us
[
https://issues.apache.org/jira/browse/HBASE-19092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16222672#comment-16222672
]
Anoop Sam John commented on HBASE-19092:
I dont think this patch is complete. Also we need a LP
[
https://issues.apache.org/jira/browse/HBASE-19092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16222653#comment-16222653
]
stack commented on HBASE-19092:
---
What is status here? Let me retry this patch. Do we want to get this in
[
https://issues.apache.org/jira/browse/HBASE-19092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16221755#comment-16221755
]
ramkrishna.s.vasudevan commented on HBASE-19092:
bq.You fellows going to make a Builder
[
https://issues.apache.org/jira/browse/HBASE-19092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16221752#comment-16221752
]
stack commented on HBASE-19092:
---
You fellows going to make a Builder then for Tags?
Lets worry about
[
https://issues.apache.org/jira/browse/HBASE-19092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16221698#comment-16221698
]
ramkrishna.s.vasudevan commented on HBASE-19092:
bq.We now have CellUtil (public),
[
https://issues.apache.org/jira/browse/HBASE-19092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16221697#comment-16221697
]
ramkrishna.s.vasudevan commented on HBASE-19092:
Yes. Once we start exposing Tags for CPs
[
https://issues.apache.org/jira/browse/HBASE-19092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16221564#comment-16221564
]
Anoop Sam John commented on HBASE-19092:
Tag was just a class in 0.98 and even in 1.x also I
[
https://issues.apache.org/jira/browse/HBASE-19092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16221427#comment-16221427
]
Vrushali C commented on HBASE-19092:
Also, yarn timeline service is using hbase 1.2.6 since that was
[
https://issues.apache.org/jira/browse/HBASE-19092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16221424#comment-16221424
]
Vrushali C commented on HBASE-19092:
Hi [~stack]
So here is the code:
[
https://issues.apache.org/jira/browse/HBASE-19092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16221409#comment-16221409
]
stack commented on HBASE-19092:
---
[~vrushalic] Pardon me, trying to use your info above. How do you do
[
https://issues.apache.org/jira/browse/HBASE-19092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16221257#comment-16221257
]
stack commented on HBASE-19092:
---
Thats great info [~vrushalic] Thank you. Helps.
> Make Tag
[
https://issues.apache.org/jira/browse/HBASE-19092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16221242#comment-16221242
]
Vrushali C commented on HBASE-19092:
So here is what we use in Timeline Service
We import {code}
[
https://issues.apache.org/jira/browse/HBASE-19092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16221152#comment-16221152
]
Appy commented on HBASE-19092:
--
Yes, only the interface please.
And these utils & their scope! The way we
[
https://issues.apache.org/jira/browse/HBASE-19092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16220775#comment-16220775
]
ramkrishna.s.vasudevan commented on HBASE-19092:
bq.It imports hbase Tag. Iterates them.
[
https://issues.apache.org/jira/browse/HBASE-19092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16220732#comment-16220732
]
stack commented on HBASE-19092:
---
Yeah, do we need to expose implementations? Can we just do the API?
Have
[
https://issues.apache.org/jira/browse/HBASE-19092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16220323#comment-16220323
]
ramkrishna.s.vasudevan commented on HBASE-19092:
bq.Only Tag interface has to be exposed
1 - 100 of 105 matches
Mail list logo
