[MediaWiki-commits] [Gerrit] Optimize all use sections in Client - change (mediawiki...Wikibase)

2014-11-15 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has submitted this change and it was merged. Change subject: Optimize all use sections in Client .. Optimize all use sections in Client Change-Id: I6ab1d09a3e55ac7d8b25362c187969015ad1f68b --- M

[MediaWiki-commits] [Gerrit] inject SiteList in OtherProjectsSitesProvider instead of cal... - change (mediawiki...Wikibase)

2014-11-14 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has submitted this change and it was merged. Change subject: inject SiteList in OtherProjectsSitesProvider instead of calling getSites many times .. inject SiteList in OtherProjectsSitesProvider instead of

[MediaWiki-commits] [Gerrit] Empty the default ID blacklist - change (mediawiki...Wikibase)

2014-11-11 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/172504 Change subject: Empty the default ID blacklist .. Empty the default ID blacklist Change-Id: Iaf12e09290be6a3a37cec012e70678b4b456d15d

[MediaWiki-commits] [Gerrit] Use __DIR__ instead of dirname( __FILE__ ) - change (mediawiki...Nuke)

2014-11-08 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has submitted this change and it was merged. Change subject: Use __DIR__ instead of dirname( __FILE__ ) .. Use __DIR__ instead of dirname( __FILE__ ) Change-Id: Ibd0f9c9baf52d9962ab3fcbfe31e04028aed699c --- M

[MediaWiki-commits] [Gerrit] Remove usage of deprecated Entity methods - change (mediawiki...Wikibase)

2014-11-07 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/171845 Change subject: Remove usage of deprecated Entity methods .. Remove usage of deprecated Entity methods Two issues remain in this

[MediaWiki-commits] [Gerrit] Add @group Database to ApiXmlFormatTest - change (mediawiki...Wikibase)

2014-11-07 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has submitted this change and it was merged. Change subject: Add @group Database to ApiXmlFormatTest .. Add @group Database to ApiXmlFormatTest Change-Id: Id57690a49e01af0ed0b9ae7580cf0c4505488aab --- M

[MediaWiki-commits] [Gerrit] Add package definitions for each component - change (mediawiki...Wikibase)

2014-11-05 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/171481 Change subject: Add package definitions for each component .. Add package definitions for each component Change-Id:

[MediaWiki-commits] [Gerrit] Fix comment in ApiErrorReporter - change (mediawiki...Wikibase)

2014-11-05 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has submitted this change and it was merged. Change subject: Fix comment in ApiErrorReporter .. Fix comment in ApiErrorReporter Change-Id: I8cf3c87c3f49bf8c37ab86e70f4ec01b8ad01531 --- M

[MediaWiki-commits] [Gerrit] Add getPermissionForTitle method to use in ViewEntityAction - change (mediawiki...Wikibase)

2014-11-04 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has submitted this change and it was merged. Change subject: Add getPermissionForTitle method to use in ViewEntityAction .. Add getPermissionForTitle method to use in ViewEntityAction Change-Id:

[MediaWiki-commits] [Gerrit] Adjust getPermissionForTitle method to getEditPermissionForT... - change (mediawiki...Wikibase)

2014-11-04 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has submitted this change and it was merged. Change subject: Adjust getPermissionForTitle method to getEditPermissionForTitle .. Adjust getPermissionForTitle method to getEditPermissionForTitle Change-Id:

[MediaWiki-commits] [Gerrit] Use Title::quickUserCan in EntityPermissionChecker - change (mediawiki...Wikibase)

2014-11-04 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has submitted this change and it was merged. Change subject: Use Title::quickUserCan in EntityPermissionChecker .. Use Title::quickUserCan in EntityPermissionChecker Change-Id:

[MediaWiki-commits] [Gerrit] Remove $parserOptions-setEditSection code in ViewEntityAction - change (mediawiki...Wikibase)

2014-11-04 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has submitted this change and it was merged. Change subject: Remove $parserOptions-setEditSection code in ViewEntityAction .. Remove $parserOptions-setEditSection code in ViewEntityAction This is already done in

[MediaWiki-commits] [Gerrit] Remove unused mw reference in RepoApi, expand alias - change (mediawiki...Wikibase)

2014-11-04 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has submitted this change and it was merged. Change subject: Remove unused mw reference in RepoApi, expand alias .. Remove unused mw reference in RepoApi, expand alias Change-Id:

[MediaWiki-commits] [Gerrit] Much more clean up in SqlUsageTracker - change (mediawiki...Wikibase)

2014-10-31 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has submitted this change and it was merged. Change subject: Much more clean up in SqlUsageTracker .. Much more clean up in SqlUsageTracker Oh wow, this was confusing. Sorry to say that. Some $entityIds

[MediaWiki-commits] [Gerrit] Remove bad dependency from NoBadDependencyUsageTest - change (mediawiki...Wikibase)

2014-10-28 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/169360 Change subject: Remove bad dependency from NoBadDependencyUsageTest .. Remove bad dependency from NoBadDependencyUsageTest Much irony

[MediaWiki-commits] [Gerrit] Inject configured mwApi into RepoApi - change (mediawiki...Wikibase)

2014-10-22 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has submitted this change and it was merged. Change subject: Inject configured mwApi into RepoApi .. Inject configured mwApi into RepoApi Change-Id: Ibae5bfca6f5d3b72257a5a97ecaf19b01ed42a15 --- M

[MediaWiki-commits] [Gerrit] Don't use full qualified class names if not necesarry - change (mediawiki...Wikibase)

2014-10-21 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has submitted this change and it was merged. Change subject: Don't use full qualified class names if not necesarry .. Don't use full qualified class names if not necesarry Found with PHPStorms static code

[MediaWiki-commits] [Gerrit] Rewrite NamespaceUtils to be non-static and use one instance - change (mediawiki...Wikibase)

2014-10-21 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has submitted this change and it was merged. Change subject: Rewrite NamespaceUtils to be non-static and use one instance .. Rewrite NamespaceUtils to be non-static and use one instance On a medium-size item,

[MediaWiki-commits] [Gerrit] Add @group Database to AvailableBadgesTest - change (mediawiki...Wikibase)

2014-10-20 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has submitted this change and it was merged. Change subject: Add @group Database to AvailableBadgesTest .. Add @group Database to AvailableBadgesTest Since it extends ApiTestCase, api users get created and added

[MediaWiki-commits] [Gerrit] We can now finally get rid of this evil thing! - change (mediawiki...Wikibase)

2014-10-19 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/167432 Change subject: We can now finally get rid of this evil thing! .. We can now finally get rid of this evil thing! This reverts commit

[MediaWiki-commits] [Gerrit] Be evil and use MediaWikiTestCase::assertTag for phpunit 4.3... - change (mediawiki...Wikibase)

2014-10-17 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has submitted this change and it was merged. Change subject: Be evil and use MediaWikiTestCase::assertTag for phpunit 4.3 compat .. Be evil and use MediaWikiTestCase::assertTag for phpunit 4.3 compat Change-Id:

[MediaWiki-commits] [Gerrit] Use DispatchingEntityIdParser instead of BasicEntityIdParser... - change (mediawiki...Wikibase)

2014-10-16 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has submitted this change and it was merged. Change subject: Use DispatchingEntityIdParser instead of BasicEntityIdParser in repo .. Use DispatchingEntityIdParser instead of BasicEntityIdParser in repo

[MediaWiki-commits] [Gerrit] Some minor style changes in the scribunto code - change (mediawiki...Wikibase)

2014-10-16 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has submitted this change and it was merged. Change subject: Some minor style changes in the scribunto code .. Some minor style changes in the scribunto code Change-Id: Ie64f8e0c1aac48515a58e8d16e425d3fdea287d0

[MediaWiki-commits] [Gerrit] Replace deprecated getPrefixedId in Repo - change (mediawiki...Wikibase)

2014-10-13 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has submitted this change and it was merged. Change subject: Replace deprecated getPrefixedId in Repo .. Replace deprecated getPrefixedId in Repo Change-Id: I6b59524a81a37f198d1f60c7ade446395cb6f5fe --- M

[MediaWiki-commits] [Gerrit] Remove 'changesAsJson' setting - change (mediawiki...Wikibase)

2014-10-13 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has submitted this change and it was merged. Change subject: Remove 'changesAsJson' setting .. Remove 'changesAsJson' setting Hasn't been used in production in more than a year, so no need to keep this around

[MediaWiki-commits] [Gerrit] Use the new Statement constructor everywhere - change (mediawiki...Wikibase)

2014-10-12 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has submitted this change and it was merged. Change subject: Use the new Statement constructor everywhere .. Use the new Statement constructor everywhere Step to tackle DataModel 2.0 See also GitHub:

[MediaWiki-commits] [Gerrit] Small refactoring for ReferencedEntitiesFinder - change (mediawiki...Wikibase)

2014-10-11 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has submitted this change and it was merged. Change subject: Small refactoring for ReferencedEntitiesFinder .. Small refactoring for ReferencedEntitiesFinder There still was a warning shown in PHPStorm. The

[MediaWiki-commits] [Gerrit] Stop using aliases outside Wikibase namespace - change (mediawiki...Wikibase)

2014-10-09 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has submitted this change and it was merged. Change subject: Stop using aliases outside Wikibase namespace .. Stop using aliases outside Wikibase namespace This is split from I687c61c. Change-Id:

[MediaWiki-commits] [Gerrit] Get rid of ORMTable::getFieldPrefix - change (mediawiki...Wikibase)

2014-10-07 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has submitted this change and it was merged. Change subject: Get rid of ORMTable::getFieldPrefix .. Get rid of ORMTable::getFieldPrefix See I46a0d7e. Change-Id: Ica8b7a8e012adc73ed4d8cc84129e7c6c95e76c3 --- M

[MediaWiki-commits] [Gerrit] Fix bad assumptions in EntityParserOutputGenerator - change (mediawiki...Wikibase)

2014-10-07 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has submitted this change and it was merged. Change subject: Fix bad assumptions in EntityParserOutputGenerator .. Fix bad assumptions in EntityParserOutputGenerator This code crashed with an can not convert

[MediaWiki-commits] [Gerrit] Fix reference snaks handling in ClaimHtmlGenerator - change (mediawiki...Wikibase)

2014-10-05 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has submitted this change and it was merged. Change subject: Fix reference snaks handling in ClaimHtmlGenerator .. Fix reference snaks handling in ClaimHtmlGenerator If we pass $reference-getSnaks() as a

[MediaWiki-commits] [Gerrit] Move Diff-related classes into namespace - change (mediawiki...Wikibase)

2014-09-24 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has submitted this change and it was merged. Change subject: Move Diff-related classes into namespace .. Move Diff-related classes into namespace Change-Id: If16ddd6f7b4840cb38e6f448e17cf23c3c6ea536 --- M

[MediaWiki-commits] [Gerrit] Fix DispatchStats::hasStats - change (mediawiki...Wikibase)

2014-09-23 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has submitted this change and it was merged. Change subject: Fix DispatchStats::hasStats .. Fix DispatchStats::hasStats Change-Id: Ib2204df2c0a5028588634990afe7aec65847adba --- M

[MediaWiki-commits] [Gerrit] Remove removeReferences from AbstractedRepoApi - change (mediawiki...Wikibase)

2014-09-20 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has submitted this change and it was merged. Change subject: Remove removeReferences from AbstractedRepoApi .. Remove removeReferences from AbstractedRepoApi Change-Id: Ic82ae1ea311205a32167d2ab76b5d48370e3f62d

[MediaWiki-commits] [Gerrit] Improve type hints in ValuesFinder - change (mediawiki...Wikibase)

2014-09-20 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/161681 Change subject: Improve type hints in ValuesFinder .. Improve type hints in ValuesFinder Change-Id:

[MediaWiki-commits] [Gerrit] Use the moved version of PropertyDataTypeLookup and InMemory... - change (mediawiki...Wikibase)

2014-09-20 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/161682 Change subject: Use the moved version of PropertyDataTypeLookup and InMemoryDataTypeLookup .. Use the moved version of

[MediaWiki-commits] [Gerrit] Move RepoLinker into Client namespace - change (mediawiki...Wikibase)

2014-09-19 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/161486 Change subject: Move RepoLinker into Client namespace .. Move RepoLinker into Client namespace Change-Id:

[MediaWiki-commits] [Gerrit] Improve docs - change (mediawiki...Wikibase)

2014-09-19 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/161488 Change subject: Improve docs .. Improve docs Change-Id: Id5849820056886eb54c57d74c8eab114b1beef8e --- M

[MediaWiki-commits] [Gerrit] Move EntityHandler and derivatives into Repo\Content NS - change (mediawiki...Wikibase)

2014-09-19 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/161492 Change subject: Move EntityHandler and derivatives into Repo\Content NS .. Move EntityHandler and derivatives into Repo\Content NS

[MediaWiki-commits] [Gerrit] Remove revision from FetchedContent - change (mediawiki...Wikibase)

2014-09-17 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has submitted this change and it was merged. Change subject: Remove revision from FetchedContent .. Remove revision from FetchedContent revision is not passed in wbUsedEntities anymore. Change-Id:

[MediaWiki-commits] [Gerrit] Adapt to changes in data-values/geo 1.0.0 - change (mediawiki...Wikibase)

2014-09-12 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has submitted this change and it was merged. Change subject: Adapt to changes in data-values/geo 1.0.0 .. Adapt to changes in data-values/geo 1.0.0 Change-Id: I94078a04bf628f5761c3fd90dff95b2a0bb32452 --- M

[MediaWiki-commits] [Gerrit] Fix fatal in EntityContent::getTextForFilters - change (mediawiki...Wikibase)

2014-09-11 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has submitted this change and it was merged. Change subject: Fix fatal in EntityContent::getTextForFilters .. Fix fatal in EntityContent::getTextForFilters @note there should be a follow up that perhaps extracts

[MediaWiki-commits] [Gerrit] Use DataModel 1.0 - change (mediawiki...Wikibase)

2014-09-02 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has submitted this change and it was merged. Change subject: Use DataModel 1.0 .. Use DataModel 1.0 Change-Id: I1ec5ac5c8f7b4a6793edd058882685ad0818d26d --- M composer.json M

[MediaWiki-commits] [Gerrit] Use a stable version of DataModel - change (mediawiki...Wikibase)

2014-09-02 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/157973 Change subject: Use a stable version of DataModel .. Use a stable version of DataModel And compatible versions of the serialization

[MediaWiki-commits] [Gerrit] Make WikibaseLuaEntityBindingsTest compatible to DataModel 1.0 - change (mediawiki...Wikibase)

2014-09-01 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has submitted this change and it was merged. Change subject: Make WikibaseLuaEntityBindingsTest compatible to DataModel 1.0 .. Make WikibaseLuaEntityBindingsTest compatible to DataModel 1.0 Change-Id:

[MediaWiki-commits] [Gerrit] Move DataModelSerializationRoundtripTest to DataModel 1.0 - change (mediawiki...Wikibase)

2014-09-01 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has submitted this change and it was merged. Change subject: Move DataModelSerializationRoundtripTest to DataModel 1.0 .. Move DataModelSerializationRoundtripTest to DataModel 1.0 I'm afraid this does not fix

[MediaWiki-commits] [Gerrit] Make SnaksFinderTest compatible to DataModel 1.0 - change (mediawiki...Wikibase)

2014-09-01 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has submitted this change and it was merged. Change subject: Make SnaksFinderTest compatible to DataModel 1.0 .. Make SnaksFinderTest compatible to DataModel 1.0 Change-Id:

[MediaWiki-commits] [Gerrit] Make TestChanges compatible to DataModel 1.0 - change (mediawiki...Wikibase)

2014-09-01 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has submitted this change and it was merged. Change subject: Make TestChanges compatible to DataModel 1.0 .. Make TestChanges compatible to DataModel 1.0 Change-Id: Iaa2ea314b3b9f751fcedbcb2b2017d75088a1304 ---

[MediaWiki-commits] [Gerrit] DM 1.0 compat: do not add claims to properties and add state... - change (mediawiki...Wikibase)

2014-08-30 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/157346 Change subject: DM 1.0 compat: do not add claims to properties and add statements to items .. DM 1.0 compat: do not add claims to

[MediaWiki-commits] [Gerrit] DM 1.0 compat: do not add claims to properties and add state... - change (mediawiki...Wikibase)

2014-08-30 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/157347 Change subject: DM 1.0 compat: do not add claims to properties and add statements to items .. DM 1.0 compat: do not add claims to

[MediaWiki-commits] [Gerrit] Make ChangeOpsMergeTest compatible with DataModel 1.0 - change (mediawiki...Wikibase)

2014-08-29 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has submitted this change and it was merged. Change subject: Make ChangeOpsMergeTest compatible with DataModel 1.0 .. Make ChangeOpsMergeTest compatible with DataModel 1.0 Change-Id:

[MediaWiki-commits] [Gerrit] Make Item/PropertyViewTest compatible with DataModel 1.0 - change (mediawiki...Wikibase)

2014-08-29 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has submitted this change and it was merged. Change subject: Make Item/PropertyViewTest compatible with DataModel 1.0 .. Make Item/PropertyViewTest compatible with DataModel 1.0 Change-Id:

[MediaWiki-commits] [Gerrit] Drop/replace some pointless assert() - change (mediawiki...Wikibase)

2014-08-29 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has submitted this change and it was merged. Change subject: Drop/replace some pointless assert() .. Drop/replace some pointless assert() This is related to the planned HHVM switch. assert() depends on a setting

[MediaWiki-commits] [Gerrit] [DNM] DM 1.0 compat - change (mediawiki...Wikibase)

2014-08-29 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/157075 Change subject: [DNM] DM 1.0 compat .. [DNM] DM 1.0 compat Change-Id: I1ec5ac5c8f7b4a6793edd058882685ad0818d26d --- M composer.json M

[MediaWiki-commits] [Gerrit] Make GetClaimsTest compatible with DataModel 1.0 - change (mediawiki...Wikibase)

2014-08-29 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has submitted this change and it was merged. Change subject: Make GetClaimsTest compatible with DataModel 1.0 .. Make GetClaimsTest compatible with DataModel 1.0 Change-Id:

[MediaWiki-commits] [Gerrit] Add missing class ref and use new method name - change (mediawiki...Wikibase)

2014-08-29 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/157132 Change subject: Add missing class ref and use new method name .. Add missing class ref and use new method name Change-Id:

[MediaWiki-commits] [Gerrit] Make SetSiteLinkTest compatible with DM 1.0 - change (mediawiki...Wikibase)

2014-08-29 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/157133 Change subject: Make SetSiteLinkTest compatible with DM 1.0 .. Make SetSiteLinkTest compatible with DM 1.0 Change-Id:

[MediaWiki-commits] [Gerrit] Sop using deprecated methods in SpecialItemDisambiguationTest - change (mediawiki...Wikibase)

2014-08-29 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/157135 Change subject: Sop using deprecated methods in SpecialItemDisambiguationTest .. Sop using deprecated methods in

[MediaWiki-commits] [Gerrit] Stop using deprecated DM functions in ItemDisambiguationTest - change (mediawiki...Wikibase)

2014-08-29 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/157136 Change subject: Stop using deprecated DM functions in ItemDisambiguationTest .. Stop using deprecated DM functions in

[MediaWiki-commits] [Gerrit] Remove wfSuppressWarnings - change (mediawiki...Wikibase)

2014-08-29 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has submitted this change and it was merged. Change subject: Remove wfSuppressWarnings .. Remove wfSuppressWarnings Change-Id: Ic3fefd2c4e10df1c8540312371809a02922837fc --- M

[MediaWiki-commits] [Gerrit] Fix SetSiteLinkTest - change (mediawiki...Wikibase)

2014-08-29 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has submitted this change and it was merged. Change subject: Fix SetSiteLinkTest .. Fix SetSiteLinkTest Change-Id: Ie8934df2da349cd25e94c2825ce4368cf98731ec --- M

[MediaWiki-commits] [Gerrit] Attempt to fix bug 70041 - change (mediawiki...Wikibase)

2014-08-27 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has submitted this change and it was merged. Change subject: Attempt to fix bug 70041 .. Attempt to fix bug 70041 Change-Id: Ib997a2bb6ffd10e4b51cc1b7ce5e793b83a0c93d --- M

[MediaWiki-commits] [Gerrit] Make ChangeOpClaimTest compatible with DM 1.0 - change (mediawiki...Wikibase)

2014-08-27 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has submitted this change and it was merged. Change subject: Make ChangeOpClaimTest compatible with DM 1.0 .. Make ChangeOpClaimTest compatible with DM 1.0 Change-Id: Ifae7772d3ee2ef280092728ce201bbe0b6ce71b8

[MediaWiki-commits] [Gerrit] Replace some assert() with actual code - change (mediawiki...Wikibase)

2014-08-27 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has submitted this change and it was merged. Change subject: Replace some assert() with actual code .. Replace some assert() with actual code This is related to the planned HHVM switch. assert() depends on a

[MediaWiki-commits] [Gerrit] Attempt to fix bug 70041 - change (mediawiki...Wikibase)

2014-08-26 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/156296 Change subject: Attempt to fix bug 70041 .. Attempt to fix bug 70041 Change-Id: Ib997a2bb6ffd10e4b51cc1b7ce5e793b83a0c93d --- M

[MediaWiki-commits] [Gerrit] Remove dead code - change (mediawiki...Wikibase)

2014-08-25 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has submitted this change and it was merged. Change subject: Remove dead code .. Remove dead code Change-Id: I92767025aff7ac7642d0eded75d3b1d0bd026f73 --- M lib/maintenance/dispatchChanges.php 1 file changed, 1

[MediaWiki-commits] [Gerrit] Kill all the aliases - change (mediawiki...Wikibase)

2014-08-24 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has submitted this change and it was merged. Change subject: Kill all the aliases .. Kill all the aliases ... when possible. It's not possible in classes that are directly in the Wikibase namespace. Change-Id:

[MediaWiki-commits] [Gerrit] Move EntityPermissionChecker to repo, as not used elsewhere - change (mediawiki...Wikibase)

2014-08-23 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has submitted this change and it was merged. Change subject: Move EntityPermissionChecker to repo, as not used elsewhere .. Move EntityPermissionChecker to repo, as not used elsewhere Change-Id:

[MediaWiki-commits] [Gerrit] Sort imports in WikibaseRepo class - change (mediawiki...Wikibase)

2014-08-23 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has submitted this change and it was merged. Change subject: Sort imports in WikibaseRepo class .. Sort imports in WikibaseRepo class Change-Id: Id829080070034240fb3346133b7cdf9c734842b7 --- M

[MediaWiki-commits] [Gerrit] Drop 5.3 repo only travis build (in German) - change (mediawiki...Wikibase)

2014-08-22 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has submitted this change and it was merged. Change subject: Drop 5.3 repo only travis build (in German) .. Drop 5.3 repo only travis build (in German) we run 5.3 on jenkins, so this is redundant. Change-Id:

[MediaWiki-commits] [Gerrit] Replace dirname( __FILE__ ) with __DIR__ in extension instal... - change (mediawiki...SemanticSignup)

2014-08-21 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has submitted this change and it was merged. Change subject: Replace dirname( __FILE__ ) with __DIR__ in extension installation file .. Replace dirname( __FILE__ ) with __DIR__ in extension installation file

[MediaWiki-commits] [Gerrit] Consolidate file header documentation for SemanticSignup.php - change (mediawiki...SemanticSignup)

2014-08-21 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has submitted this change and it was merged. Change subject: Consolidate file header documentation for SemanticSignup.php .. Consolidate file header documentation for SemanticSignup.php Change-Id:

[MediaWiki-commits] [Gerrit] Move CreateUserFieldsTemplate to a separate file - change (mediawiki...SemanticSignup)

2014-08-21 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has submitted this change and it was merged. Change subject: Move CreateUserFieldsTemplate to a separate file .. Move CreateUserFieldsTemplate to a separate file Change-Id:

[MediaWiki-commits] [Gerrit] Rename SES_Special to SpecialSemanticSignup - change (mediawiki...SemanticSignup)

2014-08-21 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has submitted this change and it was merged. Change subject: Rename SES_Special to SpecialSemanticSignup .. Rename SES_Special to SpecialSemanticSignup Also updated file header documentation for the special page

[MediaWiki-commits] [Gerrit] Use DataModel 0.9.x - change (mediawiki...Wikibase)

2014-08-15 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/154339 Change subject: Use DataModel 0.9.x .. Use DataModel 0.9.x Change-Id: Ibf3d660c475a52871d2f9d2f993857b249b84f94 --- M composer.json 1

[MediaWiki-commits] [Gerrit] Update / remove references to TermCache interface - change (mediawiki...Wikibase)

2014-08-15 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has submitted this change and it was merged. Change subject: Update / remove references to TermCache interface .. Update / remove references to TermCache interface TermCache has been renamed to TermIndex.

[MediaWiki-commits] [Gerrit] Handle MonolingualTextParser errors for values with language... - change (mediawiki...Wikibase)

2014-08-15 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has submitted this change and it was merged. Change subject: Handle MonolingualTextParser errors for values with language not set .. Handle MonolingualTextParser errors for values with language not set Throw a

[MediaWiki-commits] [Gerrit] Do not +2 on verified based just on linting - change (integration/zuul-config)

2014-08-14 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/154058 Change subject: Do not +2 on verified based just on linting .. Do not +2 on verified based just on linting Change-Id:

[MediaWiki-commits] [Gerrit] Refactor Fingerprint code out of EntityView - change (mediawiki...Wikibase)

2014-08-14 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has submitted this change and it was merged. Change subject: Refactor Fingerprint code out of EntityView .. Refactor Fingerprint code out of EntityView All code related to fingerprint is moved into a separate

[MediaWiki-commits] [Gerrit] Fix EntityHandlerTest with the new serialization format - change (mediawiki...Wikibase)

2014-08-13 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has submitted this change and it was merged. Change subject: Fix EntityHandlerTest with the new serialization format .. Fix EntityHandlerTest with the new serialization format Change-Id:

[MediaWiki-commits] [Gerrit] Make PropertyContentTest work with DataModel 1.0 - change (mediawiki...Wikibase)

2014-08-13 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has submitted this change and it was merged. Change subject: Make PropertyContentTest work with DataModel 1.0 .. Make PropertyContentTest work with DataModel 1.0 In DataModel 1.0 Properties do not contain claims

[MediaWiki-commits] [Gerrit] Make ItemContentTest work with DataModel 1.0 - change (mediawiki...Wikibase)

2014-08-13 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has submitted this change and it was merged. Change subject: Make ItemContentTest work with DataModel 1.0 .. Make ItemContentTest work with DataModel 1.0 Change-Id: I5dcd38e4e976d022c1e8e208a9201a1291c98df6 ---

[MediaWiki-commits] [Gerrit] Make monolingual-text datatype non-experimental - change (mediawiki...Wikibase)

2014-08-13 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has submitted this change and it was merged. Change subject: Make monolingual-text datatype non-experimental .. Make monolingual-text datatype non-experimental Change-Id:

[MediaWiki-commits] [Gerrit] Update restriction - change (mediawiki...Wikibase)

2014-08-12 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/153605 Change subject: Update restriction .. Update restriction Change-Id: I8a6cce56cef74712d6d558f02f52a2fab8b3a05c --- M

[MediaWiki-commits] [Gerrit] Fix phpdocs - change (mediawiki...Wikibase)

2014-08-12 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/153607 Change subject: Fix phpdocs .. Fix phpdocs Change-Id: I2dbad351ccf9ca41628cd310bdd97575a53136fa --- M

[MediaWiki-commits] [Gerrit] Remove unused imports from Lib - change (mediawiki...Wikibase)

2014-08-12 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/153608 Change subject: Remove unused imports from Lib .. Remove unused imports from Lib Change-Id: Ia2ae11c8e1fb6e47a1b5b1a3d30c6cb6fe339392

[MediaWiki-commits] [Gerrit] Optimized repo imports - change (mediawiki...Wikibase)

2014-08-12 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/153611 Change subject: Optimized repo imports .. Optimized repo imports Change-Id: I051a6a18a94bd5a679c9c479b51f32f9c8223e5c --- M

[MediaWiki-commits] [Gerrit] Optimized client imports - change (mediawiki...Wikibase)

2014-08-12 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/153612 Change subject: Optimized client imports .. Optimized client imports Change-Id: I71c2f0b560004065a6768fb4b910dd0b758fdb97 --- M

[MediaWiki-commits] [Gerrit] Fix phpdoc - change (mediawiki...Wikibase)

2014-08-12 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/153697 Change subject: Fix phpdoc .. Fix phpdoc Change-Id: Ib7d0dcef2819aa80f71e56bcd072420c9c039fe2 --- M

[MediaWiki-commits] [Gerrit] Minor cleanup in SnaksFinder - change (mediawiki...Wikibase)

2014-08-12 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/153698 Change subject: Minor cleanup in SnaksFinder .. Minor cleanup in SnaksFinder Change-Id: Ibebb95f4e58560abe4b31cba2f8c546b906bc4f7 ---

[MediaWiki-commits] [Gerrit] Improve phpdoc in ChangeHandlerTest and improve class ref - change (mediawiki...Wikibase)

2014-08-12 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/153699 Change subject: Improve phpdoc in ChangeHandlerTest and improve class ref .. Improve phpdoc in ChangeHandlerTest and improve class ref

[MediaWiki-commits] [Gerrit] Remove dead code - change (mediawiki...Wikibase)

2014-08-12 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/153700 Change subject: Remove dead code .. Remove dead code Change-Id: I948b69d396c1b63c59738fca3fbbb1d03fe07719 --- M

[MediaWiki-commits] [Gerrit] Minor tweak in PopulateInterwiki - change (mediawiki...Wikibase)

2014-08-12 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/153701 Change subject: Minor tweak in PopulateInterwiki .. Minor tweak in PopulateInterwiki Change-Id:

[MediaWiki-commits] [Gerrit] Remove unused imports from Lib - change (mediawiki...Wikibase)

2014-08-12 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has submitted this change and it was merged. Change subject: Remove unused imports from Lib .. Remove unused imports from Lib Change-Id: Ia2ae11c8e1fb6e47a1b5b1a3d30c6cb6fe339392 --- M

[MediaWiki-commits] [Gerrit] Remove dead line - change (mediawiki...Wikibase)

2014-08-12 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/153703 Change subject: Remove dead line .. Remove dead line Change-Id: I684146f1b631242eb14b5e65c94dbd5a6b98486d --- M

[MediaWiki-commits] [Gerrit] Fix class ref - change (mediawiki...Wikibase)

2014-08-12 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/153710 Change subject: Fix class ref .. Fix class ref Change-Id: Ic12553496847b27a96bf32531261f046f3dd57d0 --- M

[MediaWiki-commits] [Gerrit] Remove unused vars - change (mediawiki...Wikibase)

2014-08-12 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/153711 Change subject: Remove unused vars .. Remove unused vars Change-Id: Ie78b7d79933e3159765a4d69a4f1ed643085e866 --- M

[MediaWiki-commits] [Gerrit] Remove some presumably dead code - change (mediawiki...Wikibase)

2014-08-12 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/153712 Change subject: Remove some presumably dead code .. Remove some presumably dead code Change-Id:

[MediaWiki-commits] [Gerrit] [DNM] Testing against DataModel 1.0 - change (mediawiki...Wikibase)

2014-08-12 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/153713 Change subject: [DNM] Testing against DataModel 1.0 .. [DNM] Testing against DataModel 1.0 Change-Id:

[MediaWiki-commits] [Gerrit] [DNM] DM 1.0 compat - change (mediawiki...Wikibase)

2014-08-12 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/153714 Change subject: [DNM] DM 1.0 compat .. [DNM] DM 1.0 compat Change-Id: I1ec5ac5c8f7b4a6793edd058882685ad0818d26c --- M composer.json M

<    1   2   3   4   5   6   7   8   9   10   >