[MediaWiki-commits] [Gerrit] mediawiki...WikidataPageBanner[master]: WPB enable banners on diff pages

2016-11-14 Thread Sumit (Code Review)
Sumit has uploaded a new change for review. https://gerrit.wikimedia.org/r/321369 Change subject: WPB enable banners on diff pages .. WPB enable banners on diff pages Bug: T147946 Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...RelatedArticles[master]: Disable related articles on disambiguation pages

2016-08-23 Thread Sumit (Code Review)
Sumit has uploaded a new change for review. https://gerrit.wikimedia.org/r/306298 Change subject: Disable related articles on disambiguation pages .. Disable related articles on disambiguation pages Uses DisambiguatorHooks

[MediaWiki-commits] [Gerrit] Allow date ranges in Special:Contributions - change (mediawiki/core)

2016-04-02 Thread Sumit (Code Review)
Sumit has uploaded a new change for review. https://gerrit.wikimedia.org/r/281113 Change subject: Allow date ranges in Special:Contributions .. Allow date ranges in Special:Contributions Adds the functionality to set date

[MediaWiki-commits] [Gerrit] Apply filterContentInSection to last section - change (mediawiki...MobileFrontend)

2016-03-15 Thread Sumit (Code Review)
Sumit has uploaded a new change for review. https://gerrit.wikimedia.org/r/277603 Change subject: Apply filterContentInSection to last section .. Apply filterContentInSection to last section Fixes images in last section not

[MediaWiki-commits] [Gerrit] MobileFrontendSkinHooks fix getLicense() doc - change (mediawiki...MobileFrontend)

2016-02-22 Thread Sumit (Code Review)
Sumit has uploaded a new change for review. https://gerrit.wikimedia.org/r/272486 Change subject: MobileFrontendSkinHooks fix getLicense() doc .. MobileFrontendSkinHooks fix getLicense() doc Change-Id:

[MediaWiki-commits] [Gerrit] Override Copyright warning message for Minerva - change (mediawiki...MobileFrontend)

2016-02-18 Thread Sumit (Code Review)
Sumit has uploaded a new change for review. https://gerrit.wikimedia.org/r/271594 Change subject: Override Copyright warning message for Minerva .. Override Copyright warning message for Minerva Replace copyright warning

[MediaWiki-commits] [Gerrit] Hide cancel and pipe seaparator in editor in nojs - change (mediawiki...MobileFrontend)

2016-02-12 Thread Sumit (Code Review)
Sumit has uploaded a new change for review. https://gerrit.wikimedia.org/r/270348 Change subject: Hide cancel and pipe seaparator in editor in nojs .. Hide cancel and pipe seaparator in editor in nojs Bug: T125174 Change-Id:

[MediaWiki-commits] [Gerrit] [WIP] Enable no-js editing in mobile - change (mediawiki...MobileFrontend)

2016-01-29 Thread Sumit (Code Review)
Sumit has uploaded a new change for review. https://gerrit.wikimedia.org/r/267281 Change subject: [WIP] Enable no-js editing in mobile .. [WIP] Enable no-js editing in mobile Bug: T125174 Change-Id:

[MediaWiki-commits] [Gerrit] MobileFrontend Remove deprecated Class.extend - change (mediawiki...MobileFrontend)

2016-01-21 Thread Sumit (Code Review)
Sumit has uploaded a new change for review. https://gerrit.wikimedia.org/r/265547 Change subject: MobileFrontend Remove deprecated Class.extend .. MobileFrontend Remove deprecated Class.extend Remove all instances of

[MediaWiki-commits] [Gerrit] Replace deprecated 'llurl=true' with 'llprop=url' - change (mediawiki...MobileFrontend)

2016-01-14 Thread Sumit (Code Review)
Sumit has uploaded a new change for review. https://gerrit.wikimedia.org/r/264104 Change subject: Replace deprecated 'llurl=true' with 'llprop=url' .. Replace deprecated 'llurl=true' with 'llprop=url' Bug: T123631 Change-Id:

[MediaWiki-commits] [Gerrit] Fix new collection creation - change (mediawiki...Gather)

2016-01-13 Thread Sumit (Code Review)
Sumit has uploaded a new change for review. https://gerrit.wikimedia.org/r/263849 Change subject: Fix new collection creation .. Fix new collection creation Pass mw.Api as a parameter to CollectionEditOverlay constructor

[MediaWiki-commits] [Gerrit] Enable skipped router tests - change (mediawiki...MobileFrontend)

2015-12-20 Thread Sumit (Code Review)
Sumit has uploaded a new change for review. https://gerrit.wikimedia.org/r/260330 Change subject: Enable skipped router tests .. Enable skipped router tests Refactor Router.js to include a 'testHash' for testing and decouple

[MediaWiki-commits] [Gerrit] MF restrict max width on Special:Contributions - change (mediawiki...MobileFrontend)

2015-12-16 Thread Sumit (Code Review)
Sumit has uploaded a new change for review. https://gerrit.wikimedia.org/r/259461 Change subject: MF restrict max width on Special:Contributions .. MF restrict max width on Special:Contributions Bug: T121577 Change-Id:

[MediaWiki-commits] [Gerrit] MobileFrontend mw.notification instead of toast - change (mediawiki...MobileFrontend)

2015-12-14 Thread Sumit (Code Review)
Sumit has uploaded a new change for review. https://gerrit.wikimedia.org/r/258969 Change subject: MobileFrontend mw.notification instead of toast .. MobileFrontend mw.notification instead of toast Makes MobileFrontend use

[MediaWiki-commits] [Gerrit] MobileFrontend fix back on Special:Nearby - change (mediawiki...MobileFrontend)

2015-12-11 Thread Sumit (Code Review)
Sumit has uploaded a new change for review. https://gerrit.wikimedia.org/r/258476 Change subject: MobileFrontend fix back on Special:Nearby .. MobileFrontend fix back on Special:Nearby Fixes back on browser from an article

[MediaWiki-commits] [Gerrit] WPB fix inconsistent ImageDisabled test - change (mediawiki...WikidataPageBanner)

2015-12-11 Thread Sumit (Code Review)
Sumit has uploaded a new change for review. https://gerrit.wikimedia.org/r/258511 Change subject: WPB fix inconsistent ImageDisabled test .. WPB fix inconsistent ImageDisabled test Use reflection class to set disableImages

[MediaWiki-commits] [Gerrit] BetaFeatures only add whitelisted preferences - change (mediawiki...BetaFeatures)

2015-12-10 Thread Sumit (Code Review)
Sumit has uploaded a new change for review. https://gerrit.wikimedia.org/r/258418 Change subject: BetaFeatures only add whitelisted preferences .. BetaFeatures only add whitelisted preferences Check if a preference is

[MediaWiki-commits] [Gerrit] MobileFrontend allow anons to see per user uploads - change (mediawiki...MobileFrontend)

2015-12-08 Thread Sumit (Code Review)
Sumit has uploaded a new change for review. https://gerrit.wikimedia.org/r/257588 Change subject: MobileFrontend allow anons to see per user uploads .. MobileFrontend allow anons to see per user uploads Removes the need to

[MediaWiki-commits] [Gerrit] RelatedArticles load after half window scroll - change (mediawiki...RelatedArticles)

2015-12-05 Thread Sumit (Code Review)
Sumit has uploaded a new change for review. https://gerrit.wikimedia.org/r/257069 Change subject: RelatedArticles load after half window scroll .. RelatedArticles load after half window scroll Only triggers RelatedArticles

[MediaWiki-commits] [Gerrit] Convert title to its language variant - change (mediawiki...WikidataPageBanner)

2015-12-03 Thread Sumit (Code Review)
Sumit has uploaded a new change for review. https://gerrit.wikimedia.org/r/256664 Change subject: Convert title to its language variant .. Convert title to its language variant The title rendered on the banner is first

[MediaWiki-commits] [Gerrit] Save banner properties in page_props for api use - change (mediawiki...WikidataPageBanner)

2015-12-02 Thread Sumit (Code Review)
Sumit has uploaded a new change for review. https://gerrit.wikimedia.org/r/256409 Change subject: Save banner properties in page_props for api use .. Save banner properties in page_props for api use Set valid banner 'name'

[MediaWiki-commits] [Gerrit] TextExtracts do not crop after initials - change (mediawiki...TextExtracts)

2015-11-30 Thread Sumit (Code Review)
Sumit has uploaded a new change for review. https://gerrit.wikimedia.org/r/255959 Change subject: TextExtracts do not crop after initials .. TextExtracts do not crop after initials Disables sentence termination at a full

[MediaWiki-commits] [Gerrit] WPB show no banner when images disabled - change (mediawiki...WikidataPageBanner)

2015-11-29 Thread Sumit (Code Review)
Sumit has uploaded a new change for review. https://gerrit.wikimedia.org/r/255940 Change subject: WPB show no banner when images disabled .. WPB show no banner when images disabled Turns off pagebanner when using skin

[MediaWiki-commits] [Gerrit] TextExtracts allow sentence end with numbers - change (mediawiki...TextExtracts)

2015-11-17 Thread Sumit (Code Review)
Sumit has uploaded a new change for review. https://gerrit.wikimedia.org/r/253834 Change subject: TextExtracts allow sentence end with numbers .. TextExtracts allow sentence end with numbers Allows sentences to end with

[MediaWiki-commits] [Gerrit] WikidataPageBanner add a separate flag for toc - change (mediawiki...WikidataPageBanner)

2015-10-22 Thread Sumit (Code Review)
Sumit has uploaded a new change for review. https://gerrit.wikimedia.org/r/248277 Change subject: WikidataPageBanner add a separate flag for toc .. WikidataPageBanner add a separate flag for toc This will prevent setting the

[MediaWiki-commits] [Gerrit] Gather sort single user lists by time - change (mediawiki...Gather)

2015-09-25 Thread Sumit (Code Review)
Sumit has uploaded a new change for review. https://gerrit.wikimedia.org/r/240975 Change subject: Gather sort single user lists by time .. Gather sort single user lists by time Sort lists of a single user with last modified

[MediaWiki-commits] [Gerrit] WikidataPageBanner set focus after banner load - change (mediawiki...WikidataPageBanner)

2015-09-08 Thread Sumit (Code Review)
Sumit has uploaded a new change for review. https://gerrit.wikimedia.org/r/236735 Change subject: WikidataPageBanner set focus after banner load .. WikidataPageBanner set focus after banner load Trigger positionBanner()

[MediaWiki-commits] [Gerrit] WPB title should use Mediawiki:Pagetitle - change (mediawiki...WikidataPageBanner)

2015-09-05 Thread Sumit (Code Review)
Sumit has uploaded a new change for review. https://gerrit.wikimedia.org/r/236250 Change subject: WPB title should use Mediawiki:Pagetitle .. WPB title should use Mediawiki:Pagetitle WikidataPageBanner should use

[MediaWiki-commits] [Gerrit] WikidataPageBanner disable on diff pages - change (mediawiki...WikidataPageBanner)

2015-09-02 Thread Sumit (Code Review)
Sumit has uploaded a new change for review. https://gerrit.wikimedia.org/r/235492 Change subject: WikidataPageBanner disable on diff pages .. WikidataPageBanner disable on diff pages Show no banner when viewing a diff of a

[MediaWiki-commits] [Gerrit] WikidataPageBanner make links row selectable - change (mediawiki...WikidataPageBanner)

2015-08-31 Thread Sumit (Code Review)
Sumit has uploaded a new change for review. https://gerrit.wikimedia.org/r/235041 Change subject: WikidataPageBanner make links row selectable .. WikidataPageBanner make links row selectable Add text decoration on dropdown

[MediaWiki-commits] [Gerrit] WikidataPageBanner restrict heading to one line - change (mediawiki...WikidataPageBanner)

2015-08-31 Thread Sumit (Code Review)
Sumit has uploaded a new change for review. https://gerrit.wikimedia.org/r/235059 Change subject: WikidataPageBanner restrict heading to one line .. WikidataPageBanner restrict heading to one line On screen below 768px,

[MediaWiki-commits] [Gerrit] WikidataPageBanner replace div with h1 for heading - change (mediawiki...WikidataPageBanner)

2015-08-21 Thread Sumit (Code Review)
Sumit has uploaded a new change for review. https://gerrit.wikimedia.org/r/232934 Change subject: WikidataPageBanner replace div with h1 for heading .. WikidataPageBanner replace div with h1 for heading Bug: T109811

[MediaWiki-commits] [Gerrit] WikidataPageBanner move toc position - change (mediawiki...WikidataPageBanner)

2015-08-20 Thread Sumit (Code Review)
Sumit has uploaded a new change for review. https://gerrit.wikimedia.org/r/232759 Change subject: WikidataPageBanner move toc position .. WikidataPageBanner move toc position https://gerrit.wikimedia.org/r/#/c/228813/ hides

[MediaWiki-commits] [Gerrit] WikidataPageBanner add .jshintrc - change (mediawiki...WikidataPageBanner)

2015-08-17 Thread Sumit (Code Review)
Sumit has uploaded a new change for review. https://gerrit.wikimedia.org/r/232072 Change subject: WikidataPageBanner add .jshintrc .. WikidataPageBanner add .jshintrc Add .jshintrc Edit Gruntfile.js to test resources/ and

[MediaWiki-commits] [Gerrit] WikidataPageBanner improve qunit test - change (mediawiki...WikidataPageBanner)

2015-08-17 Thread Sumit (Code Review)
Sumit has uploaded a new change for review. https://gerrit.wikimedia.org/r/232195 Change subject: WikidataPageBanner improve qunit test .. WikidataPageBanner improve qunit test Followup to

[MediaWiki-commits] [Gerrit] WikidataPageBanner add max-wdith - change (mediawiki...WikidataPageBanner)

2015-08-16 Thread Sumit (Code Review)
Sumit has uploaded a new change for review. https://gerrit.wikimedia.org/r/231886 Change subject: WikidataPageBanner add max-wdith .. WikidataPageBanner add max-wdith Add a parameter max-width to the banner so as to prevent

[MediaWiki-commits] [Gerrit] WikidataPageBanner switch for default banner - change (mediawiki...WikidataPageBanner)

2015-08-12 Thread Sumit (Code Review)
Sumit has uploaded a new change for review. https://gerrit.wikimedia.org/r/230978 Change subject: WikidataPageBanner switch for default banner .. WikidataPageBanner switch for default banner Adds a switch to enable default

[MediaWiki-commits] [Gerrit] WikidataPageBanner unquote false in extension.json - change (mediawiki...WikidataPageBanner)

2015-08-12 Thread Sumit (Code Review)
Sumit has uploaded a new change for review. https://gerrit.wikimedia.org/r/231057 Change subject: WikidataPageBanner unquote false in extension.json .. WikidataPageBanner unquote false in extension.json Follow-up to

[MediaWiki-commits] [Gerrit] WikidataPageBanner add class image to a:link - change (mediawiki...WikidataPageBanner)

2015-08-11 Thread Sumit (Code Review)
Sumit has uploaded a new change for review. https://gerrit.wikimedia.org/r/230975 Change subject: WikidataPageBanner add class image to a:link .. WikidataPageBanner add class image to a:link Since MultimediaViewer operates

[MediaWiki-commits] [Gerrit] WikidataPageBanner add banner to imagelinks - change (mediawiki...WikidataPageBanner)

2015-08-10 Thread Sumit (Code Review)
Sumit has uploaded a new change for review. https://gerrit.wikimedia.org/r/230643 Change subject: WikidataPageBanner add banner to imagelinks .. WikidataPageBanner add banner to imagelinks Check which banner is valid and

[MediaWiki-commits] [Gerrit] WPB followup - move maxheight - change (mediawiki...WikidataPageBanner)

2015-08-07 Thread Sumit (Code Review)
Sumit has uploaded a new change for review. https://gerrit.wikimedia.org/r/230226 Change subject: WPB followup - move maxheight .. WPB followup - move maxheight Followup to Ifd696117d4614389685945ad3853a473179c2c03 to move

[MediaWiki-commits] [Gerrit] WikidataPageBanner reduce margin-top for minerva - change (mediawiki...WikidataPageBanner)

2015-08-07 Thread Sumit (Code Review)
Sumit has uploaded a new change for review. https://gerrit.wikimedia.org/r/230051 Change subject: WikidataPageBanner reduce margin-top for minerva .. WikidataPageBanner reduce margin-top for minerva Reduces margin-top from

[MediaWiki-commits] [Gerrit] WPB followup - fine tune banner position using js - change (mediawiki...WikidataPageBanner)

2015-08-07 Thread Sumit (Code Review)
Sumit has uploaded a new change for review. https://gerrit.wikimedia.org/r/230050 Change subject: WPB followup - fine tune banner position using js .. WPB followup - fine tune banner position using js This is a followup to

[MediaWiki-commits] [Gerrit] WikidataPageBanner add link to icons - change (mediawiki...WikidataPageBanner)

2015-08-06 Thread Sumit (Code Review)
Sumit has uploaded a new change for review. https://gerrit.wikimedia.org/r/229759 Change subject: WikidataPageBanner add link to icons .. WikidataPageBanner add link to icons Allow editors to define the article an icon

[MediaWiki-commits] [Gerrit] WikidataPageBanner hygiene - move non-hook methods - change (mediawiki...WikidataPageBanner)

2015-08-05 Thread Sumit (Code Review)
Sumit has uploaded a new change for review. https://gerrit.wikimedia.org/r/229389 Change subject: WikidataPageBanner hygiene - move non-hook methods .. WikidataPageBanner hygiene - move non-hook methods Move non-hook

[MediaWiki-commits] [Gerrit] WikidataPageBanner implement srcset polyfill - change (mediawiki...WikidataPageBanner)

2015-08-03 Thread Sumit (Code Review)
Sumit has uploaded a new change for review. https://gerrit.wikimedia.org/r/228785 Change subject: WikidataPageBanner implement srcset polyfill .. WikidataPageBanner implement srcset polyfill Implement a polyfill for srcset

[MediaWiki-commits] [Gerrit] WikidataPageBanner option to hide default TOC - change (mediawiki...WikidataPageBanner)

2015-08-03 Thread Sumit (Code Review)
Sumit has uploaded a new change for review. https://gerrit.wikimedia.org/r/22 Change subject: WikidataPageBanner option to hide default TOC .. WikidataPageBanner option to hide default TOC WikidataPageBanner extension

[MediaWiki-commits] [Gerrit] WPB fake banner cropping for small screens - change (mediawiki...WikidataPageBanner)

2015-08-03 Thread Sumit (Code Review)
Sumit has uploaded a new change for review. https://gerrit.wikimedia.org/r/228813 Change subject: WPB fake banner cropping for small screens .. WPB fake banner cropping for small screens On screen size below 400px, make the

[MediaWiki-commits] [Gerrit] WikidataPageBanner check avoid empty icons - change (mediawiki...WikidataPageBanner)

2015-07-28 Thread Sumit (Code Review)
Sumit has uploaded a new change for review. https://gerrit.wikimedia.org/r/227415 Change subject: WikidataPageBanner check avoid empty icons .. WikidataPageBanner check avoid empty icons Excess commas may lead to empty icon

[MediaWiki-commits] [Gerrit] WikidataPageBanner improve documentation - change (mediawiki...WikidataPageBanner)

2015-07-27 Thread Sumit (Code Review)
Sumit has uploaded a new change for review. https://gerrit.wikimedia.org/r/227254 Change subject: WikidataPageBanner improve documentation .. WikidataPageBanner improve documentation Improve the description of functions in

[MediaWiki-commits] [Gerrit] WikidataPageBanner set bannername as articlebanner - change (mediawiki...WikidataPageBanner)

2015-07-27 Thread Sumit (Code Review)
Sumit has uploaded a new change for review. https://gerrit.wikimedia.org/r/227261 Change subject: WikidataPageBanner set bannername as articlebanner .. WikidataPageBanner set bannername as articlebanner Setting the whole

[MediaWiki-commits] [Gerrit] WikidataPageBanner check for invalid Property name - change (mediawiki...WikidataPageBanner)

2015-07-26 Thread Sumit (Code Review)
Sumit has uploaded a new change for review. https://gerrit.wikimedia.org/r/227176 Change subject: WikidataPageBanner check for invalid Property name .. WikidataPageBanner check for invalid Property name Add a try-catch block

[MediaWiki-commits] [Gerrit] WikidataPageBanner prefix wpb in toc minerva style - change (mediawiki...WikidataPageBanner)

2015-07-24 Thread Sumit (Code Review)
Sumit has uploaded a new change for review. https://gerrit.wikimedia.org/r/226697 Change subject: WikidataPageBanner prefix wpb in toc minerva style .. WikidataPageBanner prefix wpb in toc minerva style Banner class names in

[MediaWiki-commits] [Gerrit] WikidataPageBanner prefix all globals with WPB - change (mediawiki...WikidataPageBanner)

2015-07-24 Thread Sumit (Code Review)
Sumit has uploaded a new change for review. https://gerrit.wikimedia.org/r/226919 Change subject: WikidataPageBanner prefix all globals with WPB .. WikidataPageBanner prefix all globals with WPB Bug: T106586 Change-Id:

[MediaWiki-commits] [Gerrit] WikidataPageBanner add parameter tocbelow - change (mediawiki...WikidataPageBanner)

2015-07-24 Thread Sumit (Code Review)
Sumit has uploaded a new change for review. https://gerrit.wikimedia.org/r/226762 Change subject: WikidataPageBanner add parameter tocbelow .. WikidataPageBanner add parameter tocbelow Add a parameter 'tocbelow' to

[MediaWiki-commits] [Gerrit] WikidataPageBanner prefix all globals with WPB - change (mediawiki...WikidataPageBanner)

2015-07-23 Thread Sumit (Code Review)
Sumit has uploaded a new change for review. https://gerrit.wikimedia.org/r/226520 Change subject: WikidataPageBanner prefix all globals with WPB .. WikidataPageBanner prefix all globals with WPB Bug: T106586 Change-Id:

[MediaWiki-commits] [Gerrit] Load oojs ui styles only for banner icons - change (mediawiki...WikidataPageBanner)

2015-07-23 Thread Sumit (Code Review)
Sumit has uploaded a new change for review. https://gerrit.wikimedia.org/r/226521 Change subject: Load oojs ui styles only for banner icons .. Load oojs ui styles only for banner icons Replace oojs-ui with oojs-ui-styles as

[MediaWiki-commits] [Gerrit] WikidataPageBanner remove outermost div - change (mediawiki...WikidataPageBanner)

2015-07-23 Thread Sumit (Code Review)
Sumit has uploaded a new change for review. https://gerrit.wikimedia.org/r/226574 Change subject: WikidataPageBanner remove outermost div .. WikidataPageBanner remove outermost div Remove container with class noprint and add

[MediaWiki-commits] [Gerrit] WikidataPageBanner drop OOUI\Theme::setSingleton - change (mediawiki...WikidataPageBanner)

2015-07-23 Thread Sumit (Code Review)
Sumit has uploaded a new change for review. https://gerrit.wikimedia.org/r/226558 Change subject: WikidataPageBanner drop OOUI\Theme::setSingleton .. WikidataPageBanner drop OOUI\Theme::setSingleton Remove the call to

[MediaWiki-commits] [Gerrit] WikidataPageBanner toc - make toc less overlapping - change (mediawiki...WikidataPageBanner)

2015-07-22 Thread Sumit (Code Review)
Sumit has submitted this change and it was merged. Change subject: WikidataPageBanner toc - make toc less overlapping .. WikidataPageBanner toc - make toc less overlapping To prevent too much toc overlapping banner on smaller

[MediaWiki-commits] [Gerrit] WikidataPageBanner TOC unstyle visited and hygiene - change (mediawiki...WikidataPageBanner)

2015-07-22 Thread Sumit (Code Review)
Sumit has uploaded a new change for review. https://gerrit.wikimedia.org/r/226341 Change subject: WikidataPageBanner TOC unstyle visited and hygiene .. WikidataPageBanner TOC unstyle visited and hygiene Disable styling on

[MediaWiki-commits] [Gerrit] WikidataPageBanner allow space in image src - change (mediawiki...WikidataPageBanner)

2015-07-22 Thread Sumit (Code Review)
Sumit has uploaded a new change for review. https://gerrit.wikimedia.org/r/226303 Change subject: WikidataPageBanner allow space in image src .. WikidataPageBanner allow space in image src Bug: T106321 Change-Id:

[MediaWiki-commits] [Gerrit] WikidataPageBanner toc - make toc less overlapping - change (mediawiki...WikidataPageBanner)

2015-07-21 Thread Sumit (Code Review)
Sumit has uploaded a new change for review. https://gerrit.wikimedia.org/r/226229 Change subject: WikidataPageBanner toc - make toc less overlapping .. WikidataPageBanner toc - make toc less overlapping To prevent too much

[MediaWiki-commits] [Gerrit] WikidataPageBanner allow spaces in banner href - change (mediawiki...WikidataPageBanner)

2015-07-20 Thread Sumit (Code Review)
Sumit has uploaded a new change for review. https://gerrit.wikimedia.org/r/225855 Change subject: WikidataPageBanner allow spaces in banner href .. WikidataPageBanner allow spaces in banner href Bug: T106321 Change-Id:

[MediaWiki-commits] [Gerrit] WikidataPageBanner add custom banner category - change (mediawiki...WikidataPageBanner)

2015-07-20 Thread Sumit (Code Review)
Sumit has uploaded a new change for review. https://gerrit.wikimedia.org/r/225904 Change subject: WikidataPageBanner add custom banner category .. WikidataPageBanner add custom banner category Return the value specified in

[MediaWiki-commits] [Gerrit] WikidataPageBanner prefix class names with wpb- - change (mediawiki...WikidataPageBanner)

2015-07-10 Thread Sumit (Code Review)
Sumit has uploaded a new change for review. https://gerrit.wikimedia.org/r/224089 Change subject: WikidataPageBanner prefix class names with wpb- .. WikidataPageBanner prefix class names with wpb- Class names on banner

[MediaWiki-commits] [Gerrit] Prevent back button hiding on scroll in chrome - change (mediawiki...MobileFrontend)

2015-07-10 Thread Sumit (Code Review)
Sumit has uploaded a new change for review. https://gerrit.wikimedia.org/r/224194 Change subject: Prevent back button hiding on scroll in chrome .. Prevent back button hiding on scroll in chrome Add overflow: visible to back

[MediaWiki-commits] [Gerrit] Fix blurry banners when no support for srcset - change (mediawiki...WikidataPageBanner)

2015-07-09 Thread Sumit (Code Review)
Sumit has uploaded a new change for review. https://gerrit.wikimedia.org/r/223746 Change subject: Fix blurry banners when no support for srcset .. Fix blurry banners when no support for srcset Set src attribute of banner

[MediaWiki-commits] [Gerrit] WikidataPageBanner hide icon placeholder if empty - change (mediawiki...WikidataPageBanner)

2015-07-08 Thread Sumit (Code Review)
Sumit has uploaded a new change for review. https://gerrit.wikimedia.org/r/223558 Change subject: WikidataPageBanner hide icon placeholder if empty .. WikidataPageBanner hide icon placeholder if empty Bug: T105163 Change-Id:

[MediaWiki-commits] [Gerrit] TalkSectionOverlay disallow empty fields - change (mediawiki...MobileFrontend)

2015-07-08 Thread Sumit (Code Review)
Sumit has uploaded a new change for review. https://gerrit.wikimedia.org/r/223657 Change subject: TalkSectionOverlay disallow empty fields .. TalkSectionOverlay disallow empty fields Keep save button disabled on add-talk

[MediaWiki-commits] [Gerrit] More padding to check icons in collection overlay - change (mediawiki...Gather)

2015-07-07 Thread Sumit (Code Review)
Sumit has uploaded a new change for review. https://gerrit.wikimedia.org/r/223370 Change subject: More padding to check icons in collection overlay .. More padding to check icons in collection overlay Padding for list in

[MediaWiki-commits] [Gerrit] WikidataPageBanner allow custom Wikidata Banner - change (mediawiki...WikidataPageBanner)

2015-07-06 Thread Sumit (Code Review)
Sumit has uploaded a new change for review. https://gerrit.wikimedia.org/r/223065 Change subject: WikidataPageBanner allow custom Wikidata Banner .. WikidataPageBanner allow custom Wikidata Banner If {{PAGEBANNER}} provides

[MediaWiki-commits] [Gerrit] Add pageactions check while rendering pre-content - change (mediawiki...MobileFrontend)

2015-07-06 Thread Sumit (Code Review)
Sumit has uploaded a new change for review. https://gerrit.wikimedia.org/r/223090 Change subject: Add pageactions check while rendering pre-content .. Add pageactions check while rendering pre-content This allows

[MediaWiki-commits] [Gerrit] WikidataPageBanner fixes for skin Minerva - change (mediawiki...WikidataPageBanner)

2015-07-03 Thread Sumit (Code Review)
Sumit has uploaded a new change for review. https://gerrit.wikimedia.org/r/222693 Change subject: WikidataPageBanner fixes for skin Minerva .. WikidataPageBanner fixes for skin Minerva Introduced the following css changes

[MediaWiki-commits] [Gerrit] WikidataPageBanner remove i18n-alias reference - change (mediawiki...WikidataPageBanner)

2015-06-30 Thread Sumit (Code Review)
Sumit has uploaded a new change for review. https://gerrit.wikimedia.org/r/221881 Change subject: WikidataPageBanner remove i18n-alias reference .. WikidataPageBanner remove i18n-alias reference Change-Id:

[MediaWiki-commits] [Gerrit] WikidataPageBanner remove url for 2x from srcset - change (mediawiki...WikidataPageBanner)

2015-06-30 Thread Sumit (Code Review)
Sumit has uploaded a new change for review. https://gerrit.wikimedia.org/r/221898 Change subject: WikidataPageBanner remove url for 2x from srcset .. WikidataPageBanner remove url for 2x from srcset Remove the image-url for

[MediaWiki-commits] [Gerrit] WikidataPageBanner remove unused files - change (mediawiki...WikidataPageBanner)

2015-06-29 Thread Sumit (Code Review)
Sumit has uploaded a new change for review. https://gerrit.wikimedia.org/r/221636 Change subject: WikidataPageBanner remove unused files .. WikidataPageBanner remove unused files Following redundant files leftover from

[MediaWiki-commits] [Gerrit] WikidataPageBanner hook changes - change (mediawiki...WikidataPageBanner)

2015-06-28 Thread Sumit (Code Review)
Sumit has uploaded a new change for review. https://gerrit.wikimedia.org/r/221459 Change subject: WikidataPageBanner hook changes .. WikidataPageBanner hook changes Remove addDefaultBanner(ArticleViewHeader hook) and add

[MediaWiki-commits] [Gerrit] WikidataPageBanner getWPBFunctionsInstace() added - change (mediawiki...WikidataPageBanner)

2015-06-26 Thread Sumit (Code Review)
Sumit has uploaded a new change for review. https://gerrit.wikimedia.org/r/221279 Change subject: WikidataPageBanner getWPBFunctionsInstace() added .. WikidataPageBanner getWPBFunctionsInstace() added This adds a static

[MediaWiki-commits] [Gerrit] WikidataPageBanner add getBannerUrl test - change (mediawiki...WikidataPageBanner)

2015-06-25 Thread Sumit (Code Review)
Sumit has uploaded a new change for review. https://gerrit.wikimedia.org/r/220963 Change subject: WikidataPageBanner add getBannerUrl test .. WikidataPageBanner add getBannerUrl test Adds a test for function getBannerUrl()

[MediaWiki-commits] [Gerrit] WikidataPageBanner custom banner on page-preview - change (mediawiki...WikidataPageBanner)

2015-06-16 Thread Sumit (Code Review)
Sumit has uploaded a new change for review. https://gerrit.wikimedia.org/r/218691 Change subject: WikidataPageBanner custom banner on page-preview .. WikidataPageBanner custom banner on page-preview Modify loadModules() to

[MediaWiki-commits] [Gerrit] WikidataPageBanner toc added - change (mediawiki...WikidataPageBanner)

2015-06-16 Thread Sumit (Code Review)
Sumit has uploaded a new change for review. https://gerrit.wikimedia.org/r/218672 Change subject: WikidataPageBanner toc added .. WikidataPageBanner toc added Add option 'toc=yes' to allow passing a parameter to

[MediaWiki-commits] [Gerrit] WikidataPageBanner Add unit tests - change (mediawiki...WikidataPageBanner)

2015-06-08 Thread Sumit (Code Review)
Sumit has uploaded a new change for review. https://gerrit.wikimedia.org/r/216735 Change subject: WikidataPageBanner Add unit tests .. WikidataPageBanner Add unit tests This patch introduces unit-testing for the following

[MediaWiki-commits] [Gerrit] Fix phpcs warnings in WikidataPageBanner - change (mediawiki...WikidataPageBanner)

2015-06-05 Thread Sumit (Code Review)
Sumit has uploaded a new change for review. https://gerrit.wikimedia.org/r/216108 Change subject: Fix phpcs warnings in WikidataPageBanner .. Fix phpcs warnings in WikidataPageBanner Remove unused $wgScript and

[MediaWiki-commits] [Gerrit] Add php entry points for WikidataPageBanner - change (mediawiki...WikidataPageBanner)

2015-06-03 Thread Sumit (Code Review)
Sumit has uploaded a new change for review. https://gerrit.wikimedia.org/r/215574 Change subject: Add php entry points for WikidataPageBanner .. Add php entry points for WikidataPageBanner As per

[MediaWiki-commits] [Gerrit] WikidataPageBanner option to add icons added - change (mediawiki...WikidataPageBanner)

2015-06-01 Thread Sumit (Code Review)
Sumit has uploaded a new change for review. https://gerrit.wikimedia.org/r/215029 Change subject: WikidataPageBanner option to add icons added .. WikidataPageBanner option to add icons added The extension now supports

[MediaWiki-commits] [Gerrit] WikidataPageBanner add option caption - change (mediawiki...WikidataPageBanner)

2015-05-30 Thread Sumit (Code Review)
Sumit has uploaded a new change for review. https://gerrit.wikimedia.org/r/214895 Change subject: WikidataPageBanner add option caption .. WikidataPageBanner add option caption Add parameter 'caption' to {{PAGEBANNER}}

[MediaWiki-commits] [Gerrit] WikidataPageBanner allow named parameters - change (mediawiki...WikidataPageBanner)

2015-05-29 Thread Sumit (Code Review)
Sumit has uploaded a new change for review. https://gerrit.wikimedia.org/r/214672 Change subject: WikidataPageBanner allow named parameters .. WikidataPageBanner allow named parameters Allow the use of parameters of the form

[MediaWiki-commits] [Gerrit] WikidataPageBanner: Add template for banner markup - change (mediawiki...WikidataPageBanner)

2015-05-25 Thread Sumit (Code Review)
Sumit has uploaded a new change for review. https://gerrit.wikimedia.org/r/213576 Change subject: WikidataPageBanner: Add template for banner markup .. WikidataPageBanner: Add template for banner markup The pagebanner

[MediaWiki-commits] [Gerrit] WikidataPageBanner::getWikidataBanner added - change (mediawiki...WikidataPageBanner)

2015-05-24 Thread Sumit (Code Review)
Sumit has uploaded a new change for review. https://gerrit.wikimedia.org/r/213478 Change subject: WikidataPageBanner::getWikidataBanner added .. WikidataPageBanner::getWikidataBanner added A function getWikidataBanner() is

[MediaWiki-commits] [Gerrit] WikidataPageBanner client-side image loading - change (mediawiki...WikidataPageBanner)

2015-05-21 Thread Sumit (Code Review)
Sumit has uploaded a new change for review. https://gerrit.wikimedia.org/r/212512 Change subject: WikidataPageBanner client-side image loading .. WikidataPageBanner client-side image loading In order to load banner image of

[MediaWiki-commits] [Gerrit] WikidataPageBanner image loading via api - change (mediawiki...WikidataPageBanner)

2015-05-18 Thread Sumit (Code Review)
Sumit has uploaded a new change for review. https://gerrit.wikimedia.org/r/211676 Change subject: WikidataPageBanner image loading via api .. WikidataPageBanner image loading via api Change-Id:

[MediaWiki-commits] [Gerrit] WikidataPageBanner: PAGEBANNER magic word added - change (mediawiki...WikidataPageBanner)

2015-05-06 Thread Sumit (Code Review)
Sumit has uploaded a new change for review. https://gerrit.wikimedia.org/r/209432 Change subject: WikidataPageBanner: PAGEBANNER magic word added .. WikidataPageBanner: PAGEBANNER magic word added 'PAGEBANNER' magic word

[MediaWiki-commits] [Gerrit] WikidataPageBanner minor issues fixed - change (mediawiki...WikidataPageBanner)

2015-05-05 Thread Sumit (Code Review)
Sumit has uploaded a new change for review. https://gerrit.wikimedia.org/r/208961 Change subject: WikidataPageBanner minor issues fixed .. WikidataPageBanner minor issues fixed As a followup on

[MediaWiki-commits] [Gerrit] PageBanner: Static banner placeholder created - change (mediawiki...WikidataPageBanner)

2015-05-01 Thread Sumit (Code Review)
Sumit has uploaded a new change for review. https://gerrit.wikimedia.org/r/208096 Change subject: PageBanner: Static banner placeholder created .. PageBanner: Static banner placeholder created A static banner placeholder

[MediaWiki-commits] [Gerrit] README Changed - change (mediawiki...WikidataPageBanner)

2015-04-01 Thread Sumit (Code Review)
Sumit has uploaded a new change for review. https://gerrit.wikimedia.org/r/201270 Change subject: README Changed .. README Changed Bug: T93127 Change-Id: If985231679a47897307ec37019efccc15061db33 --- M README 1 file changed,

[MediaWiki-commits] [Gerrit] MediaViewer cancel button made to close viewer - change (mediawiki...MobileFrontend)

2015-03-27 Thread Sumit (Code Review)
Sumit has uploaded a new change for review. https://gerrit.wikimedia.org/r/200201 Change subject: MediaViewer cancel button made to close viewer .. MediaViewer cancel button made to close viewer Cancel button on media viewer

[MediaWiki-commits] [Gerrit] ChangeOpsMerge Case insensitive string check added - change (mediawiki...Wikibase)

2015-03-19 Thread Sumit (Code Review)
Sumit has uploaded a new change for review. https://gerrit.wikimedia.org/r/197909 Change subject: ChangeOpsMerge Case insensitive string check added .. ChangeOpsMerge Case insensitive string check added wbmergeitems adds

[MediaWiki-commits] [Gerrit] Sniff to check assignment expressions in while, if - change (mediawiki...codesniffer)

2015-03-15 Thread Sumit (Code Review)
Sumit has uploaded a new change for review. https://gerrit.wikimedia.org/r/196873 Change subject: Sniff to check assignment expressions in while,if .. Sniff to check assignment expressions in while,if Mediawiki Sniff to

[MediaWiki-commits] [Gerrit] PhotoUploadOverlay and Progress use View##event - change (mediawiki...MobileFrontend)

2015-03-13 Thread Sumit (Code Review)
Sumit has uploaded a new change for review. https://gerrit.wikimedia.org/r/196609 Change subject: PhotoUploadOverlay and Progress use View##event .. PhotoUploadOverlay and Progress use View##event PhotoUploadOverlay and

  1   2   >