Re: [HACKERS] Relation extension scalability

2016-03-11 Thread Petr Jelinek
many MB when all you actually needed were a couple dozen more pages. I agree, We can have some max limit on number of extra pages, What other thinks ? Well, that's what I meant with clamping originally. I don't know what is a good value though. -- Petr Jelinek

Re: [HACKERS] pl/pgSQL, get diagnostics and big data

2016-03-11 Thread Petr Jelinek
e the 0004 and bottom of 0003 in http://www.postgresql.org/message-id/557d9ded.2080...@2ndquadrant.com (I think at minimum what the 0003 does in c.h is needed). -- Petr Jelinek http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services --

Re: [HACKERS] WIP: Upper planner pathification

2016-03-13 Thread Petr Jelinek
o me that seems too low inside the planning tree, perhaps adding it just to the subquery_planner before SS_identify_outer_params would be better, that's the place where you see the path for the whole (sub)query so you can search and modify what you need from there. -- Petr Jelinek http:

Re: [HACKERS] Reworks of CustomScan serialization/deserialization

2016-03-13 Thread Petr Jelinek
On 14/03/16 02:53, Kouhei Kaigai wrote: >> -Original Message- >> From: pgsql-hackers-ow...@postgresql.org >> [mailto:pgsql-hackers-ow...@postgresql.org] On Behalf Of Petr Jelinek >> Sent: Friday, March 11, 2016 12:27 AM >> To: Kaigai Kouhei(海外 浩平); pgsql-hac

Re: [HACKERS] Relation extension scalability

2016-03-13 Thread Petr Jelinek
further tune it if the need arises in next one. (with my love for round numbers I would have suggested 8MB as that's 3 orders of magnitude, but I am fine with 4MB as well) -- Petr Jelinek http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services -

Re: [HACKERS] Logical decoding slots can go backwards when used from SQL, docs are wrong

2016-03-14 Thread Petr Jelinek
LSN in SQL interface by first calling the pg_logical_slot_get_changes function with upto_lsn set to whatever lsn you expect to start at, but it's ugly. -- Petr Jelinek http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services -- Sent vi

Re: [HACKERS] Logical decoding slots can go backwards when used from SQL, docs are wrong

2016-03-14 Thread Petr Jelinek
was that the next call will start from whatever lsn you specified as upto_lsn. -- Petr Jelinek http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to

Re: [HACKERS] WIP: Access method extendability

2016-03-08 Thread Petr Jelinek
tionNeedsWAL() nothing to hard and hidden magic like not doing anything with WAL for the unlogged tables is seldomly good idea. Another small thing is that we put the API explanation comments into .c file not .h file. Didn't look at the bloom index too deeply yet. -- Petr Jelinek

Re: [HACKERS] Timeline following for logical slots

2016-03-09 Thread Petr Jelinek
to a physical replica using a base backup taken by pg_basebackup and without the presence of failover slots. I won't pretend it's pretty. Well for testing purposes it's quite fine I think. The TAP framework enhancements needed for this are now in and it works correctly against current master. -- Petr

Re: [HACKERS] VS 2015 support in src/tools/msvc

2016-03-09 Thread Petr Jelinek
) because in new CRT putenv have different signature. Hmm, I don't see any problem there. We should however add the msvc 2015 module to rtmodules in the pgwin32_putenv so that we can run just with that runtime. -- Petr Jelinek http://www.2ndQuadrant.com/ PostgreSQL Development

Re: [HACKERS] auto_explain sample rate

2016-03-09 Thread Petr Jelinek
description and the documentation say it's in percent but that's not really true as percent is 0 to 100. -- Petr Jelinek http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql

Re: [HACKERS] auto_explain sample rate

2016-03-11 Thread Petr Jelinek
On 11/03/16 11:45, Magnus Hagander wrote: On Thu, Mar 10, 2016 at 10:07 PM, Petr Jelinek <p...@2ndquadrant.com <mailto:p...@2ndquadrant.com>> wrote: On 10/03/16 20:59, Julien Rouhaud wrote: On 10/03/2016 04:37, Petr Jelinek wrote: On 17/02/16 01:17, Ju

Re: [HACKERS] [PATCH] Logical decoding support for sequence advances

2016-03-11 Thread Petr Jelinek
On 02/03/16 08:05, Craig Ringer wrote: On 1 March 2016 at 05:30, Petr Jelinek <p...@2ndquadrant.com <mailto:p...@2ndquadrant.com>> wrote: On 29/02/16 03:23, Craig Ringer wrote: Sound reasonable? I wonder if it would be acceptable to create new info flag for

Re: [HACKERS] MinGW versus _strtoui64() ?

2016-03-12 Thread Petr Jelinek
On 13/03/16 03:30, Tom Lane wrote: Per a comment from Petr Jelinek, I added this in commit 23a27b039d94ba35: #ifdef WIN32 return _strtoui64(str, endptr, base); #else ... Several of the Windows buildfarm members are good with that, but narwhal is not: numutils.c: In function

Re: [HACKERS] MinGW versus _strtoui64() ?

2016-03-12 Thread Petr Jelinek
On 13/03/16 04:24, Tom Lane wrote: Petr Jelinek <p...@2ndquadrant.com> writes: On 13/03/16 03:30, Tom Lane wrote: Per a comment from Petr Jelinek, I added this in commit 23a27b039d94ba35: #ifdef WIN32 return _strtoui64(str, endptr, base); #else ... Several of the Windows buildfarm m

Re: [HACKERS] WIP: Access method extendability

2016-03-19 Thread Petr Jelinek
like the English of the generic_xlog.c description improved but I won't get to it before weekend. -- Petr Jelinek http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql

Re: [HACKERS] VS 2015 support in src/tools/msvc

2016-03-09 Thread Petr Jelinek
of doing this in VS2015 that would work with older versions of windows with the exception of having our own definition of the locale_t struct so that the VS2013 code would still work... -- Petr Jelinek http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Trainin

Re: [HACKERS] WAL log only necessary part of 2PC GID

2016-03-09 Thread Petr Jelinek
Hi, I wonder why you define the gidlen as uint32 when it would fit into uint8 which in the current TwoPhaseFileHeader struct should be win of 8 bytes on padding (on 64bit). I think that's something worth considering given that this patch aims to lower the size of the data. -- Petr

Re: [HACKERS] [PROPOSAL] Client Log Output Filtering

2016-03-09 Thread Petr Jelinek
't see any reason not to accept this. Yes, the idea seems sane. Looking at the code, this adds bool hide_from_client to edata which is not initialized in errstart so that needs to be fixed. -- Petr Jelinek http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 S

Re: [HACKERS] Proposal: Generic WAL logical messages

2016-03-09 Thread Petr Jelinek
ify(uint8 info) { if ((info & ~XLR_INFO_MASK) == XLOG_LOGICAL_MESSAGE) return "MESSAGE"; return NULL; } Correct, fixed, thanks. I also rebased this as there was conflict after the fixes to logical decoding by Andres. -- Petr Jelinek http://www.2

Re: [HACKERS] Reworks of CustomScan serialization/deserialization

2016-03-09 Thread Petr Jelinek
_LEN); Shouldn't this be actually "if" with ereport() considering this is public API and extensions can pass anything there? (for that matter same is true for RegisterExtensibleNodeMethods but that's already committed). Other than that this seems like straight conversion to same basic t

Re: [HACKERS] Reworks of CustomScan serialization/deserialization

2016-03-09 Thread Petr Jelinek
not specified. > Well that's exactly my problem, this should IMHO throw error even without --enable-cassert. It's not like it's some performance sensitive API where if would be big problem, ensuring correctness of the input is more imporant here IMHO. -- Petr Jelinek htt

Re: [HACKERS] Relation extension scalability

2016-03-09 Thread Petr Jelinek
. -- Petr Jelinek http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Relation extension scalability

2016-03-28 Thread Petr Jelinek
? It seems so, do you have ability to reasonably test with 64 clients? I am mostly wondering if we see the performance going further down or just plateau. -- Petr Jelinek http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services -- Sent via p

Re: [HACKERS] WIP: Access method extendability

2016-03-29 Thread Petr Jelinek
be size of page plus size of fragment >+ * header. >+ */ >+ #define FRAGMENT_HEADER_SIZE (2 * sizeof(OffsetNumber)) >+ #define MATCH_THRESHOLD FRAGMENT_HEADER_SIZE >+ #define MAX_DELTA_SIZE BLCKSZ + FRAGMENT_HEADER_SIZE I incorporated your changes and did some

Re: [HACKERS] WIP: Access method extendability

2016-03-29 Thread Petr Jelinek
it is. It's not perfect but it's better (I am not native speaker either). It's same as v12, just changed comments somewhat. -- Petr Jelinek http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services diff --git a/src/backend/access/rmgrdesc/Makefile b

Re: [HACKERS] VS 2015 support in src/tools/msvc

2016-03-29 Thread Petr Jelinek
have machine ready, waiting for animal name and secret. It will obviously fail until we push the 0002 and 0004 though. -- Petr Jelinek http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services -- Sent via pgsql-hackers mailing lis

Re: [HACKERS] Proposal: Generic WAL logical messages

2016-04-06 Thread Petr Jelinek
. -- Petr Jelinek http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services diff --git a/contrib/test_decoding/expected/messages.out b/contrib/test_decoding/expected/messages.out index 70130e9..a5b13c5 100644 --- a/contrib/test_decoding/expe

Re: [HACKERS] Timeline following for logical slots

2016-04-07 Thread Petr Jelinek
recovering from error rather than being hell bent on preventing it is something I am pushing as well. For example it should be easier to look at what's in replication queue and remove things from there if needed. -- Petr Jelinek http://www.2ndQuadrant.com/ PostgreSQL Develop

Re: [HACKERS] Proposal: Generic WAL logical messages

2016-04-07 Thread Petr Jelinek
On 07/04/16 12:26, Andres Freund wrote: Hi, On 2016-04-06 20:03:20 +0200, Petr Jelinek wrote: Attached patch adds filtering of both database and origin. Added tests with slightly less hardcoding than what you proposed above. Not a fan of creating & dropping another database - that's re

Re: [HACKERS] VS 2015 support in src/tools/msvc

2016-04-06 Thread Petr Jelinek
mpiler. It's fun to set it up yes. I do have the machine with buildfarm client ready still (although now also traveling so slightly complicated to get to it) but I didn't activate it yet as I don't want it to just report failures forever. -- Petr Jelinek http://www.2ndQuadra

Re: [HACKERS] VS 2015 support in src/tools/msvc

2016-04-06 Thread Petr Jelinek
On 07/04/16 00:50, Michael Paquier wrote: On Thu, Apr 7, 2016 at 7:44 AM, Michael Paquier <michael.paqu...@gmail.com> wrote: On Thu, Apr 7, 2016 at 6:11 AM, Petr Jelinek <p...@2ndquadrant.com> wrote: On 06/04/16 22:50, Andrew Dunstan wrote: I have spent way too much time on th

Re: [HACKERS] Sequence Access Method WIP

2016-04-05 Thread Petr Jelinek
On 04/04/16 15:53, Fabrízio de Royes Mello wrote: On Thu, Mar 31, 2016 at 9:19 AM, Petr Jelinek <p...@2ndquadrant.com <mailto:p...@2ndquadrant.com>> wrote: > > Hi, > > new version attached that should fix the issue. It was alignment - honestly don't know what I

Re: [HACKERS] VS 2015 support in src/tools/msvc

2016-04-08 Thread Petr Jelinek
, but just in 12 hours or so, aka after the deadline if that matters for this patch. I won't be able to get back to it (well mainly to windows environment) till Thursday due to travel, sorry. -- Petr Jelinek http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 S

Re: [HACKERS] VS 2015 support in src/tools/msvc

2016-04-10 Thread Petr Jelinek
rry is that given that the header file is obviously unfinished in the area where this is defined and also the fact that this looks like something that's not meant to be used outside of that header makes people worry that it might change between point releases of the SDK. -- Petr Jelinek

Re: [HACKERS] Timeline following for logical slots

2016-04-05 Thread Petr Jelinek
her people would, too. I agree with the exception of working HA. I would consider it very sad if we got logical replication in core without having any provision for continuity of service. Doing that is relatively trivial in comparison to the logical replication itself however. -- Pe

Re: [HACKERS] [PATH] Jsonb, insert a new value into an array at arbitrary position

2016-04-05 Thread Petr Jelinek
onable. Here is a new version of patch (it will throw an error for an existing key). Is it better now? This seems like reasonable compromise to me. I wonder if the errcode should be ERRCODE_INVALID_PARAMETER_VALUE but don't feel too strongly about that. -- Petr Jelinek

[HACKERS] Re: [PATH] Jsonb, insert a new value into an array at arbitrary position

2016-03-19 Thread Petr Jelinek
I still don't like that this works on path leading to an object given that we can't fulfill the promise of inserting to an arbitrary position there. -- Petr Jelinek http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services -- Sent via p

Re: [HACKERS] VS 2015 support in src/tools/msvc

2016-03-20 Thread Petr Jelinek
ecated or anything, it's just that the public headers are botched in current version and apparently nobody important is using them to force MS to fix them. -- Petr Jelinek http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services -- Sent via pgs

Re: [HACKERS] Sequence Access Method WIP

2016-03-20 Thread Petr Jelinek
On 19/03/16 23:02, Alvaro Herrera wrote: Petr Jelinek wrote: And finally the 0003-gapless-seq is example contrib module that implements dependably and transitionally safe gapless sequence access method. It's obviously slow as it has to do locking and basically serialize all the changes

Re: [HACKERS] WIP: Access method extendability

2016-03-22 Thread Petr Jelinek
hich means it would probably be better to record dependency of opclass on amhandler as mentioned before, since this is already solved for functions and if the oid of am is not referenced anywhere it does not need special handling for binary upgrade). -- Petr Jelinek http://www.2ndQu

Re: [HACKERS] Applying logical replication changes by more than one process

2016-03-22 Thread Petr Jelinek
On 22/03/16 07:32, konstantin knizhnik wrote: On Mar 21, 2016, at 4:30 PM, Petr Jelinek wrote: On 21/03/16 14:25, Andres Freund wrote: On 2016-03-21 14:18:27 +0100, Petr Jelinek wrote: On 21/03/16 14:15, Andres Freund wrote: Only when the origin is actually setup for the current session

Re: [HACKERS] Proposal: Generic WAL logical messages

2016-03-22 Thread Petr Jelinek
On 22/03/16 12:47, Andres Freund wrote: On 2016-03-21 18:10:55 +0100, Petr Jelinek wrote: + + + Generic Message Callback + + + The optional message_cb callback is called whenever + a logical decoding message has been decoded. + +typedef void (*LogicalDecodeMessageCB

Re: [HACKERS] Relation extension scalability

2016-03-22 Thread Petr Jelinek
to take lock or not, whether to add extra blocks or not.. I also think the code simplicity makes this worth it. -- Petr Jelinek http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hacker

Re: [HACKERS] Proposal: Generic WAL logical messages

2016-03-23 Thread Petr Jelinek
On 23/03/16 14:17, Alvaro Herrera wrote: Petr Jelinek wrote: +++ b/contrib/test_decoding/sql/messages.sql @@ -0,0 +1,17 @@ +-- predictability +SET synchronous_commit = on; + +SELECT 'init' FROM pg_create_logical_replication_slot('regression_slot', 'test_decoding'); + +SELECT 'msg1' FROM

Re: [HACKERS] multivariate statistics v14

2016-03-23 Thread Petr Jelinek
itting the functionality into patchset. -- Petr Jelinek http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mail

Re: [HACKERS] Reworks of CustomScan serialization/deserialization

2016-03-23 Thread Petr Jelinek
). -- Petr Jelinek http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Relation extension scalability

2016-03-23 Thread Petr Jelinek
On 23/03/16 20:01, Robert Haas wrote: On Wed, Mar 23, 2016 at 2:52 PM, Petr Jelinek <p...@2ndquadrant.com> wrote: Second, if the other backend extended the relation in some other manner and did not extend the FSM, how does calling RecordAndGetPageWithFreeSpace help? As far as I c

Re: [HACKERS] VS 2015 support in src/tools/msvc

2016-03-23 Thread Petr Jelinek
; a couple of times. Hmm I see you are right, I missed the last couple emails. Ok I'll mark it ready for committer - it does work fine on my vs2015 machine and I am happy with the code too. Well, as happy as I can be given the locale mess. -- Petr Jelinek http://www.2ndQu

Re: [HACKERS] Relation extension scalability

2016-03-23 Thread Petr Jelinek
On 23/03/16 20:19, Petr Jelinek wrote: On 23/03/16 20:01, Robert Haas wrote: On Wed, Mar 23, 2016 at 2:52 PM, Petr Jelinek <p...@2ndquadrant.com> wrote: Second, if the other backend extended the relation in some other manner and did not extend the FSM, how does c

Re: [HACKERS] Relation extension scalability

2016-03-23 Thread Petr Jelinek
On 23/03/16 20:43, Robert Haas wrote: On Wed, Mar 23, 2016 at 3:33 PM, Petr Jelinek <p...@2ndquadrant.com> wrote: Btw thinking about it some more, ISTM that not finding the block and just doing the extension if the FSM wasn't extended correctly previously is probably cleaner behavior tha

Re: [HACKERS] VS 2015 support in src/tools/msvc

2016-03-23 Thread Petr Jelinek
be committed, but the 0003 might be somewhat controversial based on the original thread. -- Petr Jelinek http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make

Re: [HACKERS] Rationalizing code-sharing among src/bin/ directories

2016-03-23 Thread Petr Jelinek
ckend/utils/mb/encnames.c which seem like they'd be better handled by moving those files into src/common/. Thoughts? Yes please! -- Petr Jelinek http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services -- Sent via pgsql-hackers mailing list (

Re: [HACKERS] VS 2015 support in src/tools/msvc

2016-03-24 Thread Petr Jelinek
break other Windows builds? I mean, if we've got the names for those symbols wrong, how is this working right now? We didn't older versions just defined the other variants as well, but the _timezone and _tzname have been around since at least VS2003. -- Petr Jelinek http

Re: [HACKERS] Applying logical replication changes by more than one process

2016-03-21 Thread Petr Jelinek
On 21/03/16 14:25, Andres Freund wrote: On 2016-03-21 14:18:27 +0100, Petr Jelinek wrote: On 21/03/16 14:15, Andres Freund wrote: Only when the origin is actually setup for the current session. You need to call the replorigin_advance yourself from your apply code. That's problematic from

Re: [HACKERS] Applying logical replication changes by more than one process

2016-03-21 Thread Petr Jelinek
On 21/03/16 14:15, Andres Freund wrote: On March 21, 2016 2:08:54 PM GMT+01:00, Petr Jelinek <p...@2ndquadrant.com> wrote: On 21/03/16 13:44, Konstantin Knizhnik wrote: On 21.03.2016 15:10, Petr Jelinek wrote: Hi, On 19/03/16 11:46, Konstantin Knizhnik wrote: Hi, I am trying

Re: [HACKERS] Proposal: Generic WAL logical messages

2016-03-21 Thread Petr Jelinek
(just like the other structs around). Okay. Updated version attached. (BTW please try to CC author of the patch when reviewing) -- Petr Jelinek http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services &

Re: [HACKERS] Applying logical replication changes by more than one process

2016-03-21 Thread Petr Jelinek
On 21/03/16 13:44, Konstantin Knizhnik wrote: On 21.03.2016 15:10, Petr Jelinek wrote: Hi, On 19/03/16 11:46, Konstantin Knizhnik wrote: Hi, I am trying to use logical replication mechanism in implementation of PostgreSQL multimaster and faced with one conceptual problem. Originally

Re: [HACKERS] Applying logical replication changes by more than one process

2016-03-21 Thread Petr Jelinek
sion_setup for same origin only in one process but you don't need to have it setup for session to update it, the replorigin_advance() works just fine. -- Petr Jelinek http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services -- Sent via pgs

Re: [HACKERS] Applying logical replication changes by more than one process

2016-03-21 Thread Petr Jelinek
sion_setup for same origin only in one process but you don't need to have it setup for session to update it, the replorigin_advance() works just fine. -- Petr Jelinek http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services -- Sent via pgs

Re: [HACKERS] Proposal: Generic WAL logical messages

2016-03-21 Thread Petr Jelinek
Just noticed there is missing symlink in the pg_xlogdump. -- Petr Jelinek http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services >From f47730e5e8ef5797c7595aafcbf8cff3b375d0ad Mon Sep 17 00:00:00 2001 From: Petr Jelinek <pjmo...@p

Re: [HACKERS] Reworks of CustomScan serialization/deserialization

2016-03-19 Thread Petr Jelinek
the manner of RegisterExtensibleNodeMethods() Hi, looks good, only nitpick I have is that it probably should be custom_node.h with underscore given that we use underscore everywhere (except for libpq and for some reason atomic ops). -- Petr Jelinek http://www

Re: [HACKERS] VS 2015 support in src/tools/msvc

2016-03-22 Thread Petr Jelinek
On 22/03/16 14:40, Michael Paquier wrote: On Wed, Mar 9, 2016 at 11:10 PM, Petr Jelinek <p...@2ndquadrant.com> wrote: Something like attached is simplest way this would work correctly (note that I didn't really test it and it's missing comments). Note that we are falling back to the old p

Re: [HACKERS] Relation extension scalability

2016-03-23 Thread Petr Jelinek
On 23/03/16 19:39, Robert Haas wrote: On Tue, Mar 22, 2016 at 1:12 PM, Petr Jelinek <p...@2ndquadrant.com> wrote: I also think the code simplicity makes this worth it. Agreed. I went over this patch and did a cleanup pass today. I discovered that the LockWaiterCount() function was

Re: [HACKERS] Relation extension scalability

2016-03-24 Thread Petr Jelinek
like this name, but I could not come up with any better, Please suggest one. GetNearestPageWithFreeSpace? (although not sure that's accurate description, maybe Nearby would be better) -- Petr Jelinek http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training

Re: [HACKERS] VS 2015 support in src/tools/msvc

2016-03-03 Thread Petr Jelinek
area so it's definitely not just build system. But I think it should be fairly localized and fenced by ifdef anyway. -- Petr Jelinek http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hacker

Re: [HACKERS] VS 2015 support in src/tools/msvc

2016-03-03 Thread Petr Jelinek
versions of VS won a backpatch the last couple of years) would be a good thing I think. +1, and I can help (at least review and testing if nothing else). -- Petr Jelinek http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services -- Sent via p

Re: [HACKERS] [NOVICE] WHERE clause not used when index is used

2016-03-01 Thread Petr Jelinek
. But I would refrain from adding the complexity as part of a fix. -- Petr Jelinek http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes t

Re: [HACKERS] The plan for FDW-based sharding

2016-03-01 Thread Petr Jelinek
plugin due to admin error) will send server to similar situation as xid wraparound. -- Petr Jelinek http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make chang

Re: [HACKERS] VS 2015 support in src/tools/msvc

2016-03-04 Thread Petr Jelinek
was specified as it uses the setlocale() which returns the legacy (and not recommended) locale names and our fallback code can handle those. But manually set locales can be a problem. -- Petr Jelinek http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training

Re: [HACKERS] Confusing with commit time usage in logical decoding

2016-03-01 Thread Petr Jelinek
On 01/03/16 18:18, Andres Freund wrote: Hi, On 2016-03-01 18:09:28 +0100, Petr Jelinek wrote: On 01/03/16 17:57, Alvaro Herrera wrote: Artur Zakirov wrote: Hello, Andres You have introduced a large replication progress tracking infrastructure last year. And there is a problem described

Re: [HACKERS] Proposal: Generic WAL logical messages

2016-04-03 Thread Petr Jelinek
Hi, I rebased this patch on top of current master as the generic wal commit added some conflicting changes. Also fixed couple of typos in comments and added non ascii message to test. -- Petr Jelinek http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support

Re: [HACKERS] Timeline following for logical slots

2016-04-04 Thread Petr Jelinek
ded catalog xmin and lsn (simple way of doing that would be to add this to feedback protocol and let physical slot to keep the xmin/lsn as well), but that does not mean timeline following isn't good thing on it's own (not to mention that iterative development is a thing). -- Petr Jeli

Re: [HACKERS] WIP: Access method extendability

2016-03-29 Thread Petr Jelinek
my merge 13, but somehow the diff was broken so now I just sent diff against Alexander's work with mine + Alvaro's changes, sorry for confusion. -- Petr Jelinek http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services -- Sent via pgsql-hac

Re: [HACKERS] Sequence Access Method WIP

2016-03-29 Thread Petr Jelinek
E. Hmm nothing special indeed, still can't reproduce, I did one blind try for a fix. Can you test with attached? -- Petr Jelinek http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services >From 7f42f2b420e2b931e1ca013f3fdeaccf302f3618 Mon Sep

Re: [HACKERS] Sequence Access Method WIP

2016-03-29 Thread Petr Jelinek
On 29/03/16 22:08, Fabrízio de Royes Mello wrote: On Tue, Mar 29, 2016 at 4:59 PM, Petr Jelinek <p...@2ndquadrant.com <mailto:p...@2ndquadrant.com>> wrote: > > On 29/03/16 19:46, Fabrízio de Royes Mello wrotez >> >> >> > >> > Hmm I a

Re: [HACKERS] Sequence Access Method WIP

2016-03-30 Thread Petr Jelinek
avoid reading as "is_initIALIZED" Sounds good. DEPENDS ON 0001-seqam-v10.patch , which isn't commited yet --- and it doesn't apply cleanly to current git master. Please update/rebase the patch and resubmit. The current version of seqam is 0001-seqam-2016-03-29 which should apply

Re: [HACKERS] Re: [COMMITTERS] pgsql: Enable logical slots to follow timeline switches

2016-03-31 Thread Petr Jelinek
have a look at whether you have core dumps from these? If so, > backtraces would be very useful. > The function does following: TransactionId new_xmin = (TransactionId) PG_GETARG_INT64(1); And we are passing NULL as that parameter, that could explain this. Also while reading it I wonder if

Re: [HACKERS] Timeline following for logical slots

2016-04-04 Thread Petr Jelinek
onable continuation of service when the original master dies. And waiting until we have logical that's on par with physical for failover will take long time as it needs the above. -- Petr Jelinek http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training &

Re: [HACKERS] Proposal: Generic WAL logical messages

2016-03-23 Thread Petr Jelinek
On 22/03/16 14:11, Andres Freund wrote: On 2016-03-22 14:03:06 +0100, Petr Jelinek wrote: On 22/03/16 12:47, Andres Freund wrote: On 2016-03-21 18:10:55 +0100, Petr Jelinek wrote: + + + Generic Message Callback + + + The optional message_cb callback is called whenever

Re: [HACKERS] Reworks of CustomScan serialization/deserialization

2016-03-23 Thread Petr Jelinek
On 23/03/16 08:34, Kouhei Kaigai wrote: -Original Message- From: pgsql-hackers-ow...@postgresql.org [mailto:pgsql-hackers-ow...@postgresql.org] On Behalf Of Petr Jelinek Sent: Thursday, March 17, 2016 5:06 PM To: Kaigai Kouhei(海外 浩平) Cc: Robert Haas; pgsql-hackers@postgresql.org Subject

Re: [HACKERS] VS 2015 support in src/tools/msvc

2016-04-29 Thread Petr Jelinek
t;caecilian" reported first successful build to the buildfarm. -- Petr Jelinek http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to you

Re: [HACKERS] 9.6 and fsync=off

2016-04-27 Thread Petr Jelinek
updates, and I'm fine with that). +1 (Abhijit's wording with data loss changed to data corruption) -- Petr Jelinek http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)

Re: [HACKERS] VS 2015 support in src/tools/msvc

2016-04-24 Thread Petr Jelinek
ify a single one that was clearly not created or edited by anything other than Visual Studio itself. I did some checking too, and yes it seems having version 12 .sln is fine or maybe even desirable. We mainly need to make sure that the tools version is 14 and platform toolset is v140 for MSVC15. -

Re: [HACKERS] 10.0

2016-05-14 Thread Petr Jelinek
rename clause where nobody wanted to rewrite couple thousand function which used it and there are many examples like that). -- Petr Jelinek http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services -- Sent via pgsql-hackers mailing list (p

Re: [HACKERS] 10.0

2016-05-13 Thread Petr Jelinek
to bump to 10, 11, etc. We can't possibly get all the major features people want into single release given the yearly release cycle. That being said, I think that once we released beta1 as 9.6 it's too late for bumping it. -- Petr Jelinek http://www.2ndQuadrant.com/ Post

Re: [HACKERS] 10.0

2016-05-13 Thread Petr Jelinek
On 13/05/16 20:31, Alvaro Herrera wrote: Josh berkus wrote: Anyway, can we come up with a consensus of some minimum changes it will take to make the next version 10.0? I think the next version should be 10.0 no matter what changes we put in. +1 -- Petr Jelinek http

Re: [HACKERS] Processes and caches in postgresql

2016-05-03 Thread Petr Jelinek
oper feature and you should not use it for deploying anything. -- Petr Jelinek http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your su

[HACKERS] pg_stat_activity crashes

2016-04-20 Thread Petr Jelinek
which is what this patch does though. -- Petr Jelinek http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services diff --git a/src/backend/utils/adt/pgstatfuncs.c b/src/backend/utils/adt/pgstatfuncs.c index 64c4cc4..355e58c 100644 --- a/src/bac

Re: [HACKERS] Pglogical questions and problems

2016-04-14 Thread Petr Jelinek
PGCon, and I don't think Petr is either. That's unfortunate in terms of planning for this. That's a bummer. I suppose you won't be at NYC either? No NYC either. -- Petr Jelinek http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services -

Re: [HACKERS] Pglogical questions and problems

2016-04-14 Thread Petr Jelinek
syntax that's not part of standard to death halting the actual feature development for prolonged time periods as a result. Finally a side note about sharding - I have strong believe that sharding needs to be tightly coupled to be effective and maintainable in production. -- Petr Jelinek

Re: [HACKERS] BRIN vs. HOT

2016-07-28 Thread Petr Jelinek
be HOT or not, but I like you idea more. -- Petr Jelinek http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql

Re: [HACKERS] Design for In-Core Logical Replication

2016-07-26 Thread Petr Jelinek
ION mypub2; This does not yet, but I agree we should have it. -- Petr Jelinek http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subs

Re: [HACKERS] Logical Replication WIP

2016-08-11 Thread Petr Jelinek
really like so I want to limit them to the places where they are actually useful. On 05 Aug 2016, at 18:00, Petr Jelinek <p...@2ndquadrant.com> wrote: - DDL, I see several approaches we could do here for 10.0. a) don't deal with DDL at all yet, b) provide function which pushes t

Re: [HACKERS] multivariate statistics (v19)

2016-08-10 Thread Petr Jelinek
dimension (the actual histogram building algorithm is more complex, but you get the idea). I think it makes sense to pursue this, but I also think we can easily live with not having it in the first version that gets committed and doing it as follow-up patch. -- Petr Jelinek

Re: [HACKERS] A Modest Upgrade Proposal

2016-07-13 Thread Petr Jelinek
ect logical replication patch to do all that, because if you do, you'll be disappointed. -- Petr Jelinek http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make

Re: [HACKERS] Design for In-Core Logical Replication

2016-07-20 Thread Petr Jelinek
y... Just to add to what Simon wrote. There is one more reason for not using term origin for this - origin of data does not necessarily have to be on the provider database once there is a cascading so it does not really map all that well. -- Petr Jelinek http://www.2nd

Re: [HACKERS] A Modest Upgrade Proposal

2016-07-17 Thread Petr Jelinek
functions for manipulating slots and origins as those are just primitives which user should not have to fiddle with but for things that are directly meant for user interaction DDL just feels better. -- Petr Jelinek http://www.2ndQuadrant.com/ PostgreSQL Development, 24

Re: [HACKERS] A Modest Upgrade Proposal

2016-07-17 Thread Petr Jelinek
first. Agreed. -- Petr Jelinek http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] A Modest Upgrade Proposal

2016-07-08 Thread Petr Jelinek
definitions in catalogs though. It's not like we want to do any kind of RPC to add table to replication set on the remote node. -- Petr Jelinek http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services -- Sent via pgsql-hackers mailing lis

<    1   2   3   4   5   6   7   8   9   10   >