Re: [PATCHES] printTable API (was: Show INHERIT in \du)

ool -- on a first read, I think you should add some more code comments at the top of each function specifying whether the texts need to be translated by the caller or done by the function itself. Also it would be good if it is consistent, too :-) -- Alvaro Herrera

Re: [PATCHES] [HACKERS] Terminating a backend

7;s fine, even if it fails on 0.1% of the cases, but you can't use SIGTERM to implement that because it already has a different meaning. -- Alvaro Herrerahttp://www.CommandPrompt.com/ PostgreSQL Replication, Consulting, Custom Development, 24x7 support --

Re: [PATCHES] Reference by output in : \d

Brendan Jurd escribió: > Yeah, that's what I figured. The patch I attached to my previous > email should fix it up. Applied, thanks. -- Alvaro Herrerahttp://www.CommandPrompt.com/ PostgreSQL Replication, Consulting, Custom Development, 24x7 suppor

Re: [PATCHES] options for RAISE statement

Pavel Stehule escribió: > Hello > > this patch adds possibility to set additional options (SQLSTATE, > DETAIL, DETAIL_LOG and HINT) for RAISE statement, Added to May commitfest page, thanks. -- Alvaro Herrerahttp://www.CommandPrompt.com/ The Postgr

Re: [PATCHES] printTable API (was: Show INHERIT in \du)

for each element kind. -- Alvaro Herrerahttp://www.CommandPrompt.com/ The PostgreSQL Company - Command Prompt, Inc. print-table-3.patch.bz2 Description: Binary data -- Sent via pgsql-patches mailing list (pgsql-patches@postgresql.org) To make changes to your subs

Re: [PATCHES] printTable API (was: Show INHERIT in \du)

Brendan Jurd escribió: > On Thu, Apr 17, 2008 at 7:27 AM, Alvaro Herrera wrote: > > One thing I'm not entirely happy about is the fact that we need a > > pointer to the last footer/cell/header, so two pointers for each > > element kind. > > Well, the alte

Re: [PATCHES] Proposed patch - psql wraps at window width

ne in the data. Currently we have a : there, so using a : here is probably not the best idea. -- Alvaro Herrerahttp://www.CommandPrompt.com/ PostgreSQL Replication, Consulting, Custom Development, 24x7 support -- Sent via pgsql-patches mailing list (pgsql-patches@p

Re: [PATCHES] Proposed patch - psql wraps at window width

x27;ve introduced this assumption in the other case on that code (i.e. when alignment is not 'r'). I'm not seeing any checks for multibytes in there, but perhaps I'm missing it. * "} else" is forbidden too. Use two separate lines. -- Alvaro Herrera

Re: [PATCHES] Proposed patch - psql wraps at window width

s were still useful :-) -- Alvaro Herrerahttp://www.CommandPrompt.com/ The PostgreSQL Company - Command Prompt, Inc. -- Sent via pgsql-patches mailing list (pgsql-patches@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-patches

Re: [PATCHES] datum passed to macro which expects a pointer

Gavin Sherry wrote: > Hi all, > > Attached are more fixes. Applied, thanks. -- Alvaro Herrerahttp://www.CommandPrompt.com/ PostgreSQL Replication, Consulting, Custom Development, 24x7 support -- Sent via pgsql-patches mailing list (pgsql-patches@postg

Re: [PATCHES] Coding standards

Bryce Nesbitt wrote: > Alvaro Herrera wrote: >> People [are] complaining here that we don't teach people here anyway, so >> hopefully my comments were still useful :-) >> > Yes they are useful. As a new patcher, where should I look for coding > standards? How

Re: [PATCHES] float4/float8/int64 passed by value with tsearch fixup

of float32, and thus the last usage of float32 gone, I am now wondering if it would be a good idea to remove the float32 and float32data definitions in c.h. Thanks to Zoltan for the patch. -- Alvaro Herrerahttp://www.CommandPrompt.com/ PostgreSQL Replication, Consult

Re: [PATCHES] float4/float8/int64 passed by value with tsearch fixup

Alvaro Herrera wrote: > With contrib/seg also adjusted to use float4 instead of float32, and > thus the last usage of float32 gone, I am now wondering if it would be a > good idea to remove the float32 and float32data definitions in c.h. Ok, the buildfarm is going yellow over this ch

Re: [PATCHES] float4/float8/int64 passed by value with tsearch fixup

Tom Lane wrote: > Alvaro Herrera <[EMAIL PROTECTED]> writes: > > I assume this is just some dumb portability mistake on my part ... or > > perhaps the fact that the functions are still using v0 fmgr convention? > > Since they're v0, they'd have to explicitly k

Re: [PATCHES] float4/float8/int64 passed by value with tsearch fixup

t; altogether, which I don't think we're prepared to do. I have asked the Cybertec guys for a patch. Since it's basically a copy of the float8 change, it should be easy to do. -- Alvaro Herrerahttp://www.CommandPrompt.com/ PostgreSQL Replicat

Re: [PATCHES] Testing pg_terminate_backend()

is subsequently reset. -- Alvaro Herrerahttp://www.CommandPrompt.com/ PostgreSQL Replication, Consulting, Custom Development, 24x7 support -- Sent via pgsql-patches mailing list (pgsql-patches@postgresql.org) To make changes to your subscription: ht

Re: [PATCHES] float4/float8/int64 passed by value with tsearchfixup

8246e-038 | 8.98246e-038 | 8.98246e-038 ! 8.98242e-038 | 8.98242e-038 | 8.98242e-038 ! 9.03781e-038 | 9.03781e-038 | 9.03781e-038 ! 8.98224e-038 | 8.98224e-038 | 8.98224e-038 ! 8.98222e-038 | 8.98222e-038 | 8.98222e-038 ! 8.98215e-038 | 8.98215e-038 | 8.98215e-038 | |

Re: [PATCHES] float4/float8/int64 passed by value with tsearchfixup

ng (btw, what was > that?). So there's definitely a platform dependency involved and not > just you-missed-a-pointer-someplace. Huh, this was with the code with v0 conventions, right? I committed the change to v1 conventions a while ago. -- Alvaro Herrera

Re: [PATCHES] float4/float8/int64 passed by value with tsearch fixup

-byval. Does it pass "make installcheck" in contrib? I'm worried about btree_gist in particular. Perhaps the change I introduced in the previous revision needs to be #ifdef'd out? -- Alvaro Herrerahttp://www.CommandPrompt.com/ The PostgreSQL

Re: [PATCHES] Proposed patch - psql wraps at window width

t; " : " ; ", fout); > ! } > } I think it's a bad idea to use the same " : " separator in the two last cases. They are different and they should be displayed differently. -- Alv

Re: [PATCHES] Proposed patch - psql wraps at window width

Alvaro Herrera wrote: > Bruce Momjian wrote: > > > ! fputs(string_done ? " > > " : " ; ", fout); > > ! } > >

Re: [PATCHES] Testing pg_terminate_backend()

Magnus Hagander wrote: > It's been running fine now for a number of hours, with output that > looks similar to the stuff you posted. I'll leave it running.. Perhaps it would be a good idea to leave it running on code with some bugs on it, just to check if the problems show

Re: [PATCHES] Removing NONSEG mode

t, thanks. -- Alvaro Herrerahttp://www.CommandPrompt.com/ PostgreSQL Replication, Consulting, Custom Development, 24x7 support -- Sent via pgsql-patches mailing list (pgsql-patches@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailp

[PATCHES] Snapshot management, final

CONCURRENTLY, VACUUM FULL, and CLUSTER must now explicitely Pop the ActiveSnapshot set by PortalRunUtility before calling CommitTransactionCommand. -- Alvaro Herrerahttp://www.CommandPrompt.com/ The PostgreSQL Company - Command Prompt, Inc. snapshot-6.patch.bz2

Re: [PATCHES] Snapshot management, final

Simon Riggs wrote: > On Tue, 2008-04-22 at 15:49 -0400, Alvaro Herrera wrote: > > > - Three CopySnapshot call sites remain outside snapmgr.c: DoCopy() on > > copy.c, ExplainOnePlan() on explain.c and _SPI_execute_plan() on spi.c. > > They are there because they grab th

Re: [PATCHES] Snapshot management, final

need. If you need that ability, please explain. -- Alvaro Herrerahttp://www.CommandPrompt.com/ PostgreSQL Replication, Consulting, Custom Development, 24x7 support -- Sent via pgsql-patches mailing list (pgsql-patches@postgresql.org) To make changes to your subsc

Re: [PATCHES] Snapshot management, final

Tom Lane wrote: > Alvaro Herrera <[EMAIL PROTECTED]> writes: > > > CopySnapshot always copies snapshots to SnapshotContext, which is a > > context that lives until transaction end. There's no mechanism for > > copying a snapshot into another context, because

Re: [PATCHES] Snapshot management, final

Simon Riggs wrote: > On Tue, 2008-04-22 at 18:13 -0400, Alvaro Herrera wrote: > > Simon Riggs wrote: > > > > > OK, so it can;t be copied to a longer lived memory context? > > > > If you need that ability, please explain. > > No, I wish to prevent th

Re: [PATCHES] Snapshot management, final

W I noticed yesterday after going to bed that SnapshotContext serves no useful purpose -- we can just remove it and store snaps in TopTransactionContext. -- Alvaro Herrerahttp://www.CommandPrompt.com/ PostgreSQL Replication, Consulting, Custom Development, 24x7 support

Re: [PATCHES] Snapshot management, final

moryContext is no good because we want to free snapshots in a fell swoop at transaction abort. TopTransactionContext would be OK, as I just said in the parallel subthread. -- Alvaro Herrerahttp://www.CommandPrompt.com/ PostgreSQL Replication, Consulting, Custom

Re: [PATCHES] temporal version of generate_series()

H.Harada escribió: > # This is my first time to send a patch. If I did something wrong, I > appreciate your pointing me out. Brace positioning is off w.r.t. our conventions -- please fix that and resubmit. I have added this patch to the May commitfest. -- Alvaro H

Re: [PATCHES] Improve shutdown during online backup, take 4

e. Also, I am wondering if in PM_WAIT_BACKUP mode we should accept new connections from superusers only. -- Alvaro Herrerahttp://www.CommandPrompt.com/ The PostgreSQL Company - Command Prompt, Inc. -- Sent via pgsql-patches mailing list (pgsql-patches@postgresq

Re: [PATCHES] Snapshot management, final

Alvaro Herrera wrote: > FWIW I noticed yesterday after going to bed that SnapshotContext serves > no useful purpose -- we can just remove it and store snaps in > TopTransactionContext. ... which is what the attached patch does. -- Alvaro Herrera

Re: [PATCHES] lc_time and localized dates

edback. Added to May commitfest. -- Alvaro Herrerahttp://www.CommandPrompt.com/ PostgreSQL Replication, Consulting, Custom Development, 24x7 support -- Sent via pgsql-patches mailing list (pgsql-patches@postgresql.org) To make changes to your s

Re: [PATCHES] 64-bit CommandIds

against HEAD which enables extending CommandIds : to 64-bit. This is for enabling long transactions that really do that : much non-read-only work in one transaction. Question for Hans-Juergen and Zoltan: have you tested 8.3 and do you still see the need for this? -- Alvaro Herrera

Re: [PATCHES] generate_subscripts

Pavel Stehule escribió: > This patch contains generate_subscripts functions, that generate > series of array's subscripts of some dimension: Committed, thanks. -- Alvaro Herrerahttp://www.CommandPrompt.com/ The PostgreSQL Company - Command Prompt, Inc

Re: [PATCHES] Removing typename from A_Const (was: Empty arrays with ARRAY[])

st for an A_Const within a > TypeCast. Nonetheless, there was an overall net reduction of 34 lines > of code, so I think this was a win. Do say ... why don't we do away with A_Const altogether and just replace it with Value? After this patch, I don't see what'

Re: [HACKERS] [PATCHES] Removing typename from A_Const (was: Empty arrays with ARRAY[])

Tom Lane escribió: > Alvaro Herrera <[EMAIL PROTECTED]> writes: > > Brendan Jurd escribi�: > >> Here's my attempt to remove the typename field from A_Const. There > >> were a few places (notably flatten_set_variable_args() in guc.c, and > >> ty

Re: [HACKERS] [PATCHES] Removing typename from A_Const (was: Empty arrays with ARRAY[])

Tom Lane escribió: > Alvaro Herrera <[EMAIL PROTECTED]> writes: > > Tom Lane escribió: > >> They're logically different things, and after I get done putting a parse > >> location field into A_Const, they'll still be physically different too. > >

Re: [HACKERS] [PATCHES] Removing typename from A_Const (was: Empty arrays with ARRAY[])

Alvaro Herrera escribió: > Tom Lane escribió: > > Alvaro Herrera <[EMAIL PROTECTED]> writes: > > > Tom Lane escribió: > > >> They're logically different things, and after I get done putting a parse > > >> location field into A_Const, they'

Re: [HACKERS] [PATCHES] Removing typename from A_Const (was: Empty arrays with ARRAY[])

Tom Lane escribió: > Alvaro Herrera <[EMAIL PROTECTED]> writes: > > I came up with the attached patch. > > I wasn't envisioning anything anywhere near this invasive. We only > need locations on constants in a few contexts, I think. Aha. OK, I'll commit the or

Re: [PATCHES] [HACKERS] Proposed patch - psql wraps at window width

ooking at the psql code \pset only > wants two arguments. I think that could be fixed easily by having the syntax be something like \pset format aligned:80 \pset format aligned:autowrap etc. -- Alvaro Herrerahttp://www.CommandPrompt.com/ PostgreSQL

Re: [PATCHES] pg_postmaster_reload_time() patch

atch close enough to tell if it would work on both the EXEC_BACKEND case and the regular one. -- Alvaro Herrerahttp://www.CommandPrompt.com/ The PostgreSQL Company - Command Prompt, Inc. -- Sent via pgsql-patches mailing list (pgsql-patches@postgresql.org)

Re: [PATCHES] Documentation: ALTER ROLE - no password

Andreas 'ads' Scherbaum wrote: > > Hello, > > i've seen the question "how to remove a password" now several times in > the last weeks. Attached is a small patch which add a new example for > the "ALTER ROLE" documentation. Applied, thanks. -

Re: [PATCHES] [HACKERS] Proposed patch - psql wraps at window width

Gregory Stark wrote: > "Alvaro Herrera" <[EMAIL PROTECTED]> writes: > > I think that could be fixed easily by having the syntax be something > > like > > > > \pset format aligned:80 > > \pset format aligned:autowrap > > I suppose. It seems k

Re: [PATCHES] pg_postmaster_reload_time() patch

George Gensure escribió: > So if nobody's got any further objections, could this patch be applied? It's in the queue: http://wiki.postgresql.org/wiki/CommitFest:May -- Alvaro Herrerahttp://www.CommandPrompt.com/ The PostgreSQL Company - Comman

Re: [PATCHES] Exposing keywords to clients

ved > (372 rows) > > I wasn't sure about the best way to describe the categories - > obviously they need to be non-translatable (for client software to > interpret), but human readable is also nice. I'm happy to hear > alternate suggestions. Perhaps use a separate string

Re: [PATCHES] configure option for XLOG_BLCKSZ

more useful here. Kevin sent me the source file some time ago -- he didn't want to upload them to pgfoundry because he was missing a Makefile. I built one for him, but last time I looked he hadn't uploaded anything. -- Alvaro Herrerahttp://www.Comma

Re: [PATCHES] [NOVICE] encoding problems

rt counting every line from the start of the current column, it will align correctly regardless of the previous columns. -- Alvaro Herrerahttp://www.CommandPrompt.com/ PostgreSQL Replication, Consulting, Custom Development, 24x7 support -- Sent via pgsql-patches ma

Re: [PATCHES] [NOVICE] encoding problems

Bruce Momjian wrote: > Alvaro Herrera wrote: > > If you start counting every line from the start of the current column, > > it will align correctly regardless of the previous columns. > > At this stage you don't know the width of previous columns because you > don&#

Re: [PATCHES] [NOVICE] encoding problems

Bruce Momjian wrote: > Alvaro Herrera wrote: > > Surely psql computes the width of all cells before printing anything. > > It does, but if you have a value that has a tab, how do you know what > tab stop you are on because you don't know the final width of the > previou

Re: [PATCHES] Snapshot management, final

Tom Lane wrote: > I looked over this patch and I think it still needs work. Thanks for the thorough review. I'll be working on these problems soon. -- Alvaro Herrerahttp://www.CommandPrompt.com/ PostgreSQL Replication, Consulting, Custom Developme

Re: [PATCHES] printTable API (was: Show INHERIT in \du)

Brendan Jurd escribió: > On Thu, Apr 17, 2008 at 7:27 AM, Alvaro Herrera wrote: > > Thanks. I looked the patch over and did some minor changes. Modified > > version attached. > > Cool, I had a look through your changes and they all seemed fine to > me. In parti

Re: [PATCHES] [HACKERS] bug in numeric_power() function

^123.3. See this other subsection: http://en.wikipedia.org/wiki/Exponentiation#Powers_of_zero 0^123.3 is 0, not 1. -- Alvaro Herrerahttp://www.CommandPrompt.com/ PostgreSQL Replication, Consulting, Custom Development, 24x7 support -- Sent via pgsql-patches mailing li

Re: [PATCHES] [HACKERS] bug in numeric_power() function

Bruce Momjian wrote: > Ah, got it, and I updated the patch to remove the commment about > "discrete". The page also says that 0^x is undefined when x is negative, not sure about that one but I don't see it in your patch. -- Alvaro Herrera

Re: [PATCHES] [NOVICE] encoding problems

> No, we don't change behaviors in back branches unless we get lots of > complaints, and we haven't in this case. complaints++ -- Alvaro Herrerahttp://www.CommandPrompt.com/ The PostgreSQL Company - Command Prompt, Inc. -- Sent via pgsql-patches

Re: [PATCHES] Snapshot management, final

sed snap for PushActiveSnapshot. So this is all a bit confusing and wasteful and could use some clean up. This is material for a new patch however.) -- Alvaro Herrerahttp://www.CommandPrompt.com/ PostgreSQL Replication, Consulting, Custom Development, 24x7 support

Re: [PATCHES] Snapshot management, final

ar; close cur; commit; Thanks again for the review. -- Alvaro Herrerahttp://www.CommandPrompt.com/ PostgreSQL Replication, Consulting, Custom Development, 24x7 support -- Sent via pgsql-patches mailing list (pgsql-patches@postgresql.org) To make changes to yo

Re: [PATCHES] Snapshot management, final

Tom Lane wrote: > Alvaro Herrera <[EMAIL PROTECTED]> writes: > > Tom Lane wrote: > >> Shouldn't UnregisterSnapshot insist that s_level be equal to current > >> xact nest level? > > > It can't check that; consider > > > begin; >

Re: [PATCHES] Snapshot management, final

stating the problem. We can revisit this problem later if it's ever an issue. Many thanks for the extensive help. -- Alvaro Herrerahttp://www.CommandPrompt.com/ PostgreSQL Replication, Consulting, Custom Development, 24x7 support -- Sent via pgsql-patches mai

Re: [PATCHES] printTable API (was: Show INHERIT in \du)

hings like "?%c? \"%s.%s\"", which is what we use for tables of which we don't recognize the relkind. Thanks for the patch. -- Alvaro Herrerahttp://www.CommandPrompt.com/ The PostgreSQL Company - Command Prompt, Inc. -- Sent via pgs

Re: [PATCHES] libpq Win32 Mutex performance patch

Andrew Chernow wrote: > Tom Lane wrote: >> Silently not locking is surely >> not very safe. >> > > Here is the dump code version of the patch. If anyone wants the return > value idea, let me know. So is this a patch we want applied? -- Alvaro Herrera

Re: [PATCHES] libpq Win32 Mutex performance patch

Magnus Hagander wrote: > Alvaro Herrera wrote: > > Andrew Chernow wrote: > > > Tom Lane wrote: > > >> Silently not locking is surely > > >> not very safe. > > >> > > > > > > Here is the dump code version of the patch. If anyo

Re: [PATCHES] [GENERAL] Making sure \timing is on

igned is the default mode, \a should not toggle between last state and aligned, but rather between last state and unaligned. Which makes it a misnomer. Or maybe the thing to do is leave them damn well alone and just fix \timing. -- Alvaro Herrerahttp://www.Comman

Re: [PATCHES] libpq object hooks

m to be overkill, at least for now. (If hooking into libpq is truly successful we can always improve it later -- it's not an exported detail of the API after all.) -- Alvaro Herrerahttp://www.CommandPrompt.com/ The PostgreSQL Company - Command Prompt, In

Re: [PATCHES] Patch to change psql default banner v6

x27;help', not less. Making it just repeat the startup info is not very helpful. -- Alvaro Herrerahttp://www.CommandPrompt.com/ The PostgreSQL Company - Command Prompt, Inc. -- Sent via pgsql-patches mailing list (pgsql-patches@postgresql.org) T

Re: [PATCHES] Patch to change psql default banner v6

idea is not just to repeat, but also to provide useful advice to the unwary.) Remember, the people who is going to type 'help' is not the 10-year-Pg- experience types. It's the newbies. -- Alvaro Herrerahttp://www.CommandPrompt.com/ PostgreSQL Replicati

Re: [PATCHES] Patch to change psql default banner v6

he previous discussion: http://archives.postgresql.org/message-id/1200851790.19135.68.camel%40greg-laptop -- Alvaro Herrerahttp://www.CommandPrompt.com/ PostgreSQL Replication, Consulting, Custom Development, 24x7 support -- Sent via pgsql-patches mailing list (pgsql-patches@po

Re: [PATCHES] Patch to change psql default banner v6

person thinks it's "good enough". -- Alvaro Herrerahttp://www.CommandPrompt.com/ The PostgreSQL Company - Command Prompt, Inc. -- Sent via pgsql-patches mailing list (pgsql-patches@postgresql.org) To make changes to your subscription: http://www.postgres

Re: [PATCHES] Patch to change psql default banner v6

I'm OK with thisG but please move the printSSLInfo() call just before echoing the help line. -- Alvaro Herrerahttp://www.CommandPrompt.com/ The PostgreSQL Company - Command Prompt, Inc. -- Sent via pgsql-patches mailing list (pgsql-patches@postgresql.or

Re: [PATCHES] Patch to change psql default banner v6

l version could just say "this server version does not support this command". It would be already a huge improvement. Probably the biggest change would be to support versions that did not have schemas, but I think it would be OK to punt on that. We already sto

Re: [PATCHES] libpq object hooks

arted, so I think this is OK for this commitfest. (Besides, it seems we're almost there on this patch.) -- Alvaro Herrerahttp://www.CommandPrompt.com/ The PostgreSQL Company - Command Prompt, Inc. -- Sent via pgsql-patches mailing list (pgsql-patches@post

Re: [PATCHES] Patch for psql 8.0, 8.1 and 8.2 backwards compatibility

id you check it out? It's on the July commitfest page. -- Alvaro Herrerahttp://www.CommandPrompt.com/ The PostgreSQL Company - Command Prompt, Inc. -- Sent via pgsql-patches mailing list (pgsql-patches@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-patches

Re: [PATCHES] \d+ should display the storage options for columns

eworked this -- in particular the mbvalidate() call that's only on WIN32 is gone (actually it's the lack of it that's gone.) -- Alvaro Herrerahttp://www.CommandPrompt.com/ The PostgreSQL Company - Command Prompt, Inc. -- Sent via pgsql

Re: [PATCHES] \d+ should display the storage options for columns

Gregory Stark wrote: > "Alvaro Herrera" <[EMAIL PROTECTED]> writes: > > > This seems to be against an older version of psql ... with the > > printTable API stuff, we reworked this -- in particular the mbvalidate() > > call that's only on WIN32 is gone

Re: [PATCHES] Extending grant insert on tables to sequences

patch i attached is an older version that doesn't > compile because of a typo... > Re-attaching right patch and fix documentation to indicate the new > behaviour... Please add the patch to the commitfest page, http://wiki.postgresql.org/wiki/CommitFest:July -- Alvaro Her

Re: [PATCHES] partial header cleanup

is currently in bufpage.h). I am not sure what kind of fallout that causes. Maybe that would help you too. We need to come up with a good name for that file however ... bufmgrpage.h seems ugly. -- Alvaro Herrerahttp://www.CommandPrompt.com/ PostgreSQL Replication, Con

Re: [PATCHES] partial header cleanup

Zdenek Kotala wrote: > This replace xlog.h with xlogdefs.h in bufpage.h. Applied, thanks. -- Alvaro Herrerahttp://www.CommandPrompt.com/ The PostgreSQL Company - Command Prompt, Inc. -- Sent via pgsql-patches mailing list (pgsql-patches@postgresql.org)

Re: [PATCHES] [HACKERS] TRUNCATE TABLE with IDENTITY

s leave the patch there, revise the > warning per Neil's complaint, and add a TODO item to reimplement RESTART > IDENTITY transactionally. I think the TODO item did not make it, but the docs do seem updated. -- Alvaro Herrerahttp://www.CommandPrompt.c

Re: [PATCHES] GIN improvements

ly, autovac only uses pgstats as trigger for actions. Maybe we could use something else (say, a flag in shared memory?), or just stash the info that the index needs to be processed in pgstats and have autovac examine it. -- Alvaro Herrerahttp://www.CommandProm

Re: [PATCHES] GIN improvements

up. FWIW there's a typo in catalogs.sgml (finction -> function) What's the use of the FASTUPDATE parameter? Is there a case when a user is interested in turning it off? -- Alvaro Herrerahttp://www.CommandPrompt.com/ The PostgreSQL Company - Command Prom

Re: [PATCHES] SQL: table function support

Tom Lane escribió: > (It's also worth asking where the import is coming from. Who implements > the spec syntax anyway? DB2 maybe, but when was the last time we heard > from anyone trying to migrate from DB2 to PG?) Sourceforge? -- Alvaro Herrera

Re: [PATCHES] Tentative patch for making DROP put dependency info in DETAIL

NOTICE: drop cascades to 0 other object(s) > DETAIL: > reported to the client (with the server log of course saying something > different). So I gave up and left that behavior separate. Huh, annoying. Agreed with leaving that alone. -- Alvaro Herrera

Re: [PATCHES] SQL: table function support

Tom Lane escribió: > Alvaro Herrera <[EMAIL PROTECTED]> writes: > > Tom Lane escribi�: > >> (It's also worth asking where the import is coming from. Who implements > >> the spec syntax anyway? DB2 maybe, but when was the last time we heard > >&g

Re: [PATCHES] Tentative patch for making DROP put dependency info in DETAIL

files that don't > currently include dependency.h. A possible response to that is to move > ObjectAddress into postgres.h, but that seems a bit ugly too. Ugh. I thought about having a new header, but that seems overkill. -- Alvaro Herrerahttp:

[PATCHES] relscan.h split

rc/include/access/relscan.h340 360 -20 So it doesn't have a tremendous impact, but it does have some. -- Alvaro Herrerahttp://www.CommandPrompt.com/ PostgreSQL Replication, Consulting, Cus

Re: [PATCHES] Tentative patch for making DROP put dependency info in DETAIL

ious Ill go ahead and make the > rest of the Remove things behave the same way I don't think there's anything wrong with that in principle. However, does your patch actually work? The changes in expected/ is unexpected, I think. -- Alvaro Herrera

Re: [PATCHES] Simplify formatting.c

o text, then to char, > then to text to call texttowcs(). I didn't see a cleaner way to do > this. Why not use wchar2char? It seems there's room for extra cleanup here. Also, the prototype of str_initcap in builtins.h looks out of place. -- Alvaro Herrera

Re: [PATCHES] relscan.h split

of a scan. There are a few occurrences of this: /* must hold a buffer lock to call HeapTupleSatisfiesUpdate */ LockBuffer(scan->rs_cbuf, BUFFER_LOCK_SHARE); which of course need the definition. Maybe providing it is not a bad idea, because that kind of coding is used in the bac

Re: [PATCHES] [HACKERS] Hint Bits and Write I/O

the APIs as they are and have a global that's set by VACUUM only (and reset in a PG_CATCH block). -- Alvaro Herrerahttp://www.CommandPrompt.com/ PostgreSQL Replication, Consulting, Custom Development, 24x7 support -- Sent via pgsql-patches mailing list

Re: [PATCHES] Fix pg_ctl restart bug

ere is always the risk of a new bug being > introduced, so I am unsure. Why do we need someone to complain? We know the bug is there. Has the code changed a lot in that area? -- Alvaro Herrerahttp://www.CommandPrompt.com/ PostgreSQL Replication, Consulting

Re: [PATCHES] Fix pg_ctl restart bug

Bruce Momjian wrote: > Alvaro Herrera wrote: > > Why do we need someone to complain? We know the bug is there. Has the > > code changed a lot in that area? > > Do we have the policy of backpatching every fix? I thought it was only > the major bugs we fixed in back bra

Re: [PATCHES] Relation forks & FSM rewrite patches

but not lower, than the actual free space) be updated later, when someone tries to use it and finds that it's not correct. -- Alvaro Herrerahttp://www.CommandPrompt.com/ The PostgreSQL Company - Command Prompt, Inc. -- Sent via pgsql-patches mailing l

Re: [PATCHES] GIN improvements

e're storing attribute numbers too, right? Would it be too difficult to strip them out in that case? -- Alvaro Herrerahttp://www.CommandPrompt.com/ The PostgreSQL Company - Command Prompt, Inc. -- Sent via pgsql-patches mailing list (pgsql-patches@postgresql.org) T

Re: [PATCHES] GIN improvements

intuple_get_attrnum about actual storage. > > Single column index is binary compatible with current index :) Ah, neat! -- Alvaro Herrerahttp://www.CommandPrompt.com/ PostgreSQL Replication, Consulting, Custom Development, 24x7 support -- Sent via pgs

Re: [PATCHES] Extending grant insert on tables to sequences

} Wouldn't it be clearer to build a list with all the sequences owned by the tables in istmt.objects, and then call ExecGrantStmt_oids() a single time with the big list? -- Alvaro Herrerahttp://www.CommandPrompt.com/ PostgreSQL Replication, Consulti

Re: [PATCHES] [HACKERS] WITH RECURSIVE updated to CVS TIP

f the upstream guys are apparently not using it ... -- Alvaro Herrerahttp://www.CommandPrompt.com/ The PostgreSQL Company - Command Prompt, Inc. -- Sent via pgsql-patches mailing list (pgsql-patches@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-patches

Re: [PATCHES] \d+ should display the storage options for columns

ld we mark those for translation too? I admit I am not sure, if only because the untranslated strings are what gets passed to ALTER TABLE ... SET STORAGE. But if that's the decision, then it oughtta be commented in the code ... -- Alvaro Herrerahttp://ww

Re: [PATCHES] Is autovacuum doing a wraparound-avoiding VACUUM?

uot;, vac tab->at_doanalyze ? " ANALYZE" : "", tab->at_wraparound ? " (wraparound)" : ""); You're not proposing it for 8.3 right? -- Alvaro Herrerahttp://www.CommandPrompt.com/ PostgreSQL

Re: [PATCHES] Is autovacuum doing a wraparound-avoiding VACUUM?

s. > > Patches for 8.3 and CVS HEAD. Applied, thanks. -- Alvaro Herrerahttp://www.CommandPrompt.com/ The PostgreSQL Company - Command Prompt, Inc. -- Sent via pgsql-patches mailing list (pgsql-patches@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-patches

<    3   4   5   6   7   8   9   >