What is the weight of each violation types?
Hi As title, how can I know the weight of the Major, minor, critical and blocker violations? BR/Vincent -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Cancle:What is the weight of each violation types?
Hi I sent the email to the wrong group, please ignore it BR/Vincent -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: attempting to install RBTools on linux
Hi,
I tried your command on my machine and it had no such problem.
Notice that easy_install -U is updating your RBTools(Not First Time
Install ), That means you should had a former version of RBTools
installed before. Check your easy_install.pth file and make sure your
former RBTools version and path was configed there. Hope to be of
help.
Best Regards!
On 8月19日, 上午4时38分, tag_98007work tag98007w...@gmail.com wrote:
easy_install -fhttp://downloads.reviewboard.org/releases/Djblets/0.6/-U
Djblets
This worked just fine.
easy_install -fhttp://downloads.reviewboard.org/releases/RBTools/0.2/
-U RBTools
gets me:
Searching for RBTools
Readinghttp://downloads.reviewboard.org/releases/RBTools/0.2/
Readinghttp://pypi.python.org/simple/RBTools/
No local packages or download links found for RBTools
error: Could not find suitable distribution for
Requirement.parse('RBTools')
So where am I running amuck?
Thanks
On Aug 18, 12:28 pm, Christian Hammond chip...@chipx86.com wrote:
If you don't, then that's fine. It's possible to put values in there that
could trigger the sort of problem you're hitting.
In that case, I don't really know what to say. It works fine elsewhere,
which indicates it's something odd in your computer or network's setup. I
assume this has continued to be a problem since your first post.
If this continues to fail, you can try:
easy_install -fhttp://downloads.reviewboard.org/releases/Djblets/0.6/-U
Djblets
If *that* fails, your setuptools is definitely busted.
Christian
--
Christian Hammond - chip...@chipx86.com
Review Board -http://www.reviewboard.org
VMware, Inc. -http://www.vmware.com
On Wed, Aug 18, 2010 at 9:38 AM, tag_98007work
tag98007w...@gmail.comwrote:
No I don't. Did i miss that in the documentation? What suppose to be
in the file?
thanks
On Aug 16, 1:30 pm, Christian Hammond chip...@chipx86.com wrote:
Hi,
That's strange. I just tried it and it's working fine. Do you have a
~/.pydistutils.cfg file set?
Christian
--
Christian Hammond - chip...@chipx86.com
Review Board -http://www.reviewboard.org
VMware, Inc. -http://www.vmware.com
On Mon, Aug 16, 2010 at 1:12 PM, tag_98007work tag98007w...@gmail.com
wrote:
I'm following the instructions: easy_install -U RBTools and I'm
getting the error message:
Searching for RBTools
Readinghttp://pypi.python.org/simple/RBTools/
No local packages or download links found for RBTools
error: Could not find suitable distribution for
Requirement.parse('RBTools')
Any ideas?
Debian version 5.0.3
Python 2.5
SetupTools - 0.6c8-4
ReviewBoard - 1.5 RC 1
Thanks
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know athttp://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegroups.com
reviewboard%2bunsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en-Hidequoted text -
- Show quoted text -
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know athttp://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en-Hide quoted text -
- Show quoted text -- 隐藏被引用文字 -
- 显示引用的文字 -
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
Re: Facing problem installing in Windows!
Hi Sakthi, Even i had got the same page of manual updates and i followed each step on the link given under that, but got the same page again. Finally i restarted my PC and it worked fine. Regards, Shambhu. On Aug 20, 4:44 am, Timothy Pinet tim.pi...@gmail.com wrote: I installed 1.0.9 on Windows XP a couple of weeks ago successfully. I usedhttp://www.reviewboard.org/docs/manual/1.0/admin/installation/windows/and got it to work first attempt. Try installing using these instructions. Tim -Original Message- From: reviewboard@googlegroups.com [mailto:reviewbo...@googlegroups.com] On Behalf Of Chris Clark Sent: August-19-10 7:27 PM To: reviewboard@googlegroups.com Subject: Re: Facing problem installing in Windows! sakthi v wrote: I followed the following link to install ReviewBoard in Windows http://yuanyi-wang.blogspot.com/2009/03/install-review-board-on-windo... I tried installed twice.. and from blank page .. i got stuck in page showing Manual Server Updates Required I tried re-installation PIL 1.1.7, even Patch.exe. i can execute patch.exe from Cmd window. Can some one give me some pointer to resolve this.. It is urgent. If this genuinely is urgent (i.e. must fix, don't care how) the best advice I have is to set up a Ubuntu box (perhaps a virtual one in VMware) and install it there. The apache setup under Linux is pretty automatic and so much easier to deploy, no messing around with patch, etc. There are a few Windows users so hopefully you'll get some more windows focused advice if you are stuck with Windows. Chris -- Want to help the Review Board project? Donate today athttp://www.reviewboard.org/donate/ Happy user? Let us know athttp://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group athttp://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
RE: Facing problem installing in Windows!
That is good to hear! When in doubt on Windows, reboot :) Tim -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Triggers
I modified the base code for reviewboard. Its one small change in the webapi code to trigger a generate_summary call when the close-submitted action is done. Then a new file which contains the generate_summary code and its appropriate template. The email code was used as the inspiration, and subtle modifications were made to suit the layout I thought best for the summary. This file is then written to the local disk and I have separate automation which pushes it into our bugtracking system. Scott On Fri, Aug 20, 2010 at 12:48 AM, J Arrizza cppge...@gmail.com wrote: Scott, Sorry for taking so long to back to you, got tied up on other stuff. Very nice. You modified the base code in some spot or is the review summary generation already a part of RB 1.07? John On Wed, Aug 18, 2010 at 2:22 PM, Scott Quesnelle scott.quesne...@gmail.com wrote: John, I have an implementation in my deployment which generates a review summary when the review is closed, and it writes the summary to a file that is named based on the bugid(s) provided. A separate script runs and talks to the bug tracking system and updates the appropriate bug(s) with the review summary in a standardized enclosure. This is currently running on RB 1.0. Scott -- John blog: http://arrizza.blogspot.com/ web: http://www.arrizza.com/ -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: post-review error with svn and gnu diffutils (new review with an added binary file)
In which file does reviewboard invoke the svn diff --diff-cmd=diff command? I have been looking but can not find it. I then thought that you probably call the pysvn lib for this. I checked the pysvn documentation (http://pysvn.tigris.org/docs/ pysvn_prog_ref.html#pysvn_client_diff) and there is a flag ignore_content_type for the pysvn.Client.diff command. I assume that reviewboard calls this method. Is there a way I can manually include this flag? Are there any other suggestions on how I can tell subversion, gnu diff, or pysvn to ignore the content type so binary files do not block reviews? Thanks for all of your help! I really want to get this operating to show my organization how awesome this tool is. In my opinion it beats out SmartBear CodeCollaborator and Atlassian Crucible suites. Thanks, Tim -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Files in Patch not the same as files in view diff
View diff shows:
Revision 1 New Change # this file is really /config/host_tools/
Config.mak not sysfiles/etc/passwd
1 # WG_CPU is toolchain prefix
2 WG_CPU = x86
3 WG_ARCH = x86
4 WG_ENDIAN = little
5
6 KERNEL_ARCH = i386
7 KERNEL_SFX = ko
8 KERNEL_VPATH = true
9
10 export WG_ARCH
11 export WG_CPU
12 export WG_ENDIAN
13 export KERNEL_ARCH
14 export KERNEL_SFX
15 export KERNEL_VPATH
//user/reviewboard/components/wg_linux/mainline/sysfiles/finley/etc/
fstab
Revision 1 New Change # this file is really /config/host_tools/
debug_platform.pkgspec and not sysfiles/finley/etc/fstab
1 return
2 Entry { dst = DRVPATH .. oprofile. .. ext,
3 src = $LINUX_BASE/modules/arch/$KERNEL_ARCH/
oprofile/oprofile. .. ext }
4
-
--- //user/reviewboard/components/wg_linux/mainline/sysfiles/etc/
passwd //user/reviewboard/components/wg_linux/mainline/sysfiles/etc/
passwd#1
+++ //user/reviewboard/components/wg_linux/mainline/sysfiles/etc/
passwd 2010-08-19 10:14:30
@@ -1,3 +1,5 @@
+#add a line
+#
root:!$1$jw92fqyv$NVy9MLVQEPDvXiOXQC4jp.:0:0:Administrator:/root:/bin/
ash
bin:x:1:1:bin:/bin:
system:x:2:96:WG System daemons:/:
--- //user/reviewboard/components/wg_linux/mainline/sysfiles/finley/
etc/fstab //user/reviewboard/components/wg_linux/mainline/sysfiles/
finley/etc/fstab#1
+++ //user/reviewboard/components/wg_linux/mainline/sysfiles/finley/
etc/fstab 2010-08-19 10:14:30
@@ -1,3 +1,6 @@
+#new line
+#and another
+
/dev/wgrd.sysa_code/ ext2
ro 1 1
none /proc proc
defaults0 0
none /syssysfs
defaults0 0
--
Logging shows:
2010-08-20 08:43:41,623 - DEBUG - Generating diff viewer page for
filediff id 9
2010-08-20 08:43:41,641 - DEBUG - Begin: Generating diff file info for
diffset id 9
2010-08-20 08:43:41,644 - DEBUG - End: Generating diff file info for
diffset id 9
2010-08-20 08:43:41,644 - DEBUG - Generating diff file info for
diffset id 9 took 0.2773 seconds
2010-08-20 08:43:41,649 - DEBUG - Begin: Generating diff file info for
diffset id 9, filediff 14
2010-08-20 08:43:41,651 - DEBUG - End: Generating diff file info for
diffset id 9, filediff 14
2010-08-20 08:43:41,651 - DEBUG - Generating diff file info for
diffset id 9, filediff 14 took 0.2185 seconds
2010-08-20 08:43:42,013 - DEBUG - Done generating diff viewer page for
filediff id 9
2010-08-20 08:43:42,582 - DEBUG - Begin: Generating diff file info for
diffset id 9, filediff 15
2010-08-20 08:43:42,584 - DEBUG - End: Generating diff file info for
diffset id 9, filediff 15
2010-08-20 08:43:42,584 - DEBUG - Generating diff file info for
diffset id 9, filediff 15 took 0.1751 seconds
--
Any help in sorting this out would be appreciated. We are attempting
this against Perforce.
Thanks
On Aug 19, 5:04 pm, Christian Hammond chip...@chipx86.com wrote:
I don't see any files attached.
Which files were shown in the diff viewer?
Christian
--
Christian Hammond - chip...@chipx86.com
Review Board -http://www.reviewboard.org
VMware, Inc. -http://www.vmware.com
On Wed, Aug 18, 2010 at 2:35 PM, tag_98007work tag98007w...@gmail.comwrote:
I uploaded a changelist with 2 files in it: Code Review Checklist.txt,
place_holder
When I view the diff throught the View Diff button the files displayed
are not the files from the changelist. The diff in the download diff
is correct.
I uploaded the files: cl285668_viewdiff.txt so you can see what's
visiable on the view diff button.
cl285668bug.path is what's visable on the
download diff. This one is correct.
I'm running RB 1.5 RC1 on a Linux server
Mysql on Linux
RBTools 0.2 on Windows
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know athttp://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en- Hide quoted text -
- Show quoted text -
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
Revision selector
The revision selector has always been a bit confusing to me (and new RB users in my company) and inconvenient. It's not exactly clear what diff you're looking at, cumulative or incremental (interdiff). And it may take an extra click to get an interdiff, for example you have 3 revisions and you're looking at diff 1-2. If you want to look at 2-3, you have to click 3 in the first row first, then click 2 in the second row. If you just click 3 in the second row you'll get 1-3. I'd like to propose a different representation (too bad I can't attach screenshot or use HTML here): The default view is last revision: Cumulative diff between baseline and revision 3 (latest) Compare revision 3 to _(baseline) Compare revision 2 to baseline 3 Compare revision 1 to baseline 2 3 _(...) means bold and unclickable, just like in the current revision selector. And interdiff looks like this: Incremental diff between revision 2 and 3 Compare revision 3 to baseline Compare revision 2 to baseline _(3) Compare revision 1 to baseline 2 3 It takes n lines for n revisions, but I think it's much clearer and it always takes only one click to get any pair of diff. And the pyramid looks nice. I have working code but it's too ugly to show, since I'm total newbie to django template. I had to copy-n-paste code for marking current diff, because for interdiff only the current item in the line where revision is either diffset.revision or interdiffset.revision should be bold. -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Revision selector
Screenshot is uploaded as rb.png http://reviewboard.googlegroups.com/web/rb.png?gsc=iBqKOxYAAABgpEsrTenpw2OJ9ZY_yaTfM9KWFkvR1kwtm4g5T1-szg -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: post-review error with svn and gnu diffutils (new review with an added binary file)
Timothy Pinet wrote: In which file does reviewboard invoke the svn diff --diff-cmd=diff command? I have been looking but can not find it. I then thought that you probably call the pysvn lib for this. I checked the pysvn documentation (http://pysvn.tigris.org/docs/ pysvn_prog_ref.html#pysvn_client_diff) and there is a flag ignore_content_type for the pysvn.Client.diff command. I assume that reviewboard calls this method. It actually isn't in ReviewBoard, it is in postreview.py :-) Jut fork postreview locally and you can then customize it for your environment. This is very common, I've done it for my team as we needed a bunch of customizations which really aren't appropriate for anyone else. Chris -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Tabbed diff viewer
Geoffrey, could you do a mockup of what you intend? Just to get the idea. I don't quite grasp it. Also, how would your proposed design scale to a very large review? Say one consisting of 50+ files. ReviewBoard do sorts headers and implementation files for C/Objective C/C++ so that the header is right before the implementation, but during pagination it doesn't take that into account (that I know of, but I might be wrong). It's an interesting idea, either way :) Cheers, Eduardo Felipe. On Fri, Aug 20, 2010 at 1:56 PM, Geoffrey Zheng geoffreyzh...@yahoo.com wrote: The current diff viewer does not scale at all for a large review with lots of changes in lots of files. Maybe I'm just spoiled by the incredibly fast and super convenient Beyond Compare. kdiff3 is also great. I know I'm asking too much for a web app to work like a native diff tool. But it could work much better by using tabs. You would put the current file list (which is great) on the left, and a tabbed pane on the right. Each tab contains one file. There are at least 2 immediate and immense improvements: 1. The diff page height only grows at one extra line per file. Now the page could be so long that I can't even see the scrollbar thumb. 2. You can jump back and forth in the files you're interested. This is really the killer especially for reviewing c/c++ code with changes in both .c and .h. Is there any tabbed pane widget available in RB's current setup? I could try it if this isn't totally crazy. -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: post-review error with svn and gnu diffutils (new review with an added binary file)
I wanted to check post-review however since I am on Windows my Python26\Scripts\post-review.exe is a compiled executable and not a python file. Would it be enough to grab the post-review.py from the repo and delete the exe? Thanks, Tim On Aug 20, 12:54 pm, Chris Clark chris.cl...@ingres.com wrote: It actually isn't in ReviewBoard, it is in postreview.py :-) Jut fork postreview locally and you can then customize it for your environment. This is very common, I've done it for my team as we needed a bunch of customizations which really aren't appropriate for anyone else. Chris -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Revision selector
Geoffrey, It was part of my Summer of Code to implement a similar (in concept at least) interface, and I ran into a question about how to do this properly, and I think a range selector is the best possible solution, but they are hard to implement, even when using jQuery UI's range selector, so I'm working on that. Note that currently RB does not show a cumulative patch, only a version and a difference between versions. It will show cumulative patches, as that was part of SoC as well, but the feature is for inclusion in a future version of ReviewBoard. But no matter how newbie you are, I would really encourage you to post your code to http://reviews.reviewboard.org, so I can check it out and discuss this further. Cheers, Eduardo Felipe. On Fri, Aug 20, 2010 at 1:24 PM, Geoffrey Zheng geoffreyzh...@yahoo.com wrote: Screenshot is uploaded as rb.png http://reviewboard.googlegroups.com/web/rb.png?gsc=iBqKOxYAAABgpEsrTenpw2OJ9ZY_yaTfM9KWFkvR1kwtm4g5T1-szg -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Tabbed diff viewer
Eduardo could you do a mockup of what you intend? I'm not sure a full mockup is necessary. Suppose you post a review with changes to five files. The left-hand sidebar would be file1 file2 file3 file4 file5 while the main pane would consist of five tabs, one for each file (file2 is the active tab in my bad ASCII art): /file1\ /file2\ /file3\ /file4\ /file5\ --- --- line 1 | line 1 line 2 | line 2 ...| ... Each tab would display just the diff for a single file. Clicking a tab or the file name in the sidebar would bring that file's diff to the front. At least that's how I understood the OP's proposal. Eduardo Also, how would your proposed design scale to a very large Eduardo review? Say one consisting of 50+ files. I suspect at that size your tabs would have to cascade into multiple rows: /file1\ /file2\ /file3\ /file4\ /file5\ --- /file6\ /file7\ /file8\ /file9\ /file10\ --- etc but I view that as just a complication of the JavaScript necessary to work this wizardry. -- Skip Montanaro - s...@pobox.com - http://www.smontanaro.net/ -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Revision selector
When we first implemented this, we knew it was ugly, and had considered it a sort of temporary stop-gap. But then Review Board got popular and people had more pressing concerns, bug and feature-wise. So we never quite got around to it. What I've considered is a widget that shows all revisions and lets you select a range between them. For example: 1 2 3 4 5 |---o=o| The idea being that you could drag each handle to the revision you care about, and then hit a button. There's a jQuery widget for doing just this that I found recently. While I don't really have time scheduled in 1.6 for this, maybe I or someone else can play around with it and replace what we have today. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Fri, Aug 20, 2010 at 10:36 AM, Eduardo Felipe eduardofelip...@gmail.comwrote: Geoffrey, It was part of my Summer of Code to implement a similar (in concept at least) interface, and I ran into a question about how to do this properly, and I think a range selector is the best possible solution, but they are hard to implement, even when using jQuery UI's range selector, so I'm working on that. Note that currently RB does not show a cumulative patch, only a version and a difference between versions. It will show cumulative patches, as that was part of SoC as well, but the feature is for inclusion in a future version of ReviewBoard. But no matter how newbie you are, I would really encourage you to post your code to http://reviews.reviewboard.org, so I can check it out and discuss this further. Cheers, Eduardo Felipe. On Fri, Aug 20, 2010 at 1:24 PM, Geoffrey Zheng geoffreyzh...@yahoo.com wrote: Screenshot is uploaded as rb.png http://reviewboard.googlegroups.com/web/rb.png?gsc=iBqKOxYAAABgpEsrTenpw2OJ9ZY_yaTfM9KWFkvR1kwtm4g5T1-szg -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Files in Patch not the same as files in view diff
Oh, so your diff is uploading passwd but you're seeing Config.mak.
It's possible that you have some odd caching problem. If you're using
memcached, try restarting it to clear the cache. If it's a file-based cache,
delete all the files in the cache. Then re-view the diff.
Christian
--
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.com
On Fri, Aug 20, 2010 at 8:51 AM, tag_98007work tag98007w...@gmail.comwrote:
View diff shows:
Revision 1 New Change # this file is really /config/host_tools/
Config.mak not sysfiles/etc/passwd
1 # WG_CPU is toolchain prefix
2 WG_CPU = x86
3 WG_ARCH = x86
4 WG_ENDIAN = little
5
6 KERNEL_ARCH = i386
7 KERNEL_SFX = ko
8 KERNEL_VPATH = true
9
10 export WG_ARCH
11 export WG_CPU
12 export WG_ENDIAN
13 export KERNEL_ARCH
14 export KERNEL_SFX
15 export KERNEL_VPATH
//user/reviewboard/components/wg_linux/mainline/sysfiles/finley/etc/
fstab
Revision 1 New Change # this file is really /config/host_tools/
debug_platform.pkgspec and not sysfiles/finley/etc/fstab
1 return
2 Entry { dst = DRVPATH .. oprofile. .. ext,
3 src = $LINUX_BASE/modules/arch/$KERNEL_ARCH/
oprofile/oprofile. .. ext }
4
-
--- //user/reviewboard/components/wg_linux/mainline/sysfiles/etc/
passwd //user/reviewboard/components/wg_linux/mainline/sysfiles/etc/
passwd#1
+++ //user/reviewboard/components/wg_linux/mainline/sysfiles/etc/
passwd 2010-08-19 10:14:30
@@ -1,3 +1,5 @@
+#add a line
+#
root:!$1$jw92fqyv$NVy9MLVQEPDvXiOXQC4jp.:0:0:Administrator:/root:/bin/
ash
bin:x:1:1:bin:/bin:
system:x:2:96:WG System daemons:/:
--- //user/reviewboard/components/wg_linux/mainline/sysfiles/finley/
etc/fstab //user/reviewboard/components/wg_linux/mainline/sysfiles/
finley/etc/fstab#1
+++ //user/reviewboard/components/wg_linux/mainline/sysfiles/finley/
etc/fstab 2010-08-19 10:14:30
@@ -1,3 +1,6 @@
+#new line
+#and another
+
/dev/wgrd.sysa_code/ ext2
ro 1 1
none /proc proc
defaults0 0
none /syssysfs
defaults0 0
--
Logging shows:
2010-08-20 08:43:41,623 - DEBUG - Generating diff viewer page for
filediff id 9
2010-08-20 08:43:41,641 - DEBUG - Begin: Generating diff file info for
diffset id 9
2010-08-20 08:43:41,644 - DEBUG - End: Generating diff file info for
diffset id 9
2010-08-20 08:43:41,644 - DEBUG - Generating diff file info for
diffset id 9 took 0.2773 seconds
2010-08-20 08:43:41,649 - DEBUG - Begin: Generating diff file info for
diffset id 9, filediff 14
2010-08-20 08:43:41,651 - DEBUG - End: Generating diff file info for
diffset id 9, filediff 14
2010-08-20 08:43:41,651 - DEBUG - Generating diff file info for
diffset id 9, filediff 14 took 0.2185 seconds
2010-08-20 08:43:42,013 - DEBUG - Done generating diff viewer page for
filediff id 9
2010-08-20 08:43:42,582 - DEBUG - Begin: Generating diff file info for
diffset id 9, filediff 15
2010-08-20 08:43:42,584 - DEBUG - End: Generating diff file info for
diffset id 9, filediff 15
2010-08-20 08:43:42,584 - DEBUG - Generating diff file info for
diffset id 9, filediff 15 took 0.1751 seconds
--
Any help in sorting this out would be appreciated. We are attempting
this against Perforce.
Thanks
On Aug 19, 5:04 pm, Christian Hammond chip...@chipx86.com wrote:
I don't see any files attached.
Which files were shown in the diff viewer?
Christian
--
Christian Hammond - chip...@chipx86.com
Review Board -http://www.reviewboard.org
VMware, Inc. -http://www.vmware.com
On Wed, Aug 18, 2010 at 2:35 PM, tag_98007work tag98007w...@gmail.com
wrote:
I uploaded a changelist with 2 files in it: Code Review Checklist.txt,
place_holder
When I view the diff throught the View Diff button the files displayed
are not the files from the changelist. The diff in the download diff
is correct.
I uploaded the files: cl285668_viewdiff.txt so you can see what's
visiable on the view diff button.
cl285668bug.path is what's visable on the
download diff. This one is correct.
I'm running RB 1.5 RC1 on a Linux server
Mysql on Linux
RBTools 0.2 on Windows
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know athttp://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegroups.com
reviewboard%2bunsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en- Hide quoted text -
- Show quoted text -
--
Want to help the Review Board
Re: Tabbed diff viewer
Skip did a perfect job sketching it. Thanks! If you haven't used/seen Beyond Compare, please do yourself favor and head to http://www.scootersoftware.com/moreinfo.php?zz=moreinfo_compare The problem with too many tabs has been long solved by at least browsers. Just see how Firefox does it with a drop down list to the right. You do NOT want to use multiple rows of tabs like some earlier M $ apps. It's usability disaster. I'm not a web developer (I mainly do Java/Swing), but I'd be really surprised if none of the gazillion libraries/toolkits out there has a decent tabbed pane widget for web. -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Revision selector
Christian, That's precisely the jQuery UI's widget that I mentioned. I can refactor the one I'm writing for the stacked patches (aka bundle), and put that in the trunk in time for 1.6. I'll work on this. Cheers, Eduardo. On Fri, Aug 20, 2010 at 3:46 PM, Christian Hammond chip...@chipx86.com wrote: When we first implemented this, we knew it was ugly, and had considered it a sort of temporary stop-gap. But then Review Board got popular and people had more pressing concerns, bug and feature-wise. So we never quite got around to it. What I've considered is a widget that shows all revisions and lets you select a range between them. For example: 1 2 3 4 5 |---o=o| The idea being that you could drag each handle to the revision you care about, and then hit a button. There's a jQuery widget for doing just this that I found recently. While I don't really have time scheduled in 1.6 for this, maybe I or someone else can play around with it and replace what we have today. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Fri, Aug 20, 2010 at 10:36 AM, Eduardo Felipe eduardofelip...@gmail.com wrote: Geoffrey, It was part of my Summer of Code to implement a similar (in concept at least) interface, and I ran into a question about how to do this properly, and I think a range selector is the best possible solution, but they are hard to implement, even when using jQuery UI's range selector, so I'm working on that. Note that currently RB does not show a cumulative patch, only a version and a difference between versions. It will show cumulative patches, as that was part of SoC as well, but the feature is for inclusion in a future version of ReviewBoard. But no matter how newbie you are, I would really encourage you to post your code to http://reviews.reviewboard.org, so I can check it out and discuss this further. Cheers, Eduardo Felipe. On Fri, Aug 20, 2010 at 1:24 PM, Geoffrey Zheng geoffreyzh...@yahoo.com wrote: Screenshot is uploaded as rb.png http://reviewboard.googlegroups.com/web/rb.png?gsc=iBqKOxYAAABgpEsrTenpw2OJ9ZY_yaTfM9KWFkvR1kwtm4g5T1-szg -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Revision selector
The slider could work and look more fancy, but two drags would be infinitely slower than one click. I would only use it if I can click on the numbers and the slider snaps to them. Regarding cumulative patch, maybe we're talking about different things. RB has always done it perfectly. I had a discussion with Christian a couple of years ago (http://groups.google.com/group/ reviewboard/browse_thread/thread/4e30dcd77026b7a5/b6f4f65f39412925) where I asked the stupidest question about multiple diffs. Say I start with r0 and make some changes, commit, now I'm at r1. I upload diff r0-r1 to start a review. Reviewer say some lines are bs so I make more changes, and upload-- this is key--diff r0-r2, NOT r1-r2. Reviewer first looks at interdiff r1-r2 and sees that I got rid of the bs. Then s/he looks at r0-r2 as cumulative patch, which is what will be pulled (in DSCM term). On Aug 20, 2:46 pm, Christian Hammond chip...@chipx86.com wrote: When we first implemented this, we knew it was ugly, and had considered it a sort of temporary stop-gap. But then Review Board got popular and people had more pressing concerns, bug and feature-wise. So we never quite got around to it. What I've considered is a widget that shows all revisions and lets you select a range between them. For example: 1 2 3 4 5 |---o=o| The idea being that you could drag each handle to the revision you care about, and then hit a button. There's a jQuery widget for doing just this that I found recently. While I don't really have time scheduled in 1.6 for this, maybe I or someone else can play around with it and replace what we have today. Christian -- Christian Hammond - chip...@chipx86.com Review Board -http://www.reviewboard.org VMware, Inc. -http://www.vmware.com On Fri, Aug 20, 2010 at 10:36 AM, Eduardo Felipe eduardofelip...@gmail.comwrote: Geoffrey, It was part of my Summer of Code to implement a similar (in concept at least) interface, and I ran into a question about how to do this properly, and I think a range selector is the best possible solution, but they are hard to implement, even when using jQuery UI's range selector, so I'm working on that. Note that currently RB does not show a cumulative patch, only a version and a difference between versions. It will show cumulative patches, as that was part of SoC as well, but the feature is for inclusion in a future version of ReviewBoard. But no matter how newbie you are, I would really encourage you to post your code tohttp://reviews.reviewboard.org, so I can check it out and discuss this further. Cheers, Eduardo Felipe. On Fri, Aug 20, 2010 at 1:24 PM, Geoffrey Zheng geoffreyzh...@yahoo.com wrote: Screenshot is uploaded as rb.png http://reviewboard.googlegroups.com/web/rb.png?gsc=iBqKOxYAAABgpEsrTe... -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know athttp://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know athttp://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: post-review error with svn and gnu diffutils (new review with an added binary file)
Timothy Pinet wrote:
I wanted to check post-review however since I am on Windows my
Python26\Scripts\post-review.exe is a compiled executable and not a
python file. Would it be enough to grab the post-review.py from the
repo and delete the exe?
Not with the current version. There are a few dependencies (not many),
e.g. a version module. So you should take the whole thing. You can of
course make an exe from it very easily. See end of mail for the custom
setup script I use.
Chris
Issue:
NOTE using Python 2.4, this results in an exe about 4Mb in size.
NOTE using Python 2.6, this results in an exe about 5.5Mb in size.
c:\python24\python ingres_setup.py py2exe
setup.py py2exe
Quick-N-Dirty create win32 binaries and zip file script.
Zero error checking.
TODO inject 'py2exe' into sys.argv?
import os
import glob
import shutil
from distutils.core import setup
import py2exe
# Clean temp Python/Jython files
delete_list=glob.glob('simplejson/*.pyc')+glob.glob('simplejson/*$py.class')
for x in delete_list:
os.remove(x)
try:
shutil.rmtree('dist')
except WindowsError, info:
# assume directory does not exist
pass
# disable optimization- we _may_ need docs strings, specifically copyright
setup(
options = {py2exe: {
#includes: [decimal],
optimize: 1, ## 1 and NOT 2 because I use
the __doc__ string as the usage string. 2 optimises out the doc strings
'bundle_files': 1,
## options to reduce size of final exe
#~ 'ascii': True, # Exclude encodings
'excludes':[
'_ssl', # Exclude _ssl
'pyreadline', #'difflib',
'doctest', #'locale',
#'optparse',
'pickle', #'calendar',# Exclude
standard library
#'re',
],
}},
zipfile = None, ## try and make a single exe, if do not want this
loose this and the 'bundle_files' option
console=['postreview.py']
)
zipfilename='distribute_me.zip'
zipfilelist=['ingres_readme.txt', 'postreview.py', ] +
glob.glob('simplejson/*')+ glob.glob('dist/*')
import zipfile
z = zipfile.ZipFile(zipfilename, 'w')
for x in zipfilelist:
z.write(x)
z.close()
print 'Created:', zipfilename
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
Re: Revision selector
Of course now I realize I said almost exactly what Eduardo said. I meant to reply to Geoffrey's post directly, and hadn't read Eduardo's yet. Sorry Eduardo :) Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Fri, Aug 20, 2010 at 11:46 AM, Christian Hammond chip...@chipx86.comwrote: When we first implemented this, we knew it was ugly, and had considered it a sort of temporary stop-gap. But then Review Board got popular and people had more pressing concerns, bug and feature-wise. So we never quite got around to it. What I've considered is a widget that shows all revisions and lets you select a range between them. For example: 1 2 3 4 5 |---o=o| The idea being that you could drag each handle to the revision you care about, and then hit a button. There's a jQuery widget for doing just this that I found recently. While I don't really have time scheduled in 1.6 for this, maybe I or someone else can play around with it and replace what we have today. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Fri, Aug 20, 2010 at 10:36 AM, Eduardo Felipe eduardofelip...@gmail.com wrote: Geoffrey, It was part of my Summer of Code to implement a similar (in concept at least) interface, and I ran into a question about how to do this properly, and I think a range selector is the best possible solution, but they are hard to implement, even when using jQuery UI's range selector, so I'm working on that. Note that currently RB does not show a cumulative patch, only a version and a difference between versions. It will show cumulative patches, as that was part of SoC as well, but the feature is for inclusion in a future version of ReviewBoard. But no matter how newbie you are, I would really encourage you to post your code to http://reviews.reviewboard.org, so I can check it out and discuss this further. Cheers, Eduardo Felipe. On Fri, Aug 20, 2010 at 1:24 PM, Geoffrey Zheng geoffreyzh...@yahoo.com wrote: Screenshot is uploaded as rb.png http://reviewboard.googlegroups.com/web/rb.png?gsc=iBqKOxYAAABgpEsrTenpw2OJ9ZY_yaTfM9KWFkvR1kwtm4g5T1-szg -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: How to create svn diff for a new file
Your script did the job for me. This is exactly what I needed to do (I needed a full diff). Thanks a lot. -MS On Sun, Aug 15, 2010 at 6:26 AM, Vesterbaek vesterb...@gmail.com wrote: Correct me if I'm wrong, but your script is useful when you want to put existing committed code as a whole up for review, right? Such as when you're doing a post-commit review for the first time of some code? Yup, correct. Having re-read the original question, I agree that if you want to review new code that has just been added (but not committed), post-review does the job. My script is for generating a full review (diff with left side blank) of already checked in code. - Jeppe -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Files in Patch not the same as files in view diff
I restarted the memcache and that seems to have fixed the issues.
thanks
On Aug 20, 11:49 am, Christian Hammond chip...@chipx86.com wrote:
Oh, so your diff is uploading passwd but you're seeing Config.mak.
It's possible that you have some odd caching problem. If you're using
memcached, try restarting it to clear the cache. If it's a file-based cache,
delete all the files in the cache. Then re-view the diff.
Christian
--
Christian Hammond - chip...@chipx86.com
Review Board -http://www.reviewboard.org
VMware, Inc. -http://www.vmware.com
On Fri, Aug 20, 2010 at 8:51 AM, tag_98007work tag98007w...@gmail.comwrote:
View diff shows:
Revision 1 New Change # this file is really /config/host_tools/
Config.mak not sysfiles/etc/passwd
1 # WG_CPU is toolchain prefix
2 WG_CPU = x86
3 WG_ARCH = x86
4 WG_ENDIAN = little
5
6 KERNEL_ARCH = i386
7 KERNEL_SFX = ko
8 KERNEL_VPATH = true
9
10 export WG_ARCH
11 export WG_CPU
12 export WG_ENDIAN
13 export KERNEL_ARCH
14 export KERNEL_SFX
15 export KERNEL_VPATH
//user/reviewboard/components/wg_linux/mainline/sysfiles/finley/etc/
fstab
Revision 1 New Change # this file is really /config/host_tools/
debug_platform.pkgspec and not sysfiles/finley/etc/fstab
1 return
2 Entry { dst = DRVPATH .. oprofile. .. ext,
3 src = $LINUX_BASE/modules/arch/$KERNEL_ARCH/
oprofile/oprofile. .. ext }
4
-
--- //user/reviewboard/components/wg_linux/mainline/sysfiles/etc/
passwd //user/reviewboard/components/wg_linux/mainline/sysfiles/etc/
passwd#1
+++ //user/reviewboard/components/wg_linux/mainline/sysfiles/etc/
passwd 2010-08-19 10:14:30
@@ -1,3 +1,5 @@
+#add a line
+#
root:!$1$jw92fqyv$NVy9MLVQEPDvXiOXQC4jp.:0:0:Administrator:/root:/bin/
ash
bin:x:1:1:bin:/bin:
system:x:2:96:WG System daemons:/:
--- //user/reviewboard/components/wg_linux/mainline/sysfiles/finley/
etc/fstab //user/reviewboard/components/wg_linux/mainline/sysfiles/
finley/etc/fstab#1
+++ //user/reviewboard/components/wg_linux/mainline/sysfiles/finley/
etc/fstab 2010-08-19 10:14:30
@@ -1,3 +1,6 @@
+#new line
+#and another
+
/dev/wgrd.sysa_code / ext2
ro 1 1
none /proc proc
defaults 0 0
none /sys sysfs
defaults 0 0
--
Logging shows:
2010-08-20 08:43:41,623 - DEBUG - Generating diff viewer page for
filediff id 9
2010-08-20 08:43:41,641 - DEBUG - Begin: Generating diff file info for
diffset id 9
2010-08-20 08:43:41,644 - DEBUG - End: Generating diff file info for
diffset id 9
2010-08-20 08:43:41,644 - DEBUG - Generating diff file info for
diffset id 9 took 0.2773 seconds
2010-08-20 08:43:41,649 - DEBUG - Begin: Generating diff file info for
diffset id 9, filediff 14
2010-08-20 08:43:41,651 - DEBUG - End: Generating diff file info for
diffset id 9, filediff 14
2010-08-20 08:43:41,651 - DEBUG - Generating diff file info for
diffset id 9, filediff 14 took 0.2185 seconds
2010-08-20 08:43:42,013 - DEBUG - Done generating diff viewer page for
filediff id 9
2010-08-20 08:43:42,582 - DEBUG - Begin: Generating diff file info for
diffset id 9, filediff 15
2010-08-20 08:43:42,584 - DEBUG - End: Generating diff file info for
diffset id 9, filediff 15
2010-08-20 08:43:42,584 - DEBUG - Generating diff file info for
diffset id 9, filediff 15 took 0.1751 seconds
--
Any help in sorting this out would be appreciated. We are attempting
this against Perforce.
Thanks
On Aug 19, 5:04 pm, Christian Hammond chip...@chipx86.com wrote:
I don't see any files attached.
Which files were shown in the diff viewer?
Christian
--
Christian Hammond - chip...@chipx86.com
Review Board -http://www.reviewboard.org
VMware, Inc. -http://www.vmware.com
On Wed, Aug 18, 2010 at 2:35 PM, tag_98007work tag98007w...@gmail.com
wrote:
I uploaded a changelist with 2 files in it: Code Review Checklist.txt,
place_holder
When I view the diff throught the View Diff button the files displayed
are not the files from the changelist. The diff in the download diff
is correct.
I uploaded the files: cl285668_viewdiff.txt so you can see what's
visiable on the view diff button.
cl285668bug.path is what's visable on the
download diff. This one is correct.
I'm running RB 1.5 RC1 on a Linux server
Mysql on Linux
RBTools 0.2 on Windows
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know athttp://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
Re: attempting to install RBTools on linux
Actually RBTools was never added to the easy-tools.pth. Weird. I
could have sworn I got it at one point. Wound up downloading an
unzipping the egg.
I'm hoping the easy_tools -U RBTools works for the other people who
are checking Reviewboard out for our company.
On Aug 20, 3:24 am, JohnHenry qhlonl...@163.com wrote:
Hi,
I tried your command on my machine and it had no such problem.
Notice that easy_install -U is updating your RBTools(Not First Time
Install ), That means you should had a former version of RBTools
installed before. Check your easy_install.pth file and make sure your
former RBTools version and path was configed there. Hope to be of
help.
Best Regards!
On 8月19日, 上午4时38分, tag_98007work tag98007w...@gmail.com wrote:
easy_install -fhttp://downloads.reviewboard.org/releases/Djblets/0.6/-U
Djblets
This worked just fine.
easy_install -fhttp://downloads.reviewboard.org/releases/RBTools/0.2/
-U RBTools
gets me:
Searching for RBTools
Readinghttp://downloads.reviewboard.org/releases/RBTools/0.2/
Readinghttp://pypi.python.org/simple/RBTools/
No local packages or download links found for RBTools
error: Could not find suitable distribution for
Requirement.parse('RBTools')
So where am I running amuck?
Thanks
On Aug 18, 12:28 pm, Christian Hammond chip...@chipx86.com wrote:
If you don't, then that's fine. It's possible to put values in there that
could trigger the sort of problem you're hitting.
In that case, I don't really know what to say. It works fine elsewhere,
which indicates it's something odd in your computer or network's setup. I
assume this has continued to be a problem since your first post.
If this continues to fail, you can try:
easy_install -fhttp://downloads.reviewboard.org/releases/Djblets/0.6/-U
Djblets
If *that* fails, your setuptools is definitely busted.
Christian
--
Christian Hammond - chip...@chipx86.com
Review Board -http://www.reviewboard.org
VMware, Inc. -http://www.vmware.com
On Wed, Aug 18, 2010 at 9:38 AM, tag_98007work
tag98007w...@gmail.comwrote:
No I don't. Did i miss that in the documentation? What suppose to be
in the file?
thanks
On Aug 16, 1:30 pm, Christian Hammond chip...@chipx86.com wrote:
Hi,
That's strange. I just tried it and it's working fine. Do you have a
~/.pydistutils.cfg file set?
Christian
--
Christian Hammond - chip...@chipx86.com
Review Board -http://www.reviewboard.org
VMware, Inc. -http://www.vmware.com
On Mon, Aug 16, 2010 at 1:12 PM, tag_98007work tag98007w...@gmail.com
wrote:
I'm following the instructions: easy_install -U RBTools and I'm
getting the error message:
Searching for RBTools
Readinghttp://pypi.python.org/simple/RBTools/
No local packages or download links found for RBTools
error: Could not find suitable distribution for
Requirement.parse('RBTools')
Any ideas?
Debian version 5.0.3
Python 2.5
SetupTools - 0.6c8-4
ReviewBoard - 1.5 RC 1
Thanks
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know athttp://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegr---oups.com
reviewboard%2bunsubscr...@googlegr-oups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en-Hidequotedtext -
- Show quoted text -
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know athttp://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegr---oups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en-Hidequoted text -
- Show quoted text -- 隐藏被引用文字 -
- 显示引用的文字 -- Hide quoted text -
- Show quoted text -
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
starting review #
Apologies if this has been covered before, google didn't seem to have an obvious answer. Is it possible to set a starting review # for a clean install? The issue is that we have a pre-1.0 installation that has been in use for awhile now. Instead of trying to figure out how to upgrade the database, I've just created a fresh new installation (of 1.5rc1) on a fresh new server and we are just going to consider the previous version effectively read-only. But, on the new server, I'd like to start the review number +1 higher than the old server so that we don't have conflicting numbers in svn commit messages. I see that reviews_review.id is auto_increment. I know that I can do: ALTER TABLE reviews_review AUTO_INCREMENT = 100;, but I also see a 'review_request_id' column. What is that used for? Do you see any other issues with this approach? thanks, jon -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: How to create svn diff for a new file
It is indeed possible to use post-review to generate an appropriate diff following the post-commit review model. RBTools version 0.2.0 contains a fix that makes it possible to generate the initial review by passing --revision-range 0:HEAD to post-review. If you're stuck with an older version of RBTools, the appropriate changes can be found at http://reviews.reviewboard.org/r/1429/. Cheers, Nathan Heijermans On Fri, Aug 20, 2010 at 4:39 PM, Manjit Singh manjit.ga...@gmail.comwrote: Your script did the job for me. This is exactly what I needed to do (I needed a full diff). Thanks a lot. -MS On Sun, Aug 15, 2010 at 6:26 AM, Vesterbaek vesterb...@gmail.com wrote: Correct me if I'm wrong, but your script is useful when you want to put existing committed code as a whole up for review, right? Such as when you're doing a post-commit review for the first time of some code? Yup, correct. Having re-read the original question, I agree that if you want to review new code that has just been added (but not committed), post-review does the job. My script is for generating a full review (diff with left side blank) of already checked in code. - Jeppe -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: starting review #
Hi Jon, Your plan to use ALTER TABLE should work. review_request_id just holds the current ID. That's what should be auto_increment. I think so long as you do that, you'll see the review request ID number you expect. By the way, what problems did you hit with upgrading? Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Fri, Aug 20, 2010 at 5:47 PM, jon latch...@gmail.com wrote: Apologies if this has been covered before, google didn't seem to have an obvious answer. Is it possible to set a starting review # for a clean install? The issue is that we have a pre-1.0 installation that has been in use for awhile now. Instead of trying to figure out how to upgrade the database, I've just created a fresh new installation (of 1.5rc1) on a fresh new server and we are just going to consider the previous version effectively read-only. But, on the new server, I'd like to start the review number +1 higher than the old server so that we don't have conflicting numbers in svn commit messages. I see that reviews_review.id is auto_increment. I know that I can do: ALTER TABLE reviews_review AUTO_INCREMENT = 100;, but I also see a 'review_request_id' column. What is that used for? Do you see any other issues with this approach? thanks, jon -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: starting review #
Hi Christian, Thanks for the fast response. I haven't tried upgrading things. I guess I could try that, but I got the impression from somewhere that it would be difficult to do so from the early version that we are currently running. If you think it is worth trying, then that is probably the ideal route. cheers, jon On Fri, Aug 20, 2010 at 8:16 PM, Christian Hammond chip...@chipx86.comwrote: Hi Jon, Your plan to use ALTER TABLE should work. review_request_id just holds the current ID. That's what should be auto_increment. I think so long as you do that, you'll see the review request ID number you expect. By the way, what problems did you hit with upgrading? Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Fri, Aug 20, 2010 at 5:47 PM, jon latch...@gmail.com wrote: Apologies if this has been covered before, google didn't seem to have an obvious answer. Is it possible to set a starting review # for a clean install? The issue is that we have a pre-1.0 installation that has been in use for awhile now. Instead of trying to figure out how to upgrade the database, I've just created a fresh new installation (of 1.5rc1) on a fresh new server and we are just going to consider the previous version effectively read-only. But, on the new server, I'd like to start the review number +1 higher than the old server so that we don't have conflicting numbers in svn commit messages. I see that reviews_review.id is auto_increment. I know that I can do: ALTER TABLE reviews_review AUTO_INCREMENT = 100;, but I also see a 'review_request_id' column. What is that used for? Do you see any other issues with this approach? thanks, jon -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Issue 1781 in reviewboard: Please add a group named vcpdp automation with email alias vcpdp-automat...@mailman2.vmware.com
Status: New Owner: Labels: Type-Enhancement Priority-Medium New issue 1781 by sherry.zhou: Please add a group named vcpdp automation with email alias vcpdp-automat...@mailman2.vmware.com http://code.google.com/p/reviewboard/issues/detail?id=1781 Please add a group named vcpdp automation with email alias vcpdp-automat...@mailman2.vmware.com Please contact either Max or me for detail information. Thanks. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1781 in reviewboard: Please add a group named vcpdp automation with email alias vcpdp-automat...@mailman2.vmware.com
Updates: Status: NotABug Comment #2 on issue 1781 by chipx86: Please add a group named vcpdp automation with email alias vcpdp-automat...@mailman2.vmware.com http://code.google.com/p/reviewboard/issues/detail?id=1781 Review Board is an open source project. VMware just uses it. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
