On Feb. 21, 2016, 7 p.m., Joerg Schad wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43819/
> ----
)
<https://reviews.apache.org/r/43838/#comment184195>
Definitely ought to cover the python interface too. See
`src/python/interface/src/mesos/interface/__init__.py:177: def
requestResources(self, requests):`
- Adam B
On Feb. 22, 2016, 8:54 a.m., Joerg Schad
E_HEADER_EQ(APPLICATION_JSON,
"Content-Type", masterState);`?
Or is the `ASSERT_SOME(parse)` good enough to indicate that we received
json?
- Adam B
On March 2, 2016, 12:53 p.m., Joerg Schad wrote:
>
> ---
> This is an automatica
-
On Jan. 20, 2016, 12:36 a.m., Yongqiao Wang wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41672/
> ---
> On Feb. 27, 2016, 4:21 a.m., Adam B wrote:
> > Sorry this took me forever to get to. Looks pretty good except for some
> > indentation and some unnecessary lines.
> > I'd also like to see a couple of registrar tests, like AlexR suggested.
>
> Yongqiao Wang
/slave_tests.cpp (line 1161)
<https://reviews.apache.org/r/44063/#comment182787>
Why not verify the failureUpdate is TASK_FAILED?
- Adam B
On Feb. 26, 2016, 10:59 a.m., Benjamin Bannier wrote:
>
> ---
> This is an automatically gener
s
`updateWeights` won't call `allocate()` since no framework exists in 'role3'
yet, but `addFramework` will.
- Adam B
On Feb. 21, 2016, 11:23 p.m., Yongqiao Wang wrote:
>
>
s://reviews.apache.org/r/41681/#comment182775>
The list of roles whose weights can be updated.
- Adam B
On Feb. 14, 2016, 4:02 a.m., Yongqiao Wang wrote:
>
> ---
> This is an automatically generated e-mail. To reply, v
72>
s/negative/non-positive/ (since 0 is also invalid)
- Adam B
On Feb. 18, 2016, 11:56 p.m., Yongqiao Wang wrote:
>
> ---
> This is an automatically g
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44144/#review121127
---
Ship it!
Ship It!
- Adam B
On Feb. 27, 2016, 9:49 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43806/#review121087
---
Ship it!
Ship It!
- Adam B
On Feb. 27, 2016, 4:26 a.m
erify.
- Adam B
On Feb. 24, 2016, 9:32 p.m., Abhishek Dasgupta wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.a
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43716/#review121084
---
Ship it!
Ship It!
- Adam B
On Feb. 24, 2016, 10:51 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43328/#review121082
---
Ship it!
Ship It!
- Adam B
On Feb. 24, 2016, 10:50 a.m
is not required), then your
request should be allowed through without authn.
In this setup, the master would still use its --credentials to authenticate
any client that tries to use credentials.
src/tests/dynamic_weights_tests.cpp (lines 553
only roles for registered frameworks,
but quotaRoleSorter contains any role with quota set, regardless of whether any
frameworks are registered with that role."
This might belong above both the quota and roleSorter checks.
- Adam B
On Feb. 20, 2016,
.apache.org/r/43863/#comment182671>
This fits on one line if you exclude variable names for the fields you
don't use, e.g. ` Try perform(Registry* registry, hashset*,
bool);`
src/master/weights.cpp (line 25)
<https://reviews.apache.org/r/43863/#comment182672>
Only in
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43893/#review120466
---
Ship it!
Ship It!
- Adam B
On Feb. 23, 2016, 11:50 a.m
y're not implementing a new SchedulerDriver,
they're just instantiating one and calling its methods.
docs/app-framework-development-guide.md (lines 187 - 191)
<https://reviews.apache.org/r/43819/#comment181925>
Remove this from the guide since it's deprecated.
- Adam
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41681/
> ---
>
> (Updated Feb. 14, 2016, 4:02 a.m.)
>
>
> Review request for mesos, Adam B, Neil Conway, and Qian Zhang.
>
>
> Bugs: MESOS-4214
>
product on each
page, and especially in page titles or headers, must use the "Apache
Projectname" form of its name."
https://www.apache.org/foundation/marks/pmcs.html#naming
docs/documentation-guide.md (line 6)
<https://reviews.apache.org/r/43328/#comment181436>
> On Feb. 18, 2016, 10:32 p.m., Adam B wrote:
> > include/mesos/mesos.proto, line 1600
> > <https://reviews.apache.org/r/43616/diff/2/?file=1252884#file1252884line1600>
> >
> > Is it ok for labels to contain duplicate keys even if the values are
> &
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43616/#review119980
---
Ship it!
Ship It!
- Adam B
On Feb. 17, 2016, 10:44 a.m
iao Wang wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41672/
> ---
>
> (Updated Jan. 20, 2016, 12:36 a.m.)
>
>
> Review request for mesos, Adam B, Neil
/#comment181182>
s/.,/./
- Adam B
On Feb. 14, 2016, 4:47 a.m., Yongqiao Wang wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> http
value?
include/mesos/mesos.proto (line 1634)
<https://reviews.apache.org/r/43616/#comment181173>
Are you intentionally leaving out the Labels field in DiscoveryInfo, Port,
NetworkInfo, Image.Appc? I didn't think Mesos interpreted any of these either.
- Adam B
On Feb. 17, 2016,
org/r/43540/#comment180373>
Maybe the headline should be about "MesosCon 2016 CFP is now open!" or at
least mention "Denver, June"
- Adam B
On Feb. 12, 2016, 3:06 p.m., Michael Park wrote:
>
> ---
> T
> On Feb. 12, 2016, 12:13 p.m., Adam B wrote:
> > site/source/blog/2016-02-12-announcing-mesoscon-north-america-2016.md, line
> > 25
> > <https://reviews.apache.org/r/43540/diff/1/?file=1240970#file1240970line25>
> >
> > Reach out to whom? dev@ or Me
27;us'). Fix it then Ship it!
site/source/blog/2016-02-12-announcing-mesoscon-north-america-2016.md (line 25)
<https://reviews.apache.org/r/43540/#comment180352>
Reach out to whom? dev@ or MesosCon PMC or Mesosphere?
Maybe better to just leave this out of the blog post.
- Ada
wonder if all this information should just go in the endpoint help
description, and then you can link to it in the new auto-generated endpoints
docs, e.g. http://mesos.apache.org/documentation/latest/endpoints/master/roles/
docs/weights.md (line 55)
<https://reviews.apache.org/r/42719/#comment17
> On Feb. 9, 2016, 5:28 p.m., Adam B wrote:
> > docs/authentication.md, line 49
> > <https://reviews.apache.org/r/43388/diff/2/?file=1239085#file1239085line49>
> >
> > We may be deprecating the plaintext format soon
As Guangya points out, it's
ould be kinda nice if the permissive bit could apply per-action instead of
only globally. Amirite?
docs/authorization.md (line 233)
<https://reviews.apache.org/r/43199/#comment179899>
What about unauthenticated frameworks that don't have principals?
- Adam B
On Feb. 9, 2016, 4
)
<https://reviews.apache.org/r/43201/#comment179889>
How about: "Each framework may only reserve resources for its own role."
docs/reservation.md (lines 61 - 62)
<https://reviews.apache.org/r/43201/#comment179890>
Please insert your new sentence before the versioning
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43200/#review118606
---
Ship it!
Ship It!
- Adam B
On Feb. 9, 2016, 4:41 p.m., Greg
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42689/#review118540
---
Ship it!
Ship It!
- Adam B
On Feb. 9, 2016, 9:13 a.m., Neil
> On Feb. 9, 2016, 5:28 p.m., Adam B wrote:
> > Looks good, but I'd include a mention of FrameworkInfo.principal for use
> > with authorization.
Probably worth linking to
http://mesos.apache.org/documentation/latest/authorization
79796>
To enable authorization based on the authenticated principal, the framework
developer should also copy the Credential.principal into
FrameworkInfo.principal when registering.
docs/authentication.md (line 86)
<https://reviews.apache.org/r/43388/#comment179801>
Step 6.?
- A
(line 685)
<https://reviews.apache.org/r/42705/#comment179603>
s/if it is not specified,/and instead,/
docs/configuration.md (line 686)
<https://reviews.apache.org/r/42705/#comment179604>
s/operator/an operator/
- Adam B
On Jan. 24, 2016, 9:54 p.m., Yongqia
.cpp (lines 1548 - 1549)
<https://reviews.apache.org/r/41681/#comment179593>
Can you explain more clearly why this needs to be done? Is it because we
already initialized the allocator with the weights from --weights?
- Adam B
On Jan. 25,
with
`apply-reviews.py`. If you rebase it, I'll commit it.
- Adam B
On Jan. 23, 2016, 3:05 p.m., Neil Conway wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://revi
tps://reviews.apache.org/r/41681/#comment176888>
Rather than using ostringstream directly, you could use stout's `stringify`
- Adam B
On Jan. 20, 2016, 6:16 a.m., Yongqiao Wang wrote:
>
> ---
> This is an automatically genera
> On Jan. 20, 2016, 1:51 a.m., Adam B wrote:
> > src/master/master.hpp, line 1577
> > <https://reviews.apache.org/r/41681/diff/28/?file=1199825#file1199825line1577>
> >
> > Can it ever return anything but `true`? Are there any error conditions
> > at
`weights.clear()`?
src/master/master.cpp (line 1543)
<https://reviews.apache.org/r/41681/#comment176884>
s/non-default //
src/master/master.cpp (lines 1544 - 1550)
<https://reviews.apache.org/r/41681/#comment176886&g
GELOG.
- Adam B
On Jan. 21, 2016, 1:04 a.m., Guangya Liu wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41979/
> -
don't worry about it.
src/tests/teardown_tests.cpp (line 188)
<https://reviews.apache.org/r/41932/#comment176592>
s/good ACLs/deprecated (but still good) ACLs,/
- Adam B
On Jan. 21, 2016, 12:52 a.m., Guangy
tps://reviews.apache.org/r/41979/#comment176590>
s/can be teardown by/can be torn down by/
- Adam B
On Jan. 14, 2016, 12:06 a.m., Guangya Liu wrote:
>
> ---
> This is an automatically generated e-mail. To reply,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41930/#review115594
---
Ship it!
Ship It!
- Adam B
On Jan. 13, 2016, 11:51 p.m
ormats.
So how about a TeardownEndpointGoodACLs and a
TeardownEndpointGoodDeprecatedACLs?
- Adam B
On Jan. 13, 2016, 11:53 p.m., Guangya Liu wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://
tps://reviews.apache.org/r/41790/#comment176398>
Please put the open brace `{` on a new line.
src/tests/dynamic_weights_tests.cpp (line 400)
<https://reviews.apache.org/r/41790/#comment176399>
s/role/roles/
- Adam B
On Jan. 20, 2016, 1:14 a.m., Yongqia
ews.apache.org/r/41681/#comment176395>
Why are you reconstructing a roles `string` out of the weightInfos instead
of just using a `vector`? Does `authorize()` really require a comma-delimited
string?
What I was proposing before was that you call `authorize(principal, ro
x27;t hear any objection from Joris
(the original shepherd of MESOS-3763).
3rdparty/libprocess/include/process/http.hpp (lines 830 - 831)
<https://reviews.apache.org/r/41789/#comment176369>
s/Clean/Refactor/
s/and using/to use/
- Adam B
On Jan. 20, 2016, 12:26 a.m., Yon
> On Jan. 19, 2016, 7:11 p.m., Adam B wrote:
> > 3rdparty/libprocess/include/process/http.hpp, lines 812-814
> > <https://reviews.apache.org/r/41789/diff/11-17/?file=1189248#file1189248line812>
> >
> > Seems like a good candidate for a doxygen-style @param
> On Jan. 11, 2016, 12:12 a.m., Adam B wrote:
> > 3rdparty/libprocess/src/http.cpp, lines 1218-1221
> > <https://reviews.apache.org/r/41789/diff/11/?file=1189249#file1189249line1218>
> >
> > Will you add `query` as a parameter only once you&#
.cpp (line 2490)
<https://reviews.apache.org/r/41672/#comment176351>
s/have possessed all resources/sum to the total resources/
- Adam B
On Jan. 19, 2016, 10:49 p.m., Yongqiao Wang wrote:
>
> ---
> This is an automatic
ented 4 spaces instead of 2
src/tests/hierarchical_allocator_tests.cpp (lines 2177 - 2178)
<https://reviews.apache.org/r/41672/#comment176341>
Where do you verify that role2 doesn't get any offers? Shouldn't you verify
that `allocations.get()` returns a single allocation of (6) TOTAL_RESOU
> On Jan. 11, 2016, 2:13 a.m., Adam B wrote:
> > src/tests/hierarchical_allocator_tests.cpp, lines 2218-2219
> > <https://reviews.apache.org/r/41672/diff/6/?file=1181569#file1181569line2218>
> >
> > Why hardcode 3? I'd think you could just run a while
org/r/41597/#comment176330>
`CHECK(weightInfo.has_role());`
- Adam B
On Jan. 18, 2016, 12:53 a.m., Yongqiao Wang wrote:
>
> ---
> This is an automatically generated e-mail. To
ing a function: indent with 4 spaces."
Although you were correct for the previous line:
"Newline for an assignment statement: indent with 2 spaces."
See http://mesos.apache.org/documentation/latest/c++-style
> On Jan. 11, 2016, 12:12 a.m., Adam B wrote:
> > 3rdparty/libprocess/src/http.cpp, lines 1218-1221
> > <https://reviews.apache.org/r/41789/diff/11/?file=1189249#file1189249line1218>
> >
> > Will you add `query` as a parameter only once you&#
> On Jan. 15, 2016, 1:34 a.m., Adam B wrote:
> > src/tests/hierarchical_allocator_tests.cpp, lines 2093-2096
> > <https://reviews.apache.org/r/41672/diff/7/?file=1194005#file1194005line2093>
> >
> > We rarely (only 67 times) use `unsigned`. Usually it&#x
offered again next time./
src/tests/hierarchical_allocator_tests.cpp (line 2171)
<https://reviews.apache.org/r/41672/#comment175561>
Now that the frameworks' weights are 1:2,...
src/tests/hierarchical_allocator_tests.cpp (line 2172)
<https://reviews.apache.org/r/41672/#comment17
> On Jan. 11, 2016, 2:13 a.m., Adam B wrote:
> > src/tests/hierarchical_allocator_tests.cpp, line 2095
> > <https://reviews.apache.org/r/41672/diff/6/?file=1181569#file1181569line2095>
> >
> > When did we start initializing string constants with braces
ast do an `if()` check.
- Adam B
On Jan. 12, 2016, 1:34 a.m., Yongqiao Wang wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
>
> On Jan. 6, 2016, 2:09 a.m., Adam B wrote:
> > src/master/allocator/mesos/hierarchical.cpp, lines 1048-1051
> > <https://reviews.apache.org/r/41597/diff/36/?file=1183523#file1183523line1048>
> >
> > Does anything rely on this behavior of erasing 1.0s fr
> On Jan. 14, 2016, 1:33 a.m., Adam B wrote:
> > Looks great! Just a few minor items that I can fix myself. I'll commit this
> > shortly.
>
> haosdent huang wrote:
> Thank you very much!
No sir, thank you!
- Adam
-
mmitters.md (line 73)
<https://reviews.apache.org/r/42312/#comment175383>
Dominic is at YouTube
docs/committers.md (line 101)
<https://reviews.apache.org/r/42312/#comment175378>
Andy founded Databricks with Matei
- Adam B
On Jan. 14, 2016, 10:21
mmon/roles.cpp (line 30)
<https://reviews.apache.org/r/35711/#comment175285>
s/to support/supporting/
src/common/roles.cpp (line 68)
<https://reviews.apache.org/r/35711/#comment175287>
We can pull this (and its comment) out into a `static const string
INVALID_CHARACTERS` in the
> On April 21, 2015, 10:30 a.m., Mesos ReviewBot wrote:
> > Patch looks great!
> >
> > Reviews applied: [32975]
> >
> > All tests passed.
Jim, I heard there was interest in reviving this patch. Could you please rebase?
- Adam
---
This
subject
doesn't match the parenthesized verb. To correct this, I would recommend
rewording as follows:
s/the framework(s) enable(s)/a framework enables/
- Adam B
On Jan. 12, 2016, 7:01 a.m., Joerg Schad wrote:
>
> ---
>
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42217/#review114094
---
Ship it!
Ship It!
- Adam B
On Jan. 12, 2016, 2:41 p.m., Anand
//reviews.apache.org/r/41806/#comment174882>
Not yours, but could you fix the indentation please?
- Adam B
On Jan. 12, 2016, 12:47 p.m., Neil Conway wrote:
>
> ---
> Th
ve to set the sizes for the circular buffer once. We long ago discussed
refactoring the circular buffer so we could enable storage/retrieval to/from an
archive of the data that is no longer cached in memory.
I'd be ok with any of these, so I'll let you and your Shepherd choose.
t;
re-wrap
src/examples/docker_no_executor_framework.cpp (line 184)
<https://reviews.apache.org/r/41649/#comment174744>
Remove the double-blank line.
src/internal/devolve.cpp
<https://reviews.apache.org/r/41649/#comment174745>
I thought we said we'd leave this `info.set_checkpoint(tru
d actually
assert the size that you think the allocations hashmap will be. (And what key
will be in each entry.)
src/tests/hierarchical_allocator_tests.cpp (lines 2223 - 2234)
<https://reviews.apache.org/r/41672/#comment174531>
Why is the resource ratio 2:1:1 when the weight ratio
ample for teardown_frameworks, since that's newer. We
shouldn't be showing examples with a deprecated field. It's especially
confusing to give an example that sets both.
- Adam B
On Jan. 6, 2016, 7:23 a.m., Guangya Liu wrote:
>
>
174490>
Why not continue to call it 'request'? `http::httpRequest()` seems
redundant.
- Adam B
On Jan. 9, 2016, 3:37 a.m., Yongqiao Wang wrote:
>
> ---
> This is an automatically generated e-mail.
s://reviews.apache.org/r/41790/#comment174482>
s/absense/absence/
src/tests/dynamic_weights_tests.cpp (lines 394 - 395)
<https://reviews.apache.org/r/41790/#comment174485>
You should also set `acls.permissive = false;` if you want to actually
disallow unknown principals/roles.
tch?
src/authorizer/local/authorizer.cpp (line 77)
<https://reviews.apache.org/r/41930/#comment174443>
Did you mean to iterate through `shutdown_frameworks()` or
`teardown_frameworks()`? Or both?
- Adam B
On Jan. 6,
lidation fails for any role, None otherwise."
src/tests/role_tests.cpp (line 602)
<https://reviews.apache.org/r/35711/#comment174410>
s/function/functions/
- Adam B
On Jan. 9, 2016, 3:15 a.m., haosdent huang wrote:
>
> ---
> On Jan. 9, 2016, 11:44 p.m., Klaus Ma wrote:
> > src/common/roles.cpp, line 32
> > <https://reviews.apache.org/r/35711/diff/22/?file=1189198#file1189198line32>
> >
> > Do we need to define a const value `REOLE_SPLITOR` to replace ','?
>
ally generated e-mail. To reply, visit:
https://reviews.apache.org/r/35711/#review113639
---
On Jan. 9, 2016, 3:15 a.m., haosdent huang wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https:
---
On Jan. 8, 2016, 4:46 a.m., Joerg Schad wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41649/
> -------
&g
;s
checkpoint variable to filter.
src/master/master.cpp (line 1110)
<https://reviews.apache.org/r/41649/#comment174290>
s/checkpointing//
- Adam B
On Jan. 8, 2016, 4:46 a.m., Joerg Schad wrote:
>
> ---
> This is an
(line 1088)
<https://reviews.apache.org/r/41649/#comment174272>
Unnecessary comment?
- Adam B
On Jan. 8, 2016, 4:46 a.m., Joerg Schad wrote:
>
> ---
> This is an automati
on::none()/None()/?
src/master/weights_handler.cpp (line 140)
<https://reviews.apache.org/r/41681/#comment174126>
// Update the registry and acknowledge the request.
src/master/weights_handler.cpp (lines 150 - 151)
<https://reviews.apache.org/r/41681/#comment174128>
How ab
27;ve discarded the
parent patch?
- Adam B
On Dec. 18, 2015, 1:30 p.m., Neil Conway wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.a
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42044/#review113374
---
Ship it!
Ship It!
- Adam B
On Jan. 7, 2016, 4:15 p.m., Neil
sts.cpp (line 615)
<https://reviews.apache.org/r/35711/#comment173888>
Could you add another check that validate("foo..bar") and/or ".foo"
succeeds, so we know we're only erroring on "." and ".." as full strings.
- Adam B
On Jan. 5, 2016, 7:19
.cpp (line 1357)
<https://reviews.apache.org/r/42025/#comment173874>
Ditto
- Adam B
On Jan. 7, 2016, 12:29 p.m., Till Toenshoff wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit
8/10] [ FAILED ]
SlaveTest.TerminatingSlaveDoesNotReregister (129 ms)
```
Which makes me think we should leave out the `offerRescinded` change to
this test, and address the test's flakiness separately, in MESOS-3509.
- Adam B
On Jan. 5, 2016, 11:01 a
ommit this.
src/sched/sched.cpp (line 1029)
<https://reviews.apache.org/r/40429/#comment173451>
Why is this VLOG(2) instead of VLOG(1)? Seems at least as valuable as the
"Scheduler::executorLost took" message below.
I'll bring this back up to VLOG(1) so they'r
ed e-mail. To reply, visit:
https://reviews.apache.org/r/42002/#review113161
---
On Jan. 6, 2016, 4:47 p.m., Adam B wrote:
>
> ---
> This is an automatically generated e-mail. To re
mostly wanted to get rid of gyliu513's TODOs, but got frustrated with the
useless comment : function definition ratio.
Thanks,
Adam B
bits in memory and persisted in the
registry, but is there any other reason to do this? Might be a premature
optimization. Besides, the sorters still get updated for 1.0s.
Thoughts?
- Adam B
On Jan. 5, 2016, 6:14 p.m., Yongqiao Wang wrote:
>
> ---
> On Jan. 5, 2016, 4:06 p.m., Adam B wrote:
> > Thanks for noticing and fixing this.
> > - You missed a couple of references in authorization.md as well though.
> > Could you fix those too?
(probably need a rebase after Greg's recent change to
references in authorization.md as well though. Could
you fix those too?
- Adam B
On Jan. 5, 2016, 7:33 a.m., Guangya Liu wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41920/#review112795
---
Ship it!
Ship It!
- Adam B
On Jan. 4, 2016, 11:59 p.m
s/roles_tests.cpp (line 32)
<https://reviews.apache.org/r/35711/#comment173291>
s/This test tests/This tests/
src/tests/roles_tests.cpp (line 55)
<https://reviews.apache.org/r/35711/#comment173292>
s/This test tests/This tests/
- Adam B
On Jan. 4, 2016, 10:58 p.m., haosd
> On Jan. 4, 2016, 2:23 a.m., Adam B wrote:
> > include/mesos/mesos.proto, line 1669
> > <https://reviews.apache.org/r/41597/diff/23/?file=1180669#file1180669line1669>
> >
> > Let's make it `optional`, in case we later want to add weights per
> &
ps://reviews.apache.org/r/40429/#comment173236>
s/containizer/containerizer/
- Adam B
On Jan. 4, 2016, 5:14 p.m., Zhitao Li wrote:
>
> ---
> This is an automatically generated e-mail. To reply,
401 - 500 of 777 matches
Mail list logo
