Re: Review Request 52887: Added a CHANGELOG description for partition-aware frameworks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52887/#review152836 --- Ship it! Ship It! - Alexander Rukletsov On Oct. 15, 2016,

Re: Review Request 52600: Enable multiple field based authorization in the authorizer interface.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52600/ --- (Updated Oct. 17, 2016, 10:14 a.m.) Review request for mesos, Adam B, Kapil

Re: Review Request 52865: Refactored HealthChecker to never stop health checking.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52865/#review152828 --- src/tests/health_check_tests.cpp (lines 1212 - 1215)

Re: Review Request 52866: Refactored HealthChecker::reschedule to take duration as an argument.

> On Oct. 17, 2016, 7:03 a.m., haosdent huang wrote: > > Is there any reason we try to avoid `check.interval_seconds()` in > > `reschedule`. Would be greate if could update the commit message about the > > motivation. I feel it would be better to use https://reviews.apache.org/r/52867/ as the

Re: Review Request 52867: Used `Duration::create()` for double -> Duration conversion.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52867/#review152830 --- src/health-check/health_checker.cpp (lines 356 - 357)

Re: Review Request 52877: Fixed wrong float serialization in JSON in locales different from C.

> On Oct. 15, 2016, 1:23 a.m., Joris Van Remoortere wrote: > > I have a feeling that if you kept around a stringstream with the local set > > your benchmarks would look rather different. > > I also suggest using callgrind to get the instruction count / # of library > > calls made. That

Re: Review Request 49829: Consistently used virtual inheritance for Flags classes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49829/#review152760 --- src/uri/fetcher.hpp (line 43)

Re: Review Request 52600: Enable multiple field based authorization in the authorizer interface.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52600/ --- (Updated Oct. 17, 2016, 12:12 p.m.) Review request for mesos, Adam B, Kapil

Re: Review Request 52866: Refactored HealthChecker::reschedule to take duration as an argument.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52866/#review152829 --- Is there any reason we try to avoid `check.interval_seconds()` in

Re: Review Request 52865: Refactored HealthChecker to never stop health checking.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52865/#review152827 --- src/health-check/health_checker.cpp (lines 204 - 215)

Re: Review Request 52866: Refactored HealthChecker::reschedule to take duration as an argument.

> On Oct. 17, 2016, 7:03 a.m., haosdent huang wrote: > > Is there any reason we try to avoid `check.interval_seconds()` in > > `reschedule`. Would be greate if could update the commit message about the > > motivation. > > haosdent huang wrote: > I feel it would be better to use

Re: Review Request 52386: Deleted potentially implicitly generated functions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52386/#review152844 --- Ship it! Ship It! - Michael Park On Oct. 6, 2016, 2:58

Re: Review Request 49833: Consistently used virtual inheritance for Flags classes in stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49833/#review152757 --- 3rdparty/stout/tests/flags_tests.cpp (line 836)

Re: Review Request 52600: Enable multiple field based authorization in the authorizer interface.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52600/ --- (Updated Oct. 17, 2016, 12:10 p.m.) Review request for mesos, Adam B, Kapil

Re: Review Request 52809: User Namespaces Initial Implementation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52809/ --- (Updated Oct. 17, 2016, 11:59 p.m.) Review request for mesos, Gilbert Song and

Re: Review Request 52810: Added tests to test usernamespaces.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52810/ --- (Updated Oct. 17, 2016, 11:58 p.m.) Review request for mesos, Gilbert Song and

Re: Review Request 52771: Captured the `stderr` during execution of CNI plugin.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52771/ --- (Updated Oct. 18, 2016, 12:02 a.m.) Review request for mesos, Jie Yu and Qian

Re: Review Request 52083: Changed reconciliation for unregistering, reregistering agents.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52083/#review152997 --- Ship it! Ship It! - Vinod Kone On Oct. 13, 2016, 2:10 p.m.,

Re: Review Request 51617: Added the logic for installing and removing DNAT rules.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51617/#review152989 --- Fix it, then Ship it!

Re: Review Request 52659: Changed master to send TASK_DROPPED for task launch errors.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52659/#review152999 --- Fix it, then Ship it!

Re: Review Request 52741: Added capabilities support to mesos-execute.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52741/#review152969 --- Fix it, then Ship it! src/cli/execute.cpp (line 690)

Re: Review Request 52783: Added documentation for mesos-containerizer Linux capabilities support.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52783/#review152971 --- Fix it, then Ship it! Thanks!!! docs/linux_capabilities.md

Re: Review Request 40266: Libprocess Reinit: Cleanup SocketManager alongside ProcessManager.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40266/#review152977 --- Ship it! 3rdparty/libprocess/src/process.cpp (line 2858)

Re: Review Request 52656: Cleaned up a test case.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52656/#review152984 --- Ship it! Ship It! - Vinod Kone On Oct. 7, 2016, 11:50 p.m.,

Re: Review Request 52657: Clarified a comment that occurs in several tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52657/#review152985 --- Ship it! Ship It! - Vinod Kone On Oct. 7, 2016, 11:50 p.m.,

Re: Review Request 52092: Avoided to concat cgroup internally in subsystems.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52092/#review152975 --- Fix it, then Ship it!

Re: Review Request 52658: Changed scheduler driver to send TASK_DROPPED.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52658/#review152986 --- Fix it, then Ship it! src/sched/sched.cpp (line 1305)

Re: Review Request 52771: Captured the `stderr` during execution of CNI plugin.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52771/#review152988 --- src/slave/containerizer/mesos/isolators/network/cni/cni.cpp

Re: Review Request 51617: Added the logic for installing and removing DNAT rules.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51617/ --- (Updated Oct. 17, 2016, 10:56 p.m.) Review request for mesos, Jie Yu and Qian

Re: Review Request 52771: Captured the `stderr` during execution of CNI plugin.

> On Oct. 17, 2016, 11:30 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/network/cni/cni.cpp, lines 1507-1508 > > > > > > Looks like CNI spec does not specify if stdout will be empty or not. > >

Re: Review Request 52543: Added configure/make options to build the new CLI and run unit tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52543/#review152994 --- Patch looks great! Reviews applied: [52939, 52940, 52941, 52942,

Review Request 52965: Added missing titles to documentation pages.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52965/ --- Review request for mesos and Jiang Yan Xu. Repository: mesos Description

Review Request 52966: Fixed typo in comment.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52966/ --- Review request for mesos and Jiang Yan Xu. Repository: mesos Description

Review Request 52967: Improved documentation for shared persistent volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52967/ --- Review request for mesos and Jiang Yan Xu. Repository: mesos Description

Review Request 52968: Added `mesos-cni-port-mapper` to the CHANGELOG.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52968/ --- Review request for mesos and Jie Yu. Repository: mesos Description ---

Re: Review Request 52771: Captured the `stderr` during execution of CNI plugin.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52771/#review153004 --- Fix it, then Ship it!

Re: Review Request 52968: Added `mesos-cni-port-mapper` to the CHANGELOG.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52968/#review153010 --- Ship it! Ship It! - Jie Yu On Oct. 18, 2016, 12:57 a.m.,

Re: Review Request 52939: Updated CLI pylint configuration to allow 2 character variable names.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52939/#review153007 --- src/cli_new/pylint.config (line 13)

Re: Review Request 52944: Updated CLI pylint configuration to disable 'fixme' warnings.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52944/#review153009 --- Ship it! Considering how we love TODOs on our codebase, this

Re: Review Request 52658: Changed scheduler driver to send TASK_DROPPED.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52658/ --- (Updated Oct. 18, 2016, 1:01 a.m.) Review request for mesos and Vinod Kone.

Re: Review Request 52941: Updated CLI pylint configuration to allow 0 public methods.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52941/#review153008 --- src/cli_new/pylint.config (line 15)

Re: Review Request 51008: Added infrastructure for unit tests in the new python-based CLI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51008/#review153003 --- src/cli_new/bin/tests.py (lines 23 - 25)

Re: Review Request 52943: Updated CLI pylint configuration to disable no-self-use warnings.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52943/#review153005 --- Ship it! I see this warning here:

Re: Review Request 52968: Added `mesos-cni-port-mapper` to the CHANGELOG.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52968/ --- (Updated Oct. 18, 2016, 1 a.m.) Review request for mesos and Jie Yu. Changes

Re: Review Request 52940: Updated CLI pylint configuration to allow up to 30 local variables.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52940/#review152998 --- src/cli_new/pylint.config (line 14)

Re: Review Request 52953: Added container 'exec' command to the CLI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52953/#review153006 --- src/cli_new/lib/mesos/plugins/container/main.py (line 30)

Re: Review Request 52659: Changed master to send TASK_DROPPED for task launch errors.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52659/ --- (Updated Oct. 18, 2016, 1:05 a.m.) Review request for mesos and Vinod Kone.

Review Request 52969: Removed redundant test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52969/ --- Review request for mesos and Vinod Kone. Repository: mesos Description

Re: Review Request 52659: Changed master to send TASK_DROPPED for task launch errors.

> On Oct. 18, 2016, 12:35 a.m., Vinod Kone wrote: > > src/tests/master_authorization_tests.cpp, line 783 > > > > > > This test looks identical to SlaveRemoved test. Please kill this in a > > different review.

Re: Review Request 52693: Changed master to send TASK_UNKNOWN during reconciliation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52693/ --- (Updated Oct. 18, 2016, 1:14 a.m.) Review request for mesos and Vinod Kone.

Re: Review Request 52311: Pass the user value from executor of switch_user flag is set.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52311/#review153013 --- The `MasterTest.MasterFailoverLongLivedExecutor` failing

Review Request 52970: Fixed a comment and some style issues in `network/cni` isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52970/ --- Review request for mesos and Jie Yu. Bugs: MESOS-6282

Re: Review Request 52741: Added capabilities support to mesos-execute.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52741/#review153014 --- Patch looks great! Reviews applied: [52780, 52741] Passed

Re: Review Request 50123: Added GPU scheduler for docker containerizer process.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50123/#review153020 --- src/slave/containerizer/docker.hpp (line 76)

Re: Review Request 50841: Added GPU scheduling logic to docker containerizer process.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50841/#review153021 --- src/slave/containerizer/docker.hpp (lines 258 - 274)

Re: Review Request 52544: Introduced `FileDesc` class.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52544/ --- (Updated Oct. 18, 2016, 2:45 a.m.) Review request for mesos, Alex Naparu, Alex

Re: Review Request 52967: Improved documentation for shared persistent volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52967/#review153026 --- Patch looks great! Reviews applied: [52965, 52966, 52967]

Re: Review Request 52625: Replaced POSIX `int` with `FileDesc` abstraction in `libprocess` folder.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52625/ --- (Updated Oct. 18, 2016, 2:47 a.m.) Review request for mesos, Alex Naparu, Alex

Re: Review Request 52624: Replaced POSIX `int` with `FileDesc` abstraction in `src` folder.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52624/ --- (Updated Oct. 18, 2016, 2:46 a.m.) Review request for mesos, Alex Naparu, Alex

Review Request 52972: Replaced POSIX `int` with `FileDesc` abstraction in `stout` folder.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52972/ --- Review request for mesos. Repository: mesos Description --- Replaced

Re: Review Request 52696: Harden stout

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52696/#review153025 --- 3rdparty/stout/Makefile.am (line 27)

Re: Review Request 52647: Fix new sign comparison errors in libprocess produced by hardened flags

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52647/#review153024 --- 3rdparty/libprocess/src/encoder.hpp (line 291)

Re: Review Request 51052: Make mesos-docker-execute understand cgroups_enable_cfs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51052/#review153030 --- src/docker/docker.hpp (line 51)

Re: Review Request 52783: Added documentation for mesos-containerizer Linux capabilities support.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52783/#review153028 --- docs/configuration.md (line 1003)

Re: Review Request 51785: [HBASE-16608] Merge for the segments in the compaction pipeline and simplifying the user interface for in-memory flush

> On Oct. 16, 2016, 10:43 p.m., Anoop Sam John wrote: > > hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HeapMemStoreLAB.java, > > line 179 > > > > > > Able to get what u r trying to do here.

Review Request 52975: Factored out the create port range logic to test utils.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52975/ --- Review request for mesos and Benjamin Mahler. Repository: mesos Description

Re: Review Request 51785: [HBASE-16608] Merge for the segments in the compaction pipeline and simplifying the user interface for in-memory flush

> On Oct. 16, 2016, 5:13 p.m., Anoop Sam John wrote: > > hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HeapMemStoreLAB.java, > > line 179 > > > > > > Able to get what u r trying to do here.

Re: Review Request 52878: Removed outdated TODO in stout::flags.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52878/#review152913 --- Ship it! Ship It! - haosdent huang On Oct. 14, 2016, 1:35

Re: Review Request 52879: Updated the way in which the default and command executors load options.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52879/#review152909 --- The length of the commit message greater than 72, I think it

Re: Review Request 52879: Updated the way in which the default and command executors load options.

> On Oct. 17, 2016, 5:52 p.m., haosdent huang wrote: > > src/launcher/default_executor.cpp, line 1034 > > > > > > Let's use `agent_pid` here? Since we rename slave to agent. > > haosdent huang wrote: > hmm, I

Re: Review Request 52879: Updated the way in which the default and command executors load options.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52879/#review152914 --- Do you forget to update the

Re: Review Request 52868: Added pause/resume functionality to HealthChecker.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52868/#review152908 --- src/health-check/health_checker.cpp (line 243)

Review Request 52934: Explain read-only mode of persistent volumes in shared-resources.md.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52934/ --- Review request for mesos, (Disabled_DoNotUse) Anindya Sinha and Neil Conway.

Re: Review Request 51785: [HBASE-16608] Merge for the segments in the compaction pipeline and simplifying the user interface for in-memory flush

> On Oct. 15, 2016, 3:18 a.m., Michael Stack wrote: > > hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MemStoreCompactor.java, > > line 186 > > > > > > s/isInterrupted/interrupted/... its a

Re: Review Request 51785: [HBASE-16608] Merge for the segments in the compaction pipeline and simplifying the user interface for in-memory flush

> On Oct. 15, 2016, 3:18 a.m., Michael Stack wrote: > > hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MemStoreCompactor.java, > > line 229 > > > > > > This is too many threads. An executor of a

Re: Review Request 52682: Cleaned up a few style issues in the capabilities isolator tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52682/#review152968 --- Fix it, then Ship it!

Re: Review Request 52810: Added tests to test usernamespaces.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52810/ --- (Updated Oct. 17, 2016, 10:27 p.m.) Review request for mesos, Gilbert Song and

Re: Review Request 52780: Added input and output functions for v1::CapabilityInfo.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52780/#review152970 --- src/v1/mesos.cpp (lines 517 - 533)

Re: Review Request 51617: Added the logic for installing and removing DNAT rules.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51617/ --- (Updated Oct. 17, 2016, 10:11 p.m.) Review request for mesos, Jie Yu and Qian

Re: Review Request 52810: Added tests to test usernamespaces.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52810/ --- (Updated Oct. 17, 2016, 10:22 p.m.) Review request for mesos, Gilbert Song and

Re: Review Request 51785: [HBASE-16608] Merge for the segments in the compaction pipeline and simplifying the user interface for in-memory flush

> On Oct. 15, 2016, 3:18 a.m., Michael Stack wrote: > > hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/ImmutableSegment.java, > > line 88 > > > > > > Why we have a MemStoreSegmentsIterator and not

Re: Review Request 51617: Added the logic for installing and removing DNAT rules.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51617/ --- (Updated Oct. 17, 2016, 10:27 p.m.) Review request for mesos, Jie Yu and Qian

Re: Review Request 52863: Refactored HealthCheck validation for clarity.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52863/#review152825 --- Ship it! Ship It! - haosdent huang On Oct. 14, 2016, 12:35

Re: Review Request 52864: Removed unnecessary sleep in HealthChecker.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52864/#review152826 --- Ship it! Ship It! - haosdent huang On Oct. 14, 2016, 12:35

Re: Review Request 52867: Used `Duration::create()` for double -> Duration conversion.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52867/#review152851 --- src/health-check/health_checker.cpp (lines 356 - 357)

Re: Review Request 52880: Added "launcher_dir" to the default executor flags.

> On Oct. 14, 2016, 8:25 p.m., Jiang Yan Xu wrote: > > This is conversation carried over from /r/52556/ > > > > Now that we're in the business of (re)naming things for consistency, > > understandability and unambiguity, how about we just follow some widely > > used conventions: > >

Re: Review Request 52560: Avoided temporary `MockDocker` pointers in health check test cases.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52560/ --- (Updated Oct. 17, 2016, 2:53 p.m.) Review request for mesos, Alexander

Re: Review Request 52561: Renamed `flags` to `agentFlags` in health check test cases.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52561/ --- (Updated Oct. 17, 2016, 2:53 p.m.) Review request for mesos, Alexander

Re: Review Request 52786: Add the health check test helper.

> On Oct. 17, 2016, 12:34 p.m., Gastón Kleiman wrote: > > src/tests/containerizer/health_check_test_helper.cpp, line 66 > > > > > > Yhis method is so short, that I don't think we need this comment. > > > >

Re: Review Request 52786: Add the health check test helper.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52786/ --- (Updated Oct. 17, 2016, 2:51 p.m.) Review request for mesos, Alexander

Re: Review Request 51617: Added the logic for installing and removing DNAT rules.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51617/#review152881 --- Patch looks great! Reviews applied: [52671, 52771, 52772, 52773,

Re: Review Request 46823: Fully qualified addresses of Flag members in add calls in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46823/#review152879 --- Ship it! Ship It! - Michael Park On Oct. 6, 2016, 2:59

Re: Review Request 52250: Added test cases for HTTP health check.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52250/ --- (Updated Oct. 17, 2016, 2:38 p.m.) Review request for mesos, Alexander

Re: Review Request 52563: Minor clean ups in `health_check_tests.cpp` for consistency.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52563/ --- (Updated Oct. 17, 2016, 2:53 p.m.) Review request for mesos, Alexander

Re: Review Request 52251: Added test cases for TCP health check.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52251/ --- (Updated Oct. 17, 2016, 2:52 p.m.) Review request for mesos, Alexander

Re: Review Request 46825: Fully-typed all FlagsBase::add overloads.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46825/#review152882 --- Ship it! Ship It! - Michael Park On Oct. 6, 2016, 2:59

Re: Review Request 51617: Added the logic for installing and removing DNAT rules.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51617/ --- (Updated Oct. 17, 2016, 1:42 p.m.) Review request for mesos, Jie Yu and Qian

Re: Review Request 52250: Added test cases for HTTP health check.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52250/#review152884 --- Ship it! LGTM - Gastón Kleiman On Oct. 17, 2016, 2:52 p.m.,

Re: Review Request 52600: Enable multiple field based authorization in the authorizer interface.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52600/#review152847 --- Patch looks great! Reviews applied: [52600] Passed command:

Re: Review Request 46824: Fully qualified addresses of Flag members in add calls.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46824/ --- (Updated Oct. 17, 2016, 5:24 p.m.) Review request for mesos, Alexander

  1   2   >