[kudu-CR] KUDU-2351 Add IP/port for Recv() failure

2018-04-19 Thread Attila Bukor (Code Review)
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/9818 ) Change subject: KUDU-2351 Add IP/port for Recv() failure .. Patch Set 12: (4 comments)

[kudu-CR] KUDU-2351 Add IP/port for Recv() failure

2018-04-19 Thread Attila Bukor (Code Review)
Hello Tidy Bot, Dan Burkert, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9818 to look at the new patch set (#12). Change subject: KUDU-2351 Add IP/port for Recv() failure

[kudu-CR] KUDU-2287 Expose election failures as metrics

2018-04-19 Thread Attila Bukor (Code Review)
Hello Will Berkeley, Tidy Bot, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10076 to look at the new patch set (#7). Change subject: KUDU-2287 Expose election failures as metrics

[kudu-CR] KUDU-2351 Add IP/port for Recv() failure

2018-04-19 Thread Attila Bukor (Code Review)
Hello Tidy Bot, Dan Burkert, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9818 to look at the new patch set (#13). Change subject: KUDU-2351 Add IP/port for Recv() failure

[kudu-CR] KUDU-2287 Expose election failures as metrics

2018-04-19 Thread Attila Bukor (Code Review)
Hello Will Berkeley, Tidy Bot, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10076 to look at the new patch set (#8). Change subject: KUDU-2287 Expose election failures as metrics

[kudu-CR] KUDU-2368 Configure num reactors in client

2018-04-19 Thread Attila Bukor (Code Review)
Attila Bukor has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10115 Change subject: KUDU-2368 Configure num_reactors in client .. KUDU-2368 Configure num_reactors in client The number of reactors was not

[kudu-CR] [Java] Mark the Yetus annotations dependency optional

2018-04-19 Thread Grant Henke (Code Review)
Hello Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10095 to look at the new patch set (#3). Change subject: [Java] Mark the Yetus annotations dependency optional

[kudu-CR] [Java] Use Yetus annotations in place of @VisibleForTesting

2018-04-19 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/10077 ) Change subject: [Java] Use Yetus annotations in place of @VisibleForTesting .. Patch Set 7: (1 comment)

[kudu-CR] [Java] Mark the Yetus annotations dependency optional

2018-04-19 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/10095 ) Change subject: [Java] Mark the Yetus annotations dependency optional .. Patch Set 2: (1 comment)

[kudu-CR] KUDU-2351 Add IP/port for Recv() failure

2018-04-19 Thread Attila Bukor (Code Review)
Hello Tidy Bot, Dan Burkert, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9818 to look at the new patch set (#14). Change subject: KUDU-2351 Add IP/port for Recv() failure

[kudu-CR] build-support: add a nicer logger to python scripts

2018-04-19 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/10131 ) Change subject: build-support: add a nicer logger to python scripts .. Patch Set 2: Verified+1 -- To view, visit

[kudu-CR] build-support: add a nicer logger to python scripts

2018-04-19 Thread Alexey Serbin (Code Review)
Alexey Serbin has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/10131 ) Change subject: build-support: add a nicer logger to python scripts .. Removed reviewer Kudu Jenkins with the following votes:

[kudu-CR] build-support: add a nicer logger to python scripts

2018-04-19 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/10131 ) Change subject: build-support: add a nicer logger to python scripts .. Patch Set 2: Unrelated flake in

[kudu-CR] build-support: add a nicer logger to python scripts

2018-04-19 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10131 ) Change subject: build-support: add a nicer logger to python scripts .. build-support: add a nicer logger to python scripts

[kudu-CR] [iwyu] minor cleanup after LLVM/IWYU update

2018-04-19 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/10130 ) Change subject: [iwyu] minor cleanup after LLVM/IWYU update .. Patch Set 2: > Build Failed > >

[kudu-CR] [iwyu] minor cleanup after LLVM/IWYU update

2018-04-19 Thread Alexey Serbin (Code Review)
Alexey Serbin has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/10130 ) Change subject: [iwyu] minor cleanup after LLVM/IWYU update .. Removed reviewer Kudu Jenkins with the following votes: *

[kudu-CR] [iwyu] minor cleanup after LLVM/IWYU update

2018-04-19 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/10130 ) Change subject: [iwyu] minor cleanup after LLVM/IWYU update .. Patch Set 2: Verified+1 All right, I would consider this IWYU

[kudu-CR] Modify fix includes.py for Kudu usage, add a wrapper

2018-04-19 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/10106 ) Change subject: Modify fix_includes.py for Kudu usage, add a wrapper .. Patch Set 4: Code-Review+2 -- To view, visit

[kudu-CR] Modify fix includes.py for Kudu usage, add a wrapper

2018-04-19 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10106 ) Change subject: Modify fix_includes.py for Kudu usage, add a wrapper .. Modify fix_includes.py for Kudu usage, add a wrapper

[kudu-CR] [Java] Mark the Yetus annotations dependency optional

2018-04-19 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/10095 ) Change subject: [Java] Mark the Yetus annotations dependency optional .. Patch Set 5: Code-Review+2 Carrying the +2 through the rebase.

[kudu-CR] [iwyu] minor cleanup after LLVM/IWYU update

2018-04-19 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10130 ) Change subject: [iwyu] minor cleanup after LLVM/IWYU update .. [iwyu] minor cleanup after LLVM/IWYU update It seems IWYU

[kudu-CR] [iwyu] minor cleanup after LLVM/IWYU update

2018-04-19 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/10130 ) Change subject: [iwyu] minor cleanup after LLVM/IWYU update .. Patch Set 2: Code-Review+2 Carrying over Todd's +2 from PS1. -- To

[kudu-CR] build-support: add a nicer logger to python scripts

2018-04-19 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/10131 ) Change subject: build-support: add a nicer logger to python scripts .. Patch Set 2: (1 comment)

[kudu-CR] [Java] Mark the Yetus annotations dependency optional

2018-04-19 Thread Grant Henke (Code Review)
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10095 ) Change subject: [Java] Mark the Yetus annotations dependency optional .. [Java] Mark the Yetus annotations dependency optional

[kudu-CR] KUDU-2191: Metadata Upgrade Tool

2018-04-19 Thread Hao Hao (Code Review)
Hello Tidy Bot, Alexey Serbin, Dan Burkert, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10075 to look at the new patch set (#4). Change subject: KUDU-2191: Metadata Upgrade Tool

[kudu-CR] build-support: add a nicer logger to python scripts

2018-04-19 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/10131 ) Change subject: build-support: add a nicer logger to python scripts .. Patch Set 2: Code-Review+2 (1 comment)

[kudu-CR] [Java] Mark the Yetus annotations dependency optional

2018-04-19 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/10095 ) Change subject: [Java] Mark the Yetus annotations dependency optional .. Patch Set 3: Code-Review+2 -- To view, visit

[kudu-CR] KUDU-2351 Add IP/port for Recv() failure

2018-04-19 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/9818 ) Change subject: KUDU-2351 Add IP/port for Recv() failure .. Patch Set 15: Failures look like they may be legit. -- To view, visit

[kudu-CR] KUDU-2412: Fix python client compilation in el6 environments

2018-04-19 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/10114 ) Change subject: KUDU-2412: Fix python client compilation in el6 environments .. Patch Set 1: (7 comments)

[kudu-CR] Modify fix includes.py for Kudu usage, add a wrapper

2018-04-19 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/10106 ) Change subject: Modify fix_includes.py for Kudu usage, add a wrapper .. Patch Set 2: (2 comments)

[kudu-CR] KUDU-2412: Fix python client compilation in el6 environments

2018-04-19 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/10114 ) Change subject: KUDU-2412: Fix python client compilation in el6 environments .. Patch Set 1: (2 comments)

[kudu-CR] KUDU-2412: Fix python client compilation in el6 environments

2018-04-19 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/10114 ) Change subject: KUDU-2412: Fix python client compilation in el6 environments .. Patch Set 1: (2 comments)

[kudu-CR] KUDU-2412: Fix python client compilation in el6 environments

2018-04-19 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/10114 ) Change subject: KUDU-2412: Fix python client compilation in el6 environments .. Patch Set 1: (2 comments)

[kudu-CR] [Java] Use Yetus annotations in place of @VisibleForTesting

2018-04-19 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/10077 ) Change subject: [Java] Use Yetus annotations in place of @VisibleForTesting .. Patch Set 7: Code-Review+2 (2 comments)

[kudu-CR] KUDU-2412: Fix python client compilation in el6 environments

2018-04-19 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/10114 ) Change subject: KUDU-2412: Fix python client compilation in el6 environments .. Patch Set 3: (4 comments)

[kudu-CR] Modify fix includes.py for Kudu usage, add a wrapper

2018-04-19 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/10106 ) Change subject: Modify fix_includes.py for Kudu usage, add a wrapper .. Patch Set 2: (3 comments)

[kudu-CR] KUDU-2351 Add IP/port for Recv() failure

2018-04-19 Thread Attila Bukor (Code Review)
Hello Tidy Bot, Dan Burkert, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9818 to look at the new patch set (#16). Change subject: KUDU-2351 Add IP/port for Recv() failure

[kudu-CR] KUDU-2351 Add IP/port for Recv() failure

2018-04-19 Thread Attila Bukor (Code Review)
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/9818 ) Change subject: KUDU-2351 Add IP/port for Recv() failure .. Patch Set 15: > Patch Set 15: > > Failures look like they may be legit.

[kudu-CR] KUDU-2191: Metadata Upgrade Tool

2018-04-19 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/10075 ) Change subject: KUDU-2191: Metadata Upgrade Tool .. Patch Set 3: > Build Failed > > http://jenkins.kudu.apache.org/job/kudu-gerrit/13030/

[kudu-CR] KUDU-2412: Fix python client compilation in el6 environments

2018-04-19 Thread Todd Lipcon (Code Review)
Todd Lipcon has uploaded a new patch set (#2) to the change originally created by Grant Henke. ( http://gerrit.cloudera.org:8080/10114 ) Change subject: KUDU-2412: Fix python client compilation in el6 environments .. KUDU-2412:

[kudu-CR] KUDU-2412: Fix python client compilation in el6 environments

2018-04-19 Thread Todd Lipcon (Code Review)
Todd Lipcon has uploaded a new patch set (#3) to the change originally created by Grant Henke. ( http://gerrit.cloudera.org:8080/10114 ) Change subject: KUDU-2412: Fix python client compilation in el6 environments .. KUDU-2412:

[kudu-CR] KUDU-2365: [Java] Fix Gradle Artifacts

2018-04-19 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/10097 ) Change subject: KUDU-2365: [Java] Fix Gradle Artifacts .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] KUDU-2412: Fix python client compilation in el6 environments

2018-04-19 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/10114 ) Change subject: KUDU-2412: Fix python client compilation in el6 environments .. Patch Set 3: tweaked this a bit: - seems that it's fine

[kudu-CR] [Java] Use Yetus annotations in place of @VisibleForTesting

2018-04-19 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/10077 ) Change subject: [Java] Use Yetus annotations in place of @VisibleForTesting .. Patch Set 7: Code-Review+1 -- To view, visit

[kudu-CR] KUDU-2351 Add IP/port for Recv() failure

2018-04-19 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/9818 ) Change subject: KUDU-2351 Add IP/port for Recv() failure .. Patch Set 14: (3 comments)

[kudu-CR] KUDU-2351 Add IP/port for Recv() failure

2018-04-19 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/9818 ) Change subject: KUDU-2351 Add IP/port for Recv() failure .. Patch Set 15: Code-Review+2 -- To view, visit

[kudu-CR] [Java] Fix Guava transitive dependecies

2018-04-19 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/10096 ) Change subject: [Java] Fix Guava transitive dependecies .. Patch Set 3: (2 comments)

[kudu-CR] KUDU-2351 Add IP/port for Recv() failure

2018-04-19 Thread Attila Bukor (Code Review)
Hello Tidy Bot, Dan Burkert, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9818 to look at the new patch set (#15). Change subject: KUDU-2351 Add IP/port for Recv() failure

[kudu-CR] KUDU-2351 Add IP/port for Recv() failure

2018-04-19 Thread Attila Bukor (Code Review)
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/9818 ) Change subject: KUDU-2351 Add IP/port for Recv() failure .. Patch Set 15: (2 comments)

[kudu-CR] [Java] Mark the Yetus annotations dependency optional

2018-04-19 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/10095 ) Change subject: [Java] Mark the Yetus annotations dependency optional .. Patch Set 3: Code-Review+1 -- To view, visit

[kudu-CR] Modify fix includes.py for Kudu usage, add a wrapper

2018-04-19 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/10106 ) Change subject: Modify fix_includes.py for Kudu usage, add a wrapper .. Patch Set 2: Code-Review+1 LGTM, but I suggest getting Adar or

[kudu-CR] [Java] Use Yetus annotations in place of @VisibleForTesting

2018-04-19 Thread Grant Henke (Code Review)
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10077 ) Change subject: [Java] Use Yetus annotations in place of @VisibleForTesting .. [Java] Use Yetus annotations in place of

[kudu-CR] [Java] Use Yetus annotations in place of @VisibleForTesting

2018-04-19 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/10077 ) Change subject: [Java] Use Yetus annotations in place of @VisibleForTesting .. Patch Set 7: (2 comments)

[kudu-CR] KUDU-2191: Metadata Upgrade Tool

2018-04-19 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/10075 ) Change subject: KUDU-2191: Metadata Upgrade Tool .. Patch Set 3: > Patch Set 3: > > > > Build Failed > > > > > >

[kudu-CR] KUDU-2191: Metadata Upgrade Tool

2018-04-19 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/10075 ) Change subject: KUDU-2191: Metadata Upgrade Tool .. Patch Set 3: (2 comments)

[kudu-CR] KUDU-2351 Add IP/port for Recv() failure

2018-04-19 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/9818 ) Change subject: KUDU-2351 Add IP/port for Recv() failure .. Patch Set 17: Code-Review+2 -- To view, visit

[kudu-CR] KUDU-2351 Add IP/port for Recv() failure

2018-04-19 Thread Dan Burkert (Code Review)
Dan Burkert has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9818 ) Change subject: KUDU-2351 Add IP/port for Recv() failure .. KUDU-2351 Add IP/port for Recv() failure Error messages like "Recv()

[kudu-CR] [Java] Remove ImmutableList use in kudu-spark

2018-04-19 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/10124 ) Change subject: [Java] Remove ImmutableList use in kudu-spark .. Patch Set 1: Verified+1 Adding verified +1 as the release build

[kudu-CR](branch-1.7.x) KUDU-2378. Fix unaligned loads of int128 from rows

2018-04-19 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/10110 ) Change subject: KUDU-2378. Fix unaligned loads of int128 from rows .. Patch Set 1: Code-Review+2 Any idea why this isn't building

[kudu-CR] [Java] Remove ImmutableList use in kudu-spark

2018-04-19 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/10124 ) Change subject: [Java] Remove ImmutableList use in kudu-spark .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR](branch-1.7.x) KUDU-2378. Fix unaligned loads of int128 from rows

2018-04-19 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/10110 ) Change subject: KUDU-2378. Fix unaligned loads of int128 from rows .. Patch Set 1: Yeah it's the old thirdparty issue. Not sure if

[kudu-CR] KUDU-2412: Fix python client compilation in el6 environments

2018-04-19 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/10114 ) Change subject: KUDU-2412: Fix python client compilation in el6 environments .. Patch Set 2: (1 comment) Grant, you want to finish

[kudu-CR] [Java] Use Yetus annotations in place of @VisibleForTesting

2018-04-19 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/10077 ) Change subject: [Java] Use Yetus annotations in place of @VisibleForTesting .. Patch Set 7: (1 comment)

[kudu-CR] KUDU-2368 Configure num reactors in client

2018-04-19 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/10115 ) Change subject: KUDU-2368 Configure num_reactors in client .. Patch Set 1: (2 comments)

[kudu-CR] KUDU-2368 Configure num reactors in client

2018-04-19 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/10115 ) Change subject: KUDU-2368 Configure num_reactors in client .. Patch Set 1: (1 comment)

[kudu-CR] KUDU-2191: Metadata Upgrade Tool

2018-04-19 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/10075 ) Change subject: KUDU-2191: Metadata Upgrade Tool .. Patch Set 3: > > Build Failed > > > >

[kudu-CR] [Java] Remove ImmutableList use in kudu-spark

2018-04-19 Thread Grant Henke (Code Review)
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10124 ) Change subject: [Java] Remove ImmutableList use in kudu-spark .. [Java] Remove ImmutableList use in kudu-spark This is

[kudu-CR] KUDU-2351 Add IP/port for Recv() failure

2018-04-19 Thread Attila Bukor (Code Review)
Hello Tidy Bot, Dan Burkert, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9818 to look at the new patch set (#17). Change subject: KUDU-2351 Add IP/port for Recv() failure

[kudu-CR] [Java] Mark the Yetus annotations dependency optional

2018-04-19 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/10095 ) Change subject: [Java] Mark the Yetus annotations dependency optional .. Patch Set 4: Code-Review+2 -- To view, visit

[kudu-CR] [Java] Remove ImmutableList use in kudu-spark

2018-04-19 Thread Grant Henke (Code Review)
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10124 Change subject: [Java] Remove ImmutableList use in kudu-spark .. [Java] Remove ImmutableList use in kudu-spark This is currently

[kudu-CR] [iwyu] minor cleanup after LLVM/IWYU update

2018-04-19 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10130 Change subject: [iwyu] minor cleanup after LLVM/IWYU update .. [iwyu] minor cleanup after LLVM/IWYU update It seems IWYU started

[kudu-CR] [iwyu] minor cleanup after LLVM/IWYU update

2018-04-19 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/10130 ) Change subject: [iwyu] minor cleanup after LLVM/IWYU update .. Patch Set 1: Code-Review+2 (1 comment)

[kudu-CR] build-support: add a nicer logger to python scripts

2018-04-19 Thread Todd Lipcon (Code Review)
Hello Alexey Serbin, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/10131 to review the following change. Change subject: build-support: add a nicer logger to python scripts ..

[kudu-CR] Modify fix includes.py for Kudu usage, add a wrapper

2018-04-19 Thread Todd Lipcon (Code Review)
Hello Alexey Serbin, Dan Burkert, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10106 to look at the new patch set (#3). Change subject: Modify fix_includes.py for Kudu usage, add a wrapper

[kudu-CR] KUDU-2368 Configure num reactors in client

2018-04-19 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/10115 ) Change subject: KUDU-2368 Configure num_reactors in client .. Patch Set 1: (3 comments)

[kudu-CR] Modify fix includes.py for Kudu usage, add a wrapper

2018-04-19 Thread Todd Lipcon (Code Review)
Hello Alexey Serbin, Dan Burkert, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10106 to look at the new patch set (#4). Change subject: Modify fix_includes.py for Kudu usage, add a wrapper

[kudu-CR] Modify fix includes.py for Kudu usage, add a wrapper

2018-04-19 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/10106 ) Change subject: Modify fix_includes.py for Kudu usage, add a wrapper .. Patch Set 3: (2 comments)

[kudu-CR] Modify fix includes.py for Kudu usage, add a wrapper

2018-04-19 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/10106 ) Change subject: Modify fix_includes.py for Kudu usage, add a wrapper .. Patch Set 3: (10 comments)

[kudu-CR] [iwyu] minor cleanup after LLVM/IWYU update

2018-04-19 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10130 to look at the new patch set (#2). Change subject: [iwyu] minor cleanup after LLVM/IWYU update ..

[kudu-CR] build-support: add a nicer logger to python scripts

2018-04-19 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/10131 ) Change subject: build-support: add a nicer logger to python scripts .. Patch Set 2: (1 comment) Ah, that's nice. I have one