Re: 7.0.6 plans

2011-01-04 Thread Rainer Jung
On 03.01.2011 17:49, Mark Thomas wrote: Hope everyone had a good holiday. Thanks, hope you had good holidays too! I think it is time for another 7.0.x release. I'll start going through the open bugs this week and depending on how long that takes probably get to the point where 7.0.6 is

Re: Time for 6.0.30?

2011-01-04 Thread Rainer Jung
On 04.01.2011 11:44, Mark Thomas wrote: It has been a while since 6.0.29 and there have been a few requests for this on the users list. Jean-Frederic, do you have any plans for 6.0.30 at this point? I think a 6.0.30 is kind of overdue. If Jean-Frederic can't start the release process during

Re: svn commit: r1055776 - /tomcat/native/branches/1.1.x/xdocs/miscellaneous/changelog.xml

2011-01-06 Thread Rainer Jung
On 06.01.2011 08:42, jfcl...@apache.org wrote: Author: jfclere Date: Thu Jan 6 07:42:48 2011 New Revision: 1055776 URL: http://svn.apache.org/viewvc?rev=1055776view=rev Log: Add missing information. Modified: tomcat/native/branches/1.1.x/xdocs/miscellaneous/changelog.xml Modified:

Re: DO NOT REPLY [Bug 50333] IllegalArgumentException occurs when setting maxActive to smaller than 1.

2011-01-10 Thread Rainer Jung
Hi Filip, On 10.01.2011 17:41, bugzi...@apache.org wrote: https://issues.apache.org/bugzilla/show_bug.cgi?id=50333 Filip Hanikfha...@apache.org changed: What|Removed |Added

Re: [VOTE] Release build 6.0.30

2011-01-12 Thread Rainer Jung
On 10.01.2011 18:18, jean-frederic clere wrote: The candidates binaries are available here: http://people.apache.org/~jfclere/tomcat-6/v6.0.30/ According to the release process, the 6.0.30 build corresponding to the tag TOMCAT_6_0_30 is: [ ] Broken [ ] Alpha [ ] Beta [X] Stable - MD5 OK -

Re: [VOTE] Release Apache Tomcat 7.0.6

2011-01-12 Thread Rainer Jung
On 10.01.2011 19:54, Mark Thomas wrote: The proposed Apache Tomcat 7.0.6 release is now available for voting. It can be obtained from: http://people.apache.org/~markt/dev/tomcat-7/v7.0.6/ The svn tag is: http://svn.apache.org/repos/asf/tomcat/tc7.0.x/tags/TOMCAT_7_0_6/ The proposed 7.0.6

Re: DO NOT REPLY [Bug 22405] warn if not deploy with umask 0077 or if deployed as root and provide tutorial URL Secure deployment

2011-01-19 Thread Rainer Jung
On 19.01.2011 20:00, Mark Thomas wrote: On 19/01/2011 18:53, Ian Darwin wrote: On 01/19/11 13:47, Mark Thomas wrote: On 19/01/2011 18:45, bugzi...@apache.org wrote: https://issues.apache.org/bugzilla/show_bug.cgi?id=22405 --- Comment #5 from Mark Thomasma...@apache.org 2011-01-19 13:45:40

Re: Tomcat 7.0.x. still CTR?

2011-01-19 Thread Rainer Jung
On 19.01.2011 18:23, Filip Hanik - Dev Lists wrote: I'd prefer to stay CTR for a while. Chances are there are still much to be fixed given all the changes that have taken place. +1 On 1/18/2011 11:41 AM, Christopher Schultz wrote: All, Since Tomcat 7.0.x went stable, does that change the

Re: [VOTE] Release build 6.0.31

2011-01-27 Thread Rainer Jung
On 24.01.2011 22:51, jean-frederic clere wrote: The candidates binaries are available here: http://people.apache.org/~jfclere/tomcat-6/v6.0.31/ According to the release process, the 6.0.31 build corresponding to the tag TOMCAT_6_0_31 is: [ ] Broken [ ] Alpha [ ] Beta [X] Stable - MD5 OK -

Re: [VOTE] Release Tomcat 5.5.32 Build

2011-01-28 Thread Rainer Jung
On 22.01.2011 19:01, Jim Jagielski wrote: The builds for Tomcat 5.5.32 are ready for testing and approval. The candidates binaries are available here: http://people.apache.org/~jim/tomcat-5.5/ According to the release process, the 5.5.32 build corresponding to the tag TOMCAT_5_5_32 [1] is:

Re: [VOTE] Release build 6.0.31

2011-01-28 Thread Rainer Jung
On 27.01.2011 21:39, Konstantin Kolinko wrote: 2011/1/27 jean-frederic clerejfcl...@gmail.com: On 01/27/2011 10:30 AM, Konstantin Kolinko wrote: 2011/1/25 jean-frederic clerejfcl...@gmail.com: The candidates binaries are available here: http://people.apache.org/~jfclere/tomcat-6/v6.0.31/

Re: svn commit: r1065767 - in /tomcat/sandbox/tomcat-oacc/trunk: docs/changelog.xml src/share/org/apache/catalina/cluster/session/DeltaManager.java

2011-02-01 Thread Rainer Jung
On 01.02.2011 02:05, sebb wrote: On 31 January 2011 20:45,rj...@apache.org wrote: Author: rjung Date: Mon Jan 31 20:45:31 2011 New Revision: 1065767 URL: http://svn.apache.org/viewvc?rev=1065767view=rev Log: Add session creation / expiration rate statistics to the session managers. Backport

Re: Tagging 7.0.7

2011-02-02 Thread Rainer Jung
+1 On 02.02.2011 16:53, Konstantin Kolinko wrote: 2011/2/2 Mark Thomasma...@apache.org: I'd like to stick to my plan to release Tomcat 7 every month or so. The last release was ~ 3 weeks ago so that suggests next week. However, I have some commitments next week that would make tagging and

Re: [VOTE] Release build 6.0.32

2011-02-02 Thread Rainer Jung
On 02.02.2011 20:37, jean-frederic clere wrote: The candidates binaries are available here: http://people.apache.org/~jfclere/tomcat-6/v6.0.32/ According to the release process, the 6.0.32 build corresponding to the tag TOMCAT_6_0_32 is: [ ] Broken [ ] Alpha [ ] Beta [X] Stable - MD5 OK -

Re: [VOTE] Release Apache Tomcat 7.0.7

2011-02-03 Thread Rainer Jung
On 03.02.2011 14:32, Mark Thomas wrote: The proposed Apache Tomcat 7.0.7 release is now available for voting. It can be obtained from: http://people.apache.org/~markt/dev/tomcat-7/v7.0.7/ The svn tag is: http://svn.apache.org/repos/asf/tomcat/tc7.0.x/tags/TOMCAT_7_0_7/ The proposed 7.0.7

Re: [VOTE] Release Apache Tomcat 7.0.8

2011-02-05 Thread Rainer Jung
On 04.02.2011 14:52, Mark Thomas wrote: The proposed Apache Tomcat 7.0.8 release is now available for voting. It can be obtained from: http://people.apache.org/~markt/dev/tomcat-7/v7.0.8/ The svn tag is: http://svn.apache.org/repos/asf/tomcat/tc7.0.x/tags/TOMCAT_7_0_8/ The proposed 7.0.8

Re: [VOTE] Release Tomcat 5.5.33 Build

2011-02-07 Thread Rainer Jung
On 07.02.2011 21:17, Jim Jagielski wrote: The builds for Tomcat 5.5.33 are ready for testing and approval. The candidates binaries are available here: http://people.apache.org/~jim/tomcat-5.5/ According to the release process, the 5.5.33 build corresponding to the tag TOMCAT_5_5_33 [1] is: [

Re: [VOTE] Release Tomcat 5.5.33 Build

2011-02-07 Thread Rainer Jung
On 07.02.2011 21:17, Jim Jagielski wrote: The builds for Tomcat 5.5.33 are ready for testing and approval. The candidates binaries are available here: http://people.apache.org/~jim/tomcat-5.5/ According to the release process, the 5.5.33 build corresponding to the tag TOMCAT_5_5_33 [1] is: [

Re: [VOTE] Release Tomcat 5.5.33 Build

2011-02-08 Thread Rainer Jung
On 07.02.2011 21:17, Jim Jagielski wrote: The builds for Tomcat 5.5.33 are ready for testing and approval. The candidates binaries are available here: http://people.apache.org/~jim/tomcat-5.5/ According to the release process, the 5.5.33 build corresponding to the tag TOMCAT_5_5_33 [1] is: [

Connection draining when upload to large

2011-02-10 Thread Rainer Jung
Servlet 3 standardizes file uploads. It contains the ability to limit on request size, pretty much the same as commons fileupload supported for many years. It seems when this conditions triggers the rest of the request inout stream is still drained at the end of the request. swallowInput is

Re: Connection draining when upload to large

2011-02-11 Thread Rainer Jung
On 10.02.2011 18:00, Filip Hanik - Dev Lists wrote: On 2/10/2011 6:04 AM, Rainer Jung wrote: Servlet 3 standardizes file uploads. It contains the ability to limit on request size, pretty much the same as commons fileupload supported for many years. It seems when this conditions triggers

Re: Connection draining when upload to large

2011-02-17 Thread Rainer Jung
On 10.02.2011 18:44, Mark Thomas wrote: On 10/02/2011 13:04, Rainer Jung wrote: Servlet 3 standardizes file uploads. It contains the ability to limit on request size, pretty much the same as commons fileupload supported for many years. It seems when this conditions triggers the rest

Re: Connection draining when upload to large

2011-02-17 Thread Rainer Jung
On 17.02.2011 11:58, Mark Thomas wrote: On 17/02/2011 10:41, Mark Thomas wrote: On 17/02/2011 10:30, Rainer Jung wrote: On 10.02.2011 18:44, Mark Thomas wrote: On 10/02/2011 13:04, Rainer Jung wrote: Servlet 3 standardizes file uploads. It contains the ability to limit on request size

Test suite failures for TC 7 (MBeanUtils, host null)

2011-02-17 Thread Rainer Jung
I get test suite failures for TC 7 right now. I'm not sure whether it is because I changed my testing environment, but the failure seems to be pretty special, namely a NullPointerException in MBeanUtils.createObjectName() line 532. I added some logging and the reason is, that the host

Re: Response.getWriter(), getOutputStream(), setContentLength() spec issues

2011-02-27 Thread Rainer Jung
On 25.02.2011 13:01, Mark Thomas wrote: So, the questions we need to decide: 1. Is the fix for bug 50748 correct? I think it is. +0 2. Should Tomcat try and handle this situation (e.g. if any bytes have been written by a filter, commit the response). This could be tricky to get right when

Re: Connection draining when upload to large

2011-03-03 Thread Rainer Jung
On 17.02.2011 11:58, Mark Thomas wrote: Given this, I am leaning even more towards just fixing the original issue that the connection is not dropped when the request exceeds the upload limit and leaving the rest of the behaviour unchanged. Getting back to this (and sorry for the pause): What's

Re: [VOTE] Release Apache Tomcat 7.0.10

2011-03-06 Thread Rainer Jung
On 05.03.2011 15:32, Mark Thomas wrote: The proposed Apache Tomcat 7.0.10 release is now available for voting. It can be obtained from: http://people.apache.org/~markt/dev/tomcat-7/v7.0.10/ The svn tag is: http://svn.apache.org/repos/asf/tomcat/tc7.0.x/tags/TOMCAT_7_0_10/ The proposed 7.0.10

Re: svn commit: r1078805 - in /tomcat/jk/trunk: native/apache-1.3/ native/apache-2.0/ native/common/ native/iis/ native/netscape/ xdocs/generic_howto/ xdocs/miscellaneous/ xdocs/reference/

2011-03-07 Thread Rainer Jung
On 07.03.2011 22:56, Konstantin Kolinko wrote: 2011/3/7rj...@apache.org: In jk_nsapi_plugin.c: --- tomcat/jk/trunk/native/iis/jk_isapi_plugin.c (original) +++ tomcat/jk/trunk/native/iis/jk_isapi_plugin.c Mon Mar 7 15:17:11 2011 @@ -3011,7 +3011,7 @@ static int init_ws_service(isapi_private

Re: svn commit: r1079444 - in /tomcat/trunk: java/org/apache/catalina/ java/org/apache/catalina/connector/ java/org/apache/catalina/core/ java/org/apache/coyote/ java/org/apache/coyote/ajp/ java/org/

2011-03-08 Thread Rainer Jung
On 08.03.2011 22:09, sebb wrote: On 8 March 2011 17:18,rj...@apache.org wrote: Author: rjung Date: Tue Mar 8 17:18:16 2011 New Revision: 1079444 URL: http://svn.apache.org/viewvc?rev=1079444view=rev Log: New context attribute swallowAbortedUploads allows to make request data swallowing

Re: svn commit: r1079444 - in /tomcat/trunk: java/org/apache/catalina/ java/org/apache/catalina/connector/ java/org/apache/catalina/core/ java/org/apache/coyote/ java/org/apache/coyote/ajp/ java/org/

2011-03-08 Thread Rainer Jung
On 08.03.2011 23:37, Mark Thomas wrote: On 08/03/2011 17:18, rj...@apache.org wrote: snip/ Modified: tomcat/trunk/java/org/apache/catalina/connector/Request.java URL:

Some remarks and observations from implementing disable swallowAbortedUploads

2011-03-08 Thread Rainer Jung
Hi all, some things I noticed while implementing the new switch: - o.a.c.connector.Request and Response hav methods finishRequest() resp. finishResponse(). The mehod in the request seems not to be called. Although that's not a big issue, because the omplementation is empty, one would run

Re: Some remarks and observations from implementing disable swallowAbortedUploads

2011-03-09 Thread Rainer Jung
On 09.03.2011 14:46, Mark Thomas wrote: On 09/03/2011 05:41, Rainer Jung wrote: Hi all, some things I noticed while implementing the new switch: - o.a.c.connector.Request and Response hav methods finishRequest() resp. finishResponse(). The mehod in the request seems not to be called. Although

Re: [VOTE] Release Apache Tomcat 7.0.11

2011-03-11 Thread Rainer Jung
On 10.03.2011 13:03, Mark Thomas wrote: The proposed Apache Tomcat 7.0.11 release is now available for voting. It can be obtained from: http://people.apache.org/~markt/dev/tomcat-7/v7.0.11/ The svn tag is: http://svn.apache.org/repos/asf/tomcat/tc7.0.x/tags/TOMCAT_7_0_11/ The proposed 7.0.11

Re: [GUMP@vmgump]: Project tomcat-trunk-test (in module tomcat-trunk) failed

2011-04-03 Thread Rainer Jung
On 02.04.2011 01:20, Konstantin Kolinko wrote: 2011/4/1 Konstantin Kolinkoknst.koli...@gmail.com: In the recent run: [junit] Apr 1, 2011 9:53:27 PM org.apache.catalina.util.SessionIdGenerator createSecureRandom [junit] INFO: Creation of SecureRandom instance fo [junit] r session

Re: [VOTE] Release Apache Tomcat 7.0.12

2011-04-03 Thread Rainer Jung
On 01.04.2011 20:09, Mark Thomas wrote: The proposed Apache Tomcat 7.0.12 release is now available for voting. It can be obtained from: http://people.apache.org/~markt/dev/tomcat-7/v7.0.12/ The svn tag is: http://svn.apache.org/repos/asf/tomcat/tc7.0.x/tags/TOMCAT_7_0_12/ The proposed 7.0.12

Re: [GUMP@vmgump]: Project tomcat-trunk-test (in module tomcat-trunk) failed

2011-04-04 Thread Rainer Jung
On 04.04.2011 11:34, Stefan Bodewig wrote: On 2011-04-03, Rainer Jung wrote: On 02.04.2011 01:20, Konstantin Kolinko wrote: 2011/4/1 Konstantin Kolinkoknst.koli...@gmail.com: In the recent run: [junit] Apr 1, 2011 9:53:27 PM org.apache.catalina.util.SessionIdGenerator

Re: anyone using git-svn for tomcat ?

2011-04-07 Thread Rainer Jung
On 07.04.2011 22:35, Sylvain Laurent wrote: Hello, I'm trying out git at the moment and found this page http://wiki.apache.org/general/GitAtApache Is anyone here using git in front of svn ? any problem, advice ? I used it some time for the httpd sources. I like that it is easy to transfer

Re: New connector sandbox

2011-04-26 Thread Rainer Jung
On 11.04.2011 11:34, Mladen Turk wrote: On 04/11/2011 09:00 AM, Konstantin Kolinko wrote: 2011/4/11 Mladen Turkmt...@apache.org: Hi, I plan to create a sandbox/connectors/native/iis7 for a native IIS7 C++ connector (since Microsoft deprecated ISAPI) Any objections? I do not mind. Though

Re: New connector sandbox

2011-04-27 Thread Rainer Jung
On 27.04.2011 08:53, Henri Gomez wrote: Now that HTTP connector is as fast as AJP connector, is it still required ? Performance isn't a reasion for AJP in the last say 5 or more years. The major benefits of AJP are - smooth integration of a reverse proxy The connector patches the

MIME type additions

2011-04-29 Thread Rainer Jung
We recently had some mime type additions, and the new BZ 51137 asks for more. I did some checking between the mime type file of httpd 2.3 latest and TC. There are about 600 more mime types in the httpd file, some of them with more than one suffix. Some entries are inconsistent between the two

Re: BIO performance issues

2011-05-04 Thread Rainer Jung
I hope the following is not too long and confusing ... On 03.05.2011 22:02, Mark Thomas wrote: Scenario This ended up being very long, so I moved it to the end. The exact pattern of delays will vary depending on timeouts, request frequency etc. but the scenario shows an example of how

Re: [VOTE] Release Apache Tomcat 7.0.13

2011-05-07 Thread Rainer Jung
On 06.05.2011 17:37, Mark Thomas wrote: The proposed Apache Tomcat 7.0.13 release is now available for voting. It can be obtained from: http://people.apache.org/~markt/dev/tomcat-7/v7.0.13/ The svn tag is: http://svn.apache.org/repos/asf/tomcat/tc7.0.x/tags/TOMCAT_7_0_13/ The proposed 7.0.13

Re: svn commit: r1099032 - in /tomcat/trunk/res/scripts: ./ check-mime.pl

2011-05-08 Thread Rainer Jung
Hi Felix, TMTOWTDI. For standalone scripts I don't care very much about style. Let's see below ... On 08.05.2011 13:17, Felix Schumacher wrote: Hi Rainer, Am Dienstag, den 03.05.2011, 12:12 + schrieb rj...@apache.org: Author: rjung Date: Tue May 3 12:12:35 2011 New Revision: 1099032

Re: [VOTE] Release Apache Tomcat 7.0.14

2011-05-10 Thread Rainer Jung
On 10.05.2011 01:31, Mark Thomas wrote: The proposed Apache Tomcat 7.0.14 release is now available for voting. It can be obtained from: http://people.apache.org/~markt/dev/tomcat-7/v7.0.14/ The svn tag is: http://svn.apache.org/repos/asf/tomcat/tc7.0.x/tags/TOMCAT_7_0_14/ The proposed 7.0.14

Re: [VOTE] Release Apache Tomcat 7.0.14

2011-05-10 Thread Rainer Jung
On 10.05.2011 20:11, Mark Thomas wrote: On 10/05/2011 18:46, Rainer Jung wrote: On 10.05.2011 01:31, Mark Thomas wrote: The proposed Apache Tomcat 7.0.14 release is now available for voting. It can be obtained from: http://people.apache.org/~markt/dev/tomcat-7/v7.0.14/ The svn tag is: http

Re: [VOTE] Release Apache Tomcat 7.0.14

2011-05-10 Thread Rainer Jung
On 10.05.2011 21:32, Rainer Jung wrote: On 10.05.2011 20:11, Mark Thomas wrote: On 10/05/2011 18:46, Rainer Jung wrote: On 10.05.2011 01:31, Mark Thomas wrote: The proposed Apache Tomcat 7.0.14 release is now available for voting. It can be obtained from: http://people.apache.org/~markt/dev

Re: svn commit: r1104422 - in /tomcat/trunk/webapps/docs: changelog.xml config/ajp.xml

2011-05-17 Thread Rainer Jung
On 17.05.2011 19:24, ma...@apache.org wrote: Author: markt Date: Tue May 17 17:24:36 2011 New Revision: 1104422 URL: http://svn.apache.org/viewvc?rev=1104422view=rev Log: Add remaining attributes to documentation AJP-NIO now passes Servlet TCK - remove experimental label w00t!

Re: [PROPOSAL] Move to svnpubsub for /dist/tomcat

2011-05-18 Thread Rainer Jung
+1 to Marks proposal. Shot additional answer to Konstantin inline. On 18.05.2011 16:43, Konstantin Kolinko wrote: Will the commit messages be forwarded to the mailing list? At least the web server project does it like that. For an example see

mod_jk 1.2.32 [was: Re: svn commit: r1127315 - /tomcat/jk/trunk/xdocs/reference/apache.xml]

2011-05-26 Thread Rainer Jung
On 25.05.2011 00:15, Christopher Schultz wrote: All, I'm not sure what the policy is on documentation changes and back-porting to already-released versions of mod_jk, but this clarifies how mod_jk works and would be beneficial to have on the web site without having to wait for a new release

Re: [PROPOSAL] Move to svnpubsub for /dist/tomcat

2011-05-26 Thread Rainer Jung
On 24.05.2011 22:19, Mark Thomas wrote: On 24/05/2011 20:24, Konstantin Kolinko wrote: 2011/5/24 Mark Thomas ma...@apache.org: 1. In what repository will the artifacts go? IIRC, there is some additional repository. I think it wouldn't be good to have them in /repos/asf/ There is a separate

Re: mod_jk 1.2.32 [was: Re: svn commit: r1127315 - /tomcat/jk/trunk/xdocs/reference/apache.xml]

2011-05-26 Thread Rainer Jung
On 26.05.2011 15:36, Christopher Schultz wrote: Rainer, On 5/26/2011 5:06 AM, Rainer Jung wrote: There are enough changes for a 1.2.32 anyhow, so I would propose we start a new release cycle in about 2 weeks. Sounds great. Someone looking at the IPV6 patch (BZ 43968)? Rainer

Re: svn commit: r1132362 - in /tomcat/trunk/java/org/apache/coyote/http11: AbstractHttp11Processor.java Http11AprProcessor.java Http11NioProcessor.java Http11Processor.java

2011-06-05 Thread Rainer Jung
Hi Mark, On 05.06.2011 12:06, ma...@apache.org wrote: Modified: tomcat/trunk/java/org/apache/coyote/http11/AbstractHttp11Processor.java URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/coyote/http11/AbstractHttp11Processor.java?rev=1132362r1=1132361r2=1132362view=diff

Re: [VOTE] Release Apache Tomcat 7.0.15

2011-06-05 Thread Rainer Jung
Not a vote yet: I get a test failure: Testcase: testWelcomeFileStrict took 0.005 sec Caused an ERROR Forked Java VM exited abnormally. Please note the time in the report does not reflect the time until the VM exit. junit.framework.AssertionFailedError: Forked Java VM exited abnormally.

Re: [VOTE] Release Apache Tomcat 7.0.15

2011-06-05 Thread Rainer Jung
Not a vote yet: I get a test failure: Testcase: testWelcomeFileStrict took 0.005 sec Caused an ERROR Forked Java VM exited abnormally. Please note the time in the report does not reflect the time until the VM exit. junit.framework.AssertionFailedError: Forked Java VM exited abnormally.

Re: svn commit: r1132362 - in /tomcat/trunk/java/org/apache/coyote/http11: AbstractHttp11Processor.java Http11AprProcessor.java Http11NioProcessor.java Http11Processor.java

2011-06-05 Thread Rainer Jung
+for (int i = valueL - 1; i colonPos; i--) { +int charValue = HexUtils.getDec(valueB[i + valueS]); Any idea, why hex digits (including a-f, A-F) are allowed in port numbers? I know you only moved that code, but it reminded me of an observation I made long ago

Re: [PROPOSAL] Enable session replication by default.

2011-06-07 Thread Rainer Jung
On 07.06.2011 21:39, Mark Thomas wrote: On 07/06/2011 20:24, Jess Holle wrote: web apps whose web.xml does not specify distributable should certainly not be treated as such -- that would be a spec violation and break lots of web apps. How many times do I have to write this? This is NOT what

Re: [VOTE] Release Apache Tomcat 7.0.15

2011-06-07 Thread Rainer Jung
failing little TC test to investigate the APR problem :) Regards, Rainer On 05.06.2011 18:33, Rainer Jung wrote: Not a vote yet: I get a test failure: Testcase: testWelcomeFileStrict took 0.005 sec Caused an ERROR Forked Java VM exited abnormally. Please note the time in the report

Re: svn commit: r1134063 - /tomcat/trunk/java/org/apache/coyote/AsyncStateMachine.java

2011-06-10 Thread Rainer Jung
I like it :) On 09.06.2011 22:10, ma...@apache.org wrote: Author: markt Date: Thu Jun 9 20:10:23 2011 New Revision: 1134063 URL: http://svn.apache.org/viewvc?rev=1134063view=rev Log: Document the state transition diagram Modified:

Outdated Maven Info in TC 7 docs

2011-06-12 Thread Rainer Jung
Our docs page about Tomcat Maven artefacts http://tomcat.apache.org/tomcat-7.0-doc/maven-jars.html seems outdated. The staging repository linked there doesn't contain anything after 7.0.2. The text below the link indicates something about switching to the ASF main repos, but I think we could be

Re: svn commit: r1134965 - in /tomcat/trunk/webapps/docs: changelog.xml maven-jars.xml

2011-06-12 Thread Rainer Jung
Thanks Mark. I had put my new changelog entry into the Coyote section. Maybe that's not optimal for your Maven entry, which seems to be more like General. Regards, Rainer On 12.06.2011 21:28, ma...@apache.org wrote: Author: markt Date: Sun Jun 12 19:28:17 2011 New Revision: 1134965 URL:

Crash in APR when pausing endpoint

2011-06-13 Thread Rainer Jung
I had some spare time for analyzing the crashes in TestMapperWelcomeFiles. It seems there are several varieties, but at least I do now understand enough to report here: In Http11AprProcessor.process() when parsing the request line fails, e.g. it is not yet there, we add the socket back to the

Re: Crash in APR when pausing endpoint

2011-06-13 Thread Rainer Jung
On 13.06.2011 17:49, Mark Thomas wrote: On 13/06/2011 16:07, Rainer Jung wrote: I had some spare time for analyzing the crashes in TestMapperWelcomeFiles. It seems there are several varieties, but at least I do now understand enough to report here: ... This seems to be a flaw. I suggest we

Re: [VOTE] Release Apache Tomcat 7.0.16

2011-06-14 Thread Rainer Jung
On 11.06.2011 13:33, Mark Thomas wrote: The proposed 7.0.16 release is: [ ] Broken - do not release [ ] Alpha - go ahead and release as 7.0.16 Alpha [ ] Beta - go ahead and release as 7.0.16 Beta [X] Stable - go ahead and release as 7.0.16 Stable +1 for stable. - MD5 OK - signatures OK

Re: [GUMP@vmgump]: Project tomcat-trunk-test (in module tomcat-trunk) failed

2011-06-15 Thread Rainer Jung
On 15.06.2011 14:49, Mark Thomas wrote: On 15/06/2011 13:29, Konstantin Kolinko wrote: The failure happened in [junit] Test org.apache.catalina.core.TestAsyncContextImpl FAILED when running with NIO. Running the same test with BIO was OK. The log file from the test is [1]. [1]:

Re: [GUMP@vmgump]: Project tomcat-trunk-test (in module tomcat-trunk) failed

2011-06-15 Thread Rainer Jung
On 15.06.2011 14:49, Mark Thomas wrote: On 15/06/2011 13:29, Konstantin Kolinko wrote: The failure happened in [junit] Test org.apache.catalina.core.TestAsyncContextImpl FAILED when running with NIO. Running the same test with BIO was OK. The log file from the test is [1]. [1]:

Re: Questions about the ajp1.3 connector

2011-06-17 Thread Rainer Jung
On 15.06.2011 08:18, 姚伟斌 wrote: Hi, folks, I have some questions about the ajp1.3 connector. Is there any other official document for ajp1.3 connector? This url ( http://tomcat.apache.org/connectors-doc/ajp/ajpv13a.html) seems lack of something. No, that is the official protocol

Current test failures for APR

2011-06-19 Thread Rainer Jung
Notice: currently I get test failures when testing APR. Just in caes someone else is also wondering - you are not alone :) org.apache.catalina.connector.TestCoyoteAdapter crash in testPathParmsFooSessionValue (jni Socker recvbb) org.apache.catalina.connector.TestKeepAliveCount

Re: Current test failures for APR

2011-06-19 Thread Rainer Jung
Current assumption: Fixed by r1137372. It'll take some time until I have seen enough passing tests. Will report back. Regards, Rainer On 19.06.2011 14:52, Rainer Jung wrote: Notice: currently I get test failures when testing APR. Just in caes someone else is also wondering - you are not alone

Re: Current test failures for APR

2011-06-19 Thread Rainer Jung
On 19.06.2011 16:36, Rainer Jung wrote: Current assumption: Fixed by r1137372. It'll take some time until I have seen enough passing tests. Will report back. 5 runs through the test suite later it looks good now (pre r1137375). Regards, Rainer

Using eval vs. exec in shell scripts

2011-06-20 Thread Rainer Jung
Since Mladens change r918873 in March 2010 we use eval instead of exec in the shell scripts. The svn log says: Use eval instead direct call or exec command so that arguments with spaces are properly handled Eval leaves a copy of the shell process hanging around until Tomcat shutdown. I want to

Overhauling setclasspath.(bat|sh)?

2011-06-20 Thread Rainer Jung
1) Renaming Since quite some time now the setclasspath script doesn't have anything to do with setting a class path. It only searches for JRE / JDK and sets up the path to the Java or JDB binary plus JAVA_ENDORSED_DIRS. So it would be more correct to call it checkjava.sh or setupjava.sh or

Re: Using eval vs. exec in shell scripts

2011-06-20 Thread Rainer Jung
On 20.06.2011 14:52, Mladen Turk wrote: On 06/20/2011 01:39 PM, Rainer Jung wrote: Since Mladens change r918873 in March 2010 we use eval instead of exec in the shell scripts. The svn log says: Use eval instead direct call or exec command so that arguments with spaces are properly handled

Re: Overhauling setclasspath.(bat|sh)?

2011-06-20 Thread Rainer Jung
On 20.06.2011 14:54, Leon Rosenberg wrote: On Mon, Jun 20, 2011 at 2:50 PM, Rainer Jung rainer.j...@kippdata.de wrote: 1) Renaming Since quite some time now the setclasspath script doesn't have anything to do with setting a class path. It only searches for JRE / JDK and sets up the path

Re: svn commit: r1137607 - /tomcat/trunk/bin/catalina.sh

2011-06-20 Thread Rainer Jung
On 20.06.2011 14:56, Mladen Turk wrote: On 06/20/2011 02:37 PM, rj...@apache.org wrote: Author: rjung Date: Mon Jun 20 12:37:01 2011 New Revision: 1137607 URL: http://svn.apache.org/viewvc?rev=1137607view=rev Log: Slight improvement of configtest handling in Unix shell script: - add to

Re: svn commit: r1137607 - /tomcat/trunk/bin/catalina.sh

2011-06-20 Thread Rainer Jung
On 20.06.2011 14:56, Mladen Turk wrote: On 06/20/2011 02:37 PM, rj...@apache.org wrote: Author: rjung Date: Mon Jun 20 12:37:01 2011 New Revision: 1137607 URL: http://svn.apache.org/viewvc?rev=1137607view=rev Log: Slight improvement of configtest handling in Unix shell script: - add to

Re: svn commit: r1137607 - /tomcat/trunk/bin/catalina.sh

2011-06-20 Thread Rainer Jung
On 20.06.2011 15:41, Mladen Turk wrote: On 06/20/2011 03:28 PM, Mark Thomas wrote: On 20/06/2011 14:21, Mladen Turk wrote: Just don't see what was the problem with that option that would require it to go away. This wasn't discussed on the dev list so if I weren't tracking the svn commits it

Re: svn commit: r1137607 - /tomcat/trunk/bin/catalina.sh

2011-06-20 Thread Rainer Jung
On 20.06.2011 16:06, Mladen Turk wrote: On 06/20/2011 03:53 PM, Rainer Jung wrote: On 20.06.2011 15:41, Mladen Turk wrote: In general all commands except those that start a Tomcat (and thus deploy webapps etc.) should not use that type of params. They should go into CATALINA_OPTS. Everything

OneLineFormatter by default?

2011-06-20 Thread Rainer Jung
Should we use the new OneLineFormatter as the default juli formatter? I never found anyone who liked the default java.util.logging log format, which spreads all messages out via two lines. One line contains the timestamp, the other line the message. So if your grep for a message, you want find

Re: OneLineFormatter by default?

2011-06-20 Thread Rainer Jung
Thanks Konstantin. I'll take a look at cleaning up 1) to 3), likely using the DateFormatCache from the AccessLogValve as a utility class. Regards, Rainer On 20.06.2011 18:52, Konstantin Kolinko wrote: 2011/6/20 Rainer Jung rainer.j...@kippdata.de: Should we use the new OneLineFormatter

Re: OneLineFormatter by default?

2011-06-20 Thread Rainer Jung
On 20.06.2011 20:10, Mark Thomas wrote: On 20/06/2011 19:07, Rainer Jung wrote: Thanks Konstantin. I'll take a look at cleaning up 1) to 3), likely using the DateFormatCache from the AccessLogValve as a utility class. Already on it. Note DateFormatCache can't be used because a) JULI can't

Re: svn commit: r1137731 - in /tomcat/trunk: java/org/apache/juli/OneLineFormatter.java webapps/docs/changelog.xml

2011-06-20 Thread Rainer Jung
A version using the DateFormatCache is available at: http://people.apache.org/~rjung/patches/OneLineFormatter-DateFormatCache.patch Regards, Rainer - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional

Re: svn commit: r1137803 - /tomcat/trunk/webapps/docs/changelog.xml

2011-06-20 Thread Rainer Jung
On 21.06.2011 00:28, ma...@apache.org wrote: Author: markt Date: Mon Jun 20 22:28:57 2011 New Revision: 1137803 URL: http://svn.apache.org/viewvc?rev=1137803view=rev Log: Ordering Modified: tomcat/trunk/webapps/docs/changelog.xml I always forget whether there's a standard (I would

Re: DO NOT REPLY [Bug 51206] CATALINA_BASE is not visible to setenv.sh

2011-06-21 Thread Rainer Jung
On 21.06.2011 09:54, bugzi...@apache.org wrote: Rainer implemented this in 7.0.x and it will be included in 7.0.17 onwards. Sorry, this BZ slipped my attention. Thanks. Rainer - To unsubscribe, e-mail:

Multiple catalina.properties

2011-06-23 Thread Rainer Jung
Noticing that e maintain two copies of jarsToSkip lists, one in catalina.properties and one in TomcatBaseTest, I was thinking about a test case to compare the two. I then stumbled over our catalina.properties copy in the startup package, which doesn't have a jarsToSkip at all. File

Re: Multiple catalina.properties

2011-06-23 Thread Rainer Jung
On 23.06.2011 09:42, Rainer Jung wrote: Noticing that e maintain two copies of jarsToSkip lists, one in catalina.properties and one in TomcatBaseTest, I was thinking about a test case to compare the two. I then stumbled over our catalina.properties copy in the startup package, which doesn't

Re: Multiple catalina.properties

2011-06-23 Thread Rainer Jung
On 23.06.2011 11:40, Mark Thomas wrote: On 23/06/2011 08:42, Rainer Jung wrote: Noticing that e maintain two copies of jarsToSkip lists, one in catalina.properties and one in TomcatBaseTest, I was thinking about a test case to compare the two. I then stumbled over our catalina.properties copy

Re: Overhauling setclasspath.(bat|sh)?

2011-06-23 Thread Rainer Jung
On 21.06.2011 11:40, Konstantin Kolinko wrote: 2011/6/20 Rainer Jung rainer.j...@kippdata.de: 1) Renaming Since quite some time now the setclasspath script doesn't have anything to do with setting a class path. It only searches for JRE / JDK and sets up the path to the Java or JDB binary

Using juli DateFormatCache in AccessLogValve?

2011-06-23 Thread Rainer Jung
Since OneLineFormatter now uses the DateFormatCache util class, and to prevent any dependency of juli form other packages that util class sits in juli, what do we think about using it also in AccessLogValve? At the moment the valve has a local copy as an inner class. Of course a dependency on

Supporting more general globs in loader definition?

2011-06-23 Thread Rainer Jung
At the moment the file globs we support in the loader definitions in catalina.properties are hard coded to DIRECTORY/*.jar. Sometimes it would be helpful to allow a bit more flexible globs, like e.g. log4j-1.2.*.jar or similar. Would there be any interest if I would investigate whether we can

Re: Overhauling setclasspath.(bat|sh)?

2011-06-23 Thread Rainer Jung
Hi Chris, On 23.06.2011 16:29, Christopher Schultz wrote: Rainer, On 6/23/2011 7:33 AM, Rainer Jung wrote: On 21.06.2011 11:40, Konstantin Kolinko wrote: 2011/6/20 Rainer Jung rainer.j...@kippdata.de: 1) Renaming Since quite some time now the setclasspath script doesn't have anything

Re: Supporting more general globs in loader definition?

2011-06-23 Thread Rainer Jung
On 23.06.2011 16:34, Rainer Jung wrote: At the moment the file globs we support in the loader definitions in catalina.properties are hard coded to DIRECTORY/*.jar. Sometimes it would be helpful to allow a bit more flexible globs, like e.g. log4j-1.2.*.jar or similar. Would there be any

Re: Supporting more general globs in loader definition?

2011-06-23 Thread Rainer Jung
On 23.06.2011 16:51, Christopher Schultz wrote: Rainer, On 6/23/2011 10:39 AM, Rainer Jung wrote: Globs in the file name and not the directory part is the most important use case and easy to understand in its consequences. So I lean towards this type of improvement right now. So

Re: Supporting more general globs in loader definition?

2011-06-23 Thread Rainer Jung
And this would be the patch: http://people.apache.org/~rjung/patches/tc7-loader-glob.patch Regards, Rainer On 23.06.2011 16:39, Rainer Jung wrote: On 23.06.2011 16:34, Rainer Jung wrote: At the moment the file globs we support in the loader definitions in catalina.properties are hard coded

Re: Supporting more general globs in loader definition?

2011-06-23 Thread Rainer Jung
On 23.06.2011 19:46, Konstantin Kolinko wrote: 2011/6/23 Rainer Jung rainer.j...@kippdata.de: At the moment the file globs we support in the loader definitions in catalina.properties are hard coded to DIRECTORY/*.jar. Sometimes it would be helpful to allow a bit more flexible globs, like e.g

Re: Multiple instances of the same Tomcat version (was: svn commit: r1139381)

2011-06-25 Thread Rainer Jung
On 24.06.2011 22:22, Konstantin Kolinko wrote: 2011/6/24 ma...@apache.org: Author: markt Date: Fri Jun 24 16:43:40 2011 New Revision: 1139381 URL: http://svn.apache.org/viewvc?rev=1139381view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50949 Provide the ability to

Re: Using eval vs. exec in shell scripts

2011-06-26 Thread Rainer Jung
discuss the technical details here, and if the list doesn't find a solution for you, you can open a bug. Regards, Rainer Rainer Jung-3 wrote: Since Mladens change r918873 in March 2010 we use eval instead of exec in the shell scripts. The svn log says: Use eval instead direct call or exec

Re: Using eval vs. exec in shell scripts

2011-06-26 Thread Rainer Jung
On 26.06.2011 17:35, bradleymccrorey wrote: Rainer Jung-3 wrote: Did you follow the later messages in this discusison thread? I made an error in not including all quotes use din catalina.sh in my simpl test script. So when using the correct scripts, the eval did *not* leave a copy

Re: Using eval vs. exec in shell scripts

2011-06-26 Thread Rainer Jung
On 26.06.2011 17:59, bradleymccrorey wrote: Rainer Jung-3 wrote: You can clearly see here that there are two processes: one for the shell script, and one for the actual java process. Is this not what I should be seeing? You should, bot only when using run, which is precisely meant

Re: JK 1.2.32 release kick

2011-06-28 Thread Rainer Jung
+1, great! On 27.06.2011 20:03, Mladen Turk wrote: Hi, I have a time slot available so I volunteer as a 1.2.32 RM. Think we are good for a new release. Comments, objections? - To unsubscribe, e-mail:

response.encodeURL(http://localhost:8080) produces an invalid URL?

2011-06-29 Thread Rainer Jung
Motivated by https://issues.apache.org/jira/browse/WICKET-3841 I tested response.encodeURL(http://localhost:8080;) and I get http://localhost:8080;jsessionid=... (cookies off). Note that there is no slash between the port and the sessionid path info. According to my reading of RFC3986 (URIs),

<    3   4   5   6   7   8   9   10   11   12   >