Hi Bruce,
so here's the complete patch against the current cvs.
Description:
The attached patches will add
pg_get_ruledef(oid, bool)
pg_get_viewdef(text, bool)
pg_get_viewdef(oid, bool)
pg_get_indexdef(oid, int4, bool)
pg_get_constraintdef(oid, bool)
pg_get_expr(text, oid, bool)
If the
Bruce Momjian wrote:
Tom Lane wrote:
Bruce Momjian [EMAIL PROTECTED] writes:
Tom, how do I pass PG_FUNCTION_ARGS to another function, while adding a
new parameter?
I wouldn't. Do the PG_GETARGS in the wrapper, and have the called
function take a normal C parameter list.
So I
Tom Lane wrote:
Andreas Pflug [EMAIL PROTECTED] writes:
+ int prettyFlags = !PG_ARGISNULL(1) PG_GETARG_BOOL(1) ? PRETTYFLAG_PAREN|PRETTYFLAG_INDENT : 0;
Since the pg_proc entries are all marked strict, it's unnecessary for
you to write any ARGISNULL checks.
Yeah you're right
Tom Lane wrote:
Applied with some editorializing. In particular, I don't believe the
original did the right thing with (a - (b - c)).
Oops, missed that case...
But now, we have (a + ( b + c)) again.
A patch that removes parentheses for + and * is appended.
Regards,
Andfdsa
Now the patch is *really* appended :-)
Tom Lane wrote:
Applied with some editorializing. In particular, I don't believe the
original did the right thing with (a - (b - c)).
Oops, missed that case...
But now, we have (a + ( b + c)) again.
A patch that removes parentheses for + and * is
Tom Lane wrote:
Now the patch is *really* appended :-)
And rejected.
Ok, the ckeck for node being the first child already does the trick for
standard l-t-r evaluation.
You cannot assume that an operator is commutative or
associative just because it has a name you think ought to be.
(For
The attached patch allows libpq to be compiled under native win32. It
adds the missing thread.c.
Additionally, it corrects the option to compile for debugging.
Regards,
Andreas
RCS file: /projects/cvsroot/pgsql-server/src/include/pg_config.h.win32,v
retrieving revision 1.11
diff -u -r1.11
The attached patch reenables non-blocking operation under win32.
The global variable was left uninitialized, so the compiler would
silently make it 0. This resulted in connectMakeNonblocking() setting
nonblocking to zero, i.e. blocking.
Regards,
Andreas
RCS file:
Hi Bruce,
+
+/* getpwuid doesn't exist under win32 */
+#define getpwuid(uid) NULL
+
#endif /* pg_config_h_win32__ */
Why was this needed? I realize we don't have getpwuid() on Win32, but
we do have GetUserName() for cases where we need the name but not the
directory.
Because all the
Andrew Dunstan wrote:
Andreas,
You should check that the CIDR mask is a valid integer. You would need
to use strtol() rather than atoi() to do that. Perhaps this should be
hoisted out of ip.c:SockAddr_cidr_mask() and put in hba.c.
Right, I added this.
Regards,
Andreas
Index: hba.c
Tom Lane wrote:
I thought this was still really messy, so I modified it to use a
separate promote v4 address to v6 subroutine. I've applied the
attached patch (plus docs). It's not very well tested since I don't
have an IPv6 setup here; please check that it does what you want.
It SEGVs. Reason
Larry Rosenman wrote:
Here's a quickie patch I did to fix it.
Patching this or not, if the function's called the backend will SEGV
either (at least on my 2.4.20 it does) because a IPV6 address is copied
in the memory space of a IPV4 address.
Regards,
Andreas
---(end
Tom Lane wrote:
Andreas Pflug [EMAIL PROTECTED] writes:
Larry Rosenman wrote:
Here's a quickie patch I did to fix it.
Patching this or not, if the function's called the backend will SEGV
either (at least on my 2.4.20 it does) because a IPV6 address is copied
in the memory
My Deja wrote:
I am trying to get some query trees to appear in the PostgreSQL log
and in order to that I have set
client_min_messages = DEBUG1 in order to use the following settings
debug_print_parse, debug_print_rewritten, or debug_print_plan which
are required for the query tree to show up
When checking for thread safety with src/tools/thread/thread_test.c, the
mktemp function wants an argument that contains 6 X, while the current
version only supplies 5 X which will fail on my SuSE 8.1.
Patch attached.
Regards,
Andreas
Index: thread_test.c
Some modifications are needed to compile libpq with vc6:
fe-connect.c:
- pg_config_paths.h isn't available. SYSCONFDIR is already defined so
fe-connect.c doesn't need to include that.
patch appended
win32.mak:
- pg_config.h must be generated
- port/pgstrcasecmp.c is needed
- port/path.c is not
init_ssl_system will return 0 on success and -1 on failure, which will
be interpreted just the other way round in initialize_SSL.
Patch appended.
Regards,
Andreas
Index: fe-secure.c
===
RCS file:
Manfred Spraul wrote:
Btw, --enable-thread-safety on Linux (RedHat Fedora Core 1) fails in
configure with
configure: error:
*** Thread test program failed. Your platform is not thread-safe.
*** Check the file 'config.log'for the exact reason.
I had this too, for two reasons:
- configure
Tom Lane wrote:
Andreas Pflug [EMAIL PROTECTED] writes:
When checking for thread safety with src/tools/thread/thread_test.c, the
mktemp function wants an argument that contains 6 X, while the current
version only supplies 5 X which will fail on my SuSE 8.1.
Patch attached.
Isn't
Tom Lane wrote:
Andreas Pflug [EMAIL PROTECTED] writes:
init_ssl_system will return 0 on success and -1 on failure, which will
be interpreted just the other way round in initialize_SSL.
Patch appended.
Hmm, that looks backwards to me too, but this would seem to imply that
Manfred Spraul
Bruce Momjian wrote:
fe-connect.c:
- pg_config_paths.h isn't available. SYSCONFDIR is already defined so
fe-connect.c doesn't need to include that.
patch appended
This shouldn't be needed anymore. Where is SYSCONFDIR coming from? Is
it from some Win32 include file? It should only be
Bruce Momjian wrote:
Andreas Pflug wrote:
Bruce Momjian wrote:
fe-connect.c:
- pg_config_paths.h isn't available. SYSCONFDIR is already defined so
fe-connect.c doesn't need to include that.
patch appended
This shouldn't be needed anymore. Where is SYSCONFDIR
Andreas Pflug wrote:
The attached patch will create a dummy pg_config_paths.h.
Additionally, ENABLE_THREAD_SAFETY is supported by the makefile (but
not by the sources, which need some rework)
Now including the patch...
Regards,
Andreas
Index: win32.mak
The appended patch implements ENABLE_THREAD_SAFETY for win32 compiled
with Visual C. Two additional files will supply the needed pthread stuff.
There's no SIGPIPE for native win32, so there are some #IFNDEF WIN32 to
skip installing a signal handler for this. I'm not sure if this is going
to
While trying to
pg_constraint JOIN pg_index ON indrelid=conrelid AND conkey=indkey
I noticed (once again) that these columns have different types (although
describing the same thing), and there's no equality operator for them.
The attached patch adds an equality operator
bool
Magnus Hagander wrote:
Specifically about the logs, I still think there is a lot of value to
being able to read the logs remotely even if you can't restart
postmaster.
Since I believe that retrieving the logs easily without server file
access is a feature that's welcomed by many users, here's my
Tom Lane wrote:
Bruce Momjian [EMAIL PROTECTED] writes:
Looks good to me. The only issue I saw was that the default file name
mentioned in postgresql.conf doesn't match the actual default.
I'm really not happy with the concept that the postmaster overrides
its stderr direction.
I
Sorry I didn't get back on this earlier, yesterday morning my internet
access was literally struck by lightning, I'm running temporary hardware
now.
Bruce Momjian wrote:
Looks good to me. The only issue I saw was that the default file name
mentioned in postgresql.conf doesn't match the actual
Bruce Momjian wrote:
I have looked over this patch. I noticed this:
-static pthread_mutex_t init_mutex = PTHREAD_MUTEX_INITIALIZER;
-
+static pthread_mutex_t init_mutex;
+static int mutex_initialized = 0;
+if
Bruce Momjian wrote:
Agreed. My pthread book says pthread_mutex_init() should be called only
once, and we have to guarantee that. If the Windows implentation allows
it to be called multiple times, just create a function to be called only
by Win32 that does that and leave the Unix safe.
Ok,
Bruce Momjian wrote:
I was thinking of close/reopen so log files
could be rotated.
Log file rotation is fine, if we find a consensus quite soon how to
implement it... Seems as if I might find some time to implement it until
feature freeze.
The attached patch has the default filename issue
Tom Lane wrote:
This has got portability issues (fopen(ab))
My doc says b is ignored on ansi systems, and recommends using it. Do
you have other experiences?
and I don't care for its
use of malloc in preference to palloc either.
Do we already have an applicable memory context in the
Manfred Spraul wrote:
Wrong. There are portable test-and-set functions in the Win32 SDK: for
example InterlockedCompareExchange. They operate on ints and do not
need initialization.
'k, missed that one. Lets use it.
There is a third option: Add one C++ file and use the constructor to
initialize
So here's the updated ENABLE_THREAD_SAFETY patch for win32, to be
compiled under VC5/6/7 (tested with VC6).
nmake -f win32.mak [DEBUG=1] [USE_SSL=1] [ENABLE_THREAD_SAFETY=1]
are supported.
Regards,
Andreas
/*-
*
*
Dave Page wrote:
It could still be run on NT4 under the following conditions:
1) Running as a service
2) Running if the user logged in is not an administrator.
Well, isn't running as a service sufficient? I thought
that was the only interesting case for non-hackers anyway.
As long as
Dave Page wrote:
you can only run one
instance as a service on a single machine.
If you mean only run one instance of postmaster as service, that's not true.
If you like two pgsql servers (i.e. db clusters), you can install two
services, both using the same binary with different cmd line
Gavin Sherry wrote:
On Fri, 18 Jun 2004, Andreas Pflug wrote:
Gavin Sherry wrote:
On Fri, 18 Jun 2004, Bruce Momjian wrote:
[snip]
TODO. You sound like a man who's expecting a
several-generations-polished facility when we only just committed
the first version today. I do not feel
Gavin Sherry wrote:
I would debate that.
Firstly, tablespaces aren't supported on windows yet.
Just a matter of time. And I'm talking of win32 workstations connecting
to *ix servers too.
Secondly, I'd think
that Unix users would be fine with a command line tool, especially one
that can connect
Tom Lane wrote:
Andreas Pflug [EMAIL PROTECTED] writes:
IMHO checking objects in a tablespace is a routine administrative task,
so it should be supported natively by the server without need of
contribs.
I strongly disagree. Dropping a tablespace is not a routine activity,
Dropping
Tom Lane wrote:
Andreas Pflug [EMAIL PROTECTED] writes:
Tom Lane wrote:
As for the authentication-is-expensive issue, what of it? You *should*
have to authenticate yourself in order to look inside another person's
database. The sort of cross-database inspection being proposed here
would
Dave Page wrote:
-Original Message-
From: [EMAIL PROTECTED] on behalf of Bruce Momjian
Sent: Sat 6/19/2004 1:05 AM
To: Andreas Pflug
Cc: Tom Lane; Gavin Sherry; PostgreSQL-patches
Subject: Re: [PATCHES] Tablespace patch review
We can build a gui on top of the command-line tool
Bruce Momjian wrote:
I don't see why an admin tool can't connect to each database and get a
listing of what is in each tablespace. I don't think connecting to 100
databases to get that information will be slow.
Well, whatever you call slow or not slow.
I checked it; connecting 10 databases,
Dave Page wrote:
-Original Message-
From: Andreas Pflug [mailto:[EMAIL PROTECTED]
Sent: Sat 6/19/2004 6:40 PM
To: Bruce Momjian
Cc: Dave Page; Tom Lane; PostgreSQL-patches
Subject: Re: [PATCHES] Tablespace patch review
Well, whatever you call slow or not slow.
I checked it; connecting
Two minor tweaks:
sys/time.h in libpq-be.h isn't present on win32 vc6. Apparently, it
isn't used in Linux either; libpq will compile without it. All usages of
gettimeofday throughout the backend don't seem connection related, so
libpq-be.h seems an odd place to include it.
ERROR in elog.h has
Tom wrote:
It's there to declare struct timeval, and I'm fairly certain that diking
it out of the header would break things on some platforms. Where does
Windows define struct timeval?
struct timeval is defined in winsock.h under vc6.
I'm checking for _MSC_VER now.
Agreed. We define
The attached patch includes serverlog rotation with minimal shared
memory usage as discussed and functions to access it.
Regards,
Andreas
Index: doc/src/sgml/func.sgml
===
RCS file:
Andreas Pflug wrote:
From an idea of Bruce, the attached patch implements the function
pg_tablespace_databases(oid) RETURNS SETOF oid
which delivers as set of database oids having objects in the selected
tablespace, enabling an admin to examine only the databases affecting
the tablespace
Fabien COELHO wrote:
Dear patchers,
I have two minor patches that are being submitted but which do not appear
yet in the official patch queue on the web site:
http://momjian.postgresql.org/cgi-bin/pgpatches
That site is maintained by Bruce, who is out to Armenia until next week,
with
Joe Conway wrote:
Attached is the patch I plan to apply. There are a couple of changes
from what was posted.
1) You must have meant tablespace instead of namespace here:
+ row
+
Updated version.
Only timestamp of fresh logfile in shared mem, with sanity checks.
On SIGHUP, timestamp is checked if rotation was issued, as well as
changed log_filename setting from postgresql.conf.
Regards,
Andreas
Index: src/backend/postmaster/postmaster.c
Peter Eisentraut wrote:
Bruce Momjian wrote:
I have added this patch plus your later comments to the patch queue.
The autovacuum process still uses libpq to send its queries, which is
not the idea behind backend integration.
Can we consider this a non-fatal bug that has to be solved
Bruce Momjian wrote:
How is this patch supposed to work? Do people need to modify
postgresql.conf and then sighup the postmaster? It seems more logical
for the super-user to call a server-side function.
I assume calling pg_logfile_rotate() to be the standard way. calling
pg_logfile_rotate
Tom Lane wrote:
That was something that bothered me too. I think in the patch as given,
the GUC parameter determining the logfile name would have to be
PGC_POSTMASTER, ie, you could not change it on the fly because the
backends wouldn't all switch together.
In my original posting it was
Tom Lane wrote:
That struck me as not only useless but the deliberately hard way to do
it. To use that in the real world, you'd have to set up a cron job to
trigger the rotation,
Still on my radar...
which means a lot of infrastructure and privilege;
whereas ISTM the point of this feature was to
Bruce Momjian wrote:
Also there are no documenttion changes.
Here are the missing docs, freshly created against cvs.
Regards,
Andreas
Index: func.sgml
===
RCS file: /projects/cvsroot/pgsql-server/doc/src/sgml/func.sgml,v
retrieving
in
* postgresql.conf), using an internal naming scheme that mangles
* creation time and current postmaster pid.
*
* Author: Andreas Pflug [EMAIL PROTECTED]
*
* Copyright (c) 2004, PostgreSQL Global Development Group
*
*
* IDENTIFICATION
* $PostgreSQL
are reached or passed, the
* current logfile is closed and a new one is created (rotated).
* The logfiles are stored in a subdirectory (configurable in
* postgresql.conf), using an internal naming scheme that mangles
* creation time and current postmaster pid.
*
* Author: Andreas Pflug [EMAIL
Bruce Momjian wrote:
Andreas Pflug wrote:
Very nice. You did a nice trick of reading the log filenames into a
timestamp field:
count = sscanf(de-d_name, %04d-%02d-%02d_%02d%02d%02d_%05d.log, yea$
You only process files that match that pattern for pg_logfiles_ls()
(perhaps this should
Bruce Momjian wrote:
Peter Eisentraut wrote:
Bruce Momjian wrote:
Peter Eisentraut wrote:
Andreas Pflug wrote:
How should the prefix be named? pgsql_ ?
Make the file names configurable.
He has code to interpret the file names as timestamps that can be
used in queries. If we allowed full user
Bruce Momjian wrote:
Andreas Pflug wrote:
OK, new idea. Forget about modifying pg_dir_ls(). Instead add
pg_file_stat the returns the file size, times. You can then easily use
that for file size and times. Also, if you want, add an is_dir boolean
so people can write functions that walk
Bruce Momjian wrote:
Here is what you can do:
SELECT filename,
(SELECT file_len FROM pg_file_stat(filename)),
(SELECT file_ctime FROM pg_file_stat(filename)),
(SELECT file_mtime FROM pg_file_stat(filename)),
(SELECT file_atime FROM pg_file_stat(filename))
FROM pg_dir_ls('/etc') AS
Bruce Momjian wrote:
Are we done? Seems pg_file_stat() works fine. Do we need other
adjustments?
Here are the documentation changes.
Regards,
Andreas
Index: catalogs.sgml
===
RCS file:
Tom Lane wrote:
If you don't mind plastering a use at your own risk sign on it, then
go for it.
killing a backend is obviously much more at your own risk than a
descent function.
Taken from your mail, I understand that a killed backend might leave
some loose ends, eg. open locks, which would
This is the known patch, with following changes:
- realStdErr handed over for EXEC_BACKEND, but still not tested
- Sometimes EMFILE is received in the logger's process queue, when a
backend ended after a SSL connection was interrupted. This is ignored
now (previously it forced an exit(1) and
() AS A
(filetime timestamp, pid int4, filename text);
/*-
*
* genfile.c
*
*
* Copyright (c) 2004, PostgreSQL Global Development Group
*
* Author: Andreas Pflug [EMAIL PROTECTED]
*
* IDENTIFICATION
* $PostgreSQL
Bruce Momjian wrote:
Your patch has been added to the PostgreSQL unapplied patches list at:
http://momjian.postgresql.org/cgi-bin/pgpatches
It will be applied as soon as one of the PostgreSQL committers reviews
and approves it.
Do not apply.
I'm investigating issues under win32.
Main
Bruce Momjian wrote:
I talked to Tom about this today. First, I want to apologize for
running you around in circles in this. I don't think we are giving it
the attention it needs because of our schedule. I also think the
functionality is drifting into the new features territory and this is
also
Bruce Momjian wrote:
Basically I think we are converging on an answer that we can't do any of
this for 7.5.
If it's not going into the distribution as contrib or core, I'll package
that as additional admin pack. I'm quite sure I can convince the win32
installer packager guys to include that as
Dave Page wrote:
As Bruce has seen, this is some pretty nice functionality that
Andreas has added to pga3, and is one of the few areas that we
lag behind SQL Server etc. in on the management front.
If you're curious what Bruce has seen, it was this:
Bruce Momjian wrote:
Do people want the server file logging/rotating patch applied if it is
Unix-only? Right now the patch is ifdef'ed so Win32 use of it is
disabled.
Andreas is asking.
Please commit ASAP. Is I stated several times, I'll do the win32 as soon
as I get a chance to. It's not a
Peter Eisentraut wrote:
Bruce Momjian wrote:
Do people want the server file logging/rotating patch applied if it
is Unix-only? Right now the patch is ifdef'ed so Win32 use of it is
disabled.
How is logging typically handled on Windows?
It is done using the eventlog service (which is supported as
Tom Lane wrote:
Do people want the server file logging/rotating patch applied if it is
Unix-only? Right now the patch is ifdef'ed so Win32 use of it is
disabled.
I'm slightly worried that we might be painting ourselves into a corner,
ie implementing functionality that will never work on Windows.
and a new one is created (rotated).
* The logfiles are stored in a subdirectory (configurable in
* postgresql.conf), using an internal naming scheme that mangles
* creation time and current postmaster pid.
*
* Author: Andreas Pflug [EMAIL PROTECTED]
*
* Copyright (c) 2004, PostgreSQL Global
Tom Lane wrote:
Andreas Pflug [EMAIL PROTECTED] writes:
Attached the patch, an orgy in #ifdefs, decorated with various indents
and crlf line ends (glad we have pgindent).
I spent a fair amount of time fooling with this, trying to extract
something that I trusted enough to apply at this late date
Tom Lane wrote:
if (!ReadFile(...))
{
DWORD error = GetLastError();
if (error == ERROR_HANDLE_EOF)
exit(0);
Got it. And there's no reason that the pipe thread can't do exit(0)
for itself?
Not really. All threads are equivalent.
BTW, should there be a last NOTICE syslogger shutting
Dave Page wrote:
This is obviously win2k+ only though -
There's a chance it might work on NT4 with =SP4, because AFAIR the
updated NTFS driver already understands the W2K format.
until now we've tried to support NT4 as well, although it seems that we
can't get initdb to work as we'd like in the
[EMAIL PROTECTED] wrote:
(create/drop tablespace works too)
I can *not* confirm this; after configure; make clean; make; make
install I got tablespace not supported. pg_config.h lacks HAVE_SYMLINK=1.
Regards,
Andreas
---(end of broadcast)---
TIP 8:
Andreas Pflug wrote:
Some recent change in libpq seems to interfere with gtk.
After I tested a new pgadmin3 version on linuy yesterday, I found that
the GUI is hanging after PQconnectdb was called. After the call, the db
connection is fully functional, but the GUI mouse will show waiting
Dave Page wrote:
Dave Page [EMAIL PROTECTED] writes:
The attached patch directs FATAL and PANIC elog's to the
event log as
well as their normal destination.
I don't think this is a good idea. In the first place, FATAL
errors are not necessarily serious or out-of-the-ordinary ---
an example
Bruce,
I posted the attached patch 4 days ago, with the comment
The attached patch will redefine unlink and rename only if FRONTEND is
not defined..
I still believe this a good way to fix it.
Tom Lane wrote:
To put that in a more positive light: we like to think that our code is
Posix-compliant
Bruce Momjian wrote:
The problem with this approach is that it has us using the non-reliable
libc rename/unlink rather than our own in libpq.
Not really. The backend will still use the reliable pg_ functions.
Frontends continue to use the libc functions, which are totally
sufficient in
Tom Lane wrote:
Bruce Momjian [EMAIL PROTECTED] writes:
Andreas Pflug wrote:
Not really. The backend will still use the reliable pg_ functions.
Frontends continue to use the libc functions, which are totally
sufficient in non-concurrent access situations.
I would like to keep full Unix semantics
Tom Lane wrote:
Hm. Given that we now support a native Windows port, do we care about
building libpq with VC6 anymore?
Yes please!
I just tried:
I renamed libpq.a to libpq.lib. pgAdmin links with that, but will crash.
Regards,
Andreas
---(end of
Tom Lane wrote:
Ed L. [EMAIL PROTECTED] writes:
Attached is a patch which replaces the 'log_filename_prefix' configuration
directive with a similar 'log_filename' directive.
+ changes the default log filename to exclude the PID;
This would be better stated as makes it impossible to use the PID
Tom Lane wrote:
It's definitely creeping featurism ... but
I can see the value of not needing any cron daemon to remove old logs.
No other logs on your system to purge?
A potential problem is what about size-driven rotation? If the hourly
output exceeds log_rotation_size then you'd truncate and
Tom Lane wrote:
Andreas Pflug [EMAIL PROTECTED] writes:
Tom Lane wrote:
I can see the value of not needing any cron daemon to remove old logs.
No other logs on your system to purge?
The DBA isn't necessarily also root.
Interesting this argument comes from you.. :-)
Tasks like purging old log
Bruce Momjian wrote:
Are we going to change this before beta2? I have not seen a final
patch yet.
Can we have pg_logdir_ls in the backend first so any related changes to
the log filename are reflected in both places?
Otherwise displaying the logfile on the client continues to be a moving
+++ dbsize.c 29 Aug 2004 10:12:11 -
@@ -1,157 +1,285 @@
+/*
+ * dbsize.c
+ * object size functions
+ *
+ * Copyright (c) 2004, PostgreSQL Global Development Group
+ *
+ * Author: Andreas Pflug [EMAIL PROTECTED]
+ *
+ * IDENTIFICATION
+ * $PostgreSQL: $
+ *
+ */
+
+
#include postgres.h
Maksim Likharev wrote:
Compiled and tried,
seems much better, no more WAIT_FAIL errors.
but I have some questions:
1. Is there a any possibility to assign server log file ( option -l,--log )
when PG runs as a service,
I wasn't able to do that, dump everything into stderror or eventlog just
not
Jan Wieck wrote:
but allows to setup a
configuration that automatically overwrites files in a rotating manner,
if the DBA so desires.
... which can't work because it will overwrite the logfile on server
start, and thus will overwrite the very latest logfile when performing
multiple restarts.
Tom Lane wrote:
at logger startup or size-based
rotation, the rule would be to append.
which then has a problem when you startup the postmaster after 10 hours
of downtime ... hmmm.
Doesn't seem like a big problem --- at worst that logfile will get to be
double the size it normally would.
...
Gavin Sherry wrote:
The attached patch contributes:
- database_size(name)
- relation_size(text)
I sent in a dbsize patch to make these functions tablespace aware...
AFAIR your patch was applied, but it misses tables in non-default
tablespaces.
Regards,
Andreas
---(end of
Tom Lane wrote:
Andreas Pflug [EMAIL PROTECTED] writes:
I don't have the time now to review the impact, but this might make
interpreting the log filename difficult or impossible, effectively
corrupting pg_logdir_ls.
So if you want to use that, you use a format that it can cope with.
you
Bruce Momjian wrote:
Patch applied. Thanks.
Can I get some documentation in the README for all the new
functionality.
Here it is.
Regards,
Andreas
Index: README.dbsize
===
RCS file:
Dave Page wrote:
cube
seg
patch attached. Compiles, but not tested.
miscutil
Needs review; includes some deprecated stuff (backend_pid)
pg_logger
deprecated; use redirect_stderr (BTW, is it default on win32 now?)
pgcrypto
misses -lws2_32. According to README, it needs some tuning concerning
[EMAIL PROTECTED] wrote:
hello,
we are starting a new language translation in postgresql.
I send the pg_controldata message translation in Farsi language.
I sended it to the Peter Eisentraut with the name fa_IR.po. He said that
Is there any use of fa outside of IR? Else I would just call the
Bruce Momjian wrote:
How does your Win32 system rename prototype differ from what is in
port.h?
What is the need of *any* special file handling functions for client tools?
Regards,
Andreas
---(end of broadcast)---
TIP 1: subscribe and unsubscribe
Bruce Momjian wrote:
Andreas Pflug wrote:
Bruce Momjian wrote:
How does your Win32 system rename prototype differ from what is in
port.h?
What is the need of *any* special file handling functions for client tools?
We could avoid it but it does give us Unix semantics so it seemed good
to keep
Peter Eisentraut wrote:
Tom Lane wrote:
Nonetheless, it would also be good to have some consistency between
the core PG server and related projects. I tend to agree that we
should honor pgadmin's precedent here; it's not a strong argument but
the argument for fa over fa_IR seems even weaker.
The attached Makefile patch together with stylesheet-hh.xsl allows make
htmlhelp. stylesheet-hh.xsl is derived from stylesheet.xsl, after some
advise from PeterE.
The result isn't perfect, but quite usable.
Regards,
Andreas
Index: Makefile
1 - 100 of 140 matches
Mail list logo
