Hi Christian,
Thanks for the fast response. I haven't tried upgrading things. I guess I
could try that, but I got the impression from somewhere that it would be
difficult to do so from the early version that we are currently running. If
you think it is worth trying, then that is probably the ideal
Hi Jon,
Your plan to use ALTER TABLE should work. review_request_id just holds the
current ID. That's what should be auto_increment. I think so long as you do
that, you'll see the review request ID number you expect.
By the way, what problems did you hit with upgrading?
Christian
--
Christian
It is indeed possible to use post-review to generate an appropriate diff
following the post-commit review model. RBTools version 0.2.0 contains a fix
that makes it possible to generate the initial review by passing
"--revision-range 0:HEAD" to post-review. If you're stuck with an older
version of R
Apologies if this has been covered before, google didn't seem to have
an obvious answer. Is it possible to set a starting review # for a
clean install?
The issue is that we have a pre-1.0 installation that has been in use
for awhile now. Instead of trying to figure out how to upgrade the
database,
Actually RBTools was never added to the easy-tools.pth. Weird. I
could have sworn I got it at one point. Wound up downloading an
unzipping the egg.
I'm hoping the easy_tools -U RBTools works for the other people who
are checking Reviewboard out for our company.
On Aug 20, 3:24 am, JohnHenry
I restarted the memcache and that seems to have fixed the issues.
thanks
On Aug 20, 11:49 am, Christian Hammond wrote:
> Oh, so your diff is uploading passwd but you're seeing Config.mak.
>
> It's possible that you have some odd caching problem. If you're using
> memcached, try restarting it to
Your script did the job for me. This is exactly what I needed to do (I
needed a full diff).
Thanks a lot.
-MS
On Sun, Aug 15, 2010 at 6:26 AM, Vesterbaek wrote:
>
> > Correct me if I'm wrong, but your script is useful when you want to put
> > existing committed code as a whole up for review, rig
Of course now I realize I said almost exactly what Eduardo said. I meant to
reply to Geoffrey's post directly, and hadn't read Eduardo's yet. Sorry
Eduardo :)
Christian
--
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.com
On
Timothy Pinet wrote:
I wanted to check post-review however since I am on Windows my
Python26\Scripts\post-review.exe is a compiled executable and not a
python file. Would it be enough to grab the post-review.py from the
repo and delete the exe?
Not with the current version. There are a few d
The slider could work and look more fancy, but two drags would be
infinitely slower than one click. I would only use it if I can click
on the numbers and the slider snaps to them.
Regarding cumulative patch, maybe we're talking about different
things. RB has always done it perfectly. I had a discu
Christian,
That's precisely the jQuery UI's widget that I mentioned.
I can refactor the one I'm writing for the stacked patches (aka
bundle), and put that in the trunk in time for 1.6.
I'll work on this.
Cheers,
Eduardo.
On Fri, Aug 20, 2010 at 3:46 PM, Christian Hammond wrote:
> When we firs
Skip did a perfect job sketching it. Thanks!
If you haven't used/seen Beyond Compare, please do yourself favor and
head to http://www.scootersoftware.com/moreinfo.php?zz=moreinfo_compare
The problem with too many tabs has been long solved by at least
browsers. Just see how Firefox does it with a
Oh, so your diff is uploading passwd but you're seeing Config.mak.
It's possible that you have some odd caching problem. If you're using
memcached, try restarting it to clear the cache. If it's a file-based cache,
delete all the files in the cache. Then re-view the diff.
Christian
--
Christian
When we first implemented this, we knew it was ugly, and had considered it a
sort of temporary stop-gap. But then Review Board got popular and people had
more pressing concerns, bug and feature-wise. So we never quite got around
to it.
What I've considered is a widget that shows all revisions and
Eduardo> could you do a mockup of what you intend?
I'm not sure a full mockup is necessary. Suppose you post a review with
changes to five files. The left-hand sidebar would be
file1
file2
file3
file4
file5
while the main pane would consist of five tabs, one for each
Geoffrey,
It was part of my Summer of Code to implement a similar (in concept at
least) interface, and I ran into a question about how to do this
properly, and I think a range selector is the best possible solution,
but they are hard to implement, even when using jQuery UI's range
selector, so I'm
I wanted to check post-review however since I am on Windows my
Python26\Scripts\post-review.exe is a compiled executable and not a
python file. Would it be enough to grab the post-review.py from the
repo and delete the exe?
Thanks,
Tim
On Aug 20, 12:54 pm, Chris Clark wrote:
>
> It actually isn'
Geoffrey,
could you do a mockup of what you intend? Just to get the idea. I
don't quite grasp it.
Also, how would your proposed design scale to a very large review? Say
one consisting of 50+ files.
ReviewBoard do sorts headers and implementation files for C/Objective
C/C++ so that the header is r
The current diff viewer does not scale at all for a large review with
lots of changes in lots of files.
Maybe I'm just spoiled by the incredibly fast and super convenient
Beyond Compare. kdiff3 is also great.
I know I'm asking too much for a web app to work like a native diff
tool. But it could w
Timothy Pinet wrote:
In which file does reviewboard invoke the "svn diff --diff-cmd=diff"
command? I have been looking but can not find it. I then thought that
you probably call the pysvn lib for this. I checked the pysvn
documentation (http://pysvn.tigris.org/docs/
pysvn_prog_ref.html#pysvn_clie
Screenshot is uploaded as rb.png
http://reviewboard.googlegroups.com/web/rb.png?gsc=iBqKOxYAAABgpEsrTenpw2OJ9ZY_yaTfM9KWFkvR1kwtm4g5T1-szg
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~-
The revision selector has always been a bit confusing to me (and new
RB users in my company) and inconvenient.
It's not exactly clear what diff you're looking at, cumulative or
incremental (interdiff).
And it may take an extra click to get an interdiff, for example you
have 3 revisions and you're
View diff shows:
Revision 1 New Change # this file is really /config/host_tools/
Config.mak not sysfiles/etc/passwd
1 # WG_CPU is toolchain prefix
2 WG_CPU = x86
3 WG_ARCH = x86
4 WG_ENDIAN = little
5
6 KERNEL_ARCH = i386
7 KERNEL_SFX = ko
8 KERNEL_VPATH = true
9
In which file does reviewboard invoke the "svn diff --diff-cmd=diff"
command? I have been looking but can not find it. I then thought that
you probably call the pysvn lib for this. I checked the pysvn
documentation (http://pysvn.tigris.org/docs/
pysvn_prog_ref.html#pysvn_client_diff) and there is a
I modified the base code for reviewboard. Its one small change in the webapi
code to trigger a generate_summary call when the close->submitted action is
done.
Then a new file which contains the generate_summary code and its appropriate
template. The email code was used as the inspiration, and subt
That is good to hear! When in doubt on Windows, reboot :)
Tim
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this
Hi Sakthi,
Even i had got the same page of manual updates and i
followed each step on the link given under that, but got the same page
again. Finally i restarted my PC and it worked fine.
Regards,
Shambhu.
On Aug 20, 4:44 am, "Timothy Pinet" wrote:
> I installed 1.0.9 on Windows
Hi,
I tried your command on my machine and it had no such problem.
Notice that easy_install -U is updating your RBTools(Not First Time
Install ), That means you should had a former version of RBTools
installed before. Check your easy_install.pth file and make sure your
former RBTools version
Hi
I sent the email to the wrong group, please ignore it
BR/Vincent
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe fro
Hi
As title, how can I know the weight of the Major, minor, critical and
blocker violations?
BR/Vincent
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~-
30 matches
Mail list logo
