[kudu-CR] server: move apply pool into ServerBase

Alexey Serbin has posted comments on this change. Change subject: server: move apply_pool into ServerBase .. Patch Set 4: Code-Review+2 This looks like a very nice clean-up which puts the apply_pool to the right place. --

[kudu-CR] minicluster: facilitate creating multidir clusters

Andrew Wong has posted comments on this change. Change subject: minicluster: facilitate creating multidir clusters .. Patch Set 12: (1 comment) build fail cause by lint check and a flake

[kudu-CR] threadpool: token-based task sequencing

Alexey Serbin has posted comments on this change. Change subject: threadpool: token-based task sequencing .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/6874/4/src/kudu/util/threadpool.cc File

[kudu-CR] KUDU-1952 Remove round-robin for block placement

Andrew Wong has posted comments on this change. Change subject: KUDU-1952 Remove round-robin for block placement .. Patch Set 40: build failure is from a TSAN flake -- To view, visit http://gerrit.cloudera.org:8080/6636 To

[kudu-CR] KUDU-1755 Part 1: Improve tablet on disk size metric

Will Berkeley has posted comments on this change. Change subject: KUDU-1755 Part 1: Improve tablet on disk size metric .. Patch Set 6: Unrelated failure in spark tests. I'm looking into the failure. -- To view, visit

[kudu-CR] threadpool: token-based task sequencing

Alexey Serbin has posted comments on this change. Change subject: threadpool: token-based task sequencing .. Patch Set 6: (7 comments) http://gerrit.cloudera.org:8080/#/c/6874/6/src/kudu/util/debug-util.h File

[kudu-CR] KUDU-1755 Part 1: Improve tablet on disk size metric

Will Berkeley has posted comments on this change. Change subject: KUDU-1755 Part 1: Improve tablet on disk size metric .. Patch Set 4: (4 comments) http://gerrit.cloudera.org:8080/#/c/6967/5/src/kudu/tablet/rowset.h File

[kudu-CR] KUDU-1755 Part 1: Improve tablet on disk size metric

Hello Mike Percy, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6967 to look at the new patch set (#6). Change subject: KUDU-1755 Part 1: Improve tablet on disk size metric

[kudu-CR] minicluster: facilitate creating multidir clusters

Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6845 to look at the new patch set (#12). Change subject: minicluster: facilitate creating multidir clusters ..

[kudu-CR] minicluster: facilitate creating multidir clusters

Andrew Wong has posted comments on this change. Change subject: minicluster: facilitate creating multidir clusters .. Patch Set 11: (4 comments)

[kudu-CR] KUDU-1952 Remove round-robin for block placement

Hello Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6636 to look at the new patch set (#40). Change subject: KUDU-1952 Remove round-robin for block placement ..

[kudu-CR] Work around another OpenSSL thread safety bug

Alexey Serbin has posted comments on this change. Change subject: Work around another OpenSSL thread safety bug .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/6997/2//COMMIT_MSG Commit Message: Line 19:

[kudu-CR] minicluster: facilitate creating multidir clusters

Andrew Wong has posted comments on this change. Change subject: minicluster: facilitate creating multidir clusters .. Patch Set 11: (9 comments)

[kudu-CR] minicluster: facilitate creating multidir clusters

Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6845 to look at the new patch set (#11). Change subject: minicluster: facilitate creating multidir clusters ..

[kudu-CR] Add fault injection of EIOs

Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6881 to look at the new patch set (#5). Change subject: Add fault injection of EIOs .. Add fault injection of EIOs

[kudu-CR] KUDU-2021 test for negotiation timeout on Master RPCs

Alexey Serbin has submitted this change and it was merged. Change subject: KUDU-2021 test for negotiation timeout on Master RPCs .. KUDU-2021 test for negotiation timeout on Master RPCs This patch adds integration tests to

[kudu-CR] KUDU-2021 test for negotiation timeout on Master RPCs

Alexey Serbin has posted comments on this change. Change subject: KUDU-2021 test for negotiation timeout on Master RPCs .. Patch Set 11: Code-Review+2 carrying Mike's +2 from PS10 -- To view, visit

[kudu-CR] KUDU-1911 improve missing required arg message

Andrew Wong has posted comments on this change. Change subject: KUDU-1911 improve missing required arg message .. Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/6986/4/src/kudu/tools/kudu-tool-test.cc File

[kudu-CR] KUDU-1911 improve missing required arg message

Andrew Wong has posted comments on this change. Change subject: KUDU-1911 improve missing required arg message .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/6986/4/src/kudu/tools/kudu-tool-test.cc File

[kudu-CR] threadpool: token-based task sequencing

Dan Burkert has posted comments on this change. Change subject: threadpool: token-based task sequencing .. Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/6874/3/src/kudu/util/threadpool-test.cc File

[kudu-CR] debug openssl error

Dan Burkert has abandoned this change. Change subject: debug openssl error .. Abandoned -- To view, visit http://gerrit.cloudera.org:8080/6996 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

[kudu-CR] Work around another OpenSSL thread safety bug

Dan Burkert has uploaded a new patch set (#2). Change subject: Work around another OpenSSL thread safety bug .. Work around another OpenSSL thread safety bug In the course of debugging some CHECK failures and TSAN errors, I

[kudu-CR] debug openssl error

Hello Todd Lipcon, Alexey Serbin, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/6996 to review the following change. Change subject: debug openssl error .. debug openssl error Change-Id:

[kudu-CR] Work around another OpenSSL thread safety bug

Hello Todd Lipcon, Alexey Serbin, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/6997 to review the following change. Change subject: Work around another OpenSSL thread safety bug .. Work

[kudu-CR] KUDU-1911 improve missing required arg message

Hello Dan Burkert, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6986 to look at the new patch set (#4). Change subject: KUDU-1911 improve missing required arg message ..

[kudu-CR] server: move apply pool into ServerBase

Adar Dembo has posted comments on this change. Change subject: server: move apply_pool into ServerBase .. Patch Set 4: There were two interesting TSAN warnings here. 1. ksck_remote-test: this TSAN warning is about a data race

[kudu-CR] KUDU-2021 test for negotiation timeout on Master RPCs

Hello Mike Percy, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6927 to look at the new patch set (#11). Change subject: KUDU-2021 test for negotiation timeout on Master RPCs

[kudu-CR] KUDU-2021 test for negotiation timeout on Master RPCs

Mike Percy has posted comments on this change. Change subject: KUDU-2021 test for negotiation timeout on Master RPCs .. Patch Set 10: Code-Review+2 (1 comment)

[kudu-CR] KUDU-2021 test for negotiation timeout on Master RPCs

Alexey Serbin has posted comments on this change. Change subject: KUDU-2021 test for negotiation timeout on Master RPCs .. Patch Set 10: (1 comment)

[kudu-CR] KUDU-1755 Part 1: Improve tablet on disk size metric

Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6967 to look at the new patch set (#5). Change subject: KUDU-1755 Part 1: Improve tablet on disk size metric ..

[kudu-CR] KUDU-1755 Part 1: Improve tablet on disk size metric

Will Berkeley has posted comments on this change. Change subject: KUDU-1755 Part 1: Improve tablet on disk size metric .. Patch Set 4: (15 comments) http://gerrit.cloudera.org:8080/#/c/6967/4/src/kudu/tablet/cfile_set.cc File

[kudu-CR] threadpool: new test for pools with no max threads

Adar Dembo has posted comments on this change. Change subject: threadpool: new test for pools with no max_threads .. Patch Set 7: Verified+1 I think the raft_consensus-itest failure is unrelated. Although this patch builds on

[kudu-CR] minicluster: facilitate creating multidir clusters

Andrew Wong has posted comments on this change. Change subject: minicluster: facilitate creating multidir clusters .. Patch Set 10: (15 comments)

[kudu-CR] KUDU-1911 improve missing required arg message

Andrew Wong has posted comments on this change. Change subject: KUDU-1911 improve missing required arg message .. Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/6986/3//COMMIT_MSG Commit Message: PS3, Line 11:

[kudu-CR] minicluster: facilitate creating multidir clusters

Alexey Serbin has posted comments on this change. Change subject: minicluster: facilitate creating multidir clusters .. Patch Set 9: (9 comments)

[kudu-CR] Add fault injection of EIOs

Andrew Wong has posted comments on this change. Change subject: Add fault injection of EIOs .. Patch Set 4: (25 comments) http://gerrit.cloudera.org:8080/#/c/6881/2/src/kudu/util/env_posix.cc File src/kudu/util/env_posix.cc:

[kudu-CR] Update version to 1.5.0-SNAPSHOT

Adar Dembo has submitted this change and it was merged. Change subject: Update version to 1.5.0-SNAPSHOT .. Update version to 1.5.0-SNAPSHOT Change-Id: I95fff81efcc846cf5c9eb8b075f01da44be5baeb Reviewed-on:

[kudu-CR] Update version to 1.5.0-SNAPSHOT

Adar Dembo has posted comments on this change. Change subject: Update version to 1.5.0-SNAPSHOT .. Patch Set 1: Verified+1 Overriding Jenkins; there was an unexpected openssl error in a master during the Python tests. It's

[kudu-CR] minicluster: facilitate creating multidir clusters

Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6845 to look at the new patch set (#10). Change subject: minicluster: facilitate creating multidir clusters ..

[kudu-CR] KUDU-1911 improve missing required arg message

Dan Burkert has posted comments on this change. Change subject: KUDU-1911 improve missing required arg message .. Patch Set 3: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/6986 To unsubscribe, visit

[kudu-CR] KUDU-2021 test for negotiation timeout on Master RPCs

Mike Percy has posted comments on this change. Change subject: KUDU-2021 test for negotiation timeout on Master RPCs .. Patch Set 10: Code-Review+1 (1 comment)

[kudu-CR] KUDU-2021 test for negotiation timeout on Master RPCs

Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6927 to look at the new patch set (#10). Change subject: KUDU-2021 test for negotiation timeout on Master RPCs ..

[kudu-CR] threadpool: token-based task sequencing

Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6874 to look at the new patch set (#6). Change subject: threadpool: token-based task sequencing .. threadpool:

[kudu-CR] minicluster: more realistic multi-dir clusters

Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6845 to look at the new patch set (#9). Change subject: minicluster: more realistic multi-dir clusters .. minicluster:

[kudu-CR] Update version to 1.5.0-SNAPSHOT

Dan Burkert has posted comments on this change. Change subject: Update version to 1.5.0-SNAPSHOT .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6994 To unsubscribe, visit

[kudu-CR] Update version to 1.5.0-SNAPSHOT

Hello Dan Burkert, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/6994 to review the following change. Change subject: Update version to 1.5.0-SNAPSHOT .. Update version to 1.5.0-SNAPSHOT

[kudu-CR] KUDU-1911 improve missing required arg message

Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6986 to look at the new patch set (#3). Change subject: KUDU-1911 improve missing required arg message .. KUDU-1911

[kudu-CR] consensus: consolidate Raft thread pools

Adar Dembo has posted comments on this change. Change subject: consensus: consolidate Raft thread pools .. Patch Set 5: PS5 yielded the following crash: https://gist.github.com/adembo/bb30754825ec0bf10cba783d07f3ac7d Looks

[kudu-CR] threadpool: token-based task sequencing

Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6874 to look at the new patch set (#5). Change subject: threadpool: token-based task sequencing .. threadpool:

[kudu-CR] KUDU-1927 [master] always send IPKI CA certificate

Alexey Serbin has posted comments on this change. Change subject: KUDU-1927 [master] always send IPKI CA certificate .. Patch Set 7: Verified+1 It seems to be an unrelated flake of RaftConsensusITest.Test_KUDU_1735 -- in the

[kudu-CR] KUDU-1911 improve missing required arg message

Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6986 to look at the new patch set (#2). Change subject: KUDU-1911 improve missing required arg message .. KUDU-1911

[kudu-CR] KUDU-2021 test for negotiation timeout on Master RPCs

Alexey Serbin has posted comments on this change. Change subject: KUDU-2021 test for negotiation timeout on Master RPCs .. Patch Set 9: > (1 comment) > > I hope we can get rid of the port bind errors by adding a resource >

[kudu-CR] Fix flaky test TestRestartWithOrphanedReplicates

Mike Percy has submitted this change and it was merged. Change subject: Fix flaky test TestRestartWithOrphanedReplicates .. Fix flaky test TestRestartWithOrphanedReplicates Looks like the test was setting a fault injection

[kudu-CR] Fix flaky test TestRestartWithOrphanedReplicates

Mike Percy has posted comments on this change. Change subject: Fix flaky test TestRestartWithOrphanedReplicates .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6976 To unsubscribe, visit

[kudu-CR] KUDU-1755 Part 1: Improve tablet on disk size metric

Mike Percy has posted comments on this change. Change subject: KUDU-1755 Part 1: Improve tablet on disk size metric .. Patch Set 4: (14 comments) http://gerrit.cloudera.org:8080/#/c/6967/4/src/kudu/tablet/cfile_set.cc File

[kudu-CR] KUDU-2021 test for negotiation timeout on Master RPCs

Alexey Serbin has posted comments on this change. Change subject: KUDU-2021 test for negotiation timeout on Master RPCs .. Patch Set 8: (4 comments) > (4 comments) > > Would you mind running 1000 iters on this test on

[kudu-CR] KUDU-1755 Part 2: Improve tablet on-disk size metric

Will Berkeley has posted comments on this change. Change subject: KUDU-1755 Part 2: Improve tablet on-disk size metric .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/6968/4//COMMIT_MSG Commit Message: Line

[kudu-CR] Fix flaky test TestRestartWithOrphanedReplicates

Alexey Serbin has posted comments on this change. Change subject: Fix flaky test TestRestartWithOrphanedReplicates .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6976 To unsubscribe, visit

[kudu-CR] KUDU-1911 add more helpful error message when required tool arguments are missing

Dan Burkert has posted comments on this change. Change subject: KUDU-1911 add more helpful error message when required tool arguments are missing .. Patch Set 1: (1 comment)

[kudu-CR] KUDU-1755 Part 1: Improve tablet on disk size metric

Will Berkeley has posted comments on this change. Change subject: KUDU-1755 Part 1: Improve tablet on disk size metric .. Patch Set 3: Actually I'm switching to "Tablet total size on disk" and "Tablet data size on disk" --

[kudu-CR] KUDU-1755 Part 2: Improve tablet on-disk size metric

Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6968 to look at the new patch set (#4). Change subject: KUDU-1755 Part 2: Improve tablet on-disk size metric ..

[kudu-CR] threadpool: new test for pools with no max threads

David Ribeiro Alves has posted comments on this change. Change subject: threadpool: new test for pools with no max_threads .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6945 To unsubscribe,

[kudu-CR] Allow external miniclusters to use data dirs

Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6845 to look at the new patch set (#8). Change subject: Allow external miniclusters to use data dirs .. Allow external

[kudu-CR] Add fault injection of EIOs

Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6881 to look at the new patch set (#4). Change subject: Add fault injection of EIOs .. Add fault injection of EIOs

[kudu-CR] KUDU-1911 add more helpful error message when required tool arguments are missing

Andrew Wong has posted comments on this change. Change subject: KUDU-1911 add more helpful error message when required tool arguments are missing .. Patch Set 1: (3 comments) left a couple formatting comments

[kudu-CR] Fix flaky test TestRestartWithOrphanedReplicates

Hello Mike Percy, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6976 to look at the new patch set (#4). Change subject: Fix flaky test TestRestartWithOrphanedReplicates ..

[kudu-CR] KUDU-1755 Part 1: Improve tablet on disk size metric

Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6967 to look at the new patch set (#3). Change subject: KUDU-1755 Part 1: Improve tablet on disk size metric ..

[kudu-CR] KUDU-1755 Part 1: Improve tablet on disk size metric

Will Berkeley has posted comments on this change. Change subject: KUDU-1755 Part 1: Improve tablet on disk size metric .. Patch Set 2: > Also, I wonder if we shouldn't introduce an additional metric which > would capture

[kudu-CR] KUDU-1755 Part 1: Improve tablet on disk size metric

Will Berkeley has posted comments on this change. Change subject: KUDU-1755 Part 1: Improve tablet on disk size metric .. Patch Set 2: (4 comments) I changed the names to - Remove the word "Estimate" because they aren't

[kudu-CR] KUDU-2021 test for negotiation timeout on Master RPCs

Mike Percy has posted comments on this change. Change subject: KUDU-2021 test for negotiation timeout on Master RPCs .. Patch Set 8: BTW the port conflict was what I was worried about with choosing the ports manually. We

[kudu-CR] KUDU-2021 test for negotiation timeout on Master RPCs

Mike Percy has posted comments on this change. Change subject: KUDU-2021 test for negotiation timeout on Master RPCs .. Patch Set 8: (4 comments) Would you mind running 1000 iters on this test on dist-test just to make sure

[kudu-CR] KUDU-1755 Part 1: Improve tablet on disk size metric

Mike Percy has posted comments on this change. Change subject: KUDU-1755 Part 1: Improve tablet on disk size metric .. Patch Set 2: Also, I wonder if we shouldn't introduce an additional metric which would capture these

[kudu-CR] KUDU-1755 Part 1: Improve tablet on disk size metric

Mike Percy has posted comments on this change. Change subject: KUDU-1755 Part 1: Improve tablet on disk size metric .. Patch Set 2: (4 comments) I sort of have a problem with referring to it as "compaction size" because