[kudu-CR] catalog manager: various boring cleanup

2017-09-06 Thread Adar Dembo (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7990 to look at the new patch set (#2). Change subject: catalog_manager: various boring cleanup .. catalog_manager:

[kudu-CR] [iwyu tool.py] fix on the IWYU tool invocation

2017-09-06 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [iwyu_tool.py] fix on the IWYU tool invocation .. Patch Set 4: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/7989 To unsubscribe, visit

[kudu-CR] [iwyu tool.py] fix on the IWYU tool invocation

2017-09-06 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [iwyu_tool.py] fix on the IWYU tool invocation .. Patch Set 4: Verified+1 Unrelated flake in AlterTableTest.TestAddRangePartitionConflictExhaustive. I filed a

[kudu-CR] [iwyu tool.py] fix on the IWYU tool invocation

2017-09-06 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. Change subject: [iwyu_tool.py] fix on the IWYU tool invocation .. [iwyu_tool.py] fix on the IWYU tool invocation Fixed the way include-what-you-use binary is invoked

[kudu-CR] [iwyu tool.py] fix on the IWYU tool invocation

2017-09-06 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [iwyu_tool.py] fix on the IWYU tool invocation .. Patch Set 4: Code-Review+2 -Verified Carrying over Adar's +2 from PS3. -- To view, visit

[kudu-CR] KUDU-2124. Don't hold session lock while initializing a TabletCopySession

2017-09-06 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: KUDU-2124. Don't hold session lock while initializing a TabletCopySession .. Patch Set 1: (7 comments)

[kudu-CR] KUDU-2124. Don't hold session lock while initializing a TabletCopySession

2017-09-06 Thread Dan Burkert (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7985 to look at the new patch set (#2). Change subject: KUDU-2124. Don't hold session lock while initializing a TabletCopySession

[kudu-CR] [iwyu tool.py] fix on the IWYU tool invocation

2017-09-06 Thread Alexey Serbin (Code Review)
Hello Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7989 to look at the new patch set (#4). Change subject: [iwyu_tool.py] fix on the IWYU tool invocation ..

[kudu-CR] [iwyu tool.py] fix on the IWYU tool invocation

2017-09-06 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: [iwyu_tool.py] fix on the IWYU tool invocation .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7989 To unsubscribe, visit

[kudu-CR] catalog manager: various boring cleanup

2017-09-06 Thread Adar Dembo (Code Review)
Hello Dan Burkert, Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/7990 to review the following change. Change subject: catalog_manager: various boring cleanup ..

[kudu-CR] [iwyu tool.py] fix on the IWYU tool invocation

2017-09-06 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [iwyu_tool.py] fix on the IWYU tool invocation .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/7989/2//COMMIT_MSG Commit Message: PS2, Line

[kudu-CR] [iwyu tool.py] fix on the IWYU tool invocation

2017-09-06 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7989 to look at the new patch set (#3). Change subject: [iwyu_tool.py] fix on the IWYU tool invocation ..

[kudu-CR](branch-1.5.x) KUDU-2130: java client: handle termination during negotiation edge case

2017-09-06 Thread Dan Burkert (Code Review)
Dan Burkert has submitted this change and it was merged. Change subject: KUDU-2130: java client: handle termination during negotiation edge case .. KUDU-2130: java client: handle termination during negotiation edge case There

[kudu-CR] test workload: make table creation more robust

2017-09-06 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. Change subject: test_workload: make table creation more robust .. test_workload: make table creation more robust The table creation here already works around the lack of

[kudu-CR] [iwyu tool.py] fix on the IWYU tool invocation

2017-09-06 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: [iwyu_tool.py] fix on the IWYU tool invocation .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/7989/2//COMMIT_MSG Commit Message: PS2, Line 9:

[kudu-CR] [iwyu tool.py] fix on the IWYU tool invocation

2017-09-06 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded a new patch set (#2). Change subject: [iwyu_tool.py] fix on the IWYU tool invocation .. [iwyu_tool.py] fix on the IWYU tool invocation Fixed the way how include-what-you-use binary is invoked by the

[kudu-CR] [iwyu tool.py] fix on the IWYU tool invocation

2017-09-06 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded a new change for review. http://gerrit.cloudera.org:8080/7989 Change subject: [iwyu_tool.py] fix on the IWYU tool invocation .. [iwyu_tool.py] fix on the IWYU tool invocation Fixed the way how the

[kudu-CR](branch-1.5.x) KUDU-2130 (part 2): more fixes for ITClientStress

2017-09-06 Thread Dan Burkert (Code Review)
Dan Burkert has submitted this change and it was merged. Change subject: KUDU-2130 (part 2): more fixes for ITClientStress .. KUDU-2130 (part 2): more fixes for ITClientStress This fixes some more race conditions in connection

[kudu-CR] web ui: fix "percentage consumed" calculation

2017-09-06 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: web ui: fix "percentage consumed" calculation .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7987 To unsubscribe, visit

[kudu-CR] WIP: Auto-vivify cmeta if doesn't exist at startup

2017-09-06 Thread Mike Percy (Code Review)
Hello Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/7988 to review the following change. Change subject: WIP: Auto-vivify cmeta if doesn't exist at startup .. WIP:

[kudu-CR] web ui: fix "percentage consumed" calculation

2017-09-06 Thread Todd Lipcon (Code Review)
Hello Dan Burkert, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/7987 to review the following change. Change subject: web ui: fix "percentage consumed" calculation .. web ui: fix

[kudu-CR] tablet copy: Allow voting from crashed initial tablet copies

2017-09-06 Thread Mike Percy (Code Review)
Mike Percy has submitted this change and it was merged. Change subject: tablet copy: Allow voting from crashed initial tablet copies .. tablet copy: Allow voting from crashed initial tablet copies The change in

[kudu-CR] KUDU-2124. Don't hold session lock while initializing a TabletCopySession

2017-09-06 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: KUDU-2124. Don't hold session lock while initializing a TabletCopySession .. Patch Set 1: (1 comment)

[kudu-CR] KUDU-2124. Don't hold session lock while initializing a TabletCopySession

2017-09-06 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: KUDU-2124. Don't hold session lock while initializing a TabletCopySession .. Patch Set 1: (7 comments)

[kudu-CR] tablet copy: Allow voting from crashed initial tablet copies

2017-09-06 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: tablet copy: Allow voting from crashed initial tablet copies .. Patch Set 4: I ran another 200x loop w/ 4 stress threads and I got 3 failures, all of which are

[kudu-CR] tablet copy: Allow voting from crashed initial tablet copies

2017-09-06 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: tablet copy: Allow voting from crashed initial tablet copies .. Patch Set 3: (1 comment)

[kudu-CR] tablet copy: Allow voting from crashed initial tablet copies

2017-09-06 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: tablet copy: Allow voting from crashed initial tablet copies .. Patch Set 3: > BTW, what was the setting for --stress_cpu_threads for that 200x > run? That one

[kudu-CR] tablet copy: Allow voting from crashed initial tablet copies

2017-09-06 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: tablet copy: Allow voting from crashed initial tablet copies .. Patch Set 3: (1 comment)

[kudu-CR] docs: update disk failure recovery notes

2017-09-06 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: docs: update disk failure recovery notes .. Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/7984/1/docs/administration.adoc File

[kudu-CR] tablet copy: Allow voting from crashed initial tablet copies

2017-09-06 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: tablet copy: Allow voting from crashed initial tablet copies .. Patch Set 3: (1 comment)

[kudu-CR] KUDU-2124. Don't hold session lock while initializing a TabletCopySession

2017-09-06 Thread Dan Burkert (Code Review)
Dan Burkert has uploaded a new change for review. http://gerrit.cloudera.org:8080/7985 Change subject: KUDU-2124. Don't hold session lock while initializing a TabletCopySession .. KUDU-2124. Don't hold session lock while

[kudu-CR] tablet copy: Allow voting from crashed initial tablet copies

2017-09-06 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: tablet copy: Allow voting from crashed initial tablet copies .. Patch Set 4: Code-Review+2 (1 comment) BTW, what was the setting for --stress_cpu_threads for

[kudu-CR] Add tablet state summary metrics

2017-09-06 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Add tablet state summary metrics .. Patch Set 4: Code-Review+1 Please get an additional review from Mike and/or Todd. -- To view, visit

[kudu-CR] tablet copy: Allow voting from crashed initial tablet copies

2017-09-06 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: tablet copy: Allow voting from crashed initial tablet copies .. Patch Set 3: (1 comment)

[kudu-CR] KUDU-2044 Tombstoned tablets show up in /metrics

2017-09-06 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-2044 Tombstoned tablets show up in /metrics .. Patch Set 3: Code-Review+1 (2 comments) Please solicit reviews from Todd and Mike.

[kudu-CR] tablet copy: Allow voting from crashed initial tablet copies

2017-09-06 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: tablet copy: Allow voting from crashed initial tablet copies .. Patch Set 3: (2 comments)

[kudu-CR] tablet copy: Allow voting from crashed initial tablet copies

2017-09-06 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: tablet copy: Allow voting from crashed initial tablet copies .. Patch Set 3: (1 comment)

[kudu-CR] tablet copy: Allow voting from crashed initial tablet copies

2017-09-06 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: tablet copy: Allow voting from crashed initial tablet copies .. Patch Set 4: FYI I looped tablet_copy-itest 200x on the latest rev and didn't see any failures:

[kudu-CR] Add tablet state summary metrics

2017-09-06 Thread Will Berkeley (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7980 to look at the new patch set (#4). Change subject: Add tablet state summary metrics .. Add tablet state summary

[kudu-CR] Add tablet state summary metrics

2017-09-06 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: Add tablet state summary metrics .. Patch Set 3: (5 comments) http://gerrit.cloudera.org:8080/#/c/7980/1/src/kudu/integration-tests/tablet_copy-itest.cc File

[kudu-CR] tablet copy: Allow voting from crashed initial tablet copies

2017-09-06 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: tablet copy: Allow voting from crashed initial tablet copies .. Patch Set 3: (1 comment)

[kudu-CR] KUDU-2119. Fix failure in encoding-test

2017-09-06 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: KUDU-2119. Fix failure in encoding-test .. KUDU-2119. Fix failure in encoding-test In commit d1f53cc32 I introduced randomization for the format string

[kudu-CR] tablet copy: Allow voting from crashed initial tablet copies

2017-09-06 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: tablet copy: Allow voting from crashed initial tablet copies .. Patch Set 4: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/7961 To unsubscribe,

[kudu-CR] KUDU-1755 Part 2: Improve tablet on-disk size metric

2017-09-06 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: KUDU-1755 Part 2: Improve tablet on-disk size metric .. Patch Set 13: (1 comment)

[kudu-CR] KUDU-2044 Tombstoned tablets show up in /metrics

2017-09-06 Thread Will Berkeley (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7981 to look at the new patch set (#3). Change subject: KUDU-2044 Tombstoned tablets show up in /metrics .. KUDU-2044

[kudu-CR] KUDU-2044 Tombstoned tablets show up in /metrics

2017-09-06 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: KUDU-2044 Tombstoned tablets show up in /metrics .. Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/7981/1//COMMIT_MSG Commit Message: PS1, Line

[kudu-CR] KUDU-2119. Fix failure in encoding-test

2017-09-06 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-2119. Fix failure in encoding-test .. Patch Set 4: Code-Review+2 I didn't actually review this, but three +1s should warrant a +2. -- To view, visit

[kudu-CR] KUDU-2134: Defer block transaction commit to the end of a tablet copy

2017-09-06 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-2134: Defer block transaction commit to the end of a tablet copy .. Patch Set 4: Code-Review+1 (1 comment) Please get a +2 from Mike.

[kudu-CR] KUDU-2119. Fix failure in encoding-test

2017-09-06 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: KUDU-2119. Fix failure in encoding-test .. Patch Set 4: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/7967/2/src/kudu/cfile/encoding-test.cc

[kudu-CR] Add tablet state summary metrics

2017-09-06 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Add tablet state summary metrics .. Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/7980/3/src/kudu/integration-tests/tablet_copy-itest.cc File

[kudu-CR] KUDU-2119. Fix failure in encoding-test

2017-09-06 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. Change subject: KUDU-2119. Fix failure in encoding-test .. Patch Set 4: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/7967 To unsubscribe, visit

[kudu-CR] KUDU-1755 Part 2: Improve tablet on-disk size metric

2017-09-06 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: KUDU-1755 Part 2: Improve tablet on-disk size metric .. Patch Set 15: (1 comment)

[kudu-CR] docs: update disk failure recovery notes

2017-09-06 Thread Andrew Wong (Code Review)
Andrew Wong has uploaded a new change for review. http://gerrit.cloudera.org:8080/7984 Change subject: docs: update disk failure recovery notes .. docs: update disk failure recovery notes Adds more context around disk

[kudu-CR] KUDU-2119. Fix failure in encoding-test

2017-09-06 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. Change subject: KUDU-2119. Fix failure in encoding-test .. Patch Set 4: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/7967 To unsubscribe, visit

[kudu-CR] tablet copy: Allow voting from crashed initial tablet copies

2017-09-06 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: tablet copy: Allow voting from crashed initial tablet copies .. Patch Set 3: (1 comment)

[kudu-CR] tablet copy: Allow voting from crashed initial tablet copies

2017-09-06 Thread Mike Percy (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7961 to look at the new patch set (#4). Change subject: tablet copy: Allow voting from crashed initial tablet copies ..

[kudu-CR] test workload: make table creation more robust

2017-09-06 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. Change subject: test_workload: make table creation more robust .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/7982 To unsubscribe, visit

[kudu-CR] tablet copy: Allow voting from crashed initial tablet copies

2017-09-06 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: tablet copy: Allow voting from crashed initial tablet copies .. Patch Set 3: (4 comments)

[kudu-CR] Add tablet state summary metrics

2017-09-06 Thread Will Berkeley (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7980 to look at the new patch set (#3). Change subject: Add tablet state summary metrics .. Add tablet state summary

[kudu-CR] KUDU-2134: Defer block transaction commit to the end of a tablet copy

2017-09-06 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. Change subject: KUDU-2134: Defer block transaction commit to the end of a tablet copy .. Patch Set 4: > > The test failure is unrelated to your change. > > I put up a fix for

[kudu-CR] KUDU-2134: Defer block transaction commit to the end of a tablet copy

2017-09-06 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. Change subject: KUDU-2134: Defer block transaction commit to the end of a tablet copy .. Patch Set 4: (8 comments)

[kudu-CR] KUDU-2134: Defer block transaction commit to the end of a tablet copy

2017-09-06 Thread Hao Hao (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7966 to look at the new patch set (#4). Change subject: KUDU-2134: Defer block transaction commit to the end of a tablet copy

[kudu-CR] test workload: make table creation more robust

2017-09-06 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: test_workload: make table creation more robust .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7982 To unsubscribe, visit

[kudu-CR] KUDU-1807: improve IsCreateInProgress performance

2017-09-06 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-1807: improve IsCreateInProgress performance .. Patch Set 3: (11 comments) http://gerrit.cloudera.org:8080/#/c/7957/3/src/kudu/master/catalog_manager.cc

[kudu-CR] KUDU-2044 Tombstoned tablets show up in /metrics

2017-09-06 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-2044 Tombstoned tablets show up in /metrics .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/7981/1//COMMIT_MSG Commit Message: PS1, Line

[kudu-CR] KUDU-2044 Tombstoned tablets show up in /metrics

2017-09-06 Thread Will Berkeley (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7981 to look at the new patch set (#2). Change subject: KUDU-2044 Tombstoned tablets show up in /metrics .. KUDU-2044

[kudu-CR] KUDU-2044 Tombstoned tablets show up in /metrics

2017-09-06 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: KUDU-2044 Tombstoned tablets show up in /metrics .. Patch Set 1: (7 comments) http://gerrit.cloudera.org:8080/#/c/7981/1//COMMIT_MSG Commit Message: PS1, Line

[kudu-CR] Add tablet state summary metrics

2017-09-06 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Add tablet state summary metrics .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/7980/2/src/kudu/tserver/ts_tablet_manager.cc File

[kudu-CR] Add tablet state summary metrics

2017-09-06 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: Add tablet state summary metrics .. Patch Set 2: (4 comments) I added a test and fixed a bug (plus the changes from your comments)

[kudu-CR] KUDU-1755 Part 2: Improve tablet on-disk size metric

2017-09-06 Thread Will Berkeley (Code Review)
Hello Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6968 to look at the new patch set (#15). Change subject: KUDU-1755 Part 2: Improve tablet on-disk size metric

[kudu-CR] Add tablet state summary metrics

2017-09-06 Thread Will Berkeley (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7980 to look at the new patch set (#2). Change subject: Add tablet state summary metrics .. Add tablet state summary

[kudu-CR] KUDU-2119. Fix failure in encoding-test

2017-09-06 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-2119. Fix failure in encoding-test .. Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/7967/2/src/kudu/cfile/encoding-test.cc File

[kudu-CR] KUDU-2119. Fix failure in encoding-test

2017-09-06 Thread Todd Lipcon (Code Review)
Hello Will Berkeley, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7967 to look at the new patch set (#4). Change subject: KUDU-2119. Fix failure in encoding-test ..

[kudu-CR] test workload: make table creation more robust

2017-09-06 Thread Adar Dembo (Code Review)
Adar Dembo has uploaded a new patch set (#2). Change subject: test_workload: make table creation more robust .. test_workload: make table creation more robust The table creation here already works around the lack of Exactly

[kudu-CR] KUDU-2134: Defer block transaction commit to the end of a tablet copy

2017-09-06 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-2134: Defer block transaction commit to the end of a tablet copy .. Patch Set 3: > The test failure is unrelated to your change. I put up a fix for this

[kudu-CR] test workload: make table creation more robust

2017-09-06 Thread Adar Dembo (Code Review)
Hello Todd Lipcon, Alexey Serbin, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/7982 to review the following change. Change subject: test_workload: make table creation more robust ..

[kudu-CR] KUDU-1755 Part 2: Improve tablet on-disk size metric

2017-09-06 Thread Will Berkeley (Code Review)
Hello Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6968 to look at the new patch set (#14). Change subject: KUDU-1755 Part 2: Improve tablet on-disk size metric

[kudu-CR] KUDU-1755 Part 2: Improve tablet on-disk size metric

2017-09-06 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: KUDU-1755 Part 2: Improve tablet on-disk size metric .. Patch Set 13: (4 comments)

[kudu-CR] KUDU-2044 Tombstoned tablets show up in /metrics

2017-09-06 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-2044 Tombstoned tablets show up in /metrics .. Patch Set 1: (7 comments) http://gerrit.cloudera.org:8080/#/c/7981/1//COMMIT_MSG Commit Message: PS1, Line

[kudu-CR] tablet copy: Allow voting from crashed initial tablet copies

2017-09-06 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: tablet copy: Allow voting from crashed initial tablet copies .. Patch Set 3: (3 comments)

[kudu-CR] Add tablet state summary metrics

2017-09-06 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Add tablet state summary metrics .. Patch Set 1: (5 comments) Has anything materially changed since the split?

[kudu-CR] KUDU-1755 Part 2: Improve tablet on-disk size metric

2017-09-06 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: KUDU-1755 Part 2: Improve tablet on-disk size metric .. Patch Set 13: (2 comments)

[kudu-CR] Add tablet state summary metrics and fix KUDU-2044

2017-09-06 Thread Will Berkeley (Code Review)
Will Berkeley has abandoned this change. Change subject: Add tablet state summary metrics and fix KUDU-2044 .. Abandoned Split into two patches. Tablet state metrics: http://gerrit.cloudera.org:8080/7980 KUDU-2044:

[kudu-CR] KUDU-2044 Tombstoned tablets show up in /metrics

2017-09-06 Thread Will Berkeley (Code Review)
Will Berkeley has uploaded a new change for review. http://gerrit.cloudera.org:8080/7981 Change subject: KUDU-2044 Tombstoned tablets show up in /metrics .. KUDU-2044 Tombstoned tablets show up in /metrics This patch stops

[kudu-CR] Add tablet state summary metrics

2017-09-06 Thread Will Berkeley (Code Review)
Will Berkeley has uploaded a new change for review. http://gerrit.cloudera.org:8080/7980 Change subject: Add tablet state summary metrics .. Add tablet state summary metrics This patch adds metrics for the number of tablets

[kudu-CR] [tests] fix flakes in delete table-itest

2017-09-06 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7972 to look at the new patch set (#3). Change subject: [tests] fix flakes in delete_table-itest .. [tests] fix flakes

[kudu-CR] KUDU-2119. Fix failure in encoding-test

2017-09-06 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. Change subject: KUDU-2119. Fix failure in encoding-test .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/7967/3/src/kudu/cfile/encoding-test.cc File

[kudu-CR] KUDU-2119. Fix failure in encoding-test

2017-09-06 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. Change subject: KUDU-2119. Fix failure in encoding-test .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/7967/3/src/kudu/cfile/encoding-test.cc File

[kudu-CR] KUDU-2119. Fix failure in encoding-test

2017-09-06 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: KUDU-2119. Fix failure in encoding-test .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/7967/2/src/kudu/cfile/encoding-test.cc File

[kudu-CR] KUDU-2119. Fix failure in encoding-test

2017-09-06 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: KUDU-2119. Fix failure in encoding-test .. Patch Set 3: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/7967/2/src/kudu/cfile/encoding-test.cc

[kudu-CR] KUDU-2119. Fix failure in encoding-test

2017-09-06 Thread Todd Lipcon (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7967 to look at the new patch set (#3). Change subject: KUDU-2119. Fix failure in encoding-test .. KUDU-2119. Fix

[kudu-CR] KUDU-2119. Fix failure in encoding-test

2017-09-06 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-2119. Fix failure in encoding-test .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/7967/2/src/kudu/cfile/encoding-test.cc File

[kudu-CR] KUDU-2119. Fix failure in encoding-test

2017-09-06 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: KUDU-2119. Fix failure in encoding-test .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/7967/2/src/kudu/cfile/encoding-test.cc File

[kudu-CR] tablet copy: Allow voting from crashed initial tablet copies

2017-09-06 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: tablet copy: Allow voting from crashed initial tablet copies .. Patch Set 3: (4 comments)

[kudu-CR] KUDU-2119. Fix failure in encoding-test

2017-09-06 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-2119. Fix failure in encoding-test .. Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/7967/1//COMMIT_MSG Commit Message: Line 16: The fix

[kudu-CR](branch-1.5.x) KUDU-2130 (part 2): more fixes for ITClientStress

2017-09-06 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: KUDU-2130 (part 2): more fixes for ITClientStress .. Patch Set 1: Code-Review+2 Perhaps, you want to get +2 from JD as well? -- To view, visit

[kudu-CR](branch-1.5.x) KUDU-2130: java client: handle termination during negotiation edge case

2017-09-06 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: KUDU-2130: java client: handle termination during negotiation edge case .. Patch Set 1: Code-Review+2 Perhaps, you want to get +2 from JD as well? -- To

[kudu-CR] KUDU-2119. Fix failure in encoding-test

2017-09-06 Thread Todd Lipcon (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7967 to look at the new patch set (#2). Change subject: KUDU-2119. Fix failure in encoding-test .. KUDU-2119. Fix

[kudu-CR](branch-1.5.x) KUDU-2130: java client: handle termination during negotiation edge case

2017-09-06 Thread Dan Burkert (Code Review)
Dan Burkert has uploaded a new change for review. http://gerrit.cloudera.org:8080/7978 Change subject: KUDU-2130: java client: handle termination during negotiation edge case .. KUDU-2130: java client: handle termination

[kudu-CR](branch-1.5.x) KUDU-2130 (part 2): more fixes for ITClientStress

2017-09-06 Thread Dan Burkert (Code Review)
Dan Burkert has uploaded a new change for review. http://gerrit.cloudera.org:8080/7979 Change subject: KUDU-2130 (part 2): more fixes for ITClientStress .. KUDU-2130 (part 2): more fixes for ITClientStress This fixes some

  1   2   >