[Impala-ASF-CR] IMPALA-4924: Enable Decimal V2 by default

2018-01-19 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. ( http://gerrit.cloudera.org:8080/9062 ) Change subject: IMPALA-4924: Enable Decimal V2 by default .. Patch Set 5: (4 comments) http://gerrit.cloudera.org:8080/#/c/9062/5/be/src

[Impala-ASF-CR] IMPALA-6420: Fix TestCharFormats for local filesystem tests

2018-01-19 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. ( http://gerrit.cloudera.org:8080/9074 ) Change subject: IMPALA-6420: Fix TestCharFormats for local filesystem tests .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/

[Impala-ASF-CR] IMPALA-6429: Fix decimal division

2018-01-24 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. ( http://gerrit.cloudera.org:8080/9114 ) Change subject: IMPALA-6429: Fix decimal division .. Patch Set 1: (5 comments) http://gerrit.cloudera.org:8080/#/c/9114/1/be/src/exprs/e

[Impala-ASF-CR] IMPALA-6440: Backwards compatibility for HBase metadata

2018-01-24 Thread Zach Amsden (Code Review)
Zach Amsden has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9124 Change subject: IMPALA-6440: Backwards compatibility for HBase metadata .. IMPALA-6440: Backwards compatibility for HBase metadata Upstrea

[Impala-ASF-CR] IMPALA-6440: Backwards compatibility for HBase metadata

2018-01-24 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. ( http://gerrit.cloudera.org:8080/9124 ) Change subject: IMPALA-6440: Backwards compatibility for HBase metadata .. Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c

[Impala-ASF-CR] IMPALA-6440: Backwards compatibility for HBase metadata

2018-01-24 Thread Zach Amsden (Code Review)
Hello Philip Zeyliger, Dimitris Tsirogiannis, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9124 to look at the new patch set (#2). Change subject: IMPALA-6440: Backwards compatibility for HBase metadata

[Impala-ASF-CR] IMPALA-6440: Backwards compatibility for HBase metadata

2018-01-24 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. ( http://gerrit.cloudera.org:8080/9124 ) Change subject: IMPALA-6440: Backwards compatibility for HBase metadata .. Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c

[Impala-ASF-CR] IMPALA-6440: Backwards compatibility for HBase metadata

2018-01-25 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. ( http://gerrit.cloudera.org:8080/9124 ) Change subject: IMPALA-6440: Backwards compatibility for HBase metadata .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/

[Impala-ASF-CR] IMPALA-6440: Backwards compatibility for HBase metadata

2018-01-25 Thread Zach Amsden (Code Review)
Zach Amsden has abandoned this change. ( http://gerrit.cloudera.org:8080/9124 ) Change subject: IMPALA-6440: Backwards compatibility for HBase metadata .. Abandoned Looks like the Hive change is going to be reverted; no longer

[Impala-ASF-CR] IMPALA-6429: Fix decimal division

2018-01-31 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. ( http://gerrit.cloudera.org:8080/9114 ) Change subject: IMPALA-6429: Fix decimal division .. Patch Set 3: (5 comments) http://gerrit.cloudera.org:8080/#/c/9114/3/be/src/exprs/e

[Impala-ASF-CR] IMPALA-6429: Fix decimal division

2018-02-01 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. ( http://gerrit.cloudera.org:8080/9114 ) Change subject: IMPALA-6429: Fix decimal division .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/9114/3/be/src/util/dec

[Impala-ASF-CR] IMPALA-6429: Fix decimal division

2018-02-01 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. ( http://gerrit.cloudera.org:8080/9114 ) Change subject: IMPALA-6429: Fix decimal division .. Patch Set 4: Code-Review+1 Dan, Tim, any last comments? -- To view, visit http://g

[Impala-ASF-CR] IMPALA-6429: Fix decimal division

2018-02-01 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. ( http://gerrit.cloudera.org:8080/9114 ) Change subject: IMPALA-6429: Fix decimal division .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/9114/3/be/src/util/dec

[Impala-ASF-CR] IMPALA-6204: Remove external DataSource

2018-02-05 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. ( http://gerrit.cloudera.org:8080/9192 ) Change subject: IMPALA-6204: Remove external DataSource .. Patch Set 4: (5 comments) http://gerrit.cloudera.org:8080/#/c/9192/4//COMMIT_

[Impala-ASF-CR] IMPALA-6405: Error when string to decimal cast overflows

2018-02-15 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. ( http://gerrit.cloudera.org:8080/9339 ) Change subject: IMPALA-6405: Error when string to decimal cast overflows .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/

[Impala-ASF-CR] IMPALA-6405: Error when string to decimal cast overflows

2018-03-05 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. ( http://gerrit.cloudera.org:8080/9339 ) Change subject: IMPALA-6405: Error when string to decimal cast overflows .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.c

[Impala-ASF-CR] IMPALA-6230, IMPALA-6468: Fix the output type of round() and related fns

2018-03-05 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. ( http://gerrit.cloudera.org:8080/9346 ) Change subject: IMPALA-6230, IMPALA-6468: Fix the output type of round() and related fns .. Patch Set 1: (3 comments) http://gerrit.clo

[Impala-ASF-CR] IMPALA-6389: Make '\0' delimited text files work

2018-03-06 Thread Zach Amsden (Code Review)
Zach Amsden has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9525 Change subject: IMPALA-6389: Make '\0' delimited text files work .. IMPALA-6389: Make '\0' delimited text files work This is conflated a b

[Impala-ASF-CR] IMPALA-6500: gracefully handle invalid sched getcpu() values

2018-03-08 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. ( http://gerrit.cloudera.org:8080/9544 ) Change subject: IMPALA-6500: gracefully handle invalid sched_getcpu() values .. Patch Set 2: Code-Review+2 (1 comment) Looks good, up to

[Impala-ASF-CR] IMPALA-6389: Make '\0' delimited text files work

2018-03-08 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. ( http://gerrit.cloudera.org:8080/9525 ) Change subject: IMPALA-6389: Make '\0' delimited text files work .. Patch Set 1: (6 comments) http://gerrit.cloudera.org:8080/#/c/9525/1

[Impala-ASF-CR] IMPALA-6389: Make '\0' delimited text files work

2018-03-12 Thread Zach Amsden (Code Review)
Hello Tim Armstrong, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9525 to look at the new patch set (#2). Change subject: IMPALA-6389: Make '\0' delimited text files work .. I

[Impala-ASF-CR] IMPALA-6389: Make '\0' delimited text files work

2018-03-15 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. ( http://gerrit.cloudera.org:8080/9525 ) Change subject: IMPALA-6389: Make '\0' delimited text files work .. Patch Set 2: (5 comments) http://gerrit.cloudera.org:8080/#/c/9525/2

[Impala-ASF-CR] IMPALA-6389: Make '\0' delimited text files work

2018-03-15 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. ( http://gerrit.cloudera.org:8080/9525 ) Change subject: IMPALA-6389: Make '\0' delimited text files work .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/9525/1/

[Impala-ASF-CR] IMPALA-6389: Make '\0' delimited text files work

2018-03-20 Thread Zach Amsden (Code Review)
Hello Tim Armstrong, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9525 to look at the new patch set (#3). Change subject: IMPALA-6389: Make '\0' delimited text files work .. I

[Impala-ASF-CR] IMPALA-6389: Make '\0' delimited text files work

2018-03-21 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. ( http://gerrit.cloudera.org:8080/9525 ) Change subject: IMPALA-6389: Make '\0' delimited text files work .. Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/9525/3

[Impala-ASF-CR] IMPALA-6389: Make '\0' delimited text files work

2018-03-21 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. ( http://gerrit.cloudera.org:8080/9525 ) Change subject: IMPALA-6389: Make '\0' delimited text files work .. Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/9525/3

[Impala-ASF-CR] IMPALA-6389: Make '\0' delimited text files work

2018-03-22 Thread Zach Amsden (Code Review)
Hello Tim Armstrong, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9525 to look at the new patch set (#4). Change subject: IMPALA-6389: Make '\0' delimited text files work .. I

[Impala-ASF-CR] IMPALA-6670: refresh lib-cache entries from plan

2018-03-22 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. ( http://gerrit.cloudera.org:8080/9697 ) Change subject: IMPALA-6670: refresh lib-cache entries from plan .. Patch Set 19: (10 comments) http://gerrit.cloudera.org:8080/#/c/9697

[Impala-ASF-CR] IMPALA-6670: refresh lib-cache entries from plan

2018-03-22 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. ( http://gerrit.cloudera.org:8080/9697 ) Change subject: IMPALA-6670: refresh lib-cache entries from plan .. Patch Set 19: (1 comment) http://gerrit.cloudera.org:8080/#/c/9697/1

[Impala-ASF-CR] IMPALA-6670: refresh lib-cache entries from plan

2018-03-22 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. ( http://gerrit.cloudera.org:8080/9697 ) Change subject: IMPALA-6670: refresh lib-cache entries from plan .. Patch Set 20: (2 comments) http://gerrit.cloudera.org:8080/#/c/9697/

[Impala-ASF-CR] IMPALA-6389: Make '\0' delimited text files work

2018-03-22 Thread Zach Amsden (Code Review)
Hello Tim Armstrong, Dan Hecht, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9525 to look at the new patch set (#5). Change subject: IMPALA-6389: Make '\0' delimited text files work ..

[Impala-ASF-CR] IMPALA-6389: Make '\0' delimited text files work

2018-03-22 Thread Zach Amsden (Code Review)
Hello Tim Armstrong, Dan Hecht, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9525 to look at the new patch set (#6). Change subject: IMPALA-6389: Make '\0' delimited text files work ..

[Impala-ASF-CR] IMPALA-6389: Make '\0' delimited text files work

2018-03-22 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. ( http://gerrit.cloudera.org:8080/9525 ) Change subject: IMPALA-6389: Make '\0' delimited text files work .. Patch Set 4: Sigh. Release build failed. Fixed now. -- To view, v

[Impala-ASF-CR] IMPALA-6670: refresh lib-cache entries from plan

2018-03-22 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. ( http://gerrit.cloudera.org:8080/9697 ) Change subject: IMPALA-6670: refresh lib-cache entries from plan .. Patch Set 21: Code-Review+2 -- To view, visit http://gerrit.cloudera

[Impala-ASF-CR] IMPALA-6389: Make '\0' delimited text files work

2018-03-27 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. ( http://gerrit.cloudera.org:8080/9525 ) Change subject: IMPALA-6389: Make '\0' delimited text files work .. Patch Set 6: I think so; I'll let it run through GVO first. -- To v

[Impala-ASF-CR] Revert "IMPALA-6389: Make '\0' delimited text files work"

2018-03-28 Thread Zach Amsden (Code Review)
Zach Amsden has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9851 Change subject: Revert "IMPALA-6389: Make '\0' delimited text files work" .. Revert "IMPALA-6389: Make '\0' delimited text files work" Thi

[Impala-ASF-CR] Revert "IMPALA-6389: Make '\0' delimited text files work"

2018-03-28 Thread Zach Amsden (Code Review)
Zach Amsden has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9851 ) Change subject: Revert "IMPALA-6389: Make '\0' delimited text files work" .. Revert "IMPALA-6389: Make '\0' delimited text files w

[Impala-ASF-CR] Revert "IMPALA-6389: Make '\0' delimited text files work"

2018-03-28 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. ( http://gerrit.cloudera.org:8080/9851 ) Change subject: Revert "IMPALA-6389: Make '\0' delimited text files work" .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.clo

[Impala-ASF-CR] Revert "IMPALA-6389: Make '\0' delimited text files work"

2018-03-28 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. ( http://gerrit.cloudera.org:8080/9851 ) Change subject: Revert "IMPALA-6389: Make '\0' delimited text files work" .. Patch Set 2: Strict revert; verified to fix build. -- To v

[Impala-ASF-CR] IMPALA-6389: Make '\0' delimited text files work

2018-03-29 Thread Zach Amsden (Code Review)
Zach Amsden has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9857 Change subject: IMPALA-6389: Make '\0' delimited text files work .. IMPALA-6389: Make '\0' delimited text files work Initially I didn't wa

[Impala-ASF-CR] IMPALA-6389: Make '\0' delimited text files work

2018-03-29 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. ( http://gerrit.cloudera.org:8080/9857 ) Change subject: IMPALA-6389: Make '\0' delimited text files work .. Patch Set 1: Here's the diff highlighting the issue: diff --git a/be

[Impala-ASF-CR] IMPALA-6389: Make '\0' delimited text files work

2018-03-29 Thread Zach Amsden (Code Review)
Hello Tim Armstrong, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9857 to look at the new patch set (#2). Change subject: IMPALA-6389: Make '\0' delimited text files work .. I

[Impala-ASF-CR] IMPALA-6389: Make '\0' delimited text files work

2018-03-29 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. ( http://gerrit.cloudera.org:8080/9857 ) Change subject: IMPALA-6389: Make '\0' delimited text files work .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/9857/1/

[Impala-ASF-CR] IMPALA-6776: Increase region move timeout.

2018-04-02 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. ( http://gerrit.cloudera.org:8080/9892 ) Change subject: IMPALA-6776: Increase region move timeout. .. Patch Set 1: Code-Review+2 Seems fine; it seems weirdly coincidental that s

[Impala-ASF-CR] IMPALA-6389: Make '\0' delimited text files work

2018-04-05 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. ( http://gerrit.cloudera.org:8080/9857 ) Change subject: IMPALA-6389: Make '\0' delimited text files work .. Patch Set 3: Code-Review+2 Yes, I did - forgot to carry the +2 after

[Impala-ASF-CR] IMPALA-6389: Make '\0' delimited text files work

2018-04-05 Thread Zach Amsden (Code Review)
Zach Amsden has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9857 ) Change subject: IMPALA-6389: Make '\0' delimited text files work .. IMPALA-6389: Make '\0' delimited text files work Initially I

[Impala-ASF-CR] IMPALA-6206: Fix data load failure with -notests

2017-11-16 Thread Zach Amsden (Code Review)
Zach Amsden has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8580 Change subject: IMPALA-6206: Fix data load failure with -notests .. IMPALA-6206: Fix data load failure with -notests When tests are not bu

[Impala-ASF-CR] IMPALA-6206: Fix data load failure with -notests

2017-11-16 Thread Zach Amsden (Code Review)
Hello Michael Brown, Philip Zeyliger, David Knupp, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8580 to look at the new patch set (#2). Change subject: IMPALA-6206: Fix data load failure with -notests ..

[Impala-ASF-CR] IMPALA-6206: Fix data load failure with -notests

2017-11-17 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. ( http://gerrit.cloudera.org:8080/8580 ) Change subject: IMPALA-6206: Fix data load failure with -notests .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/8580/2/

[Impala-ASF-CR] IMPALA-6206: Fix data load failure with -notests

2017-11-17 Thread Zach Amsden (Code Review)
Hello Michael Brown, Philip Zeyliger, David Knupp, Tim Armstrong, Joe McDonnell, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8580 to look at the new patch set (#3). Change subject: IMPALA-6206: Fix data load failure with -notests

[Impala-ASF-CR] IMPALA-6206: Fix data load failure with -notests

2017-11-17 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. ( http://gerrit.cloudera.org:8080/8580 ) Change subject: IMPALA-6206: Fix data load failure with -notests .. Patch Set 3: Even simpler, we don't need a new target at all. -- To

[Impala-ASF-CR] IMPALA-4927: Impala should handle invalid input from Sentry

2017-11-20 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. ( http://gerrit.cloudera.org:8080/8588 ) Change subject: IMPALA-4927: Impala should handle invalid input from Sentry .. Patch Set 4: (3 comments) What version of Sentry was caus

[Impala-ASF-CR] IMPALA-4927: Impala should handle invalid input from Sentry

2017-11-21 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. ( http://gerrit.cloudera.org:8080/8588 ) Change subject: IMPALA-4927: Impala should handle invalid input from Sentry .. Patch Set 5: (2 comments) http://gerrit.cloudera.org:8080

[Impala-ASF-CR] IMPALA-4927: Impala should handle invalid input from Sentry

2017-11-21 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. ( http://gerrit.cloudera.org:8080/8588 ) Change subject: IMPALA-4927: Impala should handle invalid input from Sentry .. Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/

[Impala-ASF-CR] IMPALA-4927: Impala should handle invalid input from Sentry

2017-11-21 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. ( http://gerrit.cloudera.org:8080/8588 ) Change subject: IMPALA-4927: Impala should handle invalid input from Sentry .. Patch Set 8: To answer Phil's question, no, a role only gr

[Impala-ASF-CR] IMPALA-4927: Impala should handle invalid input from Sentry

2017-11-21 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. ( http://gerrit.cloudera.org:8080/8588 ) Change subject: IMPALA-4927: Impala should handle invalid input from Sentry .. Patch Set 9: Code-Review+2 -- To view, visit http://gerri

[Impala-ASF-CR] IMPALA-6206: Fix data load failure with -notests

2017-11-21 Thread Zach Amsden (Code Review)
Hello Lars Volker, Michael Brown, Philip Zeyliger, David Knupp, Tim Armstrong, Joe McDonnell, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8580 to look at the new patch set (#4). Change subject: IMPALA-6206: Fix data load failure with -notests ..

[Impala-ASF-CR] IMPALA-6206: Fix data load failure with -notests

2017-11-22 Thread Zach Amsden (Code Review)
Zach Amsden has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8580 ) Change subject: IMPALA-6206: Fix data load failure with -notests .. IMPALA-6206: Fix data load failure with -notests When tests a

[Impala-ASF-CR] IMPALA-6206: Fix data load failure with -notests

2017-11-22 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. ( http://gerrit.cloudera.org:8080/8580 ) Change subject: IMPALA-6206: Fix data load failure with -notests .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.

[Impala-ASF-CR] IMPALA-4927: Impala should handle invalid input from Sentry

2017-11-22 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. ( http://gerrit.cloudera.org:8080/8588 ) Change subject: IMPALA-4927: Impala should handle invalid input from Sentry .. Patch Set 10: Code-Review+2 I'm not entirely convinced tha

[Impala-ASF-CR] Revert "IMPALA-6068: Fix dataload for complextypes fileformat"

2017-11-27 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. ( http://gerrit.cloudera.org:8080/8653 ) Change subject: Revert "IMPALA-6068: Fix dataload for complextypes_fileformat" .. Patch Set 1: Code-Review+2 I reviewed the original and

[Impala-ASF-CR] IMPALA-6244: Fix test failures with Hadoop 3.0

2017-11-27 Thread Zach Amsden (Code Review)
Zach Amsden has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8656 Change subject: IMPALA-6244: Fix test failures with Hadoop 3.0 .. IMPALA-6244: Fix test failures with Hadoop 3.0 The metadata query test f

[Impala-ASF-CR] IMPALA-6068: Scale back fixing functional-types

2017-11-29 Thread Zach Amsden (Code Review)
Zach Amsden has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8690 Change subject: IMPALA-6068: Scale back fixing functional-types .. IMPALA-6068: Scale back fixing functional-types I re-created the origin

[Impala-ASF-CR] IMPALA-6244: Fix test failures with Hadoop 3.0

2017-11-29 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. ( http://gerrit.cloudera.org:8080/8656 ) Change subject: IMPALA-6244: Fix test failures with Hadoop 3.0 .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/8656/1/t

[Impala-ASF-CR] IMPALA-6244: Fix test failures with Hadoop 3.0

2017-11-29 Thread Zach Amsden (Code Review)
Hello Philip Zeyliger, David Knupp, Tim Wood, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8656 to look at the new patch set (#2). Change subject: IMPALA-6244: Fix test failures with Hadoop 3.0 ..

[Impala-ASF-CR] IMPALA-6244: Fix test failures with Hadoop 3.0

2017-11-29 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. ( http://gerrit.cloudera.org:8080/8656 ) Change subject: IMPALA-6244: Fix test failures with Hadoop 3.0 .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/8656/2/t

[Impala-ASF-CR] IMPALA-6244: Fix test failures with Hadoop 3.0

2017-11-29 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. ( http://gerrit.cloudera.org:8080/8656 ) Change subject: IMPALA-6244: Fix test failures with Hadoop 3.0 .. Patch Set 2: > (2 comments) Sigh, bad link - here is the permalink: h

[Impala-ASF-CR] IMPALA-6244: Fix test failures with Hadoop 3.0

2017-11-29 Thread Zach Amsden (Code Review)
Hello Philip Zeyliger, David Knupp, Tim Wood, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8656 to look at the new patch set (#3). Change subject: IMPALA-6244: Fix test failures with Hadoop 3.0 ..

[Impala-ASF-CR] IMPALA-6068: Scale back fixing functional-types

2017-11-30 Thread Zach Amsden (Code Review)
Hello Philip Zeyliger, David Knupp, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8690 to look at the new patch set (#3). Change subject: IMPALA-6068: Scale back fixing functional-types ...

[Impala-ASF-CR] IMPALA-6068: Scale back fixing functional-types

2017-11-30 Thread Zach Amsden (Code Review)
Hello Philip Zeyliger, David Knupp, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8690 to look at the new patch set (#4). Change subject: IMPALA-6068: Scale back fixing functional-types ...

[Impala-ASF-CR] IMPALA-6068: Scale back fixing functional-types

2017-12-01 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. ( http://gerrit.cloudera.org:8080/8690 ) Change subject: IMPALA-6068: Scale back fixing functional-types .. Patch Set 4: (1 comment) 22:54:51 FAILED (Took: 11 min 53 sec) 22

[Impala-ASF-CR] IMPALA-6068: Scale back fixing functional-types

2017-12-01 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. ( http://gerrit.cloudera.org:8080/8690 ) Change subject: IMPALA-6068: Scale back fixing functional-types .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/8690/4/t

[Impala-ASF-CR] IMPALA-6245: Tolerate column indenting from Hive

2017-12-01 Thread Zach Amsden (Code Review)
Zach Amsden has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8719 Change subject: IMPALA-6245: Tolerate column indenting from Hive .. IMPALA-6245: Tolerate column indenting from Hive The fix for HIVE-3140

[Impala-ASF-CR] IMPALA-6245: Tolerate column indenting from Hive

2017-12-01 Thread Zach Amsden (Code Review)
Zach Amsden has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/8719 ) Change subject: IMPALA-6245: Tolerate column indenting from Hive .. IMPALA-6245: Tolerate column indenting from Hive The fix for HIVE-3140

[Impala-ASF-CR] IMPALA-6245: Tolerate column indenting from Hive

2017-12-01 Thread Zach Amsden (Code Review)
Zach Amsden has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/8719 ) Change subject: IMPALA-6245: Tolerate column indenting from Hive .. IMPALA-6245: Tolerate column indenting from Hive The fix for HIVE-3140

[Impala-ASF-CR] IMPALA-6068: Scale back fixing functional-types

2017-12-04 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. ( http://gerrit.cloudera.org:8080/8690 ) Change subject: IMPALA-6068: Scale back fixing functional-types .. Patch Set 4: I still can't see anything that would actually change bas

[Impala-ASF-CR] IMPALA-6068: Scale back fixing functional-types

2017-12-04 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. ( http://gerrit.cloudera.org:8080/8690 ) Change subject: IMPALA-6068: Scale back fixing functional-types .. Patch Set 4: Finally! Anyone care to review? -- To view, visit http

[Impala-ASF-CR] IMPALA-6068: Scale back fixing functional-types

2017-12-04 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. ( http://gerrit.cloudera.org:8080/8690 ) Change subject: IMPALA-6068: Scale back fixing functional-types .. Patch Set 5: Code-Review+2 Rebased, carry the +2 -- To view, visit h

[Impala-ASF-CR] IMPALA-6068: Scale back fixing functional-types

2017-12-04 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. ( http://gerrit.cloudera.org:8080/8690 ) Change subject: IMPALA-6068: Scale back fixing functional-types .. Patch Set 5: Verified+1 -- To view, visit http://gerrit.cloudera.org:

[Impala-ASF-CR] IMPALA-6068: Scale back fixing functional-types

2017-12-04 Thread Zach Amsden (Code Review)
Zach Amsden has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8690 ) Change subject: IMPALA-6068: Scale back fixing functional-types .. IMPALA-6068: Scale back fixing functional-types I re-created t

[Impala-ASF-CR] IMPALA-6067: Enable S3 access via IAM roles for EC2 VMs

2017-12-04 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. ( http://gerrit.cloudera.org:8080/8294 ) Change subject: IMPALA-6067: Enable S3 access via IAM roles for EC2 VMs .. Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c

[Impala-ASF-CR] IMPALA-6067: Enable S3 access via IAM roles for EC2 VMs

2017-12-08 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. ( http://gerrit.cloudera.org:8080/8294 ) Change subject: IMPALA-6067: Enable S3 access via IAM roles for EC2 VMs .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/

[Impala-ASF-CR] IMPALA-6067: Enable S3 access via IAM roles for EC2 VMs

2017-12-08 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. ( http://gerrit.cloudera.org:8080/8294 ) Change subject: IMPALA-6067: Enable S3 access via IAM roles for EC2 VMs .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.cl

[Impala-ASF-CR] IMPALA-6245: Tolerate column indenting from Hive

2017-12-08 Thread Zach Amsden (Code Review)
Hello Philip Zeyliger, David Knupp, Joe McDonnell, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8719 to look at the new patch set (#5). Change subject: IMPALA-6245: Tolerate column indenting from Hive ...

[Impala-ASF-CR] IMPALA-6245: Tolerate column indenting from Hive

2017-12-08 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. ( http://gerrit.cloudera.org:8080/8719 ) Change subject: IMPALA-6245: Tolerate column indenting from Hive .. Patch Set 4: (4 comments) http://gerrit.cloudera.org:8080/#/c/8719/4

[Impala-ASF-CR] IMPALA-6245: Tolerate column indenting from Hive

2017-12-11 Thread Zach Amsden (Code Review)
Hello Philip Zeyliger, David Knupp, Joe McDonnell, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8719 to look at the new patch set (#6). Change subject: IMPALA-6245: Tolerate column indenting from Hive ...

[Impala-ASF-CR] IMPALA-6245: Tolerate column indenting from Hive

2017-12-11 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. ( http://gerrit.cloudera.org:8080/8719 ) Change subject: IMPALA-6245: Tolerate column indenting from Hive .. Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/8719/5/

[Impala-ASF-CR] IMPALA-6245: Tolerate column indenting from Hive

2017-12-11 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. ( http://gerrit.cloudera.org:8080/8719 ) Change subject: IMPALA-6245: Tolerate column indenting from Hive .. Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/8719/6/

[Impala-ASF-CR] IMPALA-6245: Tolerate column indenting from Hive

2017-12-11 Thread Zach Amsden (Code Review)
Hello Philip Zeyliger, David Knupp, Joe McDonnell, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8719 to look at the new patch set (#7). Change subject: IMPALA-6245: Tolerate column indenting from Hive ...

[Impala-ASF-CR] IMPALA-6245: Tolerate column indenting from Hive

2017-12-11 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. ( http://gerrit.cloudera.org:8080/8719 ) Change subject: IMPALA-6245: Tolerate column indenting from Hive .. Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/8719/7/

[Impala-ASF-CR] IMPALA-5014: Part 1: Round when casting string to decimal

2017-12-12 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. ( http://gerrit.cloudera.org:8080/8774 ) Change subject: IMPALA-5014: Part 1: Round when casting string to decimal .. Patch Set 2: (9 comments) http://gerrit.cloudera.org:8080/#

[Impala-ASF-CR] IMPALA-5014: Part 1: Round when casting string to decimal

2017-12-13 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. ( http://gerrit.cloudera.org:8080/8774 ) Change subject: IMPALA-5014: Part 1: Round when casting string to decimal .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/

[Impala-ASF-CR] IMPALA-6270: remove redundant version properties

2017-12-13 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. ( http://gerrit.cloudera.org:8080/8827 ) Change subject: IMPALA-6270: remove redundant version properties .. Patch Set 1: Code-Review+2 (1 comment) http://gerrit.cloudera.org:80

[Impala-ASF-CR] IMPALA-6300: Fix decimal modulo overflow

2017-12-14 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. ( http://gerrit.cloudera.org:8080/8833 ) Change subject: IMPALA-6300: Fix decimal modulo overflow .. Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/8833/1/be/src/

[Impala-ASF-CR] IMPALA-6300: Fix decimal modulo overflow

2017-12-15 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. ( http://gerrit.cloudera.org:8080/8833 ) Change subject: IMPALA-6300: Fix decimal modulo overflow .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/8833/1/be/src/r

[Impala-ASF-CR] IMPALA-6300: Fix decimal modulo overflow

2017-12-15 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. ( http://gerrit.cloudera.org:8080/8833 ) Change subject: IMPALA-6300: Fix decimal modulo overflow .. Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/8833/1/be/src/

[Impala-ASF-CR] IMPALA-6300: Fix decimal modulo overflow

2017-12-15 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. ( http://gerrit.cloudera.org:8080/8833 ) Change subject: IMPALA-6300: Fix decimal modulo overflow .. Patch Set 2: Now that I see your new diff, you can ignore my CheckMultiply co

[Impala-ASF-CR] IMPALA-6300: Fix decimal modulo overflow

2017-12-15 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. ( http://gerrit.cloudera.org:8080/8833 ) Change subject: IMPALA-6300: Fix decimal modulo overflow .. Patch Set 2: (2 comments) Other than deprecating GetScaleQuotient, this look

[Impala-ASF-CR] Remove unused deps, centralize some pom versions, upgrade SLF4J and commons-io.

2017-12-19 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. ( http://gerrit.cloudera.org:8080/8853 ) Change subject: Remove unused deps, centralize some pom versions, upgrade SLF4J and commons-io. .. Patch Set 3: Code-Review+2 -- To vie

[Impala-ASF-CR] IMPALA-5014: Part 1: Round when casting string to decimal

2017-12-21 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. ( http://gerrit.cloudera.org:8080/8774 ) Change subject: IMPALA-5014: Part 1: Round when casting string to decimal .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/

  1   2   >