Re: Announcing a proof of concept REST API for VDSM

2011-12-01 Thread Dan Kenigsberg
On Tue, Nov 29, 2011 at 03:36:04PM -0600, Adam Litke wrote: > > Hopefully monitorCommand will not be too bad, since vdsm should be asking > libvirt for the VM details when they are needed. Of course we'll need to be > testing to make sure we aren't keeping state around. Also, I would expect > mo

Re: RFC: MOM OS-level integration

2011-12-01 Thread Dan Kenigsberg
On Tue, Nov 29, 2011 at 07:21:08PM +, Daniel P. Berrange wrote: > On Tue, Nov 29, 2011 at 01:11:18PM -0600, Adam Litke wrote: > > On Tue, Nov 29, 2011 at 05:44:23PM +, Daniel P. Berrange wrote: > > > On Tue, Nov 29, 2011 at 11:18:42AM -0600, Adam Litke wrote: > > > > On Tue, Nov 29, 2011 at

Re: RFC: MOM OS-level integration

2011-12-01 Thread Dan Kenigsberg
On Thu, Dec 01, 2011 at 11:05:55AM +0200, Dor Laor wrote: > On 11/29/2011 06:29 PM, Adam Litke wrote: > > After discussing MOM / VDSM integration at length, two different strategies > > have > > emerged. I will call them Plan A and Plan B: > > > > Plan A: MOM integration at the OS/Packaging level

Re: Facing logrotate problem

2011-12-02 Thread Dan Kenigsberg
On Fri, Dec 02, 2011 at 03:16:15PM +0800, Hunt Xu wrote: > Hi, all! > > vdsm-logrotate kept reporting errors like "error: skipping > "/var/log/core/core.3150.1321682189.dump" because parent directory has > insecure permissions (It's world writable or writable by group which is > not "root") Set "s

Re: reorganizing constants and config

2011-12-02 Thread Dan Kenigsberg
On Thu, Dec 01, 2011 at 10:13:53PM -0500, Saggi Mizrahi wrote: > I want to suggest a different way of handling constants.py and config.py > the current way is clumsy and makes making convoluted code easy. > > GLOBAL VARIABLES ARE BAD. It's not something I invented. It's well > accepted that prope

Re: reorganizing constants and config

2011-12-04 Thread Dan Kenigsberg
On Sat, Dec 03, 2011 at 06:08:45PM -0500, Ayal Baron wrote: > > > - Original Message - > > On Thu, Dec 01, 2011 at 10:13:53PM -0500, Saggi Mizrahi wrote: > > > I want to suggest a different way of handling constants.py and > > > config.py > > > the current way is clumsy and makes making c

Re: can't start vdsmd and failed to connect it

2011-12-05 Thread Dan Kenigsberg
On Mon, Dec 05, 2011 at 04:51:53PM +0800, Jenna Johnson wrote: > On 5 December 2011 15:51, Yaniv Kaul wrote: > > > On 12/05/2011 09:49 AM, Jenna Johnson wrote: > > > > Folks, > > > > Installed vdsm,nothing abnormal encountered,but when start vdsmd: > > > > $ sudo service vdsmd star

Re: Fix error message "UnboundLocalError: local variable 'path' referenced before assignment" when running vm.

2011-12-06 Thread Dan Kenigsberg
On Tue, Dec 06, 2011 at 02:10:48PM +0800, Jarod. w wrote: > Hi, All > > The patch will fix error message "UnboundLocalError: local variable > 'path' referenced before assignment" when running vm. > > thanks. > > >From 1f99c4f5b04100231c8712f2caf97d11dcc9eb37 Mon Sep 17 00:00:00 2001 > Fr

Re: can't start vdsmd and failed to connect it

2011-12-06 Thread Dan Kenigsberg
On Tue, Dec 06, 2011 at 04:15:34PM +0800, Jenna Johnson wrote: > After created /etc/vdsm/vdsm.conf and set ssl=False,reconfiured service > vdsmd, > > still this: > $ sudo service vdsmd status > VDS daemon is not running > > vdsmd still can't register because of argument validation failure: This

Re: API design and plan

2011-12-06 Thread Dan Kenigsberg
On Mon, Dec 05, 2011 at 11:34:18AM -0600, Adam Litke wrote: > Hi everyone. On today's VDSM call we discussed the requirements, design, and > plan for updating the API to include support for QMF and single-host REST API. > All members present arrived at a general consensus on the best way to design

Re: RFC: MOM OS-level integration

2011-12-06 Thread Dan Kenigsberg
On Tue, Dec 06, 2011 at 12:42:24PM +0200, Dor Laor wrote: > > > >This is one advantage, but cetainly not the only one. More importantly, as > >pointed out by Dan K. and Dan B., keeping it separate will encourage > >modularization which is greatly needed in vdsm. As part of this > >modularizat

Re: API design and plan

2011-12-06 Thread Dan Kenigsberg
On Tue, Dec 06, 2011 at 08:46:57AM -0600, Adam Litke wrote: > On Tue, Dec 06, 2011 at 02:58:59PM +0200, Dan Kenigsberg wrote: > > On Mon, Dec 05, 2011 at 11:34:18AM -0600, Adam Litke wrote: > > > Hi everyone. On today's VDSM call we discussed the requirements, design, &

Re: vdsm network interfaces and directory structure

2011-12-11 Thread Dan Kenigsberg
On Sat, Dec 10, 2011 at 09:39:44PM +0200, Itamar Heim wrote: > On 12/09/2011 06:15 PM, Douglas Landgraf wrote: > > On 12/08/2011 09:59 PM, Douglas Landgraf wrote: > >> Hi, > >> > >> On 12/08/2011 02:31 PM, Douglas Landgraf wrote: > >>> On 12/08/2011 10:14 AM, Perry Myers wrote: > > /opt is used

Re: Facing logrotate problem

2011-12-11 Thread Dan Kenigsberg
On Tue, Dec 06, 2011 at 01:21:09PM -0700, dann frazier wrote: > On Fri, Dec 02, 2011 at 03:16:15PM +0800, Hunt Xu wrote: > > Hi, all! > > > > vdsm-logrotate kept reporting errors like "error: skipping > > "/var/log/core/core.3150.1321682189.dump" because parent directory has > > insecure permissio

Re: Facing logrotate problem

2011-12-11 Thread Dan Kenigsberg
On Wed, Dec 07, 2011 at 11:09:13AM +0800, Hunt Xu wrote: > On Fri, Dec 2, 2011 at 9:30 PM, Dan Kenigsberg wrote: > > > However, I am not aware of the specific error that you are seeing. Which > > vdsm > > are you using? which kernel? where is the error log shown?

Re: RFC: MOM OS-level integration

2011-12-11 Thread Dan Kenigsberg
Laor wrote: > > >>> On 12/05/2011 03:55 PM, Adam Litke wrote: > > >>>> On Sun, Dec 04, 2011 at 11:07:43PM +0200, Dor Laor wrote: > > >>>>> On 12/02/2011 04:15 PM, Adam Litke wrote: > > >>>>>> On Fri, Dec 02, 2011 at 03:08:2

Re: [Engine-devel] shared fs support

2011-12-13 Thread Dan Kenigsberg
On Tue, Dec 13, 2011 at 02:57:33PM -0500, Saggi Mizrahi wrote: > On Sun 11 Dec 2011 10:15:23 AM EST, Andrew Cathrow wrote: > > > > > > - Original Message - > >> From: "Saggi Mizrahi" > >> To: "VDSM Project Development", > >> engine-de...@ovirt.org > >> Sent: Friday, December 9, 2011 5:41:4

Re: [Engine-devel] shared fs support

2011-12-16 Thread Dan Kenigsberg
On Thu, Dec 15, 2011 at 12:37:58PM -0500, Saggi Mizrahi wrote: > On Wed 14 Dec 2011 02:29:53 AM EST, Dan Kenigsberg wrote: > >On Tue, Dec 13, 2011 at 02:57:33PM -0500, Saggi Mizrahi wrote: > >>On Sun 11 Dec 2011 10:15:23 AM EST, Andrew Cathrow wrote: > >>> >

Re: VDSM Data Types

2011-12-25 Thread Dan Kenigsberg
On Fri, Dec 23, 2011 at 07:12:14AM -0500, Igor Lvovsky wrote: > > > - Original Message - > > From: "Adam Litke" > > To: vdsm-devel@lists.fedorahosted.org > > Sent: Friday, December 23, 2011 2:52:06 AM > > Subject: VDSM Data Types > > > > This week I spent some time analyzing the paramet

getDeviceList should report partioned devices, too

2012-01-08 Thread Dan Kenigsberg
Hi Lists, One cannot create a PV on a partitioned device, and therefor such devices where not reported to Engine. This proved surprising to users who woder where their LUN disappeared. Vdsm should report all devices, and ovirt-engine should mark partitioned devices as unworthy of a PV. In the fut

Re: getDeviceList should report partitioned devices, too

2012-01-17 Thread Dan Kenigsberg
On Sun, Jan 08, 2012 at 03:08:13PM +0200, Dan Kenigsberg wrote: > Hi Lists, > > One cannot create a PV on a partitioned device, and therefor such > devices where not reported to Engine. This proved surprising to users > who woder where their LUN disappeared. > > Vdsm shou

Re: getDeviceList should report partitioned devices, too

2012-01-18 Thread Dan Kenigsberg
On Tue, Jan 17, 2012 at 07:46:17PM +0200, Livnat Peer wrote: > On 17/01/12 16:08, Dan Kenigsberg wrote: > > On Sun, Jan 08, 2012 at 03:08:13PM +0200, Dan Kenigsberg wrote: > >> Hi Lists, > >> > >> One cannot create a PV on a partitioned device, and therefor suc

Re: getDeviceList should report partitioned devices, too

2012-01-19 Thread Dan Kenigsberg
On Wed, Jan 18, 2012 at 06:17:53AM -0500, Ayal Baron wrote: > Can we broaden the scope and also allow passing createVG partitioned devices > with an override flag or something? (we'd need to check the devices and run > "kpartx -d" and fdisk to clean the devices before calling pvcreate). We can,

Re: [vdsm] about migration

2012-02-01 Thread Dan Kenigsberg
On Wed, Feb 01, 2012 at 02:20:26PM +0200, Itamar Heim wrote: > On 02/01/2012 11:16 AM, David Jaša wrote: > >wangxiaofan píše v St 01. 02. 2012 v 07:48 +0800: > >>Hi, > >> To do migration, why vdsm/libvirt requires DNS server or hostnames > >>in hosts file? Is there any way to do migration direc

Re: [vdsm] flowID schema

2012-02-06 Thread Dan Kenigsberg
On Thu, Feb 02, 2012 at 12:00:44AM -0500, Douglas Landgraf wrote: > Hello, > > flowID is schema that we will be including in vdsm API to oVirt > Engine people share the ID of engine transaction to vdsm. > With this in hands, we will add the ID of transactions to our log. > > I would like to

Re: [vdsm] flowID schema

2012-02-06 Thread Dan Kenigsberg
On Thu, Feb 02, 2012 at 10:32:49AM -0500, Saggi Mizrahi wrote: > flowID makes no sense after the initial API call as stuff like > cacheing\threadpools\samplingtasks\resources\asyncTasks so flowing a flow > like that will not give you the entire picture while debugging. > > Also adding it now wil

Re: [vdsm] flowID schema

2012-02-11 Thread Dan Kenigsberg
On Thu, Feb 09, 2012 at 03:23:19PM -0500, Ayal Baron wrote: > > > - Original Message - > > -1 > > > > I agree that for messaging environment having a Message ID is a must > > because you sometimes don't have a particular target so when you get > > a response you need to know what this no

Re: [vdsm] About the wiki page installing_VDSM_from_rpm

2012-02-13 Thread Dan Kenigsberg
On Mon, Feb 13, 2012 at 10:31:02AM +0800, Shu Ming wrote: > Hi, > I was installing the VDSM packaging following this link: > http://www.ovirt.org/wiki/Installing_VDSM_from_rpm > > It seems that the network configuration section is not correct. In > this wiki page, the static IP is assigned to

Re: [vdsm] flowID schema

2012-02-14 Thread Dan Kenigsberg
On Mon, Feb 13, 2012 at 12:06:46PM -0500, Ayal Baron wrote: > > > - Original Message - > > On 02/13/2012 02:28 PM, Ayal Baron wrote: > > > > > ... > > >>> is that it (ab)uses an http header for carrying FlowID, > > >> Yes, it certainly does appear to overload it. I would be nice to > > >

Re: [vdsm] VDSM host network configuration

2012-02-15 Thread Dan Kenigsberg
On Thu, Feb 16, 2012 at 12:05:16AM +0800, Lei Li wrote: > Hi, > > We are working on VDSM network REST APIs, to support the functions we need to > get > the list of configured networks. I found that VDSM network has a function > 'listNetworks' in configNetwork.py. It can get and display the curren

Re: [vdsm] VDSM host network configuration

2012-02-15 Thread Dan Kenigsberg
On Thu, Feb 16, 2012 at 10:55:16AM +0800, Lei Li wrote: > On 02/16/2012 07:22 AM, Adam Litke wrote: > >On Wed, Feb 15, 2012 at 06:36:48PM +0200, Dan Kenigsberg wrote: > >>On Thu, Feb 16, 2012 at 12:05:16AM +0800, Lei Li wrote: > >>>Hi, > >>> > &g

Re: [vdsm] Question about _filterXmlChars

2012-02-20 Thread Dan Kenigsberg
On Mon, Feb 20, 2012 at 03:53:00PM +0800, Mark Wu wrote: > Hi All, > > I have a question about _filterXmlChars. If only printable ascii > characters appear in the message reported by ovirt-guest-agent, > then we needn't call _filterXmlChars() because the unicode shouldn't > contain the restricte

Re: [vdsm] Procedure for restarting vdsm

2012-02-21 Thread Dan Kenigsberg
On Tue, Feb 21, 2012 at 04:11:27PM +0530, Deepak C Shetty wrote: > Hi, > I haven't found this info elsewhere, hence asking here. > > 1) What is the procedure to restart vdsm on the host ? Do i need to > put host in maint. mode > and then manually kill vdsm and supervdsm parent process or use

Re: [vdsm] Error creating fc based storage domain

2012-02-21 Thread Dan Kenigsberg
On Tue, Feb 21, 2012 at 04:42:42PM +0530, Deepak C Shetty wrote: > Hello, > This is the error i see in vdsm.log > Any pointers appreciated. > > Thread-237764::INFO::2012-02-21 > 22:04:52,785::logUtils::37::dispatcher::(wrapper) Run and protect: > createVG(vgname='2b63c813-6bd5-4488-904c-dba1c8

Re: [vdsm] non-TLS spice connections

2012-02-21 Thread Dan Kenigsberg
On Tue, Feb 21, 2012 at 04:53:24PM +0100, Christophe Fergeau wrote: > Hey, > > I recently setup ovirt/vdsm on one of my boxes. For some reason spice TLS > was disabled through spice_tls = no in /etc/libvirt/qemu.conf. > Then I created a VM, started it, and had troubles connecting to it with > spic

Re: [vdsm] non-TLS spice connections

2012-02-22 Thread Dan Kenigsberg
On Tue, Feb 21, 2012 at 05:17:50PM +0100, Christophe Fergeau wrote: > Hi, > > On Tue, Feb 21, 2012 at 06:09:06PM +0200, Dan Kenigsberg wrote: > > Please note Bug 788092 - VDSM: Disable vdsm's ssl'ability influence > > spice ssl'ability and prevent VM from star

Re: [vdsm] Run and protect profiling tools and scripts?

2012-02-23 Thread Dan Kenigsberg
On Thu, Feb 23, 2012 at 10:53:45AM +, Lee Yarwood wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > On 02/21/2012 04:24 AM, Saggi Mizrahi wrote: > > I actually create a tool that times execCmd calss and run and protect > > calls. I'll look for it tomorrow morning and check if it st

Re: [vdsm] vdsm test release plan

2012-02-27 Thread Dan Kenigsberg
On Wed, Feb 22, 2012 at 11:05:50PM +0800, Royce Lv wrote: >Guys, >* We have unittest cases for VDSM REST API at hand and expect to merge >them with* VDSM test harness. So would someone provide a schedule of VDSM >test release plan? Will it be released with VDSM or in another >

Re: [vdsm] Error when running autobuild

2012-03-03 Thread Dan Kenigsberg
On Fri, Mar 02, 2012 at 09:49:10AM +0200, Itamar Heim wrote: > On 03/01/2012 08:18 PM, Ewoud Kohl van Wijngaarden wrote: > >On Thu, Mar 01, 2012 at 03:18:59PM +, Itzik Brown wrote: > >>I have a problem building vdsm on RHEL 6.2 > >> > >>After running the following: > >> > >># git clone http://g

Re: [vdsm] Error when running autobuild

2012-03-04 Thread Dan Kenigsberg
On Sun, Mar 04, 2012 at 12:40:47AM +0200, Itamar Heim wrote: > On 03/04/2012 12:36 AM, Dan Kenigsberg wrote: > >On Fri, Mar 02, 2012 at 09:49:10AM +0200, Itamar Heim wrote: > >>On 03/01/2012 08:18 PM, Ewoud Kohl van Wijngaarden wrote: > >>>On Thu, Mar 01, 2012 at

Re: [vdsm] Failed dependencies when installing VDSM from git

2012-03-05 Thread Dan Kenigsberg
On Sun, Mar 04, 2012 at 10:29:57PM +0800, Shu Ming wrote: > On 2012-3-4 19:29, Itzik Brown wrote: > >Hi, > > > >After running the following : > ># git clone http://gerrit.ovirt.org/p/vdsm.git > ># cd vdsm > ># git fetch http://gerrit.ovirt.org/p/vdsm refs/changes/95/1695/10&& git > >checkout FETC

Re: [vdsm] createStorageDomain failure but dir structure is created !

2012-03-05 Thread Dan Kenigsberg
On Mon, Mar 05, 2012 at 12:04:36AM +0530, Deepak C Shetty wrote: > On 03/02/2012 11:54 PM, Deepak C Shetty wrote: > >On 03/02/2012 11:27 PM, Deepak C Shetty wrote: > >>Hi, > >>In my simple experiment, i connected to a SHAREDFS storage > >>server and then created a data domain > >>But the create

Re: [vdsm] createStorageDomain failure but dir structure is created !

2012-03-05 Thread Dan Kenigsberg
On Tue, Mar 06, 2012 at 10:57:49AM +0530, Deepak C Shetty wrote: > On 03/06/2012 04:21 AM, Dan Kenigsberg wrote: > >On Mon, Mar 05, 2012 at 12:04:36AM +0530, Deepak C Shetty wrote: > >>On 03/02/2012 11:54 PM, Deepak C Shetty wrote: > >>>On 03/02/2012 11:27 PM, D

Re: [vdsm] Installing VDSM on an empty Fedora 16 machine?

2012-03-07 Thread Dan Kenigsberg
On Wed, Mar 07, 2012 at 03:07:32PM +0100, Saša Tomić wrote: > > On 03/07/2012 02:43 PM, Shu Ming wrote: > >On 2012-3-7 21:38, Saša Tomić wrote: > >> > >>vdsClient -s 0 getVdsCaps > > > >Does "vdsClient 0 getVdsCaps" without '-s" work? "-s" means > >secure connection. > > > yep, exactly the same..

Re: [vdsm] Installing VDSM on an empty Fedora 16 machine?

2012-03-07 Thread Dan Kenigsberg
On Wed, Mar 07, 2012 at 04:03:33PM +0100, Saša Tomić wrote: > On 03/07/2012 03:41 PM, Dan Kenigsberg wrote: > >That's empty because in Fedora vdsm uses the now-standard systemd > >/lib/systemd/system/vdsmd.service > > > >which for some reason fails to start. I

Re: [vdsm] Installing VDSM on an empty Fedora 16 machine?

2012-03-08 Thread Dan Kenigsberg
On Thu, Mar 08, 2012 at 12:04:45PM +0100, Saša Tomić wrote: > > > On 03/08/2012 11:56 AM, Federico Simoncelli wrote: > >- Original Message - > >> > >>We are getting closer now, it appears that some paths are broken... > >> > >>2012-03-07 15:42:58.134+: 1590: error : > >>virNetTLSConte

Re: [vdsm] [Users] How to configure sharedFS ?

2012-03-19 Thread Dan Kenigsberg
On Wed, Mar 14, 2012 at 07:04:47PM +0530, Deepak C Shetty wrote: > On 02/29/2012 08:06 PM, Dan Kenigsberg wrote: > >On Wed, Feb 29, 2012 at 07:42:15PM +0530, Deepak C Shetty wrote: > >>On 02/27/2012 04:55 AM, Ayal Baron wrote: > >>>Any help on documenting this so peo

Re: [vdsm] PEP8 in VDSM code

2012-03-25 Thread Dan Kenigsberg
On Thu, Mar 22, 2012 at 04:18:10PM -0400, Saggi Mizrahi wrote: > I suggest having pep8 a must for patch submission in VDSM. > http://www.python.org/dev/peps/pep-0008/ > > Currently there are a few people policing these rules in reviews but I > suggest we make it automatic. > > Unless someone obj

Re: [vdsm] Running VDSM (master branch) on Fedora 16

2012-04-04 Thread Dan Kenigsberg
On Tue, Apr 03, 2012 at 01:02:31PM -0400, Federico Simoncelli wrote: > Hi all, > lately we introduced two new requirements in the VDSM master branch, > therefore if you want to run the latest code on Fedora 16 you need to > update some packages that aren't shipped officially (yet): > > lvm2-2.02.

Re: [vdsm] Running VDSM (master branch) on Fedora 16

2012-04-04 Thread Dan Kenigsberg
On Wed, Apr 04, 2012 at 03:43:13AM -0400, Federico Simoncelli wrote: > - Original Message - > > From: "Dan Kenigsberg" > > To: "Federico Simoncelli" > > Cc: "VDSM Project Development" > > Sent: Wednesday, April 4, 2012 9:36:26 A

Re: [vdsm] Running VDSM (master branch) on Fedora 16

2012-04-04 Thread Dan Kenigsberg
On Wed, Apr 04, 2012 at 04:20:18AM -0400, Federico Simoncelli wrote: > > > - Original Message - > > From: "Federico Simoncelli" > > To: "Dan Kenigsberg" > > Cc: "VDSM Project Development" > > Sent: Wednesday, April 4, 20

Re: [vdsm] /etc/rc.c/init.d/vdsmd set filters for libvirt at DEBUG level

2012-04-06 Thread Dan Kenigsberg
On Thu, Apr 05, 2012 at 04:42:47PM -0400, Saggi Mizrahi wrote: > > You are correct though that setting the logging level back or changing the > amount of logs kept shouldn't be such a bothersome process and you should > open a bug on that for VDSM and it will be fixed. > Since Bugzilla reports

Re: [vdsm] /etc/rc.c/init.d/vdsmd set filters for libvirt at DEBUG level

2012-04-08 Thread Dan Kenigsberg
On Fri, Apr 06, 2012 at 10:10:40AM -0400, Adam Litke wrote: > On Fri, Apr 06, 2012 at 03:23:10PM +0300, Dan Kenigsberg wrote: > > On Thu, Apr 05, 2012 at 04:42:47PM -0400, Saggi Mizrahi wrote: > > > > > > You are correct though that setting the logging level back or ch

Re: [vdsm] code sign-off/DCO for ovirt projects

2012-04-08 Thread Dan Kenigsberg
On Sat, Apr 07, 2012 at 01:00:27AM +0300, Itamar Heim wrote: > On 04/06/2012 06:00 PM, Ryan Harper wrote: > >Re-sending this to arch as in our meeting this week we agreed[1] no reason > >to not implement DCO (http://kerneltrap.org/files/Jeremy/DCO.txt) but > >that we needed to enlist the maintainer

Re: [vdsm] upstream/downstream compat

2012-04-09 Thread Dan Kenigsberg
On Fri, Apr 06, 2012 at 09:58:09AM -0500, Ryan Harper wrote: > I've submitted some changes to start some of the work of removing the > RHEV/RHEVM names throughout the vdsm code. In one of the patches, > there's a good discussion on compatibility with downstream[1] > And I wanted to continue that o

Re: [vdsm] Test that broken upstream

2012-04-10 Thread Dan Kenigsberg
On Mon, Apr 09, 2012 at 12:37:42PM -0400, Saggi Mizrahi wrote: > Upstream will not currently build because of the following patch: > > Reviewed-by: Dan Kenigsberg > Tested-by: Dan Kenigsberg Yeah, it is my fault, I know. But a teeny weeny part of the blame is shared by

Re: [vdsm] Test failure on RHEL6 host

2012-04-12 Thread Dan Kenigsberg
On Thu, Apr 12, 2012 at 02:59:51PM +0800, Mark Wu wrote: > I failed to build latest vdsm code on RHEL6 host because of test > failure as below: > > make[2]: Entering directory `/home/mark/Work/vdsm/vdsm-src/tests' > ../tests/run_tests.sh main.py miscTests.py resourceManagerTests.py > processPoolTe

[vdsm] non-optional unit tests

2012-04-16 Thread Dan Kenigsberg
Finally, we have a working, if incomplete, set of unit tests in our project. Thanks, Saggi (and others!). Every module should have comprehensive unit tests. Writing good unit tests can be hard, and writing testable code is even harder. However, I would like to request that every new module, and ev

Re: [vdsm] Storage Device Management in VDSM and oVirt

2012-04-18 Thread Dan Kenigsberg
(Note that vdsm-devel is on fedorahosted.org. vdsm-de...@ovirt.org was created by mistake, and I believe we agreed to dropped it) On Tue, Apr 17, 2012 at 03:38:25PM +0530, Shireesh Anjal wrote: > Hi all, > > As part of adding Gluster support in ovirt, we need to introduce > some Storage Device ma

Re: [vdsm] Storage Device Management in VDSM and oVirt

2012-04-18 Thread Dan Kenigsberg
On Wed, Apr 18, 2012 at 09:06:36AM -0400, Ayal Baron wrote: > > > - Original Message - > > On Tue, Apr 17, 2012 at 03:38:25PM +0530, Shireesh Anjal wrote: > > > Hi all, > > > > > > As part of adding Gluster support in ovirt, we need to introduce > > > some Storage Device management capab

Re: [vdsm] upstream/downstream compat

2012-04-21 Thread Dan Kenigsberg
On Mon, Apr 09, 2012 at 07:25:24AM -0500, Ryan Harper wrote: > * Dan Kenigsberg [2012-04-09 04:21]: > > On Fri, Apr 06, 2012 at 09:58:09AM -0500, Ryan Harper wrote: > > > I've submitted some changes to start some of the work of removing the > > > RHEV/RHEVM names t

[vdsm] minutes: today's call

2012-04-23 Thread Dan Kenigsberg
On Mon, Apr 23, 2012 at 07:34:14AM -0500, Adam Litke wrote: > On Mon, Apr 23, 2012 at 04:17:18AM -0400, Ayal Baron wrote: > > Hi all, > > > > I would like to discuss the following on today's call: > > > > 1. Gerrit vs. mailing list Gerrit is an inhibiter for some contributors. One approach to so

Re: [vdsm] pep8 check in vim

2012-04-24 Thread Dan Kenigsberg
On Tue, Apr 24, 2012 at 10:39:24AM +0800, Lei Li wrote: > On 04/12/2012 10:48 PM, Saggi Mizrahi wrote: > >Now that we started moving to conform with pep8 you would probably like to > >be able to easily check your code. > > > >If you use vim you could use this vim script > >http://www.vim.org/scrip

Re: [vdsm] changing vdsm spec file to use python 2.7.3 on Fedora

2012-04-24 Thread Dan Kenigsberg
On Tue, Apr 24, 2012 at 05:10:40PM +0800, wenchao xia wrote: > Hello, > I am planning to let vdsm use python 2.7.3 for that race condition > was found in subprocess.Popen and threading.Thread in python 2.7.2 on > Fedora 16. The test case could be found in previous mails. > gerrit: http://gerrit.o

Re: [vdsm] Unit tests

2012-04-24 Thread Dan Kenigsberg
On Wed, Apr 25, 2012 at 04:12:03AM +0800, ShaoHe Feng wrote: > build error, when Unit tests. > > Here is the info: > File > "/home/fsh/work/vm/wkspace/vdsm/vdsm-apply-rest/vdsm/vdsm/configNetwork.py", > line 37, in > from vdsm import libvirtconnection > ImportError: cannot import name libvi

Re: [vdsm] changing vdsm spec file to use python 2.7.3 on Fedora

2012-04-25 Thread Dan Kenigsberg
On Wed, Apr 25, 2012 at 05:17:47PM +0800, wenchao xia wrote: > Tested again on el6.2, passed. > With more test and code reading of cpython, I think this bug is > introduced by a bugfix in python: > http://bugs.python.org/issue13156 > The patch solving the bug I met in python2.7.2, is: > chang

Re: [vdsm] reserve virtio-balloon device created by libvirt

2012-04-29 Thread Dan Kenigsberg
On Mon, Apr 23, 2012 at 04:00:55PM +0300, Gal Hammer wrote: > On 23/04/2012 12:26, Mark Wu wrote: > >Hi guys, > > > >I saw that an option to create balloon device was added by Gal in > >http://gerrit.ovirt.org/1573 > >I have a question about it. Why don we preserve the old default > >behaviour? I k

Re: [vdsm] reserve virtio-balloon device created by libvirt

2012-04-29 Thread Dan Kenigsberg
On Sun, Apr 29, 2012 at 07:24:52AM -0400, Andrew Cathrow wrote: > > > - Original Message - > > From: "Dan Kenigsberg" > > To: "Gal Hammer" > > Cc: vdsm-devel@lists.fedorahosted.org > > Sent: Sunday, April 29, 2012 7:19:10 AM > >

Re: [vdsm] Introducing a validation test package to vdsm

2012-04-30 Thread Dan Kenigsberg
On Fri, Apr 27, 2012 at 11:22:20AM +0800, wenchao xia wrote: > 于 2012-4-27 5:13, Ewoud Kohl van Wijngaarden 写道: > >On Thu, Apr 26, 2012 at 11:11:49AM -0500, Adam Litke wrote: > >>On Thu, Apr 26, 2012 at 11:12:06PM +0800, Shu Ming wrote: > >>>One more comment about the test package version. Most li

Re: [vdsm] Introducing a validation test package to vdsm

2012-04-30 Thread Dan Kenigsberg
On Fri, Apr 27, 2012 at 11:19:21AM +0800, wenchao xia wrote: > 于 2012-4-26 21:57, Adam Litke 写道: > >On Thu, Apr 26, 2012 at 05:24:29PM +0800, wenchao xia wrote: > >>Hello, > >> vdsm now have UT suits for developer, but sometimes building and > >>installation machine is not the same one, and addit

Re: [vdsm] Introducing a validation test package to vdsm

2012-05-02 Thread Dan Kenigsberg
On Wed, May 02, 2012 at 08:36:18AM +0800, wenchao xia wrote: > 于 2012-4-30 17:26, Dan Kenigsberg 写道: > >On Fri, Apr 27, 2012 at 11:19:21AM +0800, wenchao xia wrote: > >>于 2012-4-26 21:57, Adam Litke 写道: > >>>On Thu, Apr 26, 2012 at 05:24:29PM +0800, wenchao xia wro

Re: [vdsm] Introducing a validation test package to vdsm

2012-05-03 Thread Dan Kenigsberg
On Wed, May 02, 2012 at 08:08:07PM +0800, wenchao xia wrote: > 于 2012-5-2 19:53, Dan Kenigsberg 写道: > >On Wed, May 02, 2012 at 08:36:18AM +0800, wenchao xia wrote: > >>于 2012-4-30 17:26, Dan Kenigsberg 写道: > >>>On Fri, Apr 27, 2012 at 11:19:21AM +0800, wenchao xia

Re: [vdsm] minutes: today's call

2012-05-07 Thread Dan Kenigsberg
On Mon, Apr 23, 2012 at 05:52:13PM +0300, Dan Kenigsberg wrote: > On Mon, Apr 23, 2012 at 07:34:14AM -0500, Adam Litke wrote: > > On Mon, Apr 23, 2012 at 04:17:18AM -0400, Ayal Baron wrote: > > > Hi all, > > > > > > I would like to discuss the following on tod

[vdsm] Vdsm minutes: May 7th's call

2012-05-07 Thread Dan Kenigsberg
On Mon, May 07, 2012 at 01:41:20PM +0300, Dan Kenigsberg wrote: > On Mon, Apr 23, 2012 at 05:52:13PM +0300, Dan Kenigsberg wrote: > > On Mon, Apr 23, 2012 at 07:34:14AM -0500, Adam Litke wrote: > > > On Mon, Apr 23, 2012 at 04:17:18AM -0400, Ayal Baron wrote: > > > &

Re: [vdsm] can not access the network by virsh

2012-05-07 Thread Dan Kenigsberg
On Tue, May 08, 2012 at 12:45:56AM +0800, ShaoHe Feng wrote: > virsh # net-list --all > Please enter your authentication name: vdsm@rhevh > Please enter your password: > > I get the password form /etc/pki/vdsm/keys/libvirt_password. > > the authentication name and password are not right. The im

Re: [vdsm] error when run vdsClient

2012-05-08 Thread Dan Kenigsberg
On Wed, May 09, 2012 at 01:42:45AM +0800, ShaoHe Feng wrote: > > $ sudo ./autobuild.sh > build vdsm, and all test OK. > > then rpm install the rpm package. > > and start the vdsm > $ sudo systemctl start vdsmd.service > > but error, when run vdsClient. > > File "/usr/share/vdsm/vdsClient.py"

Re: [vdsm] Re-code /etc/init.d/functions script with Python and move it to vdsm-tool

2012-05-10 Thread Dan Kenigsberg
On Thu, May 10, 2012 at 11:36:08AM +0800, Wenyi Gao wrote: > Hi All, > > I am working on moving vdsm.init script to vdsm-tool. But the > vdsm.init script uses some of functions from /etc/init.d/functions. > So I plan to re-code the /etc/init.d/functions or part of it with > python code and also mo

Re: [vdsm] Need I set "Verified" when submitting a patch ?

2012-05-10 Thread Dan Kenigsberg
On Wed, May 09, 2012 at 05:25:23PM +0800, Mark Wu wrote: > Hi Guys, > I think people always test their patch before submitting, so > explicitly setting "verified" is not necessary. More importantly, > "verified" by the committer is not convincible //enough for code > quality assurance. Wha

Re: [vdsm] libvirtError: Cannot write data: Broken pipe when vdsm try to call libvirt

2012-05-13 Thread Dan Kenigsberg
On Sun, May 13, 2012 at 11:51:48PM +0800, Shu Ming wrote: > Hi, > Recently, I found that my host in engine was always in a > "unassigned state" after the host node was installed. After looking > into the vdsm.log, it seemed that vdsm failed to call libvirt as an > error, "libvirtError: Cannot

[vdsm] F17's libvirt takes comments into LIBVIRTD_ARGS

2012-05-16 Thread Dan Kenigsberg
On Tue, May 15, 2012 at 04:16:11PM +0800, Shu Ming wrote: > On 2012-5-14 7:30, Dan Kenigsberg wrote: > >On Sun, May 13, 2012 at 11:51:48PM +0800, Shu Ming wrote: > >>Hi, > >> Recently, I found that my host in engine was always in a > >>"unassigned state&q

Re: [vdsm] F17's libvirt takes comments into LIBVIRTD_ARGS

2012-05-16 Thread Dan Kenigsberg
On Wed, May 16, 2012 at 11:05:16PM +0800, Shu Ming wrote: > On 2012-5-16 18:46, Dan Kenigsberg wrote: > >On Tue, May 15, 2012 at 04:16:11PM +0800, Shu Ming wrote: > >>On 2012-5-14 7:30, Dan Kenigsberg wrote: > >>>On Sun, May 13, 2012 at 11:51:48PM +0800, Shu Ming wrot

Re: [vdsm] minutes: today's call

2012-05-16 Thread Dan Kenigsberg
On Wed, May 16, 2012 at 09:43:57AM -0500, Ryan Harper wrote: > * Dan Kenigsberg [2012-05-07 05:42]: > > On Mon, Apr 23, 2012 at 05:52:13PM +0300, Dan Kenigsberg wrote: > > > On Mon, Apr 23, 2012 at 07:34:14AM -0500, Adam Litke wrote: > > > > On Mon, Apr 23, 2012 a

Re: [vdsm] a problem with pepe8

2012-05-18 Thread Dan Kenigsberg
On Fri, May 18, 2012 at 06:57:10AM -0500, Adam Litke wrote: > On Fri, May 18, 2012 at 03:56:05PM +0800, ShaoHe Feng wrote: > > a comment exceed 80 characters, and it is a url link. > > such as > > # > > http:///bb///eee/f

Re: [vdsm] a problem with pepe8

2012-05-18 Thread Dan Kenigsberg
On Fri, May 18, 2012 at 09:47:43PM +0800, ShaoHe Feng wrote: > On 05/18/2012 08:30 PM, Dan Kenigsberg wrote: > >On Fri, May 18, 2012 at 06:57:10AM -0500, Adam Litke wrote: > >>On Fri, May 18, 2012 at 03:56:05PM +0800, ShaoHe Feng wrote: > >>>a comment exceed 80 cha

Re: [vdsm] why vm.create preparepath then teardown

2012-05-18 Thread Dan Kenigsberg
On Wed, May 16, 2012 at 04:07:29PM +0800, Jenna Johnson wrote: >Folks, >*** I came across a problem when starting VM, and think maybe related to >the following. >*** In API.VM.create() function, we prepareVolumePath, and then >teardownVolumePath, any idea why we handle it like t

Re: [vdsm] git-review submit question

2012-05-18 Thread Dan Kenigsberg
On Thu, May 17, 2012 at 12:46:02PM -0500, Ryan Harper wrote: > I've been using git-review -t branch to submit my patches[1], and > when I need to re-work a patch, I do that locally, and then re-submit > with git-review -t > > In most cases, not all of the patches in the series have been modified

Re: [vdsm] Agenda for today's call

2012-05-20 Thread Dan Kenigsberg
On Mon, Apr 23, 2012 at 10:41:30PM +0800, ShaoHe Feng wrote: > I wonder this call is a phone call or on an IRC channel ? Phone call. See details in http://www.ovirt.org/wiki/Meetings#Meeting_Time_and_Place ___ vdsm-devel mailing list vdsm-devel@lists.fe

Re: [vdsm] Agenda for tomorrow's call

2012-05-21 Thread Dan Kenigsberg
On Sun, May 20, 2012 at 10:55:44PM +0300, Ayal Baron wrote: > Hi all, > > I would like to discuss the following on our upcoming call: > > - reviewers are missing! > - reviewers/verifiers are missing for pep8 patches. I would like to > ask a volunteer to aggregate them all in one branch, and get

Re: [vdsm] Running commands that requires root permissions in before_vm_start hook

2012-05-21 Thread Dan Kenigsberg
On Mon, May 21, 2012 at 09:24:53AM -0400, Andrew Cathrow wrote: > > > - Original Message - > > From: "Itzik Brown" > > To: vdsm-devel@lists.fedorahosted.org > > Sent: Monday, May 21, 2012 9:07:10 AM > > Subject: [vdsm] Running commands that requires root permissions in > > before_vm_sta

Re: [vdsm] vdsm unit test error

2012-05-22 Thread Dan Kenigsberg
On Tue, May 22, 2012 at 05:02:01PM +0800, ShaoHe Feng wrote: > both mountTests and parted_utils_tests failed. Failed where? On your own host? Is it reproducible? We had a similar, but transient, problem in http://jenkins.ovirt.org/job/vdsm_unit_tests/143/console We, or some other suite using the

Re: [vdsm] vdsm unit test error

2012-05-24 Thread Dan Kenigsberg
xed in some other means? > > e > > - Original Message ----- > > From: "Dan Kenigsberg" > > To: "ShaoHe Feng" , ee...@redhat.com > > Cc: "VDSM Project Development" , "Adam > > Litke" , "Mark Wu" > >

Re: [vdsm] vdsm unit test error

2012-05-25 Thread Dan Kenigsberg
On Fri, May 25, 2012 at 02:59:31AM +0800, ShaoHe Feng wrote: > On 05/23/2012 03:52 AM, Dan Kenigsberg wrote: > >On Tue, May 22, 2012 at 05:02:01PM +0800, ShaoHe Feng wrote: > >>both mountTests and parted_utils_tests failed. > >Failed where? On your own host? Is it reprod

Re: [vdsm] Solution Re: [node-devel] Still not abel to migrate to node

2012-05-27 Thread Dan Kenigsberg
On Fri, May 25, 2012 at 02:44:19PM +0200, Michel van Horssen wrote: > Okay, > > Jacob Wyatt gave the solution. Make sure that in /etc/libvirt/libvirtd.conf > the line with "listen_tls = 0" > > So > > listen_tls = 0 > > becomes > > # listen_tls = 0 > > Do this also in /config/etc/libvirt/libv

Re: [vdsm] vdsm unit test error

2012-05-27 Thread Dan Kenigsberg
On Fri, May 25, 2012 at 05:40:15PM +0800, ShaoHe Feng wrote: > On 05/25/2012 04:52 PM, Dan Kenigsberg wrote: > >On Fri, May 25, 2012 at 02:59:31AM +0800, ShaoHe Feng wrote: > >>On 05/23/2012 03:52 AM, Dan Kenigsberg wrote: > >>>On Tue, May 22, 2012 at 05:02

Re: [vdsm] Move some of code from spec file into vdsm-tool function issue

2012-05-28 Thread Dan Kenigsberg
On Mon, May 28, 2012 at 04:35:26PM +0100, Daniel P. Berrange wrote: > On Mon, May 28, 2012 at 11:33:15AM -0400, Federico Simoncelli wrote: > > - Original Message - > > > From: "Daniel P. Berrange" > > > To: "Federico Simoncelli" > > &

Re: [vdsm] setgroup/setuid affects libvirt event loop results in connection broken

2012-05-30 Thread Dan Kenigsberg
On Wed, May 30, 2012 at 10:28:29PM +0800, Royce Lv wrote: > Guys, > In debugging vdsm/supervdsm process I noticed that event loop in > libvirtev.py will be affected by setgroups/setgid/setuid. Results in > libvirtd close connection because the keepalive scheme fals.Follow up vdsm > to libvirt

Re: [vdsm] VDSM API/clientIF instance design issue

2012-05-30 Thread Dan Kenigsberg
On Wed, May 30, 2012 at 10:49:29PM +0800, Mark Wu wrote: > Hi Guys, > > Recently, I has been working on integrate MOM into VDSM. MOM needs > to use VDSM API to interact with it. But currently, it requires the > instance of clientIF to use vdsm API. Passing clientIF to MOM is > not a good choic

Re: [vdsm] Change in vdsm[master]: tests: fix gluster storage exception test

2012-05-30 Thread Dan Kenigsberg
On Tue, May 29, 2012 at 09:07:25PM -0500, Ryan Harper wrote: > * dan...@redhat.com [2012-05-29 09:29]: > > Dan Kenigsberg has posted comments on this change. > > > > Change subject: tests: fix gluster s

Re: [vdsm] Change in vdsm[master]: tests: fix gluster storage exception test

2012-05-31 Thread Dan Kenigsberg
On Wed, May 30, 2012 at 11:11:35AM -0500, Ryan Harper wrote: > * Dan Kenigsberg [2012-05-30 10:43]: > > On Tue, May 29, 2012 at 09:07:25PM -0500, Ryan Harper wrote: > > > * dan...@redhat.com [2012-05-29 09:29]: > > > > Dan Kenigsberg has posted comments on this c

Re: [vdsm] VDSM API/clientIF instance design issue

2012-05-31 Thread Dan Kenigsberg
On Thu, May 31, 2012 at 09:03:37PM +0800, Mark Wu wrote: > On 05/30/2012 11:01 PM, Dan Kenigsberg wrote: > >On Wed, May 30, 2012 at 10:49:29PM +0800, Mark Wu wrote: > >>Hi Guys, > >> > >>Recently, I has been working on integrate MOM into VDSM. MOM needs >

  1   2   3   4   5   >